1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
|
// Copyright 2025 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/tabs/public/tab_dialog_manager.h"
#include <memory>
#include <utility>
#include "base/memory/raw_ptr.h"
#include "base/test/bind.h"
#include "chrome/browser/ui/tabs/public/tab_features.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/test/test_browser_dialog.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "chrome/test/interaction/interactive_browser_test.h"
#include "components/tabs/public/tab_interface.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "ui/base/interaction/polling_state_observer.h"
#include "ui/base/models/dialog_model.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/size.h"
#include "ui/views/background.h"
#include "ui/views/bubble/bubble_dialog_model_host.h"
#include "ui/views/controls/label.h"
#include "ui/views/view_class_properties.h"
#include "ui/views/window/dialog_delegate.h"
namespace tabs {
namespace {
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kWidgetContentsViewElementId);
DEFINE_LOCAL_STATE_IDENTIFIER_VALUE(ui::test::PollingStateObserver<gfx::Rect>,
kWidgetBoundsState);
std::unique_ptr<views::Widget> CreateWidgetWithNoNonClientView() {
auto content_view = std::make_unique<views::View>();
content_view->SetPreferredSize(gfx::Size(500, 500));
content_view->SetBackground(views::CreateSolidBackground(SK_ColorBLUE));
views::Widget::InitParams widget_params(
views::Widget::InitParams::Ownership::CLIENT_OWNS_WIDGET,
views::Widget::InitParams::Type::TYPE_WINDOW_FRAMELESS);
widget_params.bounds = gfx::Rect({0, 0}, content_view->GetPreferredSize());
auto widget = std::make_unique<views::Widget>();
widget->Init(std::move(widget_params));
CHECK_EQ(widget->non_client_view(), nullptr);
content_view->SetProperty(views::kElementIdentifierKey,
kWidgetContentsViewElementId);
widget->SetContentsView(std::move(content_view));
return widget;
}
std::unique_ptr<views::Widget> CreateAutoresizeWidget() {
auto content_view = std::make_unique<views::View>();
content_view->SetPreferredSize(gfx::Size(500, 500));
content_view->SetBackground(views::CreateSolidBackground(SK_ColorBLUE));
views::Widget::InitParams widget_params(
views::Widget::InitParams::Ownership::CLIENT_OWNS_WIDGET,
views::Widget::InitParams::Type::TYPE_WINDOW_FRAMELESS);
widget_params.bounds = gfx::Rect({0, 0}, content_view->GetPreferredSize());
widget_params.autosize = true;
auto widget = std::make_unique<views::Widget>();
widget->Init(std::move(widget_params));
CHECK_EQ(widget->non_client_view(), nullptr);
content_view->SetProperty(views::kElementIdentifierKey,
kWidgetContentsViewElementId);
widget->SetContentsView(std::move(content_view));
return widget;
}
std::unique_ptr<views::Widget> CreateWidgetWithDialogModel() {
ui::DialogModel::Builder dialog_builder;
dialog_builder.SetTitle(u"Test Dialog Model")
.AddParagraph(ui::DialogModelLabel(u"This is a test dialog."), u"",
kWidgetContentsViewElementId)
.AddOkButton(base::DoNothing(),
ui::DialogModel::Button::Params().SetLabel(u"OK"));
auto dialog_model = dialog_builder.Build();
auto bubble_delegate = std::make_unique<views::BubbleDialogModelHost>(
std::move(dialog_model), /*anchor_view=*/nullptr,
views::BubbleBorder::NONE);
views::Widget::InitParams widget_params(
views::Widget::InitParams::Ownership::CLIENT_OWNS_WIDGET,
views::Widget::InitParams::Type::TYPE_BUBBLE);
auto widget = std::make_unique<views::Widget>();
// BubbleDialogModelHost is owned by the widget.
widget_params.delegate = bubble_delegate.release();
// Views-drawn shadows needs a translucent widget background.
widget_params.opacity =
views::Widget::InitParams::WindowOpacity::kTranslucent;
widget->Init(std::move(widget_params));
return widget;
}
} // namespace
class TabDialogManagerBrowserTest : public InteractiveBrowserTest {
public:
TabDialogManagerBrowserTest() = default;
~TabDialogManagerBrowserTest() override = default;
TabDialogManagerBrowserTest(const TabDialogManagerBrowserTest&) = delete;
TabDialogManagerBrowserTest& operator=(const TabDialogManagerBrowserTest&) =
delete;
protected:
TabDialogManager* GetTabDialogManager() {
TabInterface* tab_interface = browser()->GetActiveTabInterface();
CHECK(tab_interface);
return tab_interface->GetTabFeatures()->tab_dialog_manager();
}
void SetUpOnMainThread() override {
InteractiveBrowserTest::SetUpOnMainThread();
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(embedded_test_server()->InitializeAndListen());
embedded_test_server()->StartAcceptingConnections();
}
};
// Tests that a widget that does not have a non-client view can be shown without
// crashing.
IN_PROC_BROWSER_TEST_F(TabDialogManagerBrowserTest,
ShowWidgetThatHasNoNonClientView) {
std::unique_ptr<views::Widget> widget;
RunTestSequence(
Do([&]() { widget = CreateWidgetWithNoNonClientView(); }),
Do([&, this]() {
TabDialogManager* manager = GetTabDialogManager();
manager->ShowDialog(widget.get(),
std::make_unique<tabs::TabDialogManager::Params>());
}),
InAnyContext(WaitForShow(kWidgetContentsViewElementId)),
CheckResult([&]() { return widget && widget->IsVisible(); }, true,
"Verify widget is visible"));
}
IN_PROC_BROWSER_TEST_F(TabDialogManagerBrowserTest, ShowDialogModel) {
std::unique_ptr<views::Widget> widget;
RunTestSequence(
Do([&]() { widget = CreateWidgetWithDialogModel(); }), Do([&, this]() {
TabDialogManager* manager = GetTabDialogManager();
manager->ShowDialog(widget.get(),
std::make_unique<tabs::TabDialogManager::Params>());
}),
InAnyContext(WaitForShow(kWidgetContentsViewElementId)),
CheckResult([&]() { return widget->IsVisible(); }, true,
"Verify widget is visible"));
}
// Tests that the widget is closed on cross-site navigation if
// TabDialogManager::Params::close_on_navigate is true.
IN_PROC_BROWSER_TEST_F(TabDialogManagerBrowserTest,
Parmas_close_on_navigate_true_CrossSiteNavigation) {
std::unique_ptr<views::Widget> widget_ptr;
const GURL kInitialUrl =
embedded_test_server()->GetURL("foo.com", "/title1.html");
const GURL kDifferentSiteUrl =
embedded_test_server()->GetURL("bar.com", "/title2.html");
RunTestSequence(
Do([&]() {
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), kInitialUrl));
}),
Do([&]() { widget_ptr = CreateWidgetWithNoNonClientView(); }),
Do([&, this]() {
TabDialogManager* manager = GetTabDialogManager();
auto params = std::make_unique<tabs::TabDialogManager::Params>();
params->close_on_navigate = true;
manager->ShowDialog(widget_ptr.get(), std::move(params));
}),
InAnyContext(WaitForShow(kWidgetContentsViewElementId)),
CheckResult([&]() { return widget_ptr && widget_ptr->IsVisible(); }, true,
"Verify widget is initially visible"),
Do([&]() {
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), kDifferentSiteUrl));
}),
InAnyContext(WaitForHide(kWidgetContentsViewElementId)));
}
// Tests that the widget is not closed on same-site navigation if
// TabDialogManager::Params::close_on_navigate is true.
IN_PROC_BROWSER_TEST_F(TabDialogManagerBrowserTest,
Parmas_close_on_navigate_true_SameSiteNavigation) {
std::unique_ptr<views::Widget> widget_ptr;
const GURL kInitialUrl =
embedded_test_server()->GetURL("foo.com", "/title1.html");
const GURL kSameSiteUrl =
embedded_test_server()->GetURL("foo.com", "/title2.html");
RunTestSequence(
Do([&]() {
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), kInitialUrl));
}),
Do([&]() { widget_ptr = CreateWidgetWithNoNonClientView(); }),
Do([&, this]() {
TabDialogManager* manager = GetTabDialogManager();
auto params = std::make_unique<tabs::TabDialogManager::Params>();
params->close_on_navigate = true;
manager->ShowDialog(widget_ptr.get(), std::move(params));
}),
InAnyContext(WaitForShow(kWidgetContentsViewElementId)),
CheckResult([&]() { return widget_ptr && widget_ptr->IsVisible(); }, true,
"Verify widget is initially visible"),
Do([&]() {
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), kSameSiteUrl));
}),
InAnyContext(EnsurePresent(kWidgetContentsViewElementId)));
}
// Tests that the widget is not closed on cross-site navigation if
// TabDialogManager::Params::close_on_navigate is false.
IN_PROC_BROWSER_TEST_F(TabDialogManagerBrowserTest,
Parmas_close_on_navigate_false_CrossSiteNavigation) {
std::unique_ptr<views::Widget> widget_ptr;
const GURL kInitialUrl =
embedded_test_server()->GetURL("foo.com", "/title1.html");
const GURL kDifferentSiteUrl =
embedded_test_server()->GetURL("bar.com", "/title2.html");
RunTestSequence(
Do([&]() {
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), kInitialUrl));
}),
Do([&]() { widget_ptr = CreateWidgetWithNoNonClientView(); }),
Do([&, this]() {
TabDialogManager* manager = GetTabDialogManager();
auto params = std::make_unique<tabs::TabDialogManager::Params>();
params->close_on_navigate = false;
manager->ShowDialog(widget_ptr.get(), std::move(params));
}),
InAnyContext(WaitForShow(kWidgetContentsViewElementId)),
CheckResult([&]() { return widget_ptr && widget_ptr->IsVisible(); }, true,
"Verify widget is initially visible"),
Do([&]() {
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), kDifferentSiteUrl));
}),
InAnyContext(EnsurePresent(kWidgetContentsViewElementId)));
}
// Tests that the widget is repositioned after its preferred size is changed.
IN_PROC_BROWSER_TEST_F(TabDialogManagerBrowserTest,
ChangePreferredSizeAfterShow) {
std::unique_ptr<views::Widget> widget;
// `kInitialSize` is the same as the size defined in CreateAutoresizeWidget().
const gfx::Size kInitialSize(500, 500);
const gfx::Size kNewSize(200, 200);
gfx::Point initial_origin;
RunTestSequence(
Do([&, this]() {
widget = CreateAutoresizeWidget();
GetTabDialogManager()->ShowDialog(
widget.get(), std::make_unique<tabs::TabDialogManager::Params>());
}),
InAnyContext(WaitForShow(kWidgetContentsViewElementId)),
CheckResult([&]() { return widget && widget->IsVisible(); }, true,
"Verify widget is visible"),
CheckResult(
[&]() { return widget->GetClientAreaBoundsInScreen().size(); },
kInitialSize, "Verify initial size"),
Do([&]() {
initial_origin = widget->GetClientAreaBoundsInScreen().origin();
widget->GetContentsView()->SetPreferredSize(kNewSize);
}),
CheckResult(
[&]() { return widget->GetClientAreaBoundsInScreen().size(); },
kNewSize, "Verify new size"),
Check(
[&]() {
return widget->GetClientAreaBoundsInScreen().origin() !=
initial_origin;
},
"Verify origin is updated"));
}
// Tests that the widget is repositioned after its preferred size is changed
// when `Params::animated` is true.
IN_PROC_BROWSER_TEST_F(TabDialogManagerBrowserTest, AnimatedBoundsChange) {
std::unique_ptr<views::Widget> widget;
// `kInitialSize` is the same as the size defined in
// CreateWidgetWithNoNonClientView().
const gfx::Size kInitialSize(500, 500);
const gfx::Size kNewSize(200, 200);
gfx::Rect initial_bounds;
RunTestSequence(
Do([&, this]() {
widget = CreateWidgetWithNoNonClientView();
TabDialogManager* manager = GetTabDialogManager();
auto params = std::make_unique<tabs::TabDialogManager::Params>();
params->animated = true;
manager->ShowDialog(widget.get(), std::move(params));
}),
InAnyContext(WaitForShow(kWidgetContentsViewElementId)),
CheckResult([&]() { return widget && widget->IsVisible(); }, true,
"Verify widget is visible"),
CheckResult(
[&]() { return widget->GetClientAreaBoundsInScreen().size(); },
kInitialSize, "Verify initial size"),
Do([&]() { initial_bounds = widget->GetClientAreaBoundsInScreen(); }),
PollState(
kWidgetBoundsState,
[&widget]() { return widget->GetClientAreaBoundsInScreen(); }),
Do([&]() {
widget->GetContentsView()->SetPreferredSize(kNewSize);
// With animated=true and autosize=false, we must manually update
// bounds.
GetTabDialogManager()->UpdateModalDialogBounds();
}),
WaitForState(kWidgetBoundsState,
testing::AllOf(testing::Property(&gfx::Rect::size, kNewSize),
testing::Property(
&gfx::Rect::origin,
testing::Ne(initial_bounds.origin())))));
}
class TabDialogManagerPixelTest : public DialogBrowserTest {
public:
TabDialogManagerPixelTest() = default;
~TabDialogManagerPixelTest() override = default;
TabDialogManagerPixelTest(const TabDialogManagerPixelTest&) = delete;
TabDialogManagerPixelTest& operator=(const TabDialogManagerPixelTest&) =
delete;
// DialogBrowserTest:
void ShowUi(const std::string& name) override {
TabInterface* tab_interface = browser()->GetActiveTabInterface();
CHECK(tab_interface);
TabDialogManager* manager =
tab_interface->GetTabFeatures()->tab_dialog_manager();
widget_ = CreateWidgetWithDialogModel();
manager->ShowDialog(widget_.get(),
std::make_unique<tabs::TabDialogManager::Params>());
}
void TearDownOnMainThread() override {
widget_.reset();
DialogBrowserTest::TearDownOnMainThread();
}
private:
std::unique_ptr<views::Widget> widget_;
};
IN_PROC_BROWSER_TEST_F(TabDialogManagerPixelTest, InvokeUi_default) {
ShowAndVerifyUi();
}
} // namespace tabs
|
