1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
|
// Copyright 2025 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/page_action/page_action_model.h"
#include "base/types/pass_key.h"
#include "chrome/browser/ui/views/page_action/page_action_controller.h"
#include "chrome/browser/ui/views/page_action/page_action_model_observer.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/actions/actions.h"
#include "ui/gfx/image/image_unittest_util.h"
namespace page_actions {
namespace {
using ::actions::ActionItem;
const std::u16string kOverrideText = u"Override";
const std::u16string kTestText = u"Test";
const std::u16string kTooltipText = u"Tooltip";
const std::u16string kDefaultText = u"DefaultName";
const std::u16string kOverrideName = u"OverrideName";
const ui::ImageModel kTestImage =
ui::ImageModel::FromImageSkia(gfx::test::CreateImageSkia(/*size=*/16));
base::PassKey<PageActionController> PassKey() {
return PageActionController::PassKeyForTesting();
}
class MockPageActionModelObserver : public PageActionModelObserver {
public:
MOCK_METHOD(void,
OnPageActionModelChanged,
(const PageActionModelInterface& model),
(override));
MOCK_METHOD(void,
OnPageActionModelWillBeDeleted,
(const PageActionModelInterface& model),
(override));
};
class PageActionModelTest : public ::testing::Test {
protected:
void SetUp() override { model_.AddObserver(&observer_); }
void TearDown() override { model_.RemoveObserver(&observer_); }
PageActionModel model_;
testing::NiceMock<MockPageActionModelObserver> observer_;
};
TEST_F(PageActionModelTest, DefaultVisibility) {
EXPECT_FALSE(model_.GetVisible());
}
TEST_F(PageActionModelTest, VisibilityConditions) {
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(4);
model_.SetShowRequested(PassKey(), true);
EXPECT_FALSE(model_.GetVisible());
model_.SetActionItemProperties(
PassKey(),
ActionItem::Builder().SetEnabled(true).SetVisible(true).Build().get());
EXPECT_FALSE(model_.GetVisible());
model_.SetTabActive(PassKey(), true);
EXPECT_TRUE(model_.GetVisible());
model_.SetHasPinnedIcon(PassKey(), true);
EXPECT_FALSE(model_.GetVisible());
}
TEST_F(PageActionModelTest, ShouldChipBeVisible) {
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(2);
model_.SetShouldShowSuggestionChip(PassKey(), true);
EXPECT_EQ(model_.ShouldShowSuggestionChip(), true);
model_.SetShouldShowSuggestionChip(PassKey(), false);
EXPECT_EQ(model_.ShouldShowSuggestionChip(), false);
}
TEST_F(PageActionModelTest, ChipVisibility) {
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(2);
model_.SetIsChipShowing(PassKey(), true);
EXPECT_EQ(model_.IsChipShowing(), true);
model_.SetIsChipShowing(PassKey(), false);
EXPECT_EQ(model_.IsChipShowing(), false);
}
TEST_F(PageActionModelTest, ShouldAnnounceChip) {
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetSuggestionChipConfig(PassKey(), {.should_announce_chip = true});
EXPECT_EQ(model_.GetShouldAnnounceChip(), true);
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetSuggestionChipConfig(PassKey(), {.should_announce_chip = false});
EXPECT_EQ(model_.GetShouldAnnounceChip(), false);
}
TEST_F(PageActionModelTest, OverrideText) {
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(2);
model_.SetOverrideText(PassKey(), kOverrideText);
EXPECT_EQ(model_.GetText(), kOverrideText);
model_.SetOverrideText(PassKey(), std::nullopt);
EXPECT_EQ(model_.GetText(), std::u16string());
}
TEST_F(PageActionModelTest, OverrideImage) {
model_.SetActionItemProperties(
PassKey(), ActionItem::Builder().SetImage(kTestImage).Build().get());
EXPECT_EQ(model_.GetImage(), kTestImage);
ui::ImageModel kOverrideImage =
ui::ImageModel::FromImageSkia(gfx::test::CreateImageSkia(/*size=*/32));
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetOverrideImage(PassKey(), kOverrideImage);
EXPECT_EQ(model_.GetImage(), kOverrideImage);
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetOverrideImage(PassKey(), std::nullopt);
EXPECT_EQ(model_.GetImage(), kTestImage);
}
TEST_F(PageActionModelTest, OverrideTooltip) {
auto action_item = ActionItem::Builder().SetTooltipText(kTooltipText).Build();
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetActionItemProperties(PassKey(), action_item.get());
EXPECT_EQ(model_.GetTooltipText(), kTooltipText);
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetOverrideTooltip(PassKey(), kOverrideText);
EXPECT_EQ(model_.GetTooltipText(), kOverrideText);
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetOverrideTooltip(PassKey(), std::nullopt);
EXPECT_EQ(model_.GetTooltipText(), kTooltipText);
}
TEST_F(PageActionModelTest, SetActionItemProperties) {
// NOTE: The visibility is exercised by the test VisibilityConditions.
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetActionItemProperties(PassKey(), ActionItem::Builder()
.SetText(kTestText)
.SetTooltipText(kTooltipText)
.SetImage(kTestImage)
.SetIsShowingBubble(true)
.Build()
.get());
EXPECT_EQ(model_.GetText(), kTestText);
EXPECT_EQ(model_.GetImage(), kTestImage);
EXPECT_EQ(model_.GetTooltipText(), kTooltipText);
EXPECT_EQ(model_.GetActionItemIsShowingBubble(), true);
}
TEST_F(PageActionModelTest, ShouldHidePageAction) {
model_.SetShowRequested(PassKey(), true);
model_.SetActionItemProperties(
PassKey(),
ActionItem::Builder().SetEnabled(true).SetVisible(true).Build().get());
model_.SetTabActive(PassKey(), true);
// Confirm it's now visible by default.
EXPECT_TRUE(model_.GetVisible());
// Because we know we are about to toggle “hide” on and off once,
// we expect 2 calls to OnPageActionModelChanged():
// 1) false->true => triggers a notify
// 2) true->false => triggers a notify
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(2);
model_.SetShouldHidePageAction(PassKey(), true);
EXPECT_FALSE(model_.GetVisible());
model_.SetShouldHidePageAction(PassKey(), false);
EXPECT_TRUE(model_.GetVisible());
}
TEST_F(PageActionModelTest, OverrideAccessibleName) {
// Set the default accessible name through SetActionItemProperties.
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetActionItemProperties(
PassKey(), ActionItem::Builder().SetText(kDefaultText).Build().get());
EXPECT_EQ(model_.GetAccessibleName(), kDefaultText);
// Set the override name — should notify and change value.
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetOverrideAccessibleName(PassKey(), kOverrideName);
EXPECT_EQ(model_.GetAccessibleName(), kOverrideName);
// Clear the override — should notify and fallback to default.
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetOverrideAccessibleName(PassKey(), std::nullopt);
EXPECT_EQ(model_.GetAccessibleName(), kDefaultText);
}
TEST_F(PageActionModelTest, ActionActive) {
// Default state should be inactive.
EXPECT_FALSE(model_.GetActionActive());
// Setting active should notify and update the state.
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetActionActive(PassKey(), true);
EXPECT_TRUE(model_.GetActionActive());
testing::Mock::VerifyAndClearExpectations(&observer_);
// Setting active again should not notify or change the state.
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(0);
model_.SetActionActive(PassKey(), true);
EXPECT_TRUE(model_.GetActionActive());
testing::Mock::VerifyAndClearExpectations(&observer_);
// Setting inactive should notify and update the state.
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(1);
model_.SetActionActive(PassKey(), false);
EXPECT_FALSE(model_.GetActionActive());
testing::Mock::VerifyAndClearExpectations(&observer_);
// Setting inactive again should not notify or change the state.
EXPECT_CALL(observer_, OnPageActionModelChanged).Times(0);
model_.SetActionActive(PassKey(), false);
EXPECT_FALSE(model_.GetActionActive());
testing::Mock::VerifyAndClearExpectations(&observer_);
}
} // namespace
} // namespace page_actions
|
