1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/omnibox/browser/omnibox_popup_selection.h"
#include <stddef.h>
#include <memory>
#include <string>
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "build/build_config.h"
#include "components/omnibox/browser/autocomplete_match.h"
#include "components/omnibox/browser/autocomplete_result.h"
#include "components/omnibox/browser/fake_autocomplete_provider_client.h"
#include "components/omnibox/browser/mock_aim_eligibility_service.h"
#include "components/omnibox/browser/test_omnibox_client.h"
#include "components/omnibox/common/omnibox_features.h"
#include "components/prefs/testing_pref_service.h"
#include "components/search_engines/template_url_service.h"
#include "testing/gtest/include/gtest/gtest.h"
using LineState = OmniboxPopupSelection::LineState;
using Direction = OmniboxPopupSelection::Direction;
using Step = OmniboxPopupSelection::Step;
class OmniboxPopupSelectionTest : public testing::Test {
public:
AutocompleteProviderClient* client() { return &client_; }
void SetAimEligibility(bool eligibility) {
MockAimEligibilityService* mock_aim_eligibility_service =
static_cast<MockAimEligibilityService*>(
client_.GetAimEligibilityService());
EXPECT_CALL(*mock_aim_eligibility_service, IsServerEligibilityEnabled())
.WillRepeatedly(testing::Return(eligibility));
EXPECT_CALL(*mock_aim_eligibility_service, IsAimLocallyEligible())
.WillRepeatedly(testing::Return(eligibility));
EXPECT_CALL(*mock_aim_eligibility_service, IsAimEligible())
.WillRepeatedly(testing::Return(eligibility));
}
protected:
void SetUp() override {}
void TearDown() override { SetAimEligibility(false); }
private:
FakeAutocompleteProviderClient client_;
base::test::TaskEnvironment task_environment_;
};
// Desktop has special selection handling for starter pack keyword mode.
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
TEST_F(OmniboxPopupSelectionTest, SelectionWithKeywordMode) {
const std::u16string test_keyword = u"@bookmarks";
TestOmniboxClient client;
CHECK(client.GetTemplateURLService());
client.GetTemplateURLService()->Load();
client.GetTemplateURLService()->RepairStarterPackEngines();
CHECK(client.GetTemplateURLService()->GetTemplateURLForKeyword(test_keyword));
TestingPrefServiceSimple pref_service;
AutocompleteInput input;
AutocompleteResult result;
result.AppendMatches({
{nullptr, 1000, false, AutocompleteMatchType::SEARCH_SUGGEST},
{nullptr, 900, false, AutocompleteMatchType::STARTER_PACK},
{nullptr, 800, false, AutocompleteMatchType::HISTORY_EMBEDDINGS},
});
result.match_at(1u)->associated_keyword = std::make_unique<AutocompleteMatch>(
nullptr, 1000, false, AutocompleteMatchType::SEARCH_WHAT_YOU_TYPED);
result.match_at(1u)->associated_keyword->keyword = test_keyword;
auto autocomplete_provider_client = client.CreateAutocompleteProviderClient();
OmniboxPopupSelection next = OmniboxPopupSelection(0u).GetNextSelection(
input, result, client.GetTemplateURLService(),
autocomplete_provider_client.get(), Direction::kForward,
Step::kWholeLine);
EXPECT_EQ(next.line, 1u);
EXPECT_EQ(next.state, LineState::KEYWORD_MODE);
next = OmniboxPopupSelection(0u).GetNextSelection(
input, result, client.GetTemplateURLService(),
autocomplete_provider_client.get(), Direction::kForward,
Step::kStateOrLine);
EXPECT_EQ(next.line, 1u);
EXPECT_EQ(next.state, LineState::KEYWORD_MODE);
next = OmniboxPopupSelection(1u, LineState::KEYWORD_MODE)
.GetNextSelection(input, result, client.GetTemplateURLService(),
autocomplete_provider_client.get(),
Direction::kForward, Step::kWholeLine);
EXPECT_EQ(next.line, 2u);
EXPECT_EQ(next.state, LineState::NORMAL);
next = OmniboxPopupSelection(1u, LineState::KEYWORD_MODE)
.GetNextSelection(input, result, client.GetTemplateURLService(),
autocomplete_provider_client.get(),
Direction::kForward, Step::kStateOrLine);
EXPECT_EQ(next.line, 2u);
EXPECT_EQ(next.state, LineState::NORMAL);
next = OmniboxPopupSelection(2u).GetNextSelection(
input, result, client.GetTemplateURLService(),
autocomplete_provider_client.get(), Direction::kForward,
Step::kWholeLine);
EXPECT_EQ(next.line, 0u);
EXPECT_EQ(next.state, LineState::NORMAL);
next = OmniboxPopupSelection(2u).GetNextSelection(
input, result, client.GetTemplateURLService(),
autocomplete_provider_client.get(), Direction::kForward,
Step::kStateOrLine);
EXPECT_EQ(next.line, 2u);
EXPECT_EQ(next.state, LineState::FOCUSED_BUTTON_THUMBS_UP);
next = OmniboxPopupSelection(2u, LineState::FOCUSED_BUTTON_THUMBS_UP)
.GetNextSelection(input, result, client.GetTemplateURLService(),
autocomplete_provider_client.get(),
Direction::kForward, Step::kStateOrLine);
EXPECT_EQ(next.line, 2u);
EXPECT_EQ(next.state, LineState::FOCUSED_BUTTON_THUMBS_DOWN);
next = OmniboxPopupSelection(2u, LineState::FOCUSED_BUTTON_THUMBS_DOWN)
.GetNextSelection(input, result, client.GetTemplateURLService(),
autocomplete_provider_client.get(),
Direction::kForward, Step::kStateOrLine);
EXPECT_EQ(next.line, 0u);
EXPECT_EQ(next.state, LineState::NORMAL);
}
TEST_F(OmniboxPopupSelectionTest, SelectionWithAIMButton) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(omnibox::kAiModeOmniboxEntryPoint);
SetAimEligibility(true);
AutocompleteInput input;
AutocompleteResult result;
result.AppendMatches({
{nullptr, 1000, false, AutocompleteMatchType::SEARCH_SUGGEST},
{nullptr, 900, false, AutocompleteMatchType::HISTORY_URL},
{nullptr, 800, false, AutocompleteMatchType::HISTORY_TITLE},
});
// In the typed input (non-zero suggest) case, the first match in the list
// will be selected by default.
OmniboxPopupSelection initial{0u, LineState::NORMAL};
{
// Whole line stepping should skip the AIM button and just select the next
// match.
OmniboxPopupSelection next = initial.GetNextSelection(
input, result, /*template_url_service=*/nullptr,
/*client=*/client(), Direction::kForward, Step::kWholeLine);
EXPECT_EQ(next.line, 1u);
EXPECT_EQ(next.state, LineState::NORMAL);
}
{
// "Line or state" stepping should focus the AIM button associated with the
// first match.
OmniboxPopupSelection next = initial.GetNextSelection(
input, result, /*template_url_service=*/nullptr,
/*client=*/client(), Direction::kForward, Step::kStateOrLine);
EXPECT_EQ(next.line, 0u);
EXPECT_EQ(next.state, LineState::FOCUSED_BUTTON_AIM);
// Then move to the next regular match.
next = next.GetNextSelection(
input, result, /*template_url_service=*/nullptr,
/*client=*/client(), Direction::kForward, Step::kStateOrLine);
EXPECT_EQ(next.line, 1u);
EXPECT_EQ(next.state, LineState::NORMAL);
// And then the one after that.
next = next.GetNextSelection(
input, result, /*template_url_service=*/nullptr,
/*client=*/client(), Direction::kForward, Step::kStateOrLine);
EXPECT_EQ(next.line, 2u);
EXPECT_EQ(next.state, LineState::NORMAL);
}
}
TEST_F(OmniboxPopupSelectionTest, SelectionWithAIMButtonZeroInput) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(omnibox::kAiModeOmniboxEntryPoint);
SetAimEligibility(true);
AutocompleteInput input;
// INTERACTION_FOCUS indicates that there is no user input.
input.set_focus_type(metrics::OmniboxFocusType::INTERACTION_FOCUS);
AutocompleteResult result;
result.AppendMatches({
{nullptr, 1000, false, AutocompleteMatchType::SEARCH_SUGGEST},
{nullptr, 900, false, AutocompleteMatchType::HISTORY_URL},
{nullptr, 800, false, AutocompleteMatchType::HISTORY_TITLE},
});
// In the zero suggest case, there is no default match, which is represented
// by a `line` value of `kNoMatch`.
OmniboxPopupSelection initial{OmniboxPopupSelection::kNoMatch,
LineState::NORMAL};
{
// Whole line stepping should skip the AIM button and just select the first
// match.
OmniboxPopupSelection next = initial.GetNextSelection(
input, result, /*template_url_service=*/nullptr,
/*client=*/client(), Direction::kForward, Step::kWholeLine);
EXPECT_EQ(next.line, 0u);
EXPECT_EQ(next.state, LineState::NORMAL);
}
{
// "Line or state" stepping should focus the AIM button, which is first in
// the selection order when we're in zero suggest state.
OmniboxPopupSelection next = initial.GetNextSelection(
input, result, /*template_url_service=*/nullptr,
/*client=*/client(), Direction::kForward, Step::kStateOrLine);
EXPECT_EQ(next.line, OmniboxPopupSelection::kNoMatch);
EXPECT_EQ(next.state, LineState::FOCUSED_BUTTON_AIM);
// Then move to the first regular match.
next = next.GetNextSelection(
input, result, /*template_url_service=*/nullptr,
/*client=*/client(), Direction::kForward, Step::kStateOrLine);
EXPECT_EQ(next.line, 0u);
EXPECT_EQ(next.state, LineState::NORMAL);
// And then the one after that.
next = next.GetNextSelection(
input, result, /*template_url_service=*/nullptr,
/*client=*/client(), Direction::kForward, Step::kStateOrLine);
EXPECT_EQ(next.line, 1u);
EXPECT_EQ(next.state, LineState::NORMAL);
}
}
#endif
|
