1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/web_applications/web_app_install_utils.h"
#include <stddef.h>
#include <map>
#include <memory>
#include <optional>
#include <set>
#include <string>
#include <type_traits>
#include <utility>
#include <variant>
#include <vector>
#include "base/containers/flat_map.h"
#include "base/containers/flat_set.h"
#include "base/feature_list.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "build/buildflag.h"
#include "chrome/browser/web_applications/os_integration/os_integration_manager.h"
#include "chrome/browser/web_applications/os_integration/web_app_file_handler_manager.h"
#include "chrome/browser/web_applications/test/web_app_icon_test_utils.h"
#include "chrome/browser/web_applications/web_app.h"
#include "chrome/browser/web_applications/web_app_constants.h"
#include "chrome/browser/web_applications/web_app_helpers.h"
#include "chrome/browser/web_applications/web_app_icon_generator.h"
#include "chrome/browser/web_applications/web_app_install_info.h"
#include "components/services/app_service/public/cpp/icon_info.h"
#include "components/services/app_service/public/cpp/protocol_handler_info.h"
#include "components/services/app_service/public/cpp/share_target.h"
#include "mojo/public/cpp/bindings/struct_ptr.h"
#include "services/network/public/cpp/permissions_policy/origin_with_possible_wildcards.h"
#include "services/network/public/cpp/permissions_policy/permissions_policy_declaration.h"
#include "services/network/public/mojom/permissions_policy/permissions_policy_feature.mojom-shared.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/features.h"
#include "third_party/blink/public/common/manifest/manifest.h"
#include "third_party/blink/public/mojom/manifest/display_mode.mojom-shared.h"
#include "third_party/blink/public/mojom/manifest/manifest.mojom-shared.h"
#include "third_party/blink/public/mojom/manifest/manifest.mojom.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/image/image_unittest_util.h"
#include "ui/gfx/skia_util.h"
#include "url/gurl.h"
#include "url/origin.h"
namespace web_app {
using Purpose = blink::mojom::ManifestImageResource_Purpose;
namespace {
const char16_t kShortcutItemTestName[] = u"shortcut item ";
constexpr SquareSizePx kIconSize = 64;
GURL StartUrl() {
return GURL("https://www.example.com/index.html");
}
// Returns a stack-allocated WebAppInstallInfo with `StartUrl()` as the
// start_url and manifest_id. Needed to migrate existing tests from the default
// constructor. Prefer to instead use
// WebAppInstallInfo::CreateWithStartUrlForTesting when adding new tests.
WebAppInstallInfo CreateWebAppInstallInfo() {
return WebAppInstallInfo(GenerateManifestIdFromStartUrlOnly(StartUrl()),
StartUrl());
}
// Returns a stack-allocated WebAppInstallInfo. Needed to migrate existing tests
// from the default constructor. Prefer to instead use
// WebAppInstallInfo::CreateWithStartUrlForTesting when adding new tests.
WebAppInstallInfo CreateWebAppInstallInfoFromStartUrl(const GURL& start_url) {
return WebAppInstallInfo(GenerateManifestIdFromStartUrlOnly(start_url),
start_url);
}
} // namespace
// Tests that SkBitmaps associated with shortcut item icons are populated in
// their own map in web_app_info.
TEST(WebAppInstallUtils, PopulateShortcutItemIcons) {
auto web_app_info = CreateWebAppInstallInfo();
WebAppShortcutsMenuItemInfo::Icon icon;
const GURL kIconUrl1("http://www.chromium.org/shortcuts/icon1.png");
{
WebAppShortcutsMenuItemInfo shortcut_item;
std::vector<WebAppShortcutsMenuItemInfo::Icon> shortcut_manifest_icons;
shortcut_item.name = std::u16string(kShortcutItemTestName) + u"1";
shortcut_item.url = GURL("http://www.chromium.org/shortcuts/action");
icon.url = kIconUrl1;
icon.square_size_px = kIconSize;
shortcut_manifest_icons.push_back(icon);
shortcut_item.SetShortcutIconInfosForPurpose(
IconPurpose::ANY, std::move(shortcut_manifest_icons));
web_app_info.shortcuts_menu_item_infos.push_back(std::move(shortcut_item));
}
const GURL kIconUrl2("http://www.chromium.org/shortcuts/icon2.png");
{
WebAppShortcutsMenuItemInfo shortcut_item;
std::vector<WebAppShortcutsMenuItemInfo::Icon> shortcut_manifest_icons;
shortcut_item.name = std::u16string(kShortcutItemTestName) + u"2";
icon.url = kIconUrl1;
icon.square_size_px = kIconSize;
shortcut_manifest_icons.push_back(icon);
icon.url = kIconUrl2;
icon.square_size_px = 2 * kIconSize;
shortcut_manifest_icons.push_back(icon);
shortcut_item.SetShortcutIconInfosForPurpose(
IconPurpose::ANY, std::move(shortcut_manifest_icons));
web_app_info.shortcuts_menu_item_infos.push_back(std::move(shortcut_item));
}
{
IconsMap icons_map;
std::vector<SkBitmap> bmp1 = {CreateSquareIcon(32, SK_ColorWHITE)};
std::vector<SkBitmap> bmp2 = {CreateSquareIcon(32, SK_ColorBLUE)};
std::vector<SkBitmap> bmp3 = {CreateSquareIcon(32, SK_ColorRED)};
icons_map.emplace(kIconUrl1, bmp1);
icons_map.emplace(kIconUrl2, bmp2);
icons_map.emplace(GURL("http://www.chromium.org/shortcuts/icon3.png"),
bmp3);
PopulateOtherIcons(&web_app_info, icons_map);
}
// Ensure that reused shortcut icons are processed correctly.
EXPECT_EQ(1U, web_app_info.shortcuts_menu_icon_bitmaps[0].any.size());
EXPECT_EQ(0U, web_app_info.shortcuts_menu_icon_bitmaps[0].maskable.size());
EXPECT_EQ(2U, web_app_info.shortcuts_menu_icon_bitmaps[1].any.size());
EXPECT_EQ(0U, web_app_info.shortcuts_menu_icon_bitmaps[1].maskable.size());
}
// Tests that when PopulateOtherItemIcons is called with no shortcut icon
// urls specified, no data is written to shortcuts_menu_item_infos.
TEST(WebAppInstallUtils, PopulateShortcutItemIconsNoShortcutIcons) {
auto web_app_info = CreateWebAppInstallInfo();
IconsMap icons_map;
std::vector<SkBitmap> bmp1 = {CreateSquareIcon(32, SK_ColorWHITE)};
std::vector<SkBitmap> bmp2 = {CreateSquareIcon(32, SK_ColorBLUE)};
std::vector<SkBitmap> bmp3 = {CreateSquareIcon(32, SK_ColorRED)};
icons_map.emplace(GURL("http://www.chromium.org/shortcuts/icon1.png"), bmp1);
icons_map.emplace(GURL("http://www.chromium.org/shortcuts/icon2.png"), bmp2);
icons_map.emplace(GURL("http://www.chromium.org/shortcuts/icon3.png"), bmp3);
PopulateOtherIcons(&web_app_info, icons_map);
EXPECT_EQ(0U, web_app_info.shortcuts_menu_item_infos.size());
}
// Tests that when PopulateProductIcons is called with maskable
// icons available, web_app_info.icon_bitmaps_{any,maskable} are correctly
// populated.
TEST(WebAppInstallUtils, PopulateProductIcons_MaskableIcons) {
// Construct |icons_map| to pass to PopulateProductIcons().
IconsMap icons_map;
const GURL kIconUrl1("http://www.chromium.org/shortcuts/icon1.png");
std::vector<SkBitmap> bmp1 = {CreateSquareIcon(32, SK_ColorWHITE)};
icons_map.emplace(kIconUrl1, bmp1);
const GURL kIconUrl2("http://www.chromium.org/shortcuts/icon2.png");
std::vector<SkBitmap> bmp2 = {CreateSquareIcon(64, SK_ColorBLUE)};
icons_map.emplace(kIconUrl2, bmp2);
// Construct |web_app_info| to pass icon infos.
auto web_app_info = CreateWebAppInstallInfo();
web_app_info.title = u"App Name";
apps::IconInfo info;
// Icon at URL 1 has both kAny and kMaskable purpose.
info.url = kIconUrl1;
info.purpose = apps::IconInfo::Purpose::kAny;
web_app_info.manifest_icons.push_back(info);
info.purpose = apps::IconInfo::Purpose::kMaskable;
web_app_info.manifest_icons.push_back(info);
// Icon at URL 2 has kMaskable purpose only.
info.url = kIconUrl2;
info.purpose = apps::IconInfo::Purpose::kMaskable;
web_app_info.manifest_icons.push_back(info);
PopulateProductIcons(&web_app_info, &icons_map);
EXPECT_EQ(SizesToGenerate().size(), web_app_info.icon_bitmaps.any.size());
// Expect only icon at URL 1 to be used and resized as.
for (const auto& icon_bitmap : web_app_info.icon_bitmaps.any) {
EXPECT_EQ(SK_ColorWHITE, icon_bitmap.second.getColor(0, 0));
}
EXPECT_EQ(2u, web_app_info.icon_bitmaps.maskable.size());
}
// Tests that when PopulateProductIcons is called with maskable
// icons only, web_app_info.icon_bitmaps_any is correctly populated.
TEST(WebAppInstallUtils, PopulateProductIcons_MaskableIconsOnly) {
// Construct |icons_map| to pass to PopulateProductIcons().
IconsMap icons_map;
const GURL kIconUrl1("http://www.chromium.org/shortcuts/icon1.png");
std::vector<SkBitmap> bmp1 = {CreateSquareIcon(32, SK_ColorWHITE)};
icons_map.emplace(kIconUrl1, bmp1);
// Construct |web_app_info| to pass icon infos.
auto web_app_info = CreateWebAppInstallInfo();
web_app_info.title = u"App Name";
apps::IconInfo info;
info.url = kIconUrl1;
info.purpose = apps::IconInfo::Purpose::kMaskable;
web_app_info.manifest_icons.push_back(info);
PopulateProductIcons(&web_app_info, &icons_map);
// Expect to fall back to using icon from icons_map.
EXPECT_EQ(SizesToGenerate().size(), web_app_info.icon_bitmaps.any.size());
for (const auto& icon_bitmap : web_app_info.icon_bitmaps.any) {
EXPECT_EQ(SK_ColorWHITE, icon_bitmap.second.getColor(0, 0));
}
}
// Tests that when PopulateProductIcons is called with no
// app icon or shortcut icon data in web_app_info, and kDesktopPWAShortcutsMenu
// feature enabled, web_app_info.icon_bitmaps_any is correctly populated.
TEST(WebAppInstallUtils, PopulateProductIconsNoWebAppIconData_WithShortcuts) {
auto web_app_info = CreateWebAppInstallInfo();
web_app_info.title = u"App Name";
IconsMap icons_map;
std::vector<SkBitmap> bmp1 = {CreateSquareIcon(32, SK_ColorWHITE)};
icons_map.emplace(GURL("http://www.chromium.org/shortcuts/icon1.png"), bmp1);
PopulateProductIcons(&web_app_info, &icons_map);
// Expect to fall back to using icon from icons_map.
EXPECT_EQ(SizesToGenerate().size(), web_app_info.icon_bitmaps.any.size());
for (const auto& icon_bitmap : web_app_info.icon_bitmaps.any) {
EXPECT_EQ(SK_ColorWHITE, icon_bitmap.second.getColor(0, 0));
}
}
TEST(WebAppInstallUtils, PopulateProductIcons_IsGeneratedIcon) {
{
auto web_app_info = CreateWebAppInstallInfo();
web_app_info.title = u"App Name";
IconsMap icons_map;
PopulateProductIcons(&web_app_info, &icons_map);
EXPECT_TRUE(web_app_info.is_generated_icon);
EXPECT_TRUE(ContainsOneIconOfEachSize(web_app_info.icon_bitmaps.any));
}
{
auto web_app_info = CreateWebAppInstallInfo();
web_app_info.title = u"App Name";
IconsMap icons_map;
AddIconToIconsMap(GURL("http://www.example.org/icon32.png"), icon_size::k32,
SK_ColorCYAN, &icons_map);
// Does upsizing of the smallest icon.
PopulateProductIcons(&web_app_info, &icons_map);
EXPECT_FALSE(web_app_info.is_generated_icon);
EXPECT_TRUE(ContainsOneIconOfEachSize(web_app_info.icon_bitmaps.any));
for (const auto& bitmap_any : web_app_info.icon_bitmaps.any)
EXPECT_EQ(SK_ColorCYAN, bitmap_any.second.getColor(0, 0));
}
{
auto web_app_info = CreateWebAppInstallInfo();
web_app_info.title = u"App Name";
IconsMap icons_map;
AddIconToIconsMap(GURL("http://www.example.org/icon512.png"),
icon_size::k512, SK_ColorMAGENTA, &icons_map);
// Does downsizing of the biggest icon which is not in `SizesToGenerate()`.
PopulateProductIcons(&web_app_info, &icons_map);
EXPECT_FALSE(web_app_info.is_generated_icon);
EXPECT_TRUE(ContainsOneIconOfEachSize(web_app_info.icon_bitmaps.any));
for (const auto& bitmap_any : web_app_info.icon_bitmaps.any)
EXPECT_EQ(SK_ColorMAGENTA, bitmap_any.second.getColor(0, 0));
}
}
// Tests that when PopulateOtherItemIcons is called with no home tab icon
// urls specified, no data is written to other_icon_bitmaps.
TEST(WebAppInstallUtils, PopulateHomeTabIconsNoHomeTabIcons_TabStrip) {
auto web_app_info = CreateWebAppInstallInfo();
IconsMap icons_map;
std::vector<SkBitmap> bmp1 = {CreateSquareIcon(32, SK_ColorWHITE)};
std::vector<SkBitmap> bmp2 = {CreateSquareIcon(32, SK_ColorBLUE)};
std::vector<SkBitmap> bmp3 = {CreateSquareIcon(32, SK_ColorRED)};
icons_map.emplace(GURL("http://www.chromium.org/home_tab_icons/icon1.png"),
bmp1);
icons_map.emplace(GURL("http://www.chromium.org/home_tab_icons/icon2.png"),
bmp2);
icons_map.emplace(GURL("http://www.chromium.org/home_tab_icons/icon3.png"),
bmp3);
PopulateOtherIcons(&web_app_info, icons_map);
EXPECT_EQ(0U, web_app_info.other_icon_bitmaps.size());
}
class FileHandlersFromManifestTest : public ::testing::TestWithParam<bool> {
public:
FileHandlersFromManifestTest() {
feature_list_.InitAndEnableFeature(blink::features::kFileHandlingIcons);
WebAppFileHandlerManager::SetIconsSupportedByOsForTesting(GetParam());
}
~FileHandlersFromManifestTest() override = default;
protected:
static std::vector<blink::mojom::ManifestFileHandlerPtr>
CreateManifestFileHandlers(unsigned count) {
std::vector<blink::mojom::ManifestFileHandlerPtr> manifest_file_handlers;
for (unsigned i = 0; i < count; ++i) {
auto file_handler = blink::mojom::ManifestFileHandler::New();
file_handler->action = MakeActionUrl(i);
file_handler->name = base::UTF8ToUTF16(base::StringPrintf("n%u", i));
file_handler->accept[base::UTF8ToUTF16(MakeMimeType(i))] = {
base::UTF8ToUTF16(MakeExtension(i))};
blink::Manifest::ImageResource icon;
icon.src = MakeImageUrl(i);
icon.sizes = {{16, 16}, {32, 32}, {64, 64}};
icon.purpose = {blink::mojom::ManifestImageResource_Purpose::ANY};
file_handler->icons.push_back(std::move(icon));
blink::Manifest::ImageResource icon2;
icon2.src = MakeImageUrlForSecondImage(i);
icon2.sizes = {{16, 16}};
icon2.purpose = {blink::mojom::ManifestImageResource_Purpose::ANY,
blink::mojom::ManifestImageResource_Purpose::MASKABLE};
file_handler->icons.push_back(std::move(icon2));
manifest_file_handlers.push_back(std::move(file_handler));
}
return manifest_file_handlers;
}
static GURL MakeActionUrl(unsigned index) {
return GetStartUrl().Resolve(base::StringPrintf("a%u", index));
}
static GURL MakeImageUrl(unsigned index) {
return GetStartUrl().Resolve(base::StringPrintf("image%u.png", index));
}
static GURL MakeImageUrlForSecondImage(unsigned index) {
return GetStartUrl().Resolve(base::StringPrintf("image%u-2.png", index));
}
static std::string MakeMimeType(unsigned index) {
return base::StringPrintf("application/x-%u", index);
}
static std::string MakeExtension(unsigned index) {
return base::StringPrintf(".e%u", index);
}
static GURL GetStartUrl() {
return GURL("https://www.example.com/index.html");
}
base::test::ScopedFeatureList feature_list_;
};
TEST_P(FileHandlersFromManifestTest, Basic) {
std::vector<blink::mojom::ManifestFileHandlerPtr> manifest_file_handlers =
CreateManifestFileHandlers(6);
auto web_app_info = CreateWebAppInstallInfo();
PopulateFileHandlerInfoFromManifest(manifest_file_handlers, GetStartUrl(),
&web_app_info);
const apps::FileHandlers& file_handlers = web_app_info.file_handlers;
ASSERT_EQ(file_handlers.size(), 6U);
for (unsigned i = 0; i < 6U; ++i) {
EXPECT_EQ(file_handlers[i].action, MakeActionUrl(i));
ASSERT_EQ(file_handlers[i].accept.size(), 1U);
EXPECT_EQ(file_handlers[i].accept[0].mime_type, MakeMimeType(i));
EXPECT_EQ(file_handlers[i].accept[0].file_extensions.size(), 1U);
EXPECT_EQ(*file_handlers[i].accept[0].file_extensions.begin(),
MakeExtension(i));
if (WebAppFileHandlerManager::IconsEnabled()) {
ASSERT_EQ(file_handlers[i].downloaded_icons.size(), 3U);
// The manifest-specified `sizes` are ignored.
EXPECT_FALSE(file_handlers[i].downloaded_icons[0].square_size_px);
EXPECT_EQ(MakeImageUrl(i), file_handlers[i].downloaded_icons[0].url);
EXPECT_EQ(apps::IconInfo::Purpose::kAny,
file_handlers[i].downloaded_icons[0].purpose);
EXPECT_FALSE(file_handlers[i].downloaded_icons[1].square_size_px);
EXPECT_EQ(MakeImageUrlForSecondImage(i),
file_handlers[i].downloaded_icons[1].url);
EXPECT_EQ(apps::IconInfo::Purpose::kAny,
file_handlers[i].downloaded_icons[1].purpose);
EXPECT_FALSE(file_handlers[i].downloaded_icons[2].square_size_px);
EXPECT_EQ(MakeImageUrlForSecondImage(i),
file_handlers[i].downloaded_icons[2].url);
EXPECT_EQ(apps::IconInfo::Purpose::kMaskable,
file_handlers[i].downloaded_icons[2].purpose);
} else {
EXPECT_TRUE(file_handlers[i].downloaded_icons.empty());
}
}
}
TEST_P(FileHandlersFromManifestTest, PopulateFileHandlerIcons) {
if (!WebAppFileHandlerManager::IconsEnabled())
return;
std::vector<blink::mojom::ManifestFileHandlerPtr> manifest_file_handlers =
CreateManifestFileHandlers(1);
auto web_app_info = CreateWebAppInstallInfo();
PopulateFileHandlerInfoFromManifest(manifest_file_handlers, GetStartUrl(),
&web_app_info);
const GURL first_image_url = MakeImageUrl(0);
const GURL second_image_url = MakeImageUrlForSecondImage(0);
IconsMap icons_map;
// The first URL returns two valid bitmaps and one invalid (non-square), which
// should be ignored.
std::vector<SkBitmap> bmps1 = {CreateSquareIcon(17, SK_ColorWHITE),
CreateSquareIcon(29, SK_ColorBLUE),
gfx::test::CreateBitmap(16, 15)};
icons_map.emplace(first_image_url, bmps1);
std::vector<SkBitmap> bmps2 = {CreateSquareIcon(79, SK_ColorRED),
CreateSquareIcon(134, SK_ColorRED)};
icons_map.emplace(second_image_url, bmps2);
PopulateOtherIcons(&web_app_info, icons_map);
// Make sure bitmaps are copied from `icons_map` into `web_app_info`.
// Images downloaded from two distinct URLs.
ASSERT_EQ(2U, web_app_info.other_icon_bitmaps.size());
// First URL correlates to two bitmaps.
ASSERT_EQ(2U, web_app_info.other_icon_bitmaps[first_image_url].size());
EXPECT_TRUE(
gfx::BitmapsAreEqual(web_app_info.other_icon_bitmaps[first_image_url][0],
icons_map[first_image_url][0]));
EXPECT_TRUE(
gfx::BitmapsAreEqual(web_app_info.other_icon_bitmaps[first_image_url][1],
icons_map[first_image_url][1]));
// Second URL correlates to two more bitmaps.
ASSERT_EQ(2U, web_app_info.other_icon_bitmaps[second_image_url].size());
EXPECT_TRUE(
gfx::BitmapsAreEqual(web_app_info.other_icon_bitmaps[second_image_url][0],
icons_map[second_image_url][0]));
EXPECT_TRUE(
gfx::BitmapsAreEqual(web_app_info.other_icon_bitmaps[second_image_url][1],
icons_map[second_image_url][1]));
// We end up with one file handler with 6 icon infos. The second URL produces
// 4 IconInfos because it has two bitmaps and two purposes: 2 x 2 = 4.
ASSERT_EQ(1U, web_app_info.file_handlers.size());
// The metadata we expect to be saved after icons are finished downloading and
// processing. Note that the icon sizes saved to `apps::FileHandler::icons`
// match downloaded sizes, not those specified in the manifest.
struct Expectations {
GURL expected_url;
apps::IconInfo::SquareSizePx expected_size;
apps::IconInfo::Purpose expected_purpose;
};
auto expectations = std::to_array<Expectations>({
{first_image_url, 17, apps::IconInfo::Purpose::kAny},
{first_image_url, 29, apps::IconInfo::Purpose::kAny},
{second_image_url, 79, apps::IconInfo::Purpose::kAny},
{second_image_url, 134, apps::IconInfo::Purpose::kAny},
{second_image_url, 79, apps::IconInfo::Purpose::kMaskable},
{second_image_url, 134, apps::IconInfo::Purpose::kMaskable},
});
const size_t num_expectations =
sizeof(expectations) / sizeof(expectations[0]);
ASSERT_EQ(num_expectations,
web_app_info.file_handlers[0].downloaded_icons.size());
for (size_t i = 0; i < num_expectations; ++i) {
const auto& icon = web_app_info.file_handlers[0].downloaded_icons[i];
EXPECT_EQ(expectations[i].expected_url, icon.url);
EXPECT_EQ(expectations[i].expected_size, icon.square_size_px);
EXPECT_EQ(expectations[i].expected_purpose, icon.purpose);
}
}
// Test duplicate icon download urls that from the manifest.
TEST(WebAppInstallUtils, DuplicateIconDownloadURLs) {
base::test::ScopedFeatureList feature_list;
feature_list.InitWithFeatures({blink::features::kFileHandlingIcons}, {});
auto web_app_info = CreateWebAppInstallInfo();
// manifest icons
{
apps::IconInfo info;
info.url = GURL("http://www.chromium.org/image/icon1.png");
web_app_info.manifest_icons.push_back(info);
}
{
apps::IconInfo info;
info.url = GURL("http://www.chromium.org/image/icon2.png");
web_app_info.manifest_icons.push_back(info);
}
// shortcut icons
{
WebAppShortcutsMenuItemInfo shortcut_item;
{
std::vector<WebAppShortcutsMenuItemInfo::Icon> shortcut_manifest_icons;
{
WebAppShortcutsMenuItemInfo::Icon icon;
icon.url = GURL("http://www.chromium.org/image/icon2.png");
shortcut_manifest_icons.push_back(icon);
}
{
WebAppShortcutsMenuItemInfo::Icon icon;
icon.url = GURL("http://www.chromium.org/image/icon3.png");
shortcut_manifest_icons.push_back(icon);
}
shortcut_item.SetShortcutIconInfosForPurpose(
IconPurpose::ANY, std::move(shortcut_manifest_icons));
}
{
std::vector<WebAppShortcutsMenuItemInfo::Icon> shortcut_manifest_icons;
{
WebAppShortcutsMenuItemInfo::Icon icon;
icon.url = GURL("http://www.chromium.org/image/icon3.png");
shortcut_manifest_icons.push_back(icon);
}
{
WebAppShortcutsMenuItemInfo::Icon icon;
icon.url = GURL("http://www.chromium.org/image/icon4.png");
shortcut_manifest_icons.push_back(icon);
}
shortcut_item.SetShortcutIconInfosForPurpose(
IconPurpose::MONOCHROME, std::move(shortcut_manifest_icons));
}
web_app_info.shortcuts_menu_item_infos.push_back(std::move(shortcut_item));
}
{
WebAppShortcutsMenuItemInfo shortcut_item;
{
std::vector<WebAppShortcutsMenuItemInfo::Icon> shortcut_manifest_icons;
{
WebAppShortcutsMenuItemInfo::Icon icon;
icon.url = GURL("http://www.chromium.org/image/icon4.png");
shortcut_manifest_icons.push_back(icon);
}
{
WebAppShortcutsMenuItemInfo::Icon icon;
icon.url = GURL("http://www.chromium.org/image/icon5.png");
shortcut_manifest_icons.push_back(icon);
}
shortcut_item.SetShortcutIconInfosForPurpose(
IconPurpose::ANY, std::move(shortcut_manifest_icons));
}
{
std::vector<WebAppShortcutsMenuItemInfo::Icon> shortcut_manifest_icons;
{
WebAppShortcutsMenuItemInfo::Icon icon;
icon.url = GURL("http://www.chromium.org/image/icon5.png");
shortcut_manifest_icons.push_back(icon);
}
{
WebAppShortcutsMenuItemInfo::Icon icon;
icon.url = GURL("http://www.chromium.org/image/icon6.png");
shortcut_manifest_icons.push_back(icon);
}
shortcut_item.SetShortcutIconInfosForPurpose(
IconPurpose::MASKABLE, std::move(shortcut_manifest_icons));
}
web_app_info.shortcuts_menu_item_infos.push_back(std::move(shortcut_item));
}
// file handler icons
{
apps::FileHandler file_handler;
std::vector<apps::IconInfo> downloaded_icons;
{
apps::IconInfo info;
info.url = GURL("http://www.chromium.org/image/icon6.png");
web_app_info.manifest_icons.push_back(info);
}
{
apps::IconInfo info;
info.url = GURL("http://www.chromium.org/image/icon7.png");
web_app_info.manifest_icons.push_back(info);
}
web_app_info.file_handlers.push_back(file_handler);
}
{
apps::FileHandler file_handler;
std::vector<apps::IconInfo> downloaded_icons;
{
apps::IconInfo info;
info.url = GURL("http://www.chromium.org/image/icon7.png");
web_app_info.manifest_icons.push_back(info);
}
{
apps::IconInfo info;
info.url = GURL("http://www.chromium.org/image/icon8.png");
web_app_info.manifest_icons.push_back(info);
}
web_app_info.file_handlers.push_back(file_handler);
}
IconUrlSizeSet download_urls = GetValidIconUrlsToDownload(web_app_info);
const size_t download_urls_size = 8;
EXPECT_EQ(download_urls_size, download_urls.size());
for (size_t i = 0; i < download_urls_size; i++) {
std::string url_str = "http://www.chromium.org/image/icon" +
base::NumberToString(i + 1) + ".png";
EXPECT_EQ(1u, download_urls.count(IconUrlWithSize::CreateForUnspecifiedSize(
GURL(url_str))));
}
}
INSTANTIATE_TEST_SUITE_P(, FileHandlersFromManifestTest, testing::Bool());
TEST(WebAppInstallUtils, SetWebAppManifestFields_Summary) {
GURL start_url("https://www.chromium.org/index.html");
auto web_app_info = CreateWebAppInstallInfoFromStartUrl(start_url);
web_app_info.scope = web_app_info.start_url().GetWithoutFilename();
web_app_info.title = u"App Name";
web_app_info.description = u"App Description";
web_app_info.theme_color = SK_ColorCYAN;
web_app_info.dark_mode_theme_color = SK_ColorBLACK;
web_app_info.background_color = SK_ColorMAGENTA;
web_app_info.dark_mode_background_color = SK_ColorBLACK;
const webapps::AppId app_id = GenerateAppId(/*manifest_id_path=*/std::nullopt,
web_app_info.start_url());
auto web_app = std::make_unique<WebApp>(app_id);
SetWebAppManifestFields(web_app_info, *web_app);
EXPECT_EQ(web_app->scope(), GURL("https://www.chromium.org/"));
EXPECT_EQ(web_app->untranslated_name(), "App Name");
EXPECT_EQ(web_app->untranslated_description(), "App Description");
EXPECT_TRUE(web_app->theme_color().has_value());
EXPECT_EQ(*web_app->theme_color(), SK_ColorCYAN);
EXPECT_TRUE(web_app->dark_mode_theme_color().has_value());
EXPECT_EQ(*web_app->dark_mode_theme_color(), SK_ColorBLACK);
EXPECT_TRUE(web_app->background_color().has_value());
EXPECT_EQ(*web_app->background_color(), SK_ColorMAGENTA);
EXPECT_TRUE(web_app->dark_mode_background_color().has_value());
EXPECT_EQ(*web_app->dark_mode_background_color(), SK_ColorBLACK);
web_app_info.theme_color = std::nullopt;
web_app_info.dark_mode_theme_color = std::nullopt;
web_app_info.background_color = std::nullopt;
web_app_info.dark_mode_background_color = std::nullopt;
SetWebAppManifestFields(web_app_info, *web_app);
EXPECT_FALSE(web_app->theme_color().has_value());
EXPECT_FALSE(web_app->dark_mode_theme_color().has_value());
EXPECT_FALSE(web_app->background_color().has_value());
EXPECT_FALSE(web_app->dark_mode_background_color().has_value());
}
TEST(WebAppInstallUtils, SetWebAppManifestFields_ShareTarget) {
auto web_app_info = CreateWebAppInstallInfoFromStartUrl(StartUrl());
web_app_info.scope = web_app_info.start_url().GetWithoutFilename();
web_app_info.title = u"App Name";
const webapps::AppId app_id = GenerateAppId(/*manifest_id_path=*/std::nullopt,
web_app_info.start_url());
auto web_app = std::make_unique<WebApp>(app_id);
{
apps::ShareTarget share_target;
share_target.action = GURL("http://example.com/share1");
share_target.method = apps::ShareTarget::Method::kPost;
share_target.enctype = apps::ShareTarget::Enctype::kMultipartFormData;
share_target.params.title = "kTitle";
share_target.params.text = "kText";
apps::ShareTarget::Files file_filter;
file_filter.name = "kImages";
file_filter.accept.push_back(".png");
file_filter.accept.push_back("image/png");
share_target.params.files.push_back(std::move(file_filter));
web_app_info.share_target = std::move(share_target);
}
SetWebAppManifestFields(web_app_info, *web_app);
{
EXPECT_TRUE(web_app->share_target().has_value());
auto share_target = *web_app->share_target();
EXPECT_EQ(share_target.action, GURL("http://example.com/share1"));
EXPECT_EQ(share_target.method, apps::ShareTarget::Method::kPost);
EXPECT_EQ(share_target.enctype,
apps::ShareTarget::Enctype::kMultipartFormData);
EXPECT_EQ(share_target.params.title, "kTitle");
EXPECT_EQ(share_target.params.text, "kText");
EXPECT_TRUE(share_target.params.url.empty());
EXPECT_EQ(share_target.params.files.size(), 1U);
EXPECT_EQ(share_target.params.files[0].name, "kImages");
EXPECT_EQ(share_target.params.files[0].accept.size(), 2U);
EXPECT_EQ(share_target.params.files[0].accept[0], ".png");
EXPECT_EQ(share_target.params.files[0].accept[1], "image/png");
}
{
apps::ShareTarget share_target;
share_target.action = GURL("http://example.com/share2");
share_target.method = apps::ShareTarget::Method::kGet;
share_target.enctype = apps::ShareTarget::Enctype::kFormUrlEncoded;
share_target.params.text = "kText";
share_target.params.url = "kUrl";
web_app_info.share_target = std::move(share_target);
}
SetWebAppManifestFields(web_app_info, *web_app);
{
EXPECT_TRUE(web_app->share_target().has_value());
auto share_target = *web_app->share_target();
EXPECT_EQ(share_target.action, GURL("http://example.com/share2"));
EXPECT_EQ(share_target.method, apps::ShareTarget::Method::kGet);
EXPECT_EQ(share_target.enctype,
apps::ShareTarget::Enctype::kFormUrlEncoded);
EXPECT_TRUE(share_target.params.title.empty());
EXPECT_EQ(share_target.params.text, "kText");
EXPECT_EQ(share_target.params.url, "kUrl");
EXPECT_TRUE(share_target.params.files.empty());
}
web_app_info.share_target = std::nullopt;
SetWebAppManifestFields(web_app_info, *web_app);
EXPECT_FALSE(web_app->share_target().has_value());
}
} // namespace web_app
|