1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/strike_database/history_clearable_strike_database.h"
#include <optional>
#include "base/files/scoped_temp_dir.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "components/history/core/browser/history_types.h"
#include "components/history/core/browser/url_row.h"
#include "components/leveldb_proto/public/proto_database_provider.h"
#include "components/strike_database/strike_database.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace autofill {
namespace {
struct TestStrikeDatabaseTraits {
static constexpr std::string_view kName = "Test";
static constexpr size_t kMaxStrikeEntities = 200;
static constexpr size_t kMaxStrikeEntitiesAfterCleanup = 150;
static constexpr size_t kMaxStrikeLimit = 3;
static constexpr base::TimeDelta kExpiryTimeDelta = base::Days(180);
static constexpr bool kUniqueIdRequired = true;
static std::string HostFromId(const std::string& id) {
// To keep testing simple, we assume the database is only keyed by host.
return id;
}
};
class HistoryClearableStrikeDatabaseTest : public ::testing::Test {
public:
HistoryClearableStrikeDatabaseTest() = default;
void SetUp() override {
EXPECT_TRUE(temp_dir_.CreateUniqueTempDir());
db_provider_ = std::make_unique<leveldb_proto::ProtoDatabaseProvider>(
temp_dir_.GetPath());
strike_database_service_ = std::make_unique<StrikeDatabase>(
db_provider_.get(), temp_dir_.GetPath());
strike_database_ = std::make_unique<
HistoryClearableStrikeDatabase<TestStrikeDatabaseTraits>>(
strike_database_service_.get());
delete_first_url_row_.emplace_back(kUrl1);
delete_all_urls_rows_.emplace_back(kUrl1);
delete_all_urls_rows_.emplace_back(kUrl2);
delete_all_urls_rows_.emplace_back(kUrl3);
}
void TearDown() override {
// The destruction of `strike_database_service_`'s components is posted
// to a task runner, requires running the loop to complete.
strike_database_.reset();
strike_database_service_.reset();
db_provider_.reset();
task_environment_.RunUntilIdle();
}
void ClearStrikesByOrigin(const history::URLRows& deleted_rows) {
strike_database_->ClearStrikesWithHistory(
history::DeletionInfo::ForUrls(deleted_rows,
/*favicon_urls=*/{}));
}
void ClearStrikesByOriginAndTime(const history::URLRows& deleted_rows,
base::Time delete_begin,
base::Time delete_end) {
strike_database_->ClearStrikesWithHistory(history::DeletionInfo(
history::DeletionTimeRange(delete_begin, delete_end),
/*is_from_expiration=*/false, deleted_rows,
/*favicon_urls=*/{}, /*restrict_urls=*/std::nullopt));
}
protected:
base::ScopedTempDir temp_dir_;
base::test::TaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
std::unique_ptr<leveldb_proto::ProtoDatabaseProvider> db_provider_;
std::unique_ptr<StrikeDatabase> strike_database_service_;
std::unique_ptr<HistoryClearableStrikeDatabase<TestStrikeDatabaseTraits>>
strike_database_;
const GURL kUrl1 = GURL("https://www.strikedhost.com");
const GURL kUrl2 = GURL("https://www.otherhost.com");
const GURL kUrl3 = GURL("https://www.justanotherhost.com");
history::URLRows delete_first_url_row_;
history::URLRows delete_all_urls_rows_;
};
TEST_F(HistoryClearableStrikeDatabaseTest,
RemoveStrikesByOriginWithinDeletionWindow) {
base::Time start_time = base::Time::Now();
// Both strikes are added within the deletion window, but the second should
// be ruled out by the filter.
strike_database_->AddStrike(kUrl1.host());
strike_database_->AddStrike(kUrl2.host());
base::Time end_time = base::Time::Now();
EXPECT_EQ(strike_database_->GetStrikes(kUrl1.host()), 1);
EXPECT_EQ(strike_database_->GetStrikes(kUrl2.host()), 1);
ClearStrikesByOriginAndTime(delete_first_url_row_, start_time, end_time);
EXPECT_EQ(strike_database_->GetStrikes(kUrl1.host()), 0);
EXPECT_EQ(strike_database_->GetStrikes(kUrl2.host()), 1);
}
TEST_F(HistoryClearableStrikeDatabaseTest, RemoveStrikesByOrigin) {
strike_database_->AddStrike(kUrl1.host());
strike_database_->AddStrike(kUrl2.host());
EXPECT_EQ(strike_database_->GetStrikes(kUrl1.host()), 1);
EXPECT_EQ(strike_database_->GetStrikes(kUrl2.host()), 1);
ClearStrikesByOrigin(delete_first_url_row_);
EXPECT_EQ(strike_database_->GetStrikes(kUrl1.host()), 0);
EXPECT_EQ(strike_database_->GetStrikes(kUrl2.host()), 1);
}
TEST_F(HistoryClearableStrikeDatabaseTest,
DoNotRemoveStrikeAfterDeletionWindow) {
base::Time start_time = base::Time::Now();
strike_database_->AddStrike(kUrl1.host());
task_environment_.FastForwardBy(base::Minutes(1));
base::Time end_time = base::Time::Now();
task_environment_.FastForwardBy(base::Minutes(1));
// Now update the time stamp of this entry by adding another strike.
// By this, the entry should not be deleted.
strike_database_->AddStrike(kUrl1.host());
ClearStrikesByOriginAndTime(delete_all_urls_rows_, start_time, end_time);
EXPECT_EQ(strike_database_->GetStrikes(kUrl1.host()), 2);
}
TEST_F(HistoryClearableStrikeDatabaseTest,
DoNotRemoveStrikeBeforeDeletionWindow) {
// The strike is added before the deletion window.
strike_database_->AddStrike(kUrl1.host());
task_environment_.FastForwardBy(base::Minutes(1));
base::Time start_time = base::Time::Now();
task_environment_.FastForwardBy(base::Minutes(1));
base::Time end_time = base::Time::Now();
ClearStrikesByOriginAndTime(delete_all_urls_rows_, start_time, end_time);
EXPECT_EQ(strike_database_->GetStrikes(kUrl1.host()), 1);
}
} // namespace
} // namespace autofill
|
