1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/strike_database/strike_database_integrator_test_strike_database.h"
#include <utility>
#include <vector>
#include "base/files/scoped_temp_dir.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "components/autofill/core/browser/proto/strike_data.pb.h"
#include "components/autofill/core/common/autofill_payments_features.h"
#include "components/leveldb_proto/public/proto_database.h"
#include "components/leveldb_proto/public/proto_database_provider.h"
#include "components/strike_database/strike_database_integrator_base.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace autofill {
class StrikeDatabaseIntegratorTestStrikeDatabaseTest : public ::testing::Test {
public:
StrikeDatabaseIntegratorTestStrikeDatabaseTest() = default;
void SetUp() override {
EXPECT_TRUE(temp_dir_.CreateUniqueTempDir());
db_provider_ = std::make_unique<leveldb_proto::ProtoDatabaseProvider>(
temp_dir_.GetPath());
strike_database_service_ = std::make_unique<StrikeDatabase>(
db_provider_.get(), temp_dir_.GetPath());
strike_database_ =
std::make_unique<StrikeDatabaseIntegratorTestStrikeDatabase>(
strike_database_service_.get());
no_expiry_strike_database_ =
std::make_unique<StrikeDatabaseIntegratorTestStrikeDatabase>(
strike_database_service_.get(), std::nullopt);
}
void TearDown() override {
// The destruction of `strike_database_service_`'s components is posted
// to a task runner, requires running the loop to complete.
no_expiry_strike_database_.reset();
strike_database_.reset();
strike_database_service_.reset();
db_provider_.reset();
task_environment_.RunUntilIdle();
}
protected:
base::HistogramTester* GetHistogramTester() { return &histogram_tester_; }
base::ScopedTempDir temp_dir_;
base::test::TaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
std::unique_ptr<leveldb_proto::ProtoDatabaseProvider> db_provider_;
std::unique_ptr<StrikeDatabase> strike_database_service_;
std::unique_ptr<StrikeDatabaseIntegratorTestStrikeDatabase> strike_database_;
std::unique_ptr<StrikeDatabaseIntegratorTestStrikeDatabase>
no_expiry_strike_database_;
private:
base::HistogramTester histogram_tester_;
};
class DisableStrikeDatabaseIntegratorTestStrikeDatabaseTest
: public StrikeDatabaseIntegratorTestStrikeDatabaseTest {
base::test::ScopedFeatureList feature_list_{
features::kDisableAutofillStrikeSystem};
};
TEST_F(DisableStrikeDatabaseIntegratorTestStrikeDatabaseTest,
DisablementFlagEnabled) {
// Adding max strikes should have no effect if the flag is enabled.
strike_database_->AddStrikes(strike_database_->GetMaxStrikesLimit());
EXPECT_EQ(StrikeDatabaseIntegratorBase::kDoNotBlock,
strike_database_->GetStrikeDatabaseDecision());
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
MaxStrikesLimitReachedTest) {
EXPECT_EQ(StrikeDatabaseIntegratorBase::kDoNotBlock,
strike_database_->GetStrikeDatabaseDecision());
// 3 strikes added.
strike_database_->AddStrikes(3);
EXPECT_EQ(StrikeDatabaseIntegratorBase::kDoNotBlock,
strike_database_->GetStrikeDatabaseDecision());
// 4 strikes added, total strike count is 7.
strike_database_->AddStrikes(4);
EXPECT_EQ(StrikeDatabaseIntegratorBase::kMaxStrikeLimitReached,
strike_database_->GetStrikeDatabaseDecision());
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
StrikeDatabaseIntegratorTestNthStrikeAddedHistogram) {
// 2 strikes logged.
strike_database_->AddStrikes(2);
strike_database_->RemoveStrikes(2);
// 1 strike logged.
strike_database_->AddStrike();
// 2 strikes logged.
strike_database_->AddStrike();
std::vector<base::Bucket> buckets = GetHistogramTester()->GetAllSamples(
"Autofill.StrikeDatabase.NthStrikeAdded.StrikeDatabaseIntegratorTest");
// There should be two buckets, for strike counts of 1 and 2.
ASSERT_EQ(2U, buckets.size());
// Bucket for 1 strike should have count of 1.
EXPECT_EQ(1, buckets[0].count);
// Bucket for 2 strikes should have count of 2.
EXPECT_EQ(2, buckets[1].count);
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
AddStrikeForZeroAndNonZeroStrikesTest) {
EXPECT_EQ(0, strike_database_->GetStrikes());
strike_database_->AddStrike();
EXPECT_EQ(1, strike_database_->GetStrikes());
strike_database_->AddStrikes(2);
EXPECT_EQ(3, strike_database_->GetStrikes());
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
ClearStrikesForNonZeroStrikesTest) {
strike_database_->AddStrikes(3);
EXPECT_EQ(3, strike_database_->GetStrikes());
strike_database_->ClearStrikes();
EXPECT_EQ(0, strike_database_->GetStrikes());
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
ClearStrikesForZeroStrikesTest) {
strike_database_->ClearStrikes();
EXPECT_EQ(0, strike_database_->GetStrikes());
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
NonExpiringStrikesDoNotExpire) {
no_expiry_strike_database_->AddStrikes(1);
EXPECT_EQ(1, no_expiry_strike_database_->GetStrikes());
// Advance clock very far into the future.
task_environment_.FastForwardBy(base::Days(365) * 30);
no_expiry_strike_database_->RemoveExpiredStrikes();
// Strike should not be removed.
EXPECT_EQ(1, no_expiry_strike_database_->GetStrikes());
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
RemoveExpiredStrikesTest) {
strike_database_->AddStrikes(2);
EXPECT_EQ(2, strike_database_->GetStrikes());
// Advance clock to past expiry time.
task_environment_.FastForwardBy(
strike_database_->GetExpiryTimeDelta().value() + base::Microseconds(1));
// One strike should be removed.
strike_database_->RemoveExpiredStrikes();
EXPECT_EQ(1, strike_database_->GetStrikes());
// Strike count is past the max limit.
strike_database_->AddStrikes(10);
EXPECT_EQ(11, strike_database_->GetStrikes());
// Advance clock to past expiry time.
task_environment_.FastForwardBy(
strike_database_->GetExpiryTimeDelta().value() + base::Microseconds(1));
// Strike count should be one less than the max limit.
strike_database_->RemoveExpiredStrikes();
EXPECT_EQ(5, strike_database_->GetStrikes());
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
RemoveExpiredStrikesTestLogsUMA) {
strike_database_->AddStrikes(2);
EXPECT_EQ(2, strike_database_->GetStrikes());
// Advance clock to past expiry time.
task_environment_.FastForwardBy(
strike_database_->GetExpiryTimeDelta().value() + base::Microseconds(1));
// One strike should be removed.
strike_database_->RemoveExpiredStrikes();
EXPECT_EQ(1, strike_database_->GetStrikes());
// Strike count is past the max limit.
strike_database_->AddStrikes(10);
EXPECT_EQ(11, strike_database_->GetStrikes());
// Advance clock to past expiry time.
task_environment_.FastForwardBy(
strike_database_->GetExpiryTimeDelta().value() + base::Microseconds(1));
// Strike count should be one less than the max limit.
strike_database_->RemoveExpiredStrikes();
EXPECT_EQ(5, strike_database_->GetStrikes());
std::vector<base::Bucket> buckets = GetHistogramTester()->GetAllSamples(
"Autofill.StrikeDatabase.StrikesPresentWhenStrikeExpired."
"StrikeDatabaseIntegratorTest");
// There should be two buckets, for strike counts of 2 and 11.
ASSERT_EQ(2U, buckets.size());
// Bucket for 2 strikes should have count of 1.
GetHistogramTester()->ExpectBucketCount(
"Autofill.StrikeDatabase.StrikesPresentWhenStrikeExpired."
"StrikeDatabaseIntegratorTest",
2, 1);
// Bucket for 11 strikes should have count of 1.
GetHistogramTester()->ExpectBucketCount(
"Autofill.StrikeDatabase.StrikesPresentWhenStrikeExpired."
"StrikeDatabaseIntegratorTest",
11, 1);
}
// This test verifies correctness of http://crbug/1206176.
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
RemoveExpiredStrikesOnlyConsidersCurrentIntegrator) {
// Create a second test integrator, but with a different project prefix name,
// and whose strikes explicitly do not expire.
std::string other_project_prefix = "DifferentProjectPrefix";
std::unique_ptr<StrikeDatabaseIntegratorTestStrikeDatabase>
other_strike_database =
std::make_unique<StrikeDatabaseIntegratorTestStrikeDatabase>(
strike_database_service_.get(),
/*expiry_time_micros=*/std::nullopt, other_project_prefix);
// Add a strike to both integrators.
strike_database_->AddStrike();
EXPECT_EQ(1, strike_database_->GetStrikes());
other_strike_database->AddStrike();
EXPECT_EQ(1, other_strike_database->GetStrikes());
// Advance clock to past expiry time for `strike_database_`.
task_environment_.FastForwardBy(
strike_database_->GetExpiryTimeDelta().value() + base::Microseconds(1));
// Attempt to expire strikes. Only `strike_database_`'s keys should be
// affected.
strike_database_->RemoveExpiredStrikes();
other_strike_database->RemoveExpiredStrikes();
EXPECT_EQ(0, strike_database_->GetStrikes());
EXPECT_EQ(1, other_strike_database->GetStrikes());
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
GetKeyForStrikeDatabaseIntegratorUniqueIdTest) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id = "1234";
EXPECT_EQ("StrikeDatabaseIntegratorTest__1234",
strike_database_->GetKey(unique_id));
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
MaxStrikesLimitReachedUniqueIdTest) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id = "1234";
EXPECT_EQ(StrikeDatabaseIntegratorBase::kDoNotBlock,
strike_database_->GetStrikeDatabaseDecision(unique_id));
// 1 strike added for `unique_id`.
strike_database_->AddStrike(unique_id);
EXPECT_EQ(StrikeDatabaseIntegratorBase::kDoNotBlock,
strike_database_->GetStrikeDatabaseDecision(unique_id));
// 6 strikes added for `unique_id`.
strike_database_->AddStrikes(6, unique_id);
EXPECT_EQ(StrikeDatabaseIntegratorBase::kMaxStrikeLimitReached,
strike_database_->GetStrikeDatabaseDecision(unique_id));
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
StrikeDatabaseIntegratorUniqueIdTestNthStrikeAddedHistogram) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id_1 = "1234";
const std::string unique_id_2 = "9876";
// 1st strike added for `unique_id_1`.
strike_database_->AddStrike(unique_id_1);
// 2nd strike added for `unique_id_1`.
strike_database_->AddStrike(unique_id_1);
// 1st strike added for `unique_id_2`.
strike_database_->AddStrike(unique_id_2);
std::vector<base::Bucket> buckets = GetHistogramTester()->GetAllSamples(
"Autofill.StrikeDatabase.NthStrikeAdded."
"StrikeDatabaseIntegratorTest");
// There should be two buckets, one for 1st strike, one for 2nd strike count.
ASSERT_EQ(2U, buckets.size());
// Both `unique_id_1` and `unique_id_2` have 1st strikes recorded.
EXPECT_EQ(2, buckets[0].count);
// Only `unique_id_1` has 2nd strike recorded.
EXPECT_EQ(1, buckets[1].count);
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
StrikeDatabaseIntegratorUniqueIdTestClearAllStrikes) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id_1 = "1234";
const std::string unique_id_2 = "9876";
// 1 strike added for `unique_id_1`.
strike_database_->AddStrike(unique_id_1);
// 3 strikes added for `unique_id_2`.
strike_database_->AddStrikes(3, unique_id_2);
EXPECT_EQ(1, strike_database_->GetStrikes(unique_id_1));
EXPECT_EQ(3, strike_database_->GetStrikes(unique_id_2));
strike_database_->ClearAllStrikes();
EXPECT_EQ(0, strike_database_->GetStrikes(unique_id_1));
EXPECT_EQ(0, strike_database_->GetStrikes(unique_id_2));
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
AddStrikeForZeroAndNonZeroStrikesUniqueIdTest) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id = "1234";
EXPECT_EQ(0, strike_database_->GetStrikes(unique_id));
strike_database_->AddStrike(unique_id);
EXPECT_EQ(1, strike_database_->GetStrikes(unique_id));
strike_database_->AddStrike(unique_id);
EXPECT_EQ(2, strike_database_->GetStrikes(unique_id));
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
ClearStrikesForNonZeroStrikesUniqueIdTest) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id = "1234";
strike_database_->AddStrike(unique_id);
EXPECT_EQ(1, strike_database_->GetStrikes(unique_id));
strike_database_->ClearStrikes(unique_id);
EXPECT_EQ(0, strike_database_->GetStrikes(unique_id));
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
ClearStrikesForZeroStrikesUniqueIdTest) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id = "1234";
strike_database_->ClearStrikes(unique_id);
EXPECT_EQ(0, strike_database_->GetStrikes(unique_id));
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
RemoveExpiredStrikesUniqueIdTest) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id_1 = "1234";
const std::string unique_id_2 = "9876";
strike_database_->AddStrike(unique_id_1);
// Advance clock to past the entry for `unique_id_1`'s expiry time.
task_environment_.FastForwardBy(
strike_database_->GetExpiryTimeDelta().value() + base::Microseconds(1));
strike_database_->AddStrike(unique_id_2);
strike_database_->RemoveExpiredStrikes();
// `unique_id_1`'s entry should have its most recent strike expire, but
// `unique_id_2`'s should not.
EXPECT_EQ(0, strike_database_->GetStrikes(unique_id_1));
EXPECT_EQ(1, strike_database_->GetStrikes(unique_id_2));
// Advance clock to past `unique_id_2`'s expiry time.
task_environment_.FastForwardBy(
strike_database_->GetExpiryTimeDelta().value() + base::Microseconds(1));
strike_database_->RemoveExpiredStrikes();
// `unique_id_1` and `unique_id_2` should have no more unexpired strikes.
EXPECT_EQ(0, strike_database_->GetStrikes(unique_id_1));
EXPECT_EQ(0, strike_database_->GetStrikes(unique_id_2));
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest, CountEntries) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id_1 = "111";
const std::string unique_id_2 = "222";
const std::string unique_id_3 = "333";
EXPECT_EQ(0U, strike_database_->CountEntries());
strike_database_->AddStrike(unique_id_1);
EXPECT_EQ(1U, strike_database_->CountEntries());
strike_database_->AddStrike(unique_id_1);
EXPECT_EQ(1U, strike_database_->CountEntries());
strike_database_->AddStrike(unique_id_2);
strike_database_->AddStrike(unique_id_3);
EXPECT_EQ(3U, strike_database_->CountEntries());
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest, ClearStrikesForKeys) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id_1 = "111";
const std::string unique_id_2 = "222";
const std::string unique_id_3 = "333";
strike_database_->AddStrike(unique_id_1);
strike_database_->AddStrike(unique_id_2);
strike_database_->AddStrike(unique_id_3);
EXPECT_EQ(3U, strike_database_->CountEntries());
std::vector<std::string> keys_to_clear = {
strike_database_->GetKey(unique_id_1),
strike_database_->GetKey(unique_id_2)};
strike_database_->ClearStrikesForKeys(keys_to_clear);
EXPECT_EQ(1U, strike_database_->CountEntries());
EXPECT_EQ(0, strike_database_->GetStrikes(unique_id_1));
EXPECT_EQ(0, strike_database_->GetStrikes(unique_id_2));
EXPECT_EQ(1, strike_database_->GetStrikes(unique_id_3));
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest, IdFromKey) {
strike_database_->SetUniqueIdsRequired(true);
const std::string unique_id = "111";
std::string key = strike_database_->GetKey(unique_id);
ASSERT_EQ(key, "StrikeDatabaseIntegratorTest__111");
EXPECT_EQ(unique_id, strike_database_->GetIdFromKey(key));
}
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
LimitTheNumberOfElements) {
strike_database_->SetUniqueIdsRequired(true);
for (size_t i = 1; i <= 10; i++) {
strike_database_->AddStrike(base::NumberToString(i));
task_environment_.FastForwardBy(base::Microseconds(1));
EXPECT_EQ(i, strike_database_->CountEntries());
}
// Once the 11th element is added the cleanup should reduce the number of
// elements to 5. Note that the index here is chosen to be smaller than the
// previous indices. The purpose is to ensure that the deletion is actually
// done in the order of time stamp and not index.
strike_database_->AddStrike(base::NumberToString(0));
EXPECT_EQ(5U, strike_database_->CountEntries());
// Verify that the oldest 6 elements have been deleted.
for (size_t i = 1; i <= 10; i++) {
EXPECT_EQ(i <= 6 ? 0 : 1,
strike_database_->GetStrikes(base::NumberToString(i)));
}
}
// Test to ensure that `GetStrikeDatabaseDecision` function works correctly with
// the required latency since last strike requirement.
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
HasRequiredDelayPassedSinceLastStrike) {
strike_database_->SetUniqueIdsRequired(true);
strike_database_->SetRequiredDelaySinceLastStrike(base::Days(7));
strike_database_->AddStrike("fake key");
ASSERT_EQ(1U, strike_database_->CountEntries());
EXPECT_EQ(StrikeDatabaseIntegratorBase::kRequiredDelayNotPassed,
strike_database_->GetStrikeDatabaseDecision("fake key"));
task_environment_.FastForwardBy(base::Days(1));
EXPECT_EQ(StrikeDatabaseIntegratorBase::kRequiredDelayNotPassed,
strike_database_->GetStrikeDatabaseDecision("fake key"));
task_environment_.FastForwardBy(base::Days(7));
EXPECT_EQ(StrikeDatabaseIntegratorBase::kDoNotBlock,
strike_database_->GetStrikeDatabaseDecision("fake key"));
strike_database_->AddStrike("fake key");
EXPECT_EQ(StrikeDatabaseIntegratorBase::kRequiredDelayNotPassed,
strike_database_->GetStrikeDatabaseDecision("fake key"));
}
// Test to ensure `ShouldBlockFeature` returns correctly based on
// `GetStrikeDatabaseDecision` for the max strikes limit condition.
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
ShouldBlockFeature_MaxStrikes) {
EXPECT_FALSE(strike_database_->ShouldBlockFeature());
// Add max strikes.
strike_database_->AddStrikes(strike_database_->GetMaxStrikesLimit());
EXPECT_TRUE(strike_database_->ShouldBlockFeature());
}
// Test to ensure `ShouldBlockFeature` returns correctly based on
// `GetStrikeDatabaseDecision` for the required delay condition.
TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
ShouldBlockFeature_RequiredDelay) {
strike_database_->SetRequiredDelaySinceLastStrike(base::Days(7));
EXPECT_FALSE(strike_database_->ShouldBlockFeature());
// Add a single strike without advancing the clock.
strike_database_->AddStrike();
EXPECT_TRUE(strike_database_->ShouldBlockFeature());
}
} // namespace autofill
|