1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369
|
// Copyright 2025 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "content/browser/renderer_host/code_cache_host_impl.h"
#include "base/command_line.h"
#include "base/containers/span.h"
#include "base/feature_list.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/bind.h"
#include "base/functional/callback_forward.h"
#include "base/run_loop.h"
#include "base/task/sequenced_task_runner.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "base/time/time.h"
#include "content/browser/child_process_security_policy_impl.h"
#include "content/browser/code_cache/generated_code_cache_context.h"
#include "content/browser/process_lock.h"
#include "content/browser/site_instance_impl.h"
#include "content/public/common/content_switches.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/test_browser_context.h"
#include "mojo/public/cpp/base/big_buffer.h"
#include "net/base/features.h"
#include "net/http/http_cache.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/features.h"
namespace content {
// Parametrized on whether strict isolation is activated or not.
class CodeCacheHostImplTest : public testing::Test,
public testing::WithParamInterface<bool> {
public:
CodeCacheHostImplTest() {
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
if (IsSitePerProcessOrStricter()) {
command_line->AppendSwitch(switches::kSitePerProcess);
} else {
command_line->RemoveSwitch(switches::kSitePerProcess);
command_line->AppendSwitch(switches::kDisableSiteIsolation);
}
feature_list_.InitWithFeatures(
{blink::features::kUsePersistentCacheForCodeCache,
net::features::kSplitCacheByNetworkIsolationKey},
{});
CHECK(temp_dir_.CreateUniqueTempDir());
generated_code_cache_context_ =
base::MakeRefCounted<GeneratedCodeCacheContext>();
generated_code_cache_context_->Initialize(temp_dir_.GetPath(), 0);
}
~CodeCacheHostImplTest() override {
generated_code_cache_context_->Shutdown();
ChildProcessSecurityPolicyImpl* p =
ChildProcessSecurityPolicyImpl::GetInstance();
for (int renderer_id : added_renderers_) {
p->Remove(renderer_id);
}
}
bool IsSitePerProcessOrStricter() { return GetParam(); }
void SetupRendererWithLock(int process_id, const GURL& url) {
ChildProcessSecurityPolicyImpl* p =
ChildProcessSecurityPolicyImpl::GetInstance();
p->AddForTesting(process_id, &browser_context_);
scoped_refptr<SiteInstanceImpl> site_instance =
SiteInstanceImpl::CreateForTesting(&browser_context_, url);
ChildProcessSecurityPolicyImpl::GetInstance()->LockProcess(
site_instance->GetIsolationContext(), process_id, false,
ProcessLock::FromSiteInfo(site_instance->GetSiteInfo()));
added_renderers_.push_back(process_id);
}
protected:
BrowserTaskEnvironment task_environment_;
std::vector<int> added_renderers_;
TestBrowserContext browser_context_;
base::test::ScopedFeatureList feature_list_;
base::ScopedTempDir temp_dir_;
scoped_refptr<GeneratedCodeCacheContext> generated_code_cache_context_;
};
// PersistentCache is not supported on Fuchsia.
#if !BUILDFLAG(IS_FUCHSIA)
// Validates that improper site isolation setup (no valid process lock in
// renderer) leads to no use of the cache if full site isolation is activated.
// Under !IsSitePerProcessOrStricter() it instead means that the cache is usable
// and that entries are grouped under the same context for unlocked processes.
TEST_P(CodeCacheHostImplTest, PersistentCacheNoCachingWhenNoProperIsolation) {
const base::Time response_time = base::Time::Now();
const std::string data_str = "some data";
const mojo_base::BigBuffer data(base::as_byte_span(data_str));
const GURL url("http://example.com/script.js");
// The lack of a SetupRendererWithLock call for this process ID means
// `GetSecondaryKeyForCodeCache` will return an empty GURL, which causes this
// renderer to use the shared context key.
const int process_id = 12;
{
base::RunLoop runloop;
auto quit_closure = runloop.QuitClosure();
net::NetworkIsolationKey nik(net::SchemefulSite{url},
net::SchemefulSite{url});
GeneratedCodeCacheContext::RunOrPostTask(
generated_code_cache_context_.get(), FROM_HERE,
base::BindLambdaForTesting([&]() {
CodeCacheHostImpl host(
process_id, generated_code_cache_context_, nik,
blink::StorageKey::CreateFirstParty(url::Origin::Create(url)));
// No way to confirm right away but storing should fail when
// !IsSitePerProcessOrStricter().
host.DidGenerateCacheableMetadata(
blink::mojom::CodeCacheType::kJavascript, url, response_time,
data.Clone());
if (IsSitePerProcessOrStricter()) {
// No data was stored so fetching fails.
host.FetchCachedCode(
blink::mojom::CodeCacheType::kJavascript, url,
base::BindOnce(
[&](base::OnceClosure quit_closure,
base::Time response_time, mojo_base::BigBuffer data) {
// Ensure data is empty.
EXPECT_EQ(response_time, base::Time());
EXPECT_EQ(data.byte_span(),
mojo_base::BigBuffer().byte_span());
std::move(quit_closure).Run();
},
quit_closure));
} else {
// Fetching of stored data succeeds.
host.FetchCachedCode(
blink::mojom::CodeCacheType::kJavascript, url,
base::BindOnce(
[&](base::Time expected_response_time,
const std::string& expected_data,
base::OnceClosure quit_closure,
base::Time response_time, mojo_base::BigBuffer data) {
EXPECT_EQ(expected_response_time, response_time);
EXPECT_EQ(expected_data,
std::string(
reinterpret_cast<const char*>(data.data()),
data.size()));
std::move(quit_closure).Run();
},
response_time, data_str, quit_closure));
}
}));
runloop.Run();
}
}
TEST_P(CodeCacheHostImplTest,
PersistentCacheLockedAndUnlockedProcessesShareNoData) {
const base::Time response_time = base::Time::Now();
const std::string data_str = "some data";
const mojo_base::BigBuffer data(base::as_byte_span(data_str));
const base::Time other_response_time = response_time + base::Minutes(1);
const std::string other_data_str = "some other data";
const mojo_base::BigBuffer other_data(base::as_byte_span(other_data_str));
const GURL url("http://example.com/script.js");
net::NetworkIsolationKey nik(net::SchemefulSite{url},
net::SchemefulSite{url});
const int locked_process_id = 12;
SetupRendererWithLock(locked_process_id, url);
// The lack of a SetupRendererWithLock call for this process ID means
// `GetSecondaryKeyForCodeCache` will return an empty GURL, which causes this
// renderer to use the shared context key.
const int unlocked_process_id = 24;
// Locked process stores data.
{
GeneratedCodeCacheContext::RunOrPostTask(
generated_code_cache_context_.get(), FROM_HERE,
base::BindLambdaForTesting([&]() {
CodeCacheHostImpl host(
locked_process_id, generated_code_cache_context_, nik,
blink::StorageKey::CreateFirstParty(url::Origin::Create(url)));
host.DidGenerateCacheableMetadata(
blink::mojom::CodeCacheType::kJavascript, url, response_time,
data.Clone());
}));
}
// Unlocked process.
{
base::RunLoop runloop;
auto quit_closure = runloop.QuitClosure();
GeneratedCodeCacheContext::RunOrPostTask(
generated_code_cache_context_.get(), FROM_HERE,
base::BindLambdaForTesting([&]() {
CodeCacheHostImpl host(
unlocked_process_id, generated_code_cache_context_, nik,
blink::StorageKey::CreateFirstParty(url::Origin::Create(url)));
// Unlocked process cannot see the data stored by the locked process,
// even with the same NIK.
host.FetchCachedCode(
blink::mojom::CodeCacheType::kJavascript, url,
base::BindOnce(
[&](base::OnceClosure quit_closure, base::Time response_time,
mojo_base::BigBuffer data) {
// Ensure data is empty.
EXPECT_EQ(response_time, base::Time());
EXPECT_EQ(data.byte_span(),
mojo_base::BigBuffer().byte_span());
std::move(quit_closure).Run();
},
quit_closure));
// Store some other data to attempt to retrieve it from the locked
// process.
host.DidGenerateCacheableMetadata(
blink::mojom::CodeCacheType::kJavascript, url,
other_response_time, other_data.Clone());
}));
runloop.Run();
}
// Locked process cannot access data stored from shared context.
{
base::RunLoop runloop;
auto quit_closure = runloop.QuitClosure();
GeneratedCodeCacheContext::RunOrPostTask(
generated_code_cache_context_.get(), FROM_HERE,
base::BindLambdaForTesting([&]() {
CodeCacheHostImpl host(
locked_process_id, generated_code_cache_context_, nik,
blink::StorageKey::CreateFirstParty(url::Origin::Create(url)));
// Locked process cannot see the data stored by the unlocked process
// and sees its own copy, even with the same NIK.
host.FetchCachedCode(
blink::mojom::CodeCacheType::kJavascript, url,
base::BindOnce(
[&](base::Time expected_response_time,
const std::string& expected_data,
base::OnceClosure quit_closure, base::Time response_time,
mojo_base::BigBuffer data) {
EXPECT_EQ(expected_response_time, response_time);
EXPECT_EQ(
expected_data,
std::string(reinterpret_cast<const char*>(data.data()),
data.size()));
std::move(quit_closure).Run();
},
response_time, data_str, quit_closure));
}));
runloop.Run();
}
}
// This test is parameterized to run with and without strict site isolation
// enabled. With a locked process, caching should succeed regardless of the
// isolation mode.
TEST_P(CodeCacheHostImplTest, PersistentCacheWriteAndReadFullIsolationSetup) {
const base::Time response_time = base::Time::Now();
const std::string data_str = "some data";
const mojo_base::BigBuffer data(base::as_byte_span(data_str));
const GURL original_resource_url("http://example.com/script.js");
// Storing and retrieving for from the same isolation context works.
{
base::RunLoop runloop;
auto quit_closure = runloop.QuitClosure();
GURL url = original_resource_url;
net::NetworkIsolationKey nik(net::SchemefulSite{url},
net::SchemefulSite{url});
const int process_id = 12;
SetupRendererWithLock(process_id, url);
GeneratedCodeCacheContext::RunOrPostTask(
generated_code_cache_context_.get(), FROM_HERE,
base::BindLambdaForTesting([&]() {
CodeCacheHostImpl host(
process_id, generated_code_cache_context_, nik,
blink::StorageKey::CreateFirstParty(url::Origin::Create(url)));
host.DidGenerateCacheableMetadata(
blink::mojom::CodeCacheType::kJavascript, url, response_time,
data.Clone());
host.FetchCachedCode(
blink::mojom::CodeCacheType::kJavascript, url,
base::BindOnce(
[&](base::Time expected_response_time,
const std::string& expected_data,
base::OnceClosure quit_closure, base::Time response_time,
mojo_base::BigBuffer data) {
EXPECT_EQ(expected_response_time, response_time);
EXPECT_EQ(
expected_data,
std::string(reinterpret_cast<const char*>(data.data()),
data.size()));
std::move(quit_closure).Run();
},
response_time, data_str, quit_closure));
}));
runloop.Run();
}
// Attempting to retrieve code for `original_resource_url` from a different
// isolation context does not work and instead returns default values.
{
base::RunLoop runloop;
auto quit_closure = runloop.QuitClosure();
GURL url("http://other.com/script.js");
net::NetworkIsolationKey nik(net::SchemefulSite{url},
net::SchemefulSite{url});
const int process_id = 24;
SetupRendererWithLock(process_id, url);
GeneratedCodeCacheContext::RunOrPostTask(
generated_code_cache_context_.get(), FROM_HERE,
base::BindLambdaForTesting([&]() {
CodeCacheHostImpl host(
process_id, generated_code_cache_context_, nik,
blink::StorageKey::CreateFirstParty(url::Origin::Create(url)));
host.FetchCachedCode(
blink::mojom::CodeCacheType::kJavascript, original_resource_url,
base::BindOnce(
[&](base::OnceClosure quit_closure, base::Time response_time,
mojo_base::BigBuffer data) {
// Ensure data is empty.
EXPECT_EQ(response_time, base::Time());
EXPECT_EQ(data.byte_span(),
mojo_base::BigBuffer().byte_span());
std::move(quit_closure).Run();
},
quit_closure));
}));
runloop.Run();
}
}
INSTANTIATE_TEST_SUITE_P(All,
CodeCacheHostImplTest,
testing::Values(true, false));
#endif // !BUILDFLAG(IS_FUCHSIA)
} // namespace content
|