1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/browser_window.h"
#import <Cocoa/Cocoa.h>
#include <memory>
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/app_controller_mac.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/lifetime/application_lifetime_desktop.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/bookmarks/bookmark_editor.h"
#include "chrome/browser/ui/browser_command_controller.h"
#include "chrome/browser/ui/views/bookmarks/bookmark_editor_view.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/remote_cocoa/app_shim/native_widget_mac_nswindow.h"
#include "content/public/common/content_switches.h"
#include "content/public/test/browser_test.h"
#include "testing/gtest_mac.h"
#include "ui/accessibility/accessibility_switches.h"
#import "ui/base/cocoa/window_size_constants.h"
#include "ui/base/test/ns_ax_tree_validator.h"
// Test harness for Mac-specific behaviors of BrowserWindow.
class BrowserWindowMacTest : public InProcessBrowserTest {
public:
BrowserWindowMacTest() = default;
BrowserWindowMacTest(const BrowserWindowMacTest&) = delete;
BrowserWindowMacTest& operator=(const BrowserWindowMacTest&) = delete;
};
// Test that mainMenu commands do not attempt to validate against a Browser*
// that is destroyed.
IN_PROC_BROWSER_TEST_F(BrowserWindowMacTest, MenuCommandsAfterDestroy) {
// Simulate AppKit (e.g. NSMenu) retaining an NSWindow.
NSWindow* window = browser()->window()->GetNativeWindow().GetNativeNSWindow();
NSMenuItem* bookmark_menu_item =
[[[[NSApp mainMenu] itemWithTag:IDC_BOOKMARKS_MENU] submenu]
itemWithTag:IDC_BOOKMARK_THIS_TAB];
EXPECT_TRUE(window);
EXPECT_TRUE(bookmark_menu_item);
chrome::CloseAllBrowsersAndQuit();
ui_test_utils::WaitForBrowserToClose();
EXPECT_EQ([bookmark_menu_item action], @selector(commandDispatch:));
// Try validating a command via the NSUserInterfaceValidation protocol.
// With the delegates removed, CommandDispatcher ends up calling into the
// NSWindow (e.g. NativeWidgetMacNSWindow)'s defaultValidateUserInterfaceItem,
// which currently asks |super|. That is, NSWindow. Which says YES.
EXPECT_TRUE([window validateUserInterfaceItem:bookmark_menu_item]);
}
// Test that mainMenu commands from child windows are validated by the window
// chain.
// TODO(crbug.com/40898643): Disabled because this test is flaky.
IN_PROC_BROWSER_TEST_F(BrowserWindowMacTest,
DISABLED_MenuCommandsFromChildWindow) {
NativeWidgetMacNSWindow* window =
base::apple::ObjCCastStrict<NativeWidgetMacNSWindow>(
browser()->window()->GetNativeWindow().GetNativeNSWindow());
// Create a child window.
NativeWidgetMacNSWindow* child_window = [[NativeWidgetMacNSWindow alloc]
initWithContentRect:ui::kWindowSizeDeterminedLater
styleMask:NSWindowStyleMaskBorderless
backing:NSBackingStoreBuffered
defer:NO];
child_window.releasedWhenClosed = NO;
[window addChildWindow:child_window ordered:NSWindowAbove];
NSMenuItem* show_bookmark_bar_menu_item =
[[[[NSApp mainMenu] itemWithTag:IDC_VIEW_MENU] submenu]
itemWithTag:IDC_SHOW_BOOKMARK_BAR];
// Make sure both windows validate the bookmark bar menu item.
EXPECT_TRUE([window validateUserInterfaceItem:show_bookmark_bar_menu_item]);
EXPECT_TRUE(
[child_window validateUserInterfaceItem:show_bookmark_bar_menu_item]);
browser()->command_controller()->UpdateCommandEnabled(
show_bookmark_bar_menu_item.tag, false);
// Make sure both windows find the bookmark bar menu item invalid. The child
// window check is the focus of this test. The child window does not have a
// UserInterfaceItemCommandHandler. This test ensures the validation request
// bubbles up to the parent window.
EXPECT_FALSE([window validateUserInterfaceItem:show_bookmark_bar_menu_item]);
EXPECT_FALSE(
[child_window validateUserInterfaceItem:show_bookmark_bar_menu_item]);
}
class BrowserWindowMacA11yTest : public BrowserWindowMacTest {
public:
BrowserWindowMacA11yTest() = default;
BrowserWindowMacA11yTest(const BrowserWindowMacA11yTest&) = delete;
BrowserWindowMacA11yTest& operator=(const BrowserWindowMacA11yTest&) = delete;
~BrowserWindowMacA11yTest() override = default;
void SetUpCommandLine(base::CommandLine* command_line) override {
BrowserWindowMacTest::SetUpCommandLine(command_line);
command_line->AppendSwitch(switches::kForceRendererAccessibility);
}
};
IN_PROC_BROWSER_TEST_F(BrowserWindowMacA11yTest, A11yTreeIsWellFormed) {
NSWindow* window = browser()->window()->GetNativeWindow().GetNativeNSWindow();
size_t nodes_visited = 0;
std::optional<ui::NSAXTreeProblemDetails> details =
ui::ValidateNSAXTree(window, &nodes_visited);
EXPECT_FALSE(details.has_value()) << details->ToString();
// There should be at least a handful of AX nodes in the tree - fail this test
// if for some reason (eg) the window has no children, which would otherwise
// be a well-formed AX tree.
EXPECT_GE(nodes_visited, 10U);
if (HasFailure()) {
ui::PrintNSAXTree(window);
}
}
IN_PROC_BROWSER_TEST_F(BrowserWindowMacA11yTest,
AccessibilityDocumentExposedOnWindow) {
GURL url_before(R"HTML(data:text/html,before)HTML");
EXPECT_TRUE(AddTabAtIndex(0, url_before, ui::PAGE_TRANSITION_TYPED));
NSWindow* window = browser()->window()->GetNativeWindow().GetNativeNSWindow();
ASSERT_NE(nullptr, window);
EXPECT_NSEQ([NSString stringWithUTF8String:url_before.spec().c_str()],
[window accessibilityDocument]);
GURL url_after(R"HTML(data:text/html,after)HTML");
EXPECT_TRUE(AddTabAtIndex(1, url_after, ui::PAGE_TRANSITION_TYPED));
EXPECT_NSEQ([NSString stringWithUTF8String:url_after.spec().c_str()],
[window accessibilityDocument]);
}
IN_PROC_BROWSER_TEST_F(BrowserWindowMacTest, DisableCommandsWhenSheetAttached) {
NSWindow* window = browser()->window()->GetNativeWindow().GetNativeNSWindow();
ASSERT_FALSE([AppController.sharedController keyWindowIsModal]);
// Retrieve and initialize the menu items for
// IDC_BOOKMARK_ALL_TABS / IDC_PRINT / IDC_SAVE_PAGE.
ASSERT_TRUE(
AddTabAtIndex(0, GURL("chrome://newtab/"), ui::PAGE_TRANSITION_TYPED));
NSMenuItem* bookmark_all_tabs_item =
[[[[NSApp mainMenu] itemWithTag:IDC_BOOKMARKS_MENU] submenu]
itemWithTag:IDC_BOOKMARK_ALL_TABS];
ASSERT_TRUE(bookmark_all_tabs_item);
NSMenuItem* print_item = [[[[NSApp mainMenu] itemWithTag:IDC_FILE_MENU]
submenu] itemWithTag:IDC_PRINT];
ASSERT_TRUE(print_item);
NSMenuItem* save_item = [[[[NSApp mainMenu] itemWithTag:IDC_FILE_MENU]
submenu] itemWithTag:IDC_SAVE_PAGE];
ASSERT_TRUE(save_item);
// These commands should be enabled when the sheet is not attached.
EXPECT_TRUE([window validateUserInterfaceItem:bookmark_all_tabs_item]);
EXPECT_TRUE([window validateUserInterfaceItem:print_item]);
EXPECT_TRUE([window validateUserInterfaceItem:save_item]);
// Open bookmark sheet dialog.
auto* bookmark_model =
BookmarkModelFactory::GetForBrowserContext(browser()->profile());
auto editor = std::make_unique<BookmarkEditorView>(
browser()->profile(),
BookmarkEditor::EditDetails::MoveNodes(
bookmark_model,
{bookmark_model->AddURL(bookmark_model->other_node(), 0, u"bookmark",
GURL("http://www.google.com"))}),
BookmarkEditor::SHOW_TREE, base::DoNothing());
editor->Show(browser()->window()->GetNativeWindow());
auto* editor_raw = editor.release();
ASSERT_TRUE([AppController.sharedController keyWindowIsModal]);
// These commands should be disabled when the sheet is attached.
EXPECT_FALSE([window validateUserInterfaceItem:bookmark_all_tabs_item]);
EXPECT_FALSE([window validateUserInterfaceItem:print_item]);
EXPECT_FALSE([window validateUserInterfaceItem:save_item]);
// Close the sheet dialog.
editor_raw->GetWidget()->CloseNow();
ASSERT_FALSE([AppController.sharedController keyWindowIsModal]);
// These commands should be enabled again when the sheet is removed.
EXPECT_TRUE([window validateUserInterfaceItem:bookmark_all_tabs_item]);
EXPECT_TRUE([window validateUserInterfaceItem:print_item]);
EXPECT_TRUE([window validateUserInterfaceItem:save_item]);
}
|
