1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327
|
// Copyright 2025 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/extensions/extensions_menu_view_model.h"
#include "chrome/browser/extensions/extension_action_runner.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/permissions/permissions_updater.h"
#include "chrome/browser/extensions/permissions/scripting_permissions_modifier.h"
#include "chrome/browser/extensions/permissions/site_permissions_helper.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/extensions/extensions_menu_view_platform_delegate.h"
#include "components/crx_file/id_util.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/permissions_manager.h"
#include "extensions/common/extension_builder.h"
#include "extensions/test/test_extension_dir.h"
#include "net/dns/mock_host_resolver.h"
static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
namespace {
using PermissionsManager = extensions::PermissionsManager;
using SitePermissionsHelper = extensions::SitePermissionsHelper;
// A mock extensions menu platform delegate.
class TestPlatformDelegate : public ExtensionsMenuViewPlatformDelegate {
public:
TestPlatformDelegate() = default;
~TestPlatformDelegate() override = default;
void AttachToModel(ExtensionsMenuViewModel* model) override {}
void DetachFromModel() override {}
void OnHostAccessRequestAddedOrUpdated(
const extensions::ExtensionId& extension_id,
content::WebContents* web_contents) override {}
void OnAccessRequestRemoved(
const extensions::ExtensionId& extension_id) override {}
void OnAccessRequestsCleared() override {}
void OnAccessRequestDismissedByUser(
const extensions::ExtensionId& extension_id) override {}
void OnActionAdded(const ToolbarActionsModel::ActionId& action_id) override {}
};
} // namespace
class ExtensionsMenuViewModelBrowserTest
: public extensions::ExtensionBrowserTest {
public:
ExtensionsMenuViewModelBrowserTest() = default;
~ExtensionsMenuViewModelBrowserTest() override = default;
// Adds an extension with the given `host_permission`.
scoped_refptr<const extensions::Extension> AddExtensionWithHostPermission(
const std::string& name,
const std::string& host_permission);
// Adds an extension with `activeTab` permission.
scoped_refptr<const extensions::Extension> AddActiveTabExtension(
const std::string& name);
// Adds an `extension` with the given `host_permissions`,
// `permissions` and `location`.
scoped_refptr<const extensions::Extension> AddExtension(
const std::string& name,
const std::vector<std::string>& permissions,
const std::vector<std::string>& host_permissions);
ExtensionsMenuViewModel* menu_model() { return menu_model_.get(); }
SitePermissionsHelper* permissions_helper() {
return permissions_helper_.get();
}
PermissionsManager* permissions_manager() { return permissions_manager_; }
// ExtensionBrowserTest:
void SetUpOnMainThread() override;
void TearDownOnMainThread() override;
private:
std::unique_ptr<ExtensionsMenuViewModel> menu_model_;
std::unique_ptr<SitePermissionsHelper> permissions_helper_;
raw_ptr<PermissionsManager> permissions_manager_;
};
scoped_refptr<const extensions::Extension>
ExtensionsMenuViewModelBrowserTest::AddExtensionWithHostPermission(
const std::string& name,
const std::string& host_permission) {
return AddExtension(name, /*permissions=*/{}, {host_permission});
}
scoped_refptr<const extensions::Extension>
ExtensionsMenuViewModelBrowserTest::AddActiveTabExtension(
const std::string& name) {
return AddExtension(name, /*permissions=*/{"activeTab"},
/*host_permissions=*/{});
}
scoped_refptr<const extensions::Extension>
ExtensionsMenuViewModelBrowserTest::AddExtension(
const std::string& name,
const std::vector<std::string>& permissions,
const std::vector<std::string>& host_permissions) {
scoped_refptr<const extensions::Extension> extension =
extensions::ExtensionBuilder(name)
.AddAPIPermissions(permissions)
.AddHostPermissions(host_permissions)
.SetID(crx_file::id_util::GenerateId(name))
.Build();
extension_registrar()->AddExtension(extension.get());
return extension;
}
void ExtensionsMenuViewModelBrowserTest::SetUpOnMainThread() {
ExtensionBrowserTest::SetUpOnMainThread();
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(embedded_test_server()->Start());
menu_model_ = std::make_unique<ExtensionsMenuViewModel>(
browser_window_interface(), std::make_unique<TestPlatformDelegate>());
permissions_helper_ = std::make_unique<SitePermissionsHelper>(profile());
permissions_manager_ = PermissionsManager::Get(profile());
}
void ExtensionsMenuViewModelBrowserTest::ExtensionsMenuViewModelBrowserTest::
TearDownOnMainThread() {
permissions_manager_ = nullptr;
permissions_helper_.reset();
menu_model_.reset();
ExtensionBrowserTest::TearDownOnMainThread();
}
// Tests that the extensions menu view model correctly updates the site access
// for an extension.
IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewModelBrowserTest, UpdateSiteAccess) {
// Add extension that requests host permissions.
scoped_refptr<const extensions::Extension> extension =
AddExtensionWithHostPermission("Extension", "<all_urls>");
// Navigate to a site the extension has site access to.
const GURL url =
embedded_test_server()->GetURL("example.com", "/simple.html");
ASSERT_TRUE(NavigateToURL(GetActiveWebContents(), url));
content::WebContents* web_contents = GetActiveWebContents();
// Verify default initial site access is "on all sites".
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnAllSites);
// Update site access to "on site".
menu_model()->UpdateSiteAccess(extension->id(),
PermissionsManager::UserSiteAccess::kOnSite);
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kGranted);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnSite);
// Update site access to "on click".
menu_model()->UpdateSiteAccess(extension->id(),
PermissionsManager::UserSiteAccess::kOnClick);
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kWithheld);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnClick);
}
// Tests that the extensions menu view model correctly grants site access to an
// extension that requests hosts permissions and access is currently withheld.
IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewModelBrowserTest,
GrantSiteAccess_HostPermission) {
// Add extension that requests host permissions, and withheld site access.
scoped_refptr<const extensions::Extension> extension =
AddExtensionWithHostPermission("Extension", "*://example.com/*");
extensions::ScriptingPermissionsModifier modifier(profile(), extension);
modifier.SetWithholdHostPermissions(true);
// Navigate to a site the extension requested access to.
const GURL url =
embedded_test_server()->GetURL("example.com", "/simple.html");
ASSERT_TRUE(NavigateToURL(GetActiveWebContents(), url));
content::WebContents* web_contents = GetActiveWebContents();
// Verify site interaction is 'withheld' and site access is 'on click'
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kWithheld);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnClick);
// Granting site access changes site interaction to 'granted' and site access
// to 'on site'.
menu_model()->GrantSiteAccess(extension->id());
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kGranted);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnSite);
}
// Tests that the extensions menu view model correctly grants site
// access for an extension with activeTab permission.
IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewModelBrowserTest,
GrantSiteAccess_ActiveTab) {
// Add extension with activeTab permission.
scoped_refptr<const extensions::Extension> extension =
AddActiveTabExtension("Extension");
// Navigate to any (unrestricted) site.
const GURL url =
embedded_test_server()->GetURL("example.com", "/simple.html");
ASSERT_TRUE(NavigateToURL(GetActiveWebContents(), url));
content::WebContents* web_contents = GetActiveWebContents();
// Verify site interaction is 'activeTab' and site access is 'on click'
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnClick);
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kActiveTab);
// Granting site access changes site interaction to 'granted' but site access
// remains 'on click', since it's a one-time grant.
menu_model()->GrantSiteAccess(extension->id());
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kGranted);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnClick);
}
// Tests that the extensions menu view model correctly revokes site access to an
// extension that requests hosts permissions and access is currently granted.
IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewModelBrowserTest,
RevokeSiteAccess_HostPermission) {
// Add extension that requests host permissions, which are granted by default.
scoped_refptr<const extensions::Extension> extension =
AddExtensionWithHostPermission("Extension", "*://example.com/*");
// Navigate to a site the extension requested access to.
const GURL url =
embedded_test_server()->GetURL("example.com", "/simple.html");
ASSERT_TRUE(NavigateToURL(GetActiveWebContents(), url));
content::WebContents* web_contents = GetActiveWebContents();
// Verify site interaction is 'granted' and site access is 'on site'
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kGranted);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnSite);
// Revoking site access changes site interaction to 'withheld' and site access
// to 'on click'
menu_model()->RevokeSiteAccess(extension->id());
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kWithheld);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnClick);
}
// Tests that the extensions menu view model correctly revokes site
// access for an extension with granted activeTab permission.
IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewModelBrowserTest,
RevokeSiteAccess_ActiveTab) {
// Add extension with activeTab permission.
scoped_refptr<const extensions::Extension> extension =
AddActiveTabExtension("Extension");
// Navigate to any (unrestricted) site.
const GURL url =
embedded_test_server()->GetURL("example.com", "/simple.html");
ASSERT_TRUE(NavigateToURL(GetActiveWebContents(), url));
content::WebContents* web_contents = GetActiveWebContents();
// Grant one-time site access to the extension.
extensions::ExtensionActionRunner* action_runner =
extensions::ExtensionActionRunner::GetForWebContents(web_contents);
ASSERT_TRUE(action_runner);
action_runner->GrantTabPermissions({extension.get()});
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kGranted);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnClick);
// Revoking site access changes site interaction to 'activeTab' and site
// access remains 'on click'.
menu_model()->RevokeSiteAccess(extension->id());
EXPECT_EQ(permissions_helper()->GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kActiveTab);
EXPECT_EQ(permissions_manager()->GetUserSiteAccess(
*extension, web_contents->GetLastCommittedURL()),
PermissionsManager::UserSiteAccess::kOnClick);
}
// Tests that the extensions menu view model correctly updates the site setting
// for an extension.
IN_PROC_BROWSER_TEST_F(ExtensionsMenuViewModelBrowserTest, UpdateSiteSetting) {
// Add extension that requests host permissions.
scoped_refptr<const extensions::Extension> extension =
AddExtensionWithHostPermission("Extension", "<all_urls>");
// Navigate to a site the extension has site access to.
const GURL url =
embedded_test_server()->GetURL("example.com", "/simple.html");
ASSERT_TRUE(NavigateToURL(GetActiveWebContents(), url));
auto origin = url::Origin::Create(url);
// Verify default initial site setting is "customize by extension".
EXPECT_EQ(permissions_manager()->GetUserSiteSetting(origin),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
// Update site setting to "block all extensions".
menu_model()->UpdateSiteSetting(
PermissionsManager::UserSiteSetting::kBlockAllExtensions);
EXPECT_EQ(permissions_manager()->GetUserSiteSetting(origin),
PermissionsManager::UserSiteSetting::kBlockAllExtensions);
}
|