File: cookie-string-view.patch

package info (click to toggle)
chromium 143.0.7499.40-1
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 6,343,624 kB
  • sloc: cpp: 35,786,473; ansic: 7,477,456; javascript: 4,249,966; python: 1,480,744; xml: 764,791; asm: 710,816; pascal: 188,028; sh: 89,200; perl: 88,692; objc: 79,984; sql: 57,625; cs: 42,265; fortran: 24,101; makefile: 22,508; tcl: 15,277; php: 14,018; yacc: 9,043; ruby: 7,553; awk: 3,720; lisp: 3,233; lex: 1,330; ada: 727; jsp: 228; sed: 36
file content (32 lines) | stat: -rw-r--r-- 1,472 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
author: Andres Salomon <dilinger@debian.org>

revert one std::string -> string_view conversion due to the following erorr:


../../net/cookies/cookie_util.cc:844:31: error: no viable conversion from 'const_iterator' (aka 'const char *') to 'std::string::const_iterator' (aka '__wrap_iter<const char *>')
  844 |   std::string::const_iterator i = header_value.begin();
      |                               ^   ~~~~~~~~~~~~~~~~~~~~


--- a/net/cookies/cookie_util.cc
+++ b/net/cookies/cookie_util.cc
@@ -839,7 +839,7 @@ bool IsCookiePartitionedValid(const GURL
   return result;
 }
 
-void ParseRequestCookieLine(std::string_view header_value,
+void ParseRequestCookieLine(const std::string& header_value,
                             ParsedRequestCookies* parsed_cookies) {
   std::string::const_iterator i = header_value.begin();
   while (i != header_value.end()) {
--- a/net/cookies/cookie_util.h
+++ b/net/cookies/cookie_util.h
@@ -301,7 +301,7 @@ using ParsedRequestCookies = std::vector
 // these will appear in |parsed_cookies| as well. The cookie header can be
 // written by non-Chromium consumers (such as extensions), so the header may not
 // be well-formed.
-NET_EXPORT void ParseRequestCookieLine(std::string_view header_value,
+NET_EXPORT void ParseRequestCookieLine(const std::string& header_value,
                                        ParsedRequestCookies* parsed_cookies);
 
 // Writes all cookies of |parsed_cookies| into a HTTP Request header value