1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "media/gpu/test/video_encoder/decoder_buffer_validator.h"
#include <set>
#include <vector>
#include "base/logging.h"
#include "base/memory/scoped_refptr.h"
#include "base/numerics/safe_conversions.h"
#include "build/buildflag.h"
#include "media/base/decoder_buffer.h"
#include "media/gpu/buildflags.h"
#include "media/gpu/h264_decoder.h"
#include "media/gpu/macros.h"
#include "media/parsers/bit_reader_macros.h"
#include "media/parsers/h264_bit_reader.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace media {
namespace test {
namespace {
int VideoCodecProfileToH264ProfileIDC(VideoCodecProfile profile) {
switch (profile) {
case H264PROFILE_BASELINE:
return H264SPS::kProfileIDCBaseline;
case H264PROFILE_MAIN:
return H264SPS::kProfileIDCMain;
case H264PROFILE_HIGH:
return H264SPS::kProfileIDCHigh;
default:
LOG(ERROR) << "Unexpected video profile: " << GetProfileName(profile);
}
return H264SPS::kProfileIDCMain;
}
int VideoCodecProfileToVP9Profile(VideoCodecProfile profile) {
switch (profile) {
case VP9PROFILE_PROFILE0:
return 0;
default:
LOG(ERROR) << "Unexpected video profile: " << GetProfileName(profile);
}
return 0;
}
struct H264PrefixNALU {
int nal_ref_idc;
int nal_unit_type;
bool svc_extension_flag;
// SVC extension NAL unit header.
bool idr_flag;
uint8_t priority_id;
bool no_inter_layer_pred_flag;
uint8_t dependency_id;
uint8_t quality_id;
uint8_t temporal_id;
bool use_ref_base_pic_flag;
bool discardable_flag;
bool output_flag;
// RBSP
bool store_ref_base_pic_flag;
};
std::optional<H264PrefixNALU> ParseH264Prefix(const H264NALU& nalu) {
H264PrefixNALU res;
constexpr auto kInvalidStream = std::nullopt;
res.nal_ref_idc = nalu.nal_ref_idc;
res.nal_unit_type = nalu.nal_unit_type;
H264BitReader br_;
if (!br_.Initialize(nalu.data)) {
return std::nullopt;
}
// Skip first one byte as it's NALU header.
SKIP_BITS_OR_RETURN(8);
READ_BOOL_OR_RETURN(&res.svc_extension_flag);
if (res.svc_extension_flag) {
READ_BOOL_OR_RETURN(&res.idr_flag);
READ_BITS_OR_RETURN(6, &res.priority_id);
READ_BOOL_OR_RETURN(&res.no_inter_layer_pred_flag);
READ_BITS_OR_RETURN(3, &res.dependency_id);
READ_BITS_OR_RETURN(4, &res.quality_id);
READ_BITS_OR_RETURN(3, &res.temporal_id);
READ_BOOL_OR_RETURN(&res.use_ref_base_pic_flag);
READ_BOOL_OR_RETURN(&res.discardable_flag);
READ_BOOL_OR_RETURN(&res.output_flag);
uint8_t reserved_three_2bits = 0;
READ_BITS_OR_RETURN(2, &reserved_three_2bits);
if (reserved_three_2bits != 3) {
LOG(ERROR) << "reserved_three_2bits must be 3";
return std::nullopt;
}
}
// RBSP
if (res.nal_ref_idc != 0) {
READ_BOOL_OR_RETURN(&res.store_ref_base_pic_flag);
if ((res.use_ref_base_pic_flag || res.store_ref_base_pic_flag) &&
res.idr_flag) {
LOG(ERROR) << "Don't support parsing dec_ref_base_pic_marking()";
return std::nullopt;
}
bool additional_prefix_nal_unit_extension_flag = false;
READ_BOOL_OR_RETURN(&additional_prefix_nal_unit_extension_flag);
if (additional_prefix_nal_unit_extension_flag) {
LOG(ERROR) << "additional_prefix_nal_unit_extension_flag must be false";
return std::nullopt;
}
}
return res;
}
} // namespace
// static
std::unique_ptr<DecoderBufferValidator> DecoderBufferValidator::Create(
VideoCodecProfile profile,
const gfx::Rect& visible_rect,
size_t num_spatial_layers,
size_t num_temporal_layers,
SVCInterLayerPredMode inter_layer_pred) {
CHECK_LE(num_spatial_layers, kMaxSpatialLayers);
CHECK_LE(num_temporal_layers, kMaxSpatialLayers);
switch (VideoCodecProfileToVideoCodec(profile)) {
case VideoCodec::kH264:
return std::make_unique<H264Validator>(profile, visible_rect,
num_temporal_layers);
case VideoCodec::kVP8:
return std::make_unique<VP8Validator>(visible_rect, num_temporal_layers);
case VideoCodec::kVP9:
// Only SVCInterLayerPredMode::kOnKeyPic (for VP9 k-SVC) and
// SVCInterLayerPredMode::kOff (for VP9 S-mode) are supported.
CHECK_NE(inter_layer_pred, SVCInterLayerPredMode::kOn);
return std::make_unique<VP9Validator>(
profile, visible_rect, num_spatial_layers, num_temporal_layers,
inter_layer_pred);
case VideoCodec::kAV1:
return std::make_unique<AV1Validator>(visible_rect, num_temporal_layers);
default:
LOG(ERROR) << "Unsupported profile: " << GetProfileName(profile);
return nullptr;
}
}
DecoderBufferValidator::DecoderBufferValidator(const gfx::Rect& visible_rect,
size_t num_temporal_layers)
: visible_rect_(visible_rect), num_temporal_layers_(num_temporal_layers) {}
DecoderBufferValidator::~DecoderBufferValidator() = default;
void DecoderBufferValidator::ProcessBitstream(
scoped_refptr<BitstreamRef> bitstream,
size_t frame_index) {
CHECK(bitstream);
if (!Validate(bitstream->buffer.get(), bitstream->metadata)) {
num_errors_++;
}
}
bool DecoderBufferValidator::WaitUntilDone() {
return num_errors_ == 0;
}
H264Validator::H264Validator(VideoCodecProfile profile,
const gfx::Rect& visible_rect,
size_t num_temporal_layers,
std::optional<uint8_t> level)
: DecoderBufferValidator(visible_rect, num_temporal_layers),
cur_pic_(base::MakeRefCounted<H264Picture>()),
profile_(VideoCodecProfileToH264ProfileIDC(profile)),
level_(level) {}
H264Validator::~H264Validator() = default;
bool H264Validator::Validate(const DecoderBuffer* buffer,
const BitstreamBufferMetadata& metadata) {
if (metadata.dropped_frame()) {
if (metadata.key_frame) {
LOG(ERROR) << "Don't drop key frame";
return false;
}
if (metadata.h264.has_value()) {
LOG(ERROR) << "BitstreamBufferMetadata has H264Metadata on dropped frame";
return false;
}
return true;
}
if (!metadata.end_of_picture()) {
LOG(ERROR) << "end_of_picture must be true always in H264";
return false;
}
CHECK(buffer);
const DecoderBuffer& decoder_buffer = *buffer;
auto decoder_buffer_span = base::span(decoder_buffer);
parser_.SetStream(decoder_buffer_span.data(), decoder_buffer_span.size());
if (num_temporal_layers_ > 1) {
if (!metadata.h264) {
LOG(ERROR) << "H264Metadata must be filled in temporal layer encoding";
return false;
}
if (metadata.h264->temporal_idx >= num_temporal_layers_) {
LOG(ERROR) << "Invalid temporal_idx: "
<< base::strict_cast<int32_t>(metadata.h264->temporal_idx);
return false;
}
}
size_t num_frames = 0;
H264NALU nalu;
H264Parser::Result result;
std::optional<std::pair<int, H264NALU::Type>> expected_associated_slice_nal;
while ((result = parser_.AdvanceToNextNALU(&nalu)) != H264Parser::kEOStream) {
if (result != H264Parser::kOk) {
LOG(ERROR) << "Failed parsing";
return false;
}
switch (nalu.nal_unit_type) {
case H264NALU::kIDRSlice:
if (!seen_sps_ || !seen_pps_) {
LOG(ERROR) << "IDR frame before SPS and PPS";
return false;
}
seen_idr_ = true;
if (!metadata.key_frame) {
LOG(ERROR) << "metadata.key_frame is false on IDR frame";
return false;
}
if (metadata.h264 &&
(metadata.h264->temporal_idx != 0 || metadata.h264->layer_sync)) {
LOG(ERROR) << "temporal_idx="
<< base::strict_cast<int>(metadata.h264->temporal_idx)
<< " or layer_sync="
<< base::strict_cast<int>(metadata.h264->layer_sync)
<< " is unexpected";
return false;
}
[[fallthrough]];
case H264NALU::kNonIDRSlice: {
if (!seen_idr_) {
LOG(ERROR) << "Non IDR frame before IDR frame";
return false;
}
H264SliceHeader slice_hdr;
if (parser_.ParseSliceHeader(nalu, &slice_hdr) != H264Parser::kOk) {
LOG(ERROR) << "Failed parsing slice";
return false;
}
if (IsNewPicture(slice_hdr)) {
// A new frame is found. Initialize |cur_pic|.
num_frames++;
if (!UpdateCurrentPicture(slice_hdr))
return false;
}
CHECK(parser_.GetPPS(cur_pps_id_));
const int qp = slice_hdr.slice_qp_delta +
parser_.GetPPS(cur_pps_id_)->pic_init_qp_minus26 + 26;
DVLOGF(4) << "qp=" << qp;
const int temporal_idx =
metadata.h264 ? metadata.h264->temporal_idx : 0;
qp_values_[0][temporal_idx].push_back(qp);
if (slice_hdr.disable_deblocking_filter_idc != 0) {
LOG(ERROR) << "Deblocking filter is not enabled";
return false;
}
if (slice_hdr.slice_type == H264SliceHeader::Type::kBSlice) {
LOG(ERROR) << "Found B slice";
return false;
}
if (expected_associated_slice_nal) {
if (expected_associated_slice_nal->first != nalu.nal_ref_idc) {
LOG(ERROR) << "NALU ref_idc mismatched. Actual ref_idc: "
<< nalu.nal_ref_idc << ", expected ref_idc: "
<< expected_associated_slice_nal->first;
return false;
}
if (expected_associated_slice_nal->second != nalu.nal_unit_type) {
LOG(ERROR) << "NALU type mismatched. Actual type: "
<< nalu.nal_unit_type << ", expected type: "
<< expected_associated_slice_nal->second;
return false;
}
}
break;
}
case H264NALU::kSPS: {
int sps_id;
if (parser_.ParseSPS(&sps_id) != H264Parser::kOk) {
LOG(ERROR) << "Failed parsing SPS";
return false;
}
// Check the visible rect.
const H264SPS* sps = parser_.GetSPS(sps_id);
const auto& visible_rect = sps->GetVisibleRect().value_or(gfx::Rect());
if (visible_rect != visible_rect_) {
LOG(ERROR) << "Visible rectangle mismatched. Actual visible_rect: "
<< visible_rect.ToString()
<< ", expected visible_rect: " << visible_rect_.ToString();
return false;
}
if (profile_ != sps->profile_idc) {
LOG(ERROR) << "Profile mismatched. Actual profile: "
<< sps->profile_idc << ", expected profile: " << profile_;
return false;
}
if (level_ && sps->GetIndicatedLevel() != *level_) {
LOG(ERROR) << "Level mismatched. Actual profile: "
<< static_cast<int>(sps->GetIndicatedLevel())
<< ", expected profile: " << static_cast<int>(*level_);
return false;
}
seen_sps_ = true;
break;
}
case H264NALU::kPPS: {
if (!seen_sps_) {
LOG(ERROR) << "PPS before SPS";
return false;
}
int pps_id;
if (parser_.ParsePPS(&pps_id) != H264Parser::kOk) {
LOG(ERROR) << "Failed parsing PPS";
return false;
}
seen_pps_ = true;
const H264PPS* pps = parser_.GetPPS(pps_id);
if ((profile_ == H264SPS::kProfileIDCMain ||
profile_ == H264SPS::kProfileIDCHigh) &&
!pps->entropy_coding_mode_flag) {
// CABAC must be selected if a profile is Main and High.
LOG(ERROR) << "The entropy coding is not CABAC";
return false;
}
// 8x8 transform should be enabled if a profile is High. However, we
// don't check it because it is not enabled due to a hardware limitation
// on AMD stoneyridge and picasso.
break;
}
case H264NALU::kPrefix: {
if (!metadata.h264) {
LOG(ERROR) << "Prefix NALU should be generated only if temproal "
"layer encoding";
return false;
}
std::optional<H264PrefixNALU> prefix_nalu = ParseH264Prefix(nalu);
if (!prefix_nalu) {
LOG(ERROR) << "Failed parsing prefix NALU";
return false;
}
if (!prefix_nalu->svc_extension_flag) {
LOG(ERROR) << "svc_extesion_flag must be true";
return false;
}
if (prefix_nalu->idr_flag != metadata.key_frame) {
LOG(ERROR) << "mismatch on idr_flag and key_frame";
break;
}
if (prefix_nalu->priority_id != 0 || prefix_nalu->dependency_id != 0 ||
prefix_nalu->quality_id != 0) {
LOG(ERROR) << "priority_id, dependency_id, and quality_id must be 0: "
<< "priority_id="
<< static_cast<int>(prefix_nalu->priority_id)
<< ", dependency_id="
<< static_cast<int>(prefix_nalu->dependency_id)
<< ", quality_id="
<< static_cast<int>(prefix_nalu->quality_id);
return false;
}
if (!prefix_nalu->no_inter_layer_pred_flag ||
prefix_nalu->use_ref_base_pic_flag ||
!prefix_nalu->discardable_flag || !prefix_nalu->output_flag) {
LOG(ERROR) << "unexpected flags: "
<< "no_inter_layer_pred_flag="
<< prefix_nalu->no_inter_layer_pred_flag
<< ", use_ref_base_pic_flag="
<< prefix_nalu->use_ref_base_pic_flag
<< ", discardable_flag=" << prefix_nalu->discardable_flag
<< ", output_flag=" << prefix_nalu->output_flag;
return false;
}
bool is_ref = metadata.h264->temporal_idx != num_temporal_layers_ - 1;
int expected_nal_ref_idc = metadata.key_frame ? 3 : is_ref;
H264NALU::Type expected_associated_nal_unit_type =
metadata.key_frame ? H264NALU::kIDRSlice : H264NALU::kNonIDRSlice;
if (prefix_nalu->nal_ref_idc != expected_nal_ref_idc) {
LOG(ERROR) << "mismatch on nal_ref_idc: "
<< "prefix_nalu->nal_ref_idc="
<< static_cast<int>(prefix_nalu->nal_ref_idc)
<< ", expected_nal_ref_idc=" << expected_nal_ref_idc;
return false;
}
if (prefix_nalu->temporal_id != metadata.h264->temporal_idx) {
LOG(ERROR) << "mismatch on temporal_id: "
<< "prefix_nalu->temporal_id="
<< static_cast<int>(prefix_nalu->temporal_id)
<< ", metadata.h264->temporal_idx="
<< static_cast<int>(metadata.h264->temporal_idx);
return false;
}
expected_associated_slice_nal = std::make_pair(
expected_nal_ref_idc, expected_associated_nal_unit_type);
break;
}
default:
break;
}
}
return num_frames == 1u;
}
bool H264Validator::IsNewPicture(const H264SliceHeader& slice_hdr) {
if (!cur_pic_)
return true;
return H264Decoder::IsNewPrimaryCodedPicture(
cur_pic_.get(), cur_pps_id_, parser_.GetSPS(cur_sps_id_), slice_hdr);
}
bool H264Validator::UpdateCurrentPicture(const H264SliceHeader& slice_hdr) {
cur_pps_id_ = slice_hdr.pic_parameter_set_id;
const H264PPS* pps = parser_.GetPPS(cur_pps_id_);
if (!pps) {
LOG(ERROR) << "Cannot parse pps.";
return false;
}
cur_sps_id_ = pps->seq_parameter_set_id;
const H264SPS* sps = parser_.GetSPS(cur_sps_id_);
if (!sps) {
LOG(ERROR) << "Cannot parse sps.";
return false;
}
if (!H264Decoder::FillH264PictureFromSliceHeader(sps, slice_hdr,
cur_pic_.get())) {
LOG(ERROR) << "Cannot initialize current frame.";
return false;
}
return true;
}
VP8Validator::VP8Validator(const gfx::Rect& visible_rect,
size_t num_temporal_layers)
: DecoderBufferValidator(visible_rect, num_temporal_layers) {}
VP8Validator::~VP8Validator() = default;
bool VP8Validator::Validate(const DecoderBuffer* buffer,
const BitstreamBufferMetadata& metadata) {
if (metadata.dropped_frame()) {
if (metadata.key_frame) {
LOG(ERROR) << "Don't drop key frame";
return false;
}
if (metadata.vp8.has_value()) {
LOG(ERROR) << "BitstreamBufferMetadata has Vp8Metadata on dropped frame";
return false;
}
return true;
}
if (!metadata.end_of_picture()) {
LOG(ERROR) << "end_of_picture must be true always in VP8";
return false;
}
CHECK(buffer);
const DecoderBuffer& decoder_buffer = *buffer;
auto decoder_buffer_span = base::span(decoder_buffer);
// TODO(hiroh): We could be getting more frames in the buffer, but there is
// no simple way to detect this. We'd need to parse the frames and go through
// partition numbers/sizes. For now assume one frame per buffer.
Vp8FrameHeader header;
if (!parser_.ParseFrame(decoder_buffer_span.data(),
decoder_buffer_span.size(), &header)) {
LOG(ERROR) << "Failed parsing";
return false;
}
const int qp = base::strict_cast<int>(header.quantization_hdr.y_ac_qi);
DVLOGF(4) << "qp=" << qp;
if (!header.show_frame) {
LOG(ERROR) << "|show_frame| should be always true";
return false;
}
if (header.IsKeyframe()) {
seen_keyframe_ = true;
if (gfx::Rect(header.width, header.height) != visible_rect_) {
LOG(ERROR) << "Visible rectangle mismatched. Actual visible_rect: "
<< gfx::Rect(header.width, header.height).ToString()
<< ", expected visible_rect: " << visible_rect_.ToString();
return false;
}
}
if (!seen_keyframe_) {
LOG(ERROR) << "Bitstream cannot start with a delta frame";
return false;
}
if (num_temporal_layers_ == 1) {
if (!header.refresh_entropy_probs) {
LOG(ERROR) << "refereh_entropy_probs should be true in non temporal "
"layer encoding";
return false;
}
qp_values_[0][0].push_back(qp);
return true;
} else if (header.refresh_entropy_probs) {
LOG(ERROR)
<< "refereh_entropy_probs must be false in temporal layer encoding";
return false;
}
if (!metadata.vp8) {
LOG(ERROR) << "Metadata must be populated if temporal scalability is used.";
return false;
}
const uint8_t temporal_idx = metadata.vp8->temporal_idx;
if (temporal_idx >= num_temporal_layers_) {
LOG(ERROR) << "Invalid temporal id: "
<< base::strict_cast<int>(temporal_idx);
return false;
}
qp_values_[0][temporal_idx].push_back(qp);
if (header.IsKeyframe()) {
if (temporal_idx != 0) {
LOG(ERROR) << "Temporal id must be 0 on keyframe";
return false;
}
return true;
}
if (header.copy_buffer_to_golden != Vp8FrameHeader::NO_GOLDEN_REFRESH ||
header.copy_buffer_to_alternate != Vp8FrameHeader::NO_ALT_REFRESH) {
LOG(ERROR) << "Each reference frame is either updated by the current "
<< "frame or unchanged in temporal layer encoding.";
return false;
}
const bool update_reference = header.refresh_last ||
header.refresh_golden_frame ||
header.refresh_alternate_frame;
if (metadata.vp8->non_reference != !update_reference) {
LOG(ERROR) << "|non_reference| must be true iff the frame does not update"
<< "any reference buffer.";
return false;
}
if (num_temporal_layers_ == temporal_idx + 1) {
if (update_reference) {
LOG(ERROR) << "The frame in top temporal layer must not update "
"reference frame.";
return false;
}
} else {
// TL0 can update last frame only and TL1 can update golden frame only when
// it is not top temporal layer.
if (temporal_idx == 0) {
if (!header.refresh_last || header.refresh_golden_frame ||
header.refresh_alternate_frame) {
LOG(ERROR) << "|refresh_last| only must be set on temporal layer 0";
return false;
}
} else if (temporal_idx == 1) {
if (header.refresh_last || !header.refresh_golden_frame ||
header.refresh_alternate_frame) {
LOG(ERROR) << "|refresh_golden_frame| only must be set on temporal "
<< "layer 1";
return false;
}
}
}
return true;
}
VP9Validator::VP9Validator(VideoCodecProfile profile,
const gfx::Rect& visible_rect,
size_t max_num_spatial_layers,
size_t num_temporal_layers,
SVCInterLayerPredMode inter_layer_pred)
: DecoderBufferValidator(visible_rect, num_temporal_layers),
profile_(VideoCodecProfileToVP9Profile(profile)),
max_num_spatial_layers_(max_num_spatial_layers),
s_mode_(max_num_spatial_layers > 1 &&
inter_layer_pred == SVCInterLayerPredMode::kOff),
cur_num_spatial_layers_(max_num_spatial_layers_),
next_picture_id_(0) {
const size_t num_parsed_streams = s_mode_ ? max_num_spatial_layers_ : 1u;
for (size_t i = 0; i < num_parsed_streams; ++i) {
parsers_.push_back(std::make_unique<Vp9Parser>());
}
reference_buffers_.resize(num_parsed_streams);
}
VP9Validator::~VP9Validator() = default;
bool VP9Validator::Validate(const DecoderBuffer* buffer,
const BitstreamBufferMetadata& metadata) {
if (metadata.dropped_frame()) {
if (metadata.key_frame) {
LOG(ERROR) << "Don't drop key frame";
return false;
}
if (metadata.vp9.has_value()) {
LOG(ERROR)
<< "BitstreamBufferMetadata has Vp9Metadata on a dropped frame";
return false;
}
if (metadata.end_of_picture()) {
dropped_superframe_timestamp_.reset();
} else {
if (!dropped_superframe_timestamp_) {
dropped_superframe_timestamp_ = metadata.timestamp;
}
if (*dropped_superframe_timestamp_ != metadata.timestamp) {
LOG(ERROR) << "A timestamp mismatch on dropped frame in the same "
<< "spatial layers";
return false;
}
}
return true;
}
if (dropped_superframe_timestamp_ &&
*dropped_superframe_timestamp_ == metadata.timestamp) {
LOG(ERROR) << "A frame on upper spatial layers are not dropped though a "
<< "frame on bottom spatial layers is dropped";
return false;
}
CHECK(buffer);
const DecoderBuffer& decoder_buffer = *buffer;
auto decoder_buffer_span = base::span(decoder_buffer);
// See Annex B "Superframes" in VP9 spec.
constexpr uint8_t kSuperFrameMarkerMask = 0b11100000;
constexpr uint8_t kSuperFrameMarker = 0b11000000;
if ((decoder_buffer_span.back() & kSuperFrameMarkerMask) ==
kSuperFrameMarker) {
LOG(ERROR) << "Support for super-frames not yet implemented.";
return false;
}
const bool svc_encoding =
max_num_spatial_layers_ > 1 || num_temporal_layers_ > 1;
if (metadata.vp9.has_value() != svc_encoding) {
LOG(ERROR) << "VP9 specific metadata must exist only for SVC encodings";
return false;
}
const size_t parser_index =
s_mode_ ? begin_active_spatial_layer_index_ + metadata.vp9->spatial_idx
: 0;
CHECK_LT(parser_index, parsers_.size());
auto& parser = *parsers_[parser_index];
Vp9FrameHeader header;
gfx::Size allocate_size;
parser.SetStream(decoder_buffer_span.data(), decoder_buffer_span.size(),
nullptr);
if (parser.ParseNextFrame(&header, &allocate_size, nullptr) ==
Vp9Parser::kInvalidStream) {
LOG(ERROR) << "Failed parsing";
return false;
}
if (metadata.key_frame != header.IsKeyframe()) {
LOG(ERROR) << "Keyframe info in metadata is wrong, metadata.keyframe="
<< metadata.key_frame;
return false;
}
if (header.profile != static_cast<uint8_t>(profile_)) {
LOG(ERROR) << "Profile mismatched. Actual profile: "
<< static_cast<int>(header.profile)
<< ", expected profile: " << profile_;
return false;
}
if (metadata.vp9.has_value() != svc_encoding) {
LOG(ERROR) << "VP9 specific metadata must exist if and only if the stream "
<< "is temporal or spatial layer stream";
return false;
}
if (s_mode_) {
return ValidateSmodeStream(decoder_buffer, metadata, header);
} else if (svc_encoding) {
return ValidateSVCStream(decoder_buffer, metadata, header);
}
return ValidateVanillaStream(decoder_buffer, metadata, header);
}
bool VP9Validator::ValidateVanillaStream(
const DecoderBuffer& decoder_buffer,
const BitstreamBufferMetadata& metadata,
const Vp9FrameHeader& header) {
if (next_picture_id_ == 0 && !metadata.key_frame) {
LOG(ERROR) << "First frame must be a keyframe.";
return false;
}
if (header.error_resilient_mode) {
LOG(ERROR) << "Error resilient mode should not be used if neither spatial"
"nor temporal scalablity is enabled";
return false;
}
if (!header.refresh_frame_context) {
#if BUILDFLAG(USE_VAAPI)
// TODO(b/297226972): Remove the workaround once the iHD driver is fixed.
LOG(WARNING) << "Frame context should be refreshed if neither spatial nor "
"temporal scalablity is enabled";
#else
LOG(ERROR) << "Frame context should be refreshed if neither spatial nor "
"temporal scalablity is enabled";
return false;
#endif
}
if (metadata.key_frame) {
next_picture_id_ = 0;
}
BufferState new_buffer_state{};
new_buffer_state.picture_id = next_picture_id_++;
if (header.show_existing_frame &&
!reference_buffers_[0][header.frame_to_show_map_idx]) {
LOG(ERROR) << "Attempting to show an existing frame, but the selected "
"reference buffer is invalid.";
return false;
}
// Check the resolution is expected.
const gfx::Rect visible_rect(header.render_width, header.render_height);
if (visible_rect_ != visible_rect) {
LOG(ERROR) << "Visible rectangle mismatched. Actual visible_rect: "
<< visible_rect.ToString()
<< ", expected visible_rect: " << visible_rect_.ToString();
return false;
}
if (!header.IsIntra()) {
for (uint8_t ref_frame_index : header.ref_frame_idx) {
if (ref_frame_index >= static_cast<uint8_t>(kVp9NumRefFrames)) {
LOG(ERROR) << "Invalid reference frame index: "
<< static_cast<int>(ref_frame_index);
return false;
}
if (!reference_buffers_[0][ref_frame_index]) {
LOG(ERROR) << "Frame is trying to reference buffer with invalid state.";
return false;
}
}
}
// Update current state with the new buffer.
for (size_t i = 0; i < kVp9NumRefFrames; ++i) {
if (header.RefreshFlag(i)) {
reference_buffers_[0][i] = new_buffer_state;
}
}
const int qp = base::strict_cast<int>(header.quant_params.base_q_idx);
DVLOGF(4) << "qp=" << qp;
qp_values_[0][0].push_back(qp);
return true;
}
bool VP9Validator::ValidateSVCStream(const DecoderBuffer& decoder_buffer,
const BitstreamBufferMetadata& metadata,
const Vp9FrameHeader& header) {
const Vp9Metadata& vp9 = *metadata.vp9;
if (next_picture_id_ == 0 && vp9.spatial_idx == 0 && !metadata.key_frame) {
LOG(ERROR) << "First frame must be a keyframe.";
return false;
}
if (!header.error_resilient_mode) {
LOG(ERROR) << "Error resilient mode must be used if spatial or temporal "
"scaliblity is enabled.";
return false;
}
if (header.refresh_frame_context) {
LOG(ERROR) << "Frame context must not be refreshed if spatial or temporal "
<< " scalability is enabled";
return false;
}
if (vp9.spatial_idx >= cur_num_spatial_layers_ ||
vp9.temporal_idx >= num_temporal_layers_) {
LOG(ERROR) << "Invalid spatial_idx="
<< base::strict_cast<int>(vp9.spatial_idx)
<< ", temporal_idx=" << base::strict_cast<int>(vp9.temporal_idx);
return false;
}
if (vp9.inter_pic_predicted != (vp9.p_diffs.size() > 0)) {
LOG(ERROR) << "Inconsistent metadata, inter_pic_predicted implies p_diffs "
"is non-empty.";
return false;
}
if (metadata.key_frame) {
if (vp9.spatial_idx != 0 || vp9.temporal_idx != 0) {
LOG(ERROR) << "Spatial and temporal id must be 0 for keyframes.";
return false;
}
if (vp9.spatial_layer_resolutions.empty()) {
LOG(ERROR) << "spatial_layer_resolution must not be empty on key frame";
return false;
}
cur_num_spatial_layers_ = vp9.spatial_layer_resolutions.size();
spatial_layer_resolutions_ = vp9.spatial_layer_resolutions;
next_picture_id_ = 0;
} else if (header.show_existing_frame) {
if (!reference_buffers_[0][header.frame_to_show_map_idx]) {
LOG(ERROR) << "Attempting to show an existing frame, but the selected "
"reference buffer is invalid.";
return false;
}
int expected_diff =
next_picture_id_ -
reference_buffers_[0][header.frame_to_show_map_idx]->picture_id;
if (vp9.p_diffs.size() != 1 || vp9.p_diffs[0] != expected_diff) {
LOG(ERROR) << "Inconsistency between p_diff and existing frame to show.";
return false;
}
return true;
}
BufferState new_buffer_state{
.picture_id = next_picture_id_,
.spatial_id = vp9.spatial_idx,
.temporal_id = vp9.temporal_idx,
};
const bool end_of_picture = vp9.spatial_idx == cur_num_spatial_layers_ - 1;
if (end_of_picture != metadata.end_of_picture()) {
LOG(ERROR) << "end_of_picture mismatches: end_of_picture=" << end_of_picture
<< ", metadata.end_of_picture=" << metadata.end_of_picture();
return false;
}
if (end_of_picture) {
next_picture_id_++;
}
// Check the resolution is expected.
const gfx::Rect visible_rect(header.render_width, header.render_height);
if (visible_rect.size() != spatial_layer_resolutions_[vp9.spatial_idx]) {
LOG(ERROR) << "Resolution mismatched. Actual resolution: "
<< visible_rect.size().ToString() << ", expected resolution: "
<< spatial_layer_resolutions_[vp9.spatial_idx].ToString();
return false;
}
// Check that referenced frames are OK.
if (header.IsIntra()) {
if (!vp9.p_diffs.empty()) {
// TODO(crbug.com/40172317): Consider if this is truly an error-state.
LOG(ERROR) << "|p_diffs| should be empty in intra-frames.";
return false;
}
} else {
std::vector<int> expected_pdiffs;
std::set<uint8_t> used_indices;
for (uint8_t ref_frame_index : header.ref_frame_idx) {
if (ref_frame_index >= static_cast<uint8_t>(kVp9NumRefFrames)) {
LOG(ERROR) << "Invalid reference frame index: "
<< static_cast<int>(ref_frame_index);
return false;
}
if (used_indices.contains(ref_frame_index)) {
// |header.ref_frame_index| might have the same indices because an
// encoder fills the same index if the actually used ref frames is less
// than |kVp9NumRefsPerFrame|.
continue;
}
used_indices.insert(ref_frame_index);
if (!reference_buffers_[0][ref_frame_index]) {
LOG(ERROR) << "Frame is trying to reference buffer with invalid state.";
return false;
}
const BufferState& ref = *reference_buffers_[0][ref_frame_index];
if (ref.spatial_id > new_buffer_state.spatial_id) {
LOG(ERROR)
<< "Frame is trying to reference buffer from higher spatial layer.";
return false;
}
if (ref.temporal_id > new_buffer_state.temporal_id) {
LOG(ERROR) << "Frame is trying to reference buffer from higher "
"temporal layer.";
return false;
}
// For key picture (|new_buffer_state.picture_id| == 0), we don't fill
// |p_diffs| even though it references lower spatial layer frame. Skip
// inserting |expected_pdiffs|.
if (new_buffer_state.picture_id != 0) {
expected_pdiffs.push_back(new_buffer_state.picture_id - ref.picture_id);
}
}
for (uint8_t p_diff : vp9.p_diffs) {
if (!std::erase(expected_pdiffs, p_diff)) {
LOG(ERROR)
<< "Frame is referencing buffer not contained in the p_diff.";
return false;
}
}
if (!expected_pdiffs.empty()) {
// TODO(crbug.com/40172317): Consider if this is truly an error-state.
LOG(ERROR) << "|p_diff| contains frame that is not actually referenced.";
return false;
}
}
if (vp9.temporal_up_switch) {
// Temporal up-switch, invalidate any buffers containing frames with higher
// temporal id.
for (auto& buffer : reference_buffers_[0]) {
if (buffer && buffer->temporal_id > new_buffer_state.temporal_id) {
buffer.reset();
}
}
}
// Update current state with the new buffer.
for (size_t i = 0; i < kVp9NumRefFrames; ++i) {
if (header.RefreshFlag(i)) {
reference_buffers_[0][i] = new_buffer_state;
}
}
const int qp = base::strict_cast<int>(header.quant_params.base_q_idx);
DVLOGF(4) << "qp=" << qp;
qp_values_[vp9.spatial_idx][vp9.temporal_idx].push_back(qp);
return true;
}
bool VP9Validator::ValidateSmodeStream(const DecoderBuffer& decoder_buffer,
const BitstreamBufferMetadata& metadata,
const Vp9FrameHeader& header) {
const Vp9Metadata& vp9 = *metadata.vp9;
if (next_picture_id_ == 0 && !metadata.key_frame) {
LOG(ERROR) << "First frame on each layer must be a keyframe.";
return false;
}
if (!header.error_resilient_mode) {
LOG(ERROR) << "Error resilient mode must be used in s-mode encoding";
return false;
}
if (header.refresh_frame_context) {
LOG(ERROR) << "Frame context must not be refreshed in s-mode encoding";
return false;
}
if (vp9.spatial_idx >= cur_num_spatial_layers_ ||
vp9.temporal_idx >= num_temporal_layers_) {
LOG(ERROR) << "Invalid spatial_idx="
<< base::strict_cast<int>(vp9.spatial_idx)
<< ", temporal_idx=" << base::strict_cast<int>(vp9.temporal_idx);
return false;
}
if (vp9.referenced_by_upper_spatial_layers) {
LOG(ERROR) << "referenced_by_upper_spatial_layers must be always false in "
<< "s-mode encoding";
return false;
}
if (vp9.inter_pic_predicted != (vp9.p_diffs.size() > 0)) {
LOG(ERROR) << "Inconsistent metadata, inter_pic_predicted implies p_diffs "
"is non-empty.";
return false;
}
if (metadata.key_frame) {
if (vp9.temporal_idx != 0) {
LOG(ERROR) << "Temporal id must be 0 for keyframes.";
return false;
}
if (vp9.spatial_layer_resolutions.empty()) {
LOG(ERROR) << "spatial_layer_resolution must not be empty on keyframe";
return false;
}
cur_num_spatial_layers_ = vp9.spatial_layer_resolutions.size();
spatial_layer_resolutions_ = vp9.spatial_layer_resolutions;
next_picture_id_ = 0;
begin_active_spatial_layer_index_ = vp9.begin_active_spatial_layer_index;
} else if (header.show_existing_frame) {
const size_t stream_index =
vp9.spatial_idx + begin_active_spatial_layer_index_;
if (!reference_buffers_[stream_index][header.frame_to_show_map_idx]) {
LOG(ERROR) << "Attempting to show an existing frame, but the selected "
"reference buffer is invalid.";
return false;
}
int expected_diff =
next_picture_id_ -
reference_buffers_[stream_index][header.frame_to_show_map_idx]
->picture_id;
if (vp9.p_diffs.size() != 1 || vp9.p_diffs[0] != expected_diff) {
LOG(ERROR) << "Inconsistency between p_diff and existing frame to show.";
return false;
}
return true;
}
BufferState new_buffer_state{
.picture_id = next_picture_id_,
.temporal_id = vp9.temporal_idx,
};
const bool end_of_picture = vp9.spatial_idx == cur_num_spatial_layers_ - 1;
if (end_of_picture != metadata.end_of_picture()) {
LOG(ERROR) << "end_of_picture mismatches: end_of_picture=" << end_of_picture
<< ", metadata.end_of_picture=" << metadata.end_of_picture();
return false;
}
if (end_of_picture) {
next_picture_id_++;
}
// Check the resolution is expected.
const gfx::Rect visible_rect(header.render_width, header.render_height);
if (visible_rect.size() != spatial_layer_resolutions_[vp9.spatial_idx]) {
LOG(ERROR) << "Resolution mismatched. Actual resolution: "
<< visible_rect.size().ToString() << ", expected resolution: "
<< spatial_layer_resolutions_[vp9.spatial_idx].ToString();
return false;
}
// Check that referenced frames are OK.
if (header.IsIntra()) {
if (!vp9.p_diffs.empty()) {
// TODO(crbug.com/40172317): Consider if this is truly an error-state.
LOG(ERROR) << "|p_diffs| should be empty in intra-frames.";
return false;
}
} else {
std::vector<int> expected_pdiffs;
std::set<uint8_t> used_indices;
for (uint8_t ref_frame_index : header.ref_frame_idx) {
if (ref_frame_index >= static_cast<uint8_t>(kVp9NumRefFrames)) {
LOG(ERROR) << "Invalid reference frame index: "
<< static_cast<int>(ref_frame_index);
return false;
}
if (used_indices.contains(ref_frame_index)) {
// |header.ref_frame_index| might have the same indices because an
// encoder fills the same index if the actually used ref frames is less
// than |kVp9NumRefsPerFrame|.
continue;
}
used_indices.insert(ref_frame_index);
if (!reference_buffers_[vp9.spatial_idx][ref_frame_index]) {
LOG(ERROR) << "Frame is trying to reference buffer with invalid state.";
return false;
}
const BufferState& ref =
*reference_buffers_[vp9.spatial_idx][ref_frame_index];
if (ref.spatial_id > new_buffer_state.spatial_id) {
LOG(ERROR)
<< "Frame is trying to reference buffer from higher spatial layer.";
return false;
}
if (ref.temporal_id > new_buffer_state.temporal_id) {
LOG(ERROR) << "Frame is trying to reference buffer from higher "
"temporal layer.";
return false;
}
expected_pdiffs.push_back(new_buffer_state.picture_id - ref.picture_id);
}
for (uint8_t p_diff : vp9.p_diffs) {
if (!std::erase(expected_pdiffs, p_diff)) {
LOG(ERROR)
<< "Frame is referencing buffer not contained in the p_diff.";
return false;
}
}
if (!expected_pdiffs.empty()) {
// TODO(crbug.com/40172317): Consider if this is truly an error-state.
LOG(ERROR) << "|p_diff| contains frame that is not actually referenced.";
return false;
}
}
if (vp9.temporal_up_switch) {
// Temporal up-switch, invalidate any buffers containing frames with higher
// temporal id.
for (auto& buffer : reference_buffers_[vp9.spatial_idx]) {
if (buffer && buffer->temporal_id > new_buffer_state.temporal_id) {
buffer.reset();
}
}
}
// Update current state with the new buffer.
for (size_t i = 0; i < kVp9NumRefFrames; ++i) {
if (header.RefreshFlag(i))
reference_buffers_[vp9.spatial_idx][i] = new_buffer_state;
}
const int qp = base::strict_cast<int>(header.quant_params.base_q_idx);
DVLOGF(4) << "qp=" << qp;
qp_values_[vp9.spatial_idx][vp9.temporal_idx].push_back(qp);
return true;
}
AV1Validator::AV1Validator(const gfx::Rect& visible_rect,
size_t num_temporal_layers)
: DecoderBufferValidator(visible_rect, num_temporal_layers),
buffer_pool_(libgav1::OnInternalFrameBufferSizeChanged,
libgav1::GetInternalFrameBuffer,
libgav1::ReleaseInternalFrameBuffer,
&buffer_list_) {}
// TODO(b/268487938): Add more robust testing here. Currently we only perform
// the most basic validation that the bitstream parses correctly and has the
// right dimensions.
bool AV1Validator::Validate(const DecoderBuffer* buffer,
const BitstreamBufferMetadata& metadata) {
if (metadata.dropped_frame()) {
if (metadata.key_frame) {
LOG(ERROR) << "Don't drop key frame";
return false;
}
if (metadata.svc_generic.has_value()) {
LOG(ERROR) << "BitstreamBufferMetadata has Av1Metadata on dropped frame";
return false;
}
return true;
}
if (!metadata.end_of_picture()) {
LOG(ERROR) << "end_of_picture must be true always in AV1";
return false;
}
CHECK(buffer);
const DecoderBuffer& decoder_buffer = *buffer;
auto decoder_buffer_span = base::span(decoder_buffer);
libgav1::ObuParser av1_parser(decoder_buffer_span.data(),
decoder_buffer_span.size(), 0, &buffer_pool_,
&decoder_state_);
libgav1::RefCountedBufferPtr curr_frame;
if (sequence_header_) {
av1_parser.set_sequence_header(*sequence_header_);
}
auto parse_status = av1_parser.ParseOneFrame(&curr_frame);
if (parse_status != libgav1::kStatusOk) {
LOG(ERROR) << "Failed parsing frame. Status: " << parse_status;
return false;
}
const auto& frame_header = av1_parser.frame_header();
if (gfx::Size(frame_header.render_width, frame_header.render_height) !=
visible_rect_.size()) {
LOG(ERROR) << "Mismatched visible rectangle dimensions.";
LOG(ERROR) << "Got render_width=" << frame_header.render_width
<< " render_height=" << frame_header.render_height;
LOG(ERROR) << "Expected visible_width=" << visible_rect_.width()
<< " visible_height=" << visible_rect_.height();
return false;
}
if (frame_header.frame_type != libgav1::FrameType::kFrameKey &&
frame_num_ == 0) {
LOG(ERROR) << "First frame must be keyframe";
return false;
}
if (frame_header.frame_type == libgav1::FrameType::kFrameKey) {
frame_num_ = 0;
}
if (frame_header.order_hint != (frame_num_ & 0xFF)) {
LOG(ERROR) << "Incorrect frame order hint";
LOG(ERROR) << "Got: " << frame_header.order_hint;
LOG(ERROR) << "Expected: " << (int)(frame_num_ & 0xFF);
return false;
}
const int qp = base::strict_cast<int>(frame_header.quantizer.base_index);
DVLOGF(4) << "qp=" << qp;
qp_values_[0][0].push_back(qp);
// Update our state for the next frame.
if (av1_parser.frame_header().frame_type == libgav1::FrameType::kFrameKey) {
sequence_header_ = av1_parser.sequence_header();
}
if (metadata.svc_generic) {
ValidateTemporalSVCStream(decoder_buffer, metadata,
av1_parser.frame_header());
}
decoder_state_.UpdateReferenceFrames(
curr_frame, av1_parser.frame_header().refresh_frame_flags);
frame_num_++;
return true;
}
bool AV1Validator::ValidateTemporalSVCStream(
const DecoderBuffer& decoder_buffer,
const BitstreamBufferMetadata& metadata,
const libgav1::ObuFrameHeader& header) {
const SVCGenericMetadata& svc_metadata = *metadata.svc_generic;
CHECK_EQ(svc_metadata.spatial_idx, 0);
if (svc_metadata.temporal_idx >= num_temporal_layers_) {
LOG(ERROR) << "Invalid temporal_idx="
<< base::strict_cast<int>(svc_metadata.temporal_idx);
return false;
}
if (metadata.key_frame) {
if (svc_metadata.spatial_idx != 0 || svc_metadata.temporal_idx != 0) {
LOG(ERROR) << "Spatial and temporal id must be 0 for keyframes.";
return false;
}
} else if (header.show_existing_frame) {
if (!decoder_state_.reference_frame[header.frame_to_show]) {
LOG(ERROR) << "Attempting to show an existing frame, but the selected "
"reference buffer is invalid.";
return false;
}
return true;
}
// Check that referenced frames are OK.
if (header.frame_type == libgav1::FrameType::kFrameInter) {
std::set<uint8_t> used_indices;
for (uint8_t ref_frame_index : header.reference_frame_index) {
if (ref_frame_index >=
static_cast<uint8_t>(libgav1::kNumReferenceFrameTypes)) {
LOG(ERROR) << "Invalid reference frame index: "
<< static_cast<int>(ref_frame_index);
return false;
}
if (used_indices.contains(ref_frame_index)) {
// |header.ref_frame_index| might have the same indices because an
// encoder fills the same index if the actually used ref frames is less
// than |kNumReferenceFrameTypes|.
continue;
}
used_indices.insert(ref_frame_index);
if (!decoder_state_.reference_frame[ref_frame_index]) {
LOG(ERROR) << "Frame is trying to reference buffer with invalid state.";
return false;
}
const libgav1::RefCountedBufferPtr& ref =
decoder_state_.reference_frame[ref_frame_index];
if (ref->temporal_id() > svc_metadata.temporal_idx) {
LOG(ERROR) << "Frame is trying to reference buffer from higher "
"temporal layer.";
return false;
}
}
}
return true;
}
} // namespace test
} // namespace media
|