1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
|
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/external_install_error.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/external_install_manager.h"
#include "content/public/browser/notification_service.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/mock_external_provider.h"
#include "extensions/browser/notification_types.h"
namespace extensions {
class ExternalInstallErrorTest : public ExtensionBrowserTest {
public:
ExternalInstallErrorTest() = default;
~ExternalInstallErrorTest() override = default;
private:
DISALLOW_COPY_AND_ASSIGN(ExternalInstallErrorTest);
};
// Test that global errors don't crash on shutdown. See crbug.com/720081.
IN_PROC_BROWSER_TEST_F(ExternalInstallErrorTest, TestShutdown) {
// This relies on prompting for external extensions.
FeatureSwitch::ScopedOverride feature_override(
FeatureSwitch::prompt_for_external_extensions(), true);
const char kId[] = "ldnnhddmnhbkjipkidpdiheffobcpfmf";
{
// Wait for an external extension to be installed and a global error about
// it added.
content::WindowedNotificationObserver global_error_observer(
chrome::NOTIFICATION_GLOBAL_ERRORS_CHANGED,
content::NotificationService::AllSources());
content::WindowedNotificationObserver install_observer(
NOTIFICATION_CRX_INSTALLER_DONE,
content::NotificationService::AllSources());
auto provider = std::make_unique<MockExternalProvider>(
extension_service(), Manifest::EXTERNAL_PREF);
provider->UpdateOrAddExtension(kId, "1.0.0.0",
test_data_dir_.AppendASCII("good.crx"));
extension_service()->AddProviderForTesting(std::move(provider));
extension_service()->CheckForExternalUpdates();
install_observer.Wait();
global_error_observer.Wait();
}
// Verify the extension is in the expected state (disabled for being
// unacknowledged).
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
EXPECT_FALSE(registry->enabled_extensions().Contains(kId));
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
EXPECT_FALSE(prefs->IsExternalExtensionAcknowledged(kId));
EXPECT_EQ(disable_reason::DISABLE_EXTERNAL_EXTENSION,
prefs->GetDisableReasons(kId));
// Verify the external error.
ExternalInstallManager* manager =
extension_service()->external_install_manager();
std::vector<ExternalInstallError*> errors = manager->GetErrorsForTesting();
ASSERT_EQ(1u, errors.size());
EXPECT_EQ(kId, errors[0]->extension_id());
// End the test and shutdown without removing the global error. This should
// not crash.
}
} // namespace extensions
|
