1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
|
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/external_registry_loader_win.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/run_loop.h"
#include "base/values.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "extensions/common/value_builder.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
namespace {
const char kDummyRegistryKey[] = "dummyId";
class TestExternalRegistryLoader : public ExternalRegistryLoader {
public:
TestExternalRegistryLoader() {}
using ExternalRegistryLoader::StartLoading;
void WaitForTwoLoadsToFinished() {
// Run() returns immediately if Quit() has already been called.
run_loop_.Run();
}
std::vector<int> GetPrefsTestIds() { return prefs_test_ids_; }
private:
~TestExternalRegistryLoader() override {}
std::unique_ptr<base::DictionaryValue> LoadPrefsOnBlockingThread() override {
return DictionaryBuilder().Set(kDummyRegistryKey, id_++).Build();
}
void LoadFinished(std::unique_ptr<base::DictionaryValue> prefs) override {
++load_finished_count_;
ASSERT_LE(load_finished_count_, 2);
ASSERT_TRUE(prefs);
int prefs_test_id = -1;
EXPECT_TRUE(prefs->GetInteger(kDummyRegistryKey, &prefs_test_id));
prefs_test_ids_.push_back(prefs_test_id);
ExternalRegistryLoader::LoadFinished(std::move(prefs));
if (load_finished_count_ == 2)
run_loop_.Quit();
}
base::RunLoop run_loop_;
int load_finished_count_ = 0;
int id_ = 0;
std::vector<int> prefs_test_ids_;
DISALLOW_COPY_AND_ASSIGN(TestExternalRegistryLoader);
};
} // namespace
class ExternalRegistryLoaderUnittest : public testing::Test {
public:
ExternalRegistryLoaderUnittest() {}
~ExternalRegistryLoaderUnittest() override {}
protected:
void RunUntilIdle() { thread_bundle_.RunUntilIdle(); }
private:
content::TestBrowserThreadBundle thread_bundle_;
DISALLOW_COPY_AND_ASSIGN(ExternalRegistryLoaderUnittest);
};
// Tests that calling StartLoading() more than once doesn't fail DCHECK.
// Regression test for https://crbug.com/653045.
TEST_F(ExternalRegistryLoaderUnittest, TwoStartLoadingDoesNotCrash) {
scoped_refptr<TestExternalRegistryLoader> test_loader =
base::MakeRefCounted<TestExternalRegistryLoader>();
test_loader->StartLoading();
test_loader->StartLoading();
test_loader->WaitForTwoLoadsToFinished();
// Let registry watcher code complete.
RunUntilIdle();
}
// Tests that calling StartLoading() twice does not overwrite previous prefs
// before LoadFinished consumes it.
// Regression test for https://crbug.com/709304: if two StartLoading() schedules
// two LoadPrefsOnBlockingThread, then the second LoadPrefsOnBlockingThread
// could overwrite the first one's prefs.
TEST_F(ExternalRegistryLoaderUnittest, TwoStartLoadingDoesNotOverwritePrefs) {
scoped_refptr<TestExternalRegistryLoader> test_loader =
base::MakeRefCounted<TestExternalRegistryLoader>();
test_loader->StartLoading();
test_loader->StartLoading();
test_loader->WaitForTwoLoadsToFinished();
// Let registry watcher code complete.
RunUntilIdle();
std::vector<int> prefs_test_ids = test_loader->GetPrefsTestIds();
EXPECT_THAT(prefs_test_ids, testing::ElementsAre(0, 1));
}
} // namespace extensions
|
