1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
|
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/installed_loader.h"
#include "base/macros.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/extensions/permissions_updater.h"
#include "chrome/browser/extensions/scripting_permissions_modifier.h"
#include "chrome/browser/profiles/profile.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/extension_features.h"
namespace extensions {
namespace {
constexpr const char kHasWithheldHostsHistogram[] =
"Extensions.RuntimeHostPermissions.ExtensionHasWithheldHosts";
constexpr const char kGrantedHostCountHistogram[] =
"Extensions.RuntimeHostPermissions.GrantedHostCount";
} // namespace
class InstalledLoaderUnitTest : public ExtensionServiceTestBase {
public:
InstalledLoaderUnitTest() {}
~InstalledLoaderUnitTest() override = default;
void SetUp() override {
ExtensionServiceTestBase::SetUp();
InitializeEmptyExtensionService();
}
const Extension* AddExtension();
private:
DISALLOW_COPY_AND_ASSIGN(InstalledLoaderUnitTest);
};
const Extension* InstalledLoaderUnitTest::AddExtension() {
// Metrics aren't recorded for unpacked extensions, so we need to make sure
// the extension has an INTERNAL location.
constexpr Manifest::Location kManifestLocation = Manifest::INTERNAL;
scoped_refptr<const Extension> extension = ExtensionBuilder("test")
.AddPermissions({"<all_urls>"})
.SetLocation(kManifestLocation)
.Build();
PermissionsUpdater updater(profile());
updater.InitializePermissions(extension.get());
updater.GrantActivePermissions(extension.get());
service()->AddExtension(extension.get());
return extension.get();
}
TEST_F(InstalledLoaderUnitTest,
RuntimeHostPermissions_Metrics_FeatureDisabled) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndDisableFeature(
extensions_features::kRuntimeHostPermissions);
AddExtension();
base::HistogramTester histograms;
InstalledLoader loader(service());
loader.RecordExtensionsMetricsForTesting();
// No metrics should be recorded when the feature is disabled.
histograms.ExpectTotalCount(kHasWithheldHostsHistogram, 0);
histograms.ExpectTotalCount(kGrantedHostCountHistogram, 0);
}
TEST_F(InstalledLoaderUnitTest,
RuntimeHostPermissions_Metrics_HasWithheldHosts_False) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(
extensions_features::kRuntimeHostPermissions);
AddExtension();
base::HistogramTester histograms;
InstalledLoader loader(service());
loader.RecordExtensionsMetricsForTesting();
// The extension didn't have withheld hosts, so a single `false` record
// should be present.
histograms.ExpectUniqueSample(kHasWithheldHostsHistogram, false, 1);
// Granted host counts should only be recorded if the extension had withheld
// hosts.
histograms.ExpectTotalCount(kGrantedHostCountHistogram, 0);
}
TEST_F(InstalledLoaderUnitTest,
RuntimeHostPermissions_Metrics_HasWithheldHosts_True) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(
extensions_features::kRuntimeHostPermissions);
const Extension* extension = AddExtension();
ScriptingPermissionsModifier(profile(), extension)
.SetWithholdHostPermissions(true);
base::HistogramTester histograms;
InstalledLoader loader(service());
loader.RecordExtensionsMetricsForTesting();
// The extension had withheld hosts, so a single `true` record should be
// present.
histograms.ExpectUniqueSample(kHasWithheldHostsHistogram, true, 1);
// There were no granted hosts, so a single `0` record should be present.
constexpr int kGrantedHostCount = 0;
constexpr int kEmitCount = 1;
histograms.ExpectUniqueSample(kGrantedHostCountHistogram, kGrantedHostCount,
kEmitCount);
}
TEST_F(InstalledLoaderUnitTest,
RuntimeHostPermissions_Metrics_GrantedHostCount) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(
extensions_features::kRuntimeHostPermissions);
const Extension* extension = AddExtension();
ScriptingPermissionsModifier modifier(profile(), extension);
modifier.SetWithholdHostPermissions(true);
modifier.GrantHostPermission(GURL("https://example.com/"));
modifier.GrantHostPermission(GURL("https://chromium.org/"));
base::HistogramTester histograms;
InstalledLoader loader(service());
loader.RecordExtensionsMetricsForTesting();
histograms.ExpectUniqueSample(kHasWithheldHostsHistogram, true, 1);
// The extension had granted hosts, so a single `2` record should be present.
constexpr int kGrantedHostCount = 2;
constexpr int kEmitCount = 1;
histograms.ExpectUniqueSample(kGrantedHostCountHistogram, kGrantedHostCount,
kEmitCount);
}
} // namespace extensions
|
