1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <vector>
#include "base/bind.h"
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/memory/ref_counted.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/strings/string_util.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/chrome_zipfile_installer.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/load_error_reporter.h"
#include "chrome/browser/extensions/test_extension_system.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/test/base/testing_profile.h"
#include "components/services/unzip/public/interfaces/constants.mojom.h"
#include "components/services/unzip/unzip_service.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_registry_observer.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "services/data_decoder/data_decoder_service.h"
#include "services/data_decoder/public/mojom/constants.mojom.h"
#include "services/service_manager/public/cpp/connector.h"
#include "services/service_manager/public/cpp/test/test_connector_factory.h"
#include "testing/gtest/include/gtest/gtest.h"
#if defined(OS_CHROMEOS)
#include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h"
#include "chrome/browser/chromeos/settings/scoped_cros_settings_test_helper.h"
#endif
namespace extensions {
namespace {
struct MockExtensionRegistryObserver : public ExtensionRegistryObserver {
void WaitForInstall(bool expect_error) {
extensions::LoadErrorReporter* error_reporter =
extensions::LoadErrorReporter::GetInstance();
error_reporter->ClearErrors();
while (true) {
base::RunLoop run_loop;
// We do not get a notification if installation fails. Make sure to wake
// up and check for errors to get an error better than the test
// timing-out.
// TODO(jcivelli): make LoadErrorReporter::Observer report installation
// failures for packaged extensions so we don't have to poll.
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE, run_loop.QuitClosure(),
base::TimeDelta::FromMilliseconds(100));
quit_closure = run_loop.QuitClosure();
run_loop.Run();
const std::vector<base::string16>* errors = error_reporter->GetErrors();
if (!errors->empty()) {
if (!expect_error) {
FAIL() << "Error(s) happened when unzipping extension: "
<< (*errors)[0];
}
break;
}
if (!last_extension_installed.empty()) {
// Extension install succeeded.
EXPECT_FALSE(expect_error);
break;
}
}
}
void OnExtensionInstalled(content::BrowserContext* browser_context,
const Extension* extension,
bool is_update) override {
last_extension_installed = extension->id();
quit_closure.Run();
}
std::string last_extension_installed;
base::Closure quit_closure;
};
struct UnzipFileFilterTestCase {
const base::FilePath::CharType* input;
const bool should_unzip;
};
} // namespace
class ZipFileInstallerTest : public testing::Test {
public:
ZipFileInstallerTest()
: browser_threads_(content::TestBrowserThreadBundle::IO_MAINLOOP),
data_decoder_(test_connector_factory_.RegisterInstance(
data_decoder::mojom::kServiceName)),
unzip_service_(test_connector_factory_.RegisterInstance(
unzip::mojom::kServiceName)),
connector_(test_connector_factory_.CreateConnector()) {
test_connector_factory_.set_ignore_quit_requests(true);
}
void SetUp() override {
extensions::LoadErrorReporter::Init(/*enable_noisy_errors=*/false);
in_process_utility_thread_helper_.reset(
new content::InProcessUtilityThreadHelper);
// Create profile for extension service.
profile_.reset(new TestingProfile());
TestExtensionSystem* system =
static_cast<TestExtensionSystem*>(ExtensionSystem::Get(profile_.get()));
extension_service_ = system->CreateExtensionService(
base::CommandLine::ForCurrentProcess(), base::FilePath(), false);
ExtensionRegistry* registry(ExtensionRegistry::Get(profile_.get()));
registry->AddObserver(&observer_);
}
void TearDown() override {
// Need to destruct ZipFileInstaller before the message loop since
// it posts a task to it.
zipfile_installer_ = NULL;
ExtensionRegistry* registry(ExtensionRegistry::Get(profile_.get()));
registry->RemoveObserver(&observer_);
profile_.reset();
base::RunLoop().RunUntilIdle();
}
void RunInstaller(const std::string& zip_name, bool expect_error) {
base::FilePath original_path;
ASSERT_TRUE(base::PathService::Get(chrome::DIR_TEST_DATA, &original_path));
original_path = original_path.AppendASCII("extensions")
.AppendASCII("zipfile_installer")
.AppendASCII(zip_name);
ASSERT_TRUE(base::PathExists(original_path)) << original_path.value();
zipfile_installer_ = ZipFileInstaller::Create(
connector_.get(),
MakeRegisterInExtensionServiceCallback(extension_service_));
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindOnce(&ZipFileInstaller::LoadFromZipFile,
zipfile_installer_, original_path));
observer_.WaitForInstall(expect_error);
}
void RunZipFileFilterTest(
const std::vector<UnzipFileFilterTestCase>& cases,
base::RepeatingCallback<bool(const base::FilePath&)>& filter) {
for (size_t i = 0; i < cases.size(); ++i) {
base::FilePath input(cases[i].input);
bool observed = filter.Run(input);
EXPECT_EQ(cases[i].should_unzip, observed)
<< "i: " << i << ", input: " << input.value();
}
}
protected:
scoped_refptr<ZipFileInstaller> zipfile_installer_;
std::unique_ptr<TestingProfile> profile_;
ExtensionService* extension_service_;
content::TestBrowserThreadBundle browser_threads_;
std::unique_ptr<content::InProcessUtilityThreadHelper>
in_process_utility_thread_helper_;
MockExtensionRegistryObserver observer_;
#if defined(OS_CHROMEOS)
chromeos::ScopedCrosSettingsTestHelper cros_settings_test_helper_;
// ChromeOS needs a user manager to instantiate an extension service.
chromeos::ScopedTestUserManager test_user_manager_;
#endif
private:
service_manager::TestConnectorFactory test_connector_factory_;
data_decoder::DataDecoderService data_decoder_;
unzip::UnzipService unzip_service_;
std::unique_ptr<service_manager::Connector> connector_;
};
TEST_F(ZipFileInstallerTest, GoodZip) {
RunInstaller("good.zip", /*expect_error=*/false);
}
TEST_F(ZipFileInstallerTest, BadZip) {
// Manifestless archive.
RunInstaller("bad.zip", /*expect_error=*/true);
}
TEST_F(ZipFileInstallerTest, ZipWithPublicKey) {
RunInstaller("public_key.zip", /*expect_error=*/false);
const char kIdForPublicKey[] = "ikppjpenhoddphklkpdfdfdabbakkpal";
EXPECT_EQ(observer_.last_extension_installed, kIdForPublicKey);
}
TEST_F(ZipFileInstallerTest, NonTheme_FileExtractionFilter) {
const std::vector<UnzipFileFilterTestCase> cases = {
{FILE_PATH_LITERAL("foo"), true},
{FILE_PATH_LITERAL("foo.nexe"), true},
{FILE_PATH_LITERAL("foo.dll"), true},
{FILE_PATH_LITERAL("foo.jpg.exe"), false},
{FILE_PATH_LITERAL("foo.exe"), false},
{FILE_PATH_LITERAL("foo.EXE"), false},
{FILE_PATH_LITERAL("file_without_extension"), true},
};
base::RepeatingCallback<bool(const base::FilePath&)> filter =
base::BindRepeating(&ZipFileInstaller::ShouldExtractFile, false);
RunZipFileFilterTest(cases, filter);
}
TEST_F(ZipFileInstallerTest, Theme_FileExtractionFilter) {
const std::vector<UnzipFileFilterTestCase> cases = {
{FILE_PATH_LITERAL("image.jpg"), true},
{FILE_PATH_LITERAL("IMAGE.JPEG"), true},
{FILE_PATH_LITERAL("test/image.bmp"), true},
{FILE_PATH_LITERAL("test/IMAGE.gif"), true},
{FILE_PATH_LITERAL("test/image.WEBP"), true},
{FILE_PATH_LITERAL("test/dir/file.image.png"), true},
{FILE_PATH_LITERAL("manifest.json"), true},
{FILE_PATH_LITERAL("other.html"), false},
{FILE_PATH_LITERAL("file_without_extension"), true},
};
base::RepeatingCallback<bool(const base::FilePath&)> filter =
base::BindRepeating(&ZipFileInstaller::ShouldExtractFile, true);
RunZipFileFilterTest(cases, filter);
}
TEST_F(ZipFileInstallerTest, ManifestExtractionFilter) {
const std::vector<UnzipFileFilterTestCase> cases = {
{FILE_PATH_LITERAL("manifest.json"), true},
{FILE_PATH_LITERAL("MANIFEST.JSON"), true},
{FILE_PATH_LITERAL("test/manifest.json"), false},
{FILE_PATH_LITERAL("manifest.json/test"), false},
{FILE_PATH_LITERAL("other.file"), false},
};
base::RepeatingCallback<bool(const base::FilePath&)> filter =
base::BindRepeating(&ZipFileInstaller::IsManifestFile);
RunZipFileFilterTest(cases, filter);
}
} // namespace extensions
|