File: ldap.c

package info (click to toggle)
citadel 917-2
  • links: PTS, VCS
  • area: main
  • in suites: buster
  • size: 3,976 kB
  • sloc: ansic: 44,751; sh: 4,209; yacc: 651; makefile: 399
file content (636 lines) | stat: -rw-r--r-- 19,418 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
/*
 * These functions implement the portions of AUTHMODE_LDAP and AUTHMODE_LDAP_AD which
 * actually speak to the LDAP server.
 *
 * Copyright (c) 2011-2017 by the citadel.org development team.
 *
 * This program is open source software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License, version 3.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 */

int ctdl_require_ldap_version = 3;

#define _GNU_SOURCE		// Needed to suppress warning about vasprintf() when running on Linux/Linux
#include <stdio.h>
#include <libcitadel.h>
#include "citserver.h"
#include "citadel_ldap.h"
#include "ctdl_module.h"
#include "user_ops.h"
#include "internet_addressing.h"
#include "config.h"

#ifdef HAVE_LDAP
#define LDAP_DEPRECATED 1 	// Suppress libldap's warning that we are using deprecated API calls
#include <ldap.h>


/*
 * Utility function, supply a search result and get back the fullname (display name, common name, etc) from the first result
 */
void derive_fullname_from_ldap_result(char *fullname, int fullname_size, LDAP *ldserver, LDAPMessage *search_result)
{
	char **values;

	if (fullname == NULL) return;

	if (CtdlGetConfigInt("c_auth_mode") == AUTHMODE_LDAP_AD) {
		values = ldap_get_values(ldserver, search_result, "displayName");
		if (values) {
			if (values[0]) {
				if (fullname) safestrncpy(fullname, values[0], fullname_size);
				syslog(LOG_DEBUG, "ldap: displayName = %s", values[0]);
			}
			ldap_value_free(values);
		}
	}
	else {
		values = ldap_get_values(ldserver, search_result, "cn");
		if (values) {
			if (values[0]) {
				if (fullname) safestrncpy(fullname, values[0], fullname_size);
				syslog(LOG_DEBUG, "ldap: cn = %s", values[0]);
			}
			ldap_value_free(values);
		}
	}
}


/*
 * Utility function, supply a search result and get back the uid from the first result
 */
uid_t derive_uid_from_ldap(LDAP *ldserver, LDAPMessage *entry)
{
	char **values;
	uid_t uid = (-1);

	if (CtdlGetConfigInt("c_auth_mode") == AUTHMODE_LDAP_AD) {
		values = ldap_get_values(ldserver, entry, "objectGUID");	// AD schema: uid hashed from objectGUID
		if (values) {
			if (values[0]) {
				uid = abs(HashLittle(values[0], strlen(values[0])));
			}
			ldap_value_free(values);
		}
	}
	else {
		values = ldap_get_values(ldserver, entry, "uidNumber");		// POSIX schema: uid = uidNumber
		if (values) {
			if (values[0]) {
				uid = atoi(values[0]);
			}
			ldap_value_free(values);
		}
	}

	return(uid);
}


/*
 * Wrapper function for ldap_initialize() that consistently fills in the correct fields
 */
int ctdl_ldap_initialize(LDAP **ld) {

	char server_url[256];
	int ret;

	snprintf(server_url, sizeof server_url, "ldap://%s:%d", CtdlGetConfigStr("c_ldap_host"), CtdlGetConfigInt("c_ldap_port"));
	ret = ldap_initialize(ld, server_url);
	if (ret != LDAP_SUCCESS) {
		syslog(LOG_ERR, "ldap: could not connect to %s : %m", server_url);
		*ld = NULL;
		return(errno);
	}

	return(ret);
}


/*
 * Bind to the LDAP server and return a working handle
 */
LDAP *ctdl_ldap_bind(void) {
	LDAP *ldserver = NULL;
	int i;

	if (ctdl_ldap_initialize(&ldserver) != LDAP_SUCCESS) {
		return(NULL);
	}

	ldap_set_option(ldserver, LDAP_OPT_PROTOCOL_VERSION, &ctdl_require_ldap_version);
	ldap_set_option(ldserver, LDAP_OPT_REFERRALS, (void *)LDAP_OPT_OFF);

	striplt(CtdlGetConfigStr("c_ldap_bind_dn"));
	striplt(CtdlGetConfigStr("c_ldap_bind_pw"));
	i = ldap_simple_bind_s(ldserver,
		(!IsEmptyStr(CtdlGetConfigStr("c_ldap_bind_dn")) ? CtdlGetConfigStr("c_ldap_bind_dn") : NULL),
		(!IsEmptyStr(CtdlGetConfigStr("c_ldap_bind_pw")) ? CtdlGetConfigStr("c_ldap_bind_pw") : NULL)
	);
	if (i != LDAP_SUCCESS) {
		syslog(LOG_ERR, "ldap: Cannot bind: %s (%d)", ldap_err2string(i), i);
		return(NULL);
	}

	return(ldserver);
}


/*
 * Look up a user in the directory to see if this is an account that can be authenticated
 */
int CtdlTryUserLDAP(char *username,
		char *found_dn, int found_dn_size,
		char *fullname, int fullname_size,
		uid_t *uid)
{
	LDAP *ldserver = NULL;
	LDAPMessage *search_result = NULL;
	LDAPMessage *entry = NULL;
	char searchstring[1024];
	struct timeval tv;
	char *user_dn = NULL;

	ldserver = ctdl_ldap_bind();
	if (!ldserver) return(-1);

	if (fullname) safestrncpy(fullname, username, fullname_size);
	tv.tv_sec = 10;
	tv.tv_usec = 0;

	if (CtdlGetConfigInt("c_auth_mode") == AUTHMODE_LDAP_AD) {
		snprintf(searchstring, sizeof(searchstring), "(sAMAccountName=%s)", username);
	}
	else {
		snprintf(searchstring, sizeof(searchstring), "(&(objectclass=posixAccount)(cn=%s))", username);
		// snprintf(searchstring, sizeof(searchstring), "(&(objectclass=posixAccount)(uid=%s))", username);
	}

	syslog(LOG_DEBUG, "ldap: search: %s", searchstring);
	(void) ldap_search_ext_s(
		ldserver,					/* ld				*/
		CtdlGetConfigStr("c_ldap_base_dn"),		/* base				*/
		LDAP_SCOPE_SUBTREE,				/* scope			*/
		searchstring,					/* filter			*/
		NULL,						/* attrs (all attributes)	*/
		0,						/* attrsonly (attrs + values)	*/
		NULL,						/* serverctrls (none)		*/
		NULL,						/* clientctrls (none)		*/
		&tv,						/* timeout			*/
		1,						/* sizelimit (1 result max)	*/
		&search_result					/* res				*/
	);

	/* Ignore the return value of ldap_search_ext_s().  Sometimes it returns an error even when
	 * the search succeeds.  Instead, we check to see whether search_result is still NULL.
	 */
	if (search_result == NULL) {
		syslog(LOG_DEBUG, "ldap: zero search results were returned");
		ldap_unbind(ldserver);
		return(2);
	}

	/* At this point we've got at least one result from our query.  If there are multiple
	 * results, we still only look at the first one.
	 */
	entry = ldap_first_entry(ldserver, search_result);
	if (entry) {

		user_dn = ldap_get_dn(ldserver, entry);
		if (user_dn) {
			syslog(LOG_DEBUG, "ldap: dn = %s", user_dn);
		}

		derive_fullname_from_ldap_result(fullname, fullname_size, ldserver, search_result);
		*uid = derive_uid_from_ldap(ldserver, search_result);
	}

	/* free the results */
	ldap_msgfree(search_result);

	/* unbind so we can go back in as the authenticating user */
	ldap_unbind(ldserver);

	if (!user_dn) {
		syslog(LOG_DEBUG, "ldap: No such user was found.");
		return(4);
	}

	if (found_dn) safestrncpy(found_dn, user_dn, found_dn_size);
	ldap_memfree(user_dn);
	return(0);
}


int CtdlTryPasswordLDAP(char *user_dn, const char *password)
{
	LDAP *ldserver = NULL;
	int i = (-1);

	if (IsEmptyStr(password)) {
		syslog(LOG_DEBUG, "ldap: empty passwords are not permitted");
		return(1);
	}

	syslog(LOG_DEBUG, "ldap: trying to bind as %s", user_dn);
	i = ctdl_ldap_initialize(&ldserver);
	if (i == LDAP_SUCCESS) {
		ldap_set_option(ldserver, LDAP_OPT_PROTOCOL_VERSION, &ctdl_require_ldap_version);
		i = ldap_simple_bind_s(ldserver, user_dn, password);
		if (i == LDAP_SUCCESS) {
			syslog(LOG_DEBUG, "ldap: bind succeeded");
		}
		else {
			syslog(LOG_DEBUG, "ldap: Cannot bind: %s (%d)", ldap_err2string(i), i);
		}
		ldap_set_option(ldserver, LDAP_OPT_REFERRALS, (void *)LDAP_OPT_OFF);
		ldap_unbind(ldserver);
	}

	if (i == LDAP_SUCCESS) {
		return(0);
	}

	return(1);
}


//return !0 iff property changed.
int vcard_set_props_iff_different(struct vCard *v,char *propname,int numvals, char **vals) {
	int i;
	char *oldval = "";
	for(i=0;i<numvals;i++) {
	  oldval = vcard_get_prop(v,propname,0,i,0);
	  if (oldval == NULL) break;
	  if (strcmp(vals[i],oldval)) break;
	}
	if (i!=numvals) {
		syslog(LOG_DEBUG, "ldap: vcard property %s, element %d of %d changed from %s to %s\n", propname, i, numvals, oldval, vals[i]);
		for(i=0;i<numvals;i++) vcard_set_prop(v,propname,vals[i],(i==0) ? 0 : 1);
		return 1;
	}
	return 0;
}


//return !0 iff property changed.
int vcard_set_one_prop_iff_different(struct vCard *v,char *propname, char *newfmt, ...) {
	va_list args;
	char *newvalue;
	int changed_something;
	va_start(args,newfmt);
	if (-1==vasprintf(&newvalue,newfmt,args)) {
		syslog(LOG_ERR, "ldap: out of memory!");
		return 0;
	}
	changed_something = vcard_set_props_iff_different(v,propname,1,&newvalue);
	va_end(args);
	free(newvalue);
	return changed_something;
}


/*
 * Learn LDAP attributes and stuff them into the vCard.
 * Returns nonzero if we changed anything.
 */
int Ctdl_LDAP_to_vCard(char *ldap_dn, struct vCard *v)
{
	int changed_something = 0;
	LDAP *ldserver = NULL;
	struct timeval tv;
	LDAPMessage *search_result = NULL;
	LDAPMessage *entry = NULL;
	char **givenName;
	char **sn;
	char **cn;
	char **initials;
	char **o;
	char **street;
	char **l;
	char **st;
	char **postalCode;
	char **telephoneNumber;
	char **mobile;
	char **homePhone;
	char **facsimileTelephoneNumber;
	char **mail;
	char **uid;
	char **homeDirectory;
	char **uidNumber;
	char **loginShell;
	char **gidNumber;
	char **c;
	char **title;
	char **uuid;
	char *attrs[] = { "*","+",NULL};

	if (!ldap_dn) return(0);
	if (!v) return(0);

	ldserver = ctdl_ldap_bind();
	if (!ldserver) return(-1);

	tv.tv_sec = 10;
	tv.tv_usec = 0;

	syslog(LOG_DEBUG, "ldap: search: %s", ldap_dn);
	(void) ldap_search_ext_s(
		ldserver,				// ld
		ldap_dn,				// base
		LDAP_SCOPE_SUBTREE,			// scope
		NULL,					// filter
		attrs,					// attrs (all attributes)
		0,					// attrsonly (attrs + values)
		NULL,					// serverctrls (none)
		NULL,					// clientctrls (none)
		&tv,					// timeout
		1,					// sizelimit (1 result max)
		&search_result				// res
	);
	
	/* Ignore the return value of ldap_search_ext_s().  Sometimes it returns an error even when
	 * the search succeeds.  Instead, we check to see whether search_result is still NULL.
	 */
	if (search_result == NULL) {
		syslog(LOG_DEBUG, "ldap: zero search results were returned");
		ldap_unbind(ldserver);
		return(0);
	}

	/* At this point we've got at least one result from our query.  If there are multiple
	 * results, we still only look at the first one.
	 */
	entry = ldap_first_entry(ldserver, search_result);
	if (entry) {
		syslog(LOG_DEBUG, "ldap: search got user details for vcard.");
		givenName=ldap_get_values(ldserver, search_result, "givenName");
		sn=ldap_get_values(ldserver, search_result, "sn");
		cn=ldap_get_values(ldserver, search_result, "cn");
		initials=ldap_get_values(ldserver, search_result, "initials");
		title=ldap_get_values(ldserver, search_result, "title");
		o=ldap_get_values(ldserver, search_result, "o");
		street=ldap_get_values(ldserver, search_result, "street");
		l=ldap_get_values(ldserver, search_result, "l");
		st=ldap_get_values(ldserver, search_result, "st");
		postalCode=ldap_get_values(ldserver, search_result, "postalCode");
		telephoneNumber=ldap_get_values(ldserver, search_result, "telephoneNumber");
		mobile=ldap_get_values(ldserver, search_result, "mobile");
		homePhone=ldap_get_values(ldserver, search_result, "homePhone");
		facsimileTelephoneNumber=ldap_get_values(ldserver, search_result, "facsimileTelephoneNumber");
		mail=ldap_get_values(ldserver, search_result, "mail");
		uid=ldap_get_values(ldserver, search_result, "uid");
		homeDirectory=ldap_get_values(ldserver, search_result, "homeDirectory");
		uidNumber=ldap_get_values(ldserver, search_result, "uidNumber");
		loginShell=ldap_get_values(ldserver, search_result, "loginShell");
		gidNumber=ldap_get_values(ldserver, search_result, "gidNumber");
		c=ldap_get_values(ldserver, search_result, "c");
		uuid=ldap_get_values(ldserver, search_result, "entryUUID");

		if (street && l && st && postalCode && c) changed_something |= vcard_set_one_prop_iff_different(v,"adr",";;%s;%s;%s;%s;%s",street[0],l[0],st[0],postalCode[0],c[0]);
		if (telephoneNumber) changed_something |= vcard_set_one_prop_iff_different(v,"tel;work","%s",telephoneNumber[0]);
		if (facsimileTelephoneNumber) changed_something |= vcard_set_one_prop_iff_different(v,"tel;fax","%s",facsimileTelephoneNumber[0]);
		if (mobile) changed_something |= vcard_set_one_prop_iff_different(v,"tel;cell","%s",mobile[0]);
		if (homePhone) changed_something |= vcard_set_one_prop_iff_different(v,"tel;home","%s",homePhone[0]);
		if (givenName && sn) {
			if (initials) {
				changed_something |= vcard_set_one_prop_iff_different(v,"n","%s;%s;%s",sn[0],givenName[0],initials[0]);
			}
			else {
				changed_something |= vcard_set_one_prop_iff_different(v,"n","%s;%s",sn[0],givenName[0]);
			}
		}
		if (mail) {
			changed_something |= vcard_set_props_iff_different(v,"email;internet",ldap_count_values(mail),mail);
		}
		if (uuid) changed_something |= vcard_set_one_prop_iff_different(v,"X-uuid","%s",uuid[0]);
		if (o) changed_something |= vcard_set_one_prop_iff_different(v,"org","%s",o[0]);
		if (cn) changed_something |= vcard_set_one_prop_iff_different(v,"fn","%s",cn[0]);
		if (title) changed_something |= vcard_set_one_prop_iff_different(v,"title","%s",title[0]);
		
		if (givenName) ldap_value_free(givenName);
		if (initials) ldap_value_free(initials);
		if (sn) ldap_value_free(sn);
		if (cn) ldap_value_free(cn);
		if (o) ldap_value_free(o);
		if (street) ldap_value_free(street);
		if (l) ldap_value_free(l);
		if (st) ldap_value_free(st);
		if (postalCode) ldap_value_free(postalCode);
		if (telephoneNumber) ldap_value_free(telephoneNumber);
		if (mobile) ldap_value_free(mobile);
		if (homePhone) ldap_value_free(homePhone);
		if (facsimileTelephoneNumber) ldap_value_free(facsimileTelephoneNumber);
		if (mail) ldap_value_free(mail);
		if (uid) ldap_value_free(uid);
		if (homeDirectory) ldap_value_free(homeDirectory);
		if (uidNumber) ldap_value_free(uidNumber);
		if (loginShell) ldap_value_free(loginShell);
		if (gidNumber) ldap_value_free(gidNumber);
		if (c) ldap_value_free(c);
		if (title) ldap_value_free(title);
		if (uuid) ldap_value_free(uuid);
	}
	/* free the results */
	ldap_msgfree(search_result);

	/* unbind so we can go back in as the authenticating user */
	ldap_unbind(ldserver);
	return(changed_something);	/* tell the caller whether we made any changes */
}


/*
 * Extract a user's Internet email addresses from LDAP.
 * Returns zero if we got a valid set of addresses; nonzero for error.
 */
int extract_email_addresses_from_ldap(char *ldap_dn, char *emailaddrs)
{
	LDAP *ldserver = NULL;
	struct timeval tv;
	LDAPMessage *search_result = NULL;
	LDAPMessage *entry = NULL;
	char **mail;
	char *attrs[] = { "*","+",NULL};

	if (!ldap_dn) return(1);
	if (!emailaddrs) return(1);

	ldserver = ctdl_ldap_bind();
	if (!ldserver) return(-1);

	tv.tv_sec = 10;
	tv.tv_usec = 0;

	syslog(LOG_DEBUG, "ldap: search: %s", ldap_dn);
	(void) ldap_search_ext_s(
		ldserver,				// ld
		ldap_dn,				// base
		LDAP_SCOPE_SUBTREE,			// scope
		NULL,					// filter
		attrs,					// attrs (all attributes)
		0,					// attrsonly (attrs + values)
		NULL,					// serverctrls (none)
		NULL,					// clientctrls (none)
		&tv,					// timeout
		1,					// sizelimit (1 result max)
		&search_result				// res
	);
	
	/* Ignore the return value of ldap_search_ext_s().  Sometimes it returns an error even when
	 * the search succeeds.  Instead, we check to see whether search_result is still NULL.
	 */
	if (search_result == NULL) {
		syslog(LOG_DEBUG, "ldap: zero search results were returned");
		ldap_unbind(ldserver);
		return(4);
	}

	/* At this point we've got at least one result from our query.  If there are multiple
	 * results, we still only look at the first one.
	 */
	emailaddrs[0] = 0;	/* clear out any previous results */
	entry = ldap_first_entry(ldserver, search_result);
	if (entry) {
		syslog(LOG_DEBUG, "ldap: search got user details");
		mail = ldap_get_values(ldserver, search_result, "mail");

		if (mail) {
			int q;
			for (q=0; q<ldap_count_values(mail); ++q) {
				if (IsDirectory(mail[q], 0)) {
					if ((strlen(emailaddrs) + strlen(mail[q]) + 2) > 512) {
						syslog(LOG_ERR, "ldap: can't fit all email addresses into user record");
					}
					else {
						if (!IsEmptyStr(emailaddrs)) {
							strcat(emailaddrs, "|");
						}
						strcat(emailaddrs, mail[q]);
					}
				}
			}
		}
	}

	/* free the results */
	ldap_msgfree(search_result);

	/* unbind so we can go back in as the authenticating user */
	ldap_unbind(ldserver);
	return(0);
}


/*
 * Scan LDAP for users and populate Citadel's user database with everyone
 */
void CtdlSynchronizeUsersFromLDAP(void)
{
	LDAP *ldserver = NULL;
	LDAPMessage *search_result = NULL;
	LDAPMessage *entry = NULL;
	char *user_dn = NULL;
	char searchstring[1024];
	struct timeval tv;

	if ((CtdlGetConfigInt("c_auth_mode") != AUTHMODE_LDAP) && (CtdlGetConfigInt("c_auth_mode") != AUTHMODE_LDAP_AD)) {
		return;		// not running LDAP
	}

	syslog(LOG_INFO, "ldap: synchronizing Citadel user database from LDAP");

	ldserver = ctdl_ldap_bind();
	if (!ldserver) return;

	tv.tv_sec = 10;
	tv.tv_usec = 0;

	if (CtdlGetConfigInt("c_auth_mode") == AUTHMODE_LDAP_AD) {
			snprintf(searchstring, sizeof(searchstring), "(&(objectClass=user)(objectClass=person)(!(objectClass=computer)))");
	} else {
			snprintf(searchstring, sizeof(searchstring), "(objectClass=inetOrgPerson)");
	}

	syslog(LOG_DEBUG, "ldap: search: %s", searchstring);
	(void) ldap_search_ext_s(
		ldserver,					// ld
		CtdlGetConfigStr("c_ldap_base_dn"),		// base
		LDAP_SCOPE_SUBTREE,				// scope
		searchstring,					// filter
		NULL,						// attrs (all attributes)
		0,						// attrsonly (attrs + values)
		NULL,						// serverctrls (none)
		NULL,						// clientctrls (none)
		&tv,						// timeout
		INT_MAX,					// sizelimit (max)
		&search_result					// result
	);

	/* Ignore the return value of ldap_search_ext_s().  Sometimes it returns an error even when
	 * the search succeeds.  Instead, we check to see whether search_result is still NULL.
	 */
	if (search_result == NULL) {
		syslog(LOG_DEBUG, "ldap: zero search results were returned");
		ldap_unbind(ldserver);
		return;
	}

	syslog(LOG_DEBUG, "ldap: %d entries returned", ldap_count_entries(ldserver, search_result));
	entry = ldap_first_entry(ldserver, search_result);
	while (entry) {

		user_dn = ldap_get_dn(ldserver, entry);
		if (user_dn) {
			syslog(LOG_DEBUG, "ldap: found %s", user_dn);

			int fullname_size = 256;
			char fullname[256] = { 0 } ;
			uid_t uid = (-1);
			char new_emailaddrs[512] = { 0 } ;

			derive_fullname_from_ldap_result(fullname, fullname_size, ldserver, entry);
			uid = derive_uid_from_ldap(ldserver, entry);
			syslog(LOG_DEBUG, "ldap: display name: <%s> , uid = <%d>", fullname, uid);

			// now create or update the user
			int found_user;
			struct ctdluser usbuf;

			found_user = getuserbyuid(&usbuf, uid);
			if (found_user != 0) {
				create_user(fullname, CREATE_USER_DO_NOT_BECOME_USER, uid);
				found_user = getuserbyuid(&usbuf, uid);
				strcpy(fullname, usbuf.fullname);
			}

			if (found_user == 0) {		// user record exists
				// now update the account email addresses if necessary
				if (CtdlGetConfigInt("c_ldap_sync_email_addrs") > 0) {
					if (extract_email_addresses_from_ldap(user_dn, new_emailaddrs) == 0) {
						if (strcmp(usbuf.emailaddrs, new_emailaddrs)) {				// update only if changed
							CtdlSetEmailAddressesForUser(usbuf.fullname, new_emailaddrs);
						}
					}
				}
			}
			ldap_memfree(user_dn);
		}

		entry = ldap_next_entry(ldserver, entry);
	}

	/* free the results */
	ldap_msgfree(search_result);

	/* unbind so we can go back in as the authenticating user */
	ldap_unbind(ldserver);
}

#endif /* HAVE_LDAP */