File: spio-Don-t-write-to-non-allocate-memory.patch

package info (click to toggle)
clamsmtp 1.10-18.1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 1,828 kB
  • sloc: sh: 3,941; ansic: 3,311; makefile: 21
file content (31 lines) | stat: -rw-r--r-- 979 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date: Wed, 3 Jul 2024 22:41:08 +0200
Subject: [PATCH] spio: Don't write to non-allocate memory.

spio::line has a size of SP_LINE_LENGTH items starting at 0 ending at
SP_LINE_LENGTH - 1. Accessing item SP_LINE_LENGTH is out of bounds, it
no longer part of spio::line.

Use `SP_LINE_LENGTH - 1' as the last character.

Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
 common/spio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/spio.c b/common/spio.c
index e25ef3dde5da..6629e72c33fd 100644
--- a/common/spio.c
+++ b/common/spio.c
@@ -463,7 +463,7 @@ int read_raw(spctx_t* ctx, spio_t* io, int opts)
             io->_ln = 0;
             
             /* Null terminate */
-            io->line[SP_LINE_LENGTH] = 0;
+            io->line[SP_LINE_LENGTH -1] = 0;
             
             /* A double check on the return value */
             return count;
-- 
2.45.2