1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521
|
clazy is a compiler plugin which allows clang to understand Qt semantics. You get more than 50 Qt related compiler warnings, ranging from unneeded memory allocations to misusage of API, including fix-its for automatic refactoring.
# Table of contents
- [Source Code](#source-code)
- [Build Instructions](#build-instructions)
- [Linux](#linux)
- [Install dependencies](#install-dependencies)
- [Build and install clang](#build-and-install-clang)
- [Build clazy](#build-clazy)
- [Windows](#windows)
- [Build and install clang](#build-and-install-clang-1)
- [Build clazy](#build-clazy-1)
- [macOS with MacPorts](#macos-with-macports)
- [Install clang](#install-clang)
- [Build clazy](#build-clazy-2)
- [macOS with Homebrew](#macos-with-homebrew)
- [Install clang](#install-clang-1)
- [Build clazy](#build-clazy-3)
- [Setting up your project to build with clazy](#setting-up-your-project-to-build-with-clazy)
- [List of checks](#list-of-checks)
- [Selecting which checks to enable](#selecting-which-checks-to-enable)
- [Example via env variable](#example-via-env-variable)
- [Example via compiler argument](#example-via-compiler-argument)
- [clazy-standalone and JSON database support](#clazy-standalone-and-json-database-support)
- [Enabling Fixits](#enabling-fixits)
- [Troubleshooting](#troubleshooting)
- [Reducing warning noise](#reducing-warning-noise)
- [Reporting bugs and wishes](#reporting-bugs-and-wishes)
- [Authors](#authors)
- [Contributing patches](#contributing-patches)
# Source Code
You can get clazy from:
- <https://github.com/KDE/clazy>
- <https://invent.kde.org/sdk/clazy>
# Supported platforms
Clazy has been tested on Linux, macOS and Windows/MSVC.
Other platforms are not supported but we'll gladly accept patches.
# Build Instructions
## Linux
### Install dependencies
- OpenSUSE tumbleweed: `zypper install cmake git-core llvm llvm-devel llvm-clang llvm-clang-devel`
- Ubuntu: `apt install g++ cmake clang llvm-dev git-core libclang-dev`
- Archlinux: `pacman -S make llvm clang python2 cmake git gcc`
- Fedora: be sure to _remove_ the llvm-static package and only install the one with dynamic libraries
- Other distros: Check llvm/clang build docs.
### Build and install clang
clang and LLVM >= 11.0 are required.
If your distro provides clang then you can skip this step.
```
$ git clone https://github.com/llvm-mirror/llvm.git <some_directory>
$ cd <some_directory>/tools/ && git clone https://github.com/llvm-mirror/clang.git
$ cd <some_directory>/projects && git clone https://github.com/llvm-mirror/compiler-rt.git
$ mkdir <some_directory>/build && cd <some_directory>/build
$ cmake -DCMAKE_INSTALL_PREFIX=<prefix> -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_BUILD_TYPE=Release -G Ninja ..
$ cmake --build .
$ cmake --build . --target install
```
### Build clazy
```
$ cd clazy/
$ cmake -DCMAKE_INSTALL_PREFIX=<prefix> -DCMAKE_BUILD_TYPE=Release -G Ninja
$ cmake --build .
$ cmake --build . --target install
```
See troubleshooting section if you have problems.
## Windows
### Build and install clang
These instructions assume your terminal is suitable for development.
Ninja (or equivalent), git, cmake, and cl (msvc2022) should be in your PATH.
Be sure to pass -DLLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON to CMake when building LLVM, otherwise clazy won't work.
```
> git clone https://github.com/llvm/llvm-project.git -b llvmorg-11.0.0 <some_directory>
> mkdir build # Important that this is outside of the source directory
> cd build
> cmake -DCMAKE_INSTALL_PREFIX=c:\my_install_folder\llvm\ -DLLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_TARGETS_TO_BUILD="X86" -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" -DCMAKE_BUILD_TYPE=Release -G "Ninja" ../<some_directory>/llvm
> cmake --build .
> cmake --build . --target install
> Add c:\my_install_folder\llvm\bin\ to PATH
```
Also be sure to copy the generated `C:\path\to\llvm-build\lib\clang.lib` to your installation folder somewhere. It contains the exported symbols of clang.exe, which the plugins need.
Unfortunately LLVM doesn't install it. You can put it anywhere, just save it so you can delete the build directory.
### Build clazy
Be sure to point CLANG_LIBRARY_IMPORT to clang.lib. It's probably inside your LLVM build dir since it doesn't get installed.
```
> cd clazy\
> cmake -DCMAKE_INSTALL_PREFIX=c:\my_install_folder\llvm\ -DCLANG_LIBRARY_IMPORT=C:\path\to\llvm-build\lib\clang.lib -DCMAKE_BUILD_TYPE=Release -G "Ninja"
> cmake --build .
> cmake --build . --target install
```
## macOS with MacPorts
### Install clang
```
$ sudo port install llvm-11 clang-11 cmake ninja coreutils
$ sudo ln -sf /opt/local/bin/llvm-config-mp-11 /opt/local/bin/llvm-config
$ sudo port select --set clang mp-clang-11
```
### Build clazy
```
$ export CXX=clang++
$ cmake -G Ninja
$ cmake --build .
$ cmake --build . --target install
```
## macOS with Homebrew
The recommended way is to build clazy yourself, but alternatively you can try user recipes, such as:
```
$ brew install kde-mac/kde/clazy
```
for stable branch, or for master:
```
$ brew install kde-mac/kde/clazy --HEAD
```
As these are not verified or tested by the clazy developers please don't report bugs to us.
For building yourself, read on. You'll have to install clang and build clazy from source.
### Install clang
```
$ brew install --with-clang llvm
```
### Build clazy
```
$ export CXX=clang++
$ export LLVM_ROOT=/usr/local/opt/llvm
$ cmake -G Ninja
$ cmake --build .
$ cmake --build . --target install
```
# Setting up your project to build with clazy
Note: Wherever `clazy` is mentioned, replace with `clazy-cl.bat` if you're on Windows, or replace with `Clazy-x86_64.AppImage` if you're using AppImage.
Note: If you prefer running clazy over a JSON compilation database instead of using it as a plugin, jump to [clazy-standalone](#clazy-standalone-and-json-database-support).
You should now have the clazy command available to you, in `<prefix>/bin/`.
Compile your programs with it instead of clang++/g++.
Note that this command is just a convenience wrapper which calls:
`clang++ -Xclang -load -Xclang ClazyPlugin.so -Xclang -add-plugin -Xclang clazy`
If you have multiple versions of clang installed (say clang++-10 and clang++-11)
you can choose which one to use by setting the CLANGXX environment variable, like so:
`export CLANGXX=clang++-11; clazy`
To build a CMake project use:
`cmake . -DCMAKE_CXX_COMPILER=clazy`
and rebuild.
To make it the compiler for qmake projects, just run qmake like:
`qmake -spec linux-clang QMAKE_CXX="clazy"`
On Windows with MSVC it's simply: `qmake QMAKE_CXX="clazy-cl.bat"`
Alternatively, if you want to use clang directly, without the wrapper:
`qmake -spec linux-clang QMAKE_CXXFLAGS="-Xclang -load -Xclang ClazyPlugin.so -Xclang -add-plugin -Xclang clazy"`
On Windows it's similar, just inspect the contents of `clazy-cl.bat`.
To use clazy from a preset in `CMakePresets.json` or `CMakeUserPresets.json`:
"cacheVariables": {
"CMAKE_CXX_FLAGS": "-Xclang -plugin-arg-clazy -Xclang export-fixes -Xclang -plugin-arg-clazy -Xclang level0,detaching-temporary",
"CMAKE_CXX_COMPILER": "clazy"
}
It's recommended that you disable pre-compiled headers and don't use ccache.
You're all set, clazy will now run some checks on your project, but not all of them.
Read on if you want to enable/disable which checks are run.
# List of checks
There are many checks and they are divided in levels:
- level0: Very stable checks, 99.99% safe, mostly no false-positives, very desirable
- level1: The default level. Very similar to level 0, slightly more false-positives but very few.
- level2: Also very few false-positives, but contains noisy checks which not everyone agree should be default.
- manual: Checks here need to be enabled explicitly, as they don't belong to any level. They can be very stable or very unstable.
clazy runs all checks from level1 by default.
- Checks from Manual Level:
- [assert-with-side-effects](docs/checks/README-assert-with-side-effects.md)
- [container-inside-loop](docs/checks/README-container-inside-loop.md)
- [detaching-member](docs/checks/README-detaching-member.md)
- [heap-allocated-small-trivial-type](docs/checks/README-heap-allocated-small-trivial-type.md)
- [ifndef-define-typo](docs/checks/README-ifndef-define-typo.md)
- [isempty-vs-count](docs/checks/README-isempty-vs-count.md)
- [jni-signatures](docs/checks/README-jni-signatures.md)
- [qbytearray-conversion-to-c-style](docs/checks/README-qbytearray-conversion-to-c-style.md) (fix-qbytearray-conversion-to-c-style)
- [qhash-with-char-pointer-key](docs/checks/README-qhash-with-char-pointer-key.md)
- [qproperty-type-mismatch](docs/checks/README-qproperty-type-mismatch.md)
- [qrequiredresult-candidates](docs/checks/README-qrequiredresult-candidates.md)
- [qstring-varargs](docs/checks/README-qstring-varargs.md)
- [qt-keyword-emit](docs/checks/README-qt-keyword-emit.md) (fix-qt-keyword-emit)
- [qt-keywords](docs/checks/README-qt-keywords.md) (fix-qt-keywords)
- [qt6-deprecated-api-fixes](docs/checks/README-qt6-deprecated-api-fixes.md) (fix-qt6-deprecated-api-fixes)
- [qt6-fwd-fixes](docs/checks/README-qt6-fwd-fixes.md) (fix-qt6-fwd-fixes)
- [qt6-header-fixes](docs/checks/README-qt6-header-fixes.md) (fix-qt6-header-fixes)
- [qt6-qhash-signature](docs/checks/README-qt6-qhash-signature.md) (fix-qt6-qhash-signature)
- [qt6-qlatin1stringchar-to-u](docs/checks/README-qt6-qlatin1stringchar-to-u.md) (fix-qt6-qlatin1stringchar-to-u)
- [qvariant-template-instantiation](docs/checks/README-qvariant-template-instantiation.md)
- [raw-environment-function](docs/checks/README-raw-environment-function.md)
- [reserve-candidates](docs/checks/README-reserve-candidates.md)
- [sanitize-inline-keyword](docs/checks/README-sanitize-inline-keyword.md) (fix-sanitize-inline-keyword)
- [signal-with-return-value](docs/checks/README-signal-with-return-value.md)
- [thread-with-slots](docs/checks/README-thread-with-slots.md)
- [tr-non-literal](docs/checks/README-tr-non-literal.md)
- [unexpected-flag-enumerator-value](docs/checks/README-unexpected-flag-enumerator-value.md)
- [unneeded-cast](docs/checks/README-unneeded-cast.md)
- [unused-result-check](docs/checks/README-unused-result-check.md)
- [use-arrow-operator-instead-of-data](docs/checks/README-use-arrow-operator-instead-of-data.md)
- [use-chrono-in-qtimer](docs/checks/README-use-chrono-in-qtimer.md)
- [used-qunused-variable](docs/checks/README-used-qunused-variable.md)
- Checks from Level 0:
- [connect-by-name](docs/checks/README-connect-by-name.md)
- [connect-non-signal](docs/checks/README-connect-non-signal.md)
- [connect-not-normalized](docs/checks/README-connect-not-normalized.md)
- [container-anti-pattern](docs/checks/README-container-anti-pattern.md)
- [empty-qstringliteral](docs/checks/README-empty-qstringliteral.md)
- [fully-qualified-moc-types](docs/checks/README-fully-qualified-moc-types.md) (fix-fully-qualified-moc-types)
- [lambda-in-connect](docs/checks/README-lambda-in-connect.md)
- [lambda-unique-connection](docs/checks/README-lambda-unique-connection.md)
- [lowercase-qml-type-name](docs/checks/README-lowercase-qml-type-name.md)
- [mutable-container-key](docs/checks/README-mutable-container-key.md)
- [no-module-include](docs/checks/README-no-module-include.md)
- [overloaded-signal](docs/checks/README-overloaded-signal.md)
- [qcolor-from-literal](docs/checks/README-qcolor-from-literal.md) (fix-qcolor-from-literal)
- [qdatetime-utc](docs/checks/README-qdatetime-utc.md) (fix-qdatetime-utc)
- [qenums](docs/checks/README-qenums.md)
- [qfileinfo-exists](docs/checks/README-qfileinfo-exists.md) (fix-qfileinfo-exists)
- [qgetenv](docs/checks/README-qgetenv.md) (fix-qgetenv)
- [qmap-with-pointer-key](docs/checks/README-qmap-with-pointer-key.md)
- [qstring-arg](docs/checks/README-qstring-arg.md)
- [qstring-comparison-to-implicit-char](docs/checks/README-qstring-comparison-to-implicit-char.md)
- [qstring-insensitive-allocation](docs/checks/README-qstring-insensitive-allocation.md)
- [qstring-ref](docs/checks/README-qstring-ref.md) (fix-missing-qstringref)
- [qt-macros](docs/checks/README-qt-macros.md)
- [strict-iterators](docs/checks/README-strict-iterators.md)
- [temporary-iterator](docs/checks/README-temporary-iterator.md)
- [unused-non-trivial-variable](docs/checks/README-unused-non-trivial-variable.md)
- [use-static-qregularexpression](docs/checks/README-use-static-qregularexpression.md)
- [writing-to-temporary](docs/checks/README-writing-to-temporary.md)
- [wrong-qevent-cast](docs/checks/README-wrong-qevent-cast.md)
- [wrong-qglobalstatic](docs/checks/README-wrong-qglobalstatic.md)
- Checks from Level 1:
- [auto-unexpected-qstringbuilder](docs/checks/README-auto-unexpected-qstringbuilder.md) (fix-auto-unexpected-qstringbuilder)
- [child-event-qobject-cast](docs/checks/README-child-event-qobject-cast.md)
- [connect-3arg-lambda](docs/checks/README-connect-3arg-lambda.md)
- [const-signal-or-slot](docs/checks/README-const-signal-or-slot.md)
- [detaching-temporary](docs/checks/README-detaching-temporary.md)
- [foreach](docs/checks/README-foreach.md)
- [incorrect-emit](docs/checks/README-incorrect-emit.md)
- [install-event-filter](docs/checks/README-install-event-filter.md)
- [non-pod-global-static](docs/checks/README-non-pod-global-static.md)
- [overridden-signal](docs/checks/README-overridden-signal.md)
- [post-event](docs/checks/README-post-event.md)
- [qdeleteall](docs/checks/README-qdeleteall.md)
- [qhash-namespace](docs/checks/README-qhash-namespace.md)
- [qlatin1string-non-ascii](docs/checks/README-qlatin1string-non-ascii.md)
- [qproperty-without-notify](docs/checks/README-qproperty-without-notify.md)
- [qstring-left](docs/checks/README-qstring-left.md)
- [range-loop-detach](docs/checks/README-range-loop-detach.md) (fix-range-loop-add-qasconst)
- [range-loop-reference](docs/checks/README-range-loop-reference.md) (fix-range-loop-add-ref)
- [readlock-detaching](docs/checks/README-readlock-detaching.md)
- [returning-data-from-temporary](docs/checks/README-returning-data-from-temporary.md)
- [rule-of-two-soft](docs/checks/README-rule-of-two-soft.md)
- [skipped-base-method](docs/checks/README-skipped-base-method.md)
- [virtual-signal](docs/checks/README-virtual-signal.md)
- Checks from Level 2:
- [base-class-event](docs/checks/README-base-class-event.md)
- [copyable-polymorphic](docs/checks/README-copyable-polymorphic.md)
- [ctor-missing-parent-argument](docs/checks/README-ctor-missing-parent-argument.md)
- [function-args-by-ref](docs/checks/README-function-args-by-ref.md) (fix-function-args-by-ref)
- [function-args-by-value](docs/checks/README-function-args-by-value.md)
- [global-const-char-pointer](docs/checks/README-global-const-char-pointer.md)
- [implicit-casts](docs/checks/README-implicit-casts.md)
- [missing-qobject-macro](docs/checks/README-missing-qobject-macro.md) (fix-missing-qobject-macro)
- [missing-typeinfo](docs/checks/README-missing-typeinfo.md)
- [old-style-connect](docs/checks/README-old-style-connect.md) (fix-old-style-connect)
- [qstring-allocations](docs/checks/README-qstring-allocations.md) (fix-qlatin1string-allocations,fix-fromLatin1_fromUtf8-allocations,fix-fromCharPtrAllocations)
- [returning-void-expression](docs/checks/README-returning-void-expression.md)
- [rule-of-three](docs/checks/README-rule-of-three.md)
- [static-pmf](docs/checks/README-static-pmf.md)
- [virtual-call-ctor](docs/checks/README-virtual-call-ctor.md)
# Selecting which checks to enable
You may want to choose which checks to enable before starting to compile.
If you don't specify anything then all checks from level0 and level1 will run.
To specify a list of checks to run, or to choose a level, you can use the `CLAZY_CHECKS` env variable or pass arguments to the compiler.
You can disable checks by prefixing with `no-`, in case you don't want all checks from a given level.
## Example via env variable
```
export CLAZY_CHECKS="unneeded-cast,qmap-with-pointer-key,virtual-call-ctor" # Enables only these 3 checks
export CLAZY_CHECKS="level0,no-qenums" # Enables all checks from level0, except for qenums
export CLAZY_CHECKS="level0,detaching-temporary" # Enables all from level0 and also detaching-temporary
```
## Example via compiler argument
`clazy -Xclang -plugin-arg-clazy -Xclang level0,detaching-temporary`
Don't forget to re-run cmake/qmake/etc if you altered the c++ flags to specify flags.
# clazy-standalone and JSON database support
The `clazy-standalone` binary allows you to run clazy over a compilation database JSON file, in the same
way you would use `clang-tidy` or other clang tooling. This way you don't need to build your application,
only the static analysis is performed.
Note: If you're using the AppImage, use `Clazy-x86_64.AppImage --standalone` instead of `clazy-standalone`.
`clazy-standalone` supports the same env variables as the clazy plugin. You can also specify a list of checks via
the `-checks` argument.
Running on one cpp file:
`clazy-standalone -checks=install-event-filter,qmap-with-pointer-key,level0 -p compile_commands.json my.file.cpp`
Running on all cpp files:
`find . -name "*cpp" | xargs clazy-standalone -checks=level2 -p default/compile_commands.json`
See https://clang.llvm.org/docs/JSONCompilationDatabase.html for how to generate the compile_commands.json file. Basically it's generated
by passing `-DCMAKE_EXPORT_COMPILE_COMMANDS` to CMake, or using [Bear](https://github.com/rizsotto/Bear) to intercept compiler commands, or, if you're using `qbs`:
`qbs generate --generator clangdb`
**Note:** Be sure the clazy-standalone binary is located in the same folder as the clang binary, otherwise it will have trouble
finding builtin headers, like stddef.h. Alternatively, you can symlink to the folder containing the builtin headers:
(Assuming clazy was built with `-DCMAKE_INSTALL_PREFIX=/myprefix/`)
```
$ touch foo.c && clang++ '-###' -c foo.c 2>&1 | tr ' ' '\n' | grep -A1 resource # Make sure this clang here is not Apple clang. Use for example clang++-mp-8.0 if on macOS and haven't run `port select` yet.
"-resource-dir"
"/opt/local/libexec/llvm-8.0/lib/clang/8.0.1" # The interesting part is /opt/local/libexec/llvm-8.0
$ ln -sf /opt/local/libexec/llvm-8.0/lib/clang/ /myprefix/lib/clang
$ mkdir /myprefix/include/
$ ln -sf /opt/local/libexec/llvm-8.0/include/c++/ /myprefix/include/c++ # Required on macOS
```
If that doesn't work, run `clang -v` and check what's the InstalledDir. Move clazy-standalone to that folder.
# Clang-Tidy
Clazy optionally builds a plugin for integrating its checks into `clang-tidy`. This needs to be explicitly loaded using `-load=ClazyClangTidy.so`.
In case the plugin is not in a standard location or in the `LD_LIBRARY_PATH` environment variable, an absolute path should be specified.
Checks need to be enabled explicitly. Due to clang-tidy only reporting warnings from enabled checks, one can not specify levels.
For example `-checks=clazy-qdatetime-utc,clazy-qgetenv"`
<!-- jq -r '[.checks[] | select(.level == 0) | "clazy-" + .name] | join(",")' checks.json -->
To enable all checks from level0 use:
`clazy-overloaded-signal,clazy-connect-by-name,clazy-connect-non-signal,clazy-qstring-comparison-to-implicit-char,clazy-wrong-qevent-cast,clazy-lambda-in-connect,clazy-lambda-unique-connection,clazy-qdatetime-utc,clazy-qgetenv,clazy-qstring-insensitive-allocation,clazy-fully-qualified-moc-types,clazy-unused-non-trivial-variable,clazy-connect-not-normalized,clazy-mutable-container-key,clazy-qenums,clazy-qmap-with-pointer-key,clazy-qstring-ref,clazy-strict-iterators,clazy-writing-to-temporary,clazy-container-anti-pattern,clazy-qcolor-from-literal,clazy-qfileinfo-exists,clazy-qstring-arg,clazy-empty-qstringliteral,clazy-qt-macros,clazy-temporary-iterator,clazy-wrong-qglobalstatic,clazy-lowercase-qml-type-name,clazy-no-module-include,clazy-use-static-qregularexpression`
To enable all checks from level1 use:
`clazy-auto-unexpected-qstringbuilder,clazy-connect-3arg-lambda,clazy-const-signal-or-slot,clazy-detaching-temporary,clazy-foreach,clazy-incorrect-emit,clazy-install-event-filter,clazy-non-pod-global-static,clazy-post-event,clazy-qdeleteall,clazy-qlatin1string-non-ascii,clazy-qproperty-without-notify,clazy-qstring-left,clazy-range-loop-detach,clazy-range-loop-reference,clazy-returning-data-from-temporary,clazy-rule-of-two-soft,clazy-child-event-qobject-cast,clazy-virtual-signal,clazy-overridden-signal,clazy-qhash-namespace,clazy-skipped-base-method,clazy-readlock-detaching`
To enable all checks from level2 use:
`clazy-ctor-missing-parent-argument,clazy-base-class-event,clazy-copyable-polymorphic,clazy-function-args-by-ref,clazy-function-args-by-value,clazy-global-const-char-pointer,clazy-implicit-casts,clazy-missing-qobject-macro,clazy-missing-typeinfo,clazy-old-style-connect,clazy-qstring-allocations,clazy-returning-void-expression,clazy-rule-of-three,clazy-virtual-call-ctor,clazy-static-pmf`
# Enabling Fixits
Some checks support fixits, in which clazy will help re-write your source files whenever it can fix something.
Simply pass `-Xclang -plugin-arg-clazy -Xclang export-fixes` to clang, or `-export-fixes=somefile.yaml` for `clazy-standalone`.
Alternatively, set the `CLAZY_EXPORT_FIXES` env variable (works only with the plugin, not with standalone).
Then run `clang-apply-replacements <folder_with_yaml_files>`, which will modify your code.
When using fixits, prefer to run only a single check each time, so they don't conflict
with each other modifying the same source lines.
**WARNING**: Backup your code and make sure all changes done by clazy are correct.
# Troubleshooting
- CommandLine Error: `Option 'foo' registered more than once!`
Means you're building against a static version of LLVM (\*.a files instead of \*.so).
Try passing to cmake -DLINK_CLAZY_TO_LLVM=OFF when building clazy, this was tested
successfully against a static LLVM 7.0, and might work with other versions.
In case you build LLVM from source, try adding `-DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON` to your CMake options
- Some checks are mysteriously not producing warnings or not applying fixits ?
Check if you have ccache interfering and turn it off.
- fatal error: 'stddef.h' file not found, while using `clazy-standalone`
Be sure the clazy-standalone binary is located in the same folder as the clang binary.
- Be sure to disable pch.
- macOS: Be sure you're not using Apple Clang
- macOS: System Integrity Protection blocks the use of DYLD_LIBRARY_PATH. With SIP enabled you need to pass the full path
to ClazyPlugin.dylib, otherwise you'll get `image not found` error.
- Windows: fatal error LNK1112: module machine type ‘X86’ conflicts with target machine type ‘x64’
If you're building in 32-bit, open clazy-cl.bat and insert a -m32 argument.
Should read: %~dp0\clang\clang.exe –driver-mode=cl -m32 (...)
# Reducing warning noise
If you think you found a false-positive, file a bug report. But do make sure to test first without icecc/distcc enabled.
If you want to suppress warnings from headers of Qt or 3rd party code, include them with `-isystem` instead of `-I` (gcc/clang only).
For MSVC use `/external`, which is available since VS 15.6.
Alternatively you can set the CLAZY_HEADER_FILTER env variable to a regexp matching the path where you want warnings,
for example `CLAZY_HEADER_FILTER=.*myapplication.*`.
You can also exclude paths using a regexp by setting CLAZY_IGNORE_DIRS, for example `CLAZY_IGNORE_DIRS=.*my_qt_folder.*`.
You can also suppress individual warnings by file or by line by inserting comments:
- To disable clazy in a specific source file, insert this comment, anywhere in the file:
`// clazy:skip`
- To disable specific checks in a source file, insert a comment such as
`// clazy:excludeall=check1,check2`
- To disable specific checks in specific source lines, insert a comment in the same line as the warning:
`(...) // clazy:exclude=check1,check2`
- To disable specific checks in source files for the following line, insert a comment:
`// clazy:exclude=check1,check2`
Don't include the `clazy-` prefix. If, for example, you want to disable qstring-allocations you would write:
`// clazy:exclude=qstring-allocations` not `clazy-qstring-allocations`.
# Reporting bugs and wishes
- bug tracker: <https://bugs.kde.org/enter_bug.cgi?product=clazy>
- GitLab issues: https://invent.kde.org/sdk/clazy/-/issues
When reporting a bug _please_ include a minimal compilable testcase. No matter
how simple it is, it saves me time from deciphering a bug report. Time spent
doing triaging is time not spent writing fixes.
A minimal testcase is also something I can copy to the test suite.
Make sure you can reproduce with clazy (outside of QtCreator), otherwise it can be a QtCreator bug instead,
which you can report at <https://bugreports.qt.io/>.
# Authors
- Sérgio Martins
with contributions from:
- Allen Winter
- Kevin Funk
- Mathias Hasselmann
- Laurent Montel
- Albert Astals Cid
- Aurélien Gâteau
- Hannah von Reth
- Volker Krause
- Christian Ehrlicher
- Christian Gagneraud
- Nikolai Kosjar
- Jesper K. Pedersen
- Lucie Gerard
- Christian Schärf
- Waqar Ahmed
- Alexander Lohnau
qt6-\* porting checks written by Lucie Gerard <lucie.gerard@qt.io>
and thanks to:
- Klarälvdalens Datakonsult AB (<http://www.kdab.com>), for letting me work on clazy as a research project
# Contributing patches
New features go to master and bug fixes go to the last 1.X branch.
Please contribute by using KDE's GitLab instance, see <https://community.kde.org/Infrastructure/GitLab>.
|