1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838
|
/*
* Copyright 2008 The Closure Compiler Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.javascript.jscomp;
import static com.google.javascript.jscomp.CheckAccessControls.BAD_PRIVATE_GLOBAL_ACCESS;
import static com.google.javascript.jscomp.CheckAccessControls.BAD_PRIVATE_PROPERTY_ACCESS;
import static com.google.javascript.jscomp.CheckAccessControls.BAD_PROTECTED_PROPERTY_ACCESS;
import static com.google.javascript.jscomp.CheckAccessControls.CONST_PROPERTY_DELETED;
import static com.google.javascript.jscomp.CheckAccessControls.CONST_PROPERTY_REASSIGNED_VALUE;
import static com.google.javascript.jscomp.CheckAccessControls.DEPRECATED_CLASS;
import static com.google.javascript.jscomp.CheckAccessControls.DEPRECATED_CLASS_REASON;
import static com.google.javascript.jscomp.CheckAccessControls.DEPRECATED_NAME;
import static com.google.javascript.jscomp.CheckAccessControls.DEPRECATED_NAME_REASON;
import static com.google.javascript.jscomp.CheckAccessControls.DEPRECATED_PROP;
import static com.google.javascript.jscomp.CheckAccessControls.DEPRECATED_PROP_REASON;
import static com.google.javascript.jscomp.CheckAccessControls.EXTEND_FINAL_CLASS;
import static com.google.javascript.jscomp.CheckAccessControls.PRIVATE_OVERRIDE;
import static com.google.javascript.jscomp.CheckAccessControls.VISIBILITY_MISMATCH;
/**
* Tests for {@link CheckAccessControls}.
*
* @author nicksantos@google.com (Nick Santos)
*/
public class CheckAccessControlsTest extends CompilerTestCase {
public CheckAccessControlsTest() {
super(CompilerTypeTestCase.DEFAULT_EXTERNS);
parseTypeInfo = true;
enableTypeCheck(CheckLevel.WARNING);
}
@Override
protected CompilerPass getProcessor(final Compiler compiler) {
return new CheckAccessControls(compiler);
}
@Override
protected CompilerOptions getOptions() {
CompilerOptions options = super.getOptions();
options.setWarningLevel(DiagnosticGroups.ACCESS_CONTROLS, CheckLevel.ERROR);
options.setWarningLevel(DiagnosticGroups.CONSTANT_PROPERTY,
CheckLevel.ERROR);
return options;
}
/**
* Tests that the given JavaScript code has a @deprecated marker
* somewhere in it which raises an error. Also tests that the
* deprecated marker works with a message. The JavaScript should
* have a JsDoc of the form "@deprecated %s\n".
*
* @param js The JavaScript code to parse and test.
* @param reason A simple deprecation reason string, used for testing
* the addition of a deprecation reason to the @deprecated tag.
* @param error The deprecation error expected when no reason is given.
* @param errorWithMessage The deprecation error expected when a reason
* message is given.
*/
private void testDep(String js, String reason,
DiagnosticType error,
DiagnosticType errorWithMessage) {
// Test without a reason.
test(String.format(js, ""), null, error);
// Test with a reason.
test(String.format(js, reason), null, errorWithMessage, null, reason);
}
public void testDeprecatedFunction() {
testDep("/** @deprecated %s */ function f() {} function g() { f(); }",
"Some Reason",
DEPRECATED_NAME, DEPRECATED_NAME_REASON);
}
public void testWarningOnDeprecatedConstVariable() {
testDep("/** @deprecated %s */ var f = 4; function g() { alert(f); }",
"Another reason",
DEPRECATED_NAME, DEPRECATED_NAME_REASON);
}
public void testThatNumbersArentDeprecated() {
testSame("/** @deprecated */ var f = 4; var h = 3; " +
"function g() { alert(h); }");
}
public void testDeprecatedFunctionVariable() {
testDep("/** @deprecated %s */ var f = function() {}; " +
"function g() { f(); }", "I like g...",
DEPRECATED_NAME, DEPRECATED_NAME_REASON);
}
public void testNoWarningInGlobalScope() {
testSame("var goog = {}; goog.makeSingleton = function(x) {};" +
"/** @deprecated */ function f() {} goog.makeSingleton(f);");
}
public void testNoWarningInGlobalScopeForCall() {
testDep("/** @deprecated %s */ function f() {} f();",
"Some global scope", DEPRECATED_NAME, DEPRECATED_NAME_REASON);
}
public void testNoWarningInDeprecatedFunction() {
testSame("/** @deprecated */ function f() {} " +
"/** @deprecated */ function g() { f(); }");
}
public void testWarningInNormalClass() {
testDep("/** @deprecated %s */ function f() {}" +
"/** @constructor */ var Foo = function() {}; " +
"Foo.prototype.bar = function() { f(); }",
"FooBar", DEPRECATED_NAME, DEPRECATED_NAME_REASON);
}
public void testWarningForProperty1() {
testDep("/** @constructor */ function Foo() {}" +
"/** @deprecated %s */ Foo.prototype.bar = 3;" +
"Foo.prototype.baz = function() { alert((new Foo()).bar); };",
"A property is bad",
DEPRECATED_PROP, DEPRECATED_PROP_REASON);
}
public void testWarningForProperty2() {
testDep("/** @constructor */ function Foo() {}" +
"/** @deprecated %s */ Foo.prototype.bar = 3;" +
"Foo.prototype.baz = function() { alert(this.bar); };",
"Zee prop, it is deprecated!",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testWarningForDeprecatedClass() {
testDep("/** @constructor \n* @deprecated %s */ function Foo() {} " +
"function f() { new Foo(); }",
"Use the class 'Bar'",
DEPRECATED_CLASS,
DEPRECATED_CLASS_REASON);
}
public void testNoWarningForDeprecatedClassInstance() {
testSame("/** @constructor \n * @deprecated */ function Foo() {} " +
"/** @param {Foo} x */ function f(x) { return x; }");
}
public void testWarningForDeprecatedSuperClass() {
testDep("/** @constructor \n * @deprecated %s */ function Foo() {} " +
"/** @constructor \n * @extends {Foo} */ function SubFoo() {}" +
"function f() { new SubFoo(); }",
"Superclass to the rescue!",
DEPRECATED_CLASS,
DEPRECATED_CLASS_REASON);
}
public void testWarningForDeprecatedSuperClass2() {
testDep("/** @constructor \n * @deprecated %s */ function Foo() {} " +
"var namespace = {}; " +
"/** @constructor \n * @extends {Foo} */ " +
"namespace.SubFoo = function() {}; " +
"function f() { new namespace.SubFoo(); }",
"Its only weakness is Kryptoclass",
DEPRECATED_CLASS,
DEPRECATED_CLASS_REASON);
}
public void testWarningForPrototypeProperty() {
testDep("/** @constructor */ function Foo() {}" +
"/** @deprecated %s */ Foo.prototype.bar = 3;" +
"Foo.prototype.baz = function() { alert(Foo.prototype.bar); };",
"It is now in production, use that model...",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testNoWarningForNumbers() {
testSame("/** @constructor */ function Foo() {}" +
"/** @deprecated */ Foo.prototype.bar = 3;" +
"Foo.prototype.baz = function() { alert(3); };");
}
public void testWarningForMethod1() {
testDep("/** @constructor */ function Foo() {}" +
"/** @deprecated %s */ Foo.prototype.bar = function() {};" +
"Foo.prototype.baz = function() { this.bar(); };",
"There is a madness to this method",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testWarningForMethod2() {
testDep("/** @constructor */ function Foo() {} " +
"/** @deprecated %s */ Foo.prototype.bar; " +
"Foo.prototype.baz = function() { this.bar(); };",
"Stop the ringing!",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testNoWarningInDeprecatedClass() {
testSame("/** @deprecated */ function f() {} " +
"/** @constructor \n * @deprecated */ " +
"var Foo = function() {}; " +
"Foo.prototype.bar = function() { f(); }");
}
public void testNoWarningInDeprecatedClass2() {
testSame("/** @deprecated */ function f() {} " +
"/** @constructor \n * @deprecated */ " +
"var Foo = function() {}; " +
"Foo.bar = function() { f(); }");
}
public void testNoWarningInDeprecatedStaticMethod() {
testSame("/** @deprecated */ function f() {} " +
"/** @constructor */ " +
"var Foo = function() {}; " +
"/** @deprecated */ Foo.bar = function() { f(); }");
}
public void testWarningInStaticMethod() {
testDep("/** @deprecated %s */ function f() {} " +
"/** @constructor */ " +
"var Foo = function() {}; " +
"Foo.bar = function() { f(); }",
"crazy!",
DEPRECATED_NAME,
DEPRECATED_NAME_REASON);
}
public void testDeprecatedObjLitKey() {
testDep("var f = {}; /** @deprecated %s */ f.foo = 3; " +
"function g() { return f.foo; }",
"It is literally not used anymore",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testWarningForSubclassMethod() {
testDep("/** @constructor */ function Foo() {}" +
"Foo.prototype.bar = function() {};" +
"/** @constructor \n * @extends {Foo} */ function SubFoo() {}" +
"/** @deprecated %s */ SubFoo.prototype.bar = function() {};" +
"function f() { (new SubFoo()).bar(); };",
"I have a parent class!",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testWarningForSuperClassWithDeprecatedSubclassMethod() {
testSame("/** @constructor */ function Foo() {}" +
"Foo.prototype.bar = function() {};" +
"/** @constructor \n * @extends {Foo} */ function SubFoo() {}" +
"/** @deprecated \n * @override */ SubFoo.prototype.bar = " +
"function() {};" +
"function f() { (new Foo()).bar(); };");
}
public void testWarningForSuperclassMethod() {
testDep("/** @constructor */ function Foo() {}" +
"/** @deprecated %s */ Foo.prototype.bar = function() {};" +
"/** @constructor \n * @extends {Foo} */ function SubFoo() {}" +
"SubFoo.prototype.bar = function() {};" +
"function f() { (new SubFoo()).bar(); };",
"I have a child class!",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testWarningForSuperclassMethod2() {
testDep("/** @constructor */ function Foo() {}" +
"/** @deprecated %s \n* @protected */" +
"Foo.prototype.bar = function() {};" +
"/** @constructor \n * @extends {Foo} */ function SubFoo() {}" +
"/** @protected */SubFoo.prototype.bar = function() {};" +
"function f() { (new SubFoo()).bar(); };",
"I have another child class...",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testWarningForBind() {
testDep("/** @deprecated %s */ Function.prototype.bind = function() {};" +
"(function() {}).bind();",
"I'm bound to this method...",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testWarningForDeprecatedClassInGlobalScope() {
testDep("/** @constructor \n * @deprecated %s */ var Foo = function() {};" +
"new Foo();",
"I'm a very worldly object!",
DEPRECATED_CLASS,
DEPRECATED_CLASS_REASON);
}
public void testNoWarningForPrototypeCopying() {
testSame("/** @constructor */ var Foo = function() {};" +
"Foo.prototype.bar = function() {};" +
"/** @deprecated */ Foo.prototype.baz = Foo.prototype.bar;" +
"(new Foo()).bar();");
}
public void testNoWarningOnDeprecatedPrototype() {
// This used to cause an NPE.
testSame("/** @constructor */ var Foo = function() {};" +
"/** @deprecated */ Foo.prototype = {};" +
"Foo.prototype.bar = function() {};");
}
public void testPrivateAccessForNames() {
testSame("/** @private */ function foo_() {}; foo_();");
test(new String[] {
"/** @private */ function foo_() {};",
"foo_();"
}, null, BAD_PRIVATE_GLOBAL_ACCESS);
}
public void testPrivateAccessForProperties1() {
testSame("/** @constructor */ function Foo() {}" +
"/** @private */ Foo.prototype.bar_ = function() {};" +
"Foo.prototype.baz = function() { this.bar_(); }; (new Foo).bar_();");
}
public void testPrivateAccessForProperties2() {
testSame(new String[] {
"/** @constructor */ function Foo() {}",
"/** @private */ Foo.prototype.bar_ = function() {};" +
"Foo.prototype.baz = function() { this.bar_(); }; (new Foo).bar_();"
});
}
public void testPrivateAccessForProperties3() {
testSame(new String[] {
"/** @constructor */ function Foo() {}" +
"/** @private */ Foo.prototype.bar_ = function() {}; (new Foo).bar_();",
"Foo.prototype.baz = function() { this.bar_(); };"
});
}
public void testPrivateAccessForProperties4() {
testSame(new String[] {
"/** @constructor */ function Foo() {}" +
"/** @private */ Foo.prototype.bar_ = function() {};",
"Foo.prototype['baz'] = function() { (new Foo()).bar_(); };"
});
}
public void testNoPrivateAccessForProperties1() {
test(new String[] {
"/** @constructor */ function Foo() {} (new Foo).bar_();",
"/** @private */ Foo.prototype.bar_ = function() {};" +
"Foo.prototype.baz = function() { this.bar_(); };"
}, null, BAD_PRIVATE_PROPERTY_ACCESS);
}
public void testNoPrivateAccessForProperties2() {
test(new String[] {
"/** @constructor */ function Foo() {} " +
"/** @private */ Foo.prototype.bar_ = function() {};" +
"Foo.prototype.baz = function() { this.bar_(); };",
"(new Foo).bar_();"
}, null, BAD_PRIVATE_PROPERTY_ACCESS);
}
public void testNoPrivateAccessForProperties3() {
test(new String[] {
"/** @constructor */ function Foo() {} " +
"/** @private */ Foo.prototype.bar_ = function() {};",
"/** @constructor */ function OtherFoo() { (new Foo).bar_(); }"
}, null, BAD_PRIVATE_PROPERTY_ACCESS);
}
public void testNoPrivateAccessForProperties4() {
test(new String[] {
"/** @constructor */ function Foo() {} " +
"/** @private */ Foo.prototype.bar_ = function() {};",
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() { this.bar_(); }"
}, null, BAD_PRIVATE_PROPERTY_ACCESS);
}
public void testNoPrivateAccessForProperties5() {
test(new String[] {
"/** @constructor */ function Foo() {} " +
"/** @private */ Foo.prototype.bar_ = function() {};",
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() {};" +
"SubFoo.prototype.baz = function() { this.bar_(); }"
}, null, BAD_PRIVATE_PROPERTY_ACCESS);
}
public void testNoPrivateAccessForProperties6() {
// Overriding a private property with a non-private property
// in a different file causes problems.
test(new String[] {
"/** @constructor */ function Foo() {} " +
"/** @private */ Foo.prototype.bar_ = function() {};",
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() {};" +
"SubFoo.prototype.bar_ = function() {};"
}, null, BAD_PRIVATE_PROPERTY_ACCESS);
}
public void testNoPrivateAccessForProperties7() {
// It's OK to override a private property with a non-private property
// in the same file, but you'll get yelled at when you try to use it.
test(new String[] {
"/** @constructor */ function Foo() {} " +
"/** @private */ Foo.prototype.bar_ = function() {};" +
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() {};" +
"SubFoo.prototype.bar_ = function() {};",
"SubFoo.prototype.baz = function() { this.bar_(); }"
}, null, BAD_PRIVATE_PROPERTY_ACCESS);
}
public void testNoPrivateAccessForProperties8() {
test(new String[] {
"/** @constructor */ function Foo() { /** @private */ this.bar_ = 3; }",
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() { /** @private */ this.bar_ = 3; };"
}, null, PRIVATE_OVERRIDE);
}
public void testProtectedAccessForProperties1() {
testSame(new String[] {
"/** @constructor */ function Foo() {}" +
"/** @protected */ Foo.prototype.bar = function() {};" +
"(new Foo).bar();",
"Foo.prototype.baz = function() { this.bar(); };"
});
}
public void testProtectedAccessForProperties2() {
testSame(new String[] {
"/** @constructor */ function Foo() {}" +
"/** @protected */ Foo.prototype.bar = function() {};" +
"(new Foo).bar();",
"/** @constructor \n * @extends {Foo} */" +
"function SubFoo() { this.bar(); }"
});
}
public void testProtectedAccessForProperties3() {
testSame(new String[] {
"/** @constructor */ function Foo() {}" +
"/** @protected */ Foo.prototype.bar = function() {};" +
"(new Foo).bar();",
"/** @constructor \n * @extends {Foo} */" +
"function SubFoo() { }" +
"SubFoo.baz = function() { (new Foo).bar(); }"
});
}
public void testProtectedAccessForProperties4() {
testSame(new String[] {
"/** @constructor */ function Foo() {}" +
"/** @protected */ Foo.bar = function() {};",
"/** @constructor \n * @extends {Foo} */" +
"function SubFoo() { Foo.bar(); }"
});
}
public void testProtectedAccessForProperties5() {
testSame(new String[] {
"/** @constructor */ function Foo() {}" +
"/** @protected */ Foo.prototype.bar = function() {};" +
"(new Foo).bar();",
"/** @constructor \n * @extends {Foo} */" +
"var SubFoo = function() { this.bar(); }"
});
}
public void testProtectedAccessForProperties6() {
testSame(new String[] {
"var goog = {};" +
"/** @constructor */ goog.Foo = function() {};" +
"/** @protected */ goog.Foo.prototype.bar = function() {};",
"/** @constructor \n * @extends {goog.Foo} */" +
"goog.SubFoo = function() { this.bar(); };"
});
}
public void testNoProtectedAccessForProperties1() {
test(new String[] {
"/** @constructor */ function Foo() {} " +
"/** @protected */ Foo.prototype.bar = function() {};",
"(new Foo).bar();"
}, null, BAD_PROTECTED_PROPERTY_ACCESS);
}
public void testNoProtectedAccessForProperties2() {
test(new String[] {
"/** @constructor */ function Foo() {} " +
"/** @protected */ Foo.prototype.bar = function() {};",
"/** @constructor */ function OtherFoo() { (new Foo).bar(); }"
}, null, BAD_PROTECTED_PROPERTY_ACCESS);
}
public void testNoProtectedAccessForProperties3() {
test(new String[] {
"/** @constructor */ function Foo() {} " +
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() {}" +
"/** @protected */ SubFoo.prototype.bar = function() {};",
"/** @constructor \n * @extends {Foo} */ " +
"function SubberFoo() { (new SubFoo).bar(); }"
}, null, BAD_PROTECTED_PROPERTY_ACCESS);
}
public void testNoProtectedAccessForProperties4() {
test(new String[] {
"/** @constructor */ function Foo() { (new SubFoo).bar(); } ",
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() {}" +
"/** @protected */ SubFoo.prototype.bar = function() {};",
}, null, BAD_PROTECTED_PROPERTY_ACCESS);
}
public void testNoProtectedAccessForProperties5() {
test(new String[] {
"var goog = {};" +
"/** @constructor */ goog.Foo = function() {};" +
"/** @protected */ goog.Foo.prototype.bar = function() {};",
"/** @constructor */" +
"goog.NotASubFoo = function() { (new goog.Foo).bar(); };"
}, null, BAD_PROTECTED_PROPERTY_ACCESS);
}
public void testNoExceptionsWithBadConstructors1() {
testSame(new String[] {
"function Foo() { (new SubFoo).bar(); } " +
"/** @constructor */ function SubFoo() {}" +
"/** @protected */ SubFoo.prototype.bar = function() {};"
});
}
public void testNoExceptionsWithBadConstructors2() {
testSame(new String[] {
"/** @constructor */ function Foo() {} " +
"Foo.prototype.bar = function() {};" +
"/** @constructor */" +
"function SubFoo() {}" +
"/** @protected */ " +
"SubFoo.prototype.bar = function() { (new Foo).bar(); };"
});
}
public void testGoodOverrideOfProtectedProperty() {
testSame(new String[] {
"/** @constructor */ function Foo() { } " +
"/** @protected */ Foo.prototype.bar = function() {};",
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() {}" +
"/** @inheritDoc */ SubFoo.prototype.bar = function() {};",
});
}
public void testBadOverrideOfProtectedProperty() {
test(new String[] {
"/** @constructor */ function Foo() { } " +
"/** @protected */ Foo.prototype.bar = function() {};",
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() {}" +
"/** @private */ SubFoo.prototype.bar = function() {};",
}, null, VISIBILITY_MISMATCH);
}
public void testBadOverrideOfPrivateProperty() {
test(new String[] {
"/** @constructor */ function Foo() { } " +
"/** @private */ Foo.prototype.bar = function() {};",
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() {}" +
"/** @protected */ SubFoo.prototype.bar = function() {};",
}, null, PRIVATE_OVERRIDE);
testSame(new String[] {
"/** @constructor */ function Foo() { } " +
"/** @private */ Foo.prototype.bar = function() {};",
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() {}" +
"/** @override \n *@suppress{visibility} */\n" +
" SubFoo.prototype.bar = function() {};",
});
}
public void testAccessOfStaticMethodOnPrivateConstructor() {
testSame(new String[] {
"/** @constructor \n * @private */ function Foo() { } " +
"Foo.create = function() { return new Foo(); };",
"Foo.create()",
});
}
public void testAccessOfStaticMethodOnPrivateQualifiedConstructor() {
testSame(new String[] {
"var goog = {};" +
"/** @constructor \n * @private */ goog.Foo = function() { }; " +
"goog.Foo.create = function() { return new goog.Foo(); };",
"goog.Foo.create()",
});
}
public void testInstanceofOfPrivateConstructor() {
testSame(new String[] {
"var goog = {};" +
"/** @constructor \n * @private */ goog.Foo = function() { }; " +
"goog.Foo.create = function() { return new goog.Foo(); };",
"goog instanceof goog.Foo",
});
}
public void testOkAssignmentOfDeprecatedProperty() {
testSame(
"/** @constructor */ function Foo() {" +
" /** @deprecated */ this.bar = 3;" +
"}");
}
public void testBadReadOfDeprecatedProperty() {
testDep(
"/** @constructor */ function Foo() {" +
" /** @deprecated %s */ this.bar = 3;" +
" this.baz = this.bar;" +
"}",
"GRR",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testAutoboxedDeprecatedProperty() {
test(
"", // no externs
"/** @constructor */ function String() {}" +
"/** @deprecated %s */ String.prototype.length;" +
"function f() { return 'x'.length; }",
"GRR",
DEPRECATED_PROP_REASON,
null);
}
public void testAutoboxedPrivateProperty() {
test(
"/** @constructor */ function String() {}" +
"/** @private */ String.prototype.length;", // externs
"function f() { return 'x'.length; }",
"", // output
BAD_PRIVATE_PROPERTY_ACCESS,
null);
}
public void testNullableDeprecatedProperty() {
testDep(
"/** @constructor */ function Foo() {}" +
"/** @deprecated %s */ Foo.prototype.length;" +
"/** @param {?Foo} x */ function f(x) { return x.length; }",
"GRR",
DEPRECATED_PROP,
DEPRECATED_PROP_REASON);
}
public void testNullablePrivateProperty() {
test(new String[] {
"/** @constructor */ function Foo() {}" +
"/** @private */ Foo.prototype.length;",
"/** @param {?Foo} x */ function f(x) { return x.length; }"
}, null, BAD_PRIVATE_PROPERTY_ACCESS);
}
public void testConstantProperty1() {
test("/** @constructor */ function A() {" +
"/** @const */ this.bar = 3;}" +
"/** @constructor */ function B() {" +
"/** @const */ this.bar = 3;this.bar += 4;}",
null, CONST_PROPERTY_REASSIGNED_VALUE);
}
public void testConstantProperty2() {
test("/** @constructor */ function Foo() {}" +
"/** @const */ Foo.prototype.prop = 2;" +
"var foo = new Foo();" +
"foo.prop = 3;",
null , CONST_PROPERTY_REASSIGNED_VALUE);
}
public void testConstantProperty3() {
testSame("var o = { /** @const */ x: 1 };" +
"o.x = 2;");
}
public void testConstantProperty4() {
test("/** @constructor */ function cat(name) {}" +
"/** @const */ cat.test = 1;" +
"cat.test *= 2;",
null, CONST_PROPERTY_REASSIGNED_VALUE);
}
public void testConstantProperty5() {
test("/** @constructor */ function Foo() { this.prop = 1;}" +
"/** @const */ Foo.prototype.prop;" +
"Foo.prototype.prop = 2",
null , CONST_PROPERTY_REASSIGNED_VALUE);
}
public void testConstantProperty6() {
test("/** @constructor */ function Foo() { this.prop = 1;}" +
"/** @const */ Foo.prototype.prop = 2;",
null , CONST_PROPERTY_REASSIGNED_VALUE);
}
public void testConstantProperty7() {
testSame("/** @constructor */ function Foo() {} " +
"Foo.prototype.bar_ = function() {};" +
"/** @constructor \n * @extends {Foo} */ " +
"function SubFoo() {};" +
"/** @const */ /** @override */ SubFoo.prototype.bar_ = function() {};" +
"SubFoo.prototype.baz = function() { this.bar_(); }");
}
public void testConstantProperty8() {
testSame("var o = { /** @const */ x: 1 };" +
"var y = o.x;");
}
public void testConstantProperty9() {
testSame("/** @constructor */ function A() {" +
"/** @const */ this.bar = 3;}" +
"/** @constructor */ function B() {" +
"this.bar = 4;}");
}
public void testConstantProperty10() {
testSame("/** @constructor */ function Foo() { this.prop = 1;}" +
"/** @const */ Foo.prototype.prop;");
}
public void testConstantProperty11() {
test("/** @constructor */ function Foo() {}" +
"/** @const */ Foo.prototype.bar;" +
"/**\n" +
" * @constructor\n" +
" * @extends {Foo}\n" +
" */ function SubFoo() { this.bar = 5; this.bar = 6; }",
null , CONST_PROPERTY_REASSIGNED_VALUE);
}
public void testConstantProperty12() {
testSame("/** @constructor */ function Foo() {}" +
"/** @const */ Foo.prototype.bar;" +
"/**\n" +
" * @constructor\n" +
" * @extends {Foo}\n" +
" */ function SubFoo() { this.bar = 5; }" +
"/**\n" +
" * @constructor\n" +
" * @extends {Foo}\n" +
" */ function SubFoo2() { this.bar = 5; }");
}
public void testConstantProperty13() {
test("/** @constructor */ function Foo() {}" +
"/** @const */ Foo.prototype.bar;" +
"/**\n" +
" * @constructor\n" +
" * @extends {Foo}\n" +
" */ function SubFoo() { this.bar = 5; }" +
"/**\n" +
" * @constructor\n" +
" * @extends {SubFoo}\n" +
" */ function SubSubFoo() { this.bar = 5; }",
null , CONST_PROPERTY_REASSIGNED_VALUE);
}
public void testConstantProperty14() {
test("/** @constructor */ function Foo() {" +
"/** @const */ this.bar = 3; delete this.bar; }",
null, CONST_PROPERTY_DELETED);
}
public void testSuppressConstantProperty() {
testSame("/** @constructor */ function A() {" +
"/** @const */ this.bar = 3;}" +
"/**\n" +
" * @suppress {constantProperty}\n" +
" * @constructor\n" +
" */ function B() {" +
"/** @const */ this.bar = 3;this.bar += 4;}");
}
public void testSuppressConstantProperty2() {
testSame("/** @constructor */ function A() {" +
"/** @const */ this.bar = 3;}" +
"/**\n" +
" * @suppress {const}\n" +
" * @constructor\n" +
" */ function B() {" +
"/** @const */ this.bar = 3;this.bar += 4;}");
}
public void testFinalClassCannotBeSubclassed() {
test(
"/**\n"
+ " * @constructor\n"
+ " * @const\n"
+ " */ Foo = function() {};\n"
+ "/**\n"
+ " * @constructor\n"
+ " * @extends {Foo}\n*"
+ " */ Bar = function() {};",
null, EXTEND_FINAL_CLASS);
test(
"/**\n"
+ " * @constructor\n"
+ " * @const\n"
+ " */ function Foo() {};\n"
+ "/**\n"
+ " * @constructor\n"
+ " * @extends {Foo}\n*"
+ " */ function Bar() {};",
null, EXTEND_FINAL_CLASS);
}
}
|