1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336
|
/*
* Copyright 2008 The Closure Compiler Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.javascript.jscomp;
import com.google.common.base.Predicate;
import com.google.common.base.Predicates;
import com.google.javascript.jscomp.graph.LinkedDirectedGraph;
import com.google.javascript.jscomp.graph.DiGraph;
import com.google.javascript.jscomp.graph.DiGraph.DiGraphEdge;
import junit.framework.TestCase;
/**
* Tests for {@link CheckPathsBetweenNodes}.
*
*/
public class CheckPathsBetweenNodesTest extends TestCase {
/**
* Predicate satisfied by strings with a given prefix.
*/
private static class PrefixPredicate implements Predicate<String> {
String prefix;
PrefixPredicate(String prefix) {
this.prefix = prefix;
}
@Override
public boolean apply(String input) {
return input.startsWith(prefix);
}
}
private static final Predicate<String> FALSE = Predicates.alwaysFalse();
private static final Predicate<DiGraphEdge<String, String>> ALL_EDGE =
Predicates.alwaysTrue();
private static final Predicate<DiGraphEdge<String, String>> NO_EDGE =
Predicates.alwaysFalse();
/** Tests straight-line graphs. */
public void testSimple() {
DiGraph<String, String> g = LinkedDirectedGraph.create();
g.createDirectedGraphNode("a");
g.createDirectedGraphNode("b");
g.createDirectedGraphNode("c");
g.createDirectedGraphNode("d");
g.connect("a", "-", "b");
g.connect("b", "-", "c");
g.connect("c", "-", "d");
g.connect("a", "x", "d");
// Simple case: the sole path from a to d has a matching node.
assertGood(createTest(g, "a", "d", Predicates.equalTo("b"), edgeIs("-")));
//Test two edge cases where satisfying node is the first and last node on
// the path.
assertGood(createTest(g, "a", "d", Predicates.equalTo("a"), edgeIs("-")));
assertGood(createTest(g, "a", "d", Predicates.equalTo("d"), edgeIs("-")));
// Traverse no edges, so no paths.
assertGood(createTest(g, "a", "d", FALSE, NO_EDGE));
// No path with matching edges contains b.
assertBad(createTest(g, "a", "d", Predicates.equalTo("b"), edgeIs("x")));
}
/**
* Tests a graph where some paths between the nodes are valid and others
* are invalid.
*/
public void testSomeValidPaths() {
DiGraph<String, String> g = LinkedDirectedGraph.create();
g.createDirectedGraphNode("a");
g.createDirectedGraphNode("b");
g.createDirectedGraphNode("c");
g.createDirectedGraphNode("d");
g.createDirectedGraphNode("e");
g.connect("a", "1", "b");
g.connect("b", "2", "c");
g.connect("b", "3", "e");
g.connect("e", "4", "d");
g.connect("c", "5", "d");
assertBad(createTest(g, "a", "d", Predicates.equalTo("c"), ALL_EDGE));
assertBad(createTest(g, "a", "d", Predicates.equalTo("z"), ALL_EDGE));
}
/** Tests a graph with many valid paths. */
public void testManyValidPaths() {
DiGraph<String, String> g = LinkedDirectedGraph.create();
g.createDirectedGraphNode("a");
g.createDirectedGraphNode("b");
g.createDirectedGraphNode("c1");
g.createDirectedGraphNode("c2");
g.createDirectedGraphNode("c3");
g.createDirectedGraphNode("d");
g.connect("a", "-", "b");
g.connect("b", "-", "c1");
g.connect("b", "-", "c2");
g.connect("c2", "-", "d");
g.connect("c1", "-", "d");
g.connect("a", "-", "c3");
g.connect("c3", "-", "d");
assertGood(createTest(g, "a", "d", new PrefixPredicate("c"), ALL_EDGE));
}
/** Tests a graph with some cycles. */
public void testCycles1() {
DiGraph<String, String> g = LinkedDirectedGraph.create();
g.createDirectedGraphNode("a");
g.createDirectedGraphNode("b");
g.createDirectedGraphNode("c");
g.createDirectedGraphNode("d");
g.createDirectedGraphNode("e");
g.createDirectedGraphNode("f");
g.connect("a", "-", "b");
g.connect("b", "-", "c");
g.connect("c", "-", "d");
g.connect("d", "-", "e");
g.connect("e", "-", "f");
g.connect("f", "-", "b");
assertGood(createTest(g, "a", "e", Predicates.equalTo("b"), ALL_EDGE));
assertGood(createTest(g, "a", "e", Predicates.equalTo("c"), ALL_EDGE));
assertGood(createTest(g, "a", "e", Predicates.equalTo("d"), ALL_EDGE));
assertGood(createTest(g, "a", "e", Predicates.equalTo("e"), ALL_EDGE));
assertBad(createTest(g, "a", "e", Predicates.equalTo("f"), ALL_EDGE));
}
/**
* Tests another graph with cycles. The topology of this graph was inspired
* by a control flow graph that was being incorrectly analyzed by an early
* version of CheckPathsBetweenNodes.
*/
public void testCycles2() {
DiGraph<String, String> g = LinkedDirectedGraph.create();
g.createDirectedGraphNode("a");
g.createDirectedGraphNode("b");
g.createDirectedGraphNode("c");
g.createDirectedGraphNode("d");
g.connect("a", "-", "b");
g.connect("b", "-", "c");
g.connect("c", "-", "b");
g.connect("b", "-", "d");
assertGood(createTest(g, "a", "d", Predicates.equalTo("a"), ALL_EDGE));
assertBad(createTest(g, "a", "d", Predicates.equalTo("z"), ALL_EDGE));
}
/**
* Tests another graph with cycles. The topology of this graph was inspired
* by a control flow graph that was being incorrectly analyzed by an early
* version of CheckPathsBetweenNodes.
*/
public void testCycles3() {
DiGraph<String, String> g = LinkedDirectedGraph.create();
g.createDirectedGraphNode("a");
g.createDirectedGraphNode("b");
g.createDirectedGraphNode("c");
g.createDirectedGraphNode("d");
g.connect("a", "-", "b");
g.connect("b", "-", "c");
g.connect("c", "-", "b");
g.connect("b", "-", "d");
g.connect("c", "-", "d");
assertGood(createTest(g, "a", "d", Predicates.equalTo("a"), ALL_EDGE));
assertBad(createTest(g, "a", "d", Predicates.equalTo("z"), ALL_EDGE));
}
/**
* Much of the tests are done by testing all paths. We quickly verified
* that some paths are indeed correct for the some path case.
*/
public void testSomePath1() {
DiGraph<String, String> g = LinkedDirectedGraph.create();
g.createDirectedGraphNode("a");
g.createDirectedGraphNode("b");
g.createDirectedGraphNode("c");
g.createDirectedGraphNode("d");
g.connect("a", "-", "b");
g.connect("a", "-", "c");
g.connect("b", "-", "d");
g.connect("c", "-", "d");
assertTrue(createTest(g, "a", "d", Predicates.equalTo("b"), ALL_EDGE)
.somePathsSatisfyPredicate());
assertTrue(createTest(g, "a", "d", Predicates.equalTo("c"), ALL_EDGE)
.somePathsSatisfyPredicate());
assertTrue(createTest(g, "a", "d", Predicates.equalTo("a"), ALL_EDGE)
.somePathsSatisfyPredicate());
assertTrue(createTest(g, "a", "d", Predicates.equalTo("d"), ALL_EDGE)
.somePathsSatisfyPredicate());
assertFalse(createTest(g, "a", "d", Predicates.equalTo("NONE"), ALL_EDGE)
.somePathsSatisfyPredicate());
}
public void testSomePath2() {
// No Paths between nodes, by definition, always false.
DiGraph<String, String> g = LinkedDirectedGraph.create();
g.createDirectedGraphNode("a");
g.createDirectedGraphNode("b");
assertFalse(createTest(g, "a", "b", Predicates.equalTo("b"), ALL_EDGE)
.somePathsSatisfyPredicate());
assertFalse(createTest(g, "a", "b", Predicates.equalTo("d"), ALL_EDGE)
.somePathsSatisfyPredicate());
assertTrue(createTest(g, "a", "b", Predicates.equalTo("a"), ALL_EDGE)
.somePathsSatisfyPredicate());
}
public void testSomePathRevisiting() {
DiGraph<String, String> g = LinkedDirectedGraph.create();
g.createDirectedGraphNode("1");
g.createDirectedGraphNode("2a");
g.createDirectedGraphNode("2b");
g.createDirectedGraphNode("3");
g.createDirectedGraphNode("4a");
g.createDirectedGraphNode("4b");
g.createDirectedGraphNode("5");
g.connect("1", "-", "2a");
g.connect("1", "-", "2b");
g.connect("2a", "-", "3");
g.connect("2b", "-", "3");
g.connect("3", "-", "4a");
g.connect("3", "-", "4b");
g.connect("4a", "-", "5");
g.connect("4b", "-", "5");
CountingPredicate<String> p =
new CountingPredicate<String>(Predicates.equalTo("4a"));
assertTrue(createTest(g, "1", "5", p, ALL_EDGE)
.somePathsSatisfyPredicate());
// Make sure we are not doing more traversals than we have to.
assertEquals(4, p.count);
}
public void testNonInclusive() {
// No Paths between nodes, by definition, always false.
DiGraph<String, String> g = LinkedDirectedGraph.create();
g.createDirectedGraphNode("a");
g.createDirectedGraphNode("b");
g.createDirectedGraphNode("c");
g.connect("a", "-", "b");
g.connect("b", "-", "c");
assertFalse(createNonInclusiveTest(g, "a", "b",
Predicates.equalTo("a"), ALL_EDGE).somePathsSatisfyPredicate());
assertFalse(createNonInclusiveTest(g, "a", "b",
Predicates.equalTo("b"), ALL_EDGE).somePathsSatisfyPredicate());
assertTrue(createNonInclusiveTest(g, "a", "c",
Predicates.equalTo("b"), ALL_EDGE).somePathsSatisfyPredicate());
}
private static <N, E> void assertGood(CheckPathsBetweenNodes<N, E> test) {
assertTrue(test.allPathsSatisfyPredicate());
}
private static <N, E> void assertBad(CheckPathsBetweenNodes<N, E> test) {
assertFalse(test.allPathsSatisfyPredicate());
}
private static CheckPathsBetweenNodes<String, String> createTest(
DiGraph<String, String> graph,
String entry,
String exit,
Predicate<String> nodePredicate,
Predicate<DiGraphEdge<String, String>> edgePredicate) {
return new CheckPathsBetweenNodes<String, String>(graph,
graph.getDirectedGraphNode(entry), graph.getDirectedGraphNode(exit),
nodePredicate, edgePredicate);
}
private static CheckPathsBetweenNodes<String, String>
createNonInclusiveTest(
DiGraph<String, String> graph,
String entry,
String exit,
Predicate<String> nodePredicate,
Predicate<DiGraphEdge<String, String>> edgePredicate) {
return new CheckPathsBetweenNodes<String, String>(graph,
graph.getDirectedGraphNode(entry), graph.getDirectedGraphNode(exit),
nodePredicate, edgePredicate, false);
}
private static Predicate<DiGraphEdge<String, String>>
edgeIs(final Object val) {
return new Predicate<DiGraphEdge<String, String>>() {
@Override
public boolean apply(DiGraphEdge<String, String> input) {
return input.getValue().equals(val);
}
};
}
private static class CountingPredicate<T> implements Predicate<T> {
private int count = 0;
private final Predicate<T> delegate;
private CountingPredicate(Predicate<T> delegate) {
this.delegate = delegate;
}
@Override
public boolean apply(T input) {
count ++;
return delegate.apply(input);
}
}
}
|