1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258
|
/*
* Copyright 2008 The Closure Compiler Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.javascript.jscomp;
import static com.google.javascript.jscomp.CheckRequiresForConstructors.MISSING_REQUIRE_WARNING;
import com.google.common.collect.ImmutableList;
import com.google.javascript.jscomp.CheckLevel;
import com.google.javascript.jscomp.Result;
/**
* Tests for {@link CheckRequiresForConstructors}.
*
*/
public class CheckRequiresForConstructorsTest extends CompilerTestCase {
@Override
protected CompilerPass getProcessor(Compiler compiler) {
return new CheckRequiresForConstructors(compiler, CheckLevel.WARNING);
}
public void testPassWithNoNewNodes() {
String js = "var str = 'g4'; /* does not use new */";
testSame(js);
}
public void testPassWithOneNew() {
String js =
"var goog = {};" +
"goog.require('foo.bar.goo'); var bar = new foo.bar.goo();";
testSame(js);
}
public void testPassWithOneNewOuterClass() {
String js =
"var goog = {};" +
"goog.require('goog.foo.Bar'); var bar = new goog.foo.Bar.Baz();";
testSame(js);
}
public void testPassWithOneNewOuterClassWithUpperPrefix() {
String js =
"var goog = {};" +
"goog.require('goog.foo.IDBar'); var bar = new goog.foo.IDBar.Baz();";
testSame(js);
}
public void testFailWithOneNew() {
String[] js = new String[] {"var foo = {}; var bar = new foo.bar();"};
String warning = "'foo.bar' used but not goog.require'd";
test(js, js, null, MISSING_REQUIRE_WARNING, warning);
}
public void testPassWithTwoNewNodes() {
String js =
"var goog = {};" +
"goog.require('goog.foo.Bar');goog.require('goog.foo.Baz');" +
"var str = new goog.foo.Bar('g4'), num = new goog.foo.Baz(5); ";
testSame(js);
}
public void testPassWithNestedNewNodes() {
String js =
"var goog = {}; goog.require('goog.foo.Bar'); " +
"var str = new goog.foo.Bar(new goog.foo.Bar('5')); ";
testSame(js);
}
public void testFailWithNestedNewNodes() {
String[] js =
new String[] {"var goog = {}; goog.require('goog.foo.Bar'); "
+ "var str = new goog.foo.Bar(new goog.foo.Baz('5')); "};
String warning = "'goog.foo.Baz' used but not goog.require'd";
test(js, js, null, MISSING_REQUIRE_WARNING, warning);
}
public void testPassWithLocalFunctions() {
String js =
"/** @constructor */ function tempCtor() {}; var foo = new tempCtor();";
testSame(js);
}
public void testPassWithLocalVariables() {
String js =
"/** @constructor */ var nodeCreator = function() {};"
+ "var newNode = new nodeCreator();";
testSame(js);
}
public void testFailWithLocalVariableInMoreThanOneFile() {
// there should be a warning for the 2nd script because it is only declared
// in the 1st script
String localVar =
"/** @constructor */ function tempCtor() {}" +
"function baz(){" + " /** @constructor */ function tempCtor() {}; "
+ "var foo = new tempCtor();}";
String[] js = new String[] {localVar, " var foo = new tempCtor();"};
String warning = "'tempCtor' used but not goog.require'd";
test(js, js, null, MISSING_REQUIRE_WARNING, warning);
}
public void testNewNodesMetaTraditionalFunctionForm() {
// the class in this script creates an instance of itself
// there should be no warning because the class should not have to
// goog.require itself .
String js =
"/** @constructor */ function Bar(){}; "
+ "Bar.prototype.bar = function(){ return new Bar();};";
testSame(js);
}
public void testNewNodesMeta() {
String js =
"var goog = {};" +
"/** @constructor */goog.ui.Option = function(){};"
+ "goog.ui.Option.optionDecorator = function(){"
+ " return new goog.ui.Option(); };";
testSame(js);
}
public void testShouldWarnWhenInstantiatingObjectsDefinedInGlobalScope() {
// there should be a warning for the 2nd script because
// Bar was declared in the 1st file, not the 2nd
String good =
"/** @constructor */ function Bar(){}; "
+ "Bar.prototype.bar = function(){return new Bar();};";
String bad = "/** @constructor */ function Foo(){ var bar = new Bar();}";
String[] js = new String[] {good, bad};
String warning = "'Bar' used but not goog.require'd";
test(js, js, null, MISSING_REQUIRE_WARNING, warning);
}
public void testShouldWarnWhenInstantiatingGlobalClassesFromGlobalScope() {
// there should be a warning for the 2nd script because Baz
// was declared in the first file, not the 2nd
String good =
"/** @constructor */ function Baz(){}; "
+ "Baz.prototype.bar = function(){return new Baz();};";
String bad = "var baz = new Baz()";
String[] js = new String[] {good, bad};
String warning = "'Baz' used but not goog.require'd";
test(js, js, null, MISSING_REQUIRE_WARNING, warning);
}
public void testIgnoresNativeObject() {
String externs = "/** @constructor */ function String(val) {}";
String js = "var str = new String('4');";
test(externs, js, js, null, null);
}
public void testNewNodesWithMoreThanOneFile() {
// Bar is created, and goog.require()ed, but in different files.
String[] js = new String[] {
"var goog = {};" +
"/** @constructor */ function Bar() {}" +
"goog.require('Bar');",
"var bar = new Bar();"};
String warning = "'Bar' used but not goog.require'd";
test(js, js, null, MISSING_REQUIRE_WARNING, warning);
}
public void testPassWithoutWarningsAndMultipleFiles() {
String[] js = new String[] {
"var goog = {};" +
"goog.require('Foo'); var foo = new Foo();",
"goog.require('Bar'); var bar = new Bar();"};
testSame(js);
}
public void testFailWithWarningsAndMultipleFiles() {
/* goog.require is in the code base, but not in the correct file */
String[] js = new String[] {
"var goog = {};" +
"/** @constructor */ function Bar() {}" +
"goog.require('Bar');",
"var bar = new Bar();"};
String warning = "'Bar' used but not goog.require'd";
test(js, js, null, MISSING_REQUIRE_WARNING, warning);
}
public void testCanStillCallNumberWithoutNewOperator() {
String externs = "/** @constructor */ function Number(opt_value) {}";
String js = "var n = Number('42');";
test(externs, js, js, null, null);
js = "var n = Number();";
test(externs, js, js, null, null);
}
public void testRequiresAreCaughtBeforeProcessed() {
String js = "var foo = {}; var bar = new foo.bar.goo();";
SourceFile input = SourceFile.fromCode("foo.js", js);
Compiler compiler = new Compiler();
CompilerOptions opts = new CompilerOptions();
opts.checkRequires = CheckLevel.WARNING;
opts.closurePass = true;
Result result = compiler.compile(ImmutableList.<SourceFile>of(),
ImmutableList.of(input), opts);
JSError[] warnings = result.warnings;
assertNotNull(warnings);
assertTrue(warnings.length > 0);
String expectation = "'foo.bar.goo' used but not goog.require'd";
for (JSError warning : warnings) {
if (expectation.equals(warning.description)) {
return;
}
}
fail("Could not find the following warning:" + expectation);
}
public void testNoWarningsForThisConstructor() {
String js =
"var goog = {};" +
"/** @constructor */goog.Foo = function() {};" +
"goog.Foo.bar = function() {" +
" return new this.constructor; " +
"};";
testSame(js);
}
public void testBug2062487() {
testSame(
"var goog = {};" +
"/** @constructor */goog.Foo = function() {" +
" /** @constructor */ this.x_ = function() {};" +
" this.y_ = new this.x_();" +
"};");
}
public void testIgnoreDuplicateWarningsForSingleClasses(){
// no use telling them the same thing twice
String[] js = new String[]{
"var goog = {};" +
"/** @constructor */goog.Foo = function() {};" +
"goog.Foo.bar = function(){" +
" var first = new goog.Forgot();" +
" var second = new goog.Forgot();" +
"};"};
String warning = "'goog.Forgot' used but not goog.require'd";
test(js, js, null, MISSING_REQUIRE_WARNING, warning);
}
}
|