File: CrossModuleCodeMotionTest.java

package info (click to toggle)
closure-compiler 20130227%2Bdfsg1-10.1
  • links: PTS, VCS
  • area: main
  • in suites: bullseye
  • size: 12,792 kB
  • sloc: java: 175,338; javascript: 20,728; xml: 371; makefile: 19; sh: 6
file content (780 lines) | stat: -rw-r--r-- 18,667 bytes parent folder | download | duplicates (6)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
/*
 * Copyright 2008 The Closure Compiler Authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.google.javascript.jscomp;

/**
 * Tests for {@link CrossModuleCodeMotion}.
 *
 */
public class CrossModuleCodeMotionTest extends CompilerTestCase {

  private static final String EXTERNS = "alert";

  public CrossModuleCodeMotionTest() {
    super(EXTERNS);
  }

  @Override
  public void setUp() {
    super.enableLineNumberCheck(true);
  }

  @Override
  public CompilerPass getProcessor(Compiler compiler) {
    return new CrossModuleCodeMotion(compiler, compiler.getModuleGraph());
  }

  public void testFunctionMovement1() {
    // This tests lots of things:
    // 1) f1 is declared in m1, and used in m2. Move it to m2
    // 2) f2 is declared in m1, and used in m3 twice. Move it to m3
    // 3) f3 is declared in m1, and used in m2+m3. It stays put
    // 4) g declared in m1 and never used. It stays put
    // 5) h declared in m2 and never used. It stays put
    // 6) f4 declared in m1 and used in m2 as var. It moves to m2

    JSModule[] modules = createModuleStar(
      // m1
      "function f1(a) { alert(a); }" +
      "function f2(a) { alert(a); }" +
      "function f3(a) { alert(a); }" +
      "function f4() { alert(1); }" +
      "function g() { alert('ciao'); }",
      // m2
      "f1('hi'); f3('bye'); var a = f4;" +
      "function h(a) { alert('h:' + a); }",
      // m3
      "f2('hi'); f2('hi'); f3('bye');");

    test(modules, new String[] {
      // m1
      "function f3(a) { alert(a); }" +
      "function g() { alert('ciao'); }",
      // m2
      "function f4() { alert(1); }" +
      "function f1(a) { alert(a); }" +
      "f1('hi'); f3('bye'); var a = f4;" +
      "function h(a) { alert('h:' + a); }",
      // m3
      "function f2(a) { alert(a); }" +
      "f2('hi'); f2('hi'); f3('bye');",
    });
  }

  public void testFunctionMovement2() {
    // having f declared as a local variable should block the migration to m2
    JSModule[] modules = createModuleStar(
      // m1
      "function f(a) { alert(a); }" +
      "function g() {var f = 1; f++}",
      // m2
      "f(1);");

    test(modules, new String[] {
      // m1
      "function g() {var f = 1; f++}",
      // m2
      "function f(a) { alert(a); }" +
      "f(1);",
    });
  }

  public void testFunctionMovement3() {
    // having f declared as a arg should block the migration to m2
    JSModule[] modules = createModuleStar(
      // m1
      "function f(a) { alert(a); }" +
      "function g(f) {f++}",
      // m2
      "f(1);");

    test(modules, new String[] {
      // m1
      "function g(f) {f++}",
      // m2
      "function f(a) { alert(a); }" +
      "f(1);",
    });
  }

  public void testFunctionMovement4() {
    // Try out moving a function which returns a closure
    JSModule[] modules = createModuleStar(
      // m1
      "function f(){return function(a){}}",
      // m2
      "var a = f();"
    );

    test(modules, new String[] {
      // m1
      "",
      // m2
      "function f(){return function(a){}}" +
      "var a = f();",
    });
  }

  public void testFunctionMovement5() {
    // Try moving a recursive function [using factorials for kicks]
    JSModule[] modules = createModuleStar(
      // m1
      "function f(n){return (n<1)?1:f(n-1)}",
      // m2
      "var a = f(4);"
    );

    test(modules, new String[] {
      // m1
      "",
      // m2
      "function f(n){return (n<1)?1:f(n-1)}" +
      "var a = f(4);",
    });
  }

  public void testFunctionMovement5b() {
    // Try moving a recursive function declared differently.
    JSModule[] modules = createModuleStar(
      // m1
      "var f = function(n){return (n<1)?1:f(n-1)};",
      // m2
      "var a = f(4);"
    );

    test(modules, new String[] {
      // m1
      "",
      // m2
      "var f = function(n){return (n<1)?1:f(n-1)};" +
      "var a = f(4);",
    });
  }

  public void testFunctionMovement6() {
    // Try out moving to the common ancestor
    JSModule[] modules = createModuleChain(
      // m1
      "function f(){return 1}",
      // m2
      "var a = f();",
      // m3
      "var b = f();"
    );

    test(modules, new String[] {
      // m1
      "",
      // m2
      "function f(){return 1}" +
      "var a = f();",
      // m3
      "var b = f();",
    });
  }

  public void testFunctionMovement7() {
    // Try out moving to the common ancestor with deeper ancestry chain
    JSModule[] modules = createModules(
      // m1
      "function f(){return 1}",
      // m2
      "",
      // m3
      "var a = f();",
      // m4
      "var b = f();",
      // m5
      "var c = f();"
    );


    modules[1].addDependency(modules[0]);
    modules[2].addDependency(modules[1]);
    modules[3].addDependency(modules[1]);
    modules[4].addDependency(modules[1]);

    test(modules, new String[] {
      // m1
      "",
      // m2
      "function f(){return 1}",
      // m3
      "var a = f();",
      // m4
      "var b = f();",
      // m5
      "var c = f();",
    });
  }

  public void testFunctionMovement8() {
    // Check what happens with named functions
    JSModule[] modules = createModuleChain(
      // m1
      "var v = function f(){return 1}",
      // m2
      "v();"
    );

    test(modules, new String[] {
      // m1
      "",
      // m2
      "var v = function f(){return 1};" +
      "v();",
    });
  }

  public void testFunctionNonMovement1() {
    // This tests lots of things:
    // 1) we can't move it if it is a class with non-const attributes accessed
    // 2) if it's in an if statement, we can't move it
    // 3) if it's in an while statement, we can't move it [with some extra
    // block elements]
    testSame(createModuleStar(
      // m1
      "function f(){};f.prototype.bar=new f;" +
      "if(a)function f2(){}" +
      "{{while(a)function f3(){}}}",
      // m2
      "var a = new f();f2();f3();"));
  }

  public void testFunctionNonMovement2() {
    // A generic case where 2 modules depend on the first one. But it's the
    // common ancestor, so we can't move.
    testSame(createModuleStar(
      // m1
      "function f(){return 1}",
      // m2
      "var a = f();",
      // m3
      "var b = f();"));
  }

  public void testClassMovement1() {
    test(createModuleStar(
             // m1
             "function f(){} f.prototype.bar=function (){};",
             // m2
             "var a = new f();"),
         new String[] {
           "",
           "function f(){} f.prototype.bar=function (){};" +
           "var a = new f();"
         });
  }

  public void testClassMovement2() {
    // NOTE: this is the result of two iterations
    test(createModuleChain(
             // m1
             "function f(){} f.prototype.bar=3; f.prototype.baz=5;",
             // m2
             "f.prototype.baq = 7;",
             // m3
             "f.prototype.baz = 9;",
             // m4
             "var a = new f();"),
         new String[] {
           // m1
           "",
           // m2
           "",
           // m3
           "function f(){} f.prototype.bar=3; f.prototype.baz=5;" +
           "f.prototype.baq = 7;" +
           "f.prototype.baz = 9;",
           // m4
           "var a = new f();"
         });
  }

  public void testClassMovement3() {
    // NOTE: this is the result of two iterations
    test(createModuleChain(
             // m1
             "var f = function() {}; f.prototype.bar=3; f.prototype.baz=5;",
             // m2
             "f = 7;",
             // m3
             "f = 9;",
             // m4
             "f = 11;"),
         new String[] {
           // m1
           "",
           // m2
           "",
           // m3
           "var f = function() {}; f.prototype.bar=3; f.prototype.baz=5;" +
           "f = 7;" +
           "f = 9;",
           // m4
           "f = 11;"
         });
  }

  public void testClassMovement4() {
    testSame(createModuleStar(
                 // m1
                 "function f(){} f.prototype.bar=3; f.prototype.baz=5;",
                 // m2
                 "f.prototype.baq = 7;",
                 // m3
                 "var a = new f();"));
  }

  public void testClassMovement5() {
    JSModule[] modules = createModules(
        // m1
        "function f(){} f.prototype.bar=3; f.prototype.baz=5;",
        // m2
        "",
        // m3
        "f.prototype.baq = 7;",
        // m4
        "var a = new f();");

    modules[1].addDependency(modules[0]);
    modules[2].addDependency(modules[1]);
    modules[3].addDependency(modules[1]);

    test(modules,
         new String[] {
           // m1
           "",
           // m2
           "function f(){} f.prototype.bar=3; f.prototype.baz=5;",
           // m3
           "f.prototype.baq = 7;",
           // m4 +
           "var a = new f();"
         });
  }

  public void testClassMovement6() {
    test(createModuleChain(
             // m1
             "function Foo(){} function Bar(){} goog.inherits(Bar, Foo);" +
             "new Foo();",
             // m2
             "new Bar();"),
         new String[] {
           // m1
           "function Foo(){} new Foo();",
           // m2
           "function Bar(){} goog.inherits(Bar, Foo); new Bar();"
         });
  }

  public void testClassMovement7() {
    testSame(createModuleChain(
                 // m1
                 "function Foo(){} function Bar(){} goog.inherits(Bar, Foo);" +
                 "new Bar();",
                 // m2
                 "new Foo();"));
  }

  public void testStubMethodMovement1() {
    test(createModuleChain(
             // m1
             "function Foo(){} " +
             "Foo.prototype.bar = JSCompiler_stubMethod(x);",
             // m2
             "new Foo();"),
        new String[] {
          // m1
          "",
          "function Foo(){} " +
          "Foo.prototype.bar = JSCompiler_stubMethod(x);" +
          "new Foo();"
        });
  }

  public void testStubMethodMovement2() {
    test(createModuleChain(
             // m1
             "function Foo(){} " +
             "Foo.prototype.bar = JSCompiler_unstubMethod(x);",
             // m2
             "new Foo();"),
        new String[] {
          // m1
          "",
          "function Foo(){} " +
          "Foo.prototype.bar = JSCompiler_unstubMethod(x);" +
          "new Foo();"
        });
  }

  public void testNoMoveSideEffectProperty() {
    testSame(createModuleChain(
                 // m1
                 "function Foo(){} " +
                 "Foo.prototype.bar = createSomething();",
                 // m2
                 "new Foo();"));
  }

  public void testAssignMovement() {
    test(createModuleChain(
             // m1
             "var f = 3;" +
             "f = 5;",
             // m2
             "var h = f;"),
        new String[] {
          // m1
          "",
          // m2
          "var f = 3;" +
          "f = 5;" +
          "var h = f;"
        });

    // don't move nested assigns
    testSame(createModuleChain(
                 // m1
                 "var f = 3;" +
                 "var g = f = 5;",
                 // m2
                 "var h = f;"));
  }

  public void testNoClassMovement2() {
    test(createModuleChain(
             // m1
             "var f = {};" +
             "f.h = 5;",
             // m2
             "var h = f;"),
        new String[] {
          // m1
          "",
          // m2
          "var f = {};" +
          "f.h = 5;" +
          "var h = f;"
        });

    // don't move nested getprop assigns
    testSame(createModuleChain(
                 // m1
                 "var f = {};" +
                 "var g = f.h = 5;",
                 // m2
                 "var h = f;"));
  }

  public void testLiteralMovement1() {
    test(createModuleChain(
             // m1
             "var f = {'hi': 'mom', 'bye': function() {}};",
             // m2
             "var h = f;"),
        new String[] {
          // m1
          "",
          // m2
          "var f = {'hi': 'mom', 'bye': function() {}};" +
          "var h = f;"
        });
  }

  public void testLiteralMovement2() {
    testSame(createModuleChain(
                 // m1
                 "var f = {'hi': 'mom', 'bye': goog.nullFunction};",
                 // m2
                 "var h = f;"));
  }

  public void testLiteralMovement3() {
    test(createModuleChain(
             // m1
             "var f = ['hi', function() {}];",
             // m2
             "var h = f;"),
        new String[] {
          // m1
          "",
          // m2
          "var f = ['hi', function() {}];" +
          "var h = f;"
        });
  }

  public void testLiteralMovement4() {
    testSame(createModuleChain(
                 // m1
                 "var f = ['hi', goog.nullFunction];",
                 // m2
                 "var h = f;"));
  }

  public void testVarMovement1() {
    // test moving a variable
    JSModule[] modules = createModuleStar(
      // m1
      "var a = 0;",
      // m2
      "var x = a;"
    );

    test(modules, new String[] {
      // m1
      "",
      // m2
      "var a = 0;" +
      "var x = a;",
    });
  }

  public void testVarMovement2() {
    // Test moving 1 variable out of the block
    JSModule[] modules = createModuleStar(
      // m1
      "var a = 0; var b = 1; var c = 2;",
      // m2
      "var x = b;"
    );

    test(modules, new String[] {
      // m1
      "var a = 0; var c = 2;",
      // m2
      "var b = 1;" +
      "var x = b;"
    });
  }

  public void testVarMovement3() {
    // Test moving all variables out of the block
    JSModule[] modules = createModuleStar(
      // m1
      "var a = 0; var b = 1;",
      // m2
      "var x = a + b;"
    );

    test(modules, new String[] {
      // m1
      "",
      // m2
      "var b = 1;" +
      "var a = 0;" +
      "var x = a + b;"
    });
  }


  public void testVarMovement4() {
    // Test moving a function
    JSModule[] modules = createModuleStar(
      // m1
      "var a = function(){alert(1)};",
      // m2
      "var x = a;"
    );

    test(modules, new String[] {
      // m1
      "",
      // m2
      "var a = function(){alert(1)};" +
      "var x = a;"
    });
  }


  public void testVarMovement5() {
    // Don't move a function outside of scope
    testSame(createModuleStar(
      // m1
      "var a = alert;",
      // m2
      "var x = a;"));
  }

  public void testVarMovement6() {
    // Test moving a var with no assigned value
    JSModule[] modules = createModuleStar(
      // m1
      "var a;",
      // m2
      "var x = a;"
    );

    test(modules, new String[] {
      // m1
      "",
      // m2
      "var a;" +
      "var x = a;"
    });
  }

  public void testVarMovement7() {
    // Don't move a variable higher in the dependency tree
    testSame(createModuleStar(
      // m1
      "function f() {g();}",
      // m2
      "function g(){};"));
  }

  public void testVarMovement8() {
    JSModule[] modules = createModuleBush(
      // m1
      "var a = 0;",
      // m2 -> m1
      "",
      // m3 -> m2
      "var x = a;",
      // m4 -> m2
      "var y = a;"
    );

    test(modules, new String[] {
      // m1
      "",
      // m2
      "var a = 0;",
      // m3
      "var x = a;",
      // m4
      "var y = a;"
    });
  }

  public void testVarMovement9() {
    JSModule[] modules = createModuleTree(
      // m1
      "var a = 0; var b = 1; var c = 3;",
      // m2 -> m1
      "",
      // m3 -> m1
      "",
      // m4 -> m2
      "a;",
      // m5 -> m2
      "a;c;",
      // m6 -> m3
      "b;",
      // m7 -> m4
      "b;c;"
    );

    test(modules, new String[] {
      // m1
      "var c = 3;",
      // m2
      "var a = 0;",
      // m3
      "var b = 1;",
      // m4
      "a;",
      // m5
      "a;c;",
      // m6
      "b;",
      // m7
      "b;c;"
    });
  }

  public void testClone1() {
    test(createModuleChain(
             // m1
             "function f(){} f.prototype.clone = function() { return new f };",
             // m2
             "var a = (new f).clone();"),
         new String[] {
           // m1
           "",
           "function f(){} f.prototype.clone = function() { return new f() };" +
           // m2
           "var a = (new f).clone();"
         });
  }

  public void testClone2() {
    test(createModuleChain(
             // m1
             "function f(){}" +
             "f.prototype.cloneFun = function() {" +
             "  return function() {new f}" +
             "};",
             // m2
             "var a = (new f).cloneFun();"),
         new String[] {
           // m1
           "",
           "function f(){}" +
           "f.prototype.cloneFun = function() {" +
           "  return function() {new f}" +
           "};" +
           // m2
           "var a = (new f).cloneFun();"
         });
  }

  public void testBug4118005() {
    testSame(createModuleChain(
             // m1
             "var m = 1;\n" +
             "(function () {\n" +
             " var x = 1;\n" +
             " m = function() { return x };\n" +
             "})();\n",
             // m2
             "m();"));
  }

  public void testEmptyModule() {
    // When the dest module is empty, it might try to move the code to the
    // one of the modules that the empty module depends on. In some cases
    // this might ended up to be the same module as the definition of the code.
    // When that happens, CrossModuleCodeMotion might report a code change
    // while nothing is moved. This should not be a problem if we know all
    // modules are non-empty.
    JSModule m1 = new JSModule("m1");
    m1.add(SourceFile.fromCode("m1", "function x() {}"));

    JSModule empty = new JSModule("empty");
    empty.addDependency(m1);

    JSModule m2 = new JSModule("m2");
    m2.add(SourceFile.fromCode("m2", "x()"));
    m2.addDependency(empty);

    JSModule m3 = new JSModule("m3");
    m3.add(SourceFile.fromCode("m3", "x()"));
    m3.addDependency(empty);

    test(new JSModule[] {m1,empty,m2,m3},
        new String[] {
          "",
          "function x() {}",
          "x()",
          "x()"
    });
  }
}