1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
/*
* Copyright 2009 The Closure Compiler Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.javascript.jscomp;
/**
* Unit tests for {@link OptimizeArgumentsArray}.
*
*/
public class OptimizeArgumentsArrayTest extends CompilerTestCase {
public OptimizeArgumentsArrayTest() {
/*
* arguments is a builtin variable of the javascript language and
* OptimizeArgumentsArray does not make any attempt to resolve it. However,
* I am leaving "var arguments" in the externs to emulate the current
* behavior we have for JS compilation where var arguments in defined in
* externs/es3.js as extern.
*/
super("var arguments, alert" /* Externs */);
}
@Override
public void setUp() {
super.enableLineNumberCheck(false);
}
@Override
protected CompilerPass getProcessor(Compiler compiler) {
return new OptimizeArgumentsArray(compiler, "p");
}
public void testSimple() {
test("function foo() { alert(arguments[0]); }",
"function foo(p0) { alert(p0); }");
}
public void testNoVarArgs() {
testSame("function f(a,b,c) { alert(a + b + c) }");
test("function f(a,b,c) { alert(arguments[0]) }",
"function f(a,b,c) { alert(a) }");
}
public void testMissingVarArgs() {
testSame("function f() { alert(arguments[x]) }");
}
public void testArgumentRefOnNamedParameter() {
test("function f(a,b) { alert(arguments[0]) }",
"function f(a,b) { alert(a) }");
}
public void testTwoVarArgs() {
test("function foo(a) { alert(arguments[1] + arguments[2]); }",
"function foo(a, p0, p1) { alert(p0 + p1); }");
}
public void testTwoFourArgsTwoUsed() {
test("function foo() { alert(arguments[0] + arguments[3]); }",
"function foo(p0, p1, p2, p3) { alert(p0 + p3); }");
}
public void testOneRequired() {
test("function foo(req0, var_args) { alert(req0 + arguments[1]); }",
"function foo(req0, var_args) { alert(req0 + var_args); }");
}
public void testTwoRequiredSixthVarArgReferenced() {
test("function foo(r0, r1, var_args) {alert(r0 + r1 + arguments[5]);}",
"function foo(r0, r1, var_args, p0, p1, p2) { alert(r0 + r1 + p2); }");
}
public void testTwoRequiredOneOptionalFifthVarArgReferenced() {
test("function foo(r0, r1, opt_1)"
+ " {alert(r0 + r1 + opt_1 + arguments[4]);}",
"function foo(r0, r1, opt_1, p0, p1)"
+ " {alert(r0 + r1 + opt_1 + p1); }");
}
public void testTwoRequiredTwoOptionalSixthVarArgReferenced() {
test("function foo(r0, r1, opt_1, opt_2)"
+ " {alert(r0 + r1 + opt_1 + opt_2 + arguments[5]);}",
"function foo(r0, r1, opt_1, opt_2, p0, p1)"
+ " {alert(r0 + r1 + opt_1 + opt_2 + p1); }");
}
public void testInnerFunctions() {
test("function f() { function b( ) { arguments[0] }}",
"function f() { function b(p0) { p0 }}");
test("function f( ) { function b() { } arguments[0] }",
"function f(p0) { function b() { } p0 }");
test("function f( ) { arguments[0]; function b( ) { arguments[0] }}",
"function f(p1) { p1; function b(p0) { p0 }}");
}
public void testInnerFunctionsWithNamedArgumentInInnerFunction() {
test("function f() { function b(x ) { arguments[1] }}",
"function f() { function b(x,p0) { p0 }}");
test("function f( ) { function b(x) { } arguments[0] }",
"function f(p0) { function b(x) { } p0 }");
test("function f( ) { arguments[0]; function b(x ) { arguments[1] }}",
"function f(p1) { p1; function b(x,p0) { p0 }}");
}
public void testInnerFunctionsWithNamedArgumentInOutterFunction() {
test("function f(x) { function b( ) { arguments[0] }}",
"function f(x) { function b(p0) { p0 }}");
test("function f(x ) { function b() { } arguments[1] }",
"function f(x,p0) { function b() { } p0 }");
test("function f(x ) { arguments[1]; function b( ) { arguments[0] }}",
"function f(x,p1) { p1; function b(p0) { p0 }}");
}
public void testInnerFunctionsWithNamedArgumentInInnerAndOutterFunction() {
test("function f(x) { function b(x ) { arguments[1] }}",
"function f(x) { function b(x,p0) { p0 }}");
test("function f(x ) { function b(x) { } arguments[1] }",
"function f(x,p0) { function b(x) { } p0 }");
test("function f(x ) { arguments[1]; function b(x ) { arguments[1] }}",
"function f(x,p1) { p1; function b(x,p0) { p0 }}");
}
public void testInnerFunctionsAfterArguments() {
// This caused a bug earlier due to incorrect push and pop of the arguments
// access stack.
test("function f( ) { arguments[0]; function b() { function c() { }} }",
"function f(p0) { p0; function b() { function c() { }} }");
}
public void testNoOptimizationWhenGetProp() {
testSame("function f() { arguments[0]; arguments.size }");
}
public void testNoOptimizationWhenIndexIsNotNumberConstant() {
testSame("function f() { arguments[0]; arguments['callee'].length}");
testSame("function f() { arguments[0]; arguments.callee.length}");
testSame(
"function f() { arguments[0]; var x = 'callee'; arguments[x].length}");
}
public void testNoOptimizationWhenArgumentIsUsedAsFunctionCall() {
testSame("function f() {arguments[0]()}");
}
}
|
