1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859
|
/*
* Copyright 2006 The Closure Compiler Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.javascript.jscomp;
import com.google.javascript.rhino.Node;
import com.google.javascript.jscomp.CheckLevel;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.BASE_CLASS_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.DUPLICATE_NAMESPACE_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.EXPECTED_OBJECTLIT_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.FUNCTION_NAMESPACE_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.INVALID_ARGUMENT_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.INVALID_PROVIDE_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.INVALID_STYLE_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.LATE_PROVIDE_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.MISSING_PROVIDE_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.NON_STRING_PASSED_TO_SET_CSS_NAME_MAPPING_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.NULL_ARGUMENT_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.TOO_MANY_ARGUMENTS_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.XMODULE_REQUIRE_ERROR;
import static com.google.javascript.jscomp.ProcessClosurePrimitives.INVALID_CSS_RENAMING_MAP;
/**
* Tests for {@link ProcessClosurePrimitives}.
*
*/
public class ProcessClosurePrimitivesTest extends CompilerTestCase {
private String additionalCode;
private String additionalEndCode;
private boolean addAdditionalNamespace;
public ProcessClosurePrimitivesTest() {
enableLineNumberCheck(true);
}
@Override protected void setUp() {
additionalCode = null;
additionalEndCode = null;
addAdditionalNamespace = false;
}
@Override public CompilerPass getProcessor(final Compiler compiler) {
if ((additionalCode == null) && (additionalEndCode == null)) {
return new ProcessClosurePrimitives(
compiler, null, CheckLevel.ERROR);
} else {
return new CompilerPass() {
@Override
public void process(Node externs, Node root) {
// Process the original code.
new ProcessClosurePrimitives(compiler, null, CheckLevel.OFF)
.process(externs, root);
// Inject additional code at the beginning.
if (additionalCode != null) {
SourceFile file =
SourceFile.fromCode("additionalcode", additionalCode);
Node scriptNode = root.getFirstChild();
Node newScriptNode = new CompilerInput(file).getAstRoot(compiler);
if (addAdditionalNamespace) {
newScriptNode.getFirstChild()
.putBooleanProp(Node.IS_NAMESPACE, true);
}
while (newScriptNode.getLastChild() != null) {
Node lastChild = newScriptNode.getLastChild();
newScriptNode.removeChild(lastChild);
scriptNode.addChildBefore(lastChild, scriptNode.getFirstChild());
}
}
// Inject additional code at the end.
if (additionalEndCode != null) {
SourceFile file =
SourceFile.fromCode("additionalendcode", additionalEndCode);
Node scriptNode = root.getFirstChild();
Node newScriptNode = new CompilerInput(file).getAstRoot(compiler);
if (addAdditionalNamespace) {
newScriptNode.getFirstChild()
.putBooleanProp(Node.IS_NAMESPACE, true);
}
while (newScriptNode.getFirstChild() != null) {
Node firstChild = newScriptNode.getFirstChild();
newScriptNode.removeChild(firstChild);
scriptNode.addChildToBack(firstChild);
}
}
// Process the tree a second time.
new ProcessClosurePrimitives(compiler, null, CheckLevel.ERROR)
.process(externs, root);
}
};
}
}
@Override public int getNumRepetitions() {
return 1;
}
public void testSimpleProvides() {
test("goog.provide('foo');",
"var foo={};");
test("goog.provide('foo.bar');",
"var foo={}; foo.bar={};");
test("goog.provide('foo.bar.baz');",
"var foo={}; foo.bar={}; foo.bar.baz={};");
test("goog.provide('foo.bar.baz.boo');",
"var foo={}; foo.bar={}; foo.bar.baz={}; foo.bar.baz.boo={};");
test("goog.provide('goog.bar');",
"goog.bar={};"); // goog is special-cased
}
public void testMultipleProvides() {
test("goog.provide('foo.bar'); goog.provide('foo.baz');",
"var foo={}; foo.bar={}; foo.baz={};");
test("goog.provide('foo.bar.baz'); goog.provide('foo.boo.foo');",
"var foo={}; foo.bar={}; foo.bar.baz={}; foo.boo={}; foo.boo.foo={};");
test("goog.provide('foo.bar.baz'); goog.provide('foo.bar.boo');",
"var foo={}; foo.bar={}; foo.bar.baz={}; foo.bar.boo={};");
test("goog.provide('foo.bar.baz'); goog.provide('goog.bar.boo');",
"var foo={}; foo.bar={}; foo.bar.baz={}; goog.bar={}; " +
"goog.bar.boo={};");
}
public void testRemovalOfProvidedObjLit() {
test("goog.provide('foo'); foo = 0;",
"var foo = 0;");
test("goog.provide('foo'); foo = {a: 0};",
"var foo = {a: 0};");
test("goog.provide('foo'); foo = function(){};",
"var foo = function(){};");
test("goog.provide('foo'); var foo = 0;",
"var foo = 0;");
test("goog.provide('foo'); var foo = {a: 0};",
"var foo = {a: 0};");
test("goog.provide('foo'); var foo = function(){};",
"var foo = function(){};");
test("goog.provide('foo.bar.Baz'); foo.bar.Baz=function(){};",
"var foo={}; foo.bar={}; foo.bar.Baz=function(){};");
test("goog.provide('foo.bar.moo'); foo.bar.moo={E:1,S:2};",
"var foo={}; foo.bar={}; foo.bar.moo={E:1,S:2};");
test("goog.provide('foo.bar.moo'); foo.bar.moo={E:1}; foo.bar.moo={E:2};",
"var foo={}; foo.bar={}; foo.bar.moo={E:1}; foo.bar.moo={E:2};");
}
public void testProvidedDeclaredFunctionError() {
test("goog.provide('foo'); function foo(){}",
null, FUNCTION_NAMESPACE_ERROR);
}
public void testRemovalMultipleAssignment1() {
test("goog.provide('foo'); foo = 0; foo = 1",
"var foo = 0; foo = 1;");
}
public void testRemovalMultipleAssignment2() {
test("goog.provide('foo'); var foo = 0; foo = 1",
"var foo = 0; foo = 1;");
}
public void testRemovalMultipleAssignment3() {
test("goog.provide('foo'); foo = 0; var foo = 1",
"foo = 0; var foo = 1;");
}
public void testRemovalMultipleAssignment4() {
test("goog.provide('foo.bar'); foo.bar = 0; foo.bar = 1",
"var foo = {}; foo.bar = 0; foo.bar = 1");
}
public void testNoRemovalFunction1() {
test("goog.provide('foo'); function f(){foo = 0}",
"var foo = {}; function f(){foo = 0}");
}
public void testNoRemovalFunction2() {
test("goog.provide('foo'); function f(){var foo = 0}",
"var foo = {}; function f(){var foo = 0}");
}
public void testRemovalMultipleAssignmentInIf1() {
test("goog.provide('foo'); if (true) { var foo = 0 } else { foo = 1 }",
"if (true) { var foo = 0 } else { foo = 1 }");
}
public void testRemovalMultipleAssignmentInIf2() {
test("goog.provide('foo'); if (true) { foo = 0 } else { var foo = 1 }",
"if (true) { foo = 0 } else { var foo = 1 }");
}
public void testRemovalMultipleAssignmentInIf3() {
test("goog.provide('foo'); if (true) { foo = 0 } else { foo = 1 }",
"if (true) { var foo = 0 } else { foo = 1 }");
}
public void testRemovalMultipleAssignmentInIf4() {
test("goog.provide('foo.bar');" +
"if (true) { foo.bar = 0 } else { foo.bar = 1 }",
"var foo = {}; if (true) { foo.bar = 0 } else { foo.bar = 1 }");
}
public void testMultipleDeclarationError1() {
String rest = "if (true) { foo.bar = 0 } else { foo.bar = 1 }";
test("goog.provide('foo.bar');" + "var foo = {};" + rest,
"var foo = {};" + "var foo = {};" + rest);
}
public void testMultipleDeclarationError2() {
test("goog.provide('foo.bar');" +
"if (true) { var foo = {}; foo.bar = 0 } else { foo.bar = 1 }",
"var foo = {};" +
"if (true) {" +
" var foo = {}; foo.bar = 0" +
"} else {" +
" foo.bar = 1" +
"}");
}
public void testMultipleDeclarationError3() {
test("goog.provide('foo.bar');" +
"if (true) { foo.bar = 0 } else { var foo = {}; foo.bar = 1 }",
"var foo = {};" +
"if (true) {" +
" foo.bar = 0" +
"} else {" +
" var foo = {}; foo.bar = 1" +
"}");
}
public void testProvideAfterDeclarationError() {
test("var x = 42; goog.provide('x');",
"var x = 42; var x = {}");
}
public void testProvideErrorCases() {
test("goog.provide();", "", NULL_ARGUMENT_ERROR);
test("goog.provide(5);", "", INVALID_ARGUMENT_ERROR);
test("goog.provide([]);", "", INVALID_ARGUMENT_ERROR);
test("goog.provide({});", "", INVALID_ARGUMENT_ERROR);
test("goog.provide('foo', 'bar');", "", TOO_MANY_ARGUMENTS_ERROR);
test("goog.provide('foo'); goog.provide('foo');", "",
DUPLICATE_NAMESPACE_ERROR);
test("goog.provide('foo.bar'); goog.provide('foo'); goog.provide('foo');",
"", DUPLICATE_NAMESPACE_ERROR);
}
public void testRemovalOfRequires() {
test("goog.provide('foo'); goog.require('foo');",
"var foo={};");
test("goog.provide('foo.bar'); goog.require('foo.bar');",
"var foo={}; foo.bar={};");
test("goog.provide('foo.bar.baz'); goog.require('foo.bar.baz');",
"var foo={}; foo.bar={}; foo.bar.baz={};");
test("goog.provide('foo'); var x = 3; goog.require('foo'); something();",
"var foo={}; var x = 3; something();");
testSame("foo.require('foo.bar');");
}
public void testRequireErrorCases() {
test("goog.require();", "", NULL_ARGUMENT_ERROR);
test("goog.require(5);", "", INVALID_ARGUMENT_ERROR);
test("goog.require([]);", "", INVALID_ARGUMENT_ERROR);
test("goog.require({});", "", INVALID_ARGUMENT_ERROR);
}
public void testLateProvides() {
test("goog.require('foo'); goog.provide('foo');",
"var foo={};", LATE_PROVIDE_ERROR);
test("goog.require('foo.bar'); goog.provide('foo.bar');",
"var foo={}; foo.bar={};", LATE_PROVIDE_ERROR);
test("goog.provide('foo.bar'); goog.require('foo'); goog.provide('foo');",
"var foo={}; foo.bar={};", LATE_PROVIDE_ERROR);
}
public void testMissingProvides() {
test("goog.require('foo');",
"", MISSING_PROVIDE_ERROR);
test("goog.provide('foo'); goog.require('Foo');",
"var foo={};", MISSING_PROVIDE_ERROR);
test("goog.provide('foo'); goog.require('foo.bar');",
"var foo={};", MISSING_PROVIDE_ERROR);
test("goog.provide('foo'); var EXPERIMENT_FOO = true; " +
"if (EXPERIMENT_FOO) {goog.require('foo.bar');}",
"var foo={}; var EXPERIMENT_FOO = true; if (EXPERIMENT_FOO) {}",
MISSING_PROVIDE_ERROR);
}
public void testAddDependency() {
test("goog.addDependency('x.js', ['A', 'B'], []);", "0");
Compiler compiler = getLastCompiler();
assertTrue(compiler.getTypeRegistry().isForwardDeclaredType("A"));
assertTrue(compiler.getTypeRegistry().isForwardDeclaredType("B"));
assertFalse(compiler.getTypeRegistry().isForwardDeclaredType("C"));
}
public void testValidSetCssNameMapping() {
test("goog.setCssNameMapping({foo:'bar',\"biz\":'baz'});", "");
CssRenamingMap map = getLastCompiler().getCssRenamingMap();
assertNotNull(map);
assertEquals("bar", map.get("foo"));
assertEquals("baz", map.get("biz"));
}
public void testValidSetCssNameMappingWithType() {
test("goog.setCssNameMapping({foo:'bar',\"biz\":'baz'}, 'BY_PART');", "");
CssRenamingMap map = getLastCompiler().getCssRenamingMap();
assertNotNull(map);
assertEquals("bar", map.get("foo"));
assertEquals("baz", map.get("biz"));
test("goog.setCssNameMapping({foo:'bar',biz:'baz','biz-foo':'baz-bar'}," +
" 'BY_WHOLE');", "");
map = getLastCompiler().getCssRenamingMap();
assertNotNull(map);
assertEquals("bar", map.get("foo"));
assertEquals("baz", map.get("biz"));
assertEquals("baz-bar", map.get("biz-foo"));
}
public void testSetCssNameMappingNonStringValueReturnsError() {
// Make sure the argument is an object literal.
test("var BAR = {foo:'bar'}; goog.setCssNameMapping(BAR);", "",
EXPECTED_OBJECTLIT_ERROR);
test("goog.setCssNameMapping([]);", "",
EXPECTED_OBJECTLIT_ERROR);
test("goog.setCssNameMapping(false);", "",
EXPECTED_OBJECTLIT_ERROR);
test("goog.setCssNameMapping(null);", "",
EXPECTED_OBJECTLIT_ERROR);
test("goog.setCssNameMapping(undefined);", "",
EXPECTED_OBJECTLIT_ERROR);
// Make sure all values of the object literal are string literals.
test("var BAR = 'bar'; goog.setCssNameMapping({foo:BAR});", "",
NON_STRING_PASSED_TO_SET_CSS_NAME_MAPPING_ERROR);
test("goog.setCssNameMapping({foo:6});", "",
NON_STRING_PASSED_TO_SET_CSS_NAME_MAPPING_ERROR);
test("goog.setCssNameMapping({foo:false});", "",
NON_STRING_PASSED_TO_SET_CSS_NAME_MAPPING_ERROR);
test("goog.setCssNameMapping({foo:null});", "",
NON_STRING_PASSED_TO_SET_CSS_NAME_MAPPING_ERROR);
test("goog.setCssNameMapping({foo:undefined});", "",
NON_STRING_PASSED_TO_SET_CSS_NAME_MAPPING_ERROR);
}
public void testSetCssNameMappingValidity() {
// Make sure that the keys don't have -'s
test("goog.setCssNameMapping({'a': 'b', 'a-a': 'c'})", "", null,
INVALID_CSS_RENAMING_MAP);
// In full mode, we check that map(a-b)=map(a)-map(b)
test("goog.setCssNameMapping({'a': 'b', 'a-a': 'c'}, 'BY_WHOLE')", "", null,
INVALID_CSS_RENAMING_MAP);
// Unknown mapping type
test("goog.setCssNameMapping({foo:'bar'}, 'UNKNOWN');", "",
INVALID_STYLE_ERROR);
}
public void testBadCrossModuleRequire() {
test(
createModuleStar(
"",
"goog.provide('goog.ui');",
"goog.require('goog.ui');"),
new String[] {
"",
"goog.ui = {};",
""
},
null,
XMODULE_REQUIRE_ERROR);
}
public void testGoodCrossModuleRequire1() {
test(
createModuleStar(
"goog.provide('goog.ui');",
"",
"goog.require('goog.ui');"),
new String[] {
"goog.ui = {};",
"",
"",
});
}
public void testGoodCrossModuleRequire2() {
test(
createModuleStar(
"",
"",
"goog.provide('goog.ui'); goog.require('goog.ui');"),
new String[] {
"",
"",
"goog.ui = {};",
});
}
// Tests providing additional code with non-overlapping var namespace.
public void testSimpleAdditionalProvide() {
additionalCode = "goog.provide('b.B'); b.B = {};";
test("goog.provide('a.A'); a.A = {};",
"var b={};b.B={};var a={};a.A={};");
}
// Same as above, but with the additional code added after the original.
public void testSimpleAdditionalProvideAtEnd() {
additionalEndCode = "goog.provide('b.B'); b.B = {};";
test("goog.provide('a.A'); a.A = {};",
"var a={};a.A={};var b={};b.B={};");
}
// Tests providing additional code with non-overlapping dotted namespace.
public void testSimpleDottedAdditionalProvide() {
additionalCode = "goog.provide('a.b.B'); a.b.B = {};";
test("goog.provide('c.d.D'); c.d.D = {};",
"var a={};a.b={};a.b.B={};var c={};c.d={};c.d.D={};");
}
// Tests providing additional code with overlapping var namespace.
public void testOverlappingAdditionalProvide() {
additionalCode = "goog.provide('a.B'); a.B = {};";
test("goog.provide('a.A'); a.A = {};",
"var a={};a.B={};a.A={};");
}
// Tests providing additional code with overlapping var namespace.
public void testOverlappingAdditionalProvideAtEnd() {
additionalEndCode = "goog.provide('a.B'); a.B = {};";
test("goog.provide('a.A'); a.A = {};",
"var a={};a.A={};a.B={};");
}
// Tests providing additional code with overlapping dotted namespace.
public void testOverlappingDottedAdditionalProvide() {
additionalCode = "goog.provide('a.b.B'); a.b.B = {};";
test("goog.provide('a.b.C'); a.b.C = {};",
"var a={};a.b={};a.b.B={};a.b.C={};");
}
// Tests that a require of additional code generates no error.
public void testRequireOfAdditionalProvide() {
additionalCode = "goog.provide('b.B'); b.B = {};";
test("goog.require('b.B'); goog.provide('a.A'); a.A = {};",
"var b={};b.B={};var a={};a.A={};");
}
// Tests that a require not in additional code generates (only) one error.
public void testMissingRequireWithAdditionalProvide() {
additionalCode = "goog.provide('b.B'); b.B = {};";
test("goog.require('b.C'); goog.provide('a.A'); a.A = {};",
"var b={};b.B={};var a={};a.A={};",
MISSING_PROVIDE_ERROR);
}
// Tests that a require in additional code generates no error.
public void testLateRequire() {
additionalEndCode = "goog.require('a.A');";
test("goog.provide('a.A'); a.A = {};",
"var a={};a.A={};");
}
// Tests a case where code is reordered after processing provides and then
// provides are processed again.
public void testReorderedProvides() {
additionalCode = "a.B = {};"; // as if a.B was after a.A originally
addAdditionalNamespace = true;
test("goog.provide('a.A'); a.A = {};",
"var a={};a.B={};a.A={};");
}
// Another version of above.
public void testReorderedProvides2() {
additionalEndCode = "a.B = {};";
addAdditionalNamespace = true;
test("goog.provide('a.A'); a.A = {};",
"var a={};a.A={};a.B={};");
}
// Provide a name before the definition of the class providing the
// parent namespace.
public void testProvideOrder1() {
additionalEndCode = "";
addAdditionalNamespace = false;
// TODO(johnlenz): This test confirms that the constructor (a.b) isn't
// improperly removed, but this result isn't really what we want as the
// reassign of a.b removes the definition of "a.b.c".
test("goog.provide('a.b');" +
"goog.provide('a.b.c');" +
"a.b.c;" +
"a.b = function(x,y) {};",
"var a = {};" +
"a.b = {};" +
"a.b.c = {};" +
"a.b.c;" +
"a.b = function(x,y) {};");
}
// Provide a name after the definition of the class providing the
// parent namespace.
public void testProvideOrder2() {
additionalEndCode = "";
addAdditionalNamespace = false;
// TODO(johnlenz): This test confirms that the constructor (a.b) isn't
// improperly removed, but this result isn't really what we want as
// namespace placeholders for a.b and a.b.c remain.
test("goog.provide('a.b');" +
"goog.provide('a.b.c');" +
"a.b = function(x,y) {};" +
"a.b.c;",
"var a = {};" +
"a.b = {};" +
"a.b.c = {};" +
"a.b = function(x,y) {};" +
"a.b.c;");
}
// Provide a name after the definition of the class providing the
// parent namespace.
public void testProvideOrder3a() {
test("goog.provide('a.b');" +
"a.b = function(x,y) {};" +
"goog.provide('a.b.c');" +
"a.b.c;",
"var a = {};" +
"a.b = function(x,y) {};" +
"a.b.c = {};" +
"a.b.c;");
}
public void testProvideOrder3b() {
additionalEndCode = "";
addAdditionalNamespace = false;
// This tests a cleanly provided name, below a function namespace.
test("goog.provide('a.b');" +
"a.b = function(x,y) {};" +
"goog.provide('a.b.c');" +
"a.b.c;",
"var a = {};" +
"a.b = function(x,y) {};" +
"a.b.c = {};" +
"a.b.c;");
}
public void testProvideOrder4a() {
test("goog.provide('goog.a');" +
"goog.provide('goog.a.b');" +
"if (x) {" +
" goog.a.b = 1;" +
"} else {" +
" goog.a.b = 2;" +
"}",
"goog.a={};" +
"if(x)" +
" goog.a.b=1;" +
"else" +
" goog.a.b=2;");
}
public void testProvideOrder4b() {
additionalEndCode = "";
addAdditionalNamespace = false;
// This tests a cleanly provided name, below a namespace.
test("goog.provide('goog.a');" +
"goog.provide('goog.a.b');" +
"if (x) {" +
" goog.a.b = 1;" +
"} else {" +
" goog.a.b = 2;" +
"}",
"goog.a={};" +
"if(x)" +
" goog.a.b=1;" +
"else" +
" goog.a.b=2;");
}
public void testInvalidProvide() {
test("goog.provide('a.class');", null, INVALID_PROVIDE_ERROR);
}
private static final String METHOD_FORMAT =
"function Foo() {} Foo.prototype.method = function() { %s };";
private static final String FOO_INHERITS =
"goog.inherits(Foo, BaseFoo);";
public void testInvalidBase1() {
test("goog.base(this, 'method');", null, BASE_CLASS_ERROR);
}
public void testInvalidBase2() {
test("function Foo() {}" +
"Foo.method = function() {" +
" goog.base(this, 'method');" +
"};", null, BASE_CLASS_ERROR);
}
public void testInvalidBase3() {
test(String.format(METHOD_FORMAT, "goog.base();"),
null, BASE_CLASS_ERROR);
}
public void testInvalidBase4() {
test(String.format(METHOD_FORMAT, "goog.base(this, 'bar');"),
null, BASE_CLASS_ERROR);
}
public void testInvalidBase5() {
test(String.format(METHOD_FORMAT, "goog.base('foo', 'method');"),
null, BASE_CLASS_ERROR);
}
public void testInvalidBase6() {
test(String.format(METHOD_FORMAT, "goog.base.call(null, this, 'method');"),
null, BASE_CLASS_ERROR);
}
public void testInvalidBase7() {
test("function Foo() { goog.base(this); }",
null, BASE_CLASS_ERROR);
}
public void testInvalidBase8() {
test("var Foo = function() { goog.base(this); }",
null, BASE_CLASS_ERROR);
}
public void testInvalidBase9() {
test("var goog = {}; goog.Foo = function() { goog.base(this); }",
null, BASE_CLASS_ERROR);
}
public void testValidBase1() {
test(String.format(METHOD_FORMAT, "goog.base(this, 'method');"),
String.format(METHOD_FORMAT, "Foo.superClass_.method.call(this)"));
}
public void testValidBase2() {
test(String.format(METHOD_FORMAT, "goog.base(this, 'method', 1, 2);"),
String.format(METHOD_FORMAT,
"Foo.superClass_.method.call(this, 1, 2)"));
}
public void testValidBase3() {
test(String.format(METHOD_FORMAT, "return goog.base(this, 'method');"),
String.format(METHOD_FORMAT,
"return Foo.superClass_.method.call(this)"));
}
public void testValidBase4() {
test("function Foo() { goog.base(this, 1, 2); }" + FOO_INHERITS,
"function Foo() { BaseFoo.call(this, 1, 2); } " + FOO_INHERITS);
}
public void testValidBase5() {
test("var Foo = function() { goog.base(this, 1); };" + FOO_INHERITS,
"var Foo = function() { BaseFoo.call(this, 1); }; " + FOO_INHERITS);
}
public void testValidBase6() {
test("var goog = {}; goog.Foo = function() { goog.base(this); }; " +
"goog.inherits(goog.Foo, goog.BaseFoo);",
"var goog = {}; goog.Foo = function() { goog.BaseFoo.call(this); }; " +
"goog.inherits(goog.Foo, goog.BaseFoo);");
}
public void testImplicitAndExplicitProvide() {
test("var goog = {}; " +
"goog.provide('goog.foo.bar'); goog.provide('goog.foo');",
"var goog = {}; goog.foo = {}; goog.foo.bar = {};");
}
public void testImplicitProvideInIndependentModules() {
test(
createModuleStar(
"",
"goog.provide('apps.A');",
"goog.provide('apps.B');"),
new String[] {
"var apps = {};",
"apps.A = {};",
"apps.B = {};",
});
}
public void testImplicitProvideInIndependentModules2() {
test(
createModuleStar(
"goog.provide('apps');",
"goog.provide('apps.foo.A');",
"goog.provide('apps.foo.B');"),
new String[] {
"var apps = {}; apps.foo = {};",
"apps.foo.A = {};",
"apps.foo.B = {};",
});
}
public void testImplicitProvideInIndependentModules3() {
test(
createModuleStar(
"var goog = {};",
"goog.provide('goog.foo.A');",
"goog.provide('goog.foo.B');"),
new String[] {
"var goog = {}; goog.foo = {};",
"goog.foo.A = {};",
"goog.foo.B = {};",
});
}
public void testProvideInIndependentModules1() {
test(
createModuleStar(
"goog.provide('apps');",
"goog.provide('apps.foo');",
"goog.provide('apps.foo.B');"),
new String[] {
"var apps = {}; apps.foo = {};",
"",
"apps.foo.B = {};",
});
}
public void testProvideInIndependentModules2() {
// TODO(nicksantos): Make this an error.
test(
createModuleStar(
"goog.provide('apps');",
"goog.provide('apps.foo'); apps.foo = {};",
"goog.provide('apps.foo.B');"),
new String[] {
"var apps = {};",
"apps.foo = {};",
"apps.foo.B = {};",
});
}
public void testProvideInIndependentModules2b() {
// TODO(nicksantos): Make this an error.
test(
createModuleStar(
"goog.provide('apps');",
"goog.provide('apps.foo'); apps.foo = function() {};",
"goog.provide('apps.foo.B');"),
new String[] {
"var apps = {};",
"apps.foo = function() {};",
"apps.foo.B = {};",
});
}
public void testProvideInIndependentModules3() {
test(
createModuleStar(
"goog.provide('apps');",
"goog.provide('apps.foo.B');",
"goog.provide('apps.foo'); goog.require('apps.foo');"),
new String[] {
"var apps = {}; apps.foo = {};",
"apps.foo.B = {};",
"",
});
}
public void testProvideInIndependentModules3b() {
// TODO(nicksantos): Make this an error.
test(
createModuleStar(
"goog.provide('apps');",
"goog.provide('apps.foo.B');",
"goog.provide('apps.foo'); apps.foo = function() {}; " +
"goog.require('apps.foo');"),
new String[] {
"var apps = {};",
"apps.foo.B = {};",
"apps.foo = function() {};",
});
}
public void testProvideInIndependentModules4() {
// Regression test for bug 261:
// http://code.google.com/p/closure-compiler/issues/detail?id=261
test(
createModuleStar(
"goog.provide('apps');",
"goog.provide('apps.foo.bar.B');",
"goog.provide('apps.foo.bar.C');"),
new String[] {
"var apps = {};apps.foo = {};apps.foo.bar = {}",
"apps.foo.bar.B = {};",
"apps.foo.bar.C = {};",
});
}
public void testRequireOfBaseGoog() {
test("goog.require('goog');",
"", MISSING_PROVIDE_ERROR);
}
public void testSourcePositionPreservation() {
test("goog.provide('foo.bar.baz');",
"var foo = {};" +
"foo.bar = {};" +
"foo.bar.baz = {};");
Node root = getLastCompiler().getRoot();
Node fooDecl = findQualifiedNameNode("foo", root);
Node fooBarDecl = findQualifiedNameNode("foo.bar", root);
Node fooBarBazDecl = findQualifiedNameNode("foo.bar.baz", root);
assertEquals(1, fooDecl.getLineno());
assertEquals(14, fooDecl.getCharno());
assertEquals(1, fooBarDecl.getLineno());
assertEquals(18, fooBarDecl.getCharno());
assertEquals(1, fooBarBazDecl.getLineno());
assertEquals(22, fooBarBazDecl.getCharno());
}
public void testNoStubForProvidedTypedef() {
test("goog.provide('x'); /** @typedef {number} */ var x;", "var x;");
}
public void testNoStubForProvidedTypedef2() {
test("goog.provide('x.y'); /** @typedef {number} */ x.y;",
"var x = {}; x.y;");
}
public void testNoStubForProvidedTypedef4() {
test("goog.provide('x.y.z'); /** @typedef {number} */ x.y.z;",
"var x = {}; x.y = {}; x.y.z;");
}
public void testProvideRequireSameFile() {
test("goog.provide('x');\ngoog.require('x');", "var x = {};");
}
}
|