1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
|
/*
* Copyright 2010 The Closure Compiler Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.javascript.jscomp;
import com.google.common.collect.Maps;
import com.google.javascript.rhino.Node;
import com.google.javascript.rhino.Token;
import java.util.Collections;
import java.util.Map;
import java.util.Set;
/**
* @author agrieve@google.com (Andrew Grieve)
*/
public class ProcessTweaksTest extends CompilerTestCase {
Map<String, Node> defaultValueOverrides;
boolean stripTweaks;
public ProcessTweaksTest() {
super("function alert(arg) {}");
}
@Override
public void setUp() throws Exception {
super.setUp();
defaultValueOverrides = Maps.newHashMap();
stripTweaks = false;
}
@Override
protected CompilerPass getProcessor(final Compiler compiler) {
return new CompilerPass() {
@Override
public void process(Node externs, Node root) {
ProcessTweaks processTweak =
new ProcessTweaks(compiler, stripTweaks, defaultValueOverrides);
processTweak.process(externs, root);
if (stripTweaks) {
Set<String> emptySet = Collections.emptySet();
final StripCode stripCode = new StripCode(compiler, emptySet,
emptySet, emptySet, emptySet);
stripCode.enableTweakStripping();
stripCode.process(externs, root);
}
}
};
}
@Override
protected int getNumRepetitions() {
// Only do one repetition, so that we can make sure the first pass keeps
// GlobalNamespace up to date.
return 1;
}
public void testBasicTweak1() {
testSame("goog.tweak.registerBoolean('Foo', 'Description');" +
"goog.tweak.getBoolean('Foo')");
}
public void testBasicTweak2() {
testSame("goog.tweak.registerString('Foo', 'Description');" +
"goog.tweak.getString('Foo')");
}
public void testBasicTweak3() {
testSame("goog.tweak.registerNumber('Foo', 'Description');" +
"goog.tweak.getNumber('Foo')");
}
public void testBasicTweak4() {
testSame("goog.tweak.registerButton('Foo', 'Description', function() {})");
}
public void testBasicTweak5() {
testSame("goog.tweak.registerBoolean('A.b_7', 'Description', true, " +
"{ requiresRestart:false })");
}
public void testBasicTweak6() {
testSame("var opts = { requiresRestart:false };" +
"goog.tweak.registerBoolean('Foo', 'Description', true, opts)");
}
public void testNonLiteralId1() {
test("goog.tweak.registerBoolean(3, 'Description')", null,
ProcessTweaks.NON_LITERAL_TWEAK_ID_ERROR);
}
public void testNonLiteralId2() {
test("goog.tweak.getBoolean('a' + 'b')", null,
ProcessTweaks.NON_LITERAL_TWEAK_ID_ERROR);
}
public void testNonLiteralId3() {
test("var CONST = 'foo'; goog.tweak.overrideDefaultValue(CONST, 3)", null,
ProcessTweaks.NON_LITERAL_TWEAK_ID_ERROR);
}
public void testInvalidId() {
test("goog.tweak.registerBoolean('Some ID', 'a')", null,
ProcessTweaks.INVALID_TWEAK_ID_ERROR);
}
public void testInvalidDefaultValue1() {
testSame("var val = true; goog.tweak.registerBoolean('Foo', 'desc', val)",
ProcessTweaks.INVALID_TWEAK_DEFAULT_VALUE_WARNING);
}
public void testInvalidDefaultValue2() {
testSame("goog.tweak.overrideDefaultValue('Foo', 3 + 1);" +
"goog.tweak.registerNumber('Foo', 'desc')",
ProcessTweaks.INVALID_TWEAK_DEFAULT_VALUE_WARNING);
}
public void testUnknownGetString() {
testSame("goog.tweak.getString('huh')",
ProcessTweaks.UNKNOWN_TWEAK_WARNING);
}
public void testUnknownGetNumber() {
testSame("goog.tweak.getNumber('huh')",
ProcessTweaks.UNKNOWN_TWEAK_WARNING);
}
public void testUnknownGetBoolean() {
testSame("goog.tweak.getBoolean('huh')",
ProcessTweaks.UNKNOWN_TWEAK_WARNING);
}
public void testUnknownOverride() {
testSame("goog.tweak.overrideDefaultValue('huh', 'val')",
ProcessTweaks.UNKNOWN_TWEAK_WARNING);
}
public void testDuplicateTweak() {
test("goog.tweak.registerBoolean('TweakA', 'desc');" +
"goog.tweak.registerBoolean('TweakA', 'desc')", null,
ProcessTweaks.TWEAK_MULTIPLY_REGISTERED_ERROR);
}
public void testOverrideAfterRegister() {
test("goog.tweak.registerBoolean('TweakA', 'desc');" +
"goog.tweak.overrideDefaultValue('TweakA', 'val')",
null, ProcessTweaks.TWEAK_OVERRIDE_AFTER_REGISTERED_ERROR);
}
public void testRegisterInNonGlobalScope() {
test("function foo() {goog.tweak.registerBoolean('TweakA', 'desc');};",
null, ProcessTweaks.NON_GLOBAL_TWEAK_INIT_ERROR);
}
public void testWrongGetter1() {
testSame("goog.tweak.registerBoolean('TweakA', 'desc');" +
"goog.tweak.getString('TweakA')",
ProcessTweaks.TWEAK_WRONG_GETTER_TYPE_WARNING);
}
public void testWrongGetter2() {
testSame("goog.tweak.registerString('TweakA', 'desc');" +
"goog.tweak.getNumber('TweakA')",
ProcessTweaks.TWEAK_WRONG_GETTER_TYPE_WARNING);
}
public void testWrongGetter3() {
testSame("goog.tweak.registerNumber('TweakA', 'desc');" +
"goog.tweak.getBoolean('TweakA')",
ProcessTweaks.TWEAK_WRONG_GETTER_TYPE_WARNING);
}
public void testWithNoTweaks() {
testSame("var DEF=true;var x={};x.foo={}");
}
public void testStrippingWithImplicitDefaultValues() {
stripTweaks = true;
test("goog.tweak.registerNumber('TweakA', 'desc');" +
"goog.tweak.registerBoolean('TweakB', 'desc');" +
"goog.tweak.registerString('TweakC', 'desc');" +
"alert(goog.tweak.getNumber('TweakA'));" +
"alert(goog.tweak.getBoolean('TweakB'));" +
"alert(goog.tweak.getString('TweakC'));",
"void 0; void 0; void 0; alert(0); alert(false); alert('')");
}
public void testStrippingWithExplicitDefaultValues() {
stripTweaks = true;
test("goog.tweak.registerNumber('TweakA', 'desc', 5);" +
"goog.tweak.registerBoolean('TweakB', 'desc', true);" +
"goog.tweak.registerString('TweakC', 'desc', '!');" +
"alert(goog.tweak.getNumber('TweakA'));" +
"alert(goog.tweak.getBoolean('TweakB'));" +
"alert(goog.tweak.getString('TweakC'));",
"void 0; void 0; void 0; alert(5); alert(true); alert('!')");
}
public void testStrippingWithInCodeOverrides() {
stripTweaks = true;
test("goog.tweak.overrideDefaultValue('TweakA', 5);" +
"goog.tweak.overrideDefaultValue('TweakB', true);" +
"goog.tweak.overrideDefaultValue('TweakC', 'bar');" +
"goog.tweak.registerNumber('TweakA', 'desc');" +
"goog.tweak.registerBoolean('TweakB', 'desc');" +
"goog.tweak.registerString('TweakC', 'desc', 'foo');" +
"alert(goog.tweak.getNumber('TweakA'));" +
"alert(goog.tweak.getBoolean('TweakB'));" +
"alert(goog.tweak.getString('TweakC'));",
"void 0; void 0; void 0; void 0; void 0; void 0;" +
"alert(5); alert(true); alert('bar');");
}
public void testStrippingWithUnregisteredTweak1() {
stripTweaks = true;
test("alert(goog.tweak.getNumber('TweakA'));",
"alert(0)", null, ProcessTweaks.UNKNOWN_TWEAK_WARNING);
}
public void testStrippingWithUnregisteredTweak2() {
stripTweaks = true;
test("alert(goog.tweak.getBoolean('TweakB'))",
"alert(false)", null, ProcessTweaks.UNKNOWN_TWEAK_WARNING);
}
public void testStrippingWithUnregisteredTweak3() {
stripTweaks = true;
test("alert(goog.tweak.getString('TweakC'))",
"alert('')", null, ProcessTweaks.UNKNOWN_TWEAK_WARNING);
}
public void testStrippingOfManuallyRegistered1() {
stripTweaks = true;
test("var reg = goog.tweak.getRegistry();" +
"if (reg) {" +
" reg.register(new goog.tweak.BooleanSetting('foo', 'desc'));" +
" reg.getEntry('foo').setDefaultValue(1);" +
"}",
"if (null);");
}
public void testOverridesWithStripping() {
stripTweaks = true;
defaultValueOverrides.put("TweakA", Node.newNumber(1));
defaultValueOverrides.put("TweakB", new Node(Token.FALSE));
defaultValueOverrides.put("TweakC", Node.newString("!"));
test("goog.tweak.overrideDefaultValue('TweakA', 5);" +
"goog.tweak.overrideDefaultValue('TweakC', 'bar');" +
"goog.tweak.registerNumber('TweakA', 'desc');" +
"goog.tweak.registerBoolean('TweakB', 'desc', true);" +
"goog.tweak.registerString('TweakC', 'desc', 'foo');" +
"alert(goog.tweak.getNumber('TweakA'));" +
"alert(goog.tweak.getBoolean('TweakB'));" +
"alert(goog.tweak.getString('TweakC'));",
"void 0; void 0; void 0; void 0; void 0; " +
"alert(1); alert(false); alert('!')");
}
public void testCompilerOverridesNoStripping1() {
defaultValueOverrides.put("TweakA", Node.newNumber(1));
defaultValueOverrides.put("TweakB", new Node(Token.FALSE));
defaultValueOverrides.put("TweakC", Node.newString("!"));
test("goog.tweak.registerNumber('TweakA', 'desc');" +
"goog.tweak.registerBoolean('TweakB', 'desc', true);" +
"goog.tweak.registerString('TweakC', 'desc', 'foo');" +
"var a = goog.tweak.getCompilerOverrides_()",
"goog.tweak.registerNumber('TweakA', 'desc');" +
"goog.tweak.registerBoolean('TweakB', 'desc', true);" +
"goog.tweak.registerString('TweakC', 'desc', 'foo');" +
"var a = { TweakA: 1, TweakB: false, TweakC: '!' };");
}
public void testCompilerOverridesNoStripping2() {
defaultValueOverrides.put("TweakA", Node.newNumber(1));
defaultValueOverrides.put("TweakB", new Node(Token.FALSE));
defaultValueOverrides.put("TweakC", Node.newString("!"));
test("goog.tweak.registerNumber('TweakA', 'desc');" +
"goog.tweak.registerBoolean('TweakB', 'desc', true);" +
"goog.tweak.registerString('TweakC', 'desc', 'foo');" +
"var a = goog.tweak.getCompilerOverrides_();" +
"var b = goog.tweak.getCompilerOverrides_()",
"goog.tweak.registerNumber('TweakA', 'desc');" +
"goog.tweak.registerBoolean('TweakB', 'desc', true);" +
"goog.tweak.registerString('TweakC', 'desc', 'foo');" +
"var a = { TweakA: 1, TweakB: false, TweakC: '!' };" +
"var b = { TweakA: 1, TweakB: false, TweakC: '!' };");
}
public void testUnknownCompilerOverride() {
allowSourcelessWarnings();
defaultValueOverrides.put("TweakA", Node.newString("!"));
testSame("var a", ProcessTweaks.UNKNOWN_TWEAK_WARNING);
}
public void testCompilerOverrideWithWrongType() {
allowSourcelessWarnings();
defaultValueOverrides.put("TweakA", Node.newString("!"));
testSame("goog.tweak.registerBoolean('TweakA', 'desc')",
ProcessTweaks.INVALID_TWEAK_DEFAULT_VALUE_WARNING);
}
}
|
