1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
|
/*
* Copyright 2010 The Closure Compiler Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.javascript.jscomp;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import junit.framework.TestCase;
import java.util.List;
/**
* Tests for error message filtering.
* @author nicksantos@google.com (Nick Santos)
*/
public class RhinoErrorReporterTest extends TestCase {
private boolean reportMisplacedTypeAnnotations;
@Override
protected void setUp() throws Exception {
reportMisplacedTypeAnnotations = false;
super.setUp();
}
public void testTrailingComma() throws Exception {
String message =
"Parse error. IE8 (and below) will parse trailing commas in " +
"array and object literals incorrectly. " +
"If you are targeting newer versions of JS, " +
"set the appropriate language_in option.";
assertError(
"var x = [1,];",
RhinoErrorReporter.TRAILING_COMMA,
message);
JSError error = assertError(
"var x = {\n" +
" 1: 2,\n" +
"};",
RhinoErrorReporter.TRAILING_COMMA,
message);
assertEquals(2, error.getLineNumber());
// Rhino uses the "beginning" of the line where the comma appears,
// for some odd reason.
assertEquals(4, error.getCharno());
}
public void testMisplacedTypeAnnotation() throws Exception {
reportMisplacedTypeAnnotations = false;
assertNoWarningOrError("var x = /** @type {string} */ y;");
reportMisplacedTypeAnnotations = true;
String message =
"Type annotations are not allowed here. " +
"Are you missing parentheses?";
assertWarning(
"var x = /** @type {string} */ y;",
RhinoErrorReporter.MISPLACED_TYPE_ANNOTATION,
message);
JSError error = assertWarning(
"var x = /** @type {string} */ y;",
RhinoErrorReporter.MISPLACED_TYPE_ANNOTATION,
message);
assertEquals(1, error.getLineNumber());
// Rhino uses the "beginning" of the line where the comma appears,
// for some odd reason.
assertEquals(0, error.getCharno());
}
/**
* Verifies that the compiler emits an error for the given code.
*/
private void assertNoWarningOrError(String code) {
Compiler compiler = parseCode(code);
assertEquals("Expected error", 0, compiler.getErrorCount());
assertEquals("Expected warning", 0, compiler.getErrorCount());
}
/**
* Verifies that the compiler emits an error for the given code.
*/
private JSError assertError(
String code, DiagnosticType type, String description) {
Compiler compiler = parseCode(code);
assertEquals("Expected error", 1, compiler.getErrorCount());
JSError error =
Iterables.getOnlyElement(Lists.newArrayList(compiler.getErrors()));
assertEquals(type, error.getType());
assertEquals(description, error.description);
return error;
}
/**
* Verifies that the compiler emits an error for the given code.
*/
private JSError assertWarning(
String code, DiagnosticType type, String description) {
Compiler compiler = parseCode(code);
assertEquals("Expected warning", 1, compiler.getWarningCount());
JSError error =
Iterables.getOnlyElement(Lists.newArrayList(compiler.getWarnings()));
assertEquals(type, error.getType());
assertEquals(description, error.description);
return error;
}
private Compiler parseCode(String code) {
Compiler compiler = new Compiler();
CompilerOptions options = new CompilerOptions();
if (reportMisplacedTypeAnnotations) {
options.setWarningLevel(
DiagnosticGroups.MISPLACED_TYPE_ANNOTATION,
CheckLevel.WARNING);
}
List<SourceFile> externs = ImmutableList.of();
List<SourceFile> inputs = ImmutableList.of(
SourceFile.fromCode("input", code));
compiler.init(externs, inputs, options);
compiler.parseInputs();
return compiler;
}
}
|
