1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
|
import json
import logging
import os
import pytest
import yaml
from tests.integration_tests.clouds import IntegrationCloud
from tests.integration_tests.conftest import get_validated_source
from tests.integration_tests.integration_settings import PLATFORM
from tests.integration_tests.releases import (
CURRENT_RELEASE,
FOCAL,
IS_UBUNTU,
JAMMY,
)
from tests.integration_tests.util import verify_clean_boot, verify_clean_log
LOG = logging.getLogger("integration_testing.test_upgrade")
LOG_TEMPLATE = """\n\
=== `systemd-analyze` before:
{pre_systemd_analyze}
=== `systemd-analyze` after:
{post_systemd_analyze}
=== `systemd-analyze blame` before (first 10 lines):
{pre_systemd_blame}
=== `systemd-analyze blame` after (first 10 lines):
{post_systemd_blame}
=== `cloud-init analyze show` before:')
{pre_analyze_totals}
=== `cloud-init analyze show` after:')
{post_analyze_totals}
=== `cloud-init analyze blame` before (first 10 lines): ')
{pre_cloud_blame}
=== `cloud-init analyze blame` after (first 10 lines): ')
{post_cloud_blame}
"""
UNSUPPORTED_INSTALL_METHOD_MSG = (
"Install method '{}' not supported for this test"
)
USER_DATA = """\
#cloud-config
hostname: SRU-worked
"""
# The issues that we see on Bionic VMs don't appear anywhere
# else, including when calling KVM directly. It likely has to
# do with the extra lxd-agent setup happening on bionic.
# Given that we still have Bionic covered on all other platforms,
# the risk of skipping bionic here seems low enough.
@pytest.mark.skipif(
PLATFORM == "lxd_vm" and CURRENT_RELEASE < FOCAL,
reason="Update test doesn't run on Bionic LXD VMs",
)
def test_clean_boot_of_upgraded_package(session_cloud: IntegrationCloud):
source = get_validated_source(session_cloud)
if not source.installs_new_version():
pytest.skip(UNSUPPORTED_INSTALL_METHOD_MSG.format(source))
launch_kwargs = {
"image_id": session_cloud.initial_image_id,
}
with session_cloud.launch(
launch_kwargs=launch_kwargs,
user_data=USER_DATA,
) as instance:
# get pre values
pre_hostname = instance.execute("hostname")
pre_cloud_id = instance.execute("cloud-id")
pre_result = instance.execute("cat /run/cloud-init/result.json")
pre_network = instance.execute("cat /etc/netplan/50-cloud-init.yaml")
pre_systemd_analyze = instance.execute("systemd-analyze")
pre_systemd_blame = instance.execute("systemd-analyze blame")
pre_cloud_analyze = instance.execute("cloud-init analyze show")
pre_cloud_blame = instance.execute("cloud-init analyze blame")
# Ensure no issues pre-upgrade
try:
verify_clean_boot(instance)
except AssertionError:
LOG.warning(
"There were errors/warnings/tracebacks pre-upgrade. "
"Any failures may be due to pre-upgrade problem"
)
# Upgrade
instance.install_new_cloud_init(source)
# 'cloud-init init' helps us understand if our pickling upgrade paths
# have broken across re-constitution of a cached datasource. Some
# platforms invalidate their datasource cache on reboot, so we run
# it here to ensure we get a dirty run.
assert instance.execute(
"cloud-init init --local; "
"cloud-init init; "
"cloud-init modules --mode=config; "
"cloud-init modules --mode=final"
).ok
# Reboot
instance.execute("hostname something-else")
instance.restart()
assert instance.execute("cloud-init status --wait --long").ok
# get post values
post_hostname = instance.execute("hostname")
post_cloud_id = instance.execute("cloud-id")
post_result = instance.execute("cat /run/cloud-init/result.json")
post_network = instance.execute("cat /etc/netplan/50-cloud-init.yaml")
post_systemd_analyze = instance.execute("systemd-analyze")
post_systemd_blame = instance.execute("systemd-analyze blame")
post_cloud_analyze = instance.execute("cloud-init analyze show")
post_cloud_blame = instance.execute("cloud-init analyze blame")
# Ensure no issues post-upgrade
verify_clean_boot(instance)
# Ensure important things stayed the same
assert pre_hostname == post_hostname
assert pre_cloud_id == post_cloud_id
try:
assert pre_result == post_result
except AssertionError:
if instance.settings.PLATFORM == "azure":
pre_json = json.loads(pre_result)
post_json = json.loads(post_result)
assert pre_json["v1"]["datasource"].startswith(
"DataSourceAzure"
)
assert post_json["v1"]["datasource"].startswith(
"DataSourceAzure"
)
if CURRENT_RELEASE < JAMMY:
# Assert the full content is preserved including header comment
# since cloud-init writes the file directly and does not use
# netplan API to write 50-cloud-init.yaml.
assert pre_network == post_network
else:
# Jammy and later Netplan API is used and doesn't allow
# cloud-init to write header comments in network config
assert yaml.safe_load(pre_network) == yaml.safe_load(post_network)
# Calculate and log all the boot numbers
pre_analyze_totals = [
x
for x in pre_cloud_analyze.splitlines()
if x.startswith(("Finished stage", "Total Time"))
]
post_analyze_totals = [
x
for x in post_cloud_analyze.splitlines()
if x.startswith(("Finished stage", "Total Time"))
]
# pylint: disable=logging-format-interpolation
LOG.info(
LOG_TEMPLATE.format(
pre_systemd_analyze=pre_systemd_analyze,
post_systemd_analyze=post_systemd_analyze,
pre_systemd_blame="\n".join(
pre_systemd_blame.splitlines()[:10]
),
post_systemd_blame="\n".join(
post_systemd_blame.splitlines()[:10]
),
pre_analyze_totals="\n".join(pre_analyze_totals),
post_analyze_totals="\n".join(post_analyze_totals),
pre_cloud_blame="\n".join(pre_cloud_blame.splitlines()[:10]),
post_cloud_blame="\n".join(post_cloud_blame.splitlines()[:10]),
)
)
@pytest.mark.ci
@pytest.mark.skipif(not IS_UBUNTU, reason="Only ever tested on Ubuntu")
def test_subsequent_boot_of_upgraded_package(session_cloud: IntegrationCloud):
source = get_validated_source(session_cloud)
if not source.installs_new_version():
if os.environ.get("GITHUB_ACTIONS"):
# If this isn't running on CI, we should know
pytest.fail(UNSUPPORTED_INSTALL_METHOD_MSG.format(source))
else:
pytest.skip(UNSUPPORTED_INSTALL_METHOD_MSG.format(source))
launch_kwargs = {"image_id": session_cloud.initial_image_id}
with session_cloud.launch(launch_kwargs=launch_kwargs) as instance:
instance.install_new_cloud_init(source, clean=False)
# Ensure we aren't looking at any prior warnings/errors from prior boot
instance.execute("rm /var/log/cloud-init.log")
instance.restart()
log = instance.read_from_file("/var/log/cloud-init.log")
verify_clean_log(log)
assert instance.execute("cloud-init status --wait --long").ok
verify_clean_boot(instance)
@pytest.mark.timeout(600) # A failure here can leave us hanging
def test_clean_package_install(session_cloud: IntegrationCloud):
"""Test that the package install works after purge of old package."""
source = get_validated_source(session_cloud)
if not source.installs_new_version():
pytest.skip(UNSUPPORTED_INSTALL_METHOD_MSG.format(source))
launch_kwargs = {"image_id": session_cloud.initial_image_id}
with session_cloud.launch(launch_kwargs=launch_kwargs) as instance:
# Do the update before uninstalling cloud-init because we
# use cloud-init to do the package update.
instance.update_package_cache()
assert instance.execute("apt --yes remove --purge cloud-init").ok
instance.install_new_cloud_init(source, clean=False, update=False)
instance.restart()
assert instance.execute("cloud-init status --wait --long").ok
verify_clean_boot(instance)
|
