1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829
|
# This file is part of cloud-init. See LICENSE file for license information.
# pylint: disable=attribute-defined-outside-init
import copy
import errno
import ipaddress
import logging
import os
from pathlib import Path
from typing import Optional
from unittest import mock
import pytest
import cloudinit.net as net
from cloudinit import subp
from cloudinit.net.ephemeral import EphemeralIPv4Network, EphemeralIPv6Network
from cloudinit.subp import ProcessExecutionError
from cloudinit.util import ensure_file, write_file
from tests.unittests.helpers import (
assert_count_equal,
example_netdev,
random_string,
)
from tests.unittests.util import MockDistro
class TestSysDevPath:
def test_sys_dev_path(self):
"""sys_dev_path returns a path under SYS_CLASS_NET for a device."""
dev = "something"
path = "attribute"
expected = net.get_sys_class_path() + dev + "/" + path
assert expected == net.sys_dev_path(dev, path)
def test_sys_dev_path_without_path(self):
"""When path param isn't provided it defaults to empty string."""
dev = "something"
expected = net.get_sys_class_path() + dev + "/"
assert expected == net.sys_dev_path(dev)
class TestReadSysNet:
@pytest.fixture(autouse=True)
def setup(self, tmpdir_factory):
# We mock invididual numbered tmpdirs here because these tests write
# to the sysfs directory and stale test artifacts break later tests.
mock_sysfs = f"{tmpdir_factory.mktemp('sysfs', numbered=True)}/"
with mock.patch(
"cloudinit.net.get_sys_class_path", return_value=mock_sysfs
):
self.sysdir = mock_sysfs
yield
def test_read_sys_net_strips_contents_of_sys_path(self):
"""read_sys_net strips whitespace from the contents of a sys file."""
content = "some stuff with trailing whitespace\t\r\n"
write_file(os.path.join(self.sysdir, "dev", "attr"), content)
assert content.strip() == net.read_sys_net("dev", "attr")
def test_read_sys_net_reraises_oserror(self):
"""read_sys_net raises OSError/IOError when file doesn't exist."""
# Non-specific Exception because versions of python OSError vs IOError.
with pytest.raises(Exception, match="No such file or directory"):
net.read_sys_net("dev", "attr")
def test_read_sys_net_handles_error_with_on_enoent(self):
"""read_sys_net handles OSError/IOError with on_enoent if provided."""
handled_errors = []
def on_enoent(e):
handled_errors.append(e)
net.read_sys_net("dev", "attr", on_enoent=on_enoent)
error = handled_errors[0]
assert isinstance(error, Exception)
assert "No such file or directory" in str(error)
def test_read_sys_net_translates_content(self):
"""read_sys_net translates content when translate dict is provided."""
content = "you're welcome\n"
write_file(os.path.join(self.sysdir, "dev", "attr"), content)
translate = {"you're welcome": "de nada"}
assert "de nada" == net.read_sys_net(
"dev", "attr", translate=translate
)
def test_read_sys_net_errors_on_translation_failures(self, caplog):
"""read_sys_net raises a KeyError and logs details on failure."""
content = "you're welcome\n"
write_file(os.path.join(self.sysdir, "dev", "attr"), content)
with pytest.raises(KeyError, match='"you\'re welcome"'):
net.read_sys_net("dev", "attr", translate={})
assert (
"Found unexpected (not translatable) value 'you're welcome' in "
"'{0}dev/attr".format(self.sysdir) in caplog.text
)
def test_read_sys_net_handles_handles_with_onkeyerror(self):
"""read_sys_net handles translation errors calling on_keyerror."""
content = "you're welcome\n"
write_file(os.path.join(self.sysdir, "dev", "attr"), content)
handled_errors = []
def on_keyerror(e):
handled_errors.append(e)
net.read_sys_net("dev", "attr", translate={}, on_keyerror=on_keyerror)
error = handled_errors[0]
assert isinstance(error, KeyError)
assert '"you\'re welcome"' == str(error)
def test_read_sys_net_safe_false_on_translate_failure(self):
"""read_sys_net_safe returns False on translation failures."""
content = "you're welcome\n"
write_file(os.path.join(self.sysdir, "dev", "attr"), content)
assert not net.read_sys_net_safe("dev", "attr", translate={})
def test_read_sys_net_safe_returns_false_on_noent_failure(self):
"""read_sys_net_safe returns False on file not found failures."""
assert not net.read_sys_net_safe("dev", "attr")
def test_read_sys_net_int_returns_none_on_error(self):
"""read_sys_net_safe returns None on failures."""
assert not net.read_sys_net_int("dev", "attr")
def test_read_sys_net_int_returns_none_on_valueerror(self):
"""read_sys_net_safe returns None when content is not an int."""
write_file(os.path.join(self.sysdir, "dev", "attr"), "NOTINT\n")
assert not net.read_sys_net_int("dev", "attr")
def test_read_sys_net_int_returns_integer_from_content(self):
"""read_sys_net_safe returns None on failures."""
write_file(os.path.join(self.sysdir, "dev", "attr"), "1\n")
assert 1 == net.read_sys_net_int("dev", "attr")
def test_is_up_true(self):
"""is_up is True if sys/net/devname/operstate is 'up' or 'unknown'."""
for state in ["up", "unknown"]:
write_file(os.path.join(self.sysdir, "eth0", "operstate"), state)
assert net.is_up("eth0")
def test_is_up_false(self):
"""is_up is False if sys/net/devname/operstate is 'down' or invalid."""
for state in ["down", "incomprehensible"]:
write_file(os.path.join(self.sysdir, "eth0", "operstate"), state)
assert not net.is_up("eth0")
def test_is_bridge(self):
"""is_bridge is True when /sys/net/devname/bridge exists."""
assert not net.is_bridge("eth0")
ensure_file(os.path.join(self.sysdir, "eth0", "bridge"))
assert net.is_bridge("eth0")
def test_is_bond(self):
"""is_bond is True when /sys/net/devname/bonding exists."""
assert not net.is_bond("eth0")
ensure_file(os.path.join(self.sysdir, "eth0", "bonding"))
assert net.is_bond("eth0")
def test_get_master(self):
"""get_master returns the path when /sys/net/devname/master exists."""
assert net.get_master("enP1s1") is None
master_path = os.path.join(self.sysdir, "enP1s1", "master")
ensure_file(master_path)
assert master_path == net.get_master("enP1s1")
def test_master_is_bridge_or_bond(self):
bridge_mac = "aa:bb:cc:aa:bb:cc"
bond_mac = "cc:bb:aa:cc:bb:aa"
# No master => False
write_file(os.path.join(self.sysdir, "eth1", "address"), bridge_mac)
write_file(os.path.join(self.sysdir, "eth2", "address"), bond_mac)
assert not net.master_is_bridge_or_bond("eth1")
assert not net.master_is_bridge_or_bond("eth2")
# masters without bridge/bonding => False
write_file(os.path.join(self.sysdir, "br0", "address"), bridge_mac)
write_file(os.path.join(self.sysdir, "bond0", "address"), bond_mac)
os.symlink("../br0", os.path.join(self.sysdir, "eth1", "master"))
os.symlink("../bond0", os.path.join(self.sysdir, "eth2", "master"))
assert not net.master_is_bridge_or_bond("eth1")
assert not net.master_is_bridge_or_bond("eth2")
# masters with bridge/bonding => True
write_file(os.path.join(self.sysdir, "br0", "bridge"), "")
write_file(os.path.join(self.sysdir, "bond0", "bonding"), "")
assert net.master_is_bridge_or_bond("eth1")
assert net.master_is_bridge_or_bond("eth2")
def test_master_is_openvswitch(self):
ovs_mac = "bb:cc:aa:bb:cc:aa"
# No master => False
write_file(os.path.join(self.sysdir, "eth1", "address"), ovs_mac)
assert not net.master_is_bridge_or_bond("eth1")
# masters without ovs-system => False
write_file(os.path.join(self.sysdir, "ovs-system", "address"), ovs_mac)
os.symlink(
"../ovs-system", os.path.join(self.sysdir, "eth1", "master")
)
assert not net.master_is_openvswitch("eth1")
# masters with ovs-system => True
os.symlink(
"../ovs-system",
os.path.join(self.sysdir, "eth1", "upper_ovs-system"),
)
assert net.master_is_openvswitch("eth1")
def test_is_vlan(self):
"""is_vlan is True when /sys/net/devname/uevent has DEVTYPE=vlan."""
ensure_file(os.path.join(self.sysdir, "eth0", "uevent"))
assert not net.is_vlan("eth0")
content = "junk\nDEVTYPE=vlan\njunk\n"
write_file(os.path.join(self.sysdir, "eth0", "uevent"), content)
assert net.is_vlan("eth0")
class TestGenerateFallbackConfig:
@pytest.fixture(autouse=True)
def fixtures(self, mocker, tmp_path):
self.sysdir = str(tmp_path) + "/"
mocker.patch(
"cloudinit.net.get_sys_class_path", return_value=self.sysdir
)
mocker.patch("cloudinit.net.util.is_container", return_value=False)
mocker.patch("cloudinit.net.util.udevadm_settle")
self.m_is_netfail = mocker.patch(
"cloudinit.net.is_netfailover", return_value=False
)
mocker.patch(
"cloudinit.net.is_netfail_master",
return_value=False,
)
def test_generate_fallback_finds_connected_eth_with_mac(self):
"""generate_fallback_config finds any connected device with a mac."""
write_file(os.path.join(self.sysdir, "eth0", "carrier"), "1")
write_file(os.path.join(self.sysdir, "eth1", "carrier"), "1")
mac = "aa:bb:cc:aa:bb:cc"
write_file(os.path.join(self.sysdir, "eth1", "address"), mac)
expected = {
"ethernets": {
"eth1": {
"match": {"macaddress": mac},
"dhcp4": True,
"dhcp6": True,
"set-name": "eth1",
}
},
"version": 2,
}
assert expected == net.generate_fallback_config()
def test_generate_fallback_finds_dormant_eth_with_mac(self):
"""generate_fallback_config finds any dormant device with a mac."""
write_file(os.path.join(self.sysdir, "eth0", "dormant"), "1")
mac = "aa:bb:cc:aa:bb:cc"
write_file(os.path.join(self.sysdir, "eth0", "address"), mac)
expected = {
"ethernets": {
"eth0": {
"match": {"macaddress": mac},
"dhcp4": True,
"dhcp6": True,
"set-name": "eth0",
}
},
"version": 2,
}
assert expected == net.generate_fallback_config()
def test_generate_fallback_finds_eth_by_operstate(self):
"""generate_fallback_config finds any dormant device with a mac."""
mac = "aa:bb:cc:aa:bb:cc"
write_file(os.path.join(self.sysdir, "eth0", "address"), mac)
expected = {
"ethernets": {
"eth0": {
"dhcp4": True,
"dhcp6": True,
"match": {"macaddress": mac},
"set-name": "eth0",
}
},
"version": 2,
}
valid_operstates = ["dormant", "down", "lowerlayerdown", "unknown"]
for state in valid_operstates:
write_file(os.path.join(self.sysdir, "eth0", "operstate"), state)
assert expected == net.generate_fallback_config()
write_file(os.path.join(self.sysdir, "eth0", "operstate"), "noworky")
assert net.generate_fallback_config() is None
def test_generate_fallback_config_skips_veth(self):
"""generate_fallback_config will skip any veth interfaces."""
# A connected veth which gets ignored
write_file(os.path.join(self.sysdir, "veth0", "carrier"), "1")
assert net.generate_fallback_config() is None
def test_generate_fallback_config_skips_bridges(self):
"""generate_fallback_config will skip any bridges interfaces."""
# A connected veth which gets ignored
write_file(os.path.join(self.sysdir, "eth0", "carrier"), "1")
mac = "aa:bb:cc:aa:bb:cc"
write_file(os.path.join(self.sysdir, "eth0", "address"), mac)
ensure_file(os.path.join(self.sysdir, "eth0", "bridge"))
assert net.generate_fallback_config() is None
def test_generate_fallback_config_skips_bonds(self):
"""generate_fallback_config will skip any bonded interfaces."""
# A connected veth which gets ignored
write_file(os.path.join(self.sysdir, "eth0", "carrier"), "1")
mac = "aa:bb:cc:aa:bb:cc"
write_file(os.path.join(self.sysdir, "eth0", "address"), mac)
ensure_file(os.path.join(self.sysdir, "eth0", "bonding"))
assert net.generate_fallback_config() is None
@mock.patch("cloudinit.net.is_netfail_master")
def test_generate_fallback_config_skips_netfail_devs(
self, m_is_netfail_master
):
"""gen_fallback_config ignores netfail primary,sby no mac on master."""
mac = "aa:bb:cc:aa:bb:cc" # netfailover devs share the same mac
for iface in ["ens3", "ens3sby", "enP0s1f3"]:
write_file(os.path.join(self.sysdir, iface, "carrier"), "1")
write_file(
os.path.join(self.sysdir, iface, "addr_assign_type"), "0"
)
write_file(os.path.join(self.sysdir, iface, "address"), mac)
def is_netfail(iface, _driver=None):
# ens3 is the master
if iface == "ens3":
return False
return True
self.m_is_netfail.side_effect = is_netfail
def is_netfail_master(iface, _driver=None):
# ens3 is the master
if iface == "ens3":
return True
return False
m_is_netfail_master.side_effect = is_netfail_master
expected = {
"ethernets": {
"ens3": {
"dhcp4": True,
"dhcp6": True,
"match": {"name": "ens3"},
"set-name": "ens3",
}
},
"version": 2,
}
result = net.generate_fallback_config()
assert expected == result
class TestNetFindFallBackNic:
@pytest.fixture(autouse=True)
def fixtures(self, mocker, tmp_path):
self.sysdir = str(tmp_path) + "/"
mocker.patch(
"cloudinit.net.get_sys_class_path", return_value=self.sysdir
)
mocker.patch(
"cloudinit.net.util.is_container",
return_value=False,
)
mocker.patch("cloudinit.net.util.udevadm_settle")
def test_generate_fallback_finds_first_connected_eth_with_mac(self):
"""find_fallback_nic finds any connected device with a mac."""
write_file(os.path.join(self.sysdir, "eth0", "carrier"), "1")
write_file(os.path.join(self.sysdir, "eth1", "carrier"), "1")
mac = "aa:bb:cc:aa:bb:cc"
write_file(os.path.join(self.sysdir, "eth1", "address"), mac)
assert "eth1" == net.find_fallback_nic()
class TestNetFindCandidateNics:
def create_fake_interface(
self,
name: str,
address: Optional[str] = "aa:bb:cc:aa:bb:cc",
carrier: bool = True,
bonding: bool = False,
dormant: bool = False,
driver: str = "fakenic",
bridge: bool = False,
failover_standby: bool = False,
operstate: Optional[str] = None,
renamed: bool = True,
):
interface_path = self.sys_path / name
interface_path.mkdir(parents=True)
if address is not None:
(interface_path / "address").write_text(str(address))
if carrier:
(interface_path / "carrier").write_text("1")
else:
(interface_path / "carrier").write_text("0")
if bonding:
(interface_path / "bonding").write_text("1")
if bridge:
(interface_path / "bridge").write_text("1")
if dormant:
(interface_path / "dormant").write_text("1")
else:
(interface_path / "dormant").write_text("0")
if operstate:
(interface_path / "operstate").write_text(operstate)
device_path = interface_path / "device"
device_path.mkdir()
if failover_standby:
driver = "virtio_net"
(interface_path / "master").symlink_to(os.path.join("..", name))
(device_path / "features").write_text("1" * 64)
if driver:
(device_path / driver).write_text(driver)
(device_path / "driver").symlink_to(driver)
if renamed:
(interface_path / "name_assign_type").write_text("4")
else:
(interface_path / "name_assign_type").write_text("0")
@pytest.fixture(autouse=True)
def setup(self, monkeypatch, tmpdir):
"""Fixture to set up the test environment."""
self.sys_path = Path(tmpdir) / "sys"
monkeypatch.setattr(
net, "get_sys_class_path", lambda: str(self.sys_path) + "/"
)
monkeypatch.setattr(
net.util,
"is_container",
lambda: False,
)
self.m_settle = mock.Mock(return_value=None)
self.m_cmdline = mock.Mock(return_value="")
monkeypatch.setattr("cloudinit.net.util.udevadm_settle", self.m_settle)
monkeypatch.setattr("cloudinit.net.util.get_cmdline", self.m_cmdline)
def test_ignored_interfaces(self):
self.create_fake_interface(
name="ethNoCarrierDormantOperstateIgnored",
carrier=False,
)
self.create_fake_interface(
name="ethWithoutMacIgnored",
address=None,
)
self.create_fake_interface(name="vethIgnored", carrier=1)
self.create_fake_interface(
name="bondIgnored",
bonding=True,
)
self.create_fake_interface(
name="bridgeIgnored",
bridge=True,
)
self.create_fake_interface(
name="failOverIgnored",
failover_standby=True,
)
self.create_fake_interface(
name="TestingOperStateIgnored",
carrier=False,
operstate="testing",
)
self.create_fake_interface(
name="hv",
driver="hv_netvsc",
address="00:11:22:00:00:f0",
)
self.create_fake_interface(
name="hv_vf_mlx4",
driver="mlx4_core",
address="00:11:22:00:00:f0",
)
self.create_fake_interface(
name="hv_vf_mlx5",
driver="mlx5_core",
address="00:11:22:00:00:f0",
)
self.create_fake_interface(
name="hv_vf_mana",
driver="mana",
address="00:11:22:00:00:f0",
)
assert net.find_candidate_nics_on_linux() == ["hv"]
def test_carrier_preferred(self):
self.create_fake_interface(name="eth0", carrier=False, dormant=True)
self.create_fake_interface(name="eth1")
assert net.find_candidate_nics_on_linux() == ["eth1", "eth0"]
def test_natural_sort(self):
self.create_fake_interface(name="a")
self.create_fake_interface(name="a1")
self.create_fake_interface(name="a2")
self.create_fake_interface(name="a10")
self.create_fake_interface(name="b1")
assert net.find_candidate_nics_on_linux() == [
"a",
"a1",
"a2",
"a10",
"b1",
]
def test_eth0_preferred_with_carrier(self):
self.create_fake_interface(name="abc0")
self.create_fake_interface(name="eth0")
assert net.find_candidate_nics_on_linux() == ["eth0", "abc0"]
@pytest.mark.parametrize("dormant", [False, True])
@pytest.mark.parametrize(
"operstate", ["dormant", "down", "lowerlayerdown", "unknown"]
)
def test_eth0_preferred_after_carrier(self, dormant, operstate):
self.create_fake_interface(name="xeth10")
self.create_fake_interface(name="eth", carrier=False, dormant=True)
self.create_fake_interface(
name="eth0",
carrier=False,
dormant=dormant,
operstate=operstate,
)
self.create_fake_interface(name="eth1", carrier=False, dormant=True)
self.create_fake_interface(
name="eth2",
carrier=False,
operstate=operstate,
)
assert net.find_candidate_nics_on_linux() == [
"xeth10",
"eth0",
"eth",
"eth1",
"eth2",
]
def test_no_nics(self):
assert net.find_candidate_nics_on_linux() == []
def test_udevadm_settle_called_for_predictable_names(self):
self.create_fake_interface(name="eth0", renamed=False)
result = net.find_candidate_nics_on_linux()
assert result == ["eth0"]
self.m_settle.assert_called_once()
def test_udevadm_settle_not_called_for_unpredictable_names(self):
self.create_fake_interface(name="eth0", renamed=False)
self.m_cmdline.return_value = "net.ifnames=0 biosdevname=0"
result = net.find_candidate_nics_on_linux()
assert result == ["eth0"]
self.m_settle.assert_not_called()
def test_udevadm_settle_not_called_for_renamed_interface(self):
self.create_fake_interface(name="eth0", renamed=True)
result = net.find_candidate_nics_on_linux()
assert result == ["eth0"]
self.m_settle.assert_not_called()
def test_udevadm_settle_failure_handled_gracefully(self, caplog):
self.create_fake_interface(name="eth0", renamed=False)
self.m_settle.side_effect = subp.ProcessExecutionError(
cmd="xcmd", stderr="xstderr", stdout="xstdout", exit_code=1
)
with caplog.at_level(logging.WARNING):
result = net.find_candidate_nics_on_linux()
assert (
"udevadm failed to settle: cmd='xcmd' "
"stderr='xstderr' stdout='xstdout' exit_code=1" in caplog.text
)
assert result == ["eth0"]
self.m_settle.assert_called_once()
class TestGetDeviceList:
@pytest.fixture(autouse=True)
def fixtures(self, mocker, tmp_path):
self.sysdir = str(tmp_path) + "/"
self.m_sys_path = mocker.patch(
"cloudinit.net.get_sys_class_path", return_value=self.sysdir
)
def test_get_devicelist_raise_oserror(self):
"""get_devicelist raise any non-ENOENT OSerror."""
error = OSError("Can not do it")
error.errno = errno.EPERM # Set non-ENOENT
self.m_sys_path.side_effect = error
with pytest.raises(OSError, match="Can not do it"):
net.get_devicelist()
def test_get_devicelist_empty_without_sys_net(self):
"""get_devicelist returns empty list when missing SYS_CLASS_NET."""
self.m_sys_path.return_value = "idontexist"
assert [] == net.get_devicelist()
def test_get_devicelist_empty_with_no_devices_in_sys_net(self):
"""get_devicelist returns empty directoty listing for SYS_CLASS_NET."""
assert [] == net.get_devicelist()
def test_get_devicelist_lists_any_subdirectories_in_sys_net(self):
"""get_devicelist returns a directory listing for SYS_CLASS_NET."""
write_file(os.path.join(self.sysdir, "eth0", "operstate"), "up")
write_file(os.path.join(self.sysdir, "eth1", "operstate"), "up")
assert_count_equal(["eth0", "eth1"], net.get_devicelist())
@mock.patch(
"cloudinit.net.is_openvswitch_internal_interface",
mock.Mock(return_value=False),
)
class TestGetInterfaceMAC:
@pytest.fixture(autouse=True)
def fixtures(self, mocker, tmp_path):
self.sysdir = str(tmp_path) + "/"
self.m_sys_path = mocker.patch(
"cloudinit.net.get_sys_class_path", return_value=self.sysdir
)
def test_get_interface_mac_false_with_no_mac(self):
"""get_device_list returns False when no mac is reported."""
ensure_file(os.path.join(self.sysdir, "eth0", "bonding"))
mac_path = os.path.join(self.sysdir, "eth0", "address")
assert not os.path.exists(mac_path)
assert net.get_interface_mac("eth0") is False
def test_get_interface_mac(self):
"""get_interfaces returns the mac from SYS_CLASS_NET/dev/address."""
mac = "aa:bb:cc:aa:bb:cc"
write_file(os.path.join(self.sysdir, "eth1", "address"), mac)
assert mac == net.get_interface_mac("eth1")
def test_get_interface_mac_grabs_bonding_address(self):
"""get_interfaces returns the source device mac for bonded devices."""
source_dev_mac = "aa:bb:cc:aa:bb:cc"
bonded_mac = "dd:ee:ff:dd:ee:ff"
write_file(os.path.join(self.sysdir, "eth1", "address"), bonded_mac)
write_file(
os.path.join(self.sysdir, "eth1", "bonding_slave", "perm_hwaddr"),
source_dev_mac,
)
assert source_dev_mac == net.get_interface_mac("eth1")
def test_get_interfaces_empty_list_without_sys_net(self):
"""get_interfaces returns an empty list when missing SYS_CLASS_NET."""
self.m_sys_path.return_value = "idontexist"
assert [] == net.get_interfaces()
def test_get_interfaces_by_mac_skips_empty_mac(self):
"""Ignore 00:00:00:00:00:00 addresses from get_interfaces_by_mac."""
empty_mac = "00:00:00:00:00:00"
mac = "aa:bb:cc:aa:bb:cc"
write_file(os.path.join(self.sysdir, "eth1", "address"), empty_mac)
write_file(os.path.join(self.sysdir, "eth1", "addr_assign_type"), "0")
write_file(os.path.join(self.sysdir, "eth2", "addr_assign_type"), "0")
write_file(os.path.join(self.sysdir, "eth2", "address"), mac)
expected = [("eth2", "aa:bb:cc:aa:bb:cc", None, None)]
assert expected == net.get_interfaces()
def test_get_interfaces_by_mac_skips_missing_mac(self):
"""Ignore interfaces without an address from get_interfaces_by_mac."""
write_file(os.path.join(self.sysdir, "eth1", "addr_assign_type"), "0")
address_path = os.path.join(self.sysdir, "eth1", "address")
assert not os.path.exists(address_path)
mac = "aa:bb:cc:aa:bb:cc"
write_file(os.path.join(self.sysdir, "eth2", "addr_assign_type"), "0")
write_file(os.path.join(self.sysdir, "eth2", "address"), mac)
expected = [("eth2", "aa:bb:cc:aa:bb:cc", None, None)]
assert expected == net.get_interfaces()
def test_get_interfaces_by_mac_skips_master_devs(self):
"""Ignore interfaces with a master device which would have dup mac."""
mac1 = mac2 = "aa:bb:cc:aa:bb:cc"
write_file(os.path.join(self.sysdir, "eth1", "addr_assign_type"), "0")
write_file(os.path.join(self.sysdir, "eth1", "address"), mac1)
write_file(os.path.join(self.sysdir, "eth1", "master"), "blah")
write_file(os.path.join(self.sysdir, "eth2", "addr_assign_type"), "0")
write_file(os.path.join(self.sysdir, "eth2", "address"), mac2)
expected = [("eth2", mac2, None, None)]
assert expected == net.get_interfaces()
@mock.patch("cloudinit.net.is_netfailover")
def test_get_interfaces_by_mac_skips_netfailvoer(self, m_netfail):
"""Ignore interfaces if netfailover primary or standby."""
mac = "aa:bb:cc:aa:bb:cc" # netfailover devs share the same mac
for iface in ["ens3", "ens3sby", "enP0s1f3"]:
write_file(
os.path.join(self.sysdir, iface, "addr_assign_type"), "0"
)
write_file(os.path.join(self.sysdir, iface, "address"), mac)
def is_netfail(iface, _driver=None):
# ens3 is the master
if iface == "ens3":
return False
else:
return True
m_netfail.side_effect = is_netfail
expected = [("ens3", mac, None, None)]
assert expected == net.get_interfaces()
def test_get_interfaces_does_not_skip_phys_members_of_bridges_and_bonds(
self,
):
bridge_mac = "aa:bb:cc:aa:bb:cc"
bond_mac = "cc:bb:aa:cc:bb:aa"
ovs_mac = "bb:cc:aa:bb:cc:aa"
write_file(os.path.join(self.sysdir, "br0", "address"), bridge_mac)
write_file(os.path.join(self.sysdir, "br0", "bridge"), "")
write_file(os.path.join(self.sysdir, "bond0", "address"), bond_mac)
write_file(os.path.join(self.sysdir, "bond0", "bonding"), "")
write_file(os.path.join(self.sysdir, "ovs-system", "address"), ovs_mac)
write_file(os.path.join(self.sysdir, "eth1", "address"), bridge_mac)
os.symlink("../br0", os.path.join(self.sysdir, "eth1", "master"))
write_file(os.path.join(self.sysdir, "eth2", "address"), bond_mac)
os.symlink("../bond0", os.path.join(self.sysdir, "eth2", "master"))
write_file(os.path.join(self.sysdir, "eth3", "address"), ovs_mac)
os.symlink(
"../ovs-system", os.path.join(self.sysdir, "eth3", "master")
)
os.symlink(
"../ovs-system",
os.path.join(self.sysdir, "eth3", "upper_ovs-system"),
)
interface_names = [interface[0] for interface in net.get_interfaces()]
assert ["eth1", "eth2", "eth3", "ovs-system"] == sorted(
interface_names
)
class TestInterfaceHasOwnMAC:
@pytest.fixture(autouse=True)
def fixtures(self, mocker, tmp_path):
self.sysdir = str(tmp_path) + "/"
mocker.patch(
"cloudinit.net.get_sys_class_path", return_value=self.sysdir
)
def test_interface_has_own_mac_false_when_stolen(self):
"""Return False from interface_has_own_mac when address is stolen."""
write_file(os.path.join(self.sysdir, "eth1", "addr_assign_type"), "2")
assert net.interface_has_own_mac("eth1") is False
def test_interface_has_own_mac_true_when_not_stolen(self):
"""Return False from interface_has_own_mac when mac isn't stolen."""
valid_assign_types = ["0", "1", "3"]
assign_path = os.path.join(self.sysdir, "eth1", "addr_assign_type")
for _type in valid_assign_types:
write_file(assign_path, _type)
assert net.interface_has_own_mac("eth1") is True
def test_interface_has_own_mac_strict_errors_on_absent_assign_type(self):
"""When addr_assign_type is absent, interface_has_own_mac errors."""
with pytest.raises(ValueError):
net.interface_has_own_mac("eth1", strict=True)
@mock.patch("cloudinit.net.subp.subp")
@pytest.mark.usefixtures("disable_netdev_info")
class TestEphemeralIPV4Network:
@pytest.fixture(autouse=True)
def fixtures(self, mocker, tmp_path):
self.sysdir = str(tmp_path) + "/"
mocker.patch(
"cloudinit.net.get_sys_class_path", return_value=self.sysdir
)
def test_ephemeral_ipv4_network_errors_on_missing_params(self, m_subp):
"""No required params for EphemeralIPv4Network can be None."""
required_params = {
"interface": "eth0",
"ip": "192.168.2.2",
"prefix_or_mask": "255.255.255.0",
"broadcast": "192.168.2.255",
}
for key in required_params.keys():
params = copy.deepcopy(required_params)
params[key] = None
with pytest.raises(ValueError, match="Cannot init network on"):
EphemeralIPv4Network(
MockDistro(),
interface_addrs_before_dhcp=example_netdev,
**params,
)
assert 0 == m_subp.call_count
def test_ephemeral_ipv4_network_errors_invalid_mask_prefix(self, m_subp):
"""Raise an error when prefix_or_mask is not a netmask or prefix."""
params = {
"interface": "eth0",
"ip": "192.168.2.2",
"broadcast": "192.168.2.255",
"interface_addrs_before_dhcp": example_netdev,
}
invalid_masks = ("invalid", "invalid.", "123.123.123")
for error_val in invalid_masks:
params["prefix_or_mask"] = error_val
with pytest.raises(
ValueError,
match="Cannot setup network, invalid prefix or netmask: ",
):
with EphemeralIPv4Network(MockDistro(), **params):
pass
assert 0 == m_subp.call_count
def test_ephemeral_ipv4_network_performs_teardown(self, m_subp):
"""EphemeralIPv4Network performs teardown on the device if setup."""
expected_setup_calls = [
mock.call(
[
"ip",
"-family",
"inet",
"addr",
"add",
"192.168.2.2/24",
"broadcast",
"192.168.2.255",
"dev",
"eth0",
],
),
]
expected_teardown_calls = [
mock.call(
[
"ip",
"-family",
"inet",
"addr",
"del",
"192.168.2.2/24",
"dev",
"eth0",
],
),
]
params = {
"interface": "eth0",
"ip": "192.168.2.2",
"prefix_or_mask": "255.255.255.0",
"broadcast": "192.168.2.255",
"interface_addrs_before_dhcp": example_netdev,
}
with EphemeralIPv4Network(MockDistro(), **params):
assert expected_setup_calls == m_subp.call_args_list
m_subp.assert_has_calls(expected_teardown_calls)
def test_teardown_on_enter_exception(self, m_subp):
"""Ensure ephemeral teardown happens.
Even though we're using a context manager, we need to handle any
exceptions raised in __enter__ manually and do the appropriate
teardown.
"""
def side_effect(args, **kwargs):
if "append" in args and "3.3.3.3/32" in args:
raise subp.ProcessExecutionError("oh no!")
m_subp.side_effect = side_effect
with pytest.raises(subp.ProcessExecutionError):
with EphemeralIPv4Network(
MockDistro(),
interface="eth0",
ip="1.1.1.1",
prefix_or_mask="255.255.255.0",
broadcast="1.1.1.255",
interface_addrs_before_dhcp=example_netdev,
static_routes=[
("2.2.2.2/32", "9.9.9.9"),
("3.3.3.3/32", "8.8.8.8"),
],
):
pass
expected_teardown_calls = [
mock.call(
[
"ip",
"-4",
"route",
"del",
"2.2.2.2/32",
"via",
"9.9.9.9",
"dev",
"eth0",
],
),
mock.call(
[
"ip",
"-family",
"inet",
"addr",
"del",
"1.1.1.1/24",
"dev",
"eth0",
],
),
]
for teardown in expected_teardown_calls:
assert teardown in m_subp.call_args_list
def test_ephemeral_ipv4_network_noop_when_configured(self, m_subp, caplog):
"""EphemeralIPv4Network handles exception when address is setup.
It performs no cleanup as the interface was already setup.
"""
params = {
"interface": "eth0",
"ip": "10.85.130.116",
"prefix_or_mask": "255.255.255.0",
"broadcast": "192.168.2.255",
"interface_addrs_before_dhcp": example_netdev,
}
m_subp.side_effect = ProcessExecutionError(
"", "RTNETLINK answers: File exists", 2
)
expected_calls = []
with EphemeralIPv4Network(MockDistro(), **params):
pass
assert expected_calls == m_subp.call_args_list
assert "Skip bringing up network link" in caplog.text
assert "Skip adding ip address" in caplog.text
def test_ephemeral_ipv4_network_with_prefix(self, m_subp):
"""EphemeralIPv4Network takes a valid prefix to setup the network."""
params = {
"interface": "eth0",
"ip": "192.168.2.2",
"prefix_or_mask": "24",
"broadcast": "192.168.2.255",
"interface_addrs_before_dhcp": example_netdev,
}
for prefix_val in ["24", 16]: # prefix can be int or string
params["prefix_or_mask"] = prefix_val
with EphemeralIPv4Network(MockDistro(), **params):
pass
m_subp.assert_has_calls(
[
mock.call(
[
"ip",
"-family",
"inet",
"addr",
"add",
"192.168.2.2/24",
"broadcast",
"192.168.2.255",
"dev",
"eth0",
],
)
]
)
m_subp.assert_has_calls(
[
mock.call(
[
"ip",
"-family",
"inet",
"addr",
"add",
"192.168.2.2/16",
"broadcast",
"192.168.2.255",
"dev",
"eth0",
],
)
]
)
def test_ephemeral_ipv4_network_with_new_default_route(self, m_subp):
"""Add the route when router is set and no default route exists."""
params = {
"interface": "eth0",
"ip": "192.168.2.2",
"prefix_or_mask": "255.255.255.0",
"broadcast": "192.168.2.255",
"router": "192.168.2.1",
"interface_addrs_before_dhcp": example_netdev,
}
# Empty response from ip route gw check
m_subp.return_value = subp.SubpResult("", "")
expected_setup_calls = [
mock.call(
[
"ip",
"-family",
"inet",
"addr",
"add",
"192.168.2.2/24",
"broadcast",
"192.168.2.255",
"dev",
"eth0",
],
),
mock.call(["ip", "route", "show", "0.0.0.0/0"]),
mock.call(
[
"ip",
"-4",
"route",
"replace",
"192.168.2.1",
"dev",
"eth0",
"src",
"192.168.2.2",
],
),
mock.call(
[
"ip",
"-4",
"route",
"replace",
"default",
"via",
"192.168.2.1",
"dev",
"eth0",
],
),
]
expected_teardown_calls = [
mock.call(
["ip", "-4", "route", "del", "default", "dev", "eth0"],
),
mock.call(
[
"ip",
"-4",
"route",
"del",
"192.168.2.1",
"dev",
"eth0",
"src",
"192.168.2.2",
],
),
]
with EphemeralIPv4Network(MockDistro(), **params):
assert expected_setup_calls == m_subp.call_args_list
m_subp.assert_has_calls(expected_teardown_calls)
def test_ephemeral_ipv4_network_with_rfc3442_static_routes(self, m_subp):
params = {
"interface": "eth0",
"ip": "192.168.2.2",
"prefix_or_mask": "255.255.255.255",
"broadcast": "192.168.2.255",
"static_routes": [
("192.168.2.1/32", "0.0.0.0"),
("169.254.169.254/32", "192.168.2.1"),
("0.0.0.0/0", "192.168.2.1"),
],
"router": "192.168.2.1",
"interface_addrs_before_dhcp": example_netdev,
}
expected_setup_calls = [
mock.call(
[
"ip",
"-family",
"inet",
"addr",
"add",
"192.168.2.2/32",
"broadcast",
"192.168.2.255",
"dev",
"eth0",
],
),
mock.call(
[
"ip",
"-4",
"route",
"append",
"192.168.2.1/32",
"dev",
"eth0",
],
),
mock.call(
[
"ip",
"-4",
"route",
"append",
"169.254.169.254/32",
"via",
"192.168.2.1",
"dev",
"eth0",
],
),
mock.call(
[
"ip",
"-4",
"route",
"append",
"0.0.0.0/0",
"via",
"192.168.2.1",
"dev",
"eth0",
],
),
]
expected_teardown_calls = [
mock.call(
[
"ip",
"-4",
"route",
"del",
"0.0.0.0/0",
"via",
"192.168.2.1",
"dev",
"eth0",
],
),
mock.call(
[
"ip",
"-4",
"route",
"del",
"169.254.169.254/32",
"via",
"192.168.2.1",
"dev",
"eth0",
],
),
mock.call(
["ip", "-4", "route", "del", "192.168.2.1/32", "dev", "eth0"],
),
mock.call(
[
"ip",
"-family",
"inet",
"addr",
"del",
"192.168.2.2/32",
"dev",
"eth0",
],
),
]
with EphemeralIPv4Network(MockDistro(), **params):
assert expected_setup_calls == m_subp.call_args_list
m_subp.assert_has_calls(expected_setup_calls + expected_teardown_calls)
class TestEphemeralIPV6Network:
@mock.patch("cloudinit.net.read_sys_net")
@mock.patch("cloudinit.net.subp.subp")
def test_ephemeral_ipv6_network_performs_setup(self, m_subp, _):
"""EphemeralIPv4Network performs teardown on the device if setup."""
expected_setup_calls = [
mock.call(
["ip", "link", "set", "dev", "eth0", "up"],
),
]
with EphemeralIPv6Network(MockDistro(), interface="eth0"):
assert expected_setup_calls == m_subp.call_args_list
def _mk_v1_phys(mac, name, driver, device_id):
v1_cfg = {"type": "physical", "name": name, "mac_address": mac}
params = {}
if driver:
params.update({"driver": driver})
if device_id:
params.update({"device_id": device_id})
if params:
v1_cfg.update({"params": params})
return v1_cfg
def _mk_v2_phys(mac, name, driver=None, device_id=None):
v2_cfg = {"set-name": name, "match": {"macaddress": mac}}
if driver:
v2_cfg["match"].update({"driver": driver})
if device_id:
v2_cfg["match"].update({"device_id": device_id})
return v2_cfg
class TestExtractPhysdevs:
@pytest.fixture(autouse=True)
def fixtures(self, mocker):
self.m_driver = mocker.patch("cloudinit.net.device_driver")
self.m_devid = mocker.patch(
"cloudinit.net.device_devid",
)
def test_extract_physdevs_looks_up_driver_v1(self):
driver = "virtio"
self.m_driver.return_value = driver
physdevs = [
["aa:bb:cc:dd:ee:ff", "eth0", None, "0x1000"],
]
netcfg = {
"version": 1,
"config": [_mk_v1_phys(*args) for args in physdevs],
}
# insert the driver value for verification
physdevs[0][2] = driver
assert sorted(physdevs) == sorted(net.extract_physdevs(netcfg))
self.m_driver.assert_called_with("eth0")
def test_extract_physdevs_looks_up_driver_v2(self):
driver = "virtio"
self.m_driver.return_value = driver
physdevs = [
["aa:bb:cc:dd:ee:ff", "eth0", None, "0x1000"],
]
netcfg = {
"version": 2,
"ethernets": {args[1]: _mk_v2_phys(*args) for args in physdevs},
}
# insert the driver value for verification
physdevs[0][2] = driver
assert sorted(physdevs) == sorted(net.extract_physdevs(netcfg))
self.m_driver.assert_called_with("eth0")
def test_extract_physdevs_looks_up_devid_v1(self):
devid = "0x1000"
self.m_devid.return_value = devid
physdevs = [
["aa:bb:cc:dd:ee:ff", "eth0", "virtio", None],
]
netcfg = {
"version": 1,
"config": [_mk_v1_phys(*args) for args in physdevs],
}
# insert the driver value for verification
physdevs[0][3] = devid
assert sorted(physdevs) == sorted(net.extract_physdevs(netcfg))
self.m_devid.assert_called_with("eth0")
def test_extract_physdevs_looks_up_devid_v2(self):
devid = "0x1000"
self.m_devid.return_value = devid
physdevs = [
["aa:bb:cc:dd:ee:ff", "eth0", "virtio", None],
]
netcfg = {
"version": 2,
"ethernets": {args[1]: _mk_v2_phys(*args) for args in physdevs},
}
# insert the driver value for verification
physdevs[0][3] = devid
assert sorted(physdevs) == sorted(net.extract_physdevs(netcfg))
self.m_devid.assert_called_with("eth0")
def test_get_v1_type_physical(self):
physdevs = [
["aa:bb:cc:dd:ee:ff", "eth0", "virtio", "0x1000"],
["00:11:22:33:44:55", "ens3", "e1000", "0x1643"],
["09:87:65:43:21:10", "ens0p1", "mlx4_core", "0:0:1000"],
]
netcfg = {
"version": 1,
"config": [_mk_v1_phys(*args) for args in physdevs],
}
assert sorted(physdevs) == sorted(net.extract_physdevs(netcfg))
def test_get_v2_type_physical(self):
physdevs = [
["aa:bb:cc:dd:ee:ff", "eth0", "virtio", "0x1000"],
["00:11:22:33:44:55", "ens3", "e1000", "0x1643"],
["09:87:65:43:21:10", "ens0p1", "mlx4_core", "0:0:1000"],
]
netcfg = {
"version": 2,
"ethernets": {args[1]: _mk_v2_phys(*args) for args in physdevs},
}
assert sorted(physdevs) == sorted(net.extract_physdevs(netcfg))
def test_get_v2_type_physical_skips_if_no_set_name(self):
netcfg = {
"version": 2,
"ethernets": {
"ens3": {
"match": {"macaddress": "00:11:22:33:44:55"},
}
},
}
assert [] == net.extract_physdevs(netcfg)
def test_runtime_error_on_unknown_netcfg_version(self):
with pytest.raises(RuntimeError):
net.extract_physdevs({"version": 3, "awesome_config": []})
class TestNetFailOver:
@pytest.fixture(autouse=True)
def setup(self, mocker):
mocker.patch("cloudinit.net.util")
self.device_driver = mocker.patch("cloudinit.net.device_driver")
self.read_sys_net = mocker.patch("cloudinit.net.read_sys_net")
def test_get_dev_features(self):
devname = random_string()
features = random_string()
self.read_sys_net.return_value = features
assert features == net.get_dev_features(devname)
assert 1 == self.read_sys_net.call_count
self.read_sys_net.assert_called_once_with(devname, "device/features")
def test_get_dev_features_none_returns_empty_string(self):
devname = random_string()
self.read_sys_net.side_effect = Exception("error")
assert "" == net.get_dev_features(devname)
assert 1 == self.read_sys_net.call_count
self.read_sys_net.assert_called_once_with(devname, "device/features")
@mock.patch("cloudinit.net.get_dev_features")
def test_has_netfail_standby_feature(self, m_dev_features):
devname = random_string()
standby_features = ("0" * 62) + "1" + "0"
m_dev_features.return_value = standby_features
assert net.has_netfail_standby_feature(devname)
@mock.patch("cloudinit.net.get_dev_features")
def test_has_netfail_standby_feature_short_is_false(self, m_dev_features):
devname = random_string()
standby_features = random_string()
m_dev_features.return_value = standby_features
assert not net.has_netfail_standby_feature(devname)
@mock.patch("cloudinit.net.get_dev_features")
def test_has_netfail_standby_feature_not_present_is_false(
self, m_dev_features
):
devname = random_string()
standby_features = "0" * 64
m_dev_features.return_value = standby_features
assert not net.has_netfail_standby_feature(devname)
@mock.patch("cloudinit.net.get_dev_features")
def test_has_netfail_standby_feature_no_features_is_false(
self, m_dev_features
):
devname = random_string()
standby_features = None
m_dev_features.return_value = standby_features
assert not net.has_netfail_standby_feature(devname)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
def test_is_netfail_master(self, m_exists, m_standby):
devname = random_string()
driver = "virtio_net"
m_exists.return_value = False # no master sysfs attr
m_standby.return_value = True # has standby feature flag
assert net.is_netfail_master(devname, driver)
@mock.patch("cloudinit.net.sys_dev_path")
def test_is_netfail_master_checks_master_attr(self, m_sysdev):
devname = random_string()
driver = "virtio_net"
m_sysdev.return_value = random_string()
assert not net.is_netfail_master(devname, driver)
assert 1 == m_sysdev.call_count
m_sysdev.assert_called_once_with(devname, path="master")
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
def test_is_netfail_master_wrong_driver(self, m_exists, m_standby):
devname = random_string()
driver = random_string()
assert not net.is_netfail_master(devname, driver)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
def test_is_netfail_master_has_master_attr(self, m_exists, m_standby):
devname = random_string()
driver = "virtio_net"
m_exists.return_value = True # has master sysfs attr
assert not net.is_netfail_master(devname, driver)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
def test_is_netfail_master_no_standby_feat(self, m_exists, m_standby):
devname = random_string()
driver = "virtio_net"
m_exists.return_value = False # no master sysfs attr
m_standby.return_value = False # no standby feature flag
assert not net.is_netfail_master(devname, driver)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
@mock.patch("cloudinit.net.sys_dev_path")
def test_is_netfail_primary(self, m_sysdev, m_exists, m_standby):
devname = random_string()
driver = random_string() # device not virtio_net
master_devname = random_string()
m_sysdev.return_value = "%s/%s" % (
random_string(),
master_devname,
)
m_exists.return_value = True # has master sysfs attr
self.device_driver.return_value = "virtio_net" # master virtio_net
m_standby.return_value = True # has standby feature flag
assert net.is_netfail_primary(devname, driver)
self.device_driver.assert_called_once_with(master_devname)
assert 1 == m_standby.call_count
m_standby.assert_called_once_with(master_devname)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
@mock.patch("cloudinit.net.sys_dev_path")
def test_is_netfail_primary_wrong_driver(
self, m_sysdev, m_exists, m_standby
):
devname = random_string()
driver = "virtio_net"
assert not net.is_netfail_primary(devname, driver)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
@mock.patch("cloudinit.net.sys_dev_path")
def test_is_netfail_primary_no_master(self, m_sysdev, m_exists, m_standby):
devname = random_string()
driver = random_string() # device not virtio_net
m_exists.return_value = False # no master sysfs attr
assert not net.is_netfail_primary(devname, driver)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
@mock.patch("cloudinit.net.sys_dev_path")
def test_is_netfail_primary_bad_master(
self, m_sysdev, m_exists, m_standby
):
devname = random_string()
driver = random_string() # device not virtio_net
master_devname = random_string()
m_sysdev.return_value = "%s/%s" % (
random_string(),
master_devname,
)
m_exists.return_value = True # has master sysfs attr
self.device_driver.return_value = "XXXX" # master not virtio_net
assert not net.is_netfail_primary(devname, driver)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
@mock.patch("cloudinit.net.sys_dev_path")
def test_is_netfail_primary_no_standby(
self, m_sysdev, m_exists, m_standby
):
devname = random_string()
driver = random_string() # device not virtio_net
master_devname = random_string()
m_sysdev.return_value = "%s/%s" % (
random_string(),
master_devname,
)
m_exists.return_value = True # has master sysfs attr
self.device_driver.return_value = "virtio_net" # master virtio_net
m_standby.return_value = False # master has no standby feature flag
assert not net.is_netfail_primary(devname, driver)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
def test_is_netfail_standby(self, m_exists, m_standby):
devname = random_string()
driver = "virtio_net"
m_exists.return_value = True # has master sysfs attr
m_standby.return_value = True # has standby feature flag
assert net.is_netfail_standby(devname, driver)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
def test_is_netfail_standby_wrong_driver(self, m_exists, m_standby):
devname = random_string()
driver = random_string()
assert not net.is_netfail_standby(devname, driver)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
def test_is_netfail_standby_no_master(self, m_exists, m_standby):
devname = random_string()
driver = "virtio_net"
m_exists.return_value = False # has master sysfs attr
assert not net.is_netfail_standby(devname, driver)
@mock.patch("cloudinit.net.has_netfail_standby_feature")
@mock.patch("cloudinit.net.os.path.exists")
def test_is_netfail_standby_no_standby_feature(self, m_exists, m_standby):
devname = random_string()
driver = "virtio_net"
m_exists.return_value = True # has master sysfs attr
m_standby.return_value = False # has standby feature flag
assert not net.is_netfail_standby(devname, driver)
@mock.patch("cloudinit.net.is_netfail_standby")
@mock.patch("cloudinit.net.is_netfail_primary")
def test_is_netfailover_primary(self, m_primary, m_standby):
devname = random_string()
driver = random_string()
m_primary.return_value = True
m_standby.return_value = False
assert net.is_netfailover(devname, driver)
@mock.patch("cloudinit.net.is_netfail_standby")
@mock.patch("cloudinit.net.is_netfail_primary")
def test_is_netfailover_standby(self, m_primary, m_standby):
devname = random_string()
driver = random_string()
m_primary.return_value = False
m_standby.return_value = True
assert net.is_netfailover(devname, driver)
@mock.patch("cloudinit.net.is_netfail_standby")
@mock.patch("cloudinit.net.is_netfail_primary")
def test_is_netfailover_returns_false(self, m_primary, m_standby):
devname = random_string()
driver = random_string()
m_primary.return_value = False
m_standby.return_value = False
assert not net.is_netfailover(devname, driver)
class TestOpenvswitchIsInstalled:
"""Test cloudinit.net.openvswitch_is_installed.
Uses the ``clear_lru_cache`` local autouse fixture to allow us to test
despite the ``lru_cache`` decorator on the unit under test.
"""
@pytest.fixture(autouse=True)
def clear_lru_cache(self):
net.openvswitch_is_installed.cache_clear()
@pytest.mark.parametrize(
"expected,which_return", [(True, "/some/path"), (False, None)]
)
@mock.patch("cloudinit.net.subp.which")
def test_mirrors_which_result(self, m_which, expected, which_return):
m_which.return_value = which_return
assert expected == net.openvswitch_is_installed()
@mock.patch("cloudinit.net.subp.which")
def test_only_calls_which_once(self, m_which):
net.openvswitch_is_installed()
net.openvswitch_is_installed()
assert 1 == m_which.call_count
@mock.patch("cloudinit.net.subp.subp", return_value=("", ""))
class TestGetOVSInternalInterfaces:
"""Test cloudinit.net.get_ovs_internal_interfaces.
Uses the ``clear_lru_cache`` local autouse fixture to allow us to test
despite the ``lru_cache`` decorator on the unit under test.
"""
@pytest.fixture(autouse=True)
def clear_lru_cache(self):
net.get_ovs_internal_interfaces.cache_clear()
def test_command_used(self, m_subp):
"""Test we use the correct command when we call subp"""
net.get_ovs_internal_interfaces()
assert [
mock.call(net.OVS_INTERNAL_INTERFACE_LOOKUP_CMD)
] == m_subp.call_args_list
def test_subp_contents_split_and_returned(self, m_subp):
"""Test that the command output is appropriately mangled."""
stdout = "iface1\niface2\niface3\n"
m_subp.return_value = (stdout, "")
assert [
"iface1",
"iface2",
"iface3",
] == net.get_ovs_internal_interfaces()
def test_database_connection_error_handled_gracefully(self, m_subp):
"""Test that the error indicating OVS is down is handled gracefully."""
m_subp.side_effect = ProcessExecutionError(
stderr="database connection failed"
)
assert [] == net.get_ovs_internal_interfaces()
def test_other_errors_raised(self, m_subp):
"""Test that only database connection errors are handled."""
m_subp.side_effect = ProcessExecutionError()
with pytest.raises(ProcessExecutionError):
net.get_ovs_internal_interfaces()
def test_only_runs_once(self, m_subp):
"""Test that we cache the value."""
net.get_ovs_internal_interfaces()
net.get_ovs_internal_interfaces()
assert 1 == m_subp.call_count
@mock.patch("cloudinit.net.get_ovs_internal_interfaces")
@mock.patch("cloudinit.net.openvswitch_is_installed")
class TestIsOpenVSwitchInternalInterface:
def test_false_if_ovs_not_installed(
self, m_openvswitch_is_installed, _m_get_ovs_internal_interfaces
):
"""Test that OVS' absence returns False."""
m_openvswitch_is_installed.return_value = False
assert not net.is_openvswitch_internal_interface("devname")
@pytest.mark.parametrize(
"detected_interfaces,devname,expected_return",
[
([], "devname", False),
(["notdevname"], "devname", False),
(["devname"], "devname", True),
(["some", "other", "devices", "and", "ours"], "ours", True),
],
)
def test_return_value_based_on_detected_interfaces(
self,
m_openvswitch_is_installed,
m_get_ovs_internal_interfaces,
detected_interfaces,
devname,
expected_return,
):
"""Test that the detected interfaces are used correctly."""
m_openvswitch_is_installed.return_value = True
m_get_ovs_internal_interfaces.return_value = detected_interfaces
assert expected_return == net.is_openvswitch_internal_interface(
devname
)
class TestIsIpAddress:
"""Tests for net.is_ip_address.
Instead of testing with values we rely on the ipaddress stdlib module to
handle all values correctly, so simply test that is_ip_address defers to
the ipaddress module correctly.
"""
@pytest.mark.parametrize(
"ip_address_side_effect,expected_return",
(
(ValueError, False),
(lambda _: ipaddress.IPv4Address("192.168.0.1"), True),
(lambda _: ipaddress.IPv4Address("192.168.0.1/24"), False),
(lambda _: ipaddress.IPv6Address("2001:db8::"), True),
(lambda _: ipaddress.IPv6Address("2001:db8::/48"), False),
),
)
def test_is_ip_address(self, ip_address_side_effect, expected_return):
with mock.patch(
"cloudinit.net.ipaddress.ip_address",
side_effect=ip_address_side_effect,
) as m_ip_address:
ret = net.is_ip_address(mock.sentinel.ip_address_in)
assert expected_return == ret
expected_call = mock.call(mock.sentinel.ip_address_in)
assert [expected_call] == m_ip_address.call_args_list
class TestIsIpv4Address:
"""Tests for net.is_ipv4_address.
Instead of testing with values we rely on the ipaddress stdlib module to
handle all values correctly, so simply test that is_ipv4_address defers to
the ipaddress module correctly.
"""
@pytest.mark.parametrize(
"ipv4address_mock,expected_return",
(
(mock.Mock(side_effect=ValueError), False),
(
mock.Mock(return_value=ipaddress.IPv4Address("192.168.0.1")),
True,
),
),
)
def test_is_ip_address(self, ipv4address_mock, expected_return):
with mock.patch(
"cloudinit.net.ipaddress.IPv4Address", ipv4address_mock
) as m_ipv4address:
ret = net.is_ipv4_address(mock.sentinel.ip_address_in)
assert expected_return == ret
expected_call = mock.call(mock.sentinel.ip_address_in)
assert [expected_call] == m_ipv4address.call_args_list
class TestIsIpNetwork:
"""Tests for net.is_ip_network() and related functions."""
@pytest.mark.parametrize(
"func,arg,expected_return",
(
(net.is_ip_network, "192.168.1.1", True),
(net.is_ip_network, "192.168.1.1/24", True),
(net.is_ip_network, "192.168.1.1/32", True),
(net.is_ip_network, "192.168.1.1/33", False),
(net.is_ip_network, "2001:67c:1", False),
(net.is_ip_network, "2001:67c:1/32", False),
(net.is_ip_network, "2001:67c::", True),
(net.is_ip_network, "2001:67c::/32", True),
(net.is_ipv4_network, "192.168.1.1", True),
(net.is_ipv4_network, "192.168.1.1/24", True),
(net.is_ipv4_network, "2001:67c::", False),
(net.is_ipv4_network, "2001:67c::/32", False),
(net.is_ipv6_network, "192.168.1.1", False),
(net.is_ipv6_network, "192.168.1.1/24", False),
(net.is_ipv6_network, "2001:67c:1", False),
(net.is_ipv6_network, "2001:67c:1/32", False),
(net.is_ipv6_network, "2001:67c::", True),
(net.is_ipv6_network, "2001:67c::/32", True),
(net.is_ipv6_network, "2001:67c::/129", False),
(net.is_ipv6_network, "2001:67c::/128", True),
),
)
def test_is_ip_network(self, func, arg, expected_return):
assert func(arg) == expected_return
class TestIsIpInSubnet:
"""Tests for net.is_ip_in_subnet()."""
@pytest.mark.parametrize(
"func,ip,subnet,expected_return",
(
(net.is_ip_in_subnet, "192.168.1.1", "2001:67c::1/64", False),
(net.is_ip_in_subnet, "2001:67c::1", "192.168.1.1/24", False),
(net.is_ip_in_subnet, "192.168.1.1", "192.168.1.1/24", True),
(net.is_ip_in_subnet, "192.168.1.1", "192.168.1.1/32", True),
(net.is_ip_in_subnet, "192.168.1.2", "192.168.1.1/24", True),
(net.is_ip_in_subnet, "192.168.1.2", "192.168.1.1/32", False),
(net.is_ip_in_subnet, "192.168.2.2", "192.168.1.1/24", False),
(net.is_ip_in_subnet, "192.168.2.2", "192.168.1.1/32", False),
(net.is_ip_in_subnet, "2001:67c1::1", "2001:67c1::1/64", True),
(net.is_ip_in_subnet, "2001:67c1::1", "2001:67c1::1/128", True),
(net.is_ip_in_subnet, "2001:67c1::2", "2001:67c1::1/64", True),
(net.is_ip_in_subnet, "2001:67c1::2", "2001:67c1::1/128", False),
(net.is_ip_in_subnet, "2002:67c1::1", "2001:67c1::1/8", True),
(net.is_ip_in_subnet, "2002:67c1::1", "2001:67c1::1/16", False),
),
)
def test_is_ip_in_subnet(self, func, ip, subnet, expected_return):
assert func(ip, subnet) == expected_return
|