1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
|
#include <cstddef> // IWYU pragma: keep
#include <iostream>
#include <map>
#include <string>
#include <utility>
#include <vector>
#include "cmCTestBinPacker.h"
#include "cmCTestResourceAllocator.h"
struct ExpectedPackResult
{
std::vector<int> SlotsNeeded;
std::map<std::string, cmCTestResourceAllocator::Resource> Resources;
bool ExpectedReturnValue;
std::vector<cmCTestBinPackerAllocation> ExpectedRoundRobinAllocations;
std::vector<cmCTestBinPackerAllocation> ExpectedBlockAllocations;
};
static std::vector<ExpectedPackResult> const expectedResults{
/* clang-format off */
{
{ 2, 2, 2, 2 },
{ { "0", { 4, 0 } }, { "1", { 4, 0 } }, { "2", { 4, 0 } },
{ "3", { 4, 0 } } },
true,
{
{ 0, 2, "0" },
{ 1, 2, "1" },
{ 2, 2, "2" },
{ 3, 2, "3" },
},
{
{ 0, 2, "0" },
{ 1, 2, "0" },
{ 2, 2, "1" },
{ 3, 2, "1" },
},
},
{
{ 2, 3, 2 },
{ { "0", { 5, 0 } }, { "1", { 2, 0 } } },
true,
{
{ 0, 2, "0" },
{ 1, 3, "0" },
{ 2, 2, "1" },
},
{
{ 0, 2, "0" },
{ 1, 3, "0" },
{ 2, 2, "1" },
},
},
{
{ 1, 2, 3 },
{ { "0", { 1, 0 } }, { "1", { 2, 0 } }, { "2", { 2, 0 } } },
false,
{ },
{ },
},
{
{ 48, 21, 31, 10, 40 },
{ { "0", { 81, 0 } }, { "1", { 68, 0 } }, { "2", { 20, 0 } },
{ "3", { 13, 0 } } },
true,
{
{ 0, 48, "0" },
{ 1, 21, "1" },
{ 2, 31, "0" },
{ 3, 10, "2" },
{ 4, 40, "1" },
},
{
{ 0, 48, "0" },
{ 1, 21, "1" },
{ 2, 31, "0" },
{ 3, 10, "2" },
{ 4, 40, "1" },
},
},
{
{ 30, 31, 39, 67 },
{ { "0", { 16, 0 } }, { "1", { 81, 0 } }, { "2", { 97, 0 } } },
true,
{
{ 0, 30, "2" },
{ 1, 31, "1" },
{ 2, 39, "1" },
{ 3, 67, "2" },
},
{
{ 0, 30, "2" },
{ 1, 31, "1" },
{ 2, 39, "1" },
{ 3, 67, "2" },
},
},
{
{ 63, 47, 1, 9 },
{ { "0", { 18, 0 } }, { "1", { 29, 0 } }, { "2", { 9, 0 } },
{ "3", { 52, 0 } } },
false,
{ },
{ },
},
{
{ 22, 29, 46, 85 },
{ { "0", { 65, 0 } }, { "1", { 85, 0 } }, { "2", { 65, 0 } },
{ "3", { 78, 0 } } },
true,
{
{ 0, 22, "2" },
{ 1, 29, "0" },
{ 2, 46, "3" },
{ 3, 85, "1" },
},
{
{ 0, 22, "0" },
{ 1, 29, "3" },
{ 2, 46, "3" },
{ 3, 85, "1" },
},
},
{
{ 66, 11, 34, 21 },
{ { "0", { 24, 0 } }, { "1", { 57, 0 } }, { "2", { 61, 0 } },
{ "3", { 51, 0 } } },
false,
{ },
{ },
},
{
{ 72, 65, 67, 45 },
{ { "0", { 29, 0 } }, { "1", { 77, 0 } }, { "2", { 98, 0 } },
{ "3", { 58, 0 } } },
false,
{ },
{ },
},
/*
* The following is a contrived attack on the bin-packing algorithm that
* causes it to execute with n! complexity, where n is the number of
* resources. This case is very unrepresentative of real-world usage, and
* has been documented but disabled. The bin-packing problem is NP-hard, and
* we may not be able to fix this case at all.
*/
#if 0
{
{ 1000, 999, 998, 997, 996, 995, 994, 993, 992, 991, 19 },
{ { "0", { 1000, 0 } }, { "1", { 1001, 0 } }, { "2", { 1002, 0 } },
{ "3", { 1003, 0 } }, { "4", { 1004, 0 } }, { "5", { 1005, 0 } },
{ "6", { 1006, 0 } }, { "7", { 1007, 0 } }, { "8", { 1008, 0 } },
{ "9", { 1009, 0 } } },
false,
{ },
{ },
},
#endif
/*
* These cases are more representative of real-world usage (the resource
* sizes are all the same.)
*/
{
{ 1000, 999, 998, 997, 996, 995, 994, 993, 992, 991, 10 },
{ { "0", { 1000, 0 } }, { "1", { 1000, 0 } }, { "2", { 1000, 0 } },
{ "3", { 1000, 0 } }, { "4", { 1000, 0 } }, { "5", { 1000, 0 } },
{ "6", { 1000, 0 } }, { "7", { 1000, 0 } }, { "8", { 1000, 0 } },
{ "9", { 1000, 0 } } },
false,
{ },
{ },
},
{
{ 1000, 999, 998, 997, 996, 995, 994, 993, 992, 991, 9 },
{ { "0", { 1000, 0 } }, { "1", { 1000, 0 } }, { "2", { 1000, 0 } },
{ "3", { 1000, 0 } }, { "4", { 1000, 0 } }, { "5", { 1000, 0 } },
{ "6", { 1000, 0 } }, { "7", { 1000, 0 } }, { "8", { 1000, 0 } },
{ "9", { 1000, 0 } } },
true,
{
{ 0, 1000, "0" },
{ 1, 999, "1" },
{ 2, 998, "2" },
{ 3, 997, "3" },
{ 4, 996, "4" },
{ 5, 995, "5" },
{ 6, 994, "6" },
{ 7, 993, "7" },
{ 8, 992, "8" },
{ 9, 991, "9" },
{ 10, 9, "9" },
},
{
{ 0, 1000, "0" },
{ 1, 999, "1" },
{ 2, 998, "2" },
{ 3, 997, "3" },
{ 4, 996, "4" },
{ 5, 995, "5" },
{ 6, 994, "6" },
{ 7, 993, "7" },
{ 8, 992, "8" },
{ 9, 991, "9" },
{ 10, 9, "9" },
},
},
/* clang-format on */
};
struct AllocationComparison
{
cmCTestBinPackerAllocation First;
cmCTestBinPackerAllocation Second;
bool Equal;
};
static std::vector<AllocationComparison> const comparisons{
/* clang-format off */
{ { 0, 1, "0" }, { 0, 1, "0" }, true },
{ { 0, 1, "0" }, { 1, 1, "0" }, false },
{ { 0, 1, "0" }, { 0, 2, "0" }, false },
{ { 0, 1, "0" }, { 0, 1, "1" }, false },
/* clang-format on */
};
static bool TestExpectedPackResult(ExpectedPackResult const& expected)
{
std::vector<cmCTestBinPackerAllocation> roundRobinAllocations;
roundRobinAllocations.reserve(expected.SlotsNeeded.size());
std::size_t index = 0;
for (auto const& n : expected.SlotsNeeded) {
roundRobinAllocations.push_back({ index++, n, "" });
}
bool roundRobinResult = cmAllocateCTestResourcesRoundRobin(
expected.Resources, roundRobinAllocations);
if (roundRobinResult != expected.ExpectedReturnValue) {
std::cout
<< "cmAllocateCTestResourcesRoundRobin did not return expected value"
<< std::endl;
return false;
}
if (roundRobinResult &&
roundRobinAllocations != expected.ExpectedRoundRobinAllocations) {
std::cout << "cmAllocateCTestResourcesRoundRobin did not return expected "
"allocations"
<< std::endl;
return false;
}
std::vector<cmCTestBinPackerAllocation> blockAllocations;
blockAllocations.reserve(expected.SlotsNeeded.size());
index = 0;
for (auto const& n : expected.SlotsNeeded) {
blockAllocations.push_back({ index++, n, "" });
}
bool blockResult =
cmAllocateCTestResourcesBlock(expected.Resources, blockAllocations);
if (blockResult != expected.ExpectedReturnValue) {
std::cout << "cmAllocateCTestResourcesBlock did not return expected value"
<< std::endl;
return false;
}
if (blockResult && blockAllocations != expected.ExpectedBlockAllocations) {
std::cout << "cmAllocateCTestResourcesBlock did not return expected"
" allocations"
<< std::endl;
return false;
}
return true;
}
int testCTestBinPacker(int /*unused*/, char* /*unused*/[])
{
int retval = 0;
for (auto const& comparison : comparisons) {
if ((comparison.First == comparison.Second) != comparison.Equal) {
std::cout << "Comparison did not match expected" << std::endl;
retval = 1;
}
if ((comparison.First != comparison.Second) == comparison.Equal) {
std::cout << "Comparison did not match expected" << std::endl;
retval = 1;
}
}
for (auto const& expected : expectedResults) {
if (!TestExpectedPackResult(expected)) {
retval = 1;
}
}
return retval;
}
|
