1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592
|
#!/usr/bin/python3 -cimport os, sys; os.execv(os.path.dirname(sys.argv[1]) + "/pywrap", sys.argv)
import argparse
import binascii
import errno
import glob
import importlib.machinery
import importlib.util
import logging
import os
import socket
import string
import subprocess
import sys
import tempfile
import time
import unittest
from typing import List, Optional, Tuple
import testlib
from lcov import create_coverage_report, prepare_for_code_coverage
from machine import testvm
os.environ['PYTHONUNBUFFERED'] = '1'
# Amount of times a test is re-run to find flakes / race conditions
AMPLIFY_TEST_COUNT = 10
def flush_stdout():
while True:
try:
sys.stdout.flush()
break
except BlockingIOError:
time.sleep(0.1)
class Test:
def __init__(self, test_id, command, timeout, nondestructive, retry_when_affected, todo, cost=1):
self.process = None
self.retries = 0
self.test_id = test_id
self.command = command
self.timeout = timeout
self.nondestructive = nondestructive
self.machine_id = None
self.retry_when_affected = retry_when_affected
self.todo = todo
self.cost = cost
self.returncode = None
def assign_machine(self, machine_id, ssh_address, web_address):
assert self.nondestructive, "assigning a machine only works for nondestructive test"
self.machine_id = machine_id
self.command.insert(-2, "--machine")
self.command.insert(-2, ssh_address)
self.command.insert(-2, "--browser")
self.command.insert(-2, web_address)
def start(self):
if self.nondestructive:
assert self.machine_id is not None, f"need to assign nondestructive test {self} {self.command} to a machine"
self.outfile = tempfile.TemporaryFile()
self.process = subprocess.Popen(["timeout", "-v", str(self.timeout), *self.command],
stdout=self.outfile, stderr=subprocess.STDOUT)
def poll(self):
poll_result = self.process.poll()
if poll_result is not None:
self.outfile.flush()
self.outfile.seek(0)
self.output = self.outfile.read()
self.outfile.close()
self.outfile = None
self.returncode = self.process.returncode
return poll_result
def finish(self, affected_tests: List[str], opts: argparse.Namespace) -> Tuple[Optional[str], int]:
"""Returns if a test should retry or not
Call test-failure-policy on the test's output, print if needed.
Return (retry_reason, exit_code). retry_reason can be None or a string.
"""
print_tap = not opts.list
affected = any(self.command[0].endswith(t) for t in affected_tests)
retry_reason = ""
# Try affected tests 3 times
if self.returncode == 0 and affected and self.retry_when_affected and self.retries < 2:
retry_reason = "test affected tests 3 times"
self.retries += 1
self._print_test(print_tap, f"# RETRY {self.retries} ({retry_reason})")
return retry_reason, 0
# If test is being skipped pick up the reason
if self.returncode == 77:
lines = self.output.splitlines()
skip_reason = lines[-1].strip().decode()
self.output = b"\n".join(lines[:-1])
self._print_test(print_tap, skip_reason=skip_reason)
return None, 0
# If the test was marked with @todo then...
if self.todo is not None:
if self.returncode == 0:
# The test passed, but it shouldn't have.
self.returncode = 1 # that's a fail
self._print_test(print_tap, todo_reason=f'# expected failure: {self.todo}')
return None, 1
else:
# The test failed as expected
# Outputs 'not ok 1 test # TODO ...'
self._print_test(print_tap, todo_reason=f'# TODO {self.todo}')
return None, 0
if self.returncode == 0:
self._print_test(print_tap)
return None, 0
if not opts.thorough:
cmd = ["test-failure-policy", "--all"]
if not opts.track_naughties:
cmd.append("--offline")
cmd.append(testvm.DEFAULT_IMAGE)
try:
proc = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
reason = proc.communicate(self.output + ("not ok " + str(self)).encode())[0].strip()
if proc.returncode == 77:
self.returncode = proc.returncode
self._print_test(skip_reason=f"# SKIP {reason.decode()}")
return None, 0
if proc.returncode == 78:
self.returncode = proc.returncode
self._print_test(skip_reason=f"# NOTE {reason.decode()}")
return None, 1
if proc.returncode == 1:
retry_reason = reason.decode()
except OSError as ex:
if ex.errno != errno.ENOENT:
sys.stderr.write(f"\nCouldn't run test-failure-policy: {ex!s}\n")
# HACK: many tests are unstable, always retry them 3 times unless affected
if not affected and not retry_reason and not opts.no_retry_fail:
retry_reason = "be robust against unstable tests"
has_unexpected_message = testlib.UNEXPECTED_MESSAGE.encode() in self.output
has_pixel_test_message = testlib.PIXEL_TEST_MESSAGE.encode() in self.output
if self.retries < 2 and not (has_unexpected_message or has_pixel_test_message) and retry_reason:
self.retries += 1
self._print_test(retry_reason=f"# RETRY {self.retries} ({retry_reason})")
return retry_reason, 0
self.output += b"\n"
self._print_test()
self.machine_id = None
return None, 1
# internal methods
def __str__(self):
cost = "" if self.cost == 1 else f" ${self.cost}"
nd = f" [ND@{self.machine_id}]" if self.nondestructive else ""
return f"{self.test_id} {self.command[0]} {self.command[-1]}{cost}{nd}"
def _print_test(self, print_tap=True, retry_reason="", skip_reason="", todo_reason=""):
def write_line(line):
while line:
try:
sys.stdout.buffer.write(line)
break
except BlockingIOError as e:
line = line[e.characters_written:]
time.sleep(0.1)
# be quiet in TAP mode for successful tests
lines = self.output.strip().splitlines(keepends=True)
if print_tap and self.returncode == 0 and len(lines) > 0:
for line in lines[:-1]:
if line.startswith(b"WARNING:"):
write_line(line)
write_line(lines[-1])
else:
for line in lines:
write_line(line)
if retry_reason:
retry_reason = " " + retry_reason
if skip_reason:
skip_reason = " " + skip_reason
if todo_reason:
todo_reason = " " + todo_reason
if not print_tap:
print(retry_reason + skip_reason + todo_reason)
flush_stdout()
return
print() # Tap needs to start on a separate line
status = 'ok' if self.returncode in [0, 77] else 'not ok'
print(f"{status} {self}{retry_reason}{skip_reason}{todo_reason}")
flush_stdout()
class GlobalMachine:
def __init__(self, restrict=True, cpus=None, memory_mb=None, machine_class=testvm.VirtMachine):
self.image = testvm.DEFAULT_IMAGE
self.network = testvm.VirtNetwork(image=self.image)
self.networking = self.network.host(restrict=restrict)
# provide enough RAM for cryptsetup's PBKDF, as long as that is not configurable:
# https://bugzilla.redhat.com/show_bug.cgi?id=1881829
self.machine = machine_class(verbose=True, networking=self.networking, image=self.image, cpus=cpus,
memory_mb=memory_mb or 1400)
self.machine_class = machine_class
if not os.path.exists(self.machine.image_file):
self.machine.pull(self.machine.image_file)
self.machine.start()
self.start_time = time.time()
self.duration = None
self.ssh_address = f"{self.machine.ssh_address}:{self.machine.ssh_port}"
self.web_address = f"{self.machine.web_address}:{self.machine.web_port}"
self.running_test = None
def reset(self):
# It is important to re-use self.networking here, so that the
# machine keeps its browser and control port.
self.machine.kill()
self.machine = self.machine_class(verbose=True, networking=self.networking, image=self.image)
self.machine.start()
def kill(self):
assert self.running_test is None, "can't kill global machine with running test"
self.machine.kill()
self.network.kill()
self.duration = round(time.time() - self.start_time)
self.machine = None
self.ssh_address = None
self.web_address = None
def is_available(self):
return self.machine and self.running_test is None
def check_valid(filename):
name = os.path.basename(filename)
allowed = string.ascii_letters + string.digits + '-_'
if not all(c in allowed for c in name):
return None
return name.replace("-", "_")
def build_command(filename, test, opts):
cmd = [filename]
if opts.trace:
cmd.append("-t")
if opts.verbosity:
cmd.append("-v")
if not opts.fetch:
cmd.append("--nonet")
if opts.list:
cmd.append("-l")
if opts.coverage:
cmd.append("--coverage")
cmd.append(test)
return cmd
def get_affected_tests(test_dir, base_branch, test_files):
if not base_branch:
return []
changed_tests = []
# Detect affected tests from changed test files
diff_out = subprocess.check_output(["git", "diff", "--name-only", "origin/" + base_branch, test_dir])
# Never consider 'test/verify/check-example' to be affected - our tests for tests count on that
# This file provides only examples, there is no place for it being flaky, no need to retry
changed_tests = [test.decode() for test in diff_out.strip().splitlines() if not test.endswith(b"check-example")]
# If more than 3 test files were changed don't consider any of them as affected
# as it might be a PR that changes more unrelated things.
if len(changed_tests) > 3:
# If 'test/verify/check-testlib' is affected, keep just that one - our tests for tests count on that
if "test/verify/check-testlib" in changed_tests:
changed_tests = ["test/verify/check-testlib"]
else:
changed_tests = []
# Detect affected tests from changed pkg/* subdirectories in cockpit
# If affected tests get detected from pkg/* changes, don't apply the
# "only do this for max. 3 check-* changes" (even if the PR also changes ≥ 3 check-*)
# (this does not apply to other projects)
diff_out = subprocess.check_output(["git", "diff", "--name-only", "origin/" + base_branch, "--", "pkg/"])
# Drop changes in css files - this does not affect tests thus no reason to retry
files = [f.decode() for f in diff_out.strip().splitlines() if not f.endswith(b"css")]
changed_pkgs = {"check-" + pkg.split('/')[1] for pkg in files}
changed_tests.extend([test for test in test_files if any(pkg in test for pkg in changed_pkgs)])
return changed_tests
def detect_tests(test_files, image, opts):
"""Detect tests to be run
Builds the list of tests we'll run in separate machines (destructive tests)
and the ones we can run on the same machine (nondestructive)
"""
destructive_tests = []
nondestructive_tests = []
seen_classes = {}
machine_class = None
test_id = 1
for filename in test_files:
name = check_valid(filename)
if not name or not os.path.isfile(filename):
continue
loader = importlib.machinery.SourceFileLoader(name, filename)
module = importlib.util.module_from_spec(importlib.util.spec_from_loader(loader.name, loader))
loader.exec_module(module)
for test_suite in unittest.TestLoader().loadTestsFromModule(module):
for test in test_suite:
if hasattr(test, "machine_class") and test.machine_class is not None:
if machine_class is not None and machine_class != test.machine_class:
raise ValueError(f"only one unique machine_class can be used per project, provided with {machine_class} and {test.machine_class}")
machine_class = test.machine_class
# ensure that test classes are unique, so that they can be selected properly
cls = test.__class__.__name__
if seen_classes.get(cls) not in [None, filename]:
raise ValueError("test class %s in %s already defined in %s" % (cls, filename, seen_classes[cls]))
seen_classes[cls] = filename
test_method = getattr(test.__class__, test._testMethodName)
test_str = f"{cls}.{test._testMethodName}"
# most tests should take much less than 10mins, so default to that;
# longer tests can be annotated with @timeout(seconds)
# check the test function first, fall back to the class'es timeout
if opts.tests and not any(t in test_str for t in opts.tests):
continue
if test_str in opts.exclude:
continue
test_timeout = testlib.get_decorator(test_method, test, "timeout", 600)
nd = testlib.get_decorator(test_method, test, "nondestructive")
rwa = not testlib.get_decorator(test_method, test, "no_retry_when_changed")
todo = testlib.get_decorator(test_method, test, "todo")
if getattr(test.__class__, "provision", None):
# each additionally provisioned VM costs destructive test capacity
cost = len(test.__class__.provision)
else:
cost = 1
test = Test(test_id, build_command(filename, test_str, opts), test_timeout, nd, rwa, todo, cost=cost)
if nd:
for _ in range(AMPLIFY_TEST_COUNT if opts.amplify == test_str else 1):
nondestructive_tests.append(test)
else:
if not opts.nondestructive:
for _ in range(AMPLIFY_TEST_COUNT if opts.amplify == test_str else 1):
destructive_tests.append(test)
test_id += 1
# sort non destructive tests by class/test name, to avoid spurious errors where failures depend on the order of
# execution but let's make sure we always test them both ways around; hash the image name, which is
# robust, reproducible, and provides an even distribution of both directions
nondestructive_tests.sort(key=lambda t: t.command[-1], reverse=bool(binascii.crc32(image.encode()) & 1))
return (nondestructive_tests, destructive_tests, machine_class)
def list_tests(opts):
test_files = glob.glob(os.path.join(opts.test_dir, opts.test_glob))
nondestructive_tests, destructive_tests, _ = detect_tests(test_files, "dummy", opts)
names = {t.command[-1] for t in nondestructive_tests + destructive_tests}
for n in sorted(names):
print(n)
def run(opts, image):
fail_count = 0
start_time = time.time()
if opts.coverage:
prepare_for_code_coverage()
test_files = glob.glob(os.path.join(opts.test_dir, opts.test_glob))
changed_tests = get_affected_tests(opts.test_dir, opts.base, test_files)
nondestructive_tests, destructive_tests, machine_class = detect_tests(test_files, image, opts)
nondestructive_tests_len = len(nondestructive_tests)
destructive_tests_len = len(destructive_tests)
if opts.machine:
assert not destructive_tests
print(f"1..{nondestructive_tests_len + destructive_tests_len}")
flush_stdout()
running_tests = []
global_machines = []
if not opts.machine:
# Create appropriate number of nondestructive machines; prioritize the nondestructive tests, to get
# them out of the way as fast as possible, then let the destructive ones start as soon as
# a given nondestructive runner is done.
num_global = min(nondestructive_tests_len, opts.jobs)
for _ in range(num_global):
global_machines.append(GlobalMachine(restrict=not opts.enable_network, cpus=opts.nondestructive_cpus,
memory_mb=opts.nondestructive_memory_mb,
machine_class=machine_class or testvm.VirtMachine))
# test scheduling loop
while True:
made_progress = False
# mop up finished tests
logging.debug("test loop: %d running tests", len(running_tests))
for test in running_tests.copy():
poll_result = test.poll()
if poll_result is not None:
made_progress = True
running_tests.remove(test)
test_machine = test.machine_id # test_finish() resets it
retry_reason, test_result = test.finish(changed_tests, opts)
fail_count += test_result
logging.debug("test %s finished; result %s retry reason %s", test, test_result, retry_reason)
if test_machine is not None and not opts.machine:
# unassign from global machine
global_machines[test_machine].running_test = None
# sometimes our global machine gets messed up; also, tests that time out don't run cleanup handlers
# restart it to avoid an unbounded number of test retries and follow-up errors
if not opts.machine and (poll_result == 124 or (retry_reason and "test harness" in retry_reason)):
# try hard to keep the test output consistent
sys.stderr.write("\nRestarting global machine %s\n" % test_machine)
sys.stderr.flush()
global_machines[test_machine].reset()
# run again if needed
if retry_reason:
if test.nondestructive:
nondestructive_tests.insert(0, test)
else:
destructive_tests.insert(0, test)
if opts.machine:
if not running_tests and nondestructive_tests:
test = nondestructive_tests.pop(0)
logging.debug("Static machine is free, assigning next test %s", test)
test.assign_machine(-1, opts.machine, opts.browser)
test.start()
running_tests.append(test)
made_progress = True
else:
# find free global machines, and either assign a new non destructive test, or kill them to free resources
for (idx, machine) in enumerate(global_machines):
if machine.is_available():
if nondestructive_tests:
test = nondestructive_tests.pop(0)
logging.debug("Global machine %s is free, assigning next test %s", idx, test)
machine.running_test = test
test.assign_machine(idx, machine.ssh_address, machine.web_address)
test.start()
running_tests.append(test)
else:
logging.debug("Global machine %s is free, and no more non destructive tests; killing", idx)
machine.kill()
made_progress = True
def running_cost():
return sum(test.cost for test in running_tests)
# fill the remaining available job slots with destructive tests; run tests with a cost higher than #jobs by themselves
while destructive_tests and (running_cost() + destructive_tests[0].cost <= opts.jobs or len(running_tests) == 0):
test = destructive_tests.pop(0)
logging.debug("%d running tests with total cost %d, starting next destructive test %s",
len(running_tests), running_cost(), test)
test.start()
running_tests.append(test)
made_progress = True
# are we done?
if not running_tests:
assert not nondestructive_tests, f"nondestructive_tests should be empty: {[str(t) for t in nondestructive_tests]}"
assert not destructive_tests, f"destructive_tests should be empty: {[str(t) for t in destructive_tests]}"
break
# Sleep if we didn't make progress
if not made_progress:
time.sleep(0.5)
# Create coverage report
if opts.coverage:
create_coverage_report()
# print summary
duration = int(time.time() - start_time)
hostname = socket.gethostname().split(".")[0]
nondestructive_details = []
if not opts.machine:
for (idx, machine) in enumerate(global_machines):
nondestructive_details.append(f"{idx}: {machine.duration}s")
details = f"[{duration}s on {hostname}, {destructive_tests_len} destructive tests, {nondestructive_tests_len} nondestructive tests: {', '.join(nondestructive_details)}]"
print()
if fail_count > 0:
print(f"# {fail_count} TESTS FAILED {details}")
else:
print(f"# TESTS PASSED {details}")
flush_stdout()
return fail_count
def main():
parser = testlib.arg_parser(enable_sit=False)
parser.add_argument('-j', '--jobs', type=int,
default=int(os.environ.get("TEST_JOBS", 1)), help="Number of concurrent jobs")
parser.add_argument('--thorough', action='store_true',
help='Thorough mode, no skipping known issues')
parser.add_argument('-n', '--nondestructive', action='store_true',
help='Only consider @nondestructive tests')
parser.add_argument('--machine', metavar="hostname[:port]",
default=None, help="Run tests against an already running machine; implies --nondestructive")
parser.add_argument('--browser', metavar="hostname[:port]",
default=None, help="When using --machine, use this cockpit web address")
parser.add_argument('--test-dir', default=os.environ.get("TEST_DIR", testvm.TEST_DIR),
help="Directory in which to glob for test files; default: %(default)s")
parser.add_argument('--test-glob', default="check-*",
help="Pattern with which to glob in the test directory; default: %(default)s")
parser.add_argument('--exclude', action="append", default=[], metavar="TestClass.testName",
help="Exclude test (exact match only); can be specified multiple times")
parser.add_argument('--nondestructive-cpus', type=int, default=None,
help="Number of CPUs for nondestructive test global machines")
parser.add_argument('--nondestructive-memory-mb', type=int, default=None,
help="RAM size for nondestructive test global machines")
parser.add_argument('--base', default=os.environ.get("BASE_BRANCH"),
help="Retry affected tests compared to given base branch; default: %(default)s")
parser.add_argument('--track-naughties', action='store_true',
help='Update the occurrence of naughties on cockpit-project/bots')
parser.add_argument('--no-retry-fail', action='store_true',
help="Don't retry failed tests")
parser.add_argument('--amplify', type=str, default=None,
help="Run the given tests multiple times in a row")
opts = parser.parse_args()
if opts.machine:
if opts.jobs > 1:
parser.error("--machine cannot be used with concurrent jobs")
if not opts.browser:
parser.error("--browser must be specified together with --machine")
opts.nondestructive = True
# Tell any subprocesses what we are testing
if "TEST_REVISION" not in os.environ:
r = subprocess.run(["git", "rev-parse", "HEAD"],
universal_newlines=True, check=False, stdout=subprocess.PIPE)
if r.returncode == 0:
os.environ["TEST_REVISION"] = r.stdout.strip()
os.environ["TEST_BROWSER"] = os.environ.get("TEST_BROWSER", "chromium")
image = testvm.DEFAULT_IMAGE
testvm.DEFAULT_IMAGE = image
os.environ["TEST_OS"] = image
# Make sure tests can make relative imports
sys.path.append(os.path.realpath(opts.test_dir))
if opts.list:
list_tests(opts)
return 0
return run(opts, image)
if __name__ == '__main__':
# logging.basicConfig(level=logging.DEBUG)
sys.exit(main())
|