1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495
|
#!/usr/bin/python3 -cimport os, sys; os.execv(os.path.dirname(sys.argv[1]) + "/../common/pywrap", sys.argv)
# This file is part of Cockpit.
#
# Copyright (C) 2020 Red Hat, Inc.
#
# Cockpit is free software; you can redistribute it and/or modify it
# under the terms of the GNU Lesser General Public License as published by
# the Free Software Foundation; either version 2.1 of the License, or
# (at your option) any later version.
#
# Cockpit is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public License
# along with Cockpit; If not, see <https://www.gnu.org/licenses/>.
import time
import testlib
@testlib.nondestructive
class TestSuperuser(testlib.MachineCase):
def testBasic(self):
b = self.browser
m = self.machine
# Log in with all defaults
self.login_and_go()
b.check_superuser_indicator("Administrative access")
b.assert_pixels("#topnav", "topnav-privileged")
# Drop privileges
b.open_superuser_dialog()
b.click(".pf-v6-c-modal-box:contains('Switch to limited access') button:contains('Limit access')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Switch to limited access')")
b.check_superuser_indicator("Limited access")
b.assert_pixels("#topnav", "topnav-unprivileged")
# Check they are still gone after logout
b.relogin()
b.leave_page()
b.check_superuser_indicator("Limited access")
# A reload should not lose privileges
b.become_superuser()
b.reload()
b.check_superuser_indicator("Administrative access")
# Drop privileges
b.drop_superuser()
# We want to be lectured again
self.restore_dir("/var/db/sudo/lectured")
m.execute("rm -rf /var/{db,lib}/sudo/lectured/admin")
# Sudo since 1.9.15 uses a UID not a username https://www.sudo.ws/releases/stable/#1.9.15
uid = m.execute("id -u admin").strip()
m.execute(f"rm -rf /var/{{db,lib}}/sudo/lectured/{uid}")
# Get the privileges back, this time in the mobile layout
b.set_layout("mobile")
b.open_superuser_dialog()
if "ubuntu" not in m.image and "debian" not in m.image:
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')",
"We trust you have received the usual lecture")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "Password for admin:")
b.set_input_text(".pf-v6-c-modal-box:contains('Switch to administrative access') input", "foobar")
b.focus(".pf-v6-c-modal-box button:contains('Cancel')")
b.assert_pixels(".pf-v6-c-modal-box:contains('Switch to administrative access')", "superuser-modal",
chrome_hack_double_shots=True)
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Switch to administrative access')")
b.check_superuser_indicator("Administrative access")
b.set_layout("desktop")
# Check we still have them after logout
b.relogin()
b.leave_page()
b.check_superuser_indicator("Administrative access")
# Test that closing instead of cancelling the dialog keeps the "switch
# to administrative button"
b.open_superuser_dialog()
b.click(".pf-v6-c-modal-box:contains('Switch to limited access') button:contains('Limit access')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Switch to limited access')")
b.check_superuser_indicator("Limited access")
b.open_superuser_dialog()
b.click(".pf-v6-c-modal-box__close button")
b.check_superuser_indicator("Limited access")
def testSudoIOLogging(self):
b = self.browser
m = self.machine
self.write_file("/etc/sudoers.d/log", "Defaults log_output\n")
# with explicitly becoming superuser
self.login_and_go(superuser=False)
b.check_superuser_indicator("Limited access")
b.become_superuser()
self.assertIn("00\n", m.execute("ls /var/log/sudo-io"))
b.logout()
# with immediate superuser at login
b.login_and_go()
b.check_superuser_indicator("Administrative access")
b.logout()
def testNoPasswd(self):
b = self.browser
# Log in with limited access
self.login_and_go(superuser=False)
b.check_superuser_indicator("Limited access")
# Give us password-less sudo and use it
self.write_file("/etc/sudoers.d/admin", "admin ALL=(ALL) NOPASSWD:ALL")
b.become_superuser(passwordless=True)
@testlib.skipBeiboot("no local PAM config in beiboot mode")
@testlib.skipOstree("mock-pam-conv not installed")
def testTwoPasswds(self):
b = self.browser
m = self.machine
# Log in with limited access
self.login_and_go(superuser=False)
b.check_superuser_indicator("Limited access")
# Configure the sudo PAM stack to make two prompts
if "debian" in m.image or "ubuntu" in m.image:
self.write_file("/etc/pam.d/sudo", """
auth required pam_unix.so
auth required mock-pam-conv-mod.so
@include common-account
@include common-session-noninteractive
""")
else:
self.write_file("/etc/pam.d/sudo", """
auth required pam_unix.so
auth required mock-pam-conv-mod.so
account include system-auth
password include system-auth
session include system-auth
""")
b.open_superuser_dialog()
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "Password for admin:")
# Let the dialog sit there for 45 seconds, to test that this doesn't trigger a D-Bus timeout.
time.sleep(45)
b.set_input_text(".pf-v6-c-modal-box:contains('Switch to administrative access') input", "foobar")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "universe and everything")
b.set_input_text(".pf-v6-c-modal-box:contains('Switch to administrative access') input", "42")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Switch to administrative access')")
b.check_superuser_indicator("Administrative access")
def testWrongPasswd(self):
b = self.browser
# Log in with limited access
self.login_and_go(superuser=False)
b.check_superuser_indicator("Limited access")
b.open_superuser_dialog()
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "Password for admin:")
b.set_input_text(".pf-v6-c-modal-box:contains('Switch to administrative access') input", "wrong")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "Password for admin:")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "Sorry, try again")
b.set_input_text(".pf-v6-c-modal-box:contains('Switch to administrative access') input", "wronger")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "Password for admin:")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "Sorry, try again")
b.set_input_text(".pf-v6-c-modal-box:contains('Switch to administrative access') input", "wrongest")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_in_text(".pf-v6-c-modal-box:contains('Problem becoming administrator')", "Sudo: 3 incorrect password attempts")
b.click(".pf-v6-c-modal-box:contains('Problem becoming administrator') button:contains('Close')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Problem becoming administrator')")
b.check_superuser_indicator("Limited access")
def testNotAdmin(self):
b = self.browser
m = self.machine
# Remove special treatment of the "admin" group on Ubuntu.
# Our main test user is unfortunately called "admin" and has
# "admin" as its primary group.
#
if "ubuntu" in m.image:
self.sed_file("/^%admin/d", "/etc/sudoers")
m.execute(f"gpasswd -d admin {m.get_admin_group()}")
self.login_and_go()
b.check_superuser_indicator("Limited access")
b.open_superuser_dialog()
b.set_input_text(".pf-v6-c-modal-box:contains('Switch to administrative access') input", "foobar")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_in_text(".pf-v6-c-modal-box:contains('Problem becoming administrator')", "Admin is not in the sudoers file.")
b.click(".pf-v6-c-modal-box:contains('Problem becoming administrator') button:contains('Close')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Problem becoming administrator')")
# no stray/hanging sudo process
testlib.wait(lambda: "sudo" not in m.execute("loginctl --lines=0 user-status admin"), tries=5)
# cancelling auth dialog stops sudo
b.open_superuser_dialog()
b.wait_in_text(".pf-v6-c-modal-box", "Switch to administrative access")
b.wait_in_text(".pf-v6-c-modal-box", "Password for admin")
status = m.execute("loginctl --lines=0 user-status admin")
self.assertIn("sudo", status)
if not m.ws_container:
self.assertIn("cockpit-askpass", status)
b.click(".pf-v6-c-modal-box button:contains('Cancel')")
b.wait_not_present(".pf-v6-c-modal-box")
testlib.wait(lambda: "sudo" not in m.execute("loginctl --lines=0 user-status admin"), tries=5)
# logging out cleans up pending sudo auth; user should either go to "State: closing" or disappear completely
b.open_superuser_dialog()
b.wait_in_text(".pf-v6-c-modal-box", "Password for admin")
if not m.ws_container:
self.assertIn("cockpit-askpass", m.execute("loginctl --lines=0 user-status admin"))
b.click(".pf-v6-c-modal-box button:contains('Cancel')")
b.wait_not_present(".pf-v6-c-modal-box")
b.logout()
testlib.wait(lambda: "sudo" not in m.execute("loginctl --lines=0 user-status admin || true"), tries=10)
self.assertNotIn("cockpit", m.execute("loginctl --lines=0 user-status admin || true"))
@testlib.skipBeiboot("no local overrides/PAM config in beiboot mode")
def testBrokenBridgeConfig(self):
b = self.browser
m = self.machine
self.write_file("/etc/cockpit/shell.override.json", """
{
"bridges": [
{
"privileged": true,
"spawn": [
"sudo",
"-k",
"-A",
"cockpit-bridge",
"--privileged"
]
}
]
}
""")
# We don't want to be lectured in this test just to control
# the content of the dialog better.
m.execute("touch /var/{db,lib}/sudo/lectured/admin 2>/dev/null || true")
self.login_and_go(superuser=False)
b.check_superuser_indicator("Limited access")
b.open_superuser_dialog()
b.wait_in_text(".pf-v6-c-modal-box:contains('Problem becoming administrator')", "Sudo: no askpass program specified, try setting SUDO_ASKPASS")
b.click(".pf-v6-c-modal-box:contains('Problem becoming administrator') button:contains('Close')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Problem becoming administrator')")
b.check_superuser_indicator("Limited access")
@testlib.skipBeiboot("no local overrides/PAM config in beiboot mode")
def testRemoveBridgeConfig(self):
m = self.machine
b = self.browser
self.login_and_go("/playground/pkgs", superuser=True)
b.leave_page()
b.check_superuser_indicator("Administrative access")
# superuser bridge is running
m.execute("pgrep -u root -a cockpit-bridge")
self.write_file("/etc/cockpit/shell.override.json", """
{
"bridges": [ ]
}
""")
b.enter_page("/playground/pkgs")
b.click("#reload")
b.leave_page()
b.check_superuser_indicator("")
# superuser bridge goes away
m.execute("while pgrep -u root -a cockpit-bridge; do sleep 1; done", timeout=5)
# no banner for "running in limited access mode", there are no bridge configs
b.go("/system")
b.enter_page("/system")
b.wait_visible("#system_information_os_text")
b.wait_not_present(".pf-v6-c-alert:contains('Web console is running in limited access mode')")
@testlib.skipBeiboot("no local overrides/PAM config in beiboot mode")
def testSingleLabelBridgeConfig(self):
b = self.browser
# When there is a single labeled privileged bridge, Cockit will start it automatically.
self.write_file("/etc/cockpit/shell.override.json", """
{
"bridges": [
{
"privileged": true,
"label": "Always fails",
"spawn": [
"/bin/bash", "-c", "echo >&2 'Hello from the bash method'; exit 1"
]
}
]
}
""")
self.login_and_go("/playground/pkgs", superuser=False)
b.leave_page()
b.check_superuser_indicator("Limited access")
b.open_superuser_dialog()
b.wait_in_text(".pf-v6-c-modal-box:contains('Problem becoming administrator')", "Hello from the bash method")
b.click(".pf-v6-c-modal-box button:contains('Close')")
b.check_superuser_indicator("Limited access")
@testlib.skipBeiboot("no local overrides/PAM config in beiboot mode")
def testMultipleBridgeConfig(self):
b = self.browser
self.write_file("/etc/cockpit/shell.override.json", """
{
"bridges": [
{
"privileged": true,
"label": "Sudo",
"environ": [
"SUDO_ASKPASS=${libexecdir}/cockpit-askpass"
],
"spawn": [
"sudo",
"-k",
"-A",
"cockpit-bridge",
"--privileged"
]
},
{
"privileged": true,
"label": "Polkit",
"spawn": [
"pkexec",
"--disable-internal-agent",
"cockpit-bridge",
"--privileged"
]
}
]
}
""")
self.login_and_go("/playground/pkgs", superuser=False)
b.leave_page()
b.check_superuser_indicator("Limited access")
# Get admin rights with Polkit method
b.open_superuser_dialog()
b.set_val(".pf-v6-c-modal-box:contains('Switch to administrative access') select", "Polkit")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access') select", "Polkit")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "Please authenticate")
b.set_input_text(".pf-v6-c-modal-box:contains('Switch to administrative access') input", "foobar")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Switch to administrative access')")
b.check_superuser_indicator("Administrative access")
# Drop them
b.open_superuser_dialog()
b.click(".pf-v6-c-modal-box:contains('Switch to limited access') button:contains('Limit access')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Switch to limited access')")
b.check_superuser_indicator("Limited access")
# Run the regular sudo method, which should work as always
b.open_superuser_dialog()
b.set_val(".pf-v6-c-modal-box:contains('Switch to administrative access') select", "Sudo")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access') select", "Sudo")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "Password for admin:")
b.set_input_text(".pf-v6-c-modal-box:contains('Switch to administrative access') input", "foobar")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Switch to administrative access')")
b.check_superuser_indicator("Administrative access")
def testOverview(self):
b = self.browser
self.login_and_go("/system", superuser=False)
b.wait_visible(".pf-v6-c-alert:contains('Web console is running in limited access mode.')")
b.click(".pf-v6-c-alert:contains('Web console is running in limited access mode.') button:contains('Turn on')")
b.wait_in_text(".pf-v6-c-modal-box:contains('Switch to administrative access')", "Password for admin:")
b.set_input_text(".pf-v6-c-modal-box:contains('Switch to administrative access') input", "foobar")
b.click(".pf-v6-c-modal-box button:contains('Authenticate')")
b.wait_not_present(".pf-v6-c-modal-box:contains('Switch to administrative access')")
b.wait_not_present(".pf-v6-c-alert:contains('Web console is running in limited access mode.')")
@testlib.skipBeiboot("host switching disabled in beiboot mode")
class TestSuperuserDashboard(testlib.MachineCase):
provision = {
"machine1": {"address": "10.111.113.1/20", "memory_mb": 512},
"machine2": {"address": "10.111.113.2/20", "memory_mb": 512},
}
def test(self):
b = self.browser
self.setup_provisioned_hosts()
self.enable_multihost(self.machine)
self.login_and_go()
b.go("/@10.111.113.2")
b.click('#machine-troubleshoot')
b.wait_visible('#hosts_setup_server_dialog')
b.wait_visible('#hosts_setup_server_dialog button:contains("Add")')
b.click('#hosts_setup_server_dialog button:contains("Add")')
b.wait_visible('#hosts_connect_server_dialog')
b.click('#hosts_connect_server_dialog button.pf-m-warning')
b.wait_in_text('#hosts_setup_server_dialog', "You are connecting to 10.111.113.2 for the first time.")
b.click('#hosts_setup_server_dialog button.pf-m-primary')
b.wait_in_text('#hosts_setup_server_dialog', "Unable to log in")
b.set_input_text("#login-custom-password", "foobar")
b.click('#hosts_setup_server_dialog button:contains("Log in")')
b.wait_not_present('#hosts_setup_server_dialog')
# There should be no superuser indicator in the Overview
b.go("/@10.111.113.2/system")
b.enter_page("/system", host="10.111.113.2")
b.wait_not_present(".ct-overview-header-actions button:contains('Administrative access')")
b.wait_not_present(".ct-overview-header-actions button:contains('Limited access')")
b.leave_page()
# The superuser indicator in the Shell should apply to machine2
b.check_superuser_indicator("Limited access")
b.become_superuser()
b.go("/@10.111.113.2/playground/test")
b.enter_page("/playground/test", host="10.111.113.2")
b.click(".super-channel button")
b.wait_in_text(".super-channel span", 'result: ')
self.assertIn('result: uid=0', b.text(".super-channel span"))
# Logging out and logging back in should give us immediate
# superuser on m2 (once we have logged in there).
b.relogin()
b.wait_visible('#hosts_connect_server_dialog')
b.click('#hosts_connect_server_dialog button.pf-m-warning')
b.wait_visible('#hosts_setup_server_dialog')
b.set_input_text("#login-custom-password", "foobar")
b.click('#hosts_setup_server_dialog button:contains("Log in")')
b.wait_not_present('#hosts_setup_server_dialog')
b.check_superuser_indicator("Administrative access")
b.enter_page("/playground/test", host="10.111.113.2")
b.click(".super-channel button")
b.wait_in_text(".super-channel span", 'result: ')
self.assertIn('result: uid=0', b.text(".super-channel span"))
b.drop_superuser()
b.click(".super-channel button")
b.wait_in_text(".super-channel span", 'access-denied')
# back to superuser on machine2
b.become_superuser()
user = self.machines["machine2"].execute("loginctl user-status admin")
self.assertIn("cockpit-bridge --privileged", user)
# no stray askpass process
self.assertNotIn("cockpit-askpass", user)
# logging out cleans up logind sessions on both machines
b.logout()
for m in [self.machine, self.machines["machine2"]]:
m.execute('while [ "$(loginctl show-user --property=State --value admin)" = "active" ]; do sleep 1; done')
self.assertNotIn("cockpit", "loginctl user-status admin")
self.allow_hostkey_messages()
if __name__ == '__main__':
testlib.test_main()
|