1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890
|
(* Co-installability tools
* http://coinst.irill.org/
* Copyright (C) 2005-2011 Jérôme Vouillon
* Laboratoire PPS - CNRS Université Paris Diderot
*
* These programs are free software; you can redistribute them and/or
* modify them under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*)
let debug_coinst =
Debug.make "coinst" "Debug co-installability issue analyse" []
let debug_time = Debug.make "time" "Print execution times" []
let debug_cluster = Debug.make "cluster" "Debug clustering algorithm" []
let debug_problems =
Debug.make "coinst_prob"
"Debug enumeration of possible co-installability issues" []
let debug_problem_graph =
Debug.make "coinst_graph"
"Write the graph of new dependencies to /tmp/newdeps.dot" []
let debug = false
module IntSet = Util.IntSet
module StringSet = Util.StringSet
module M = Deb_lib
module Coinst = Coinst_common.F(M)
module Repository = Coinst.Repository
open Repository
module Quotient = Coinst.Quotient
module Graph = Graph.F (Coinst.Repository)
module PSetSet = Set.Make (PSet)
module Timer = Util.Timer
(****)
type ignored_sets = (StringSet.t list * bool) list ref
type ignored_sets_2 = (PSet.t list * bool) list
let ignored_set_domain l =
List.fold_left
(fun s (l, ext) ->
List.fold_left
(fun s s' ->
StringSet.fold (fun nm s -> M.PkgSet.add (M.add_name nm) s) s' s)
s l)
M.PkgSet.empty !l
let forced_packages l =
List.fold_left
(fun s (l, ext) ->
match l with
[s'] when not ext -> StringSet.union s s'
| _ -> s)
StringSet.empty !l
let intern_ignored_sets dist l =
List.fold_left
(fun r (l, ext) ->
let l =
List.map
(fun s ->
StringSet.fold
(fun nm s ->
match M.parse_package_name dist nm with
[p] -> PSet.add (Package.of_index p) s
| [] -> s
| _ :: _ -> assert false)
s PSet.empty)
l
in
if List.exists PSet.is_empty l then r else (l, ext) :: r)
[] l
let is_ignored_set l s =
List.exists
(fun (l, ext) ->
try
not
(StringSet.is_empty
(List.fold_left
(fun s s' ->
let p = StringSet.choose (StringSet.inter s s') in
StringSet.remove p s)
s l)
&&
ext)
with Not_found ->
false)
!l
let ignored_set_domain_2 l =
List.fold_left
(fun s (l, ext) -> List.fold_left PSet.union s l)
PSet.empty l
let is_ignored_set_2 l s =
List.exists
(fun (l, ext) ->
try
not
(PSet.is_empty
(List.fold_left
(fun s s' ->
let p = PSet.choose (PSet.inter s s') in
PSet.remove p s)
s l)
&&
ext)
with Not_found ->
false)
l
let print_ignore_spec dist f l =
Util.print_list
(fun f (l, ext) ->
Util.print_list
(fun f s ->
Util.print_list (Package.print_name dist) "|" f (PSet.elements s))
"," f l;
if ext then Format.fprintf f ",_")
" " f l
(****)
let new_deps pred possibly_ignored_packages deps1 dist2 deps2 =
PTbl.mapi
(fun p2 i ->
if i = -1 then
Formula._true
else begin
let p1 = Package.of_index i in
let f1 = PTbl.get deps1 p1 in
let f2 = PTbl.get deps2 p2 in
let f2 =
Formula.filter
(fun d2 ->
Disj.exists (fun p -> PSet.mem p possibly_ignored_packages) d2
||
let d1 =
Disj.fold
(fun p2 d2 ->
let i = PTbl.get pred p2 in
if i = -1 then d2 else
Disj.disj (Disj.lit (Package.of_index i)) d2)
d2 Disj._false
in
not (Formula.implies1 f1 d1))
f2
in
if debug && not (Formula.implies Formula._true f2) then begin
Format.printf "%a ==> %a@."
(Package.print_name dist2) p2
(Formula.print dist2) f2;
(*
Format.printf "%a --> %a@."
(Package.print_name dist1) p1
(Formula.print dist1) f1
*)
end;
f2
end)
pred
(****)
module ListTbl = Util.ListTbl
type st =
{ dist : M.pool; deps : Formula.t PTbl.t; confl : Conflict.t;
pieces : (int, Package.t * Disj.t) Hashtbl.t;
pieces_in_confl : (Package.t, int) ListTbl.t;
set : PSet.t;
installed : IntSet.t; not_installed : IntSet.t;
check : PSet.t -> bool }
let print_prob st =
IntSet.iter
(fun i ->
let (p, d) = Hashtbl.find st.pieces i in
Format.printf "%a => %a; "
(Package.print_name st.dist) p
(Disj.print st.dist) d)
st.installed;
Format.printf "@."
let rec add_piece st i cont =
assert (not (IntSet.mem i st.installed || IntSet.mem i st.not_installed));
let (p, d) = Hashtbl.find st.pieces i in
if
(* We do not add a dependency if it is implied by, or implies, a
dependency currently under consideration. *)
not (IntSet.exists
(fun i' ->
let (_, d') = Hashtbl.find st.pieces i' in
Disj.implies d d' || Disj.implies d' d)
st.installed)
&&
(* When adding a package in st.set, we check that d is not implied
by any of the dependencies of a package already in st.set *)
(PSet.mem p st.set ||
not (PSet.exists
(fun p -> Formula.implies1 (PTbl.get st.deps p) d)
st.set))
&&
(* If we are adding a package, we check whether the set is still
co-installable *)
(PSet.mem p st.set || st.check (PSet.add p st.set))
then begin
if debug_problems () then
Format.printf "Adding %a => %a@."
(Package.print_name st.dist) p (Disj.print st.dist) d;
let st =
{st with set = PSet.add p st.set;
installed = IntSet.add i st.installed}
in
if debug_problems () then print_prob st;
(* Make sure that there is at least one piece in conflict for all
dependencies, then consider all possible additions *)
Disj.fold
(fun p cont st ->
if
PSet.exists
(fun q ->
List.exists (fun i -> IntSet.mem i st.installed)
(ListTbl.find st.pieces_in_confl q))
(Conflict.of_package st.confl p)
then
cont st
else
ignore
(PSet.fold
(fun q st ->
List.fold_right (fun j st -> do_add_piece st j cont)
(ListTbl.find st.pieces_in_confl q) st)
(Conflict.of_package st.confl p) st))
d
(fun st ->
if debug_problems () then
Format.printf "Considering all possible additions in %d: %a...@."
i (Disj.print st.dist) d;
Disj.fold
(fun p cont ->
PSet.fold
(fun q cont ->
List.fold_right (fun j cont st -> maybe_add_piece st j cont)
(ListTbl.find st.pieces_in_confl q) cont)
(Conflict.of_package st.confl p) cont)
d cont st)
st
end else
if debug_problems () then
Format.printf "Could not add %a => %a@."
(Package.print_name st.dist) p (Disj.print st.dist) d;
and do_add_piece st i cont =
if IntSet.mem i st.installed then begin
cont st; st
end else if not (IntSet.mem i st.not_installed) then begin
add_piece st i cont;
{st with not_installed = IntSet.add i st.not_installed}
end else
st
and maybe_add_piece st i cont =
if
not (IntSet.mem i st.installed || IntSet.mem i st.not_installed)
then begin
add_piece st i cont;
cont {st with not_installed = IntSet.add i st.not_installed}
end else
cont st
let find_problems dist deps confl check =
let pieces = Hashtbl.create 101 in
let last_piece = ref (-1) in
let pieces_in_confl = ListTbl.create 101 in
PTbl.iteri
(fun p f ->
Formula.iter f
(fun d ->
incr last_piece;
let i = !last_piece in
Hashtbl.add pieces i (p, d);
Disj.iter d (fun p -> ListTbl.add pieces_in_confl p i)))
deps;
let st =
{ dist = dist; deps = deps; confl = confl;
pieces = pieces; pieces_in_confl = pieces_in_confl;
set = PSet.empty; check = check;
installed = IntSet.empty; not_installed = IntSet.empty }
in
for i = 0 to !last_piece do
add_piece st i (fun _ -> ())
done
(****)
type state =
{ dist : M.deb_pool;
deps : Formula.t PTbl.t;
confl : Conflict.t;
deps' : Formula.t PTbl.t;
confl' : Conflict.t;
st : M.Solver.state }
(****)
type pkg_ref = string * bool * bool
type reason =
R_depends of pkg_ref * string M.dep * pkg_ref list
| R_conflict of pkg_ref * string M.dep * pkg_ref
type clause = { pos : StringSet.t; neg : StringSet.t }
let print_clause ch clause =
Util.print_list (fun f -> Format.fprintf f "-%s") " | " ch
(StringSet.elements clause.neg);
if not (StringSet.is_empty clause.pos || StringSet.is_empty clause.neg) then
Format.fprintf ch " | ";
Util.print_list (fun f -> Format.fprintf f "%s") " | " ch
(StringSet.elements clause.pos)
let problematic_packages dist1 dist dist2 reasons =
let resolve_dep dist l =
List.fold_left
(fun s cstr ->
List.fold_left
(fun s p -> StringSet.add (M.name_of_id p.M.package) s)
s (M.resolve_package_dep_raw dist cstr))
StringSet.empty l
in
let extern_deps l =
List.map (fun (id, rel) -> (M.name_of_id id, rel)) l in
let (s1, s2, lst) =
List.fold_left
(fun (s1, s2, lst) r ->
match r with
M.R_depends (n, l) ->
let p = M.find_package_by_num dist n in
let id = p.M.package in
let nm = M.name_of_id id in
let d = resolve_dep dist l in
let d1 = resolve_dep dist1 l in
let d2 = resolve_dep dist2 l in
let s1 = StringSet.union (StringSet.diff d1 d) s1 in
let s2 = StringSet.union (StringSet.diff d2 d) s2 in
let unchanged_dep dist =
match M.find_packages_by_name dist id with
[] ->
false
| [q] ->
M.compare_version q.M.version p.M.version = 0
||
List.exists
(fun l' ->
let d1' = resolve_dep dist1 l' in
let d2' = resolve_dep dist2 l' in
not (StringSet.is_empty d1' && StringSet.is_empty d2')
&&
StringSet.subset d1' d1
&&
StringSet.subset d2' d2)
(q.M.pre_depends @ q.M.depends)
| _ ->
assert false
in
let u1 = unchanged_dep dist1 in
let u2 = unchanged_dep dist2 in
let s1 = if u1 then s1 else StringSet.add nm s1 in
let s2 = if u2 then s2 else StringSet.add nm s2 in
let pkgs d1 d2 =
List.map
(fun nm -> (nm, StringSet.mem nm d1, StringSet.mem nm d2))
(StringSet.elements (StringSet.union d1 d2))
in
let d12 = StringSet.union d1 d2 in
let other_deps u dist old lst =
if u then lst else
match M.find_packages_by_name dist id with
[] ->
lst
| [q] ->
List.fold_left
(fun lst l' ->
let d1' = resolve_dep dist1 l' in
let d2' = resolve_dep dist2 l' in
if
StringSet.subset d1' d12
&&
StringSet.subset d2' d12
then
R_depends ((nm, old, not old), extern_deps l',
pkgs d1' d2') :: lst
else
lst)
lst (q.M.pre_depends @ q.M.depends)
| _ ->
assert false
in
let lst = other_deps u1 dist1 true lst in
let lst = other_deps u2 dist2 false lst in
(s1, s2,
R_depends ((nm, u1, u2), extern_deps l, pkgs d1 d2) :: lst)
| M.R_conflict (j, k, Some (i, l)) ->
let i' = if i = j then k else j in
let p = M.find_package_by_num dist i in
let p' = M.find_package_by_num dist i' in
let id = p.M.package in
let nm = M.name_of_id id in
let nm' = M.name_of_id p'.M.package in
let c1 = resolve_dep dist1 l in
let c2 = resolve_dep dist2 l in
let u1' = StringSet.mem nm' c1 in
let s1 = if u1' then s1 else StringSet.add nm' s1 in
let u2' = StringSet.mem nm' c2 in
let s2 = if u2' then s2 else StringSet.add nm' s2 in
let unchanged_cfl dist =
match M.find_packages_by_name dist id with
[] ->
false
| [q] ->
(*
Format.eprintf "%s ## %s (%a): %b %b %b %b@." nm nm' M.print_package_dependency (q.M.breaks @ q.M.conflicts) u1' (StringSet.mem nm' (resolve_dep dist1 (List.flatten (q.M.breaks @ q.M.conflicts)))) u2' (StringSet.mem nm' (resolve_dep dist1 (List.flatten (q.M.breaks @ q.M.conflicts))));
*)
M.compare_version q.M.version p.M.version = 0
||
(let l' = List.flatten (q.M.breaks @ q.M.conflicts) in
(not u1' || StringSet.mem nm' (resolve_dep dist1 l'))
&&
(not u2' || StringSet.mem nm' (resolve_dep dist2 l')))
| _ ->
assert false
in
let u1 = unchanged_cfl dist1 in
let u2 = unchanged_cfl dist2 in
let s1 = if u1 then s1 else StringSet.add nm s1 in
let s2 = if u2 then s2 else StringSet.add nm s2 in
(s1, s2,
R_conflict ((nm, u1, u2), extern_deps l, (nm', u1', u2')) :: lst)
| M.R_conflict (_, _, None) ->
assert false)
(StringSet.empty, StringSet.empty, []) reasons
in
({pos = s1; neg = s2}, List.rev lst)
let compute_support dist1 dist2 reasons =
let add support (nm, _, _) = StringSet.add nm support in
let support =
List.fold_left
(fun support r ->
match r with
R_depends (p, _, pl) -> add (List.fold_left add support pl) p
| R_conflict (p1, _, p2) -> add (add support p2) p1)
StringSet.empty reasons
in
(support,
StringSet.filter
(fun nm -> M.has_package_of_name dist1 (M.add_name nm)) support,
StringSet.filter
(fun nm -> M.has_package_of_name dist2 (M.add_name nm)) support)
let problematic_packages dist1 dist dist2 s reasons =
let (clause, reasons) = problematic_packages dist1 dist dist2 reasons in
let (support_set, support1, support2) =
compute_support dist1 dist2 reasons in
let support = Array.of_list (StringSet.elements support_set) in
let package_index = Hashtbl.create 17 in
Array.iteri (fun n nm -> Hashtbl.add package_index nm n) support;
let n = Array.length support in
let conflict = Hashtbl.create 5 in
PSet.iter
(fun p ->
let p = M.find_package_by_num dist (Package.index p) in
Hashtbl.add conflict (M.name_of_id p.M.package) ())
s;
let in_testing nm =
match
M.find_packages_by_name dist1 (M.id_of_name nm),
M.find_packages_by_name dist (M.id_of_name nm)
with
[p1], [p] -> M.compare_version p1.M.version p.M.version = 0
| [], [] -> true
| _ -> false
in
let var nm t = (2 * Hashtbl.find package_index nm + if t then 0 else 1) in
let nlit nm t = M.Solver.lit_of_var (var nm t) false in
let plit nm t = M.Solver.lit_of_var (var nm t) true in
let print_var ch p =
Format.fprintf ch "%s(%s)"
support.(p / 2) (if p mod 2 = 0 then "testing" else "sid")
in
let pr = M.Solver.initialize_problem ~print_var (2 * n) in
let vars = ref [] in
Hashtbl.iter
(fun nm _ ->
vars := var nm true :: var nm false :: !vars;
M.Solver.add_rule pr [|plit nm true; plit nm false|] [])
conflict;
let lst = ref [] in
Hashtbl.iter
(fun nm _ ->
lst := var nm (not (in_testing nm)) :: !lst;
M.Solver.add_rule pr [|nlit nm true; nlit nm false|] [])
package_index;
(*
let print_ref f (nm, t, u) =
match t, u with
true, true -> Format.fprintf f "%s" nm
| true, false -> Format.fprintf f "%s (testing)" nm
| false, true -> Format.fprintf f "%s (sid)" nm
| false, false -> assert false
in
Format.eprintf "=======================@.";
*)
List.iter
(fun r ->
match r with
R_depends (p, _, pl) ->
(*
Format.eprintf "| %a => %a@." print_ref p
(Util.print_list print_ref " | ") pl;
*)
let lit = M.Solver.lit_of_var in
let l =
List.fold_right
(fun (nm, t, u) l ->
let l = if t then var nm true :: l else l in
let l = if u then var nm false :: l else l in
l)
pl []
in
let (nm, t, u) = p in
if t then begin
M.Solver.add_rule pr
(Array.of_list (lit (var nm true) false ::
List.map (fun x -> lit x true) l)) [];
M.Solver.associate_vars pr (lit (var nm true) true) l
end;
if u then begin
M.Solver.add_rule pr
(Array.of_list (lit (var nm false) false ::
List.map (fun x -> lit x true) l)) [];
M.Solver.associate_vars pr (lit (var nm false) true) l
end
| R_conflict ((nm1, t1, u1), _, (nm2, t2, u2)) ->
(*
Format.eprintf "| %a ## %a@." print_ref (nm1, t1, u1) print_ref (nm2, t2, u2);
*)
if t1 && t2 then
M.Solver.add_rule pr [|nlit nm1 true; nlit nm2 true|] [];
if t1 && u2 then
M.Solver.add_rule pr [|nlit nm1 true; nlit nm2 false|] [];
if u1 && t2 then
M.Solver.add_rule pr [|nlit nm1 false; nlit nm2 true|] [];
if u1 && u2 then
M.Solver.add_rule pr [|nlit nm1 false; nlit nm2 false|] [])
reasons;
(*
Format.eprintf ">> %a@." print_clause clause;
Format.eprintf "- "; List.iter (fun p -> Format.eprintf " %s (%s)" support.(p / 2)(if p mod 2 = 0 then "testing" else "sid")) !lst; Format.eprintf "@.";
*)
let rec minimize l l' f =
match l' with
[] ->
List.rev l
| x :: r ->
if f (List.rev_append l r) then
minimize (x :: l) r f
else
minimize l r f
in
let check lst =
(*
Format.eprintf ") - "; List.iter (fun p -> Format.eprintf " %s (%s)" support.(p / 2)(if p mod 2 = 0 then "testing" else "sid")) lst; Format.eprintf "@.";
*)
let res = M.Solver.solve_neg_list pr !vars lst in
(*
Format.eprintf ") ==> %b@." res;
*)
M.Solver.reset pr;
res
in
let lst = minimize [] !lst (fun lst -> check lst) in
(*
Format.eprintf "- "; List.iter (fun p -> Format.eprintf " %s (%s)" support.(p / 2)(if p mod 2 = 0 then "testing" else "sid")) lst; Format.eprintf "@.";
*)
let pos = ref StringSet.empty in
let neg = ref StringSet.empty in
List.iter
(fun x ->
let nm = support.(x / 2) in
if x mod 2 = 0 then
pos := StringSet.add nm !pos
else
neg := StringSet.add nm !neg)
lst;
({pos = !pos; neg = !neg}, reasons, support1, support2)
(****)
type problem =
{ p_clause : clause; p_issue : Util.StringSet.t; p_explain : reason list;
p_support1 : Util.StringSet.t; p_support2 : Util.StringSet.t }
type issue =
{ i_issue : PSet.t; i_problem : problem }
let prepare_analyze dist =
let (deps, confl) = Coinst.compute_dependencies_and_conflicts dist in
let (deps', confl') = Coinst.flatten_and_simplify dist deps confl in
let st = Coinst.generate_rules (Quotient.trivial dist) deps' confl' in
{ dist=dist; deps=deps; confl=confl; deps'=deps'; confl'=confl'; st=st }
let compute_predecessors dist1 dist2 =
PTbl.init dist2
(fun p2 ->
let nm = M.package_name dist2 (Package.index p2) in
match M.parse_package_name dist1 nm with
[] ->
if debug then Format.printf "%s is a new package@." nm;
-1
| [p1] ->
p1
| _ ->
assert false)
let analyze ?(check_new_packages = false) ignored_sets
?reference dist1_state dist2 =
let
{ dist = dist1; deps = deps1; confl = confl1;
deps' = deps1'; confl' = confl1'; st = st1 }
= dist1_state
in
let t = Timer.start () in
let t' = Timer.start () in
let (deps2, confl2) = Coinst.compute_dependencies_and_conflicts dist2 in
if debug_time () then
Format.eprintf " Deps and confls: %f@." (Timer.stop t');
let (deps2', confl2') = Coinst.flatten_and_simplify dist2 deps2 confl2 in
let t' = Timer.start () in
let st2 = Coinst.generate_rules (Quotient.trivial dist2) deps2' confl2' in
if debug_time () then begin
Format.eprintf " Rules: %f@." (Timer.stop t');
Format.eprintf " Target dist: %f@." (Timer.stop t)
end;
let t = Timer.start () in
let pred = compute_predecessors dist1 dist2 in
let new_conflicts = ref [] in
Conflict.iter confl2
(fun p2 q2 ->
let i = PTbl.get pred p2 in
let j = PTbl.get pred q2 in
if i <> -1 && j <> -1 then begin
let p1 = Package.of_index i in
let q1 = Package.of_index j in
if not (Conflict.check confl1 p1 q1) then begin
if debug_coinst () then begin
Format.eprintf "possible new conflict: %a %a@."
(Package.print_name dist1) p1
(Package.print_name dist1) q1;
end;
new_conflicts := (p2, q2) :: !new_conflicts;
end
end);
let results = ref PSetSet.empty in
let add_result s =
if not (PSetSet.mem s !results) then begin
if debug_coinst () then begin
Format.eprintf "==>";
PSet.iter
(fun p -> Format.eprintf " %a" (Package.print_name dist2) p) s;
Format.eprintf "@."
end;
results := PSetSet.add s !results
end
in
let is_installable p =
let res = M.Solver.solve st2 (Package.index p) in
M.Solver.reset st2;
res
and was_installable p =
let res = M.Solver.solve st1 (PTbl.get pred p) in
M.Solver.reset st1;
res
in
(*
(* Clearly non installable packages *)
PTbl.iteri
(fun p f ->
if
PTbl.get pred p <> -1 &&
Formula.implies f Formula._false && was_installable p
then
add_result (PSet.singleton p))
deps2';
*)
(* New conflict pairs *)
List.iter
(fun (p2, q2) ->
let pi = is_installable p2 in
let qi = is_installable q2 in
if not pi && was_installable p2 then add_result (PSet.singleton p2);
if not qi && was_installable q2 then add_result (PSet.singleton q2);
if pi && qi then begin
let i = PTbl.get pred p2 in
let j = PTbl.get pred q2 in
let p1 = Package.of_index i in
let q1 = Package.of_index j in
if M.Solver.solve_lst st1 [i; j] then begin
if debug then begin
Format.printf "new conflict: %a %a@."
(Package.print_name dist1) p1
(Package.print_name dist1) q1;
end;
add_result (PSet.add p2 (PSet.add q2 PSet.empty))
end else begin
if debug then begin
Format.printf "NOT new conflict: %a %a@."
(Package.print_name dist1) p1
(Package.print_name dist1) q1;
M.show_reasons dist1 (M.Solver.collect_reasons_lst st1 [i; j])
end
end;
M.Solver.reset st1
end)
!new_conflicts;
(* Only consider new dependencies. *)
let ignored_sets' = intern_ignored_sets dist2 !ignored_sets in
let possibly_ignored_packages =
ignored_set_domain_2 ignored_sets' in
let deps2 = new_deps pred possibly_ignored_packages deps1 dist2 deps2 in
(* Compute the corresponding flattened dependencies. *)
let deps2 =
PTbl.mapi
(fun p f ->
Formula.fold
(fun d f ->
Formula.conj
(PSet.fold
(fun p f -> Formula.disj (PTbl.get deps2' p) f)
(Disj.to_lits d) Formula._false) f)
f Formula._true)
deps2
in
(* Only keep those that are new... *)
let deps2 = new_deps pred PSet.empty deps1' dist2 deps2 in
(* ...and that are indeed in the flattened repository *)
let deps2 =
PTbl.mapi
(fun p f ->
let f' = PTbl.get deps2' p in
Formula.filter
(fun d ->
Formula.exists (fun d' -> Disj.equiv d d') f') f)
deps2
in
(* Only keep relevant conflicts. *)
let dep_targets = ref PSet.empty in
PTbl.iteri
(fun _ f ->
Formula.iter f
(fun d ->
Disj.iter d (fun p -> dep_targets := PSet.add p !dep_targets)))
deps2;
Conflict.iter confl2'
(fun p2 q2 ->
let i1 = PTbl.get pred p2 in
let j1 = PTbl.get pred q2 in
if
not ((PSet.mem p2 !dep_targets && j1 <> -1) ||
(PSet.mem q2 !dep_targets && i1 <> -1) ||
(PSet.mem p2 !dep_targets && PSet.mem q2 !dep_targets))
then
Conflict.remove confl2' p2 q2);
(*
List.iter
(fun (p2, q2) ->
if
not (PSet.mem p2 possibly_ignored_packages
||
PSet.mem q2 possibly_ignored_packages)
then
Conflict.remove confl2' p2 q2)
!new_conflicts;
*)
(* As a consequence, some new dependencies might not be relevant anymore. *)
let deps2 = Coinst.remove_clearly_irrelevant_deps confl2' deps2 in
(* Add self dependencies for packages with conflicts, as we want to
consider them as well to find possible problems. *)
let deps2 =
PTbl.mapi
(fun p f ->
if Conflict.has confl2' p && PTbl.get pred p <> -1 then
Formula.conj (Formula.lit p) f
else
f)
deps2
in
if debug_problem_graph () then
Graph.output "/tmp/newdeps.dot"
~package_weight:(fun p ->
if Formula.implies (Formula.lit p) (PTbl.get deps2 p) then
(if PTbl.get pred p = -1 then 1. else 10.)
else 1000.)
(Quotient.trivial dist2) deps2 confl2';
(*
Conflict.iter confl2' (fun p q -> Format.eprintf "%a ## %a@." (Package.print dist2) p (Package.print dist2) q);
PTbl.iteri (fun p f -> Format.eprintf "%a: %a@." (Package.print dist2) p (Formula.print dist2) f) deps2;
*)
if debug_time () then Format.eprintf " Init: %f@." (Timer.stop t);
let check s =
let now_installable s =
let res =
M.Solver.solve_lst st2 (List.map Package.index (PSet.elements s)) in
M.Solver.reset st2;
res
in
let l = PSet.elements s in
let was_coinstallable =
M.Solver.solve_lst st1 (List.map (fun p -> PTbl.get pred p) l)
in
M.Solver.reset st1;
if not was_coinstallable then begin
if debug then begin
Format.printf "Was not co-installable:";
List.iter (fun p -> Format.printf " %a" (Package.print_name dist2) p) l;
Format.printf "@.";
end;
false
end else if now_installable s then begin
if debug then begin
Format.printf "Still co-installable:";
List.iter (fun p -> Format.printf " %a" (Package.print_name dist2) p) l;
Format.printf "@.";
end;
true
end else begin
if
PSet.exists (fun p -> not (now_installable (PSet.remove p s))) s
then begin
if debug_coinst () then begin
Format.eprintf "Not minimal:";
List.iter (fun p -> Format.eprintf " %a" (Package.print_name dist2) p) l;
Format.eprintf "@.";
end;
end else begin
add_result s
end;
false
end
in
let t = Timer.start () in
find_problems dist2 deps2 confl2' check;
if debug_time () then
Format.eprintf " Enumerating problems: %f@." (Timer.stop t);
let results =
PSetSet.filter (fun s -> not (is_ignored_set_2 ignored_sets' s)) !results
in
(****)
let t = Timer.start () in
let all_pkgs = ref PSet.empty in
let all_conflicts = Conflict.create dist2 in
let dep_src = PTbl.create dist2 PSet.empty in
let dep_trg = PTbl.create dist2 PSet.empty in
let add_rel r p q = PTbl.set r p (PSet.add q (PTbl.get r p)) in
let broken_new_packages = ref PSet.empty in
if check_new_packages then begin
let forced_pkgs = forced_packages ignored_sets in
PTbl.iteri
(fun p _ ->
if
PTbl.get pred p = -1 &&
not (StringSet.mem (M.package_name dist2 (Package.index p))
forced_pkgs)
then begin
(*Format.eprintf "??? %a@." (Package.print dist2) p;*)
if not (M.Solver.solve st2 (Package.index p)) then begin
(*
M.Solver.solve st2init (Package.index p);
M.Solver.reset st2init;
*)
broken_new_packages := PSet.add p !broken_new_packages
end;
M.Solver.reset st2
end)
deps2
end;
(****)
let (graphs, broken_new_packages) =
if PSetSet.is_empty results && PSet.is_empty !broken_new_packages then
([], [])
else begin
let s = PSetSet.fold PSet.union results !broken_new_packages in
let t = Timer.start () in
let st2init = M.generate_rules_restricted dist2 (pset_indices s) in
if debug_time () then
Format.eprintf " Generating constraints: %f@." (Timer.stop t);
(List.map
(fun s ->
let l = List.map Package.index (PSet.elements s) in
let res = M.Solver.solve_lst st2init l in
assert (not res);
let r = M.Solver.collect_reasons_lst st2init l in
M.Solver.reset st2init;
let confl = Conflict.create dist2 in
let deps = PTbl.create dist2 Formula._true in
let pkgs = ref PSet.empty in
let package i =
let p = Package.of_index i in pkgs := PSet.add p !pkgs; p in
(*
if debug_coinst () then M.show_reasons dist2 r;
*)
List.iter
(fun r ->
match r with
M.R_conflict (n1, n2, _) ->
Conflict.add confl (package n1) (package n2);
Conflict.add all_conflicts (package n1) (package n2)
| M.R_depends (n, l) ->
let p = package n in
let l =
List.map package
(List.flatten
(List.map (M.resolve_package_dep dist2) l))
in
List.iter
(fun q ->
add_rel dep_src q p;
add_rel dep_trg p q)
l;
PTbl.set deps p
(Formula.conj (PTbl.get deps p)
(Formula.of_disj (Disj.lit_disj l))))
r;
all_pkgs := PSet.union !all_pkgs !pkgs;
let (clause, explanation, support1, support2) =
match reference with
Some dist2_state ->
problematic_packages
dist1_state.dist dist2 dist2_state.dist s r
| None ->
problematic_packages dist1_state.dist dist2 dist2 s r
in
(*
PSet.iter (fun p -> Format.printf " %a" (Package.print_name dist2) p) s;
Format.printf "==> %a@." (Formula.print dist1) ppkgs;
*)
{ i_issue = s;
i_problem =
{ p_clause = clause;
p_issue =
PSet.fold
(fun p s ->
StringSet.add (M.package_name dist2 (Package.index p))
s)
s StringSet.empty;
p_explain = explanation;
p_support1 = support1; p_support2 = support2 } })
(PSetSet.elements results),
PSet.fold
(fun p s ->
let i = Package.index p in
let res = M.Solver.solve st2init i in
assert (not res);
let r = M.Solver.collect_reasons st2init i in
M.Solver.reset st2init;
(*
if debug_coinst () then M.show_reasons dist2 r;
*)
let (clause, explanation, support1, support2) =
match reference with
Some dist2_state ->
problematic_packages
dist1_state.dist dist2 dist2_state.dist (PSet.singleton p) r
| None ->
problematic_packages
dist1_state.dist dist2 dist2 (PSet.singleton p) r
in
assert
(StringSet.mem (M.package_name dist2 (Package.index p))
clause.pos);
(p, clause, explanation, support1, support2) :: s)
!broken_new_packages [])
end
in
if debug_time () then
Format.eprintf " Analysing problems: %f@." (Timer.stop t);
(pred, !all_pkgs, all_conflicts, dep_src, graphs, broken_new_packages)
(****)
let get_clearly_broken_packages
dist1_state dist dist2_state can_break_package =
let t = Timer.start () in
let unsat_dep d =
not (List.exists (fun cstr -> M.dep_can_be_satisfied dist cstr) d) in
let was_installable p =
match M.find_packages_by_name dist1_state.dist p.M.package with
[] ->
true
| [q] ->
let res = M.Solver.solve dist1_state.st q.M.num in
M.Solver.reset dist1_state.st;
res
| _ ->
assert false
in
let problems = ref [] in
M.iter_packages dist
(fun p ->
let l =
List.filter unsat_dep p.M.depends @
List.filter unsat_dep p.M.pre_depends
in
if not (can_break_package p) && l <> [] && was_installable p then begin
List.iter
(fun d ->
if debug_coinst () then begin
let d' =
List.map (fun (id, rel) -> (M.name_of_id id, rel)) d in
Format.eprintf "Broken dependency: %a ==> %a@."
(Package.print dist) (Package.of_index p.M.num)
M.print_package_dependency [d']
end;
let r = [M.R_depends (p.M.num, d)] in
let (clause, explanation, support1, support2) =
problematic_packages dist1_state.dist dist dist2_state.dist
(PSet.singleton (Package.of_index p.M.num)) r
in
problems :=
{ p_clause = clause;
p_issue = StringSet.singleton (M.name_of_id p.M.package);
p_explain = explanation;
p_support1 = support1; p_support2 = support2 }
:: !problems)
l
end);
if debug_coinst () then
Format.eprintf ">>> %a@."
(Util.print_list (fun ch p -> print_clause ch p.p_clause) ", ")
!problems;
if debug_time () then Format.eprintf " Clearly broken: %f@." (Timer.stop t);
!problems
let analyze_installability dist1_state dist dist2_state can_break_package =
let t = Timer.start () in
let (deps, confl) = Coinst.compute_dependencies_and_conflicts dist in
if debug_time () then
Format.eprintf " Deps and confls: %f@." (Timer.stop t);
let (deps', confl') = Coinst.flatten_and_simplify dist deps confl in
let t' = Timer.start () in
let st = Coinst.generate_rules (Quotient.trivial dist) deps' confl' in
if debug_time () then
Format.eprintf " Generate rules: %f@." (Timer.stop t');
if debug_time () then Format.eprintf " Preparing: %f@." (Timer.stop t);
let package_name p =
(M.find_package_by_num dist (Package.index p)).M.package in
let is_installable p =
let res = M.Solver.solve st (Package.index p) in
M.Solver.reset st;
res
and was_installable p =
let nm = package_name p in
match M.find_packages_by_name dist1_state.dist nm with
[] ->
true
| [q] ->
let res = M.Solver.solve dist1_state.st q.M.num in
M.Solver.reset dist1_state.st;
res
| _ ->
assert false
in
let broken_pkgs = ref PSet.empty in
let to_consider = ListTbl.create 101 in
let add_package p f =
let f = Formula.normalize f in
ListTbl.add to_consider f p
in
PTbl.iteri
(fun p f ->
if
not (Formula.implies Formula._true f) &&
(Formula.implies f Formula._false ||
Formula.fold (fun _ n -> n + 1) f 0 > 1) &&
not (can_break_package (M.find_package_by_num dist (Package.index p)))
then
add_package p f)
deps';
ListTbl.iter
(fun f l ->
let p = List.hd l in
if not (is_installable p) then begin
let l = List.filter was_installable l in
broken_pkgs := List.fold_right PSet.add l !broken_pkgs
end)
to_consider;
let pr_t = Timer.start () in
let problems =
if PSet.is_empty !broken_pkgs then
[]
else begin
let st_init =
M.generate_rules_restricted dist (pset_indices !broken_pkgs) in
PSet.fold
(fun p l ->
let i = Package.index p in
let res = M.Solver.solve st_init i in
assert (not res);
let r = M.Solver.collect_reasons st_init i in
M.Solver.reset st_init;
let (clause, explanation, support1, support2) =
problematic_packages dist1_state.dist dist dist2_state.dist
(PSet.singleton p) r
in
{ p_clause = clause;
p_issue = StringSet.singleton (M.name_of_id (package_name p));
p_explain = explanation;
p_support1 = support1; p_support2 = support2 } :: l)
!broken_pkgs []
end
in
if debug_time () then begin
Format.eprintf " Computing problems: %f@." (Timer.stop pr_t);
Format.eprintf " Finding non-inst packages: %f@." (Timer.stop t)
end;
problems
(****)
let find_problematic_packages
?(check_new_packages = false) ignored_sets
dist1_state dist2_state is_preserved =
let t = Timer.start () in
let dist2 = M.new_pool () in
M.merge dist2 (fun p -> not (is_preserved p.M.package)) dist2_state.dist;
M.merge dist2 (fun p -> is_preserved p.M.package) dist1_state.dist;
if debug_time () then
Format.eprintf " Building target dist: %f@." (Timer.stop t);
let forced_pkgs = forced_packages ignored_sets in
let can_break_package p =
(*
(break_arch_all && p.M.architecture = "all")
||
*)
StringSet.mem (M.name_of_id p.M.package) forced_pkgs in
let problems =
get_clearly_broken_packages dist1_state dist2 dist2_state can_break_package
in
if
List.exists (fun p -> StringSet.cardinal p.p_clause.pos = 1)
problems
then
problems
else
let (_, _, _, _, graphs, broken_new_packages) =
analyze ~check_new_packages ignored_sets
~reference:dist2_state dist1_state dist2
in
let t = Timer.start () in
let problems =
List.map (fun i -> i.i_problem) graphs
@
List.map
(fun (p, ppkgs, explanation, support1, support2) ->
{ p_clause = ppkgs;
p_issue =
StringSet.singleton (M.package_name dist2 (Package.index p));
p_explain = explanation;
p_support1 = support1; p_support2 = support2 })
broken_new_packages
in
if debug_coinst () then
Format.eprintf ">>> %a@."
(Util.print_list (fun ch p -> print_clause ch p.p_clause) ", ")
problems;
if debug_time () then
Format.eprintf " Compute problematic package names: %f@." (Timer.stop t);
problems
let find_non_inst_packages
break_arch_all ignored_sets dist1_state dist2_state is_preserved =
let t = Timer.start () in
let dist = M.new_pool () in
M.merge dist (fun p -> not (is_preserved p.M.package)) dist2_state.dist;
M.merge dist (fun p -> is_preserved p.M.package) dist1_state.dist;
if debug_time () then
Format.eprintf " Building target dist: %f@." (Timer.stop t);
let forced_pkgs = forced_packages ignored_sets in
let can_break_package p =
(break_arch_all && p.M.architecture = "all")
||
StringSet.mem (M.name_of_id p.M.package) forced_pkgs
in
let problems =
get_clearly_broken_packages dist1_state dist dist2_state
can_break_package in
if
List.exists (fun p -> StringSet.cardinal p.p_clause.pos = 1)
problems
then
problems
else begin
let problems =
analyze_installability dist1_state dist dist2_state can_break_package in
if debug_coinst () then
Format.eprintf ">>> %a@."
(Util.print_list (fun ch p -> print_clause ch p.p_clause) ", ")
problems;
problems
end
(****)
module Union_find = Util.Union_find
let find_clusters dist1_state dist2_state is_preserved groups merge =
let dist2 = M.new_pool () in
M.merge dist2 (fun p -> true) dist1_state.dist;
let first_new = M.pool_size dist2 in
M.merge dist2 (fun p -> not (is_preserved p.M.package)) dist2_state.dist;
let first_dummy = M.pool_size dist2 in
let group_reprs = Hashtbl.create 101 in
let group_classes = Hashtbl.create 101 in
let group_pkgs = Hashtbl.create 101 in
let group_other_pkg = Hashtbl.create 101 in
List.iter
(fun (l, elt) ->
let q = List.hd l in
let pkg v =
let pseudo = "<" ^ q ^ "/" ^ v ^ ">" in
Hashtbl.add group_reprs pseudo q;
let provides = M.add_name ("<" ^ q ^ ">") in
let v = M.parse_version "0" in
{ M.num = 0; package = M.add_name pseudo;
version = v; source = (M.add_name pseudo, v);
section = ""; architecture = "";
depends = []; recommends = []; suggests = []; enhances = [];
pre_depends = []; provides = [[provides, None]];
conflicts = [[provides, None]];
breaks = []; replaces = [] }
in
let old_grp = Package.of_index (M.add_package dist2 (pkg "OLD")) in
let new_grp = Package.of_index (M.add_package dist2 (pkg "NEW")) in
Hashtbl.add group_pkgs q (old_grp, new_grp);
Hashtbl.add group_other_pkg old_grp new_grp;
Hashtbl.add group_other_pkg new_grp old_grp;
Hashtbl.add group_classes q elt;
List.iter (fun p -> Hashtbl.add group_reprs p q) l)
groups;
let group_repr p =
let nm = M.package_name dist2 (Package.index p) in
try Hashtbl.find group_reprs nm with Not_found -> ""
in
let same_group p q = group_repr p == group_repr q in
let group_class p =
try Some (Hashtbl.find group_classes p) with Not_found -> None
in
let old_version = PTbl.init dist2 (fun p -> p) in
let new_version = PTbl.init dist2 (fun p -> p) in
M.iter_packages_by_name dist2
(fun nm l ->
match l with
[p] ->
()
| [p; q] ->
let i = min p.M.num q.M.num in
let j = max p.M.num q.M.num in
PTbl.set old_version (Package.of_index j) (Package.of_index i);
PTbl.set new_version (Package.of_index i) (Package.of_index j)
| _ ->
assert false);
let is_old p = Package.index p < first_new in
let is_new p =
Package.index p >= first_new && Package.index p < first_dummy in
let is_dummy p = Package.index p >= first_dummy in
let is_removed = PTbl.create dist2 false in
M.iter_packages dist2
(fun p ->
if not (M.has_package_of_name dist2_state.dist p.M.package) then
PTbl.set is_removed (Package.of_index p.M.num) true);
let (deps2full, confl2full) =
Coinst.compute_dependencies_and_conflicts dist2 in
let confl2 = Conflict.create dist2 in
Conflict.iter confl2full
(fun p q ->
let p' = PTbl.get old_version p in
let q' = PTbl.get old_version q in
(* We omit conflicts between old and new version of packages
in a same group. *)
if
(is_old p && is_old q) || (is_new p && is_new q) ||
is_dummy p || not (same_group p q)
then
Conflict.add confl2 p' q');
let marked_conj o old_f n new_f =
let common_part f f' =
Formula.filter
(fun d -> Formula.exists (fun d' -> Disj.implies d' d) f) f'
in
let common_f =
Formula.conj (common_part old_f new_f) (common_part new_f old_f) in
Formula.conj
(Formula.conj common_f (Formula.disj (Formula.lit n) old_f))
(Formula.disj (Formula.lit o) new_f)
in
let quotient_formula p f =
Formula.fold
(fun d f ->
let disj = Disj.to_lits d in
let variable_part = PSet.filter (fun p -> group_repr p <> "") disj in
if PSet.is_empty variable_part then
Formula.conj (Formula.of_disj d) f
else begin
let stable_part = PSet.filter (fun p -> group_repr p = "") disj in
let s =
PSet.fold (fun p s -> StringSet.add (group_repr p) s)
variable_part StringSet.empty
in
(*
Format.eprintf "Involved (%s / %a):" (group_repr p) (Package.print dist2) p;
StringSet.iter (fun nm -> Format.eprintf " %s" nm) s;
Format.eprintf "@.";
*)
let f' =
StringSet.fold
(fun nm f ->
let s1 =
PSet.filter
(fun p -> is_new p && group_repr p = nm) variable_part
in
let s2 =
PSet.filter
(fun p -> is_old p && group_repr p = nm) variable_part
in
let d1 =
PSet.fold
(fun p d ->
Disj.disj (Disj.lit (PTbl.get old_version p)) d)
s1 Disj._false
in
let d2 = Disj.of_lits s2 in
(*
Format.eprintf "?? %b %b %a %a@." (nm = group_repr p) (is_old p) (Disj.print dist2) d1 (Disj.print dist2) d2;
*)
Formula.disj
(if Disj.equiv d1 d2 then
Formula.of_disj d1
else if nm <> group_repr p then
(*
Formula.conj
(Formula.of_disj d1)
(Formula.of_disj d2)
*)
let (o, n) = Hashtbl.find group_pkgs nm in
marked_conj
o (Formula.of_disj d2) n (Formula.of_disj d1)
(*
Formula.conj
(Formula.of_disj (Disj.disj d1 (Disj.lit o)))
(Formula.of_disj (Disj.disj d2 (Disj.lit n)))
*)
else if is_old p then
Formula.of_disj d2
else
Formula.of_disj d1)
f)
s Formula._false
in
let f' =
Formula.disj f' (Formula.of_disj (Disj.of_lits stable_part)) in
(*
Format.eprintf "%a ==> %a@." (Disj.print dist2) d (Formula.print dist2) f';
*)
Formula.conj f f'
end)
f Formula._true
in
let deps2 = PTbl.mapi quotient_formula deps2full in
PTbl.iteri
(fun p f ->
let q = PTbl.get old_version p in
if p <> q then begin
let nm = group_repr p in
let (o, n) = Hashtbl.find group_pkgs nm in
PTbl.set deps2 q
(marked_conj o (PTbl.get deps2 q) n (PTbl.get deps2 p));
(*
(Formula.conj (Formula.disj (Formula.lit n) (PTbl.get deps2 q)) (Formula.disj (Formula.lit o) (PTbl.get deps2 p)));
*)
(*
PTbl.set deps2 q (Formula.conj (PTbl.get deps2 q) (PTbl.get deps2 p));
*)
PTbl.set deps2 p Formula._true
end else if is_new q then begin
let nm = group_repr p in
let (o, n) = Hashtbl.find group_pkgs nm in
PTbl.set deps2 q (Formula.disj (Formula.lit o) (PTbl.get deps2 q))
end else if PTbl.get is_removed p then begin
let nm = group_repr p in
if nm <> "" then begin
let (o, n) = Hashtbl.find group_pkgs nm in
PTbl.set deps2 q (Formula.disj (Formula.lit n) (PTbl.get deps2 q))
end
end)
deps2;
(*
PTbl.iteri
(fun p f ->
Format.eprintf "%a: %a@." (Package.print dist2) p (Formula.print dist2) f)
deps2;
*)
let (deps2', confl2') = Coinst.flatten_and_simplify dist2 deps2 confl2 in
let pred = compute_predecessors dist1_state.dist dist2 in
let confl1 = dist1_state.confl in
let new_conflicts = ref [] in
Conflict.iter confl2
(fun p2 q2 ->
let i = PTbl.get pred p2 in
let j = PTbl.get pred q2 in
if i <> -1 && j <> -1 then begin
let p1 = Package.of_index i in
let q1 = Package.of_index j in
if not (Conflict.check confl1 p1 q1) then begin
if debug_coinst () then begin
Format.eprintf "possible new conflict: %a %a@."
(Package.print_name dist1_state.dist) p1
(Package.print_name dist1_state.dist) q1;
end;
new_conflicts := (p2, q2) :: !new_conflicts;
end
end);
(* Only consider new dependencies. *)
let deps2 = new_deps pred PSet.empty dist1_state.deps dist2 deps2 in
(* Compute the corresponding flattened dependencies. *)
let deps2 =
PTbl.mapi
(fun p f ->
Formula.fold
(fun d f ->
Formula.conj
(PSet.fold
(fun p f -> Formula.disj (PTbl.get deps2' p) f)
(Disj.to_lits d) Formula._false) f)
f Formula._true)
deps2
in
(* Only keep those that are new... *)
let deps2 = new_deps pred PSet.empty dist1_state.deps' dist2 deps2 in
(* ...and that are indeed in the flattened repository *)
let deps2 =
PTbl.mapi
(fun p f ->
let f' = PTbl.get deps2' p in
Formula.filter
(fun d ->
Formula.exists (fun d' -> Disj.equiv d d') f') f)
deps2
in
(* Only keep relevant conflicts. *)
let dep_targets = ref PSet.empty in
PTbl.iteri
(fun _ f ->
Formula.iter f
(fun d ->
Disj.iter d (fun p -> dep_targets := PSet.add p !dep_targets)))
deps2;
Conflict.iter confl2'
(fun p2 q2 ->
let i1 = PTbl.get pred p2 in
let j1 = PTbl.get pred q2 in
if
not (is_dummy p2 ||
(PSet.mem p2 !dep_targets && j1 <> -1) ||
(PSet.mem q2 !dep_targets && i1 <> -1) ||
(PSet.mem p2 !dep_targets && PSet.mem q2 !dep_targets))
then
Conflict.remove confl2' p2 q2);
(*
List.iter (fun (p2, q2) -> Conflict.remove confl2' p2 q2) !new_conflicts;
*)
(* As a consequence, some new dependencies might not be relevant anymore. *)
let deps2 = Coinst.remove_clearly_irrelevant_deps confl2' deps2 in
(* Add self dependencies for packages with conflicts, as we want to
consider them as well to find possible problems. *)
let deps2 =
PTbl.mapi
(fun p f ->
if Conflict.has confl2' p && PTbl.get pred p <> -1 then
Formula.conj (Formula.lit p) f
else
f)
deps2
in
let merge v v' =
match v, v' with
Some c, Some c' -> merge c c'; v
| Some _, None -> v
| None, Some _ -> v'
| None, None -> None
in
let group_confl = Hashtbl.create 101 in
PTbl.iteri
(fun p f ->
Formula.iter f
(fun d ->
if debug_cluster () then begin
Format.eprintf "New dep %a ==> %a@."
(Package.print_name dist2) p
(Disj.print dist2) d
end;
let c =
if Disj.implies1 p d then begin
if debug_cluster () then begin
let s = group_repr p in
if s <> "" then Format.eprintf " ==> %s@." s
end;
group_class (group_repr p)
end else
Disj.fold
(fun p c ->
if is_dummy p then begin
if debug_cluster () then begin
let s = group_repr p in
if s <> "" then Format.eprintf " ==> %s@." s
end;
merge c (group_class (group_repr p))
end else
c)
d None
in
let c = Union_find.elt c in
Disj.iter d
(fun p ->
if not (is_dummy p) then
let c' =
try
Hashtbl.find group_confl p
with Not_found ->
Union_find.elt None
in
Union_find.merge c c' merge;
Hashtbl.replace group_confl p c)))
deps2;
Conflict.iter confl2'
(fun p p' ->
if not (is_dummy p) then begin
(*
Format.eprintf "Old conflict %a ## %a@."
(Package.print dist2) p (Package.print dist2) p';
*)
try
let c = Hashtbl.find group_confl p in
let c' = Hashtbl.find group_confl p' in
Union_find.merge c c' merge
with Not_found ->
assert false
end);
List.iter
(fun (p, p') ->
let c = group_class (group_repr p) in
let c' = group_class (group_repr p') in
if debug_cluster () then
Format.eprintf "New conflict %s ## %s@." (group_repr p) (group_repr p');
ignore (merge c c'))
!new_conflicts;
PTbl.iteri
(fun p f ->
if is_new p && PTbl.get old_version p = p then begin
if debug_cluster () then
Format.eprintf "New package %a ==> %a@."
(Package.print_name dist2) p
(Formula.print dist2) f;
Formula.iter f
(fun d ->
ignore
(Disj.fold
(fun p c ->
if is_dummy p then
merge c (group_class (group_repr p))
else
c)
d None))
end)
deps2'
(****)
(*
type pkg_ref = string * bool * bool
type reason =
R_depends of pkg_ref * M.dep * pkg_ref list
| R_conflict of pkg_ref * M.dep * pkg_ref
*)
module D = Dot_file
let output_conflict_graph f problem =
let conflict = problem.p_issue in
let reasons = problem.p_explain in
let i = ref 0 in
let pkg (nm, _, _) = nm in
let line_style t u =
match t, u with
true, false -> ["dotted"]
| false, true -> ["dashed"]
| true, true -> []
| _ -> assert false
in
let make_style l = if l = [] then [] else ["style", String.concat "," l] in
let new_node () = incr i; D.node (string_of_int !i) in
let pkgs = Hashtbl.create 17 in
let pkg_node nm rem =
if Hashtbl.mem pkgs nm then rem else begin
Hashtbl.add pkgs nm ();
let t = StringSet.mem nm problem.p_support1 in
let u = StringSet.mem nm problem.p_support2 in
let st = line_style t u in
let color =
if StringSet.mem nm conflict then
make_style ("filled" :: st) @ ["fillcolor", "#ebc885"]
else
make_style st
in
`Compound ([D.node nm], ("label", nm) :: color) :: rem
end
in
let style (_, t, u) = make_style (line_style t u) in
let in_dep = Hashtbl.create 17 in
List.iter
(fun r ->
match r with
R_depends (_, _, l) ->
List.iter (fun (nm, _, _) -> Hashtbl.add in_dep nm ()) l
| R_conflict _ ->
())
reasons;
let l =
`Attributes (`Graph, ["rankdir", "LR"]) ::
`Attributes
(`Node, ["fontsize", "8"; "margin", "0.05,0"; "height", "0.2";
"style", "rounded"]) ::
List.fold_right
(fun r l ->
match r with
R_depends (p, _, []) ->
let n = new_node () in
pkg_node (pkg p) (
`Compound
([n], ["color", "blue"; "shape", "box"; "label", "NONE"]) ::
`Compound ([D.node (pkg p); n],
style p @ ["color", "blue"; "minlen", "2"]) :: l)
| R_depends (p, _, [q]) ->
let pstyle = style p in
let qstyle = style q in
pkg_node (pkg p) (
pkg_node (pkg q) (
if pstyle = qstyle then begin
`Compound ([D.node (pkg p); D.node (pkg q)],
pstyle @ ["color", "blue"; "minlen", "2"]) :: l
end else begin
let n = new_node () in
`Compound ([n], ["label", ""; "fixedsize", "true";
"width", "0.0"; "height", "0";
"shape", "none"]) ::
`Compound ([D.node (pkg p); n],
pstyle @ ["color", "blue"; "dir", "none"]) ::
`Compound ([n; D.node (pkg q)],
qstyle @ ["color", "blue"]) :: l
end))
| R_depends (p, _, pl) ->
let n = new_node () in
pkg_node (pkg p) (
List.fold_right (fun q rem -> pkg_node (pkg q) rem) pl (
`Compound
([n],
["label", "∨"; "shape", "circle";
"color", "blue"; "fontcolor", "blue"]) ::
`Compound
([D.node (pkg p); n],
style p @ ["color", "blue"; "dir", "none"]) ::
List.map
(fun p ->`Compound ([n; D.node (pkg p)],
style p @ ["color", "blue"]))
pl @
l))
| R_conflict (p1, _, p2) ->
(*
let print_ref f (nm, t, u) =
match t, u with
true, true -> Format.fprintf f "%s" nm
| true, false -> Format.fprintf f "%s (testing)" nm
| false, true -> Format.fprintf f "%s (sid)" nm
| false, false -> assert false
in
Format.eprintf "| %a ## %a@." print_ref p1 print_ref p2;
*)
let (p1, p2) =
if
Hashtbl.mem in_dep (pkg p2) &&
not (Hashtbl.mem in_dep (pkg p1))
then
(p2, p1)
else
(p1, p2)
in
let style1 = style p1 in
let style2 = style p2 in
let attrs = ["dir", "none"; "color", "red"] in
pkg_node (pkg p1) (
pkg_node (pkg p2) (
if style1 = style2 then begin
`Compound ([D.node (pkg p1); D.node (pkg p2)],
("minlen", "2") :: style1 @ attrs) :: l
end else begin
let n = new_node () in
`Compound ([n], ["label", ""; "fixedsize", "true";
"width", "0.0"; "height", "0";
"shape", "none"]) ::
`Compound ([D.node (pkg p1); n], style1 @ attrs) ::
`Compound ([n; D.node (pkg p2)], style2 @ attrs) :: l
end)))
reasons []
in
D.print f (D.graph `Digraph "G" l)
(****)
let conj_inter l l' =
match l, l' with
None, None -> None
| Some _ , None -> l
| None, Some _ -> l'
| Some s, Some s' -> Some (PSet.inter s s')
let conj_union l l' =
match l, l' with
| Some s, Some s' -> Some (PSet.union s s')
| _ -> None
let rec conj_deps tbl dist deps visited l =
Formula.fold
(fun d (l, r) ->
let (l', r') =
Disj.fold
(fun i (l, r) ->
let (l', r') = conj_dep tbl dist deps visited i in
(conj_inter l' l, PSet.union r r')) d (None, r)
in
(conj_union l' l, r'))
l (Some PSet.empty, PSet.empty)
and conj_dep tbl dist deps visited i =
try
(Hashtbl.find tbl i, PSet.empty)
with Not_found ->
let res =
if List.mem i visited then
(Some PSet.empty, PSet.singleton i)
else begin
let (l, r) =
conj_deps tbl dist deps (i :: visited) (PTbl.get deps i)
in
(*
Format.eprintf "XXX %a: %a (%d)@."
(Package.print_name dist) i (Formula.print dist) (PTbl.get deps i) (match l with Some s -> PSet.cardinal s | None -> -1);
*)
let r = PSet.remove i r in
(conj_union (Some (PSet.singleton i)) l, r)
end
in
(* Only cache the result if it is unconditionally true *)
if PSet.is_empty (snd res) then Hashtbl.add tbl i (fst res);
res
let conj_dependencies dist deps =
let tbl = Hashtbl.create 17 in
PTbl.init dist (fun p -> fst (conj_dep tbl dist deps [] p))
let reversed_conj_dependencies dist deps =
let tbl = PTbl.create dist PSet.empty in
let tbl' = conj_dependencies dist deps in
PTbl.iteri
(fun p l ->
match l with
None ->
()
| Some s ->
PSet.iter
(fun p' ->
(*
Format.eprintf "YYY %a -> %a@."
(Package.print_name dist) p (Package.print_name dist) p';
*)
PTbl.set tbl p' (PSet.add p (PTbl.get tbl p'))) s)
tbl';
tbl
(**** Breaking co-installability ****)
let comma_re = Str.regexp "[ \t]*,[ \t]*"
let bar_re = Str.regexp "[ \t]*|[ \t]*"
let empty_break_set () = ref []
let allow_broken_sets broken_sets s =
let l = Str.split comma_re (Util.trim s) in
let ext = List.mem "_" l in
let l = List.filter (fun s -> s <> "_") l in
(* XXXX Should disallow specs such that a,a *)
let l =
List.fold_left
(fun l s ->
List.fold_left
(fun s nm -> StringSet.add nm s)
StringSet.empty (Str.split bar_re s)
:: l)
[] l
in
broken_sets := (l, ext) :: !broken_sets
let copy_ignored_sets l = ref !l
|