1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244
|
Index: combblas/CMakeLists.txt
===================================================================
--- combblas.orig/CMakeLists.txt 2025-09-28 01:20:56.595566436 +0200
+++ combblas/CMakeLists.txt 2025-09-28 01:25:22.941315193 +0200
@@ -1,46 +1,39 @@
-cmake_minimum_required(VERSION 3.3)
+cmake_minimum_required(VERSION 3.20...4.0)
project(CombBLAS VERSION 2.0.0 LANGUAGES C CXX)
-# require c++14
-set(CMAKE_CXX_STANDARD 14)
+# require c++17
+set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED YES)
set(CMAKE_CXX_EXTENSIONS OFF)
+include(GNUInstallDirs)
+
# Main CombBLAS library
add_library(CombBLAS src/CommGrid.cpp src/mmio.c src/MPIType.cpp src/MPIOp.cpp src/MemoryPool.cpp src/hash.cpp)
-# require c++14 in CombBLAS interface
-if("cxx_std_14" IN_LIST CMAKE_CXX_COMPILE_FEATURES) # Use language feature if available (CMake >= 3.8)
- target_compile_features(CombBLAS PUBLIC cxx_std_14)
-else()
- # Use C++14-specific features for CMake >= 3.3, which will force the appropriate language level flags.
- target_compile_features(CombBLAS PUBLIC cxx_return_type_deduction)
-endif()
-
# set include directories
-target_include_directories(CombBLAS PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> $<INSTALL_INTERFACE:include>)
-target_include_directories(CombBLAS PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/psort-1.0/include> $<INSTALL_INTERFACE:include>)
-target_include_directories(CombBLAS PRIVATE include/CombBLAS)
+target_include_directories(CombBLAS PUBLIC
+ $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+ $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/psort-1.0/include>
+ $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
+ PRIVATE include/CombBLAS
+)
-# MPI and OpenMP dependencies
+# MPI dependencies
find_package(MPI REQUIRED)
+if(TARGET MPI::MPI_CXX)
+ target_link_libraries(CombBLAS PUBLIC MPI::MPI_CXX)
+endif()
+
+# OpenMP dependencies
find_package(OpenMP)
+option(USE_OPENMP "default on, but can be turned off by users" ON)
-if(TARGET MPI::MPI_CXX) # Use target if available (CMake >= 3.9)
- target_link_libraries(CombBLAS PUBLIC MPI::MPI_CXX)
-else()
- target_compile_options(CombBLAS PUBLIC "${MPI_CXX_COMPILE_FLAGS}")
- target_link_libraries(CombBLAS PUBLIC "${MPI_CXX_LIBRARIES}" "${MPI_CXX_LINKFLAGS}")
- target_include_directories(CombBLAS PUBLIC "${MPI_CXX_INCLUDE_PATH}")
+if(TARGET OpenMP::OpenMP_CXX)
+if(USE_OPENMP)
+ target_compile_definitions(CombBLAS PUBLIC THREADED)
+ target_link_libraries(CombBLAS PUBLIC OpenMP::OpenMP_CXX)
endif()
-
-if(TARGET OpenMP::OpenMP_CXX) # Use target if available (CMake >= 3.9)
- target_compile_definitions(CombBLAS PUBLIC THREADED)
- target_link_libraries(CombBLAS PUBLIC OpenMP::OpenMP_CXX)
-elseif(OPENMP_FOUND)
- target_compile_definitions(CombBLAS PUBLIC THREADED)
- target_compile_options(CombBLAS PUBLIC "${OpenMP_CXX_FLAGS}")
- target_link_libraries(CombBLAS PUBLIC "${OpenMP_CXX_FLAGS}")
endif()
add_subdirectory(usort)
@@ -56,7 +49,7 @@
# modifications to CombBLAS and have the changes automatically recompiled for
# dependent projects.
# Either way, we need to create a CombBLASConfig.cmake.
-set(ConfigPackageLocation lib/cmake/CombBLAS)
+set(ConfigPackageLocation ${CMAKE_INSTALL_LIBDIR}/cmake/CombBLAS)
# Generate version number header
include(GenerateExportHeader)
@@ -64,34 +57,21 @@
set_target_properties(CombBLAS PROPERTIES VERSION ${CombBLAS_VERSION})
# installation
-install(DIRECTORY include/ DESTINATION include)
-install(DIRECTORY psort-1.0/include/ DESTINATION include)
-install(TARGETS CombBLAS EXPORT CombBLASTargets
- LIBRARY DESTINATION lib
- ARCHIVE DESTINATION lib
- RUNTIME DESTINATION bin
- INCLUDES DESTINATION include
- )
+install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+install(DIRECTORY psort-1.0/include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+install(TARGETS CombBLAS EXPORT CombBLASTargets)
include(CMakePackageConfigHelpers)
+configure_package_config_file(cmake/CombBLASConfig.cmake
+ "${CMAKE_CURRENT_BINARY_DIR}/CombBLAS/CombBLASConfig.cmake"
+ INSTALL_DESTINATION ${ConfigPackageLocation}
+)
write_basic_package_version_file(
"${CMAKE_CURRENT_BINARY_DIR}/CombBLAS/CombBLASConfigVersion.cmake"
VERSION ${CombBLAS_VERSION}
COMPATIBILITY AnyNewerVersion
)
-
-# The following commands allow for option 2.
-export(EXPORT CombBLASTargets
- FILE "${CMAKE_CURRENT_BINARY_DIR}/CombBLAS/CombBLASTargets.cmake"
- NAMESPACE CombBLAS::
- )
-configure_file(cmake/CombBLASConfig.cmake
- "${CMAKE_CURRENT_BINARY_DIR}/CombBLAS/CombBLASConfig.cmake"
- COPYONLY
- )
-
-# Allow for option 2
install(EXPORT CombBLASTargets
FILE
CombBLASTargets.cmake
@@ -99,11 +79,16 @@
CombBLAS::
DESTINATION
${ConfigPackageLocation}
- )
-export(PACKAGE CombBLAS)
+)
+
+# The following command allow for option 2.
+export(EXPORT CombBLASTargets
+ FILE "${CMAKE_CURRENT_BINARY_DIR}/CombBLAS/CombBLASTargets.cmake"
+ NAMESPACE CombBLAS::
+ )
install(
FILES
- cmake/CombBLASConfig.cmake
+ "${CMAKE_CURRENT_BINARY_DIR}/CombBLAS/CombBLASConfig.cmake"
"${CMAKE_CURRENT_BINARY_DIR}/CombBLAS/CombBLASConfigVersion.cmake"
DESTINATION
${ConfigPackageLocation}
Index: combblas/ReleaseTests/CMakeLists.txt
===================================================================
--- combblas.orig/ReleaseTests/CMakeLists.txt 2025-09-28 01:20:56.595566436 +0200
+++ combblas/ReleaseTests/CMakeLists.txt 2025-09-28 01:20:56.589928273 +0200
@@ -40,7 +40,16 @@
ADD_TEST(NAME GenMMWrite_Test COMMAND ${MPIEXEC} ${MPIEXEC_NUMPROC_FLAG} 4 $<TARGET_FILE:GenWrMat> 20 16 1 scale20_ef16_symmetric.mtx)
ADD_TEST(NAME Multiplication_Test COMMAND ${MPIEXEC} ${MPIEXEC_NUMPROC_FLAG} 4 $<TARGET_FILE:MultTest> ../TESTDATA/rmat_scale16_A.mtx ../TESTDATA/rmat_scale16_B.mtx ../TESTDATA/rmat_scale16_productAB.mtx ../TESTDATA/x_65536_halfdense.txt ../TESTDATA/y_65536_halfdense.txt )
-ADD_TEST(NAME SpGEMM3D_Test COMMAND ${MPIEXEC} ${MPIEXEC_NUMPROC_FLAG} 16 $<TARGET_FILE:SpGEMM3DTest> ../TESTDATA/rmat_scale16_A.mtx ../TESTDATA/rmat_scale16_B.mtx ../TESTDATA/rmat_scale16_productAB.mtx )
+
+# Set number of processes based on platform
+if(APPLE) # osx usually has less cores, so make it 4 for just correctness check
+ set(TEST_PROCS 4)
+else()
+ set(TEST_PROCS 16)
+endif()
+ADD_TEST(NAME SpGEMM3D_Test COMMAND ${MPIEXEC} ${MPIEXEC_NUMPROC_FLAG} ${TEST_PROCS} $<TARGET_FILE:SpGEMM3DTest> ../TESTDATA/rmat_scale16_A.mtx ../TESTDATA/rmat_scale16_B.mtx ../TESTDATA/rmat_scale16_productAB.mtx )
+
+
ADD_TEST(NAME HashSpGEMMTest COMMAND ${MPIEXEC} ${MPIEXEC_NUMPROC_FLAG} 1 $<TARGET_FILE:HashSpGEMMTest> ../TESTDATA/rmat_scale16_A.mtx ../TESTDATA/rmat_scale16_B.mtx ../TESTDATA/rmat_scale16_productAB.mtx )
ADD_TEST(NAME Reduction_Test COMMAND ${MPIEXEC} ${MPIEXEC_NUMPROC_FLAG} 4 $<TARGET_FILE:ReduceTest> ../TESTDATA/sprand10000 ../TESTDATA/sprand10000_sumcols ../TESTDATA/sprand10000_sumrows)
ADD_TEST(NAME Iterator_Test COMMAND ${MPIEXEC} ${MPIEXEC_NUMPROC_FLAG} 4 $<TARGET_FILE:IteratorTest> ../TESTDATA sprand10000)
Index: combblas/ReleaseTests/SpGEMM3DTest.cpp
===================================================================
--- combblas.orig/ReleaseTests/SpGEMM3DTest.cpp 2025-09-28 01:20:56.595566436 +0200
+++ combblas/ReleaseTests/SpGEMM3DTest.cpp 2025-09-28 01:20:56.590431101 +0200
@@ -71,7 +71,12 @@
// Increase number of layers 1 -> 4 -> 16
for(int layers = 1; layers <= 16; layers = layers * 4){
-
+ if(layers > nprocs){
+ if(myrank == 0){
+ printf("we only have %d mpi processes, skip layer %d test \n", nprocs, layers);
+ }
+ continue;
+ }
if(myrank == 0) fprintf(stderr, "Trying %d layers\n", layers);
// Convert 2D matrices to 3D
Index: combblas/graph500-1.2/generator/CMakeLists.txt
===================================================================
--- combblas.orig/graph500-1.2/generator/CMakeLists.txt 2025-09-28 01:20:56.595566436 +0200
+++ combblas/graph500-1.2/generator/CMakeLists.txt 2025-09-28 01:20:56.590849920 +0200
@@ -1,16 +1,14 @@
# Top level directory has the include files
ADD_LIBRARY( GraphGenlib btrd_binomial_distribution.c splittable_mrg.c mrg_transitions.c graph_generator.c permutation_gen.c make_graph.c utils.c scramble_edges.c)
-target_include_directories(GraphGenlib PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> $<INSTALL_INTERFACE:include>)
-target_include_directories(GraphGenlib PRIVATE include/graph500/generator)
+target_include_directories(GraphGenlib PUBLIC
+ $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+ $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
+ PRIVATE include/graph500/generator
+)
if(CMAKE_C_COMPILER_ID STREQUAL "Intel")
target_compile_options(GraphGenlib PRIVATE "-restrict")
endif()
-install(DIRECTORY include/ DESTINATION include)
-install(TARGETS GraphGenlib EXPORT CombBLASTargets
- LIBRARY DESTINATION lib
- ARCHIVE DESTINATION lib
- RUNTIME DESTINATION bin
- INCLUDES DESTINATION include
-)
+install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+install(TARGETS GraphGenlib EXPORT CombBLASTargets)
Index: combblas/usort/CMakeLists.txt
===================================================================
--- combblas.orig/usort/CMakeLists.txt 2025-09-28 01:20:56.595566436 +0200
+++ combblas/usort/CMakeLists.txt 2025-09-28 01:20:56.591421998 +0200
@@ -1,8 +1,11 @@
# Top level directory has the include files
add_library(Usortlib src/parUtils.cpp src/binUtils.cpp)
-target_include_directories(Usortlib PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> $<INSTALL_INTERFACE:include>)
-target_include_directories(Usortlib PRIVATE include/usort)
+target_include_directories(Usortlib PUBLIC
+ $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+ $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
+ PRIVATE include/usort
+)
if(TARGET MPI::MPI_CXX) # Use target if available (CMake >= 3.9)
target_link_libraries(Usortlib PUBLIC MPI::MPI_CXX)
@@ -12,11 +15,6 @@
target_include_directories(Usortlib PUBLIC "${MPI_CXX_INCLUDE_PATH}")
endif()
-install(DIRECTORY include/ DESTINATION include)
-install(TARGETS Usortlib EXPORT CombBLASTargets
- LIBRARY DESTINATION lib
- ARCHIVE DESTINATION lib
- RUNTIME DESTINATION bin
- INCLUDES DESTINATION include
- )
+install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+install(TARGETS Usortlib EXPORT CombBLASTargets)
|