1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
|
<?php declare(strict_types=1);
/*
* This file is part of Composer.
*
* (c) Nils Adermann <naderman@naderman.de>
* Jordi Boggiano <j.boggiano@seld.be>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Composer\Test\Package\Version;
use Composer\Filter\PlatformRequirementFilter\PlatformRequirementFilterFactory;
use Composer\IO\BufferIO;
use Composer\Package\Version\VersionSelector;
use Composer\Package\Package;
use Composer\Package\Link;
use Composer\Package\AliasPackage;
use Composer\Repository\PlatformRepository;
use Composer\Package\Version\VersionParser;
use Composer\Test\TestCase;
use PHPUnit\Framework\Attributes\DataProvider;
use Symfony\Component\Console\Output\StreamOutput;
class VersionSelectorTest extends TestCase
{
// A) multiple versions, get the latest one
// B) targetPackageVersion will pass to repo set
// C) No results, throw exception
public function testLatestVersionIsReturned(): void
{
$packageName = 'foo/bar';
$package1 = self::getPackage('foo/bar', '1.2.1');
$package2 = self::getPackage('foo/bar', '1.2.2');
$package3 = self::getPackage('foo/bar', '1.2.0');
$packages = [$package1, $package2, $package3];
$repositorySet = $this->createMockRepositorySet();
$repositorySet->expects($this->once())
->method('findPackages')
->with($packageName, null)
->willReturn($packages);
$versionSelector = new VersionSelector($repositorySet);
$best = $versionSelector->findBestCandidate($packageName);
// 1.2.2 should be returned because it's the latest of the returned versions
self::assertSame($package2, $best, 'Latest version should be 1.2.2');
}
public function testLatestVersionIsReturnedThatMatchesPhpRequirements(): void
{
$packageName = 'foo/bar';
$platform = new PlatformRepository([], ['php' => '5.5.0']);
$repositorySet = $this->createMockRepositorySet();
$versionSelector = new VersionSelector($repositorySet, $platform);
$parser = new VersionParser;
$package0 = self::getPackage('foo/bar', '0.9.0');
$package0->setRequires(['php' => new Link($packageName, 'php', $parser->parseConstraints('>=5.6'), Link::TYPE_REQUIRE, '>=5.6')]);
$package1 = self::getPackage('foo/bar', '1.0.0');
$package1->setRequires(['php' => new Link($packageName, 'php', $parser->parseConstraints('>=5.4'), Link::TYPE_REQUIRE, '>=5.4')]);
$package2 = self::getPackage('foo/bar', '2.0.0');
$package2->setRequires(['php' => new Link($packageName, 'php', $parser->parseConstraints('>=5.6'), Link::TYPE_REQUIRE, '>=5.6')]);
$package3 = self::getPackage('foo/bar', '2.1.0');
$package3->setRequires(['php' => new Link($packageName, 'php', $parser->parseConstraints('>=5.6'), Link::TYPE_REQUIRE, '>=5.6')]);
$packages = [$package0, $package1, $package2, $package3];
$repositorySet->expects($this->any())
->method('findPackages')
->with($packageName, null)
->willReturn($packages);
$io = new BufferIO();
$best = $versionSelector->findBestCandidate($packageName, null, 'stable', null, 0, $io);
self::assertSame((string) $package1, (string) $best, 'Latest version supporting php 5.5 should be returned (1.0.0)');
self::assertSame("<warning>Cannot use foo/bar's latest version 2.1.0 as it requires php >=5.6 which is not satisfied by your platform.".PHP_EOL, $io->getOutput());
$io = new BufferIO('', StreamOutput::VERBOSITY_VERBOSE);
$best = $versionSelector->findBestCandidate($packageName, null, 'stable', null, 0, $io);
self::assertSame((string) $package1, (string) $best, 'Latest version supporting php 5.5 should be returned (1.0.0)');
self::assertSame(
"<warning>Cannot use foo/bar's latest version 2.1.0 as it requires php >=5.6 which is not satisfied by your platform.".PHP_EOL
."<warning>Cannot use foo/bar 2.0.0 as it requires php >=5.6 which is not satisfied by your platform.".PHP_EOL,
$io->getOutput()
);
$best = $versionSelector->findBestCandidate($packageName, null, 'stable', PlatformRequirementFilterFactory::ignoreAll());
self::assertSame((string) $package3, (string) $best, 'Latest version should be returned when ignoring platform reqs (2.1.0)');
}
public function testLatestVersionIsReturnedThatMatchesExtRequirements(): void
{
$packageName = 'foo/bar';
$platform = new PlatformRepository([], ['ext-zip' => '5.3.0']);
$repositorySet = $this->createMockRepositorySet();
$versionSelector = new VersionSelector($repositorySet, $platform);
$parser = new VersionParser;
$package1 = self::getPackage('foo/bar', '1.0.0');
$package1->setRequires(['ext-zip' => new Link($packageName, 'ext-zip', $parser->parseConstraints('^5.2'), Link::TYPE_REQUIRE, '^5.2')]);
$package2 = self::getPackage('foo/bar', '2.0.0');
$package2->setRequires(['ext-zip' => new Link($packageName, 'ext-zip', $parser->parseConstraints('^5.4'), Link::TYPE_REQUIRE, '^5.4')]);
$packages = [$package1, $package2];
$repositorySet->expects($this->any())
->method('findPackages')
->with($packageName, null)
->willReturn($packages);
$best = $versionSelector->findBestCandidate($packageName);
self::assertSame($package1, $best, 'Latest version supporting ext-zip 5.3.0 should be returned (1.0.0)');
$best = $versionSelector->findBestCandidate($packageName, null, 'stable', PlatformRequirementFilterFactory::ignoreAll());
self::assertSame($package2, $best, 'Latest version should be returned when ignoring platform reqs (2.0.0)');
}
public function testLatestVersionIsReturnedThatMatchesPlatformExt(): void
{
$packageName = 'foo/bar';
$platform = new PlatformRepository();
$repositorySet = $this->createMockRepositorySet();
$versionSelector = new VersionSelector($repositorySet, $platform);
$parser = new VersionParser;
$package1 = self::getPackage('foo/bar', '1.0.0');
$package2 = self::getPackage('foo/bar', '2.0.0');
$package2->setRequires(['ext-barfoo' => new Link($packageName, 'ext-barfoo', $parser->parseConstraints('*'), Link::TYPE_REQUIRE, '*')]);
$packages = [$package1, $package2];
$repositorySet->expects($this->any())
->method('findPackages')
->with($packageName, null)
->willReturn($packages);
$best = $versionSelector->findBestCandidate($packageName);
self::assertSame($package1, $best, 'Latest version not requiring ext-barfoo should be returned (1.0.0)');
$best = $versionSelector->findBestCandidate($packageName, null, 'stable', PlatformRequirementFilterFactory::ignoreAll());
self::assertSame($package2, $best, 'Latest version should be returned when ignoring platform reqs (2.0.0)');
}
public function testLatestVersionIsReturnedThatMatchesComposerRequirements(): void
{
$packageName = 'foo/bar';
$platform = new PlatformRepository([], ['composer-runtime-api' => '1.0.0']);
$repositorySet = $this->createMockRepositorySet();
$versionSelector = new VersionSelector($repositorySet, $platform);
$parser = new VersionParser;
$package1 = self::getPackage('foo/bar', '1.0.0');
$package1->setRequires(['composer-runtime-api' => new Link($packageName, 'composer-runtime-api', $parser->parseConstraints('^1.0'), Link::TYPE_REQUIRE, '^1.0')]);
$package2 = self::getPackage('foo/bar', '1.1.0');
$package2->setRequires(['composer-runtime-api' => new Link($packageName, 'composer-runtime-api', $parser->parseConstraints('^2.0'), Link::TYPE_REQUIRE, '^2.0')]);
$packages = [$package1, $package2];
$repositorySet->expects($this->any())
->method('findPackages')
->with($packageName, null)
->willReturn($packages);
$best = $versionSelector->findBestCandidate($packageName);
self::assertSame($package1, $best, 'Latest version supporting composer 1 should be returned (1.0.0)');
$best = $versionSelector->findBestCandidate($packageName, null, 'stable', PlatformRequirementFilterFactory::ignoreAll());
self::assertSame($package2, $best, 'Latest version should be returned when ignoring platform reqs (1.1.0)');
}
public function testMostStableVersionIsReturned(): void
{
$packageName = 'foo/bar';
$package1 = self::getPackage('foo/bar', '1.0.0');
$package2 = self::getPackage('foo/bar', '1.1.0-beta');
$packages = [$package1, $package2];
$repositorySet = $this->createMockRepositorySet();
$repositorySet->expects($this->once())
->method('findPackages')
->with($packageName, null)
->willReturn($packages);
$versionSelector = new VersionSelector($repositorySet);
$best = $versionSelector->findBestCandidate($packageName);
self::assertSame($package1, $best, 'Latest most stable version should be returned (1.0.0)');
}
public function testMostStableVersionIsReturnedRegardlessOfOrder(): void
{
$packageName = 'foo/bar';
$package1 = self::getPackage('foo/bar', '2.x-dev');
$package2 = self::getPackage('foo/bar', '2.0.0-beta3');
$packages = [$package1, $package2];
$repositorySet = $this->createMockRepositorySet();
$repositorySet->expects($this->exactly(2))
->method('findPackages')
->with($packageName, null)
->willReturnOnConsecutiveCalls(
$packages,
array_reverse($packages)
);
$versionSelector = new VersionSelector($repositorySet);
$best = $versionSelector->findBestCandidate($packageName);
self::assertSame($package2, $best, 'Expecting 2.0.0-beta3, cause beta is more stable than dev');
$best = $versionSelector->findBestCandidate($packageName);
self::assertSame($package2, $best, 'Expecting 2.0.0-beta3, cause beta is more stable than dev');
}
public function testHighestVersionIsReturned(): void
{
$packageName = 'foo/bar';
$package1 = self::getPackage('foo/bar', '1.0.0');
$package2 = self::getPackage('foo/bar', '1.1.0-beta');
$packages = [$package1, $package2];
$repositorySet = $this->createMockRepositorySet();
$repositorySet->expects($this->once())
->method('findPackages')
->with($packageName, null)
->willReturn($packages);
$versionSelector = new VersionSelector($repositorySet);
$best = $versionSelector->findBestCandidate($packageName, null, 'dev');
self::assertSame($package2, $best, 'Latest version should be returned (1.1.0-beta)');
}
public function testHighestVersionMatchingStabilityIsReturned(): void
{
$packageName = 'foo/bar';
$package1 = self::getPackage('foo/bar', '1.0.0');
$package2 = self::getPackage('foo/bar', '1.1.0-beta');
$package3 = self::getPackage('foo/bar', '1.2.0-alpha');
$packages = [$package1, $package2, $package3];
$repositorySet = $this->createMockRepositorySet();
$repositorySet->expects($this->once())
->method('findPackages')
->with($packageName, null)
->willReturn($packages);
$versionSelector = new VersionSelector($repositorySet);
$best = $versionSelector->findBestCandidate($packageName, null, 'beta');
self::assertSame($package2, $best, 'Latest version should be returned (1.1.0-beta)');
}
public function testMostStableUnstableVersionIsReturned(): void
{
$packageName = 'foo/bar';
$package2 = self::getPackage('foo/bar', '1.1.0-beta');
$package3 = self::getPackage('foo/bar', '1.2.0-alpha');
$packages = [$package2, $package3];
$repositorySet = $this->createMockRepositorySet();
$repositorySet->expects($this->once())
->method('findPackages')
->with($packageName, null)
->willReturn($packages);
$versionSelector = new VersionSelector($repositorySet);
$best = $versionSelector->findBestCandidate($packageName, null, 'stable');
self::assertSame($package2, $best, 'Latest version should be returned (1.1.0-beta)');
}
public function testDefaultBranchAliasIsNeverReturned(): void
{
$packageName = 'foo/bar';
$package = self::getPackage('foo/bar', '1.1.0-beta');
$package2 = self::getPackage('foo/bar', 'dev-main');
$package2Alias = new AliasPackage($package2, VersionParser::DEFAULT_BRANCH_ALIAS, VersionParser::DEFAULT_BRANCH_ALIAS);
$packages = [$package, $package2Alias];
$repositorySet = $this->createMockRepositorySet();
$repositorySet->expects($this->once())
->method('findPackages')
->with($packageName, null)
->willReturn($packages);
$versionSelector = new VersionSelector($repositorySet);
$best = $versionSelector->findBestCandidate($packageName, null, 'dev');
self::assertSame($package2, $best, 'Latest version should be returned (dev-main)');
}
public function testFalseReturnedOnNoPackages(): void
{
$repositorySet = $this->createMockRepositorySet();
$repositorySet->expects($this->once())
->method('findPackages')
->willReturn([]);
$versionSelector = new VersionSelector($repositorySet);
$best = $versionSelector->findBestCandidate('foobaz');
self::assertFalse($best, 'No versions are available returns false');
}
#[DataProvider('provideRecommendedRequireVersionPackages')]
public function testFindRecommendedRequireVersion(string $prettyVersion, string $expectedVersion, ?string $branchAlias = null, string $packageName = 'foo/bar'): void
{
$repositorySet = $this->createMockRepositorySet();
$versionSelector = new VersionSelector($repositorySet);
$versionParser = new VersionParser();
$package = new Package($packageName, $versionParser->normalize($prettyVersion), $prettyVersion);
if ($branchAlias) {
$package->setExtra(['branch-alias' => [$prettyVersion => $branchAlias]]);
}
$recommended = $versionSelector->findRecommendedRequireVersion($package);
// assert that the recommended version is what we expect
self::assertSame($expectedVersion, $recommended);
}
public static function provideRecommendedRequireVersionPackages(): array
{
return [
// real version, expected recommendation, [branch-alias], [pkg name]
['1.2.1', '^1.2'],
['1.2', '^1.2'],
['v1.2.1', '^1.2'],
['3.1.2-pl2', '^3.1'],
['3.1.2-patch', '^3.1'],
['2.0-beta.1', '^2.0@beta'],
['3.1.2-alpha5', '^3.1@alpha'],
['3.0-RC2', '^3.0@RC'],
['0.1.0', '^0.1.0'],
['0.1.3', '^0.1.3'],
['0.0.3', '^0.0.3'],
['0.0.3-alpha', '^0.0.3@alpha'],
['0.0.3.4-alpha', '^0.0.3@alpha'],
['3.0.0.2-RC2', '^3.0@RC'],
['1.2.1.1020402', '^1.2'],
// date-based versions are not touched at all
['v20121020', 'v20121020'],
['v20121020.2', 'v20121020.2'],
// dev packages without alias are not touched at all
['dev-master', 'dev-master'],
['3.1.2-dev', '3.1.2-dev'],
// dev packages with alias inherit the alias
['dev-master', '^2.1@dev', '2.1.x-dev'],
['dev-master', '^2.1@dev', '2.1-dev'],
['dev-master', '^2.1@dev', '2.1.3.x-dev'],
['dev-master', '^2.0@dev', '2.x-dev'],
['dev-master', '^0.3.0@dev', '0.3.x-dev'],
['dev-master', '^0.0.3@dev', '0.0.3.x-dev'],
['dev-master', 'dev-master', VersionParser::DEFAULT_BRANCH_ALIAS],
// numeric alias
['3.x-dev', '^3.0@dev', '3.0.x-dev'],
['3.x-dev', '^3.0@dev', '3.0-dev'],
// ext in sync with php
[PHP_MAJOR_VERSION . '.' . PHP_MINOR_VERSION . '.' . PHP_RELEASE_VERSION, '*', null, 'ext-filter'],
// ext versioned individually
['3.0.5', '^3.0', null, 'ext-xdebug'],
];
}
/**
* @return \PHPUnit\Framework\MockObject\MockObject&\Composer\Repository\RepositorySet
*/
private function createMockRepositorySet()
{
return $this->getMockBuilder('Composer\Repository\RepositorySet')
->disableOriginalConstructor()
->getMock();
}
}
|
