1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618
|
/*
* Cppcheck - A tool for static C/C++ code analysis
* Copyright (C) 2007-2025 Cppcheck team.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "checktype.h"
#include "errortypes.h"
#include "fixture.h"
#include "helpers.h"
#include "platform.h"
#include "settings.h"
#include "standards.h"
#include "tokenize.h"
#include <cstddef>
#include <string>
#include <vector>
class TestType : public TestFixture {
public:
TestType() : TestFixture("TestType") {}
private:
void run() override {
TEST_CASE(checkTooBigShift_Unix32);
TEST_CASE(checkIntegerOverflow);
TEST_CASE(signConversion);
TEST_CASE(longCastAssign);
TEST_CASE(longCastReturn);
TEST_CASE(checkFloatToIntegerOverflow);
TEST_CASE(integerOverflow); // #11794
TEST_CASE(shiftTooManyBits); // #11496
}
struct CheckOptions
{
CheckOptions() = default;
Standards::cppstd_t standard = Standards::cppstd_t::CPP11;
};
#define check(...) check_(__FILE__, __LINE__, __VA_ARGS__)
template<size_t size>
void check_(const char* file, int line, const char (&code)[size], const Settings& settings, const CheckOptions& options = make_default_obj()) {
const Settings settings1 = settingsBuilder(settings).severity(Severity::warning).severity(Severity::portability).cpp(options.standard).build();
// Tokenize..
SimpleTokenizer tokenizer(settings1, *this);
ASSERT_LOC(tokenizer.tokenize(code), file, line);
// Check..
runChecks<CheckType>(tokenizer, this);
}
// TODO: get rid of this
void check_(const char* file, int line, const std::string& code, const Settings& settings, const CheckOptions& options = make_default_obj()) {
const Settings settings1 = settingsBuilder(settings).severity(Severity::warning).severity(Severity::portability).cpp(options.standard).build();
// Tokenize..
SimpleTokenizer tokenizer(settings1, *this);
ASSERT_LOC(tokenizer.tokenize(code), file, line);
// Check..
runChecks<CheckType>(tokenizer, this);
}
struct CheckPOptions
{
CheckPOptions() = default;
const char* filename = "test.cpp";
};
#define checkP(...) checkP_(__FILE__, __LINE__, __VA_ARGS__)
template<size_t size>
void checkP_(const char* file, int line, const char (&code)[size], const Settings& settings, const CheckPOptions& options = make_default_obj()) {
const Settings settings1 = settingsBuilder(settings).severity(Severity::warning).severity(Severity::portability).build();
std::vector<std::string> files(1, options.filename);
Tokenizer tokenizer(settings1, *this);
PreprocessorHelper::preprocess(code, files, tokenizer, *this);
// Tokenizer..
ASSERT_LOC(tokenizer.simplifyTokens1(""), file, line);
// Check..
runChecks<CheckType>(tokenizer, this);
}
void checkTooBigShift_Unix32() {
const Settings settings = settingsBuilder().platform(Platform::Type::Unix32).build();
// unsigned types getting promoted to int sizeof(int) = 4 bytes
// and unsigned types having already a size of 4 bytes
{
const std::string types[] = {"unsigned char", /*[unsigned]*/ "char", "bool", "unsigned short", "unsigned int", "unsigned long"};
for (const std::string& type : types) {
check(type + " f(" + type +" x) { return x << 31; }", settings);
ASSERT_EQUALS("", errout_str());
check(type + " f(" + type +" x) { return x << 33; }", settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 32-bit value by 33 bits is undefined behaviour\n", errout_str());
check(type + " f(int x) { return (x = (" + type + ")x << 32); }", settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 32-bit value by 32 bits is undefined behaviour\n", errout_str());
check(type + " foo(" + type + " x) { return x << 31; }", settings);
ASSERT_EQUALS("", errout_str());
}
}
// signed types getting promoted to int sizeof(int) = 4 bytes
// and signed types having already a size of 4 bytes
{
const std::string types[] = {"signed char", "signed short", /*[signed]*/ "short", "wchar_t", /*[signed]*/ "int", "signed int", /*[signed]*/ "long", "signed long"};
for (const std::string& type : types) {
// c++11
check(type + " f(" + type +" x) { return x << 33; }", settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 32-bit value by 33 bits is undefined behaviour\n", errout_str());
check(type + " f(int x) { return (x = (" + type + ")x << 32); }", settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 32-bit value by 32 bits is undefined behaviour\n", errout_str());
check(type + " foo(" + type + " x) { return x << 31; }", settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour\n", errout_str());
check(type + " foo(" + type + " x) { return x << 30; }", settings);
ASSERT_EQUALS("", errout_str());
// c++14
check(type + " foo(" + type + " x) { return x << 31; }", settings, dinit(CheckOptions, $.standard = Standards::CPP14));
ASSERT_EQUALS("[test.cpp:1]: (portability) Shifting signed 32-bit value by 31 bits is implementation-defined behaviour\n", errout_str());
check(type + " f(int x) { return (x = (" + type + ")x << 32); }", settings, dinit(CheckOptions, $.standard = Standards::CPP14));
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 32-bit value by 32 bits is undefined behaviour\n", errout_str());
}
}
// 64 bit width types
{
// unsigned long long
check("unsigned long long foo(unsigned long long x) { return x << 64; }",settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 64-bit value by 64 bits is undefined behaviour\n", errout_str());
check("unsigned long long f(int x) { return (x = (unsigned long long)x << 64); }",settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 64-bit value by 64 bits is undefined behaviour\n", errout_str());
check("unsigned long long f(unsigned long long x) { return x << 63; }",settings);
ASSERT_EQUALS("", errout_str());
// [signed] long long
check("long long foo(long long x) { return x << 64; }",settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 64-bit value by 64 bits is undefined behaviour\n", errout_str());
check("long long f(int x) { return (x = (long long)x << 64); }",settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 64-bit value by 64 bits is undefined behaviour\n", errout_str());
check("long long f(long long x) { return x << 63; }",settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting signed 64-bit value by 63 bits is undefined behaviour\n", errout_str());
check("long long f(long long x) { return x << 62; }",settings);
ASSERT_EQUALS("", errout_str());
// signed long long
check("signed long long foo(signed long long x) { return x << 64; }",settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 64-bit value by 64 bits is undefined behaviour\n", errout_str());
check("signed long long f(long long x) { return (x = (signed long long)x << 64); }",settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 64-bit value by 64 bits is undefined behaviour\n", errout_str());
check("signed long long f(signed long long x) { return x << 63; }",settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting signed 64-bit value by 63 bits is undefined behaviour\n", errout_str());
check("signed long long f(signed long long x) { return x << 62; }",settings);
ASSERT_EQUALS("", errout_str());
// c++14
check("signed long long foo(signed long long x) { return x << 64; }",settings, dinit(CheckOptions, $.standard = Standards::CPP14));
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 64-bit value by 64 bits is undefined behaviour\n", errout_str());
check("signed long long f(long long x) { return (x = (signed long long)x << 64); }",settings, dinit(CheckOptions, $.standard = Standards::CPP14));
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 64-bit value by 64 bits is undefined behaviour\n", errout_str());
check("signed long long f(signed long long x) { return x << 63; }",settings, dinit(CheckOptions, $.standard = Standards::CPP14));
ASSERT_EQUALS("[test.cpp:1]: (portability) Shifting signed 64-bit value by 63 bits is implementation-defined behaviour\n", errout_str());
check("signed long long f(signed long long x) { return x << 62; }",settings);
ASSERT_EQUALS("", errout_str());
}
check("void f() { int x; x = 1 >> 64; }", settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Shifting 32-bit value by 64 bits is undefined behaviour\n", errout_str());
check("void foo() {\n"
" QList<int> someList;\n"
" someList << 300;\n"
"}", settings);
ASSERT_EQUALS("", errout_str());
// Ticket #6793
check("template<unsigned int I> int foo(unsigned int x) { return x << I; }\n"
"const unsigned int f = foo<31>(0);\n"
"const unsigned int g = foo<100>(0);\n"
"template<unsigned int I> int hoo(unsigned int x) { return x << 32; }\n"
"const unsigned int h = hoo<100>(0);", settings);
ASSERT_EQUALS("[test.cpp:4]: (error) Shifting 32-bit value by 32 bits is undefined behaviour\n"
"[test.cpp:1]: (error) Shifting 32-bit value by 100 bits is undefined behaviour\n", errout_str());
// #7266: C++, shift in macro
check("void f(unsigned int x) {\n"
" UINFO(x << 1234);\n"
"}", settingsDefault);
ASSERT_EQUALS("", errout_str());
// #8640
check("int f (void)\n"
"{\n"
" constexpr const int a = 1;\n"
" constexpr const int shift[1] = {32};\n"
" constexpr const int ret = a << shift[0];\n" // shift too many bits
" return ret;\n"
"}", settingsDefault);
ASSERT_EQUALS("[test.cpp:5]: (error) Shifting 32-bit value by 32 bits is undefined behaviour\n"
"[test.cpp:5]: (error) Signed integer overflow for expression 'a<<shift[0]'.\n", errout_str());
// #8885
check("int f(int k, int rm) {\n"
" if (k == 32)\n"
" return 0;\n"
" if (k > 32)\n"
" return 0;\n"
" return rm>> k;\n"
"}", settingsDefault);
ASSERT_EQUALS(
"[test.cpp:4] -> [test.cpp:6]: (warning) Shifting signed 32-bit value by 31 bits is undefined behaviour. See condition at line 4.\n",
errout_str());
check("int f(int k, int rm) {\n"
" if (k == 0 || k == 32)\n"
" return 0;\n"
" else if (k > 32)\n"
" return 0;\n"
" else\n"
" return rm>> k;\n"
"}", settingsDefault);
ASSERT_EQUALS(
"[test.cpp:4] -> [test.cpp:7]: (warning) Shifting signed 32-bit value by 31 bits is undefined behaviour. See condition at line 4.\n",
errout_str());
check("int f(int k, int rm) {\n"
" if (k == 0 || k == 32 || k == 31)\n"
" return 0;\n"
" else if (k > 32)\n"
" return 0;\n"
" else\n"
" return rm>> k;\n"
"}", settingsDefault);
ASSERT_EQUALS("", errout_str());
check("static long long f(int x, long long y) {\n"
" if (x >= 64)\n"
" return 0;\n"
" return -(y << (x-1));\n"
"}", settingsDefault);
ASSERT_EQUALS("", errout_str());
check("bool f() {\n"
" std::ofstream outfile;\n"
" outfile << vec_points[0](0) << static_cast<int>(d) << ' ';\n"
"}", settingsDefault);
ASSERT_EQUALS("", errout_str());
check("void f(unsigned b, int len, unsigned char rem) {\n" // #10773
" int bits = 0;\n"
" while (len > 8) {\n"
" b = b >> rem;\n"
" bits += 8 - rem;\n"
" if (bits == 512)\n"
" len -= 8;\n"
" }\n"
"}\n", settingsDefault);
ASSERT_EQUALS("", errout_str());
}
void checkIntegerOverflow() {
const Settings settings = settingsBuilder().severity(Severity::warning).platform(Platform::Type::Unix32).build();
check("x = (int)0x10000 * (int)0x10000;", settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Signed integer overflow for expression '(int)0x10000*(int)0x10000'.\n", errout_str());
check("x = (long)0x10000 * (long)0x10000;", settings);
ASSERT_EQUALS("[test.cpp:1]: (error) Signed integer overflow for expression '(long)0x10000*(long)0x10000'.\n", errout_str());
check("void foo() {\n"
" int intmax = 0x7fffffff;\n"
" return intmax + 1;\n"
"}",settings);
ASSERT_EQUALS("[test.cpp:3]: (error) Signed integer overflow for expression 'intmax+1'.\n", errout_str());
check("void foo() {\n"
" int intmax = 0x7fffffff;\n"
" return intmax - 1;\n"
"}",settings);
ASSERT_EQUALS("", errout_str());
check("int foo(signed int x) {\n"
" if (x==123456) {}\n"
" return x * x;\n"
"}",settings);
ASSERT_EQUALS("[test.cpp:2] -> [test.cpp:3]: (warning) Either the condition 'x==123456' is redundant or there is signed integer overflow for expression 'x*x'.\n", errout_str());
check("int foo(signed int x) {\n"
" if (x==123456) {}\n"
" return -123456 * x;\n"
"}",settings);
ASSERT_EQUALS("[test.cpp:2] -> [test.cpp:3]: (warning) Either the condition 'x==123456' is redundant or there is signed integer underflow for expression '-123456*x'.\n", errout_str());
check("int foo(signed int x) {\n"
" if (x==123456) {}\n"
" return 123456U * x;\n"
"}",settings);
ASSERT_EQUALS("", errout_str());
check("int f(int i) {\n" // #12117
" return (i == 31) ? 1 << i : 0;\n"
"}", settings);
ASSERT_EQUALS("[test.cpp:2] -> [test.cpp:2]: (warning) Shifting signed 32-bit value by 31 bits is undefined behaviour. See condition at line 2.\n", errout_str());
check("void f() {\n" // #13092
" int n = 0;\n"
" for (int i = 0; i < 10; i++) {\n"
" n = n * 47163 - 57412;\n"
" }\n"
"}", settings);
ASSERT_EQUALS("[test.cpp:4]: (error) Signed integer underflow for expression 'n*47163'.\n"
"[test.cpp:4]: (error) Signed integer underflow for expression 'n*47163-57412'.\n",
errout_str());
}
void signConversion() {
const Settings settings = settingsBuilder().platform(Platform::Type::Unix64).build();
check("x = -4 * (unsigned)y;", settingsDefault);
ASSERT_EQUALS("[test.cpp:1]: (warning) Expression '-4' has a negative value. That is converted to an unsigned value and used in an unsigned calculation.\n", errout_str());
check("x = (unsigned)y * -4;", settingsDefault);
ASSERT_EQUALS("[test.cpp:1]: (warning) Expression '-4' has a negative value. That is converted to an unsigned value and used in an unsigned calculation.\n", errout_str());
check("unsigned int dostuff(int x) {\n" // x is signed
" if (x==0) {}\n"
" return (x-1)*sizeof(int);\n"
"}", settings);
ASSERT_EQUALS("[test.cpp:2] -> [test.cpp:3]: (warning) Expression 'x-1' can have a negative value. That is converted to an unsigned value and used in an unsigned calculation.\n", errout_str());
check("unsigned int f1(signed int x, unsigned int y) {" // x is signed
" return x * y;\n"
"}\n"
"void f2() { f1(-4,4); }", settingsDefault);
ASSERT_EQUALS(
"[test.cpp:1]: (warning) Expression 'x' can have a negative value. That is converted to an unsigned value and used in an unsigned calculation.\n",
errout_str());
check("unsigned int f1(int x) {"
" return x * 5U;\n"
"}\n"
"void f2() { f1(-4); }", settingsDefault);
ASSERT_EQUALS(
"[test.cpp:1]: (warning) Expression 'x' can have a negative value. That is converted to an unsigned value and used in an unsigned calculation.\n",
errout_str());
check("unsigned int f1(int x) {" // #6168: FP for inner calculation
" return 5U * (1234 - x);\n" // <- signed subtraction, x is not sign converted
"}\n"
"void f2() { f1(-4); }", settingsDefault);
ASSERT_EQUALS("", errout_str());
// Don't warn for + and -
check("void f1(int x) {"
" a = x + 5U;\n"
"}\n"
"void f2() { f1(-4); }", settingsDefault);
ASSERT_EQUALS("", errout_str());
check("size_t foo(size_t x) {\n"
" return -2 * x;\n"
"}", settingsDefault);
ASSERT_EQUALS("[test.cpp:2]: (warning) Expression '-2' has a negative value. That is converted to an unsigned value and used in an unsigned calculation.\n", errout_str());
checkP("void f() {\n" // #12110 FP signConversion with integer overflow
" if (LLONG_MIN / (-1)) {}\n"
"}\n", settingsDefault);
ASSERT_EQUALS("", errout_str());
}
void longCastAssign() {
const Settings settings = settingsBuilder().severity(Severity::style).platform(Platform::Type::Unix64).build();
const Settings settingsWin = settingsBuilder().severity(Severity::style).platform(Platform::Type::Win64).build();
const char code[] = "long f(int x, int y) {\n"
" const long ret = x * y;\n"
" return ret;\n"
"}\n";
check(code, settings);
ASSERT_EQUALS("[test.cpp:2]: (style) int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information.\n", errout_str());
check(code, settingsWin);
ASSERT_EQUALS("", errout_str());
check("long f(int x, int y) {\n"
" long ret = x * y;\n"
" return ret;\n"
"}\n", settings);
ASSERT_EQUALS("[test.cpp:2]: (style) int result is assigned to long variable. If the variable is long to avoid loss of information, then you have loss of information.\n", errout_str());
check("long f() {\n"
" const long long ret = 256 * (1 << 10);\n"
" return ret;\n"
"}\n", settings);
ASSERT_EQUALS("", errout_str());
// typedef
check("long f(int x, int y) {\n"
" const size_t ret = x * y;\n"
" return ret;\n"
"}\n", settings);
ASSERT_EQUALS("", errout_str());
// astIsIntResult
check("long f(int x, int y) {\n"
" const long ret = (long)x * y;\n"
" return ret;\n"
"}\n", settings);
ASSERT_EQUALS("", errout_str());
check("double g(float f) {\n"
" return f * f;\n"
"}\n", settings);
ASSERT_EQUALS("[test.cpp:2]: (style) float result is returned as double value. If the return value is double to avoid loss of information, then you have loss of information.\n",
errout_str());
check("void f(int* p) {\n" // #11862
" long long j = *(p++);\n"
"}\n", settings);
ASSERT_EQUALS("", errout_str());
check("template <class T>\n" // #12393
"struct S {\n"
" S& operator=(const S&) { return *this; }\n"
" struct U {\n"
" S<T>* p;\n"
" };\n"
" U u;\n"
"};\n", settings);
ASSERT_EQUALS("", errout_str()); // don't crash
check("void f(long& r, long i) {\n"
" r = 1 << i;\n"
"}\n", settingsWin);
ASSERT_EQUALS("", errout_str());
}
void longCastReturn() {
const Settings settings = settingsBuilder().severity(Severity::style).platform(Platform::Type::Unix64).build();
const Settings settingsWin = settingsBuilder().severity(Severity::style).platform(Platform::Type::Win64).build();
const char code[] = "long f(int x, int y) {\n"
" return x * y;\n"
"}\n";
check(code, settings);
ASSERT_EQUALS("[test.cpp:2]: (style) int result is returned as long value. If the return value is long to avoid loss of information, then you have loss of information.\n", errout_str());
check(code, settingsWin);
ASSERT_EQUALS("", errout_str());
const char code2[] = "long long f(int x, int y) {\n"
" return x * y;\n"
"}\n";
check(code2, settings);
ASSERT_EQUALS("[test.cpp:2]: (style) int result is returned as long long value. If the return value is long long to avoid loss of information, then you have loss of information.\n", errout_str());
check(code2, settingsWin);
ASSERT_EQUALS("[test.cpp:2]: (style) int result is returned as long long value. If the return value is long long to avoid loss of information, then you have loss of information.\n", errout_str());
// typedef
check("size_t f(int x, int y) {\n"
" return x * y;\n"
"}\n", settings);
ASSERT_EQUALS("[test.cpp:2]: (style) int result is returned as long value. If the return value is long to avoid loss of information, then you have loss of information.\n", errout_str());
}
// This function ensure that test works with different compilers. Floats can
// be stringified differently.
static std::string removeFloat(const std::string& msg) {
const std::string::size_type pos1 = msg.find("float (");
const std::string::size_type pos2 = msg.find(") to integer conversion");
if (pos1 == std::string::npos || pos2 == std::string::npos || pos1 > pos2)
return msg;
return msg.substr(0,pos1+7) + msg.substr(pos2);
}
void checkFloatToIntegerOverflow() {
check("x = (int)1E100;", settingsDefault);
ASSERT_EQUALS("[test.cpp:1]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
check("void f(void) {\n"
" return (int)1E100;\n"
"}", settingsDefault);
ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
check("void f(void) {\n"
" return (int)-1E100;\n"
"}", settingsDefault);
ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
check("void f(void) {\n"
" return (short)1E6;\n"
"}", settingsDefault);
ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
check("void f(void) {\n"
" return (unsigned char)256.0;\n"
"}", settingsDefault);
ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
check("void f(void) {\n"
" return (unsigned char)255.5;\n"
"}", settingsDefault);
ASSERT_EQUALS("", removeFloat(errout_str()));
check("void f(void) {\n"
" char c = 1234.5;\n"
"}", settingsDefault);
ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
check("char f(void) {\n"
" return 1234.5;\n"
"}", settingsDefault);
ASSERT_EQUALS("[test.cpp:2]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
checkP("#define TEST(b, f) b ? 5000 : (unsigned short)f\n" // #11685
"void f()\n"
"{\n"
" unsigned short u = TEST(true, 75000.0);\n"
"}\n", settingsDefault);
ASSERT_EQUALS("", errout_str());
checkP("#define TEST(b, f) b ? 5000 : (unsigned short)f\n"
"void f()\n"
"{\n"
" unsigned short u = TEST(false, 75000.0);\n"
"}\n", settingsDefault);
ASSERT_EQUALS("[test.cpp:4]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
check( "bool f(unsigned short x);\n"
"bool g() {\n"
" return false && f((unsigned short)75000.0);\n"
"}\n", settingsDefault);
ASSERT_EQUALS("", errout_str());
check( "bool f(unsigned short x);\n"
"bool g() {\n"
" return true && f((unsigned short)75000.0);\n"
"}\n", settingsDefault);
ASSERT_EQUALS("[test.cpp:3]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
check( "bool f(unsigned short x);\n"
"bool g() {\n"
" return true || f((unsigned short)75000.0);\n"
"}\n", settingsDefault);
ASSERT_EQUALS("", errout_str());
check( "bool f(unsigned short x);\n"
"bool g() {\n"
" return false || f((unsigned short)75000.0);\n"
"}\n", settingsDefault);
ASSERT_EQUALS("[test.cpp:3]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
checkP("#define TEST(b, f) b ? 5000 : (unsigned short)f\n" // #11685
"void f()\n"
"{\n"
" unsigned short u = TEST(true, 75000.0);\n"
"}\n", settingsDefault, dinit(CheckPOptions, $.filename = "test.c"));
ASSERT_EQUALS("", errout_str());
checkP("#define TEST(b, f) b ? 5000 : (unsigned short)f\n"
"void f()\n"
"{\n"
" unsigned short u = TEST(false, 75000.0);\n"
"}\n", settingsDefault, dinit(CheckPOptions, $.filename = "test.c"));
ASSERT_EQUALS("[test.c:4]: (error) Undefined behaviour: float () to integer conversion overflow.\n", removeFloat(errout_str()));
}
void integerOverflow() { // #11794
// std.cfg for int32_t
// Platform::Unix32 for INT_MIN=-2147483648 and INT32_MAX=2147483647
const Settings s = settingsBuilder().library("std.cfg").cpp(Standards::CPP11).platform(Platform::Unix32).build();
checkP("int fun(int x)\n"
"{\n"
" if(x < 0) x = -x;\n"
" return x >= 0;\n"
"}\n"
"int f()\n"
"{\n"
" fun(INT_MIN);\n"
"}", s);
ASSERT_EQUALS("[test.cpp:3]: (error) Signed integer overflow for expression '-x'.\n", errout_str());
checkP("void f() {\n" // #8399
" int32_t i = INT32_MAX;\n"
" i << 1;\n"
" i << 2;\n"
"}", s);
ASSERT_EQUALS("[test.cpp:4]: (error) Signed integer overflow for expression 'i<<2'.\n", errout_str());
}
void shiftTooManyBits() { // #11496
check("template<unsigned int width> struct B {\n"
" unsigned long long f(unsigned int n) const {\n"
" if (width == 1)\n"
" return 1ULL << width;\n"
" return 0;\n"
" }\n"
"};\n"
"static B<64> b;\n", settingsDefault);
ASSERT_EQUALS("", errout_str());
}
};
REGISTER_TEST(TestType)
|