1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
|
# python -m pytest test-inline-suppress.py
import json
import os
import pytest
import sys
from testutils import cppcheck
__script_dir = os.path.dirname(os.path.abspath(__file__))
__proj_inline_suppres_path = 'proj-inline-suppress' + os.path.sep
def __create_unused_function_compile_commands(tmpdir):
prjpath = os.path.realpath(os.path.join(__script_dir, 'proj-inline-suppress-unusedFunction'))
j = [{'directory': prjpath,
'command': '/usr/bin/c++ -I"' + prjpath + '" -o "' + os.path.join(prjpath, 'B.cpp.o') + '" -c "' + os.path.join(prjpath, 'B.cpp') + '"',
'file': os.path.join(prjpath, 'B.cpp')},
{'directory': prjpath,
'command': '/usr/bin/c++ -I"' + prjpath + '" -o "' + os.path.join(prjpath, 'A.cpp.o') + '" -c "' + os.path.join(prjpath, 'A.cpp') + '"',
'file': os.path.join(prjpath, 'A.cpp')}]
compdb_path = os.path.join(tmpdir, 'proj-inline-suppress-unusedFunction')
os.makedirs(compdb_path)
compile_commands = os.path.join(compdb_path, 'compile_commands.json')
with open(compile_commands, 'wt') as f:
f.write(json.dumps(j, indent=4))
return compile_commands
def test_1():
args = [
'-q',
'--template=simple',
'--inline-suppr',
'proj-inline-suppress'
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
assert stderr == ''
assert stdout == ''
assert ret == 0, stdout
def test_2():
args = [
'-q',
'--template=simple',
'proj-inline-suppress'
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == [
'{}3.cpp:4:19: error: Division by zero. [zerodiv]'.format(__proj_inline_suppres_path)
]
assert stdout == ''
assert ret == 0, stdout
def test_xml():
args = [
'-q',
'--template=simple',
'--inline-suppr',
'--xml-version=3',
'proj-inline-suppress'
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
assert '<suppression errorId="some_warning_id" fileName="proj-inline-suppress/2.c" lineNumber="2" inline="true" comment="there should be a unmatchedSuppression warning about this" />' in stderr
assert stdout == ''
assert ret == 0, stdout
def test_unmatched_suppression():
args = [
'-q',
'--template=simple',
'--inline-suppr',
'--enable=information',
'--error-exitcode=1',
'{}2.c'.format(__proj_inline_suppres_path)
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == [
'{}2.c:2:0: information: Unmatched suppression: some_warning_id [unmatchedSuppression]'.format(__proj_inline_suppres_path)
]
assert stdout == ''
assert ret == 1, stdout
def test_unmatched_suppression_path_with_extra_stuff():
args = [
'-q',
'--template=simple',
'--inline-suppr',
'--enable=information',
'--error-exitcode=1',
'{}2.c'.format(__proj_inline_suppres_path)
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == [
'{}2.c:2:0: information: Unmatched suppression: some_warning_id [unmatchedSuppression]'.format(__proj_inline_suppres_path)
]
assert stdout == ''
assert ret == 1, stdout
def test_backwards_compatibility():
args = [
'-q',
'--template=simple',
'{}3.cpp'.format(__proj_inline_suppres_path)
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == [
'{}3.cpp:4:19: error: Division by zero. [zerodiv]'.format(__proj_inline_suppres_path)
]
assert stdout == ''
assert ret == 0, stdout
args = [
'-q',
'--template=simple',
'--inline-suppr',
'{}3.cpp'.format(__proj_inline_suppres_path)
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == []
assert stdout == ''
assert ret == 0, stdout
def __test_compile_commands_unused_function(tmpdir, use_j):
compdb_file = __create_unused_function_compile_commands(tmpdir)
args = [
'-q',
'--template=simple',
'--enable=all',
'--error-exitcode=1',
'--project={}'.format(compdb_file)
]
if use_j:
args.append('-j2')
else:
args.append('-j1')
ret, stdout, stderr = cppcheck(args)
proj_path_sep = os.path.join(__script_dir, 'proj-inline-suppress-unusedFunction') + os.path.sep
lines = stderr.splitlines()
assert lines == [
"{}B.cpp:6:9: style: The function 'unusedFunctionTest' is never used. [unusedFunction]".format(proj_path_sep)
]
assert stdout == ''
assert ret == 1, stdout
def test_compile_commands_unused_function(tmpdir):
__test_compile_commands_unused_function(tmpdir, False)
@pytest.mark.skip # unusedFunction does not work with -j
def test_compile_commands_unused_function_j(tmpdir):
__test_compile_commands_unused_function(tmpdir, True)
def __test_compile_commands_unused_function_suppression(tmpdir, use_j):
compdb_file = __create_unused_function_compile_commands(tmpdir)
args = [
'-q',
'--template=simple',
'--enable=all',
'--inline-suppr',
'--error-exitcode=1',
'--project={}'.format(compdb_file)
]
if use_j:
args.append('-j2')
else:
args.append('-j1')
ret, stdout, stderr = cppcheck(args)
lines = stderr.splitlines()
assert lines == []
assert stdout == ''
assert ret == 0, stdout
def test_compile_commands_unused_function_suppression(tmpdir):
__test_compile_commands_unused_function_suppression(tmpdir, False)
@pytest.mark.skip # unusedFunction does not work with -j
def test_compile_commands_unused_function_suppression_j(tmpdir):
__test_compile_commands_unused_function_suppression(tmpdir, True)
def test_unmatched_suppression_ifdef():
args = [
'-q',
'--template=simple',
'--enable=information',
'--inline-suppr',
'-DNO_ZERO_DIV',
'trac5704/trac5704a.c'
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == []
assert stdout == ''
assert ret == 0, stdout
def test_unmatched_suppression_ifdef_0():
args = [
'-q',
'--template=simple',
'--enable=information',
'--inline-suppr',
'trac5704/trac5704b.c'
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == []
assert stdout == ''
assert ret == 0, stdout
def test_build_dir(tmpdir):
args = [
'-q',
'--template=simple',
'--cppcheck-build-dir={}'.format(tmpdir),
'--enable=all',
'--inline-suppr',
'{}4.c'.format(__proj_inline_suppres_path)
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == []
assert stdout == ''
assert ret == 0, stdout
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == []
assert stdout == ''
assert ret == 0, stdout
def __test_build_dir_unused_template(tmpdir, extra_args):
args = [
'-q',
'--template=simple',
'--cppcheck-build-dir={}'.format(tmpdir),
'--enable=all',
'--inline-suppr',
'{}template.cpp'.format(__proj_inline_suppres_path)
]
args = args + extra_args
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == []
assert stdout == ''
assert ret == 0, stdout
def test_build_dir_unused_template(tmpdir):
__test_build_dir_unused_template(tmpdir, ['-j1', '--no-cppcheck-build-dir'])
def test_build_dir_unused_template_j_thread(tmpdir):
__test_build_dir_unused_template(tmpdir, ['-j2', '--executor=thread'])
@pytest.mark.skipif(sys.platform == 'win32', reason='ProcessExecutor not available on Windows')
def test_build_dir_unused_template_j_process(tmpdir):
__test_build_dir_unused_template(tmpdir, ['-j2', '--executor=process'])
def test_suppress_unmatched_inline_suppression(): # 11172
args = [
'-q',
'--template=simple',
'--enable=information',
'--suppress=unmatchedSuppression',
'--inline-suppr',
'{}2.c'.format(__proj_inline_suppres_path)
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
assert lines == []
assert stdout == ''
assert ret == 0, stdout
@pytest.mark.skip # TODO: this test makes no sense
@pytest.mark.xfail(strict=True) # no error as inline suppressions are currently not being propagated back
def test_duplicate(tmpdir):
args = [
'-q',
'--template=simple',
'--enable=all',
'--inline-suppr',
'proj-inline-suppress/duplicate.cpp'
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
assert stderr.splitlines() == []
assert stdout.splitlines() == [
"cppcheck: error: suppression 'unreadVariable' already exists"
]
assert ret == 0, stdout
# no error as inline suppressions are handled separately
def __test_duplicate_cmd(tmpdir, extra_args):
args = [
'-q',
'--template=simple',
'--enable=all',
'--inline-suppr',
'--suppress=unreadVariable',
'proj-inline-suppress/4.c'
]
args = args + extra_args
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
# this is the suppression provided via the command-line which is unused because only the inline suppression is being matched
assert lines == [
'nofile:0:0: information: Unmatched suppression: unreadVariable [unmatchedSuppression]'
]
assert stdout == ''
assert ret == 0, stdout
@pytest.mark.skip # TODO: behavior of duplicate suppressions across inline and non-inline is currently undefined
def test_duplicate_cmd(tmp_path):
__test_duplicate_cmd(tmp_path, ['-j1'])
@pytest.mark.skip # TODO: behavior of duplicate suppressions across inline and non-inline is currently undefined
def test_duplicate_cmd_j(tmp_path):
__test_duplicate_cmd(tmp_path, ['-j2'])
# no error as inline suppressions are handled separately
def __test_duplicate_file(tmp_path, extra_args):
suppr_file = tmp_path / 'suppressions'
with open(suppr_file, 'wt') as f:
f.write('unreadVariable')
args = [
'-q',
'--template=simple',
'--enable=all',
'--inline-suppr',
'--suppressions-list={}'.format(suppr_file),
'proj-inline-suppress/4.c'
]
args = args + extra_args
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
# this is the suppression provided via the suppression file which is unused because only the inline suppression is being matched
assert lines == [
'nofile:0:0: information: Unmatched suppression: unreadVariable [unmatchedSuppression]'
]
assert stdout == ''
assert ret == 0, stdout
@pytest.mark.skip # TODO: behavior of duplicate suppressions across inline and non-inline is currently undefined
def test_duplicate_file(tmpdir):
__test_duplicate_file(tmpdir, ['-j1'])
@pytest.mark.skip # TODO: behavior of duplicate suppressions across inline and non-inline is currently undefined
def test_duplicate_file_j(tmpdir):
__test_duplicate_file(tmpdir, ['-j2'])
# reporting of inline unusedFunction is deferred
def __test_unused_function_unmatched(tmpdir, extra_args):
args = [
'-q',
'--template=simple',
'--enable=all',
'--inline-suppr',
'proj-inline-suppress/unusedFunctionUnmatched.cpp'
]
args += extra_args
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
lines = stderr.splitlines()
lines.sort()
assert lines == [
'{}unusedFunctionUnmatched.cpp:5:0: information: Unmatched suppression: uninitvar [unmatchedSuppression]'.format(__proj_inline_suppres_path),
'{}unusedFunctionUnmatched.cpp:5:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]'.format(__proj_inline_suppres_path)
]
assert stdout == ''
assert ret == 0, stdout
def test_unused_function_unmatched(tmpdir):
__test_unused_function_unmatched(tmpdir, ['-j1', '--no-cppcheck-build-dir'])
@pytest.mark.xfail(strict=True) # TODO: check error - do not work with -j2
def test_unused_function_unmatched_j(tmpdir):
__test_unused_function_unmatched(tmpdir, ['-j2', '--no-cppcheck-build-dir'])
def test_unused_function_unmatched_builddir(tmpdir):
build_dir = os.path.join(tmpdir, 'b1')
os.mkdir(build_dir)
__test_unused_function_unmatched(tmpdir, ['-j1', '--cppcheck-build-dir={}'.format(build_dir)])
def test_unused_function_unmatched_builddir_j_thread(tmpdir):
build_dir = os.path.join(tmpdir, 'b1')
os.mkdir(build_dir)
__test_unused_function_unmatched(tmpdir, ['-j2', '--cppcheck-build-dir={}'.format(build_dir), '--executor=thread'])
@pytest.mark.skipif(sys.platform == 'win32', reason='ProcessExecutor not available on Windows')
def test_unused_function_unmatched_builddir_j_process(tmpdir):
build_dir = os.path.join(tmpdir, 'b1')
os.mkdir(build_dir)
__test_unused_function_unmatched(tmpdir, ['-j2', '--cppcheck-build-dir={}'.format(build_dir), '--executor=process'])
# do not report unmatched unusedFunction inline suppressions when unusedFunction check is disabled
def test_unused_function_disabled_unmatched():
args = [
'-q',
'--template=simple',
'--enable=warning,information',
'--inline-suppr',
'proj-inline-suppress/unusedFunctionUnmatched.cpp'
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
assert stderr.splitlines() == [
'{}unusedFunctionUnmatched.cpp:5:0: information: Unmatched suppression: uninitvar [unmatchedSuppression]'.format(__proj_inline_suppres_path)
]
assert stdout == ''
assert ret == 0, stdout
def test_unmatched_cfg():
# make sure we do not report unmatched inline suppressions from inactive code blocks
args = [
'-q',
'--template=simple',
'--enable=warning,information',
'--inline-suppr',
'proj-inline-suppress/cfg.c'
]
ret, stdout, stderr = cppcheck(args, cwd=__script_dir)
assert stderr.splitlines() == [
'{}cfg.c:10:0: information: Unmatched suppression: id [unmatchedSuppression]'.format(__proj_inline_suppres_path),
'{}cfg.c:14:0: information: Unmatched suppression: id [unmatchedSuppression]'.format(__proj_inline_suppres_path),
]
assert stdout == ''
assert ret == 0, stdout
|
