1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464
|
# THIS FILE IS PART OF THE CYLC WORKFLOW ENGINE.
# Copyright (C) NIWA & British Crown (Met Office) & Contributors.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
"""Test "cylc set" functionality.
Note: see also functional tests
"""
from secrets import token_hex
from typing import Callable
import pytest
from cylc.flow.commands import (
run_cmd,
set_prereqs_and_outputs,
)
from cylc.flow.cycling.integer import IntegerPoint
from cylc.flow.data_messages_pb2 import (
PbJob,
PbTaskProxy,
)
from cylc.flow.data_store_mgr import (
JOBS,
TASK_PROXIES,
task_mean_elapsed_time,
)
from cylc.flow.id import TaskTokens
from cylc.flow.scheduler import Scheduler
from cylc.flow.task_outputs import (
TASK_OUTPUT_FAILED,
TASK_OUTPUT_STARTED,
TASK_OUTPUT_SUBMITTED,
TASK_OUTPUT_SUCCEEDED,
)
from cylc.flow.task_proxy import TaskProxy
from cylc.flow.task_state import (
TASK_STATUS_FAILED,
TASK_STATUS_PREPARING,
TASK_STATUS_SUCCEEDED,
TASK_STATUS_WAITING,
)
def outputs_section(*names: str) -> dict:
"""Create outputs section with random messages for the given output names.
"""
return {
'outputs': {
name: token_hex() for name in names
}
}
async def test_set_parentless_spawning(
flow,
scheduler,
run,
complete,
):
"""Ensure that setting outputs does not interfere with parentless spawning.
Setting outputs manually causes the logic to follow a different code
pathway to "natural" output satisfaction. If we're not careful this could
lead to "premature shutdown" (i.e. the scheduler thinks it's finished when
it isn't), this test makes sure that's not the case.
"""
id_ = flow({
'scheduling': {
'initial cycle point': '1',
'cycling mode': 'integer',
'runahead limit': 'P0',
'graph': {'P1': 'a => z'},
},
})
schd: Scheduler = scheduler(id_, paused_start=False)
async with run(schd):
# mark cycle 1 as succeeded
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'a'), TaskTokens('1', 'z')},
['succeeded'],
[],
['1'],
)
# the parentless task "a" should be spawned out to the runahead limit
assert schd.pool.get_task_ids() == {'2/a', '3/a'}
# the workflow should run on to the next cycle
await complete(schd, '2/a', timeout=5)
async def test_rerun_incomplete(
flow,
scheduler,
run,
complete,
reflog,
):
"""Incomplete tasks should be re-run."""
id_ = flow({
'scheduling': {
'graph': {'R1': 'a => z'},
},
'runtime': {
# register a custom output
'a': {'outputs': {'x': 'xyz'}},
},
})
schd = scheduler(id_, paused_start=False)
async with run(schd):
# generate 1/a:x but do not complete 1/a
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'a')}, ['x'], [], ['1']
)
triggers = reflog(schd)
await complete(schd)
assert triggers == {
# the task 1/a should have been run despite the earlier
# setting of the "x" output
('1/a', None),
('1/z', ('1/a',)),
}
async def test_data_store(
flow,
scheduler,
start,
):
"""Test that manually set prereqs/outputs are applied to the data store."""
id_ = flow({
'scheduling': {
'graph': {'R1': 'a => z'},
},
'runtime': {
# register a custom output
'a': {'outputs': {'x': 'xyz'}},
},
})
schd: Scheduler = scheduler(id_)
async with start(schd):
await schd.update_data_structure()
data = schd.data_store_mgr.data[schd.tokens.id]
# 1/a not the same data-store object post set and not in pool
# post succeeded.
task_a_id = schd.pool.get_task(IntegerPoint('1'), 'a').tokens.id
# set the 1/a:succeeded prereq of 1/z
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'z')}, [], ['1/a:succeeded'], ['1'])
task_z = data[TASK_PROXIES][
schd.pool.get_task(IntegerPoint('1'), 'z').tokens.id
]
await schd.update_data_structure()
assert task_z.prerequisites[0].satisfied is True
# set 1/a:x the task should be waiting with output x satisfied
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'a')}, ['x'], [], ['1']
)
await schd.update_data_structure()
task_a: PbTaskProxy = data[TASK_PROXIES][task_a_id]
assert task_a.state == TASK_STATUS_WAITING
assert task_a.outputs['x'].satisfied is True
assert task_a.outputs['succeeded'].satisfied is False
# set 1/a:succeeded the task should be succeeded with output x sat
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'a')}, ['succeeded'], [], ['1']
)
await schd.update_data_structure()
task_a: PbTaskProxy = data[TASK_PROXIES][task_a_id]
assert task_a.state == TASK_STATUS_SUCCEEDED
assert task_a.outputs['x'].satisfied is True
assert task_a.outputs['succeeded'].satisfied is True
async def test_incomplete_detection(
one_conf,
flow,
scheduler,
start,
log_filter,
):
"""It should detect and log finished tasks left with incomplete outputs."""
schd = scheduler(flow(one_conf))
async with start(schd):
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'one')}, ['failed'], [], ['1']
)
assert log_filter(contains='1/one did not complete')
async def test_pre_all(flow, scheduler, run):
"""Ensure that --pre=all is interpreted as a special case
and _not_ tokenized.
"""
id_ = flow({'scheduling': {'graph': {'R1': 'a => z'}}})
schd = scheduler(id_, paused_start=False)
async with run(schd) as log:
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'z')}, [], ['all'], []
)
warn_or_higher = [i for i in log.records if i.levelno > 30]
assert warn_or_higher == []
async def test_bad_prereq(
flow: 'Callable',
scheduler: 'Callable',
run: 'Callable',
complete: 'Callable',
caplog: 'pytest.LogCaptureFixture'
):
"""Attempting to set an invalid prerequisite should not leave a trace in
the DB that prevents the target task from spawning. later on.
"""
id_ = flow({
'scheduling': {
'graph': {'R1': 'a => b => c'},
},
})
schd = scheduler(id_, paused_start=False)
async with run(schd):
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'c')}, [], ['1/a'], []
)
assert schd.pool.get_task_ids() == {'1/a'}
assert '1/c does not depend on "1/a:succeeded"' in caplog.text
schd.workflow_db_mgr.process_queued_ops()
# This will fail if the previous set left 1/c in the DB:
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'c')}, [], ['1/b'], []
)
assert schd.pool.get_task_ids() == {'1/a', '1/c'}
await complete(schd, '1/c', timeout=5)
async def test_no_outputs_given(flow, scheduler, start):
"""Test `cylc set` without providing any outputs.
It should set the "success pathway" outputs.
"""
schd: Scheduler = scheduler(
flow({
'scheduling': {
'graph': {
'R1': r"""
foo? => alpha
foo:submitted? => bravo
foo:started? => charlie
foo:x => xray
# Optional custom outputs not emitted:
foo:y? => yankee
# Non-success-pathway outputs not emitted:
foo:submit-failed? => delta
""",
},
},
'runtime': {
'foo': outputs_section('x', 'y'),
},
})
)
async with start(schd):
foo = schd.pool.get_tasks()[0]
await run_cmd(
set_prereqs_and_outputs(schd, {foo.tokens}, [])
)
assert set(foo.state.outputs.get_completed_outputs()) == {
TASK_OUTPUT_SUBMITTED,
TASK_OUTPUT_STARTED,
TASK_OUTPUT_SUCCEEDED,
'x'
}
assert schd.pool.get_task_ids() == {
'1/alpha',
'1/bravo',
'1/charlie',
'1/xray',
}
async def test_completion_expr(flow, scheduler, start):
"""Test `cylc set` without providing any outputs on a task that has a
custom completion expression."""
conf = {
'scheduling': {
'graph': {
'R1': 'foo? | foo:x? => bar'
},
},
'runtime': {
'foo': {
**outputs_section('x'),
'completion': '(succeeded or x) or failed'
},
},
}
schd: Scheduler = scheduler(flow(conf))
async with start(schd):
foo = schd.pool.get_tasks()[0]
await run_cmd(
set_prereqs_and_outputs(schd, {foo.tokens}, [])
)
assert set(foo.state.outputs.get_completed_outputs()) == {
TASK_OUTPUT_SUBMITTED,
TASK_OUTPUT_STARTED,
TASK_OUTPUT_SUCCEEDED,
}
async def test_set_submitted(flow, scheduler, start):
"""`cylc set --out submitted` should spawn children that depend on the
output, but not affect the task's state."""
schd: Scheduler = scheduler(flow('foo:submitted? => bar'))
async with start(schd):
foo = schd.pool.get_tasks()[0]
await run_cmd(
set_prereqs_and_outputs(
schd, [foo.identity], [], ['submitted']
)
)
assert set(foo.state.outputs.get_completed_outputs()) == {
TASK_OUTPUT_SUBMITTED,
}
assert schd.pool.get_task_ids() == {'1/foo', '1/bar'}
assert foo.state(TASK_STATUS_WAITING)
async def test_job_state(flow, scheduler, start, db_select):
"""Test that setting outputs does not change the job state."""
schd: Scheduler = scheduler(flow('foo => bar'))
fail_time = '1950-01-01T00:00:00Z'
def db_task_states(itask: TaskProxy):
return db_select(
schd, True, 'task_states', 'status', name=itask.tdef.name
)
def assert_job_failed(itask: TaskProxy):
"""...in the DB and data store."""
assert db_select(
schd,
True,
'task_jobs',
'run_status',
'time_run_exit',
name=itask.tdef.name,
) == [(1, fail_time)]
pb_job: PbJob = schd.data_store_mgr.data[schd.tokens.id][JOBS][
itask.job_tokens.id
]
assert pb_job.state == TASK_STATUS_FAILED
assert pb_job.finished_time == fail_time
async with start(schd):
foo = schd.pool.get_tasks()[0]
schd.submit_task_jobs([foo])
schd.task_events_mgr.process_message(
foo, 'INFO', TASK_OUTPUT_FAILED, event_time=fail_time
)
await schd.update_data_structure()
assert foo.state(TASK_STATUS_FAILED)
assert db_task_states(foo) == [(TASK_STATUS_FAILED,)]
assert_job_failed(foo)
await run_cmd(
set_prereqs_and_outputs(schd, [foo.identity], [])
)
await schd.update_data_structure()
# Task is now succeeded:
assert foo.state(TASK_STATUS_SUCCEEDED)
assert db_task_states(foo) == [(TASK_STATUS_SUCCEEDED,)]
# But job is still failed:
assert_job_failed(foo)
async def test_set_already_succeeded(
flow, scheduler, run, complete, db_select
):
"""Doing `cylc set` on a task that has already succeeded should not
change anything."""
schd: Scheduler = scheduler(
flow('foo => bar'),
paused_start=False,
)
def db_task_states(itask: TaskProxy):
return db_select(
schd,
True,
'task_states',
'submit_num',
'status',
'time_updated',
name=itask.tdef.name,
)
def data_store_task_state(itask: TaskProxy):
return schd.data_store_mgr.data[schd.tokens.id][TASK_PROXIES][
itask.tokens.id
].state
async with run(schd):
foo = schd.pool.get_tasks()[0]
await complete(schd, foo.identity)
time_updated = db_task_states(foo)[0][2]
expected = [(1, TASK_STATUS_SUCCEEDED, time_updated)]
assert db_task_states(foo) == expected
assert data_store_task_state(foo) == TASK_STATUS_SUCCEEDED
await run_cmd(
set_prereqs_and_outputs(schd, [foo.identity], [])
)
assert foo.state(TASK_STATUS_SUCCEEDED)
await schd.update_data_structure()
assert db_task_states(foo) == expected
assert data_store_task_state(foo) == TASK_STATUS_SUCCEEDED
async def test_timings(one_conf, flow, scheduler, start, caplog):
"""Test that setting outputs does not change the task timings."""
wid = flow({
**one_conf,
'runtime': {
'one': {
'execution time limit': 'PT100S',
},
},
})
schd: Scheduler = scheduler(wid)
async with start(schd):
itask = schd.pool.get_tasks()[0]
def check_times():
assert not itask.tdef.elapsed_times
assert task_mean_elapsed_time(itask.tdef) == 100
itask.state_reset(TASK_STATUS_PREPARING)
schd.task_events_mgr.process_message(
itask, 'INFO', TASK_OUTPUT_STARTED
)
check_times()
await run_cmd(set_prereqs_and_outputs(schd, [itask.identity], []))
check_times()
|