1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578
|
# THIS FILE IS PART OF THE CYLC WORKFLOW ENGINE.
# Copyright (C) NIWA & British Crown (Met Office) & Contributors.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
from json import loads
import logging
from typing import (
TYPE_CHECKING,
AsyncGenerator,
Callable,
Iterable,
List,
Tuple,
Union,
cast,
)
import pytest
from pytest import param
import re
from cylc.flow import (
CYLC_LOG,
commands,
)
from cylc.flow.cycling.integer import IntegerPoint
from cylc.flow.cycling.iso8601 import ISO8601Point
from cylc.flow.data_messages_pb2 import PbPrerequisite
from cylc.flow.data_store_mgr import TASK_PROXIES
from cylc.flow.exceptions import WorkflowConfigError
from cylc.flow.flow_mgr import FLOW_NONE
from cylc.flow.id import TaskTokens, Tokens
from cylc.flow.task_events_mgr import TaskEventsManager
from cylc.flow.task_outputs import (
TASK_OUTPUT_FAILED,
TASK_OUTPUT_SUCCEEDED,
)
from cylc.flow.task_pool import TaskPool
from cylc.flow.task_state import (
TASK_STATUS_EXPIRED,
TASK_STATUS_FAILED,
TASK_STATUS_PREPARING,
TASK_STATUS_RUNNING,
TASK_STATUS_SUBMIT_FAILED,
TASK_STATUS_SUBMITTED,
TASK_STATUS_SUCCEEDED,
TASK_STATUS_WAITING,
)
if TYPE_CHECKING:
from cylc.flow.cycling import PointBase
from cylc.flow.scheduler import Scheduler
# NOTE: foo and bar have no parents so at start-up (even with the workflow
# paused) they get spawned out to the runahead limit. 2/pub spawns
# immediately too, because we spawn autospawn absolute-triggered tasks as
# well as parentless tasks. 3/asd does not spawn at start, however.
EXAMPLE_FLOW_CFG = {
'scheduling': {
'cycling mode': 'integer',
'initial cycle point': 1,
'final cycle point': 10,
'runahead limit': 'P3',
'graph': {
'P1': 'foo & bar',
'R1/2': 'foo[1] => pub',
'R1/3': 'foo[-P1] => asd'
}
},
'runtime': {
'FAM': {},
'bar': {'inherit': 'FAM'}
}
}
EXAMPLE_FLOW_2_CFG = {
'scheduler': {
'UTC mode': True
},
'scheduling': {
'initial cycle point': '2001',
'runahead limit': 'P3Y',
'graph': {
'P1Y': 'foo',
'R/2025/P1Y': 'foo => bar',
}
},
}
def get_task_ids(
name_point_list: Iterable[Tuple[str, Union['PointBase', str, int]]]
) -> List[str]:
"""Helper function to return sorted task identities
from a list of (name, point) tuples."""
return sorted(f'{point}/{name}' for name, point in name_point_list)
def assert_expected_log(
caplog_instance: pytest.LogCaptureFixture,
expected_log_substrings: List[str]
) -> List[str]:
"""Helper function to check that expected (substrings of) log messages
are actually in the log.
Returns the list of actual logged messages.
Args:
caplog_instance: The instance of the caplog fixture for the particular
test.
expected_log_substrings: The expected, possibly partial, log messages.
"""
logged_messages = [i[2] for i in caplog_instance.record_tuples]
assert len(logged_messages) == len(expected_log_substrings)
for actual, expected in zip(
sorted(logged_messages), sorted(expected_log_substrings)):
assert expected in actual
return logged_messages
@pytest.fixture(scope='module')
async def mod_example_flow(
mod_flow: Callable, mod_scheduler: Callable, mod_run: Callable
) -> AsyncGenerator['Scheduler', None]:
"""Return a scheduler for interrogating its task pool.
This is module-scoped so faster than example_flow, but should only be used
where the test does not mutate the state of the scheduler or task pool.
"""
id_ = mod_flow(EXAMPLE_FLOW_CFG)
schd: 'Scheduler' = mod_scheduler(id_, paused_start=True)
async with mod_run(schd, level=logging.DEBUG):
yield schd
@pytest.fixture
async def example_flow(
flow: Callable,
scheduler: Callable,
start,
caplog: pytest.LogCaptureFixture,
) -> AsyncGenerator['Scheduler', None]:
"""Return a scheduler for interrogating its task pool.
This is function-scoped so slower than mod_example_flow; only use this
when the test mutates the scheduler or task pool.
"""
# The run(schd) fixture doesn't work for modifying the DB, so have to
# set up caplog and do schd.install()/.initialise()/.configure() instead
caplog.set_level(logging.INFO, CYLC_LOG)
id_ = flow(EXAMPLE_FLOW_CFG)
schd: 'Scheduler' = scheduler(id_)
async with start(schd, level=logging.DEBUG):
yield schd
@pytest.fixture(scope='module')
async def mod_example_flow_2(
mod_flow: Callable, mod_scheduler: Callable, mod_run: Callable
) -> AsyncGenerator['Scheduler', None]:
"""Return a scheduler for interrogating its task pool.
This is module-scoped so faster than example_flow, but should only be used
where the test does not mutate the state of the scheduler or task pool.
"""
id_ = mod_flow(EXAMPLE_FLOW_2_CFG)
schd: 'Scheduler' = mod_scheduler(id_, paused_start=True)
async with mod_run(schd):
yield schd
@pytest.mark.parametrize(
'ids, expected_tasks_to_hold_ids',
[
param(
['1/foo', '3/asd'],
['1/foo', '3/asd'],
id="Active & inactive tasks",
),
param(
['1/FAM', '2/FAM', '6/FAM'],
['1/bar', '2/bar', '6/bar'],
id="Family names hold active and future tasks",
),
param(
['1/grogu', 'H/foo', '20/foo', '1/pub'],
[],
id="Non-existent task name or invalid cycle point",
),
param(
['1/foo:waiting', '1/foo:failed', '6/bar:waiting'],
['1/foo'],
id=(
"Specifying task state works for active tasks,"
" not inactive tasks"
),
),
],
)
async def test_hold_tasks(
ids: List[str],
expected_tasks_to_hold_ids: List[str],
example_flow: 'Scheduler',
caplog: pytest.LogCaptureFixture,
db_select: Callable
) -> None:
"""Test TaskPool.hold_tasks().
Also tests TaskPool_explicit_match_tasks_to_hold() in the process;
kills 2 birds with 1 stone.
Params:
items: Arg passed to hold_tasks().
expected_tasks_to_hold_ids: Expected IDs of the tasks that get put in
the TaskPool.tasks_to_hold set, of the form "{point}/{name}"/
expected_warnings: Expected to be logged.
"""
expected_tasks_to_hold_ids = sorted(expected_tasks_to_hold_ids)
caplog.set_level(logging.WARNING, CYLC_LOG)
task_pool = example_flow.pool
task_pool.hold_tasks(
{cast('TaskTokens', Tokens(id_, relative=True)) for id_ in ids}
)
for itask in task_pool.get_tasks():
hold_expected = itask.identity in expected_tasks_to_hold_ids
assert itask.state.is_held is hold_expected
assert get_task_ids(task_pool.tasks_to_hold) == expected_tasks_to_hold_ids
db_held_tasks = db_select(example_flow, True, 'tasks_to_hold')
assert get_task_ids(db_held_tasks) == expected_tasks_to_hold_ids
async def test_release_held_tasks(
example_flow: 'Scheduler', db_select: Callable
) -> None:
"""Test TaskPool.release_held_tasks().
For a workflow with held active tasks 1/foo & 1/bar, and held inactive task
3/asd.
We skip testing the matching logic here because it would be slow using the
function-scoped example_flow fixture, and it would repeat what is covered
in test_hold_tasks().
"""
# Setup
task_pool = example_flow.pool
expected_tasks_to_hold_ids = sorted(['1/foo', '1/bar', '3/asd'])
task_pool.hold_tasks(
{
TaskTokens('1', 'foo'),
TaskTokens('1', 'bar'),
TaskTokens('3', 'asd'),
}
)
for itask in task_pool.get_tasks():
hold_expected = itask.identity in expected_tasks_to_hold_ids
assert itask.state.is_held is hold_expected
assert get_task_ids(task_pool.tasks_to_hold) == expected_tasks_to_hold_ids
db_tasks_to_hold = db_select(example_flow, True, 'tasks_to_hold')
assert get_task_ids(db_tasks_to_hold) == expected_tasks_to_hold_ids
# Test
task_pool.release_held_tasks(
{TaskTokens('1', 'foo'), TaskTokens('3', 'asd')}
)
for itask in task_pool.get_tasks():
assert itask.state.is_held is (itask.identity == '1/bar')
expected_tasks_to_hold_ids = sorted(['1/bar'])
assert get_task_ids(task_pool.tasks_to_hold) == expected_tasks_to_hold_ids
db_tasks_to_hold = db_select(example_flow, True, 'tasks_to_hold')
assert get_task_ids(db_tasks_to_hold) == expected_tasks_to_hold_ids
@pytest.mark.parametrize(
'hold_after_point, expected_held_task_ids',
[
(
'0',
[
'1/foo',
'1/bar',
'2/foo',
'2/bar',
'2/pub',
'3/foo',
'3/bar',
'4/foo',
'4/bar',
'5/foo',
'5/bar',
],
),
(
'1',
[
'2/foo',
'2/bar',
'2/pub',
'3/foo',
'3/bar',
'4/foo',
'4/bar',
'5/foo',
'5/bar',
],
),
],
)
async def test_hold_point(
hold_after_point: str,
expected_held_task_ids: List[str],
example_flow: 'Scheduler', db_select: Callable
) -> None:
"""Test TaskPool.set_hold_point() and .release_hold_point()"""
expected_held_task_ids = sorted(expected_held_task_ids)
task_pool = example_flow.pool
# Test hold
task_pool.set_hold_point(IntegerPoint(hold_after_point))
assert ('holdcp', str(hold_after_point)) in db_select(
example_flow, True, 'workflow_params')
for itask in task_pool.get_tasks():
hold_expected = itask.identity in expected_held_task_ids
assert itask.state.is_held is hold_expected
assert get_task_ids(task_pool.tasks_to_hold) == expected_held_task_ids
db_tasks_to_hold = db_select(example_flow, True, 'tasks_to_hold')
assert get_task_ids(db_tasks_to_hold) == expected_held_task_ids
# Test release
task_pool.release_hold_point()
assert db_select(example_flow, True, 'workflow_params', key='holdcp') == [
('holdcp', None)
]
for itask in task_pool.get_tasks():
assert itask.state.is_held is False
assert task_pool.tasks_to_hold == set()
assert db_select(example_flow, True, 'tasks_to_hold') == []
@pytest.mark.parametrize(
'status,should_trigger',
[
(TASK_STATUS_WAITING, True),
(TASK_STATUS_PREPARING, False),
(TASK_STATUS_SUBMITTED, False),
(TASK_STATUS_RUNNING, False),
(TASK_STATUS_SUCCEEDED, True),
]
)
async def test_trigger_states(
status: str, should_trigger: bool, one: 'Scheduler', start: Callable
):
"""It should only trigger tasks in compatible states."""
async with start(one):
itask = one.pool.get_task(IntegerPoint('1'), 'one')
# reset task a to the provided state
itask.state.reset(status)
# try triggering the task
await commands.run_cmd(
commands.force_trigger_tasks(one, ['1/one'], []))
# retrieve the task again - the original may have been removed
itask = one.pool.get_task(IntegerPoint('1'), 'one')
# check whether the task triggered
assert itask.is_manual_submit == should_trigger
async def test_preparing_tasks_on_restart(one_conf, flow, scheduler, start):
"""Preparing tasks should be reset to waiting on restart.
This forces preparation to be re-done on restart so that it uses the
new configuration.
See discussion on: https://github.com/cylc/cylc-flow/pull/4668
"""
id_ = flow(one_conf)
# start the workflow, reset a task to preparing
one = scheduler(id_)
async with start(one):
itask = one.pool.get_tasks()[0]
itask.state.reset(TASK_STATUS_PREPARING)
# when we restart the task should have been reset to waiting
one = scheduler(id_)
async with start(one):
itask = one.pool.get_tasks()[0]
assert itask.state(TASK_STATUS_WAITING)
itask.state.reset(TASK_STATUS_SUCCEEDED)
# whereas if we reset the task to succeeded the state is not reset
one = scheduler(id_)
async with start(one):
itask = one.pool.get_tasks()[0]
assert itask.state(TASK_STATUS_SUCCEEDED)
async def test_reload_stopcp(
flow: Callable, scheduler: Callable, start: Callable
):
"""Test that the task pool stopping point does not revert to the final
cycle point on reload."""
cfg = {
'scheduler': {
'allow implicit tasks': True,
'cycle point format': 'CCYY',
},
'scheduling': {
'initial cycle point': 2010,
'stop after cycle point': 2020,
'final cycle point': 2030,
'graph': {
'P1Y': 'anakin'
}
}
}
schd: 'Scheduler' = scheduler(flow(cfg))
async with start(schd):
assert str(schd.pool.stop_point) == '2020'
await commands.run_cmd(commands.reload_workflow(schd))
assert str(schd.pool.stop_point) == '2020'
async def test_runahead_after_remove(
example_flow: 'Scheduler'
) -> None:
"""The runahead limit should be recomputed after tasks are removed.
"""
task_pool = example_flow.pool
assert int(task_pool.runahead_limit_point) == 4
# No change after removing an intermediate cycle.
await commands.run_cmd(commands.remove_tasks(example_flow, ['3/*'], ["1"]))
assert int(task_pool.runahead_limit_point) == 4
# Should update after removing the first point.
await commands.run_cmd(commands.remove_tasks(example_flow, ['1/*'], ["1"]))
assert int(task_pool.runahead_limit_point) == 5
async def test_load_db_bad_platform(
flow: Callable, scheduler: Callable, start: Callable, one_conf: Callable
):
"""Test that loading an unavailable platform from the database doesn't
cause calamitous failure."""
schd: 'Scheduler' = scheduler(flow(one_conf))
async with start(schd):
result = schd.pool.load_db_task_pool_for_restart(0, (
'1', 'one', '{"1": 1}', "0", False, False, "failed",
False, 1, '', 'culdee-fell-summit', '', '', '', '{}'
))
assert result == 'culdee-fell-summit'
def list_tasks(schd):
"""Return a sorted list of task pool tasks.
Returns a list in the format:
[
(cycle, task, state)
]
"""
return sorted(
(itask.tokens['cycle'], itask.tokens['task'], itask.state.status)
for itask in schd.pool.get_tasks()
)
@pytest.mark.parametrize(
'graph_1, graph_2, '
'expected_1, expected_2, expected_3, expected_4',
[
param( # Restart after adding a prerequisite to task z
'''a => z
b => z''',
'''a => z
b => z
c => z''',
[
('1', 'a', 'running'),
('1', 'b', 'running'),
],
[
('1', 'b', 'running'),
('1', 'z', 'waiting'),
],
[
('1', 'b', 'running'),
('1', 'z', 'waiting'),
],
[
{('1', 'a', 'succeeded'): 'satisfied naturally'},
{('1', 'b', 'succeeded'): False},
{('1', 'c', 'succeeded'): False},
],
id='added'
),
param( # Restart after removing a prerequisite from task z
'''a => z
b => z
c => z''',
'''a => z
b => z''',
[
('1', 'a', 'running'),
('1', 'b', 'running'),
('1', 'c', 'running'),
],
[
('1', 'b', 'running'),
('1', 'c', 'running'),
('1', 'z', 'waiting'),
],
[
('1', 'b', 'running'),
('1', 'c', 'running'),
('1', 'z', 'waiting'),
],
[
{('1', 'a', 'succeeded'): 'satisfied naturally'},
{('1', 'b', 'succeeded'): False},
],
id='removed'
)
]
)
async def test_restart_prereqs(
flow, scheduler, start,
graph_1, graph_2,
expected_1, expected_2, expected_3, expected_4
):
"""It should handle graph prerequisites change on restart.
Prerequisite changes must be applied to tasks already in the pool.
See https://github.com/cylc/cylc-flow/pull/5334
"""
conf = {
'scheduler': {'allow implicit tasks': 'True'},
'scheduling': {
'graph': {
'R1': graph_1
}
}
}
id_ = flow(conf)
schd: Scheduler = scheduler(id_, paused_start=False)
async with start(schd):
# Release tasks 1/a and 1/b
schd.pool.release_runahead_tasks()
schd.release_tasks_to_run()
assert list_tasks(schd) == expected_1
# Mark 1/a as succeeded and spawn 1/z
task_a = schd.pool.get_tasks()[0]
schd.pool.task_events_mgr.process_message(task_a, 1, 'succeeded')
assert list_tasks(schd) == expected_2
# Save our progress
schd.workflow_db_mgr.put_task_pool(schd.pool)
# Edit the workflow to add a new dependency on "z"
conf['scheduling']['graph']['R1'] = graph_2
id_ = flow(conf, workflow_id=id_)
# Restart it
schd = scheduler(id_, run_mode='simulation', paused_start=False)
async with start(schd):
# Load jobs from db
schd.workflow_db_mgr.pri_dao.select_jobs_for_restart(
schd.data_store_mgr.insert_db_job
)
assert list_tasks(schd) == expected_3
# To cover some code for loading prereqs from the DB at restart:
schd.data_store_mgr.update_data_structure()
# Check resulting dependencies of task z
task_z = [
t for t in schd.pool.get_tasks() if t.tdef.name == "z"
][0]
assert sorted(
(
p._satisfied
for p in task_z.state.prerequisites
),
key=lambda d: tuple(d.keys())[0],
) == expected_4
@pytest.mark.parametrize(
'graph_1, graph_2, '
'expected_1, expected_2, expected_3, expected_4',
[
param( # Reload after adding a prerequisite to task z
'''a => z
b => z''',
'''a => z
b => z
c => z''',
[
('1', 'a', 'running'),
('1', 'b', 'running'),
],
[
('1', 'b', 'running'),
('1', 'z', 'waiting'),
],
[
('1', 'b', 'running'),
('1', 'z', 'waiting'),
],
[
{('1', 'a', 'succeeded'): 'satisfied naturally'},
{('1', 'b', 'succeeded'): False},
{('1', 'c', 'succeeded'): False},
],
id='added'
),
param( # Reload after removing a prerequisite from task z
'''a => z
b => z
c => z''',
'''a => z
b => z''',
[
('1', 'a', 'running'),
('1', 'b', 'running'),
('1', 'c', 'running'),
],
[
('1', 'b', 'running'),
('1', 'c', 'running'),
('1', 'z', 'waiting'),
],
[
('1', 'b', 'running'),
('1', 'c', 'running'),
('1', 'z', 'waiting'),
],
[
{('1', 'a', 'succeeded'): 'satisfied naturally'},
{('1', 'b', 'succeeded'): False},
],
id='removed'
)
]
)
async def test_reload_prereqs(
flow, scheduler, start,
graph_1, graph_2,
expected_1, expected_2, expected_3, expected_4
):
"""It should handle graph prerequisites change on reload.
Prerequisite changes must be applied to tasks already in the pool.
See https://github.com/cylc/cylc-flow/pull/5334
"""
conf = {
'scheduler': {'allow implicit tasks': 'True'},
'scheduling': {
'graph': {
'R1': graph_1
}
}
}
id_ = flow(conf)
schd: Scheduler = scheduler(id_, paused_start=False)
async with start(schd):
# Release tasks 1/a and 1/b
schd.pool.release_runahead_tasks()
schd.release_tasks_to_run()
assert list_tasks(schd) == expected_1
# Mark 1/a as succeeded and spawn 1/z
task_a = schd.pool.get_tasks()[0]
schd.pool.task_events_mgr.process_message(task_a, 1, 'succeeded')
assert list_tasks(schd) == expected_2
# Modify flow.cylc to add a new dependency on "z"
conf['scheduling']['graph']['R1'] = graph_2
flow(conf, workflow_id=id_)
# Reload the workflow config
await commands.run_cmd(commands.reload_workflow(schd))
assert list_tasks(schd) == expected_3
# Check resulting dependencies of task z
task_z = [
t for t in schd.pool.get_tasks() if t.tdef.name == "z"
][0]
assert sorted(
(
p._satisfied
for p in task_z.state.prerequisites
),
key=lambda d: tuple(d.keys())[0],
) == expected_4
async def _test_restart_prereqs_sat():
schd: Scheduler
# YIELD: the workflow has now started...
schd = yield
await schd.update_data_structure()
# Release tasks 1/a and 1/b
schd.pool.release_runahead_tasks()
schd.release_tasks_to_run()
assert list_tasks(schd) == [
('1', 'a', 'running'),
('1', 'b', 'running')
]
# Mark both as succeeded and spawn 1/c
for itask in schd.pool.get_tasks():
schd.pool.task_events_mgr.process_message(itask, 1, 'succeeded')
schd.workflow_db_mgr.put_update_task_outputs(itask)
schd.pool.remove_if_complete(itask)
schd.workflow_db_mgr.process_queued_ops()
assert list_tasks(schd) == [
('1', 'c', 'waiting')
]
# YIELD: the workflow has now restarted or reloaded with the new config...
schd = yield
await schd.update_data_structure()
assert list_tasks(schd) == [
('1', 'c', 'waiting')
]
# Check resulting dependencies of task z
task_c = schd.pool.get_tasks()[0]
assert sorted(
(*key, satisfied)
for prereq in task_c.state.prerequisites
for key, satisfied in prereq.items()
) == [
('1', 'a', 'succeeded', 'satisfied naturally'),
('1', 'b', 'succeeded', 'satisfied from database')
]
# The prereqs in the data store should have been updated too
# await schd.update_data_structure()
tasks = (
schd.data_store_mgr.data[schd.data_store_mgr.workflow_id][TASK_PROXIES]
)
task_c_prereqs: List[PbPrerequisite] = tasks[
schd.data_store_mgr.id_.duplicate(cycle='1', task='c').id
].prerequisites
assert sorted(
(condition.task_proxy, condition.satisfied, condition.message)
for prereq in task_c_prereqs
for condition in prereq.conditions
) == [
('1/a', True, 'satisfied naturally'),
('1/b', True, 'satisfied from database'),
]
# and we're done, yield back control and return
yield
@pytest.mark.parametrize('do_restart', [True, False])
async def test_graph_change_prereq_satisfaction(
flow, scheduler, start, do_restart
):
"""It should handle graph prerequisites change on reload/restart.
If the graph is changed to add a dependency which has been previously
satisfied, then Cylc should perform a DB check and mark the prerequsite
as satisfied accordingly.
See https://github.com/cylc/cylc-flow/pull/5334
"""
conf = {
'scheduler': {'allow implicit tasks': 'True'},
'scheduling': {
'graph': {
'R1': '''
a => c
b
'''
}
}
}
id_ = flow(conf)
schd = scheduler(id_, run_mode='simulation', paused_start=False)
test = _test_restart_prereqs_sat()
await test.asend(None)
if do_restart:
async with start(schd):
# start the workflow and run part 1 of the tests
await test.asend(schd)
# shutdown and change the workflow definiton
conf['scheduling']['graph']['R1'] += '\nb => c'
flow(conf, workflow_id=id_)
schd = scheduler(id_, run_mode='simulation', paused_start=False)
async with start(schd):
# restart the workflow and run part 2 of the tests
await test.asend(schd)
else:
async with start(schd):
await test.asend(schd)
# Modify flow.cylc to add a new dependency on "b"
conf['scheduling']['graph']['R1'] += '\nb => c'
flow(conf, workflow_id=id_)
# Reload the workflow config
await commands.run_cmd(commands.reload_workflow(schd))
await test.asend(schd)
async def test_runahead_limit_for_sequence_before_start_cycle(
flow,
scheduler,
start,
):
"""It should obey the runahead limit.
Ensure the runahead limit is computed correctly for sequences before the
start cycle
See https://github.com/cylc/cylc-flow/issues/5603
"""
id_ = flow({
'scheduler': {'allow implicit tasks': 'True'},
'scheduling': {
'initial cycle point': '2000',
'runahead limit': 'P2Y',
'graph': {
'R1/2000': 'a',
'P1Y': 'b[-P1Y] => b',
},
}
})
schd = scheduler(id_, startcp='2005')
async with start(schd):
assert str(schd.pool.runahead_limit_point) == '20070101T0000Z'
def list_pool_from_db(schd):
"""Returns the task pool table as a sorted list."""
db_task_pool = []
schd.workflow_db_mgr.pri_dao.select_task_pool(
lambda _, row: db_task_pool.append(row)
)
return sorted(db_task_pool)
async def test_db_update_on_removal(
flow,
scheduler,
start,
):
"""It should updated the task_pool table when tasks complete.
There was a bug where the task_pool table was only being updated when tasks
in the pool were updated. This meant that if a task was removed the DB
would not reflect this change and would hold a record of the task in the
wrong state.
This test ensures that the DB is updated when a task is removed from the
pool.
See: https://github.com/cylc/cylc-flow/issues/5598
"""
id_ = flow({
'scheduler': {
'allow implicit tasks': 'true',
},
'scheduling': {
'graph': {
'R1': 'a',
},
},
})
schd = scheduler(id_)
async with start(schd):
task_a = schd.pool.get_tasks()[0]
# set the task to running
schd.pool.task_events_mgr.process_message(task_a, 1, 'started')
# update the db
await schd.update_data_structure()
schd.workflow_db_mgr.process_queued_ops()
# the task should appear in the DB
assert list_pool_from_db(schd) == [
['1', 'a', 'running', 0],
]
# mark the task as succeeded and allow it to be removed from the pool
schd.pool.task_events_mgr.process_message(task_a, 1, 'succeeded')
schd.pool.remove_if_complete(task_a)
# update the DB, note no new tasks have been added to the pool
await schd.update_data_structure()
schd.workflow_db_mgr.process_queued_ops()
# the task should be gone from the DB
assert list_pool_from_db(schd) == []
async def test_no_flow_tasks_dont_spawn(
flow,
scheduler,
start,
):
"""Ensure no-flow tasks don't spawn downstreams.
No-flow tasks (i.e `--flow=none`) are not attached to any "flow".
See https://github.com/cylc/cylc-flow/issues/5613
"""
id_ = flow({
'scheduling': {
'graph': {
'R1': 'a => b => c'
}
},
})
schd: Scheduler = scheduler(id_)
async with start(schd):
task_a = schd.pool.get_tasks()[0]
# set as no-flow:
task_a.flow_nums = set()
# Set as completed: should not spawn children.
schd.pool.set_prereqs_and_outputs(
{task_a.tokens}, [], [], [FLOW_NONE]
)
assert not schd.pool.get_tasks()
for flow_nums, expected_pool in (
# outputs yielded from a no-flow task should not spawn downstreams
(set(), []),
# outputs yielded from a task with flow numbers should spawn
# downstreams in the same flow
({1}, [('1/b', {1})]),
):
# set the flow-nums on 1/a
task_a.flow_nums = flow_nums
# spawn on the succeeded output
schd.pool.spawn_on_output(task_a, TASK_OUTPUT_SUCCEEDED)
schd.pool.spawn_on_all_outputs(task_a)
# ensure the pool is as expected
assert [
(itask.identity, itask.flow_nums)
for itask in schd.pool.get_tasks()
] == expected_pool
async def test_task_proxy_remove_from_queues(
flow, one_conf, scheduler, start,
):
"""TaskPool.remove should delete task proxies from queues.
See https://github.com/cylc/cylc-flow/pull/5573
"""
# Set up a scheduler with a non-default queue:
one_conf['scheduling'] = {
'queues': {'queue_two': {'members': 'one, control'}},
'graph': {'R1': 'two & one & control'},
}
schd = scheduler(flow(one_conf))
async with start(schd):
# Get a list of itasks:
itasks = schd.pool.get_tasks()
for itask in itasks:
id_ = itask.identity
# The meat of the test - remove itask from pool if it
# doesn't have "control" in the name:
if 'control' not in id_:
schd.pool.remove(itask)
# Look at the queues afterwards:
queues_after = {
name: [itask.identity for itask in queue.deque]
for name, queue in schd.pool.task_queue_mgr.queues.items()}
assert queues_after['queue_two'] == ['1/control']
async def test_runahead_offset_start(
mod_example_flow_2: 'Scheduler'
) -> None:
"""Late-start recurrences should not break the runahead limit at start-up.
See GitHub #5708
"""
task_pool = mod_example_flow_2.pool
assert task_pool.runahead_limit_point == ISO8601Point('2004')
async def test_detect_incomplete_tasks(
flow,
scheduler,
start,
log_filter,
):
"""Finished but incomplete tasks should be retained as incomplete."""
incomplete_final_task_states = {
# final task states that would leave a task with
# completion=succeeded incomplete
TASK_STATUS_FAILED: TaskEventsManager.EVENT_FAILED,
TASK_STATUS_EXPIRED: TaskEventsManager.EVENT_EXPIRED,
TASK_STATUS_SUBMIT_FAILED: TaskEventsManager.EVENT_SUBMIT_FAILED
}
id_ = flow({
'scheduling': {
'graph': {
# a workflow with one task for each of the final task states
'R1': '\n'.join(incomplete_final_task_states.keys())
}
}
})
schd = scheduler(id_)
async with start(schd, level=logging.DEBUG):
itasks = schd.pool.get_tasks()
for itask in itasks:
itask.state_reset(is_queued=False)
# spawn the output corresponding to the task
schd.pool.task_events_mgr.process_message(
itask, 1,
incomplete_final_task_states[itask.tdef.name]
)
# ensure that it is correctly identified as incomplete
assert not itask.state.outputs.is_complete()
assert log_filter(
contains=(
f"[{itask}] did not complete the required outputs:"
),
)
# the task should not have been removed
assert itask in schd.pool.get_tasks()
async def test_trigger_icp_fcp_syntax(
flow,
scheduler,
start,
log_filter,
):
"""It should support the ^/$ syntax for referencing the initial/final cp.
See https://github.com/cylc/cylc-flow/issues/6537
"""
cfg = {
'scheduling': {
'cycling mode': 'integer',
'initial cycle point': 1,
'final cycle point': 2,
'graph': {
'R1/^': 'start',
'R1/$': 'end',
},
},
}
# trigger tasks at both the initial and final cycle points
id_ = flow(cfg)
schd = scheduler(id_)
async with start(schd) as log:
await commands.run_cmd(
commands.force_trigger_tasks(schd, ['^/start', '$/end'], ['1'])
)
assert log_filter(contains='[1/start:waiting(queued)] => waiting')
assert log_filter(contains='[2/end:waiting(queued)] => waiting')
log.clear()
# clear the final cycle point
del cfg['scheduling']['final cycle point']
del cfg['scheduling']['graph']['R1/$']
# try triggering a task at the (non existent) final cycle point
id_ = flow(cfg)
schd = scheduler(id_)
async with start(schd):
await commands.run_cmd(
commands.force_trigger_tasks(schd, ['^/start', '$/end'], ['1'])
)
assert log_filter(contains='[1/start:waiting(queued)] => waiting')
assert not log_filter(contains='[2/end:waiting(queued)] => waiting')
assert log_filter(
contains='ID references final cycle point, but none is set: $/end'
)
async def test_future_trigger_final_point(
flow,
scheduler,
start,
log_filter,
):
"""Check spawning of future-triggered tasks: foo[+P1] => bar.
Don't spawn if a prerequisite reaches beyond the final cycle point.
"""
id_ = flow(
{
'scheduling': {
'cycling mode': 'integer',
'initial cycle point': 1,
'final cycle point': 1,
'graph': {
'P1': "foo\n foo[+P1] & bar => baz"
}
}
}
)
schd = scheduler(id_)
async with start(schd):
for itask in schd.pool.get_tasks():
schd.pool.spawn_on_output(itask, "succeeded")
assert log_filter(
regex=(
".*1/baz.*not spawned: a prerequisite is beyond"
r" the workflow stop point \(1\)"
)
)
async def test_set_failed_complete(
flow,
scheduler,
start,
one_conf,
log_filter,
db_select: Callable
):
"""Test manual completion of an incomplete failed task."""
id_ = flow(one_conf)
schd: Scheduler = scheduler(id_)
async with start(schd, level=logging.DEBUG):
one = schd.pool.get_tasks()[0]
one.state_reset(is_queued=False)
schd.pool.task_events_mgr.process_message(one, 1, "failed")
assert log_filter(
regex="1/one.* setting implied output: submitted")
assert log_filter(
regex="1/one.* setting implied output: started")
assert log_filter(
regex="failed.* did not complete the required outputs")
# Set failed task complete via default "set" args.
schd.pool.set_prereqs_and_outputs({one.tokens}, [], [], [])
assert log_filter(
contains=f'[{one}] removed from the n=0 window: completed')
db_outputs = db_select(
schd, True, 'task_outputs', 'outputs',
**{'name': 'one'}
)
assert (
sorted(loads((db_outputs[0])[0])) == [
"failed", "started", "submitted", "succeeded"
]
)
async def test_set_prereqs(
flow,
scheduler,
start,
log_filter,
):
"""Check manual setting of prerequisites (task and xtrigger).
"""
id_ = flow(
{
'scheduling': {
'initial cycle point': '2040',
'xtriggers': {
'x': 'xrandom(0)'
},
'graph': {
'R1': """
foo & bar & baz => qux",
@x => bar
"""
}
},
'runtime': {
'foo': {
'outputs': {
'a': 'drugs and money',
}
}
}
}
)
schd: Scheduler = scheduler(id_)
async with start(schd):
# it should start up with foo, bar, baz
assert schd.pool.get_task_ids() == {
"20400101T0000Z/bar",
"20400101T0000Z/baz",
"20400101T0000Z/foo",
}
# try to set an invalid prereq of qux
schd.pool.set_prereqs_and_outputs(
{TaskTokens('20400101T0000Z', 'qux')},
[],
["20400101T0000Z/foo:a", "xtrigger/x"],
[],
)
assert log_filter(
contains=(
'20400101T0000Z/qux does not depend on "20400101T0000Z/foo:a"'
)
)
assert log_filter(
contains=(
'20400101T0000Z/qux does not depend on xtrigger "x"'
)
)
# it should not add 20400101T0000Z/qux to the pool
assert schd.pool.get_task_ids() == {
"20400101T0000Z/bar",
"20400101T0000Z/baz",
"20400101T0000Z/foo",
}
# set an xtrigger (see also test_xtrigger_mgr, and test_data_store_mgr)
bar = schd.pool._get_task_by_id('20400101T0000Z/bar')
assert bar.state.prerequisites_all_satisfied()
assert not bar.state.xtriggers_all_satisfied()
schd.pool.set_prereqs_and_outputs(
{TaskTokens('20400101T0000Z', 'bar')},
[],
["xtrigger/x:succeeded"],
[],
)
assert bar.state.xtriggers_all_satisfied()
assert log_filter(
contains=('prerequisite force-satisfied: x = xrandom(0)'))
# set xtrigger in the wrong task
schd.pool.set_prereqs_and_outputs(
{TaskTokens('20400101T0000Z', 'baz')},
[],
["xtrigger/x:succeeded"],
[],
)
assert log_filter(
contains='20400101T0000Z/baz does not depend on xtrigger "x"')
# set one prereq of inactive task 20400101T0000Z/qux
schd.pool.set_prereqs_and_outputs(
{TaskTokens('20400101T0000Z', 'qux')},
[],
["20400101T0000Z/foo:succeeded"],
[])
# it should add 20400101T0000Z/qux to the pool
assert schd.pool.get_task_ids() == {
"20400101T0000Z/bar",
"20400101T0000Z/baz",
"20400101T0000Z/foo",
"20400101T0000Z/qux",
}
# get the 20400101T0000Z/qux task proxy
qux = schd.pool.get_task(ISO8601Point("20400101T0000Z"), "qux")
assert not qux.state.prerequisites_all_satisfied()
# set its other prereqs (test implicit "succeeded" and "succeed")
# and truncated cycle point
schd.pool.set_prereqs_and_outputs(
{TaskTokens('20400101T0000Z', 'qux')},
[],
["2040/bar", "2040/baz:succeed"],
[],
)
assert log_filter(
contains=('prerequisite force-satisfied: 20400101T0000Z/bar'))
assert log_filter(
contains=('prerequisite force-satisfied: 20400101T0000Z/baz'))
# it should now be fully satisfied
assert qux.state.prerequisites_all_satisfied()
# set one again
schd.pool.set_prereqs_and_outputs(
{TaskTokens('20400101T0000Z', 'qux')}, [], ["2040/bar"], [])
assert log_filter(
contains=('prerequisite already satisfied: 20400101T0000Z/bar'))
async def test_set_bad_prereqs(
flow,
scheduler,
start,
log_filter,
):
"""Check manual setting of prerequisites.
"""
id_ = flow({
'scheduler': {
'cycle point format': '%Y'},
'scheduling': {
'initial cycle point': '2040',
'graph': {'R1': "foo => bar"}},
})
schd: Scheduler = scheduler(id_)
def set_prereqs(prereqs):
"""Shorthand so only variable under test given as arg"""
schd.pool.set_prereqs_and_outputs(
{TaskTokens('2040', 'bar')}, [], prereqs, [])
async with start(schd):
# Invalid: task name wildcard:
set_prereqs(["2040/*"])
assert log_filter(contains='Invalid prerequisite task name')
# Invalid: cycle point wildcard.
set_prereqs(["*/foo"])
assert log_filter(contains='Invalid prerequisite cycle point')
async def test_set_outputs_live(
flow,
scheduler,
start,
log_filter,
):
"""Check manual set outputs in an active (spawned) task.
"""
id_ = flow(
{
'scheduling': {
'graph': {
'R1': """
foo:x => bar
foo => baz
foo:y
"""
}
},
'runtime': {
'foo': {
'outputs': {
'x': 'xylophone',
'y': 'yacht'
}
}
}
}
)
schd: Scheduler = scheduler(id_)
async with start(schd):
# it should start up with just 1/foo
assert schd.pool.get_task_ids() == {"1/foo"}
# fake failed
foo = schd.pool.get_task(IntegerPoint("1"), "foo")
foo.state_reset(is_queued=False)
schd.pool.task_events_mgr.process_message(foo, 1, 'failed')
# set foo:x: it should spawn bar but not baz
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'foo')}, ["x"], [], []
)
assert schd.pool.get_task_ids() == {"1/bar", "1/foo"}
# Foo should have been removed from the queue:
assert '1/foo' not in [
i.identity for i
in schd.pool.task_queue_mgr.queues['default'].deque
]
# set foo:succeed: it should spawn baz but foo remains incomplete.
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'foo')}, ["succeeded"], [], []
)
assert schd.pool.get_task_ids() == {"1/bar", "1/baz", "1/foo"}
# it should complete implied outputs (submitted, started) too
assert log_filter(contains="setting implied output: submitted")
assert log_filter(contains="setting implied output: started")
# set foo (default: all required outputs) to complete y.
schd.pool.set_prereqs_and_outputs({TaskTokens('1', 'foo')}, [], [], [])
assert log_filter(contains="output 1/foo:succeeded completed")
assert schd.pool.get_task_ids() == {"1/bar", "1/baz"}
async def test_set_outputs_live2(
flow,
scheduler,
start,
log_filter,
):
"""Assert that optional outputs are satisfied before completion
outputs to prevent incomplete task warnings.
"""
id_ = flow(
{
'scheduling': {'graph': {
'R1': """
foo:a => apple
foo:b => boat
"""}},
'runtime': {'foo': {'outputs': {
'a': 'xylophone',
'b': 'yacht'}}}
}
)
schd: Scheduler = scheduler(id_)
async with start(schd):
schd.pool.set_prereqs_and_outputs({TaskTokens('1', 'foo')}, [], [], [])
assert not log_filter(
contains="did not complete required outputs: ['a', 'b']"
)
async def test_set_outputs_future(
flow,
scheduler,
start,
log_filter,
):
"""Check manual setting of inactive task outputs.
"""
id_ = flow(
{
'scheduling': {
'graph': {
'R1': "a:x & a:y => b => c"
}
},
'runtime': {
'a': {
'outputs': {
'x': 'xylophone',
'y': 'yacht'
}
}
}
}
)
schd: Scheduler = scheduler(id_)
async with start(schd):
# it should start up with just 1/a
assert schd.pool.get_task_ids() == {"1/a"}
# setting inactive task b succeeded should spawn c but not b
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'b')}, ["succeeded"], [], [])
assert schd.pool.get_task_ids() == {"1/a", "1/c"}
schd.pool.set_prereqs_and_outputs(
items={TaskTokens('1', 'a')},
outputs=["x", "y", "cheese"],
prereqs=[],
flow=[]
)
assert log_filter(contains="Output 1/a:cheese not found")
assert log_filter(contains="completed output x")
assert log_filter(contains="completed output y")
async def test_set_outputs_from_skip_settings(
flow,
scheduler,
start,
log_filter,
validate
):
"""Check working of ``cylc set --out=skip``:
1. --out=skip can be used to set all required outputs.
2. --out=skip,other_output can be used to set other outputs.
"""
id_ = flow(
{
'scheduling': {
'cycling mode': 'integer',
'initial cycle point': 1,
'final cycle point': 2,
'graph': {
'P1': """
a => after_asucceeded
a:x => after_ax
a:y? => after_ay
"""
}
},
'runtime': {
'a': {
'outputs': {
'x': 'xebec',
'y': 'yacht'
},
'skip': {'outputs': 'x'}
}
}
}
)
validate(id_)
schd: Scheduler = scheduler(id_)
async with start(schd):
# it should start up with just tasks a:
assert schd.pool.get_task_ids() == {'1/a', '2/a'}
# setting 1/a output to skip should set output x, but not
# y (because y is optional).
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'a')}, ['skip'], [], [])
assert schd.pool.get_task_ids() == {
'1/after_asucceeded',
'1/after_ax',
'2/a',
}
# Check that the presence of "skip" in outputs doesn't
# trigger a warning:
assert not log_filter(level=30)
# You should be able to set skip as part of a list of outputs:
schd.pool.set_prereqs_and_outputs(
{TaskTokens('2', 'a')}, ['skip', 'y'], [], [])
assert schd.pool.get_task_ids() == {
'1/after_asucceeded',
'1/after_ax',
'2/after_asucceeded',
'2/after_ax',
'2/after_ay',
}
async def test_prereq_satisfaction(
flow,
scheduler,
start,
log_filter,
):
"""Check manual setting of task prerequisites.
"""
id_ = flow(
{
'scheduling': {
'graph': {
'R1': "a:x & a:y => b"
}
},
'runtime': {
'a': {
'outputs': {
'x': 'xylophone',
'y': 'yacht'
}
}
}
}
)
schd: Scheduler = scheduler(id_)
async with start(schd):
# it should start up with just 1/a
assert schd.pool.get_task_ids() == {"1/a"}
# spawn b
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'a')}, ["x"], [], []
)
assert schd.pool.get_task_ids() == {"1/a", "1/b"}
b = schd.pool.get_task(IntegerPoint("1"), "b")
assert not b.prereqs_are_satisfied()
# set valid and invalid prerequisites, by label and message.
schd.pool.set_prereqs_and_outputs(
prereqs=["1/a:xylophone", "1/a:y", "1/a:w", "1/a:z"],
items={TaskTokens('1', 'b')},
outputs=[],
flow=[],
)
assert log_filter(contains="1/a:z not found")
assert log_filter(contains="1/a:w not found")
# FIXME: testing that something is *not* logged is extremely fragile:
assert not log_filter(regex='.*does not depend on.*')
assert b.prereqs_are_satisfied()
@pytest.mark.parametrize('compat_mode', ['compat-mode', 'normal-mode'])
@pytest.mark.parametrize('cycling_mode', ['integer', 'datetime'])
@pytest.mark.parametrize('runahead_format', ['P3Y', 'P3'])
async def test_compute_runahead(
cycling_mode,
compat_mode,
runahead_format,
flow,
scheduler,
start,
monkeypatch,
):
"""Test the calculation of the runahead limit.
This test ensures that:
* Runahead tasks are excluded from computations
see https://github.com/cylc/cylc-flow/issues/5825
* Tasks are initiated with the correct is_runahead status on startup.
* Behaviour in compat/regular modes is same unless failed tasks are present
* Behaviour is the same for integer/datetime cycling modes.
"""
if cycling_mode == 'integer':
config = {
'scheduler': {
'allow implicit tasks': 'True',
},
'scheduling': {
'initial cycle point': '1',
'cycling mode': 'integer',
'runahead limit': 'P3',
'graph': {
'P1': 'a'
},
}
}
point = lambda point: IntegerPoint(str(int(point)))
else:
config = {
'scheduler': {
'allow implicit tasks': 'True',
'cycle point format': 'CCYY',
},
'scheduling': {
'initial cycle point': '0001',
'runahead limit': runahead_format,
'graph': {
'P1Y': 'a'
},
}
}
point = ISO8601Point
monkeypatch.setattr(
'cylc.flow.flags.cylc7_back_compat',
compat_mode == 'compat-mode',
)
id_ = flow(config)
schd = scheduler(id_)
async with start(schd):
schd.pool.compute_runahead(force=True)
assert int(str(schd.pool.runahead_limit_point)) == 4
# ensure task states are initiated with is_runahead status
assert schd.pool.get_task(point('0001'), 'a').state(is_runahead=False)
assert schd.pool.get_task(point('0005'), 'a').state(is_runahead=True)
# mark the first three cycles as running
for cycle in range(1, 4):
schd.pool.get_task(point(f'{cycle:04}'), 'a').state.reset(
TASK_STATUS_RUNNING
)
schd.pool.compute_runahead(force=True)
assert int(str(schd.pool.runahead_limit_point)) == 4 # no change
# In Cylc 8 all incomplete tasks hold back runahead.
# In Cylc 7, submit-failed tasks hold back runahead..
schd.pool.get_task(point('0001'), 'a').state.reset(
TASK_STATUS_SUBMIT_FAILED
)
schd.pool.compute_runahead(force=True)
assert int(str(schd.pool.runahead_limit_point)) == 4
# ... but failed ones don't. Go figure.
schd.pool.get_task(point('0001'), 'a').state.reset(
TASK_STATUS_FAILED
)
schd.pool.compute_runahead(force=True)
if compat_mode == 'compat-mode':
assert int(str(schd.pool.runahead_limit_point)) == 5
else:
assert int(str(schd.pool.runahead_limit_point)) == 4 # no change
# mark cycle 1 as complete
# (via task message so the task gets removed before runahead compute)
schd.task_events_mgr.process_message(
schd.pool.get_task(point('0001'), 'a'),
logging.INFO,
TASK_OUTPUT_SUCCEEDED
)
schd.pool.compute_runahead(force=True)
assert int(str(schd.pool.runahead_limit_point)) == 5 # +1
async def test_compute_runahead_with_no_tasks(flow, scheduler, run):
"""It should handle the case of an empty workflow.
See https://github.com/cylc/cylc-flow/issues/6225
"""
id_ = flow(
{
'scheduling': {
'initial cycle point': '2000',
'graph': {'R1': 'foo'},
},
}
)
schd = scheduler(id_, startcp='2002', paused_start=False)
async with run(schd):
assert schd.pool.compute_runahead() is False
assert schd.pool.runahead_limit_point is None
assert schd.pool.get_tasks() == []
async def test_compute_runahead_with_no_sequences(
flow, scheduler, start, run, complete
):
"""It should handle no sequences within the start-stop cycle range.
See https://github.com/cylc/cylc-flow/issues/6154
"""
cfg = {
'scheduling': {
'cycling mode': 'integer',
'initial cycle point': '1',
'graph': {
'P1': 'foo[-P1] => foo',
},
},
}
id_ = flow(cfg)
schd = scheduler(id_, paused_start=False)
async with run(schd):
await complete(schd, '2/foo')
cfg['scheduling']['graph']['R1'] = cfg['scheduling']['graph']['P1']
cfg['scheduling']['graph'].pop('P1')
flow(cfg, workflow_id=id_)
schd = scheduler(id_, paused_start=False)
async with start(schd):
schd.pool.compute_runahead()
assert schd.pool.runahead_limit_point == IntegerPoint('3')
@pytest.mark.parametrize('rhlimit', ['P2D', 'P2'])
@pytest.mark.parametrize('compat_mode', ['compat-mode', 'normal-mode'])
async def test_runahead_future_trigger(
flow,
scheduler,
start,
monkeypatch,
rhlimit,
compat_mode,
):
"""Equivalent time interval and cycle count runahead limits should yield
the same limit point, even if there is a future trigger.
See https://github.com/cylc/cylc-flow/pull/5893
"""
id_ = flow({
'scheduler': {
'allow implicit tasks': 'True',
'cycle point format': 'CCYYMMDD',
},
'scheduling': {
'initial cycle point': '2001',
'runahead limit': rhlimit,
'graph': {
'P1D': '''
a
a[+P1D] => b
''',
},
}
})
monkeypatch.setattr(
'cylc.flow.flags.cylc7_back_compat',
compat_mode == 'compat-mode',
)
schd = scheduler(id_,)
async with start(schd, level=logging.DEBUG):
assert str(schd.pool.runahead_limit_point) == '20010103'
schd.pool.release_runahead_tasks()
for itask in schd.pool.get_tasks():
schd.pool.spawn_on_output(itask, 'succeeded')
# future trigger raises the limit by one cycle point
assert str(schd.pool.runahead_limit_point) == '20010104'
@pytest.fixture(scope='module')
async def mod_blah(
mod_flow: Callable, mod_scheduler: Callable, mod_run: Callable
) -> 'Scheduler':
"""Return a scheduler for interrogating its task pool.
This is module-scoped so faster than example_flow, but should only be used
where the test does not mutate the state of the scheduler or task pool.
"""
config = {
'scheduler': {
'allow implicit tasks': 'True',
'cycle point format': '%Y',
},
'scheduling': {
'initial cycle point': '0001',
'runahead limit': 'P1Y',
'graph': {
'P1Y': 'a'
},
}
}
id_ = mod_flow(config)
schd: 'Scheduler' = mod_scheduler(id_, paused_start=True)
async with mod_run(schd):
yield schd
@pytest.mark.parametrize(
'status, expected',
[
# (Status, Are we expecting an update?)
(TASK_STATUS_WAITING, False),
(TASK_STATUS_EXPIRED, False),
(TASK_STATUS_PREPARING, False),
(TASK_STATUS_SUBMIT_FAILED, False),
(TASK_STATUS_SUBMITTED, False),
(TASK_STATUS_RUNNING, False),
(TASK_STATUS_FAILED, True),
(TASK_STATUS_SUCCEEDED, True)
]
)
async def test_runahead_c7_compat_task_state(
status,
expected,
mod_blah,
monkeypatch,
):
"""For each task status check whether changing the oldest task
to that status will cause compute_runahead to make a change.
Compat mode: Cylc 7 ignored failed tasks but not submit-failed!
"""
def max_cycle(tasks):
return max([int(t.tokens.get("cycle")) for t in tasks])
monkeypatch.setattr(
'cylc.flow.flags.cylc7_back_compat', True)
monkeypatch.setattr(
'cylc.flow.task_events_mgr.TaskEventsManager._insert_task_job',
lambda *_: True)
mod_blah.pool.compute_runahead()
before_pt = max_cycle(mod_blah.pool.get_tasks())
before = mod_blah.pool.runahead_limit_point
itask = mod_blah.pool.get_task(ISO8601Point(f'{before_pt - 2:04}'), 'a')
itask.state_reset(status, is_queued=False)
mod_blah.pool.compute_runahead()
after = mod_blah.pool.runahead_limit_point
assert bool(before != after) == expected
async def test_fast_respawn(
example_flow: 'Scheduler',
caplog: pytest.LogCaptureFixture,
) -> None:
"""Immediate re-spawn of removed tasks is not allowed.
An immediate DB update is required to stop the respawn.
https://github.com/cylc/cylc-flow/pull/6067
"""
task_pool = example_flow.pool
# find task 1/foo in the pool
foo = task_pool.get_task(IntegerPoint("1"), "foo")
# remove it from the pool
task_pool.remove(foo)
assert foo not in task_pool.get_tasks()
# attempt to spawn it again
itask = task_pool.spawn_task("foo", IntegerPoint("1"), {1})
assert itask is None
assert "Not respawning 1/foo - task was removed" in caplog.text
async def test_remove_active_task(
example_flow: 'Scheduler',
log_filter: Callable,
) -> None:
"""Test warning on removing an active task."""
task_pool = example_flow.pool
# find task 1/foo in the pool
foo = task_pool.get_task(IntegerPoint("1"), "foo")
foo.state_reset(TASK_STATUS_RUNNING)
task_pool.remove(foo, "request")
assert foo not in task_pool.get_tasks()
assert log_filter(
regex=(
"1/foo.*removed from the n=0 window:"
" request - active job orphaned"
),
level=logging.WARNING
)
async def test_remove_by_expire_trigger(
flow,
validate,
scheduler,
start,
log_filter
):
"""Test task removal by suicide trigger.
* Suicide triggers should remove tasks from the pool.
* It should be possible to bring them back by manually triggering them.
* Removing a task manually (cylc remove) should work the same.
"""
def _get_id(b_completion: str = "succeeded"):
return flow({
'scheduler': {
'experimental': {
'expire triggers': 'True',
}
},
'scheduling': {
'graph': {
'R1': '''
a? => b
a:failed? => !b
'''
},
},
'runtime': {
'b': {
'completion': b_completion
}
}
})
with pytest.raises(
WorkflowConfigError,
match=re.escape(
"This may be due to use of an expire (formerly suicide) trigger"
)
):
validate(_get_id())
id_ = _get_id("succeeded or expired")
validate(id_)
schd: 'Scheduler' = scheduler(id_, paused_start=False)
async with start(schd, level=logging.DEBUG) as log:
# it should start up with 1/a
assert schd.pool.get_task_ids() == {"1/a"}
a = schd.pool.get_task(IntegerPoint("1"), "a")
# mark 1/a as failed and check that 1/b expires
schd.pool.spawn_on_output(a, TASK_OUTPUT_FAILED)
assert log_filter(regex="1/b.*=> expired")
assert schd.pool.get_task_ids() == {"1/a"}
# 1/b should not be resurrected if it becomes ready
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'b')}, [], ["1/a"], ["1"],
)
assert log_filter(regex="1/b:expired.* already finished and completed")
# but we can still resurrect 1/b by triggering it
log.clear()
await commands.run_cmd(
commands.force_trigger_tasks(schd, ['1/b'], ['1']))
assert log_filter(regex='1/b.*added to the n=0 window')
# remove 1/b with "cylc remove""
await commands.run_cmd(
commands.remove_tasks(schd, ['1/b'], [])
)
assert log_filter(
regex='1/b.*removed from the n=0 window: request',
)
# and bring 1/b back again by triggering it again
log.clear()
await commands.run_cmd(
commands.force_trigger_tasks(schd, ['1/b'], ['1']))
assert log_filter(regex='1/b.*added to the n=0 window',)
async def test_remove_by_suicide(
flow,
scheduler,
start,
log_filter
):
"""Test task removal by suicide trigger.
* Suicide triggers should remove tasks from the pool.
* It should be possible to bring them back by manually triggering them.
* Removing a task manually (cylc remove) should work the same.
"""
id_ = flow({
'scheduling': {
'graph': {
'R1': '''
a? & b
a:failed? => !b
'''
},
}
})
schd: 'Scheduler' = scheduler(id_)
async with start(schd, level=logging.DEBUG) as log:
# it should start up with 1/a and 1/b
assert schd.pool.get_task_ids() == {"1/a", "1/b"}
a = schd.pool.get_task(IntegerPoint("1"), "a")
# mark 1/a as failed and ensure 1/b is removed by suicide trigger
schd.pool.spawn_on_output(a, TASK_OUTPUT_FAILED)
assert log_filter(
regex="1/b.*removed from the n=0 window: suicide trigger"
)
assert schd.pool.get_task_ids() == {"1/a"}
# ensure that we are able to bring 1/b back by triggering it
log.clear()
await commands.run_cmd(
commands.force_trigger_tasks(schd, ['1/b'], ['1']))
assert log_filter(
regex='1/b.*added to the n=0 window',
)
# remove 1/b by request (cylc remove)
await commands.run_cmd(
commands.remove_tasks(schd, ['1/b'], [])
)
assert log_filter(
regex='1/b.*removed from the n=0 window: request',
)
# ensure that we are able to bring 1/b back by triggering it
log.clear()
await commands.run_cmd(
commands.force_trigger_tasks(schd, ['1/b'], ['1']))
assert log_filter(regex='1/b.*added to the n=0 window',)
async def test_set_future_flow(flow, scheduler, start, log_filter):
"""Manually-set outputs for new flow num must be recorded in the DB.
See https://github.com/cylc/cylc-flow/pull/6186
To trigger the bug, the flow must be new but the task must have been
spawned before in an earlier flow.
"""
# Scenario: after flow 1, set c1:succeeded in a future flow so
# when b succeeds in the new flow it will spawn c2 but not c1.
id_ = flow({
'scheduler': {
'allow implicit tasks': True
},
'scheduling': {
'cycling mode': 'integer',
'graph': {
'R1': 'b => c1 & c2',
},
},
})
schd: 'Scheduler' = scheduler(id_)
async with start(schd, level=logging.DEBUG):
assert schd.pool.get_task(IntegerPoint("1"), "b") is not None, (
'1/b should be spawned on startup'
)
# set b, c1, c2 succeeded in flow 1
schd.pool.set_prereqs_and_outputs(
{
TaskTokens('1', 'b'),
TaskTokens('1', 'c1'),
TaskTokens('1', 'c2'),
},
prereqs=[],
outputs=[],
flow=['1'],
)
schd.workflow_db_mgr.process_queued_ops()
# set task c1:succeeded in flow 2
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'c1')}, prereqs=[], outputs=[], flow=['2']
)
schd.workflow_db_mgr.process_queued_ops()
# set b:succeeded in flow 2 and check downstream spawning
schd.pool.set_prereqs_and_outputs(
{TaskTokens('1', 'b')}, prereqs=[], outputs=[], flow=['2']
)
assert schd.pool.get_task(IntegerPoint("1"), "c1") is None, (
'1/c1 (flow 2) should not be spawned after 1/b:succeeded'
)
assert schd.pool.get_task(IntegerPoint("1"), "c2") is not None, (
'1/c2 (flow 2) should be spawned after 1/b:succeeded'
)
async def test_trigger_queue(one, run, db_select, complete):
"""It should handle triggering tasks in the queued state.
Triggering a queued task with a new flow number should result in the
task running with merged flow numbers.
See https://github.com/cylc/cylc-flow/pull/6241
"""
async with run(one):
# the workflow should start up with one task in the original flow
task = one.pool.get_tasks()[0]
assert task.state(TASK_STATUS_WAITING, is_queued=True)
assert task.flow_nums == {1}
# trigger this task even though is already queued in flow 1
await commands.run_cmd(
commands.force_trigger_tasks(one, [task.identity], ['2']))
# the merged flow should continue
one.resume_workflow()
await complete(one, timeout=2)
assert db_select(one, False, 'task_outputs', 'flow_nums') == [
('[1, 2]',),
('[1]',),
]
async def test_reload_xtriggers(flow, scheduler, start):
"""It should rebuild xtriggers when the workflow is reloaded.
See https://github.com/cylc/cylc-flow/pull/6263
"""
config = {
'scheduling': {
'initial cycle point': '2000',
'graph': {
'R1': '''
@a => foo
@b => foo
'''
},
'xtriggers': {
'a': 'wall_clock(offset="P0D")',
'b': 'wall_clock(offset="P5D")',
},
}
}
id_ = flow(config)
schd: Scheduler = scheduler(id_)
def list_xtrig_mgr():
"""List xtrigs from the xtrigger_mgr."""
return {
key: repr(value)
for key, value in schd.xtrigger_mgr.xtriggers.functx_map.items()
}
async def list_data_store():
"""List xtrigs from the data_store_mgr."""
await schd.update_data_structure()
return {
value.label: value.id
for key, value in schd.data_store_mgr.data[schd.tokens.id][
TASK_PROXIES
][
schd.tokens.duplicate(cycle='20000101T0000Z', task='foo').id
].xtriggers.items()
}
async with start(schd):
# check xtrigs on startup
assert list_xtrig_mgr() == {
'a': '<SubFuncContext wall_clock(offset=P0D):10.0>',
'b': '<SubFuncContext wall_clock(offset=P5D):10.0>',
}
assert await list_data_store() == {
'a': 'wall_clock(trigger_time=946684800)',
'b': 'wall_clock(trigger_time=947116800)',
}
# remove @a
config['scheduling']['xtriggers'].pop('a')
# modify @b
config['scheduling']['xtriggers']['b'] = 'wall_clock(offset="PT12H")'
# add @c
config['scheduling']['xtriggers']['c'] = 'wall_clock(offset="PT1H")'
config['scheduling']['graph']['R1'] = config['scheduling']['graph'][
'R1'
].replace('@a', '@c')
# reload
flow(config, workflow_id=id_)
await commands.run_cmd(commands.reload_workflow(schd))
# check xtrigs post-reload
assert list_xtrig_mgr() == {
'b': '<SubFuncContext wall_clock(offset=PT12H):10.0>',
'c': '<SubFuncContext wall_clock(offset=PT1H):10.0>',
}
assert await list_data_store() == {
'b': 'wall_clock(trigger_time=946728000)',
'c': 'wall_clock(trigger_time=946688400)',
}
@pytest.mark.parametrize('expire_type', ['clock-expire', 'manual'])
async def test_expire_dequeue_with_retries(
flow, scheduler, start, expire_type
):
"""An expired waiting task should be removed from any queues.
See https://github.com/cylc/cylc-flow/issues/6284
"""
conf = {
'scheduling': {
'initial cycle point': '2000',
'graph': {
'R1': 'foo'
},
},
'runtime': {
'foo': {
'execution retry delays': 'PT0S'
}
}
}
if expire_type == 'clock-expire':
conf['scheduling']['special tasks'] = {'clock-expire': 'foo(PT0S)'}
method = lambda schd: schd.pool.clock_expire_tasks()
else:
method = lambda schd: schd.pool.set_prereqs_and_outputs(
{TaskTokens('20000101T0000Z', 'foo')},
prereqs=[],
outputs=['expired'],
flow=['1'],
)
id_ = flow(conf)
schd = scheduler(id_)
schd: Scheduler
async with start(schd):
itask = schd.pool.get_tasks()[0]
# the task should start as "waiting(queued)"
assert itask.state(TASK_STATUS_WAITING, is_queued=True)
# expire the task via whichever method we are testing
method(schd)
# the task should enter the "expired" state
assert itask.state(TASK_STATUS_EXPIRED, is_queued=False)
# the task should also have been removed from the queue
assert not schd.pool.task_queue_mgr.remove_task(itask)
async def test_downstream_complete_before_upstream(
flow, scheduler, start, db_select
):
"""It should handle an upstream task completing before a downstream task.
See https://github.com/cylc/cylc-flow/issues/6315
"""
id_ = flow(
{
'scheduling': {
'graph': {
'R1': 'a => b',
},
},
}
)
schd = scheduler(id_)
async with start(schd):
# 1/a should be pre-spawned (parentless)
a_1 = schd.pool.get_task(IntegerPoint('1'), 'a')
assert a_1
# spawn 1/b (this can happens as the result of request e.g. trigger)
b_1 = schd.pool.spawn_task('b', IntegerPoint('1'), {1})
schd.pool.add_to_pool(b_1)
assert b_1
# mark 1/b as succeeded
schd.task_events_mgr.process_message(b_1, 'INFO', 'succeeded')
# 1/b should be removed from the pool (completed)
assert schd.pool.get_tasks() == [a_1]
# as a side effect the DB should have been updated
assert (
TASK_OUTPUT_SUCCEEDED
in db_select(
schd,
# "False" means "do not run the DB update before checking it"
False, # do not change this to "True"
'task_outputs',
'outputs',
name='b',
cycle='1',
)[0][0]
)
# mark 1/a as succeeded
schd.task_events_mgr.process_message(a_1, 'INFO', 'succeeded')
# 1/a should be removed from the pool (completed)
# 1/b should not be re-spawned by the success of 1/a
assert schd.pool.get_tasks() == []
async def test_job_insert_on_crash(one_conf, flow, scheduler, start):
"""Ensure that a job can be inserted if its config is not known.
It is possible, though very difficult, to create the circumstances where
the configuration for the latest job is not held in `itask.jobs`.
This should not happen under normal circumstances, but should be handled
elegantly if it does occur.
See https://github.com/cylc/cylc-flow/issues/6314
"""
id_ = flow(one_conf)
schd: Scheduler = scheduler(id_, run_mode='live')
async with start(schd):
task_1 = schd.pool.get_tasks()[0]
# make it look like the task submitted but without storing the job
# config in TaskProxy.jobs
task_1.submit_num += 1
task_1.state.reset('preparing')
schd.task_events_mgr.process_message(
task_1,
'INFO',
'submitted',
)
# the task state should be updated correctly
assert task_1.state.status == 'submitted'
# and a job entry should be added
assert len(task_1.jobs) == 1
async def test_start_tasks(
flow,
scheduler,
start,
capture_submission,
):
"""Check starting from "start-tasks" with and without clock-triggers.
"""
id_ = flow(
{
'scheduler': {
'cycle point format': '%Y',
},
'scheduling': {
'initial cycle point': '2040',
'runahead limit': 'P0Y',
'xtriggers': {
'wall_clock_satisfied': "wall_clock(offset='-P100Y')"
},
'graph': {
'P1Y': """
foo
@wall_clock => bar
@wall_clock_satisfied => baz
qux
"""
}
}
}
)
schd = scheduler(
id_,
starttask=['2050/foo', '2050/bar', '2050/baz'],
paused_start=False
)
async with start(schd):
# capture any job submissions
submitted_tasks = capture_submission(schd)
assert submitted_tasks == set()
# It should start up with:
# - 2050/foo and 2051/foo (spawned to runahead limit)
# - 2050/bar waiting on its (unsatisfied) clock-trigger
# - 2050/baz waiting on its (satisfied) clock-trigger
# - no qux instances (not listed as a start-task)
itasks = schd.pool.get_tasks()
assert (
set(itask.identity for itask in itasks) == {
"2050/foo",
"2051/foo",
"2050/bar",
"2050/baz",
}
)
# Check xtriggers
for itask in itasks:
schd.pool.xtrigger_mgr.call_xtriggers_async(itask)
schd.pool.rh_release_and_queue(itask)
# Release tasks that are ready to run.
schd.release_tasks_to_run()
# It should submit 2050/foo, 2051/foo, 2050/baz
# It should not submit 2050/bar (waiting on clock trigger)
assert (
set(itask.identity for itask in submitted_tasks) == {
"2050/foo",
"2051/foo",
"2050/baz",
}
)
async def test_add_new_flow_rows_on_spawn(
flow,
scheduler,
run,
complete,
db_select,
capcall,
) -> None:
"""Task suicide should not override previously completed outputs.
See https://github.com/cylc/cylc-flow/pull/6821
"""
# capture all TaskPool.spawn_task() calls
spawn_task_calls = capcall(
'cylc.flow.task_pool.TaskPool.spawn_task', TaskPool.spawn_task
)
def list_spawn_task_calls():
"""Return a list of the names of tasks which have been run through the
"spawn_tasks" function so far."""
return [
args[1] for args, _kwargs in spawn_task_calls
]
id_ = flow({
'scheduling': {
'graph': {
'R1': '''
slow:fail? => foo
slow? => !foo
foo:x => x
''',
},
},
'runtime': {
'foo': {
'outputs': {'x': 'xxx'}
},
},
})
schd = scheduler(id_, paused_start=False)
async with run(schd):
# 1/slow should spawn on startup
assert list_spawn_task_calls() == ['slow']
# set foo:x
await commands.run_cmd(
commands.set_prereqs_and_outputs(
schd, ['1/foo'], ['1'], ['x'], None
)
)
# 1/foo:x should be recorded in the DB:
assert db_select(
schd, True, 'task_outputs', 'outputs', cycle='1', name='foo'
) == [('{"x": "(manually completed)"}',)]
# and 1/x should spawn:
assert list_spawn_task_calls() == ['slow', 'x']
# run the workflow until completion
await complete(schd, timeout=5)
# 1/foo should spawn as a result of the suicide trigger
assert list_spawn_task_calls() == ['slow', 'x', 'foo']
# the manually completed output should not have been overwritten by the
# suicide trigger
assert db_select(
schd, True, 'task_outputs', 'outputs', cycle='1', name='foo'
) == [('{"x": "(manually completed)"}',)]
|