1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508
|
/**
* Tests covering the XML Document handling classes in namespace xmlutil
*/
#include "RadiantTest.h"
#include "algorithm/FileUtils.h"
#include "string/split.h"
#include "string/trim.h"
#include "testutil/TemporaryFile.h"
#include "xmlutil/Node.h"
#include "xmlutil/Document.h"
namespace test
{
// Obtain the test resources path from either TEST_BASE_PATH or the application context,
// depending on platform.
//
// This is done because parsing XML correctly is a pre-requisite for initialising the core
// modules and allowing RadiantTest to work, so having the basic XML tests dependent on
// RadiantTest is a Catch-22 situation. It also provides a significant performance
// improvement to not have to initialise the core module for each test.
//
// However, TEST_BASE_PATH is not currently defined on Windows as far as I can see, so we
// have to check for TEST_BASE_PATH and fall back to the original RadiantTest usage if it is
// not defined.
class XmlTest:
#if defined(TEST_BASE_PATH)
public ::testing::Test
#else
public RadiantTest
#endif
{
protected:
std::string getXmlTestResourcePath() const
{
#if defined(TEST_BASE_PATH)
return std::string(TEST_BASE_PATH) + "/resources/xml/";
#else
return _context.getTestResourcePath() + "xml/";
#endif
}
};
// Relative to the resource folder
constexpr const char* const TEST_XML_FILE = "testfile.xml";
TEST_F(XmlTest, CreateEmptyDocument)
{
// Create an xmlutil::Document from scratch
auto document = xml::Document::create();
EXPECT_TRUE(document.isValid()) << "New document must be valid";
EXPECT_EQ(document.getTopLevelNode().getName(), "") << "New document doesn't have a top level node";
EXPECT_EQ(
string::trim_copy(document.saveToString()),
"<?xml version=\"1.0\" encoding=\"utf-8\"?>"
);
}
TEST_F(XmlTest, CreateDocumentFromFile)
{
// Create an xmlutil::Document from an existing XML file
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
EXPECT_TRUE(document.isValid()) << "Test file could not be loaded";
EXPECT_EQ(document.getTopLevelNode().getName(), "testDocument");
}
TEST_F(XmlTest, CreateDocumentFromStream)
{
// Create an xmlutil::Document from an input stream
std::ifstream stream(getXmlTestResourcePath() + TEST_XML_FILE);
xml::Document document(stream);
EXPECT_TRUE(document.isValid()) << "Test stream could not be parsed";
EXPECT_EQ(document.getTopLevelNode().getName(), "testDocument");
}
TEST_F(XmlTest, DocumentAlwaysHasDeclNode)
{
static const char* HEADER = "<?xml version=\"1.0\" encoding=\"utf-8\"?>";
xml::Document emptyDoc;
std::string emptyDocStr = emptyDoc.saveToString();
EXPECT_EQ(emptyDocStr, HEADER);
xml::Document newDoc(emptyDoc);
EXPECT_EQ(newDoc.saveToString(), HEADER);
newDoc.addTopLevelNode("top");
EXPECT_TRUE(string::starts_with(newDoc.saveToString(), HEADER));
}
TEST_F(XmlTest, AddTopLevelNodeToDocument)
{
// Create an empty document and add a top level node to it
auto document = xml::Document::create();
EXPECT_EQ(document.getTopLevelNode().getName(), "");
document.addTopLevelNode("someNodeName");
EXPECT_EQ(document.getTopLevelNode().getName(), "someNodeName");
// Calling addTopLevelNode removes the previous top level node
document.addTopLevelNode("replacementNodeName");
EXPECT_EQ(document.getTopLevelNode().getName(), "replacementNodeName");
}
TEST_F(XmlTest, ImportDocument)
{
// Create an empty document, add an <importNode /> tag without children
auto importDocument = xml::Document::create();
importDocument.addTopLevelNode("importNode");
// Load an existing file
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
// Import the <importNode /> into this document
auto targetNode = document.findXPath("//colourscheme[@name='Black & Green']").at(0);
auto previousChildCount = document.findXPath("//colourscheme[@name='Black & Green']/*").size();
document.importDocument(importDocument, targetNode);
auto newChildCount = document.findXPath("//colourscheme[@name='Black & Green']/*").size();
EXPECT_EQ(newChildCount, previousChildCount + 1);
// Importing a node to a target node without existing children should work too
targetNode = document.findXPath("//colourscheme[@name='Black & Green']/colour[@name='active_view_name']").at(0);
// The target node shouldn't have any children yet
EXPECT_EQ(document.findXPath("//colourscheme[@name='Black & Green']/colour[@name='active_view_name']/*").size(), 0);
auto importDocument2 = xml::Document::create();
importDocument2.addTopLevelNode("anotherNode");
document.importDocument(importDocument2, targetNode);
// We should have one child node now
EXPECT_EQ(document.findXPath("//colourscheme[@name='Black & Green']/colour[@name='active_view_name']/*").size(), 1);
}
TEST_F(XmlTest, CopyNodesIntoDocument)
{
// Copy existing nodes into this document
auto targetDocument = xml::Document::create();
targetDocument.addTopLevelNode("importNode");
// Load an existing file
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
// Copy all colourScheme nodes
auto importNodes = document.findXPath("//colourscheme");
EXPECT_EQ(importNodes.size(), 2) << "Expect 2 colour schemes to be present";
EXPECT_EQ(targetDocument.findXPath("//colourscheme").size(), 0) << "Target document shouldn't have any colourscheme nodes yet";
targetDocument.copyNodes(importNodes);
// The 2 colour schemes should have been added below the top level node
EXPECT_EQ(targetDocument.findXPath("/importNode/colourscheme").size(), 2) << "Target document should have 2 colourscheme nodes now";
}
TEST_F(XmlTest, DocumentValidityCheck)
{
// Test the isValid() method
// Loading an invalid file will produce an invalid document
auto filename = getXmlTestResourcePath() + "xml/broken_file.xml";
xml::Document broken(filename);
EXPECT_FALSE(broken.isValid());
// Same goes for the stream constructor
std::ifstream stream(filename);
xml::Document brokenFromStream(stream);
EXPECT_FALSE(brokenFromStream.isValid());
}
TEST_F(XmlTest, FindXPathInDocument)
{
// Test the findXPath() method
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
// Find the root element
EXPECT_EQ(document.findXPath("/testDocument").size(), 1);
// Find the root node everywhere
EXPECT_EQ(document.findXPath("//testDocument").size(), 1);
// Find the 2 colourScheme nodes
EXPECT_EQ(document.findXPath("/testDocument/colourscheme").size(), 2);
// Find the 2 colourScheme nodes with the double-slash search
EXPECT_EQ(document.findXPath("//colourscheme").size(), 2);
// Find the 2 colourScheme nodes using a wildcard expression
EXPECT_EQ(document.findXPath("/testDocument/*").size(), 2);
// XPath expressions are case sensitive
EXPECT_EQ(document.findXPath("/testDocument/colourSCHEME").size(), 0); // find nothing
// Find all colour nodes using various methods
EXPECT_EQ(document.findXPath("/testDocument/colourscheme/colour").size(), 62);
EXPECT_EQ(document.findXPath("/testDocument/colourscheme/*").size(), 64);
EXPECT_EQ(document.findXPath("/testDocument//colour").size(), 62);
EXPECT_EQ(document.findXPath("//colour").size(), 62);
// Find specific colour scheme(s)
EXPECT_EQ(document.findXPath("//colourscheme[@name='Black & Green']").size(), 1);
EXPECT_EQ(document.findXPath("//colourscheme[@version='1.0']").size(), 2);
EXPECT_EQ(document.findXPath("/testDocument/colourscheme[@name='Black & Green']").size(), 1);
EXPECT_EQ(document.findXPath("/testDocument/*[@name='Black & Green']").size(), 1);
// Ampersand doesn't need to be escaped, otherwise there's no result
EXPECT_EQ(document.findXPath("//colourscheme[@name='Black & Green']").size(), 0);
}
namespace
{
// pugixml does not guarantee to preserve formatting in the output, so we instead break
// the XML into non-whitespace fragments and compare these one by one.
void compareXMLFragments(const std::string& actual, const std::string& expected)
{
auto actFrags = string::splitToVec(actual, " \n\r\t<>");
auto expFrags = string::splitToVec(expected, " \n\r\t<>");
EXPECT_EQ(actFrags.size(), expFrags.size());
EXPECT_EQ(actFrags, expFrags);
}
}
TEST_F(XmlTest, SaveDocumentToFile)
{
// Test the saveToFile() method
auto filename = getXmlTestResourcePath() + TEST_XML_FILE;
auto targetFilePath = getXmlTestResourcePath() + TEST_XML_FILE + ".tmp";
TemporaryFile targetFile(targetFilePath);
xml::Document document(filename);
const auto fileContents = algorithm::loadFileToString(filename);
// saveToFile() should produce the same file again, except for formatting
document.saveToFile(targetFilePath);
auto newFileContents = algorithm::loadFileToString(targetFilePath);
compareXMLFragments(newFileContents, fileContents);
}
TEST_F(XmlTest, SaveDocumentToString)
{
// Test the saveToString() method
auto filename = getXmlTestResourcePath() + TEST_XML_FILE;
const auto fileContents = algorithm::loadFileToString(filename);
// saveToString() should produce the same file again, except for formatting
xml::Document document(filename);
compareXMLFragments(document.saveToString(), fileContents);
}
TEST_F(XmlTest, CreateEmptyNode)
{
xml::Node node;
EXPECT_FALSE(node.isValid()) << "Empty node should not be valid";
}
TEST_F(XmlTest, NodeName)
{
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
// Get the root node and check its name
auto rootNode = document.findXPath("/testDocument").at(0);
EXPECT_TRUE(rootNode.isValid()) << "Root node should be valid";
EXPECT_EQ(rootNode.getName(), "testDocument") << "Root node has the wrong name";
}
TEST_F(XmlTest, CopyConstructNode)
{
// xml::Document document(getResourcePath() + TEST_XML_FILE);
// // Get the root node and check its name
// auto rootNode = document.findXPath("/testDocument").at(0);
// EXPECT_TRUE(rootNode.isValid()) << "Root node should be valid";
// EXPECT_EQ(rootNode.getName(), "testDocument") << "Root node has the wrong name";
// xml::Node copy(rootNode);
// EXPECT_TRUE(copy.isValid()) << "Root node should be valid";
// EXPECT_EQ(copy.getName(), "testDocument") << "Copied node has the wrong name";
// // Copying an empty node should be possible
// xml::Node nullNode();
// xml::Node copiedNullNode(nullNode);
// EXPECT_FALSE(nullNode.isValid()) << "Empty node should not be valid";
// EXPECT_FALSE(copiedNullNode.isValid()) << "Empty copied node should not be valid";
// // operator=
// xml::Node assignedNullNode(rootNode);
// assignedNullNode = nullNode;
// EXPECT_FALSE(assignedNullNode.isValid()) << "Empty assigned node should not be valid";
}
TEST_F(XmlTest, GetNodeChildren)
{
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
// Get the root node and check its name
auto rootNode = document.findXPath("/testDocument").at(0);
EXPECT_TRUE(rootNode.isValid()) << "Root node should be valid";
auto children = rootNode.getChildren();
EXPECT_GE(children.size(), 2) << "Expected at least 2 child nodes";
// Check all non-text nodes
for (const auto& child : children)
{
if (child.getName() == "text")
{
continue;
}
EXPECT_EQ(child.getName(), "colourscheme") << "Expected only colourscheme nodes";
}
}
TEST_F(XmlTest, GetNamedNodeChildren)
{
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
// Get the root node and check its name
auto rootNode = document.findXPath("/testDocument").at(0);
EXPECT_TRUE(rootNode.isValid()) << "Root node should be valid";
auto children = rootNode.getNamedChildren("colourscheme");
EXPECT_EQ(children.size(), 2) << "Expected exactly 2 child nodes";
EXPECT_EQ(children.at(0).getName(), "colourscheme") << "Expected only colourscheme nodes";
EXPECT_EQ(children.at(1).getName(), "colourscheme") << "Expected only colourscheme nodes";
}
TEST_F(XmlTest, GetNodeAttributeValue)
{
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
// Get the root node and check its name
auto colourNode = document.findXPath("/testDocument//colour[@name='active_view_name']").at(0);
EXPECT_TRUE(colourNode.isValid()) << "Colour node should be valid";
EXPECT_EQ(colourNode.getName(), "colour") << "Expected only colourscheme nodes";
EXPECT_EQ(colourNode.getAttributeValue("name"), "active_view_name") << "Attribute values not retrieved";
EXPECT_EQ(colourNode.getAttributeValue("value"), "0.7 0.7 0") << "Attribute values not retrieved";
EXPECT_EQ(colourNode.getAttributeValue("nonexistent"), "") << "Nonexistent attributes should return an empty string";
}
TEST_F(XmlTest, SetNodeAttributeValue)
{
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
// Get the root node and check its name
auto colourNode = document.findXPath("/testDocument//colour[@name='active_view_name']").at(0);
EXPECT_EQ(colourNode.getAttributeValue("name"), "active_view_name") << "Attribute values not retrieved";
EXPECT_EQ(colourNode.getAttributeValue("nonexistent"), "") << "Nonexistent attributes should return an empty string";
EXPECT_EQ(document.findXPath("/testDocument//colour[@name='active_view_name']").size(), 2) << "We should start with 2 active_view_name colours";
EXPECT_EQ(document.findXPath("/testDocument//colour[@name='My new name!']").size(), 0) << "This node should not be there yet";
colourNode.setAttributeValue("name", "My new name!");
colourNode.setAttributeValue("nonexistent", "Not so nonexistent anymore");
EXPECT_EQ(colourNode.getAttributeValue("name"), "My new name!") << "Attribute values not retrieved";
EXPECT_EQ(colourNode.getAttributeValue("nonexistent"), "Not so nonexistent anymore") << "Attribute values not retrieved";
// The changes should also be applied within the document without explicitly having to save anything
EXPECT_EQ(document.findXPath("/testDocument//colour[@name='active_view_name']").size(), 1) << "Only one of these should be left";
EXPECT_EQ(document.findXPath("/testDocument//colour[@name='My new name!']").size(), 1);
}
TEST_F(XmlTest, CreateNodeChild)
{
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
EXPECT_EQ(document.findXPath("//colourscheme[@name='Black & Green']").size(), 1);
EXPECT_EQ(document.findXPath("//colourscheme[@name='Black & Green']/testNode").size(), 0) << "Expected no children";
auto colourscheme = document.findXPath("//colourscheme[@name='Black & Green']").at(0);
auto previousChildNodes = colourscheme.getChildren();
colourscheme.createChild("testNode");
EXPECT_EQ(document.findXPath("//colourscheme[@name='Black & Green']").size(), 1);
EXPECT_EQ(document.findXPath("//colourscheme[@name='Black & Green']/testNode").size(), 1) << "Expected 1 child now";
auto childNodes = colourscheme.getChildren();
EXPECT_EQ(childNodes.size(), previousChildNodes.size() + 1);
childNodes = colourscheme.getNamedChildren("testNode");
EXPECT_EQ(childNodes.size(), 1);
EXPECT_EQ(childNodes.at(0).getName(), "testNode");
}
TEST_F(XmlTest, GetNodeContent)
{
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
auto colourNode = document.findXPath("//colourscheme[@name='DarkRadiant Default']/colour[@name='xyview_crosshairs']").at(0);
EXPECT_EQ(colourNode.getContent(), "") << "Closed XML tag should have an empty content";
EXPECT_EQ(document.findXPath("//colourscheme[@name='DarkRadiant Default']").size(), 1);
EXPECT_EQ(document.findXPath("//colourscheme[@name='DarkRadiant Default']/specialNode").size(), 1) << "Expected 1 matching node";
auto specialNode = document.findXPath("//colourscheme[@name='DarkRadiant Default']/specialNode").at(0);
EXPECT_EQ(specialNode.getContent(), "Some special content");
auto specialNodeWithWhitespace = document.findXPath("//colourscheme[@name='DarkRadiant Default']/specialNodeWithWhitespace").at(0);
EXPECT_EQ(specialNodeWithWhitespace.getContent(), R"(
Some special content including leading and trailing whitespace
)");
}
TEST_F(XmlTest, SetNodeContent)
{
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
EXPECT_EQ(document.findXPath("//colourscheme[@name='DarkRadiant Default']").size(), 1);
EXPECT_EQ(document.findXPath("//colourscheme[@name='DarkRadiant Default']/specialNode").size(), 1) << "Expected 1 matching node";
auto specialNode = document.findXPath("//colourscheme[@name='DarkRadiant Default']/specialNode").at(0);
std::string someText = "-Some text-";
specialNode.setContent(someText);
EXPECT_EQ(specialNode.getContent(), someText);
EXPECT_NE(document.saveToString().find(someText), std::string::npos) << "Expected to find the custom string in the document";
// LF whitespaces should be preserved when stored in the content
std::string someTextWithWhitespace = "\n-Some\ntext-\t\t\n";
specialNode.setContent(someTextWithWhitespace);
EXPECT_EQ(specialNode.getContent(), someTextWithWhitespace);
EXPECT_NE(document.saveToString().find(someTextWithWhitespace), std::string::npos) << "Expected to find the custom whitespace string in the document";
}
TEST_F(XmlTest, AddTextToNode)
{
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
auto colourscheme = document.findXPath("//colourscheme[@name='DarkRadiant Default']").at(0);
auto testNode1 = colourscheme.createChild("testNode");
auto testNode2 = colourscheme.createChild("testNode");
// The two nodes lack any whitespace
auto expectedText = "<testNode/><testNode/>";
auto expectedTextWithAddedText = "<testNode/> \t <testNode/>\n";
EXPECT_NE(document.saveToString().find(expectedText), std::string::npos) << "Expected to find the new nodes in the document";
EXPECT_EQ(document.saveToString().find(expectedTextWithAddedText), std::string::npos) << "Whitespaced text should not be present yet";
// Add some specific whitespace to the first node and a line break to the second
testNode1.addText(" \t ");
testNode2.addText("\n");
EXPECT_EQ(document.saveToString().find(expectedText), std::string::npos) << "The old text should be gone";
EXPECT_NE(document.saveToString().find(expectedTextWithAddedText), std::string::npos) << "Expected to find the whitespaced nodes in the document";
}
TEST_F(XmlTest, EraseNode)
{
xml::Document document(getXmlTestResourcePath() + TEST_XML_FILE);
// Expect exactly two colour schemes, one with that name
EXPECT_EQ(document.findXPath("//colourscheme").size(), 2);
EXPECT_EQ(document.findXPath("//colourscheme[@name='DarkRadiant Default']").size(), 1);
auto colourscheme = document.findXPath("//colourscheme[@name='DarkRadiant Default']").at(0);
colourscheme.erase();
EXPECT_EQ(document.findXPath("//colourscheme").size(), 1);
EXPECT_EQ(document.findXPath("//colourscheme[@name='DarkRadiant Default']").size(), 0);
}
TEST_F(XmlTest, LoadGameFile)
{
xml::Document game(getXmlTestResourcePath() + "darkmod.game");
EXPECT_TRUE(game.isValid());
auto nodes = game.findXPath("//game");
EXPECT_EQ(nodes.size(), 1);
EXPECT_EQ(nodes[0].getName(), "game");
EXPECT_EQ(nodes[0].getAttributeValue("name"), "The Dark Mod 2.0 (Standalone)");
EXPECT_EQ(nodes[0].getAttributeValue("index"), "10");
auto nodes1 = game.findXPath("//game[@name='The Dark Mod 2.0 (Standalone)']");
EXPECT_EQ(nodes1.size(), 1);
}
TEST_F(XmlTest, LoadInputFile)
{
xml::Document input(getXmlTestResourcePath() + "input.xml");
EXPECT_TRUE(input.isValid());
auto nodes = input.findXPath("//input/mouseToolMappings/mouseToolMapping[@name='OrthoView']");
EXPECT_EQ(nodes.size(), 1);
}
}
|