1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063
|
from __future__ import annotations
import asyncio
import pytest
import distributed
from distributed import Event, Lock, Worker
from distributed.client import wait
from distributed.utils_test import (
BlockedExecute,
BlockedGatherDep,
BlockedGetData,
_LockedCommPool,
assert_story,
gen_cluster,
inc,
lock_inc,
wait_for_state,
wait_for_stimulus,
)
from distributed.worker_state_machine import (
AddKeysMsg,
ComputeTaskEvent,
DigestMetric,
Execute,
ExecuteFailureEvent,
ExecuteSuccessEvent,
FreeKeysEvent,
GatherDep,
GatherDepFailureEvent,
GatherDepNetworkFailureEvent,
GatherDepSuccessEvent,
LongRunningMsg,
RescheduleEvent,
SecedeEvent,
TaskFinishedMsg,
UpdateDataEvent,
)
async def wait_for_cancelled(key, dask_worker):
while key in dask_worker.state.tasks:
if dask_worker.state.tasks[key].state == "cancelled":
return
await asyncio.sleep(0.005)
assert False
@gen_cluster(client=True, nthreads=[("", 1)])
async def test_abort_execution_release(c, s, a):
lock = Lock()
async with lock:
fut = c.submit(lock_inc, 1, lock=lock)
await wait_for_state(fut.key, "executing", a)
fut.release()
await wait_for_cancelled(fut.key, a)
@gen_cluster(client=True, nthreads=[("", 1)])
async def test_abort_execution_reschedule(c, s, a):
lock = Lock()
async with lock:
fut = c.submit(lock_inc, 1, lock=lock)
await wait_for_state(fut.key, "executing", a)
fut.release()
await wait_for_cancelled(fut.key, a)
fut = c.submit(lock_inc, 1, lock=lock)
await fut
@gen_cluster(client=True, nthreads=[("", 1)])
async def test_abort_execution_add_as_dependency(c, s, a):
lock = Lock()
async with lock:
fut = c.submit(lock_inc, 1, lock=lock)
await wait_for_state(fut.key, "executing", a)
fut.release()
await wait_for_cancelled(fut.key, a)
fut = c.submit(lock_inc, 1, lock=lock)
fut = c.submit(inc, fut)
await fut
@gen_cluster(client=True)
async def test_abort_execution_to_fetch(c, s, a, b):
ev = Event()
def f(ev):
ev.wait()
return 123
fut = c.submit(f, ev, key="f1", workers=[a.worker_address])
await wait_for_state(fut.key, "executing", a)
fut.release()
await wait_for_cancelled(fut.key, a)
# While the first worker is still trying to compute f1, we'll resubmit it to
# another worker with a smaller delay. The key is still the same
fut = c.submit(inc, 1, key="f1", workers=[b.worker_address])
# then, a must switch the execute to fetch. Instead of doing so, it will
# simply re-use the currently computing result.
fut = c.submit(inc, fut, workers=[a.worker_address], key="f2")
await wait_for_state("f2", "waiting", a)
await ev.set()
assert await fut == 124 # It would be 3 if the result was copied from b
del fut
while "f1" in a.state.tasks:
await asyncio.sleep(0.01)
assert_story(
a.state.story("f1"),
[
("f1", "compute-task", "released"),
("f1", "released", "waiting", "waiting", {"f1": "ready"}),
("f1", "waiting", "ready", "ready", {"f1": "executing"}),
("f1", "ready", "executing", "executing", {}),
("free-keys", ("f1",)),
("f1", "executing", "released", "cancelled", {}),
("f1", "cancelled", "fetch", "resumed", {}),
("f1", "resumed", "memory", "memory", {"f2": "ready"}),
("free-keys", ("f1",)),
("f1", "memory", "released", "released", {}),
("f1", "released", "forgotten", "forgotten", {}),
],
)
@gen_cluster(client=True)
async def test_worker_stream_died_during_comm(c, s, a, b):
write_queue = asyncio.Queue()
write_event = asyncio.Event()
b.rpc = _LockedCommPool(
b.rpc,
write_queue=write_queue,
write_event=write_event,
)
fut = c.submit(inc, 1, workers=[a.address], allow_other_workers=True)
await fut
# Actually no worker has the data; the scheduler is supposed to reschedule
res = c.submit(inc, fut, workers=[b.address])
await write_queue.get()
await a.close()
write_event.set()
await res
assert any("receive-dep-failed" in msg for msg in b.state.log)
@gen_cluster(client=True, nthreads=[("", 1)])
async def test_flight_to_executing_via_cancelled_resumed(c, s, b):
block_get_data = asyncio.Lock()
block_compute = Lock()
enter_get_data = asyncio.Event()
await block_get_data.acquire()
class BrokenWorker(Worker):
async def get_data(self, comm, *args, **kwargs):
enter_get_data.set()
async with block_get_data:
comm.abort()
def blockable_compute(x, lock):
with lock:
return x + 1
async with BrokenWorker(s.address) as a:
await c.wait_for_workers(2)
fut1 = c.submit(
blockable_compute,
1,
lock=block_compute,
workers=[a.address],
allow_other_workers=True,
key="fut1",
)
await wait(fut1)
await block_compute.acquire()
fut2 = c.submit(inc, fut1, workers=[b.address], key="fut2")
await enter_get_data.wait()
# Close in scheduler to ensure we transition and reschedule task properly
await s.remove_worker(a.address, stimulus_id="test", close=False)
await wait_for_stimulus(ComputeTaskEvent, b, key=fut1.key)
block_get_data.release()
await block_compute.release()
assert await fut2 == 3
b_story = b.state.story(fut1.key)
assert any("receive-dep-failed" in msg for msg in b_story)
assert any("cancelled" in msg for msg in b_story)
assert any("resumed" in msg for msg in b_story)
@gen_cluster(client=True, nthreads=[("", 1)])
async def test_executing_cancelled_error(c, s, w):
"""One worker with one thread. We provoke an executing->cancelled transition
and let the task err. This test ensures that there is no residual state
(e.g. a semaphore) left blocking the thread"""
lock = distributed.Lock()
await lock.acquire()
async def wait_and_raise(*args, **kwargs):
async with lock:
raise RuntimeError()
f1 = c.submit(wait_and_raise, key="f1")
await wait_for_state(f1.key, "executing", w)
# Queue up another task to ensure this is not affected by our error handling
f2 = c.submit(inc, 1, key="f2")
await wait_for_state(f2.key, "ready", w)
f1.release()
await wait_for_state(f1.key, "cancelled", w)
await lock.release()
# At this point we do not fetch the result of the future since the future
# itself would raise a cancelled exception. At this point we're concerned
# about the worker. The task should transition over error to be eventually
# forgotten since we no longer hold a ref.
while f1.key in w.state.tasks:
await asyncio.sleep(0.01)
assert await f2 == 2
# Everything should still be executing as usual after this
assert await c.submit(sum, c.map(inc, range(10))) == sum(map(inc, range(10)))
# Everything above this line should be generically true, regardless of
# refactoring. Below verifies some implementation specific test assumptions
assert_story(
w.state.story(f1.key),
[
(f1.key, "executing", "released", "cancelled", {}),
(f1.key, "cancelled", "error", "released", {f1.key: "forgotten"}),
(f1.key, "released", "forgotten", "forgotten", {}),
],
)
def test_flight_cancelled_error(ws):
"""Test flight -> cancelled -> error transition loop.
This can be caused by an issue while (un)pickling or a bug in the network stack.
See https://github.com/dask/distributed/issues/6877
"""
ws2 = "127.0.0.1:2"
instructions = ws.handle_stimulus(
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s1"),
FreeKeysEvent(keys=["y", "x"], stimulus_id="s2"),
GatherDepFailureEvent.from_exception(
Exception(), worker=ws2, total_nbytes=1, stimulus_id="s3"
),
)
assert instructions == [
GatherDep(worker=ws2, to_gather={"x"}, total_nbytes=1, stimulus_id="s1")
]
assert not ws.tasks
@gen_cluster(client=True, nthreads=[("", 1)])
async def test_in_flight_lost_after_resumed(c, s, b):
lock_executing = Lock()
def block_execution(lock):
lock.acquire()
return 1
async with BlockedGetData(s.address) as a:
fut1 = c.submit(
block_execution,
lock_executing,
workers=[a.address],
key="fut1",
)
# Ensure fut1 is in memory but block any further execution afterwards to
# ensure we control when the recomputation happens
await wait(fut1)
fut2 = c.submit(inc, fut1, workers=[b.address], key="fut2")
# This ensures that B already fetches the task, i.e. after this the task
# is guaranteed to be in flight
await a.in_get_data.wait()
assert fut1.key in b.state.tasks
assert b.state.tasks[fut1.key].state == "flight"
s.set_restrictions({fut1.key: [a.address, b.address]})
# It is removed, i.e. get_data is guaranteed to fail and f1 is scheduled
# to be recomputed on B
await s.remove_worker(a.address, stimulus_id="foo", close=False, safe=True)
while not b.state.tasks[fut1.key].state == "resumed":
await asyncio.sleep(0.01)
fut1.release()
fut2.release()
while not b.state.tasks[fut1.key].state == "cancelled":
await asyncio.sleep(0.01)
a.block_get_data.set()
while b.state.tasks:
await asyncio.sleep(0.01)
assert_story(
b.state.story(fut1.key),
expect=[
# The initial free-keys is rejected
("free-keys", (fut1.key,)),
(fut1.key, "resumed", "released", "cancelled", {}),
# After gather_dep receives the data, the task is forgotten
(fut1.key, "cancelled", "memory", "released", {fut1.key: "forgotten"}),
(fut1.key, "released", "forgotten", "forgotten", {}),
],
)
@gen_cluster(client=True)
async def test_cancelled_error(c, s, a, b):
executing = Event()
lock_executing = Lock()
await lock_executing.acquire()
def block_execution(event, lock):
event.set()
with lock:
raise RuntimeError()
fut1 = c.submit(
block_execution,
executing,
lock_executing,
workers=[b.address],
allow_other_workers=True,
key="fut1",
)
await executing.wait()
assert b.state.tasks[fut1.key].state == "executing"
fut1.release()
while b.state.tasks[fut1.key].state == "executing":
await asyncio.sleep(0.01)
await lock_executing.release()
while b.state.tasks:
await asyncio.sleep(0.01)
assert_story(
b.state.story(fut1.key),
[
(fut1.key, "executing", "released", "cancelled", {}),
(fut1.key, "cancelled", "error", "released", {fut1.key: "forgotten"}),
(fut1.key, "released", "forgotten", "forgotten", {}),
],
)
@gen_cluster(client=True, nthreads=[("", 1, {"resources": {"A": 1}})])
async def test_cancelled_error_with_resources(c, s, a):
executing = Event()
lock_executing = Lock()
await lock_executing.acquire()
def block_execution(event, lock):
event.set()
with lock:
raise RuntimeError()
fut1 = c.submit(
block_execution,
executing,
lock_executing,
resources={"A": 1},
key="fut1",
)
await executing.wait()
fut2 = c.submit(inc, 1, resources={"A": 1}, key="fut2")
while fut2.key not in a.state.tasks:
await asyncio.sleep(0.01)
fut1.release()
while a.state.tasks[fut1.key].state == "executing":
await asyncio.sleep(0.01)
await lock_executing.release()
assert await fut2 == 2
@gen_cluster(client=True, nthreads=[("", 1)])
async def test_cancelled_resumed_after_flight_with_dependencies(c, s, a):
"""A task is in flight from b to a.
While a is waiting, b dies. The scheduler notices before a and reschedules the
task on a itself (as the only surviving replica was just lost).
Test that the worker eventually computes the task.
See https://github.com/dask/distributed/pull/6327#discussion_r872231090
See test_cancelled_resumed_after_flight_with_dependencies_workerstate below.
"""
async with BlockedGetData(s.address) as b:
x = c.submit(inc, 1, key="x", workers=[b.address], allow_other_workers=True)
y = c.submit(inc, x, key="y", workers=[a.address])
await b.in_get_data.wait()
# Make b dead to s, but not to a
await s.remove_worker(b.address, stimulus_id="stim-id")
# Wait for the scheduler to reschedule x on a.
# We want the comms from the scheduler to reach a before b closes the RPC
# channel, causing a.gather_dep() to raise OSError.
await wait_for_stimulus(ComputeTaskEvent, a, key="x")
# b closed; a.gather_dep() fails. Note that, in the current implementation, x won't
# be recomputed on a until this happens.
assert await y == 3
def test_cancelled_resumed_after_flight_with_dependencies_workerstate(ws):
"""Same as test_cancelled_resumed_after_flight_with_dependencies, but testing the
WorkerState in isolation
"""
ws2 = "127.0.0.1:2"
instructions = ws.handle_stimulus(
# Create task x and put it in flight from ws2
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s1"),
# The scheduler realises that ws2 is unresponsive, although ws doesn't know yet.
# Having lost the last surviving replica of x, the scheduler cancels all of its
# dependents. This also cancels x.
FreeKeysEvent(keys=["y"], stimulus_id="s2"),
# The scheduler reschedules x on another worker, which just happens to be one
# that was previously fetching it. This does not generate an Execute
# instruction, because the GatherDep instruction isn't complete yet.
ComputeTaskEvent.dummy("x", stimulus_id="s3"),
# After ~30s, the TCP socket with ws2 finally times out and collapses.
# This triggers the Execute instruction.
GatherDepNetworkFailureEvent(worker=ws2, total_nbytes=1, stimulus_id="s4"),
)
assert instructions == [
GatherDep(worker=ws2, to_gather={"x"}, total_nbytes=1, stimulus_id="s1"),
Execute(key="x", stimulus_id="s4"), # Note the stimulus_id!
]
assert ws.tasks["x"].state == "executing"
@pytest.mark.parametrize("wait_for_processing", [True, False])
@pytest.mark.parametrize("raise_error", [True, False])
@gen_cluster(client=True)
async def test_resumed_cancelled_handle_compute(
c, s, a, b, raise_error, wait_for_processing
):
"""
Given the history of a task
executing -> cancelled -> resumed(fetch)
A handle_compute should properly restore executing.
"""
# This test is heavily using set_restrictions to simulate certain scheduler
# decisions of placing keys
lock_compute = Lock()
await lock_compute.acquire()
enter_compute = Event()
exit_compute = Event()
def block(x, lock, enter_event, exit_event):
enter_event.set()
try:
with lock:
if raise_error:
raise RuntimeError("test error")
else:
return x + 1
finally:
exit_event.set()
f1 = c.submit(inc, 1, key="f1", workers=[a.address])
f2 = c.submit(inc, f1, key="f2", workers=[a.address])
f3 = c.submit(
block,
f2,
lock=lock_compute,
enter_event=enter_compute,
exit_event=exit_compute,
key="f3",
workers=[b.address],
)
f4 = c.submit(sum, [f1, f3], key="f4", workers=[b.address])
await enter_compute.wait()
async def release_all_futures():
futs = [f1, f2, f3, f4]
for fut in futs:
fut.release()
while any(fut.key in s.tasks for fut in futs):
await asyncio.sleep(0.05)
await release_all_futures()
await wait_for_state(f3.key, "cancelled", b)
f1 = c.submit(inc, 1, key="f1", workers=[a.address])
f2 = c.submit(inc, f1, key="f2", workers=[a.address])
f3 = c.submit(inc, f2, key="f3", workers=[a.address])
f4 = c.submit(sum, [f1, f3], key="f4", workers=[b.address])
await wait_for_state(f3.key, "resumed", b)
await release_all_futures()
if not wait_for_processing:
await lock_compute.release()
await exit_compute.wait()
f1 = c.submit(inc, 1, key="f1", workers=[a.address])
f2 = c.submit(inc, f1, key="f2", workers=[a.address])
f3 = c.submit(inc, f2, key="f3", workers=[b.address])
f4 = c.submit(sum, [f1, f3], key="f4", workers=[b.address])
if wait_for_processing:
await wait_for_state(f3.key, "processing", s)
await lock_compute.release()
if not wait_for_processing and not raise_error:
assert await f4 == 4 + 2
assert_story(
b.state.story(f3.key),
expect=[
(f3.key, "ready", "executing", "executing", {}),
(f3.key, "executing", "released", "cancelled", {}),
(f3.key, "cancelled", "fetch", "resumed", {}),
(f3.key, "resumed", "memory", "memory", {}),
],
)
elif not wait_for_processing and raise_error:
assert await f4 == 4 + 2
assert_story(
b.state.story(f3.key),
expect=[
(f3.key, "ready", "executing", "executing", {}),
(f3.key, "executing", "released", "cancelled", {}),
(f3.key, "cancelled", "fetch", "resumed", {}),
(f3.key, "resumed", "error", "released", {f3.key: "fetch"}),
(f3.key, "fetch", "flight", "flight", {}),
(f3.key, "flight", "missing", "missing", {}),
(f3.key, "missing", "waiting", "waiting", {f2.key: "fetch"}),
(f3.key, "waiting", "ready", "ready", {f3.key: "executing"}),
(f3.key, "ready", "executing", "executing", {}),
(f3.key, "executing", "memory", "memory", {}),
],
)
elif wait_for_processing and not raise_error:
assert await f4 == 4 + 2
assert_story(
b.state.story(f3.key),
expect=[
(f3.key, "ready", "executing", "executing", {}),
(f3.key, "executing", "released", "cancelled", {}),
(f3.key, "cancelled", "fetch", "resumed", {}),
(f3.key, "resumed", "waiting", "executing", {}),
(f3.key, "executing", "memory", "memory", {}),
],
)
elif wait_for_processing and raise_error:
with pytest.raises(RuntimeError, match="test error"):
await f3
assert_story(
b.state.story(f3.key),
[
(f3.key, "ready", "executing", "executing", {}),
(f3.key, "executing", "released", "cancelled", {}),
(f3.key, "cancelled", "fetch", "resumed", {}),
(f3.key, "resumed", "waiting", "executing", {}),
(f3.key, "executing", "error", "error", {}),
],
)
else:
assert False, "unreachable"
@pytest.mark.parametrize("intermediate_state", ["resumed", "cancelled"])
@pytest.mark.parametrize("close_worker", [False, True])
@gen_cluster(client=True, config={"distributed.comm.timeouts.connect": "500ms"})
async def test_deadlock_cancelled_after_inflight_before_gather_from_worker(
c, s, a, x, intermediate_state, close_worker
):
"""If a task was transitioned to in-flight, the gather_dep coroutine was scheduled
but a cancel request came in before gather_data_from_worker was issued. This might
corrupt the state machine if the cancelled key is not properly handled.
"""
fut1 = c.submit(inc, 1, workers=[a.address], key="f1")
fut1B = c.submit(inc, 2, workers=[x.address], key="f1B")
fut2 = c.submit(sum, [fut1, fut1B], workers=[x.address], key="f2")
await fut2
async with BlockedGatherDep(s.address, name="b") as b:
fut3 = c.submit(inc, fut2, workers=[b.address], key="f3")
await wait_for_state(fut2.key, "flight", b)
s.set_restrictions(worker={fut1B.key: a.address, fut2.key: b.address})
await b.in_gather_dep.wait()
await s.remove_worker(
address=x.address,
safe=True,
close=close_worker,
stimulus_id="remove-worker",
)
await wait_for_state(fut2.key, intermediate_state, b, interval=0)
b.block_gather_dep.set()
await fut3
def test_workerstate_executing_to_executing(ws_with_running_task):
"""Test state loops:
- executing -> cancelled -> executing
- executing -> long-running -> cancelled -> long-running
Test that the task immediately reverts to its original state.
"""
ws = ws_with_running_task
ts = ws.tasks["x"]
prev_state = ts.state
instructions = ws.handle_stimulus(
FreeKeysEvent(keys=["x"], stimulus_id="s1"),
ComputeTaskEvent.dummy("x", resource_restrictions={"R": 1}, stimulus_id="s2"),
)
if prev_state == "executing":
assert not instructions
else:
assert instructions == [
LongRunningMsg(key="x", compute_duration=None, stimulus_id="s2")
]
assert ws.tasks["x"] is ts
assert ts.state == prev_state
def test_workerstate_flight_to_flight(ws):
"""Test state loop:
flight -> cancelled -> flight
Test that the task immediately reverts to its original state.
"""
ws2 = "127.0.0.1:2"
instructions = ws.handle_stimulus(
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s1"),
FreeKeysEvent(keys=["y", "x"], stimulus_id="s2"),
ComputeTaskEvent.dummy("z", who_has={"x": [ws2]}, stimulus_id="s3"),
)
assert instructions == [
GatherDep(worker=ws2, to_gather={"x"}, total_nbytes=1, stimulus_id="s1")
]
assert ws.tasks["x"].state == "flight"
def test_workerstate_executing_skips_fetch_on_success(ws_with_running_task):
"""Test state loops:
- executing -> cancelled -> resumed(fetch) -> memory
- executing -> long-running -> cancelled -> resumed(fetch) -> memory
The task execution later terminates successfully.
Test that the task is never fetched and that dependents are unblocked.
See also: test_workerstate_executing_failure_to_fetch
"""
ws = ws_with_running_task
ws2 = "127.0.0.1:2"
instructions = ws.handle_stimulus(
FreeKeysEvent(keys=["x"], stimulus_id="s1"),
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s2"),
ExecuteSuccessEvent.dummy("x", 123, stimulus_id="s3"),
)
assert instructions == [
DigestMetric(name="compute-duration", value=1.0, stimulus_id="s3"),
AddKeysMsg(keys=["x"], stimulus_id="s3"),
Execute(key="y", stimulus_id="s3"),
]
assert ws.tasks["x"].state == "memory"
assert ws.data["x"] == 123
def test_workerstate_executing_failure_to_fetch(ws_with_running_task):
"""Test state loops:
- executing -> cancelled -> resumed(fetch)
- executing -> long-running -> cancelled -> resumed(fetch)
The task execution later terminates with a failure.
This is an edge case interaction between work stealing and a task that does not
deterministically succeed or fail when run multiple times or on different workers.
Test that the task is fetched from the other worker. This is to avoid having to deal
with cancelling the dependent, which would require interaction with the scheduler
and increase the complexity of the use case.
See also: test_workerstate_executing_success_to_fetch
"""
ws = ws_with_running_task
ws2 = "127.0.0.1:2"
instructions = ws.handle_stimulus(
FreeKeysEvent(keys=["x"], stimulus_id="s1"),
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s2"),
ExecuteFailureEvent.dummy("x", stimulus_id="s3"),
)
assert instructions == [
GatherDep(worker=ws2, to_gather={"x"}, total_nbytes=1, stimulus_id="s3")
]
assert ws.tasks["x"].state == "flight"
def test_workerstate_flight_skips_executing_on_success(ws):
"""Test state loop
flight -> cancelled -> resumed(waiting) -> memory
gather_dep later terminates successfully.
Test that the task is not executed and is in memory.
"""
ws2 = "127.0.0.1:2"
instructions = ws.handle_stimulus(
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s1"),
FreeKeysEvent(keys=["y", "x"], stimulus_id="s2"),
ComputeTaskEvent.dummy("x", stimulus_id="s3"),
GatherDepSuccessEvent(
worker=ws2, total_nbytes=1, data={"x": 123}, stimulus_id="s4"
),
)
assert instructions == [
GatherDep(worker=ws2, to_gather={"x"}, total_nbytes=1, stimulus_id="s1"),
TaskFinishedMsg.match(key="x", stimulus_id="s4"),
]
assert ws.tasks["x"].state == "memory"
assert ws.data["x"] == 123
@pytest.mark.parametrize("block_queue", [False, True])
def test_workerstate_flight_failure_to_executing(ws, block_queue):
"""Test state loop
flight -> cancelled -> resumed(waiting)
gather_dep later terminates with a failure.
Test that the task is executed.
"""
ws2 = "127.0.0.1:2"
instructions = ws.handle_stimulus(
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s1"),
FreeKeysEvent(keys=["y", "x"], stimulus_id="s2"),
ComputeTaskEvent.dummy("x", stimulus_id="s3"),
)
assert instructions == [
GatherDep(stimulus_id="s1", worker=ws2, to_gather={"x"}, total_nbytes=1),
]
assert ws.tasks["x"].state == "resumed"
if block_queue:
instructions = ws.handle_stimulus(
ComputeTaskEvent.dummy(key="z", stimulus_id="s4"),
GatherDepNetworkFailureEvent(worker=ws2, total_nbytes=1, stimulus_id="s5"),
ExecuteSuccessEvent.dummy(key="z", stimulus_id="s6"),
)
assert instructions == [
Execute(key="z", stimulus_id="s4"),
DigestMetric(name="compute-duration", value=1.0, stimulus_id="s6"),
TaskFinishedMsg.match(key="z", stimulus_id="s6"),
Execute(key="x", stimulus_id="s6"),
]
assert_story(
ws.story("x"),
[
("x", "resumed", "fetch", "released", {"x": "waiting"}),
("x", "released", "waiting", "waiting", {"x": "ready"}),
("x", "waiting", "ready", "ready", {}),
],
)
else:
instructions = ws.handle_stimulus(
GatherDepNetworkFailureEvent(worker=ws2, total_nbytes=1, stimulus_id="s5"),
)
assert instructions == [
Execute(key="x", stimulus_id="s5"),
]
assert_story(
ws.story("x"),
[
("x", "resumed", "fetch", "released", {"x": "waiting"}),
("x", "released", "waiting", "waiting", {"x": "ready"}),
("x", "waiting", "ready", "ready", {"x": "executing"}),
],
)
assert ws.tasks["x"].state == "executing"
def test_workerstate_resumed_fetch_to_executing(ws_with_running_task):
"""Test state loops:
- executing -> cancelled -> resumed(fetch) -> cancelled -> executing
- executing -> long-running -> cancelled -> resumed(fetch) -> long-running
See also: test_workerstate_resumed_waiting_to_flight
"""
ws = ws_with_running_task
ws2 = "127.0.0.1:2"
prev_state = ws.tasks["x"].state
instructions = ws.handle_stimulus(
FreeKeysEvent(keys=["x"], stimulus_id="s1"),
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s2"),
FreeKeysEvent(keys=["y", "x"], stimulus_id="s3"),
ComputeTaskEvent.dummy("x", resource_restrictions={"R": 1}, stimulus_id="s4"),
)
if prev_state == "executing":
assert not instructions
else:
assert instructions == [
LongRunningMsg(key="x", compute_duration=None, stimulus_id="s4")
]
assert ws.tasks["x"].state == prev_state
def test_workerstate_resumed_waiting_to_flight(ws):
"""Test state loop:
- flight -> cancelled -> resumed(waiting) -> cancelled -> flight
See also: test_workerstate_resumed_fetch_to_executing
"""
ws2 = "127.0.0.1:2"
instructions = ws.handle_stimulus(
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s1"),
FreeKeysEvent(keys=["y", "x"], stimulus_id="s2"),
ComputeTaskEvent.dummy("x", resource_restrictions={"R": 1}, stimulus_id="s3"),
FreeKeysEvent(keys=["x"], stimulus_id="s4"),
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s5"),
)
assert instructions == [
GatherDep(worker=ws2, to_gather={"x"}, stimulus_id="s1", total_nbytes=1),
]
assert ws.tasks["x"].state == "flight"
@pytest.mark.parametrize("critical_section", ["execute", "deserialize_task"])
@pytest.mark.parametrize("resume_inside_critical_section", [False, True])
@pytest.mark.parametrize("resumed_status", ["executing", "resumed"])
@gen_cluster(client=True, nthreads=[("", 1)])
async def test_execute_preamble_early_cancel(
c, s, b, critical_section, resume_inside_critical_section, resumed_status
):
"""Test multiple race conditions in the preamble of Worker.execute(), which used to
cause a task to remain permanently in resumed state or to crash the worker through
`fail_hard` in case of very tight timings when resuming a task.
See also
--------
https://github.com/dask/distributed/issues/6869
https://github.com/dask/dask/issues/9330
test_worker.py::test_execute_preamble_abort_retirement
"""
async with BlockedExecute(s.address, validate=True) as a:
if critical_section == "execute":
in_ev = a.in_execute
block_ev = a.block_execute
a.block_deserialize_task.set()
else:
assert critical_section == "deserialize_task"
in_ev = a.in_deserialize_task
block_ev = a.block_deserialize_task
a.block_execute.set()
async def resume():
if resumed_status == "executing":
x = c.submit(inc, 1, key="x", workers=[a.address])
await wait_for_state("x", "executing", a)
return x, 2
else:
assert resumed_status == "resumed"
x = c.submit(inc, 1, key="x", workers=[b.address])
y = c.submit(inc, x, key="y", workers=[a.address])
await wait_for_state("x", "resumed", a)
return y, 3
x = c.submit(inc, 1, key="x", workers=[a.address])
await in_ev.wait()
x.release()
await wait_for_state("x", "cancelled", a)
if resume_inside_critical_section:
fut, expect = await resume()
# Unblock Worker.execute. At the moment of writing this test, the method
# would detect the cancelled status and perform an early exit.
block_ev.set()
await a.in_execute_exit.wait()
if not resume_inside_critical_section:
fut, expect = await resume()
# Finally let the done_callback of Worker.execute run
a.block_execute_exit.set()
# Test that x does not get stuck.
assert await fut == expect
@pytest.mark.parametrize("release_dep", [False, True])
@pytest.mark.parametrize(
"done_ev_cls", [ExecuteSuccessEvent, ExecuteFailureEvent, RescheduleEvent]
)
def test_cancel_with_dependencies_in_memory(ws, release_dep, done_ev_cls):
"""Cancel an executing task y with an in-memory dependency x; then simulate that x
did not have any further dependents, so cancel x as well.
Test that x immediately transitions to released state and is forgotten as soon as
y finishes computing.
Read: https://github.com/dask/distributed/issues/6893"""
ws.handle_stimulus(
UpdateDataEvent(data={"x": 1}, report=False, stimulus_id="s1"),
ComputeTaskEvent.dummy("y", who_has={"x": [ws.address]}, stimulus_id="s2"),
)
assert ws.tasks["x"].state == "memory"
assert ws.tasks["y"].state == "executing"
ws.handle_stimulus(FreeKeysEvent(keys=["y"], stimulus_id="s3"))
assert ws.tasks["x"].state == "memory"
assert ws.tasks["y"].state == "cancelled"
if release_dep:
# This will happen iff x has no dependents or waiters on the scheduler
ws.handle_stimulus(FreeKeysEvent(keys=["x"], stimulus_id="s4"))
assert ws.tasks["x"].state == "released"
assert ws.tasks["y"].state == "cancelled"
ws.handle_stimulus(done_ev_cls.dummy("y", stimulus_id="s5"))
assert "y" not in ws.tasks
assert "x" not in ws.tasks
else:
ws.handle_stimulus(done_ev_cls.dummy("y", stimulus_id="s5"))
assert "y" not in ws.tasks
assert ws.tasks["x"].state == "memory"
@pytest.mark.parametrize("resume_to_fetch", [False, True])
@pytest.mark.parametrize("resume_to_executing", [False, True])
@pytest.mark.parametrize(
"done_ev_cls", [ExecuteSuccessEvent, ExecuteFailureEvent, RescheduleEvent]
)
def test_secede_cancelled_or_resumed_workerstate(
ws, resume_to_fetch, resume_to_executing, done_ev_cls
):
"""Test what happens when a cancelled or resumed(fetch) task calls secede().
See also test_secede_cancelled_or_resumed_scheduler
"""
ws2 = "127.0.0.1:2"
ws.handle_stimulus(
ComputeTaskEvent.dummy("x", stimulus_id="s1"),
FreeKeysEvent(keys=["x"], stimulus_id="s2"),
)
if resume_to_fetch:
ws.handle_stimulus(
ComputeTaskEvent.dummy("y", who_has={"x": [ws2]}, stimulus_id="s3"),
)
ts = ws.tasks["x"]
assert ts.previous == "executing"
assert ts in ws.executing
assert ts not in ws.long_running
instructions = ws.handle_stimulus(
SecedeEvent(key="x", compute_duration=1, stimulus_id="s4")
)
assert not instructions # Do not send RescheduleMsg
assert ts.previous == "long-running"
assert ts not in ws.executing
assert ts in ws.long_running
if resume_to_executing:
instructions = ws.handle_stimulus(
FreeKeysEvent(keys=["y"], stimulus_id="s5"),
ComputeTaskEvent.dummy("x", stimulus_id="s6"),
)
# Inform the scheduler of the SecedeEvent that happened in the past
assert instructions == [
LongRunningMsg(key="x", compute_duration=None, stimulus_id="s6")
]
assert ts.state == "long-running"
assert ts not in ws.executing
assert ts in ws.long_running
ws.handle_stimulus(done_ev_cls.dummy(key="x", stimulus_id="s7"))
assert ts not in ws.executing
assert ts not in ws.long_running
@gen_cluster(client=True, nthreads=[("", 1)], timeout=2)
async def test_secede_cancelled_or_resumed_scheduler(c, s, a):
"""Same as test_secede_cancelled_or_resumed_workerstate, but testing the interaction
with the scheduler
"""
ws = s.workers[a.address]
ev1 = Event()
ev2 = Event()
ev3 = Event()
ev4 = Event()
def f(ev1, ev2, ev3, ev4):
ev1.set()
ev2.wait()
distributed.secede()
ev3.set()
ev4.wait()
return 123
x = c.submit(f, ev1, ev2, ev3, ev4, key="x")
await ev1.wait()
ts = a.state.tasks["x"]
assert ts.state == "executing"
assert ws.processing
assert not ws.long_running
x.release()
await wait_for_state("x", "cancelled", a)
assert not ws.processing
await ev2.set()
await ev3.wait()
assert ts.previous == "long-running"
assert not ws.processing
x = c.submit(inc, 1, key="x")
await wait_for_state("x", "long-running", a)
# Test that the scheduler receives a delayed {op: long-running}
assert ws.processing
while not ws.long_running:
await asyncio.sleep(0)
assert ws.processing
await ev4.set()
assert await x == 123
assert not ws.processing
|