1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435
|
from __future__ import annotations
import array
import logging
import os
import random
import uuid
from pathlib import Path
import pytest
from dask.sizeof import sizeof
from distributed import profile
from distributed.compatibility import WINDOWS
from distributed.spill import SpillBuffer, has_zict_210, has_zict_220
from distributed.utils_test import captured_logger
requires_zict_210 = pytest.mark.skipif(
not has_zict_210,
reason="requires zict version >= 2.1.0",
)
requires_zict_220 = pytest.mark.skipif(
not has_zict_220,
reason="requires zict version >= 2.2.0",
)
def psize(tmp_path: Path, **objs: object) -> tuple[int, int]:
return (
sum(sizeof(o) for o in objs.values()),
sum(os.stat(tmp_path / k).st_size for k in objs),
)
def assert_buf(
buf: SpillBuffer, tmp_path: Path, expect_fast: dict, expect_slow: dict
) -> None:
# assertions on fast
assert dict(buf.fast) == expect_fast
assert buf.fast.weights == {k: sizeof(v) for k, v in expect_fast.items()}
assert buf.fast.total_weight == sum(sizeof(v) for v in expect_fast.values())
for k, v in buf.fast.items():
assert buf[k] is v
# assertions on slow
assert set(buf.slow) == expect_slow.keys()
slow = buf.slow.data if has_zict_220 else buf.slow # type: ignore
assert slow.weight_by_key == {
k: psize(tmp_path, **{k: v}) for k, v in expect_slow.items()
}
total_weight = psize(tmp_path, **expect_slow)
assert slow.total_weight == total_weight
assert buf.spilled_total == total_weight
def test_psize(tmp_path):
buf = SpillBuffer(str(tmp_path), target=0)
a = "a" * 100
assert 100 < sizeof(a) < 200
buf["a"] = a
memory_size, disk_size = psize(tmp_path, a=a)
assert memory_size != disk_size
def test_spillbuffer(tmp_path):
buf = SpillBuffer(str(tmp_path), target=300)
# Convenience aliases
assert buf.memory is buf.fast
assert buf.disk is buf.slow
assert_buf(buf, tmp_path, {}, {})
a, b, c, d = "a" * 100, "b" * 99, "c" * 98, "d" * 97
# Test assumption made by this test, mostly for non CPython implementations
assert 100 < sizeof(a) < 200
buf["a"] = a
assert_buf(buf, tmp_path, {"a": a}, {})
assert buf["a"] == a
buf["b"] = b
assert_buf(buf, tmp_path, {"a": a, "b": b}, {})
buf["c"] = c
assert_buf(buf, tmp_path, {"b": b, "c": c}, {"a": a})
assert buf["a"] == a
assert_buf(buf, tmp_path, {"a": a, "c": c}, {"b": b})
buf["d"] = d
assert_buf(buf, tmp_path, {"a": a, "d": d}, {"b": b, "c": c})
# Deleting an in-memory key does not automatically move spilled keys back to memory
del buf["a"]
assert_buf(buf, tmp_path, {"d": d}, {"b": b, "c": c})
with pytest.raises(KeyError):
buf["a"]
# Deleting a spilled key updates the metadata
del buf["b"]
assert_buf(buf, tmp_path, {"d": d}, {"c": c})
with pytest.raises(KeyError):
buf["b"]
# Updating a spilled key moves it to the top of the LRU and to memory
c2 = c * 2
buf["c"] = c2
assert_buf(buf, tmp_path, {"c": c2}, {"d": d})
# Single key is larger than target and goes directly into slow
e = "e" * 500
buf["e"] = e
assert_buf(buf, tmp_path, {"c": c2}, {"d": d, "e": e})
# Updating a spilled key with another larger than target updates slow directly
d = "d" * 500
buf["d"] = d
assert_buf(buf, tmp_path, {"c": c2}, {"d": d, "e": e})
def test_disk_size_calculation(tmp_path):
buf = SpillBuffer(str(tmp_path), target=0)
a = "a" * 100
b = array.array("d", (random.random() for _ in range(100)))
buf["a"] = a
buf["b"] = b
assert_buf(buf, tmp_path, {}, {"a": a, "b": b})
@requires_zict_210
def test_spillbuffer_maxlim(tmp_path_factory):
buf_dir = tmp_path_factory.mktemp("buf")
buf = SpillBuffer(str(buf_dir), target=200, max_spill=600, min_log_interval=0)
a, b, c, d, e = "a" * 200, "b" * 100, "c" * 99, "d" * 199, "e" * 98
# size of a is bigger than target and is smaller than max_spill;
# key should be in slow
buf["a"] = a
assert_buf(buf, buf_dir, {}, {"a": a})
assert buf["a"] == a
# size of b is smaller than target key should be in fast
buf["b"] = b
assert_buf(buf, buf_dir, {"b": b}, {"a": a})
# size of c is smaller than target but b+c > target, c should stay in fast and b
# move to slow since the max_spill limit has not been reached yet
buf["c"] = c
assert_buf(buf, buf_dir, {"c": c}, {"a": a, "b": b})
# size of e < target but e+c > target, this will trigger movement of c to slow
# but the max spill limit prevents it. Resulting in e remaining in fast
with captured_logger(logging.getLogger("distributed.spill")) as logs_e:
buf["e"] = e
assert "disk reached capacity" in logs_e.getvalue()
assert_buf(buf, buf_dir, {"c": c, "e": e}, {"a": a, "b": b})
# size of d > target, d should go to slow but slow reached the max_spill limit then
# d will end up on fast with c (which can't be move to slow because it won't fit
# either)
with captured_logger(logging.getLogger("distributed.spill")) as logs_d:
buf["d"] = d
assert "disk reached capacity" in logs_d.getvalue()
assert_buf(buf, buf_dir, {"c": c, "d": d, "e": e}, {"a": a, "b": b})
# Overwrite a key that was in slow, but the size of the new key is larger than
# max_spill
a_large = "a" * 500
# Assert precondition that a_large is larger than max_spill when written to disk
unlimited_buf_dir = tmp_path_factory.mktemp("unlimited_buf")
unlimited_buf = SpillBuffer(unlimited_buf_dir, target=0)
unlimited_buf["a_large"] = a_large
assert psize(unlimited_buf_dir, a_large=a_large)[1] > 600
with captured_logger(logging.getLogger("distributed.spill")) as logs_alarge:
buf["a"] = a_large
assert "disk reached capacity" in logs_alarge.getvalue()
assert_buf(buf, buf_dir, {"a": a_large, "d": d, "e": e}, {"b": b, "c": c})
# Overwrite a key that was in fast, but the size of the new key is larger than
# max_spill
d_large = "d" * 501
with captured_logger(logging.getLogger("distributed.spill")) as logs_dlarge:
buf["d"] = d_large
assert "disk reached capacity" in logs_dlarge.getvalue()
assert_buf(buf, buf_dir, {"a": a_large, "d": d_large, "e": e}, {"b": b, "c": c})
class MyError(Exception):
pass
class Bad:
def __init__(self, size):
self.size = size
def __getstate__(self):
raise MyError()
def __sizeof__(self):
return self.size
@requires_zict_210
def test_spillbuffer_fail_to_serialize(tmp_path):
buf = SpillBuffer(str(tmp_path), target=200, max_spill=600, min_log_interval=0)
# bad data individually larger than spill threshold target 200
a = Bad(size=201)
# Exception caught in the worker
with pytest.raises(TypeError, match="Could not serialize"):
with captured_logger(logging.getLogger("distributed.spill")) as logs_bad_key:
buf["a"] = a
# spill.py must remain silent because we're already logging in worker.py
assert not logs_bad_key.getvalue()
assert_buf(buf, tmp_path, {}, {})
b = Bad(size=100) # this is small enough to fit in memory/fast
buf["b"] = b
assert_buf(buf, tmp_path, {"b": b}, {})
c = "c" * 100
with captured_logger(logging.getLogger("distributed.spill")) as logs_bad_key_mem:
# This will go to fast and try to kick b out,
# but keep b in fast since it's not pickable
buf["c"] = c
# worker.py won't intercept the exception here, so spill.py must dump the traceback
logs_value = logs_bad_key_mem.getvalue()
assert "Failed to pickle" in logs_value # from distributed.spill
assert "Traceback" in logs_value # from distributed.spill
assert_buf(buf, tmp_path, {"b": b, "c": c}, {})
@requires_zict_210
@pytest.mark.skipif(WINDOWS, reason="Needs chmod")
def test_spillbuffer_oserror(tmp_path):
buf = SpillBuffer(str(tmp_path), target=200, max_spill=800, min_log_interval=0)
a, b, c, d = (
"a" * 200,
"b" * 100,
"c" * 201,
"d" * 101,
)
# let's have something in fast and something in slow
buf["a"] = a
buf["b"] = b
assert_buf(buf, tmp_path, {"b": b}, {"a": a})
# modify permissions of disk to be read only.
# This causes writes to raise OSError, just like in case of disk full.
os.chmod(tmp_path, 0o555)
# Add key > than target
with captured_logger(logging.getLogger("distributed.spill")) as logs_oserror_slow:
buf["c"] = c
assert "Spill to disk failed" in logs_oserror_slow.getvalue()
assert_buf(buf, tmp_path, {"b": b, "c": c}, {"a": a})
del buf["c"]
assert_buf(buf, tmp_path, {"b": b}, {"a": a})
# add key to fast which is smaller than target but when added it triggers spill,
# which triggers OSError
with captured_logger(logging.getLogger("distributed.spill")) as logs_oserror_evict:
buf["d"] = d
assert "Spill to disk failed" in logs_oserror_evict.getvalue()
assert_buf(buf, tmp_path, {"b": b, "d": d}, {"a": a})
@requires_zict_210
def test_spillbuffer_evict(tmp_path):
buf = SpillBuffer(str(tmp_path), target=300, min_log_interval=0)
bad = Bad(size=100)
a = "a" * 100
buf["a"] = a
assert_buf(buf, tmp_path, {"a": a}, {})
# successful eviction
weight = buf.evict()
assert weight == sizeof(a)
assert_buf(buf, tmp_path, {}, {"a": a})
buf["bad"] = bad
assert_buf(buf, tmp_path, {"bad": bad}, {"a": a})
# unsuccessful eviction
with captured_logger(logging.getLogger("distributed.spill")) as logs_evict_key:
weight = buf.evict()
assert weight == -1
assert "Failed to pickle" in logs_evict_key.getvalue()
# bad keys stays in fast
assert_buf(buf, tmp_path, {"bad": bad}, {"a": a})
class NoWeakRef:
"""A class which
1. reports an arbitrary managed memory usage
2. does not support being targeted by weakref.ref()
3. has a property `id` which changes every time it is unpickled
"""
__slots__ = ("size", "id")
def __init__(self, size):
self.size = size
self.id = uuid.uuid4()
def __sizeof__(self):
return self.size
def __reduce__(self):
return (type(self), (self.size,))
class SupportsWeakRef(NoWeakRef):
__slots__ = ("__weakref__",)
@pytest.mark.parametrize(
"cls,expect_cached",
[
(SupportsWeakRef, has_zict_220),
(NoWeakRef, False),
],
)
@pytest.mark.parametrize("size", [60, 110])
def test_weakref_cache(tmp_path, cls, expect_cached, size):
buf = SpillBuffer(str(tmp_path), target=100)
# Run this test twice:
# - x is smaller than target and is evicted by y;
# - x is individually larger than target and it never touches fast
x = cls(size)
buf["x"] = x
if size < 100:
buf["y"] = cls(60) # spill x
assert "x" in buf.slow
# Test that we update the weakref cache on setitem
assert (buf["x"] is x) == expect_cached
# Do not use id_x = id(x), as in CPython id's are C memory addresses and are reused
# by PyMalloc when you descope objects, so a brand new object might end up having
# the same id as a deleted one
id_x = x.id
del x
# Ensure that the profiler has stopped and released all references to x so that it can be garbage-collected
with profile.lock:
pass
if size < 100:
buf["y"]
assert "x" in buf.slow
x2 = buf["x"]
assert x2.id != id_x
if size < 100:
buf["y"]
assert "x" in buf.slow
# Test that we update the weakref cache on getitem
assert (buf["x"] is x2) == expect_cached
def test_metrics(tmp_path):
buf = SpillBuffer(str(tmp_path), target=1000)
assert buf.get_metrics() == {
"disk_bytes": 0,
"disk_count": 0,
"disk_read_bytes_total": 0,
"disk_read_count_total": 0,
"disk_read_time_total": 0,
"disk_write_bytes_total": 0,
"disk_write_count_total": 0,
"disk_write_time_total": 0,
"memory_bytes": 0,
"memory_count": 0,
"memory_read_bytes_total": 0,
"memory_read_count_total": 0,
"pickle_time_total": 0,
"unpickle_time_total": 0,
}
a, b, c = "a" * 200, "b" * 150, "c" * 100
buf["a"] = a
buf["b"] = b
del buf["b"]
metrics = buf.get_metrics()
assert 200 < metrics["memory_bytes"] < 350
assert metrics["memory_count"] == 1
for k, v in metrics.items():
if "disk" in k or "pickle" in k:
assert v == 0, f"{k}={v}"
assert metrics["memory_read_bytes_total"] == 0
assert metrics["memory_read_count_total"] == 0
_ = buf["a"] # Cache hit
metrics = buf.get_metrics()
assert metrics["memory_read_bytes_total"] > 0
assert metrics["memory_read_count_total"] == 1
buf.evict()
buf["c"] = c
buf.evict()
_ = buf["c"] # Unspill / cache miss
metrics = buf.get_metrics()
for k, v in metrics.items():
assert v > 0, f"{k}={v}"
|