1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866
|
from __future__ import annotations
import asyncio
import contextlib
import itertools
import logging
import math
import random
import weakref
from collections import defaultdict
from operator import mul
from time import sleep
from typing import Callable, Iterable, Mapping, Sequence
import numpy as np
import pytest
from tlz import merge, sliding_window
import dask
from dask.utils import key_split, parse_bytes
from distributed import (
Client,
Event,
Lock,
Nanny,
Scheduler,
Worker,
profile,
wait,
worker_client,
)
from distributed.client import Future
from distributed.compatibility import LINUX
from distributed.core import Status
from distributed.metrics import time
from distributed.system import MEMORY_LIMIT
from distributed.utils_test import (
NO_AMM,
BlockedGetData,
captured_logger,
freeze_batched_send,
gen_cluster,
gen_nbytes,
inc,
nodebug_setup_module,
nodebug_teardown_module,
slowadd,
slowidentity,
slowinc,
)
from distributed.worker_state_machine import (
DigestMetric,
ExecuteSuccessEvent,
FreeKeysEvent,
StealRequestEvent,
)
pytestmark = pytest.mark.ci1
# Most tests here are timing-dependent
setup_module = nodebug_setup_module
teardown_module = nodebug_teardown_module
@gen_cluster(client=True, nthreads=[("", 2), ("", 2)])
async def test_work_stealing(c, s, a, b):
[x] = await c._scatter([1], workers=a.address)
futures = c.map(slowadd, range(50), [x] * 50)
await wait(futures)
assert len(a.data) > 10
assert len(b.data) > 10
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)] * 2)
async def test_dont_steal_expensive_data_fast_computation(c, s, a, b):
np = pytest.importorskip("numpy")
x = c.submit(np.arange, 1000000, workers=a.address)
await wait([x])
future = c.submit(np.sum, [1], workers=a.address) # learn that sum is fast
await wait([future])
cheap = [
c.submit(np.sum, x, pure=False, workers=a.address, allow_other_workers=True)
for i in range(10)
]
await wait(cheap)
assert len(s.tasks[x.key].who_has) == 1
assert len(b.data) == 0
assert len(a.data) == 12
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)] * 2)
async def test_steal_cheap_data_slow_computation(c, s, a, b):
x = c.submit(slowinc, 100, delay=0.1) # learn that slowinc is slow
await wait(x)
futures = c.map(
slowinc, range(10), delay=0.1, workers=a.address, allow_other_workers=True
)
await wait(futures)
assert abs(len(a.data) - len(b.data)) <= 5
@pytest.mark.slow
@gen_cluster(client=True, nthreads=[("", 1)] * 2, config=NO_AMM)
async def test_steal_expensive_data_slow_computation(c, s, a, b):
np = pytest.importorskip("numpy")
x = c.submit(slowinc, 1, delay=0.2, workers=a.address)
await wait(x) # learn that slowinc is slow
x = c.submit(np.arange, 1_000_000, workers=a.address) # put expensive data
await wait(x)
slow = [c.submit(slowinc, x, delay=0.1, pure=False) for _ in range(20)]
await wait(slow)
assert len(s.tasks[x.key].who_has) > 1
assert b.data # not empty
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)] * 10, config=NO_AMM)
async def test_worksteal_many_thieves(c, s, *workers):
x = c.submit(slowinc, -1, delay=0.1)
await x
xs = c.map(slowinc, [x] * 100, pure=False, delay=0.1)
await wait(xs)
for ws in s.workers.values():
assert 2 < len(ws.has_what) < 30
assert len(s.tasks[x.key].who_has) > 1
assert sum(len(ws.has_what) for ws in s.workers.values()) < 150
@gen_cluster(
client=True,
nthreads=[("127.0.0.1", 1)] * 2,
config={"distributed.scheduler.work-stealing-interval": "10ms"},
)
async def test_stop_plugin(c, s, a, b):
steal = s.extensions["stealing"]
await steal.stop()
futs = c.map(slowinc, range(10), workers=[a.address], allow_other_workers=True)
await c.gather(futs)
assert len(a.data) == 10
# nothing happens
for _ in range(10):
await steal.stop()
@gen_cluster(
client=True,
nthreads=[("127.0.0.1", 1)] * 2,
config={"distributed.scheduler.work-stealing-interval": "1ms"},
)
async def test_stop_in_flight(c, s, a, b):
steal = s.extensions["stealing"]
num_tasks = 10
futs = c.map(
slowinc, range(num_tasks), workers=[a.address], allow_other_workers=True
)
while not steal.in_flight:
await asyncio.sleep(0)
assert steal.in_flight
await steal.stop()
assert not steal.in_flight
assert len(a.data) != num_tasks
del futs
while s.tasks or a.state.tasks or b.state.tasks:
await asyncio.sleep(0.1)
futs = c.map(
slowinc, range(num_tasks), workers=[a.address], allow_other_workers=True
)
await c.gather(futs)
assert len(a.data) == num_tasks
del futs
while s.tasks or a.state.tasks or b.state.tasks:
await asyncio.sleep(0.1)
event = Event()
def block(x, event):
event.wait()
return x + 1
futs = c.map(
block,
range(num_tasks),
event=event,
workers=[a.address],
allow_other_workers=True,
)
while not len(a.state.tasks) == num_tasks:
await asyncio.sleep(0.01)
assert len(b.state.tasks) == 0
await steal.start()
await event.set()
await c.gather(futs)
assert len(a.state.tasks) != num_tasks
assert len(b.state.tasks) != 0
@gen_cluster(
client=True,
nthreads=[("127.0.0.1", 1)] * 2,
config={"distributed.scheduler.work-stealing-interval": "10ms"},
)
async def test_allow_tasks_stolen_before_first_completes(c, s, a, b):
# https://github.com/dask/distributed/issues/5564
from distributed import Semaphore
steal = s.extensions["stealing"]
await steal.stop()
lock = await Semaphore(max_leases=1)
# We will reuse the same function such that multiple dispatches have the
# same task prefix. This ensures that we have tasks queued up but all of
# them are still classified as unknown.
# The lock allows us to control the duration of the first task without
# delaying test runtime or flakyness
def blocked_task(x, lock):
if x == 0:
with lock:
return x
return x
async with lock:
first = c.submit(blocked_task, 0, lock, workers=[a.address], key="f-0")
while first.key not in a.state.tasks:
await asyncio.sleep(0.001)
# Ensure the task is indeed blocked
with pytest.raises(asyncio.TimeoutError):
await asyncio.wait_for(first, 0.01)
more_tasks = c.map(
blocked_task,
# zero is a sentinel for using the lock.
# Start counting at one for non-blocking funcs
range(1, 11),
lock=lock,
workers=[a.address],
key=[f"f-{ix}" for ix in range(1, 11)],
allow_other_workers=True,
)
# All tasks are put on A since this is what we asked for. Only work
# stealing should rebalance the tasks once we allow for it
while not len(a.state.tasks) == 11:
await asyncio.sleep(0.1)
assert len(b.state.tasks) == 0
await steal.start()
# A is still blocked by executing task f-1 so this can only pass if
# workstealing moves the tasks to B
await asyncio.sleep(5)
await c.gather(more_tasks)
assert len(b.data) == 10
await first
@gen_cluster(
client=True,
nthreads=[("127.0.0.1", 1)] * 2,
config={"distributed.scheduler.work-stealing-interval": "10ms"},
)
async def test_eventually_steal_unknown_functions(c, s, a, b):
futures = c.map(
slowinc, range(10), delay=0.1, workers=a.address, allow_other_workers=True
)
await wait(futures)
assert not s.unknown_durations
assert len(a.data) >= 3, [len(a.data), len(b.data)]
assert len(b.data) >= 3, [len(a.data), len(b.data)]
@pytest.mark.skip(reason="")
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)] * 3)
async def test_steal_related_tasks(e, s, a, b, c):
futures = e.map(
slowinc, range(20), delay=0.05, workers=a.address, allow_other_workers=True
)
await wait(futures)
nearby = 0
for f1, f2 in sliding_window(2, futures):
if s.tasks[f1.key].who_has == s.tasks[f2.key].who_has:
nearby += 1
assert nearby > 10
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)] * 10)
async def test_dont_steal_fast_tasks_compute_time(c, s, *workers):
def do_nothing(x, y=None):
pass
xs = c.map(do_nothing, range(10), workers=workers[0].address)
await wait(xs)
futures = c.map(do_nothing, range(100), y=xs)
await wait(futures)
assert len(set.union(*(s.tasks[x.key].who_has for x in xs))) == 1
assert len(s.workers[workers[0].address].has_what) == len(xs) + len(futures)
@gen_cluster(client=True, nthreads=[("", 1)])
async def test_dont_steal_fast_tasks_blocklist(c, s, a):
async with BlockedGetData(s.address) as b:
# create a dependency
x = c.submit(inc, 1, workers=[b.address], key="x")
await wait(x)
# If the blocklist of fast tasks is tracked somewhere else, this needs to be
# changed. This test requires *any* key which is blocked.
from distributed.stealing import fast_tasks
blocked_key = next(iter(fast_tasks))
def fast_blocked(i, x):
# The task should observe a certain computation time such that we can
# ensure that it is not stolen due to the blocking. If it is too
# fast, the standard mechanism shouldn't allow stealing
sleep(0.01)
futures = c.map(
fast_blocked,
range(50),
x=x,
# Submit the task to one worker but allow it to be distributed elsewhere,
# i.e. this is not a task restriction
workers=[a.address],
allow_other_workers=True,
key=blocked_key,
)
while len(s.tasks) < 51:
await asyncio.sleep(0.01)
b.block_get_data.set()
await wait(futures)
# Note: x may now be on a, b, or both, depending if the Active Memory Manager
# got to run or not
ws_a = s.workers[a.address]
for ts in s.tasks.values():
if ts.key.startswith(blocked_key):
assert ts.who_has == {ws_a}
@gen_cluster(client=True, nthreads=[("", 1)], config=NO_AMM)
async def test_new_worker_steals(c, s, a):
await wait(c.submit(slowinc, 1, delay=0.01))
futures = c.map(slowinc, range(100), delay=0.05)
total = c.submit(sum, futures)
while len(a.state.tasks) < 10:
await asyncio.sleep(0.01)
async with Worker(s.address, nthreads=1) as b:
result = await total
assert result == sum(map(inc, range(100)))
for w in (a, b):
assert all(isinstance(v, int) for v in w.data.values())
# This requires AMM to be off. Otherwise, if b reports higher optimistic memory
# than a and `total` happens to be computed on a, then all keys on b will be
# replicated onto a and then deleted by the AMM.
assert b.data
@gen_cluster(client=True)
async def test_work_steal_no_kwargs(c, s, a, b):
await wait(c.submit(slowinc, 1, delay=0.05))
futures = c.map(
slowinc, range(100), workers=a.address, allow_other_workers=True, delay=0.05
)
await wait(futures)
assert 20 < len(a.data) < 80
assert 20 < len(b.data) < 80
total = c.submit(sum, futures)
result = await total
assert result == sum(map(inc, range(100)))
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1), ("127.0.0.1", 2)])
async def test_dont_steal_worker_restrictions(c, s, a, b):
future = c.submit(slowinc, 1, delay=0.10, workers=a.address)
await future
futures = c.map(slowinc, range(100), delay=0.1, workers=a.address)
while len(a.state.tasks) + len(b.state.tasks) < 100:
await asyncio.sleep(0.01)
assert len(a.state.tasks) == 100
assert len(b.state.tasks) == 0
s.extensions["stealing"].balance()
await asyncio.sleep(0.1)
assert len(a.state.tasks) == 100
assert len(b.state.tasks) == 0
@gen_cluster(
client=True, nthreads=[("127.0.0.1", 1), ("127.0.0.1", 2), ("127.0.0.1", 2)]
)
async def test_steal_worker_restrictions(c, s, wa, wb, wc):
future = c.submit(slowinc, 1, delay=0.1, workers={wa.address, wb.address})
await future
ntasks = 100
futures = c.map(slowinc, range(ntasks), delay=0.1, workers={wa.address, wb.address})
while sum(len(w.state.tasks) for w in [wa, wb, wc]) < ntasks:
await asyncio.sleep(0.01)
assert 0 < len(wa.state.tasks) < ntasks
assert 0 < len(wb.state.tasks) < ntasks
assert len(wc.state.tasks) == 0
s.extensions["stealing"].balance()
await asyncio.sleep(0.1)
assert 0 < len(wa.state.tasks) < ntasks
assert 0 < len(wb.state.tasks) < ntasks
assert len(wc.state.tasks) == 0
@pytest.mark.skipif(not LINUX, reason="Need 127.0.0.2 to mean localhost")
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1), ("127.0.0.2", 1)])
async def test_dont_steal_host_restrictions(c, s, a, b):
future = c.submit(slowinc, 1, delay=0.10, workers=a.address)
await future
futures = c.map(slowinc, range(100), delay=0.1, workers="127.0.0.1")
while len(a.state.tasks) + len(b.state.tasks) < 100:
await asyncio.sleep(0.01)
assert len(a.state.tasks) == 100
assert len(b.state.tasks) == 0
result = s.extensions["stealing"].balance()
await asyncio.sleep(0.1)
assert len(a.state.tasks) == 100
assert len(b.state.tasks) == 0
@pytest.mark.skipif(not LINUX, reason="Need 127.0.0.2 to mean localhost")
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1), ("127.0.0.2", 2)])
async def test_steal_host_restrictions(c, s, wa, wb):
future = c.submit(slowinc, 1, delay=0.10, workers=wa.address)
await future
ntasks = 100
futures = c.map(slowinc, range(ntasks), delay=0.1, workers="127.0.0.1")
while len(wa.state.tasks) < ntasks:
await asyncio.sleep(0.01)
assert len(wa.state.tasks) == ntasks
assert len(wb.state.tasks) == 0
async with Worker(s.address, nthreads=1) as wc:
start = time()
while not wc.state.tasks or len(wa.state.tasks) == ntasks:
await asyncio.sleep(0.01)
assert time() < start + 3
await asyncio.sleep(0.1)
assert 0 < len(wa.state.tasks) < ntasks
assert len(wb.state.tasks) == 0
assert 0 < len(wc.state.tasks) < ntasks
@gen_cluster(
client=True, nthreads=[("127.0.0.1", 1, {"resources": {"A": 2}}), ("127.0.0.1", 1)]
)
async def test_dont_steal_resource_restrictions(c, s, a, b):
future = c.submit(slowinc, 1, delay=0.10, workers=a.address)
await future
futures = c.map(slowinc, range(100), delay=0.1, resources={"A": 1})
while len(a.state.tasks) + len(b.state.tasks) < 100:
await asyncio.sleep(0.01)
assert len(a.state.tasks) == 100
assert len(b.state.tasks) == 0
result = s.extensions["stealing"].balance()
await asyncio.sleep(0.1)
assert len(a.state.tasks) == 100
assert len(b.state.tasks) == 0
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1, {"resources": {"A": 2}})])
async def test_steal_resource_restrictions(c, s, a):
future = c.submit(slowinc, 1, delay=0.10, workers=a.address)
await future
futures = c.map(slowinc, range(100), delay=0.2, resources={"A": 1})
while len(a.state.tasks) < 101:
await asyncio.sleep(0.01)
assert len(a.state.tasks) == 101
async with Worker(s.address, nthreads=1, resources={"A": 4}) as b:
while not b.state.tasks or len(a.state.tasks) == 101:
await asyncio.sleep(0.01)
assert len(b.state.tasks) > 0
assert len(a.state.tasks) < 101
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1, {"resources": {"A": 2, "C": 1}})])
async def test_steal_resource_restrictions_asym_diff(c, s, a):
# See https://github.com/dask/distributed/issues/5565
future = c.submit(slowinc, 1, delay=0.10, workers=a.address)
await future
futures = c.map(slowinc, range(100), delay=0.2, resources={"A": 1})
while len(a.state.tasks) < 101:
await asyncio.sleep(0.01)
assert len(a.state.tasks) == 101
async with Worker(s.address, nthreads=1, resources={"A": 4, "B": 5}) as b:
while not b.state.tasks or len(a.state.tasks) == 101:
await asyncio.sleep(0.01)
assert len(b.state.tasks) > 0
assert len(a.state.tasks) < 101
@gen_cluster(
client=True,
nthreads=[("127.0.0.1", 1)] * 5,
config={"distributed.scheduler.work-stealing-interval": "20ms"},
)
async def test_balance_without_dependencies(c, s, *workers):
def slow(x):
y = random.random() * 0.1
sleep(y)
return y
futures = c.map(slow, range(100))
await wait(futures)
durations = [sum(w.data.values()) for w in workers]
assert max(durations) / min(durations) < 3
@gen_cluster(client=True, nthreads=[("127.0.0.1", 4)] * 2)
async def test_dont_steal_executing_tasks(c, s, a, b):
futures = c.map(
slowinc, range(4), delay=0.1, workers=a.address, allow_other_workers=True
)
await wait(futures)
assert len(a.data) == 4
assert len(b.data) == 0
@gen_cluster(client=True)
async def test_dont_steal_executing_tasks_2(c, s, a, b):
steal = s.extensions["stealing"]
future = c.submit(slowinc, 1, delay=0.5, workers=a.address)
while not a.state.executing_count:
await asyncio.sleep(0.01)
steal.move_task_request(
s.tasks[future.key], s.workers[a.address], s.workers[b.address]
)
await asyncio.sleep(0.1)
assert a.state.tasks[future.key].state == "executing"
assert not b.state.executing_count
@gen_cluster(
client=True,
nthreads=[("127.0.0.1", 1)] * 10,
config={
"distributed.scheduler.default-task-durations": {"slowidentity": 0.2},
"distributed.scheduler.work-stealing-interval": "20ms",
},
)
async def test_dont_steal_few_saturated_tasks_many_workers(c, s, a, *rest):
x = c.submit(mul, b"0", 100000000, workers=a.address) # 100 MB
await wait(x)
futures = [c.submit(slowidentity, x, pure=False, delay=0.2) for i in range(2)]
await wait(futures)
assert len(a.data) == 3
assert not any(w.state.tasks for w in rest)
@gen_cluster(
client=True,
nthreads=[("127.0.0.1", 1)] * 10,
worker_kwargs={"memory_limit": MEMORY_LIMIT},
config={
"distributed.scheduler.default-task-durations": {"slowidentity": 0.2},
"distributed.scheduler.work-stealing-interval": "20ms",
},
)
async def test_steal_when_more_tasks(c, s, a, *rest):
x = c.submit(mul, b"0", 50000000, workers=a.address) # 50 MB
await wait(x)
futures = [c.submit(slowidentity, x, pure=False, delay=0.2) for i in range(20)]
start = time()
while not any(w.state.tasks for w in rest):
await asyncio.sleep(0.01)
assert time() < start + 1
@gen_cluster(
client=True,
nthreads=[("127.0.0.1", 1)] * 10,
config={
"distributed.scheduler.default-task-durations": {
"slowidentity": 0.2,
"slow2": 1,
},
"distributed.scheduler.work-stealing-interval": "20ms",
},
)
async def test_steal_more_attractive_tasks(c, s, a, *rest):
def slow2(x):
sleep(1)
return x
x = c.submit(mul, b"0", 100000000, workers=a.address) # 100 MB
await wait(x)
futures = [c.submit(slowidentity, x, pure=False, delay=0.2) for i in range(10)]
future = c.submit(slow2, x, priority=-1)
while not any(w.state.tasks for w in rest):
await asyncio.sleep(0.01)
# good future moves first
assert any(future.key in w.state.tasks for w in rest)
async def assert_balanced(inp, expected, c, s, *workers):
steal = s.extensions["stealing"]
await steal.stop()
ev = Event()
def block(*args, event, **kwargs):
event.wait()
counter = itertools.count()
futures = []
for w, ts in zip(workers, inp):
for t in sorted(ts, reverse=True):
if t:
[dat] = await c.scatter(
[gen_nbytes(int(t * s.bandwidth))], workers=w.address
)
else:
dat = 123
i = next(counter)
f = c.submit(
block,
dat,
event=ev,
key="%d-%d" % (int(t), i),
workers=w.address,
allow_other_workers=True,
pure=False,
priority=-i,
)
futures.append(f)
while len([ts for ts in s.tasks.values() if ts.processing_on]) < len(futures):
await asyncio.sleep(0.001)
try:
for _ in range(10):
steal.balance()
await steal.stop()
result = [
sorted(
(int(key_split(ts.key)) for ts in s.workers[w.address].processing),
reverse=True,
)
for w in workers
]
result2 = sorted(result, reverse=True)
expected2 = sorted(expected, reverse=True)
if result2 == expected2:
# Release the threadpools
return
finally:
await ev.set()
raise Exception(f"Expected: {expected2}; got: {result2}")
@pytest.mark.parametrize(
"inp,expected",
[
pytest.param([[1], []], [[1], []], id="don't move unnecessarily"),
pytest.param([[0, 0], []], [[0], [0]], id="balance"),
pytest.param(
[[0.1, 0.1], []], [[0], [0]], id="balance even if results in even"
),
pytest.param([[0, 0, 0], []], [[0, 0], [0]], id="don't over balance"),
pytest.param(
[[0, 0], [0, 0, 0], []], [[0, 0], [0, 0], [0]], id="move from larger"
),
pytest.param([[0, 0, 0], [0], []], [[0, 0], [0], [0]], id="move to smaller"),
pytest.param([[0, 1], []], [[1], [0]], id="choose easier first"),
pytest.param([[0, 0, 0, 0], [], []], [[0, 0], [0], [0]], id="spread evenly"),
pytest.param([[1, 0, 2, 0], [], []], [[2, 1], [0], [0]], id="move easier"),
pytest.param(
[[1, 1, 1], []], [[1, 1], [1]], id="be willing to move costly items"
),
pytest.param(
[[1, 1, 1, 1], []], [[1, 1, 1], [1]], id="but don't move too many"
),
pytest.param(
[[0, 0], [0, 0], [0, 0], []],
[[0, 0], [0, 0], [0], [0]],
id="no one clearly saturated",
),
# NOTE: There is a timing issue that workers may already start executing
# tasks before we call balance, i.e. the workers will reject the
# stealing request and we end up with a different end result.
# Particularly tests with many input tasks are more likely to fail since
# the test setup takes longer and allows the workers more time to
# schedule a task on the threadpool
pytest.param(
[[4, 2, 2, 2, 2, 1, 1], [4, 2, 1, 1], [], [], []],
[[4, 2, 2, 2], [4, 2, 1, 1], [2], [1], [1]],
id="balance multiple saturated workers",
),
],
)
def test_balance(inp, expected):
async def test_balance_(*args, **kwargs):
await assert_balanced(inp, expected, *args, **kwargs)
config = {
"distributed.scheduler.default-task-durations": {str(i): 1 for i in range(10)}
}
gen_cluster(client=True, nthreads=[("", 1)] * len(inp), config=config)(
test_balance_
)()
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)] * 2, Worker=Nanny, timeout=60)
async def test_restart(c, s, a, b):
futures = c.map(
slowinc, range(100), delay=0.01, workers=a.address, allow_other_workers=True
)
while not s.workers[b.worker_address].processing:
await asyncio.sleep(0.01)
# Unknown tasks are never stolen therefore wait for a measurement
while not any(s.tasks[f.key].state == "memory" for f in futures):
await asyncio.sleep(0.01)
steal = s.extensions["stealing"]
assert any(x for L in steal.stealable.values() for x in L)
await c.restart()
assert not any(x for L in steal.stealable.values() for x in L)
@gen_cluster(client=True)
async def test_steal_twice(c, s, a, b):
x = c.submit(inc, 1, workers=a.address)
await wait(x)
futures = [c.submit(slowadd, x, i, delay=0.2) for i in range(100)]
while len(s.tasks) < 100: # tasks are all allocated
await asyncio.sleep(0.01)
if math.isinf(s.WORKER_SATURATION):
# Wait for b to start stealing tasks
while len(b.state.tasks) < 30:
await asyncio.sleep(0.01)
else:
# Wait for b to complete some tasks
while len(b.data) < 8:
await asyncio.sleep(0.01)
# Army of new workers arrives to help
async with contextlib.AsyncExitStack() as stack:
# This is pretty timing sensitive
workers = [stack.enter_async_context(Worker(s.address)) for _ in range(10)]
workers = await asyncio.gather(*workers)
await wait(futures)
# Note: this includes a and b
empty_workers = [ws for ws in s.workers.values() if not ws.has_what]
assert (
len(empty_workers) < 3
), f"Too many workers without keys ({len(empty_workers)} out of {len(s.workers)})"
# This also tests that some tasks were stolen from b
# (see `while len(b.state.tasks) < 30` above)
# If queuing is enabled, then there was nothing to steal from b,
# so this just tests the queue was balanced not-terribly.
assert max(len(ws.has_what) for ws in s.workers.values()) < 30
assert a.state.in_flight_tasks_count == 0
assert b.state.in_flight_tasks_count == 0
@gen_cluster(
client=True,
nthreads=[("", 1)] * 3,
config={"distributed.worker.memory.pause": False},
)
async def test_paused_workers_must_not_steal(c, s, w1, w2, w3):
w2.status = Status.paused
while s.workers[w2.address].status != Status.paused:
await asyncio.sleep(0.01)
x = c.submit(inc, 1, workers=w1.address)
await wait(x)
futures = [c.submit(slowadd, x, i, delay=0.1) for i in range(10)]
await wait(futures)
assert w1.data
assert not w2.data
assert w3.data
@gen_cluster(client=True)
async def test_dont_steal_already_released(c, s, a, b):
future = c.submit(slowinc, 1, delay=0.05, workers=a.address)
key = future.key
while key not in a.state.tasks:
await asyncio.sleep(0.05)
del future
while key in a.state.tasks and a.state.tasks[key].state != "released":
await asyncio.sleep(0.05)
a.handle_stimulus(StealRequestEvent(key=key, stimulus_id="test"))
assert len(a.batched_stream.buffer) == 1
msg = a.batched_stream.buffer[0]
assert msg["op"] == "steal-response"
assert msg["key"] == key
assert msg["state"] in [None, "released"]
with captured_logger(
logging.getLogger("distributed.stealing"), level=logging.DEBUG
) as stealing_logs:
msg = f"Key released between request and confirm: {key}"
while msg not in stealing_logs.getvalue():
await asyncio.sleep(0.05)
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)] * 2)
async def test_dont_steal_long_running_tasks(c, s, a, b):
def long(delay):
with worker_client() as c:
sleep(delay)
await c.submit(long, 0.1) # learn duration
await c.submit(inc, 1) # learn duration
long_tasks = c.map(long, [0.5, 0.6], workers=a.address, allow_other_workers=True)
while sum(len(ws.long_running) for ws in s.workers.values()) < 2: # let them start
await asyncio.sleep(0.01)
start = time()
while any(t.key in s.extensions["stealing"].key_stealable for t in long_tasks):
await asyncio.sleep(0.01)
assert time() < start + 1
na = a.state.executing_count
nb = b.state.executing_count
incs = c.map(inc, range(100), workers=a.address, allow_other_workers=True)
await asyncio.sleep(0.2)
await wait(long_tasks)
for t in long_tasks:
assert (
sum(log[1] == "executing" for log in a.state.story(t))
+ sum(log[1] == "executing" for log in b.state.story(t))
) <= 1
@gen_cluster(
client=True,
nthreads=[("127.0.0.1", 5)] * 2,
config={"distributed.scheduler.work-stealing-interval": "20ms"},
)
async def test_cleanup_repeated_tasks(c, s, a, b):
class Foo:
pass
await c.submit(slowidentity, -1, delay=0.1)
objects = [c.submit(Foo, pure=False, workers=a.address) for _ in range(50)]
x = c.map(
slowidentity, objects, workers=a.address, allow_other_workers=True, delay=0.05
)
del objects
await wait(x)
assert a.data and b.data
assert len(a.data) + len(b.data) > 10
ws = weakref.WeakSet()
ws.update(a.data.values())
ws.update(b.data.values())
del x
start = time()
while a.data or b.data:
await asyncio.sleep(0.01)
assert time() < start + 1
assert not s.tasks
with profile.lock:
assert not list(ws)
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)] * 2)
async def test_lose_task(c, s, a, b):
with captured_logger("distributed.stealing") as log:
s.periodic_callbacks["stealing"].interval = 1
for _ in range(100):
futures = c.map(
slowinc,
range(10),
delay=0.01,
pure=False,
workers=a.address,
allow_other_workers=True,
)
await asyncio.sleep(0.01)
del futures
out = log.getvalue()
assert "Error" not in out
@pytest.mark.parametrize("interval, expected", [(None, 100), ("500ms", 500), (2, 2)])
@gen_cluster(nthreads=[], config={"distributed.scheduler.work-stealing": False})
async def test_parse_stealing_interval(s, interval, expected):
from distributed.scheduler import WorkStealing
if interval:
ctx = dask.config.set(
{"distributed.scheduler.work-stealing-interval": interval}
)
else:
ctx = contextlib.nullcontext()
with ctx:
ws = WorkStealing(s)
await ws.start()
assert s.periodic_callbacks["stealing"].callback_time == expected
@gen_cluster(client=True)
async def test_balance_with_longer_task(c, s, a, b):
np = pytest.importorskip("numpy")
await c.submit(slowinc, 0, delay=0) # scheduler learns that slowinc is very fast
x = await c.scatter(np.arange(10000), workers=[a.address])
y = c.submit(
slowinc, 1, delay=5, workers=[a.address], priority=1
) # a surprisingly long task
z = c.submit(
slowadd, x, 1, workers=[a.address], allow_other_workers=True, priority=0
) # a task after y, suggesting a, but open to b
# Allow task to be learned, otherwise it will not be stolen
_ = c.submit(slowadd, x, 2, workers=[b.address])
await z
assert not y.done()
assert z.key in b.data
@gen_cluster(client=True)
async def test_blocklist_shuffle_split(c, s, a, b):
pd = pytest.importorskip("pandas")
dd = pytest.importorskip("dask.dataframe")
npart = 10
df = dd.from_pandas(pd.DataFrame({"A": range(100), "B": 1}), npartitions=npart)
graph = df.shuffle(
"A",
shuffle="tasks",
# If we don't have enough partitions, we'll fall back to a simple shuffle
max_branch=npart - 1,
).sum()
res = c.compute(graph)
while not s.tasks:
await asyncio.sleep(0.005)
prefixes = set(s.task_prefixes.keys())
from distributed.stealing import fast_tasks
blocked = fast_tasks & prefixes
assert blocked
assert any(["split" in prefix for prefix in blocked])
stealable = s.extensions["stealing"].stealable
while not res.done():
for tasks_per_level in stealable.values():
for tasks in tasks_per_level:
for ts in tasks:
assert ts.prefix.name not in fast_tasks
assert "split" not in ts.prefix.name
await asyncio.sleep(0.001)
await res
@gen_cluster(
client=True,
nthreads=[("", 1)] * 3,
config={
"distributed.scheduler.work-stealing-interval": 1_000_000,
},
)
async def test_steal_concurrent_simple(c, s, *workers):
steal = s.extensions["stealing"]
w0 = workers[0]
w1 = workers[1]
w2 = workers[2]
futs1 = c.map(
slowinc,
range(10),
key=[f"f1-{ix}" for ix in range(10)],
workers=[w0.address],
)
while not w0.state.tasks:
await asyncio.sleep(0.1)
# ready is a heap but we don't need last, just not the next
victim_key = w0.state.ready.peekright().key
victim_ts = s.tasks[victim_key]
ws0 = s.workers[w0.address]
ws1 = s.workers[w1.address]
ws2 = s.workers[w2.address]
steal.move_task_request(victim_ts, ws0, ws1)
steal.move_task_request(victim_ts, ws0, ws2)
await c.gather(futs1)
# First wins
assert ws1.has_what
assert not ws2.has_what
@gen_cluster(client=True)
async def test_steal_reschedule_reset_in_flight_occupancy(c, s, *workers):
# https://github.com/dask/distributed/issues/5370
steal = s.extensions["stealing"]
await steal.stop()
w0 = workers[0]
roots = c.map(
inc,
range(6),
key=[f"r-{ix}" for ix in range(6)],
)
def block(x, event):
event.wait()
return x + 1
event = Event()
futs1 = [
c.submit(block, r, event=event, key=f"f{ir}-{ix}")
for ir, r in enumerate(roots)
for ix in range(4)
]
while not w0.state.ready:
await asyncio.sleep(0.01)
# ready is a heap but we don't need last, just not the next
victim_key = w0.state.ready.peekright().key
victim_ts = s.tasks[victim_key]
wsA = victim_ts.processing_on
other_workers = [ws for ws in s.workers.values() if ws != wsA]
wsB = other_workers[0]
steal.move_task_request(victim_ts, wsA, wsB)
s._reschedule(victim_key, stimulus_id="test")
await event.set()
await c.gather(futs1)
del futs1
assert all(v == 0 for v in steal.in_flight_occupancy.values())
@gen_cluster(
client=True,
config={
"distributed.scheduler.work-stealing-interval": 10,
},
)
async def test_get_story(c, s, a, b):
steal = s.extensions["stealing"]
futs = c.map(slowinc, range(100), workers=[a.address], allow_other_workers=True)
collect = c.submit(sum, futs)
await collect
key = next(iter(b.state.tasks))
ts = s.tasks[key]
msgs = steal.story(key)
msgs_ts = steal.story(ts)
assert msgs
assert msgs == msgs_ts
assert all(isinstance(m, tuple) for m in msgs)
@gen_cluster(
client=True,
config={
"distributed.scheduler.work-stealing-interval": 1_000_000,
},
)
async def test_steal_worker_dies_same_ip(c, s, w0, w1):
# https://github.com/dask/distributed/issues/5370
steal = s.extensions["stealing"]
ev = Event()
futs1 = c.map(
lambda _, ev: ev.wait(),
range(10),
ev=ev,
key=[f"f1-{ix}" for ix in range(10)],
workers=[w0.address],
allow_other_workers=True,
)
while not w0.active_keys:
await asyncio.sleep(0.01)
# ready is a heap but we don't need last, just not the next
victim_key = w0.state.ready.peekright().key
victim_ts = s.tasks[victim_key]
wsA = victim_ts.processing_on
assert wsA.address == w0.address
wsB = s.workers[w1.address]
steal.move_task_request(victim_ts, wsA, wsB)
len_before = len(s.events["stealing"])
with freeze_batched_send(w0.batched_stream):
while not any(
isinstance(event, StealRequestEvent) for event in w0.state.stimulus_log
):
await asyncio.sleep(0.1)
async with contextlib.AsyncExitStack() as stack:
# Block batched stream of w0 to ensure the steal-confirmation doesn't
# arrive at the scheduler before we want it to
await w1.close()
# Kill worker wsB
# Restart new worker with same IP, name, etc.
while w1.address in s.workers:
await asyncio.sleep(0.1)
w_new = await stack.enter_async_context(
Worker(
s.address,
host=w1.host,
port=w1.port,
name=w1.name,
)
)
wsB2 = s.workers[w_new.address]
assert wsB2.address == wsB.address
assert wsB2 is not wsB
assert wsB2 != wsB
assert hash(wsB2) != hash(wsB)
# Wait for the steal response to arrive
while len_before == len(s.events["stealing"]):
await asyncio.sleep(0.1)
assert victim_ts.processing_on != wsB
await w_new.close(executor_wait=False)
await ev.set()
await c.gather(futs1)
@gen_cluster(
client=True,
nthreads=[("", 1)] * 3,
config={
"distributed.scheduler.work-stealing-interval": 1_000_000,
},
)
async def test_reschedule_concurrent_requests_deadlock(c, s, *workers):
# https://github.com/dask/distributed/issues/5370
steal = s.extensions["stealing"]
w0 = workers[0]
ev = Event()
futs1 = c.map(
lambda _, ev: ev.wait(),
range(10),
ev=ev,
key=[f"f1-{ix}" for ix in range(10)],
workers=[w0.address],
allow_other_workers=True,
)
while not w0.active_keys:
await asyncio.sleep(0.01)
# ready is a heap but we don't need last, just not the next
victim_key = list(w0.active_keys)[0]
victim_ts = s.tasks[victim_key]
wsA = victim_ts.processing_on
other_workers = [ws for ws in s.workers.values() if ws != wsA]
wsB = other_workers[0]
wsC = other_workers[1]
steal.move_task_request(victim_ts, wsA, wsB)
s.set_restrictions(worker={victim_key: [wsB.address]})
s._reschedule(victim_key, stimulus_id="test")
assert wsB == victim_ts.processing_on
# move_task_request is not responsible for respecting worker restrictions
steal.move_task_request(victim_ts, wsB, wsC)
# Let tasks finish
await ev.set()
await c.gather(futs1)
assert victim_ts.who_has != {wsC}
msgs = steal.story(victim_ts)
msgs = [msg[:-1] for msg in msgs] # Remove random IDs
# There are three possible outcomes
expect1 = [
("stale-response", victim_key, "executing", wsA.address),
("already-computing", victim_key, "executing", wsB.address, wsC.address),
]
expect2 = [
("already-computing", victim_key, "executing", wsB.address, wsC.address),
("already-aborted", victim_key, "executing", wsA.address),
]
# This outcome appears only in ~2% of the runs
expect3 = [
("already-computing", victim_key, "executing", wsB.address, wsC.address),
("already-aborted", victim_key, "memory", wsA.address),
]
assert msgs in (expect1, expect2, expect3)
@pytest.mark.skip("executing heartbeats not considered yet")
@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)] * 3)
async def test_correct_bad_time_estimate(c, s, *workers):
"""Initial time estimation causes the task to not be considered for
stealing. Following occupancy readjustments will re-enlist the keys since
the duration estimate is now significant.
This is done during reevaluate occupancy
"""
steal = s.extensions["stealing"]
future = c.submit(slowinc, 1, delay=0)
await wait(future)
futures = [c.submit(slowinc, future, delay=0.1, pure=False) for _ in range(20)]
while len(s.tasks) < 21:
await asyncio.sleep(0)
assert not any(s.tasks[f.key] in steal.key_stealable for f in futures)
await asyncio.sleep(0.5)
assert any(s.tasks[f.key] in steal.key_stealable for f in futures)
await wait(futures)
assert all(w.data for w in workers), [sorted(w.data) for w in workers]
@gen_cluster(client=True)
async def test_steal_stimulus_id_unique(c, s, a, b):
steal = s.extensions["stealing"]
num_futs = 1_000
async with Lock() as lock:
def blocked(x, lock):
lock.acquire()
# Setup all tasks on worker 0 such that victim/thief relation is the
# same for all tasks.
futures = c.map(blocked, range(num_futs), lock=lock, workers=[a.address])
# Ensure all tasks are assigned to the worker since otherwise the
# move_task_request fails.
while len(a.state.tasks) != num_futs:
await asyncio.sleep(0.1)
tasks = [s.tasks[f.key] for f in futures]
w0 = s.workers[a.address]
w1 = s.workers[b.address]
# Generating the move task requests as fast as possible increases the
# chance of duplicates if the uniqueness is not guaranteed.
for ts in tasks:
steal.move_task_request(ts, w0, w1)
# Values stored in in_flight are used for response verification.
# Therefore all stimulus IDs are stored here and must be unique
stimulus_ids = {dct["stimulus_id"] for dct in steal.in_flight.values()}
assert len(stimulus_ids) == num_futs
await c.cancel(futures)
def test_steal_worker_state(ws_with_running_task):
ws = ws_with_running_task
ws.handle_stimulus(FreeKeysEvent(keys=["x"], stimulus_id="s1"))
assert ws.available_resources == {"R": 0}
assert ws.tasks["x"].state == "cancelled"
instructions = ws.handle_stimulus(ExecuteSuccessEvent.dummy("x", stimulus_id="s2"))
assert instructions == [
DigestMetric(stimulus_id="s2", name="compute-duration", value=1.0)
]
assert "x" not in ws.tasks
assert "x" not in ws.data
assert ws.available_resources == {"R": 1}
@pytest.mark.slow()
@gen_cluster(nthreads=[("", 1)] * 4, client=True)
async def test_steal_very_fast_tasks(c, s, *workers):
# Ensure that very fast tasks are allowed to be stolen
root = dask.delayed(lambda n: "x" * n)(
dask.utils.parse_bytes("1MiB"), dask_key_name="root"
)
@dask.delayed
def func(*args):
import time
time.sleep(0.002)
ntasks = 1000
results = [func(root, i) for i in range(ntasks)]
futs = c.compute(results)
await c.gather(futs)
ntasks_per_worker = np.array([len(w.data) for w in workers])
ideal = ntasks / len(workers)
assert (ntasks_per_worker > ideal * 0.5).all(), (ideal, ntasks_per_worker)
assert (ntasks_per_worker < ideal * 1.5).all(), (ideal, ntasks_per_worker)
@pytest.mark.flaky(reruns=2, reruns_delay=10)
@pytest.mark.parametrize(
"cost, ntasks, expect_steal",
[
pytest.param(10, 5, False, id="not enough work to steal"),
pytest.param(10, 10, True, id="enough work to steal"),
pytest.param(20, 10, False, id="not enough work for increased cost"),
],
)
def test_balance_expensive_tasks(cost, ntasks, expect_steal):
dependencies = {"a": cost, "b": cost}
dependency_placement = [["a"], ["b"]]
task_placement = [[["a", "b"]] * ntasks, []]
def _correct_placement(actual):
actual_task_counts = [len(placed) for placed in actual]
return sum(actual_task_counts) == ntasks and (
(actual_task_counts[1] > 0) == expect_steal
)
_run_dependency_balance_test(
dependencies,
dependency_placement,
task_placement,
_correct_placement,
)
def test_balance_uneven_without_replica():
dependencies = {"a": 1}
dependency_placement = [["a"], []]
task_placement = [[["a"], ["a"]], []]
def _correct_placement(actual):
actual_task_counts = [len(placed) for placed in actual]
return actual_task_counts == [2, 0]
_run_dependency_balance_test(
dependencies,
dependency_placement,
task_placement,
_correct_placement,
)
def test_balance_eventually_steals_large_dependency_without_replica():
dependencies = {"a": 10}
dependency_placement = [["a"], []]
task_placement = [[["a"]] * 20, []]
def _correct_placement(actual):
actual_task_counts = [len(placed) for placed in actual]
return sum(actual_task_counts) == 20 and actual_task_counts[1] > 0
_run_dependency_balance_test(
dependencies,
dependency_placement,
task_placement,
_correct_placement,
)
def test_balance_even_with_replica():
dependencies = {"a": 1}
dependency_placement = [["a"], ["a"]]
task_placement = [[["a"], ["a"]], []]
def _correct_placement(actual):
actual_task_counts = [len(placed) for placed in actual]
return actual_task_counts == [
1,
1,
]
_run_dependency_balance_test(
dependencies,
dependency_placement,
task_placement,
_correct_placement,
)
def test_balance_to_replica():
dependencies = {"a": 2}
dependency_placement = [["a"], ["a"], []]
task_placement = [[["a"], ["a"]], [], []]
def _correct_placement(actual):
actual_task_counts = [len(placed) for placed in actual]
return actual_task_counts == [
1,
1,
0,
]
_run_dependency_balance_test(
dependencies,
dependency_placement,
task_placement,
_correct_placement,
)
def test_balance_multiple_to_replica():
dependencies = {"a": 6}
dependency_placement = [["a"], ["a"], []]
task_placement = [[["a"], ["a"], ["a"], ["a"], ["a"], ["a"], ["a"], ["a"]], [], []]
def _correct_placement(actual):
actual_task_counts = [len(placed) for placed in actual]
# FIXME: A better task placement would be even but the current balancing
# logic aborts as soon as a worker is no longer classified as idle
# return actual_task_counts == [
# 4,
# 4,
# 0,
# ]
return actual_task_counts == [
6,
2,
0,
]
_run_dependency_balance_test(
dependencies,
dependency_placement,
task_placement,
_correct_placement,
)
def test_balance_to_larger_dependency():
dependencies = {"a": 2, "b": 1}
dependency_placement = [["a", "b"], ["a"], ["b"]]
task_placement = [[["a", "b"], ["a", "b"], ["a", "b"]], [], []]
def _correct_placement(actual):
actual_task_counts = [len(placed) for placed in actual]
return actual_task_counts == [
2,
1,
0,
]
_run_dependency_balance_test(
dependencies,
dependency_placement,
task_placement,
_correct_placement,
)
def test_balance_prefers_busier_with_dependency():
dependencies = {"a": 5, "b": 1}
dependency_placement = [["a"], ["a", "b"], []]
task_placement = [
[["a"], ["a"], ["a"], ["a"], ["a"], ["a"]],
[["b"]],
[],
]
def _correct_placement(actual):
actual_task_placements = [sorted(placed) for placed in actual]
# FIXME: A better task placement would be even but the current balancing
# logic aborts as soon as a worker is no longer classified as idle
# return actual_task_placements == [
# [["a"], ["a"], ["a"], ["a"]],
# [["a"], ["a"], ["b"]],
# [],
# ]
return actual_task_placements == [
[["a"], ["a"], ["a"], ["a"], ["a"]],
[["a"], ["b"]],
[],
]
_run_dependency_balance_test(
dependencies,
dependency_placement,
task_placement,
_correct_placement,
# This test relies on disabling queueing to flag workers as idle
config={
"distributed.scheduler.worker-saturation": float("inf"),
},
)
def _run_dependency_balance_test(
dependencies: Mapping[str, int],
dependency_placement: list[list[str]],
task_placement: list[list[list[str]]],
correct_placement_fn: Callable[[list[list[list[str]]]], bool],
config: dict | None = None,
) -> None:
"""Run a test for balancing with task dependencies according to the provided
specifications.
This method executes the test logic for all permutations of worker placements
and generates a new cluster for each one.
Parameters
----------
dependencies
Mapping of task dependencies to their weight.
dependency_placement
List of list of dependencies to be placed on the worker corresponding
to the index of the outer list.
task_placement
List of list of tasks to be placed on the worker corresponding to the
index of the outer list. Each task is a list of names of dependencies.
correct_placement_fn
Callable used to determine if stealing placed the tasks as expected.
config
Optional configuration to apply to the test.
See Also
--------
_dependency_balance_test_permutation
"""
nworkers = len(task_placement)
for permutation in itertools.permutations(range(nworkers)):
async def _run(
*args,
permutation=permutation,
**kwargs,
):
await _dependency_balance_test_permutation(
dependencies,
dependency_placement,
task_placement,
correct_placement_fn,
permutation,
*args,
**kwargs,
)
gen_cluster(
client=True,
nthreads=[("", 1)] * len(task_placement),
config=merge(
NO_AMM,
config or {},
{
"distributed.scheduler.unknown-task-duration": "1s",
},
),
)(_run)()
async def _dependency_balance_test_permutation(
dependencies: Mapping[str, int],
dependency_placement: list[list[str]],
task_placement: list[list[list[str]]],
correct_placement_fn: Callable[[list[list[list[str]]]], bool],
permutation: list[int],
c: Client,
s: Scheduler,
*workers: Worker,
) -> None:
"""Run a test for balancing with task dependencies according to the provided
specifications and worker permutations.
Parameters
----------
dependencies
Mapping of task dependencies to their weight.
dependency_placement
List of list of dependencies to be placed on the worker corresponding
to the index of the outer list.
task_placement
List of list of tasks to be placed on the worker corresponding to the
index of the outer list. Each task is a list of names of dependencies.
correct_placement_fn
Callable used to determine if stealing placed the tasks as expected.
permutation
Permutation of workers to use for this run.
See Also
--------
_run_dependency_balance_test
"""
steal = s.extensions["stealing"]
await steal.stop()
inverse = [permutation.index(i) for i in range(len(permutation))]
permutated_dependency_placement = [dependency_placement[i] for i in permutation]
permutated_task_placement = [task_placement[i] for i in permutation]
dependency_futures = await _place_dependencies(
dependencies, permutated_dependency_placement, c, s, workers
)
ev, futures = await _place_tasks(
permutated_task_placement,
permutated_dependency_placement,
dependency_futures,
c,
s,
workers,
)
# Re-evaluate idle/saturated classification to avoid outdated classifications due to
# the initialization order of workers. On a real cluster, this would get constantly
# updated by tasks being added or completing.
for ws in s.workers.values():
s.check_idle_saturated(ws)
try:
for _ in range(20):
steal.balance()
await steal.stop()
permutated_actual_placement = _get_task_placement(s, workers)
actual_placement = [permutated_actual_placement[i] for i in inverse]
if correct_placement_fn(actual_placement):
return
finally:
# Release the threadpools
await ev.set()
await c.gather(futures)
raise AssertionError(actual_placement, permutation)
async def _place_dependencies(
dependencies: Mapping[str, int],
placement: list[list[str]],
c: Client,
s: Scheduler,
workers: Sequence[Worker],
) -> dict[str, Future]:
"""Places the dependencies on the workers as specified.
Parameters
----------
dependencies
Mapping of task dependencies to their weight.
placement
List of list of dependencies to be placed on the worker corresponding to the
index of the outer list.
Returns
-------
Dictionary of futures matching the input dependencies.
See Also
--------
_run_dependency_balance_test
"""
dependencies_to_workers = defaultdict(set)
for worker_idx, placed in enumerate(placement):
for dependency in placed:
dependencies_to_workers[dependency].add(workers[worker_idx].address)
futures = {}
for name, multiplier in dependencies.items():
worker_addresses = dependencies_to_workers[name]
futs = await c.scatter(
{name: gen_nbytes(int(multiplier * s.bandwidth))},
workers=worker_addresses,
broadcast=True,
)
futures[name] = futs[name]
await c.gather(futures.values())
_assert_dependency_placement(placement, workers)
return futures
def _assert_dependency_placement(expected, workers):
"""Assert that dependencies are placed on the workers as expected."""
actual = []
for worker in workers:
actual.append(list(worker.state.tasks.keys()))
assert actual == expected
async def _place_tasks(
placement: list[list[list[str]]],
dependency_placement: list[list[str]],
dependency_futures: Mapping[str, Future],
c: Client,
s: Scheduler,
workers: Sequence[Worker],
) -> tuple[Event, list[Future]]:
"""Places the tasks on the workers as specified.
Parameters
----------
placement
List of list of tasks to be placed on the worker corresponding to the
index of the outer list. Each task is a list of names of dependencies.
dependency_placement
List of list of dependencies to be placed on the worker corresponding to the
index of the outer list.
dependency_futures
Mapping of dependency names to their corresponding futures.
Returns
-------
Tuple of the event blocking the placed tasks and list of futures matching
the input task placement.
See Also
--------
_run_dependency_balance_test
"""
ev = Event()
def block(*args, event, **kwargs):
event.wait()
counter = itertools.count()
futures = []
for worker_idx, tasks in enumerate(placement):
for dependencies in tasks:
i = next(counter)
dep_key = "".join(sorted(dependencies))
key = f"{dep_key}-{i}"
f = c.submit(
block,
[dependency_futures[dependency] for dependency in dependencies],
event=ev,
key=key,
workers=workers[worker_idx].address,
allow_other_workers=True,
pure=False,
priority=-i,
)
futures.append(f)
while len([ts for ts in s.tasks.values() if ts.processing_on]) < len(futures):
await asyncio.sleep(0.001)
while any(
len(w.state.tasks) < (len(tasks) + len(dependencies))
for w, dependencies, tasks in zip(workers, dependency_placement, placement)
):
await asyncio.sleep(0.001)
assert_task_placement(placement, s, workers)
return ev, futures
def _get_task_placement(
s: Scheduler, workers: Iterable[Worker]
) -> list[list[list[str]]]:
"""Return the placement of tasks on this worker"""
actual = []
for w in workers:
actual.append(
[list(key_split(ts.key)) for ts in s.workers[w.address].processing]
)
return _deterministic_placement(actual)
def _equal_placement(left, right):
"""Return True IFF the two input placements are equal."""
return _deterministic_placement(left) == _deterministic_placement(right)
def _deterministic_placement(placement):
"""Return a deterministic ordering of the tasks or dependencies on each worker."""
return [sorted(placed) for placed in placement]
def assert_task_placement(expected, s, workers):
"""Assert that tasks are placed on the workers as expected."""
actual = _get_task_placement(s, workers)
assert _equal_placement(actual, expected)
# Reproducer from https://github.com/dask/distributed/issues/6573
@gen_cluster(
client=True,
nthreads=[("", 1)] * 4,
)
async def test_trivial_workload_should_not_cause_work_stealing(c, s, *workers):
root = dask.delayed(lambda n: "x" * n)(parse_bytes("1MiB"), dask_key_name="root")
results = [dask.delayed(lambda *args: None)(root, i) for i in range(1000)]
futs = c.compute(results)
await c.gather(futs)
events = s.events["stealing"]
assert len(events) == 0
|