1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
|
#include "../src/span_buffer.h"
#include <catch2/catch.hpp>
#include "../src/sample.h"
#include "mocks.h"
using namespace datadog::opentracing;
TEST_CASE("span buffer") {
auto logger = std::make_shared<MockLogger>();
auto sampler = std::make_shared<RulesSampler>();
auto writer = std::make_shared<MockWriter>(sampler);
auto buffer =
std::make_shared<SpanBuffer>(logger, writer, sampler, nullptr, SpanBufferOptions{});
auto context_from_span = [](const TestSpanData& span) -> SpanContext {
auto logger = std::make_shared<const MockLogger>();
return SpanContext{logger, span.span_id, span.trace_id, "", {}};
};
SECTION("can write a single-span trace") {
auto span = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420, 420, 0,
123, 456, 0);
buffer->registerSpan(context_from_span(*span));
buffer->finishSpan(std::move(span));
REQUIRE(writer->traces.size() == 1);
REQUIRE(writer->traces[0].size() == 1);
auto& result = writer->traces[0][0];
REQUIRE(result->name == "name");
REQUIRE(result->service == "service");
REQUIRE(result->resource == "resource");
REQUIRE(result->type == "type");
REQUIRE(result->span_id == 420);
REQUIRE(result->trace_id == 420);
REQUIRE(result->parent_id == 0);
REQUIRE(result->error == 0);
REQUIRE(result->start == 123);
REQUIRE(result->duration == 456);
REQUIRE(result->meta == std::unordered_map<std::string, std::string>{});
}
SECTION("can write a multi-span trace") {
auto rootSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420, 420,
0, 123, 456, 0);
buffer->registerSpan(context_from_span(*rootSpan));
auto childSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420,
421, 0, 124, 455, 0);
buffer->registerSpan(context_from_span(*childSpan));
buffer->finishSpan(std::move(childSpan));
buffer->finishSpan(std::move(rootSpan));
REQUIRE(writer->traces.size() == 1);
REQUIRE(writer->traces[0].size() == 2);
// Although order doesn't actually matter.
REQUIRE(writer->traces[0][0]->span_id == 421);
REQUIRE(writer->traces[0][1]->span_id == 420);
}
SECTION("can write a multi-span trace, even if the root finishes before a child") {
auto rootSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420, 420,
0, 123, 456, 0);
buffer->registerSpan(context_from_span(*rootSpan));
auto childSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420,
421, 0, 124, 455, 0);
buffer->registerSpan(context_from_span(*childSpan));
buffer->finishSpan(std::move(rootSpan));
buffer->finishSpan(std::move(childSpan));
REQUIRE(writer->traces.size() == 1);
REQUIRE(writer->traces[0].size() == 2);
// Although order doesn't actually matter.
REQUIRE(writer->traces[0][0]->span_id == 420);
REQUIRE(writer->traces[0][1]->span_id == 421);
}
SECTION("doesn't write an unfinished trace") {
auto rootSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420, 420,
0, 123, 456, 0);
buffer->registerSpan(context_from_span(*rootSpan));
auto childSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420,
421, 0, 124, 455, 0);
buffer->registerSpan(context_from_span(*childSpan));
buffer->finishSpan(std::move(childSpan));
REQUIRE(writer->traces.size() == 0); // rootSpan still outstanding
auto childSpan2 = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420,
422, 0, 125, 457, 0);
buffer->registerSpan(context_from_span(*childSpan2));
buffer->finishSpan(std::move(rootSpan));
// Root span finished, but *after* childSpan2 was registered, so childSpan2 still oustanding.
REQUIRE(writer->traces.size() == 0);
// Ok now we're done!
buffer->finishSpan(std::move(childSpan2));
REQUIRE(writer->traces.size() == 1);
REQUIRE(writer->traces[0].size() == 3);
}
SECTION("discards spans written without a corresponding startSpan call") {
// Redirect cerr, so the the terminal output doesn't imply failure.
std::stringstream error_message;
std::streambuf* stderr = std::cerr.rdbuf(error_message.rdbuf());
SECTION("not even a trace") {
auto rootSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420,
420, 0, 123, 456, 0);
buffer->finishSpan(std::move(rootSpan));
REQUIRE(writer->traces.size() == 0);
}
SECTION("there's a trace but no startSpan call") {
auto rootSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420,
420, 0, 123, 456, 0);
buffer->registerSpan(context_from_span(*rootSpan));
auto childSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420,
421, 0, 124, 455, 0);
buffer->finishSpan(std::move(childSpan));
buffer->finishSpan(std::move(rootSpan));
REQUIRE(writer->traces.size() == 1);
REQUIRE(writer->traces[0].size() == 1); // Only rootSpan got written.
REQUIRE(writer->traces[0][0]->span_id == 420);
}
std::cerr.rdbuf(stderr); // Restore stderr.
}
SECTION("spans written after a trace is submitted just start a new trace") {
auto rootSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420, 420,
0, 123, 456, 0);
buffer->registerSpan(context_from_span(*rootSpan));
buffer->finishSpan(std::move(rootSpan));
REQUIRE(writer->traces.size() == 1);
auto childSpan = std::make_unique<TestSpanData>("type", "service", "resource", "name", 420,
421, 0, 123, 456, 0);
buffer->registerSpan(context_from_span(*childSpan));
buffer->finishSpan(std::move(childSpan));
REQUIRE(writer->traces.size() == 2);
}
SECTION("thread safe") {
std::vector<std::thread> trace_writers;
// Buffer 5 traces at once.
for (uint64_t trace_id = 10; trace_id <= 50; trace_id += 10) {
trace_writers.emplace_back(
[&](uint64_t trace_id) {
// For each trace, buffer 5 spans at once.
std::vector<std::thread> span_writers;
for (uint64_t span_id = trace_id; span_id < trace_id + 5; span_id++) {
span_writers.emplace_back(
[&](uint64_t span_id) {
auto span = std::make_unique<TestSpanData>(
"type", "service", "resource", "name", trace_id, span_id, 0, 123, 456, 0);
buffer->registerSpan(context_from_span(*span));
},
span_id);
}
// Wait for all spans to be registered before finishing them.
for (std::thread& span_writer : span_writers) {
span_writer.join();
}
span_writers.clear();
for (uint64_t span_id = trace_id; span_id < trace_id + 5; span_id++) {
span_writers.emplace_back(
[&](uint64_t span_id) {
auto span = std::make_unique<TestSpanData>(
"type", "service", "resource", "name", trace_id, span_id, 0, 123, 456, 0);
buffer->finishSpan(std::move(span));
},
span_id);
}
for (std::thread& span_writer : span_writers) {
span_writer.join();
}
},
trace_id);
}
for (std::thread& trace_writer : trace_writers) {
trace_writer.join();
}
// Mostly we REQUIRE that this doesn't SIGABRT :D
REQUIRE(writer->traces.size() == 5);
for (int i = 0; i < 5; i++) {
REQUIRE(writer->traces[i].size() == 5);
}
}
}
|
