File: fix_memleak_in_my_wnck_get_viewport_start.patch

package info (click to toggle)
devilspie 0.23-5
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 1,184 kB
  • sloc: ansic: 2,392; sh: 1,166; makefile: 57
file content (28 lines) | stat: -rw-r--r-- 831 bytes parent folder | download | duplicates (3) 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
 
Author: Andreas Rönnquist <gusnan@gusnan.se>
Description: Fix my_wnck_get_viewport memleak
 Fixes a memleak in the my_wnck_get_viewport_start function where the result
 from my_wnck_get_cardinal_list wasn't freed correctly. It is already fixed
 in upstream git repository, but not in a release yet - See
 https://git.gnome.org/browse/devilspie/commit/?id=6b1af1227658ac333bfab407e02f3de6452d6de1
--- a/src/xutils.c
+++ b/src/xutils.c
@@ -286,13 +286,14 @@
 {
   gulong *list;
   int len;
+  int result = -1;
 
   my_wnck_get_cardinal_list (RootWindowOfScreen (my_wnck_window_get_xscreen (win)),
                             my_wnck_atom_get ("_NET_DESKTOP_VIEWPORT"), &list, &len);
 
-  if (len > 0) {
-    return list[0];
-  } else {
-    return -1;
-  }
+  if (len > 0) result=list[0];
+
+  g_free(list);
+
+  return result;
 }