1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404
|
"""
Implement the command-line tool interface for diff_quality.
"""
import argparse
import contextlib
import io
import logging
import os
import sys
import pluggy
import diff_cover
from diff_cover import hookspecs
from diff_cover.config_parser import Tool, get_config
from diff_cover.diff_cover_tool import (
COMPARE_BRANCH_HELP,
CONFIG_FILE_HELP,
CSS_FILE_HELP,
DIFF_RANGE_NOTATION_HELP,
EXCLUDE_HELP,
FAIL_UNDER_HELP,
FORMAT_HELP,
HTML_REPORT_DEFAULT_PATH,
IGNORE_STAGED_HELP,
IGNORE_UNSTAGED_HELP,
IGNORE_WHITESPACE,
INCLUDE_UNTRACKED_HELP,
JSON_REPORT_DEFAULT_PATH,
MARKDOWN_REPORT_DEFAULT_PATH,
QUIET_HELP,
TOTAL_PERCENT_FLOAT_HELP,
format_type,
handle_old_format,
)
from diff_cover.diff_reporter import GitDiffReporter
from diff_cover.git_diff import GitDiffTool
from diff_cover.git_path import GitPathTool
from diff_cover.report_generator import (
HtmlQualityReportGenerator,
JsonReportGenerator,
MarkdownQualityReportGenerator,
StringQualityReportGenerator,
)
from diff_cover.util import open_file
from diff_cover.violationsreporters.base import QualityReporter
from diff_cover.violationsreporters.java_violations_reporter import (
CheckstyleXmlDriver,
FindbugsXmlDriver,
PmdXmlDriver,
checkstyle_driver,
)
from diff_cover.violationsreporters.violations_reporter import (
ClangFormatDriver,
CppcheckDriver,
EslintDriver,
PylintDriver,
flake8_driver,
jshint_driver,
mypy_driver,
pycodestyle_driver,
pydocstyle_driver,
pyflakes_driver,
ruff_check_driver,
shellcheck_driver,
)
QUALITY_DRIVERS = {
"clang": ClangFormatDriver(),
"cppcheck": CppcheckDriver(),
"mypy": mypy_driver,
"pycodestyle": pycodestyle_driver,
"pyflakes": pyflakes_driver,
"pylint": PylintDriver(),
"ruff.check": ruff_check_driver,
"flake8": flake8_driver,
"jshint": jshint_driver,
"eslint": EslintDriver(),
"pydocstyle": pydocstyle_driver,
"checkstyle": checkstyle_driver,
"checkstylexml": CheckstyleXmlDriver(),
"findbugs": FindbugsXmlDriver(),
"pmd": PmdXmlDriver(),
"shellcheck": shellcheck_driver,
}
VIOLATION_CMD_HELP = (
f"Which code quality tool to use ({'/'.join(sorted(QUALITY_DRIVERS))})"
)
INPUT_REPORTS_HELP = "Which violations reports to use"
OPTIONS_HELP = "Options to be passed to the violations tool"
INCLUDE_HELP = "Files to include (glob pattern)"
REPORT_ROOT_PATH_HELP = "The root path used to generate a report"
LOGGER = logging.getLogger(__name__)
def parse_quality_args(argv):
"""
Parse command line arguments, returning a dict of
valid options:
{
'violations': pycodestyle| pyflakes | flake8 | pylint | ...,
'html_report': None | HTML_REPORT,
'external_css_file': None | CSS_FILE,
}
where `HTML_REPORT` and `CSS_FILE` are paths.
"""
parser = argparse.ArgumentParser(description=diff_cover.QUALITY_DESCRIPTION)
parser.add_argument(
"--violations", metavar="TOOL", type=str, help=VIOLATION_CMD_HELP, required=True
)
parser.add_argument(
"--format",
type=format_type,
default="",
help=FORMAT_HELP,
)
parser.add_argument(
"--external-css-file",
metavar="FILENAME",
type=str,
help=CSS_FILE_HELP,
)
parser.add_argument(
"--compare-branch",
metavar="BRANCH",
type=str,
help=COMPARE_BRANCH_HELP,
)
parser.add_argument("input_reports", type=str, nargs="*", help=INPUT_REPORTS_HELP)
parser.add_argument("--options", type=str, nargs="?", help=OPTIONS_HELP)
parser.add_argument(
"--fail-under", metavar="SCORE", type=float, help=FAIL_UNDER_HELP
)
parser.add_argument(
"--ignore-staged", action="store_true", default=None, help=IGNORE_STAGED_HELP
)
parser.add_argument(
"--ignore-unstaged",
action="store_true",
default=None,
help=IGNORE_UNSTAGED_HELP,
)
parser.add_argument(
"--include-untracked",
action="store_true",
default=None,
help=INCLUDE_UNTRACKED_HELP,
)
parser.add_argument(
"--exclude", metavar="EXCLUDE", type=str, nargs="+", help=EXCLUDE_HELP
)
parser.add_argument(
"--include", metavar="INCLUDE", nargs="+", type=str, help=INCLUDE_HELP
)
parser.add_argument(
"--diff-range-notation",
metavar="RANGE_NOTATION",
type=str,
help=DIFF_RANGE_NOTATION_HELP,
)
parser.add_argument(
"--version",
action="version",
version=f"diff-quality {diff_cover.VERSION}",
)
parser.add_argument(
"--ignore-whitespace",
action="store_true",
default=None,
help=IGNORE_WHITESPACE,
)
parser.add_argument(
"-q", "--quiet", action="store_true", default=None, help=QUIET_HELP
)
parser.add_argument(
"-c", "--config-file", help=CONFIG_FILE_HELP, metavar="CONFIG_FILE"
)
parser.add_argument(
"--report-root-path", help=REPORT_ROOT_PATH_HELP, metavar="ROOT_PATH"
)
parser.add_argument(
"--total-percent-float",
action="store_true",
default=None,
help=TOTAL_PERCENT_FLOAT_HELP,
)
defaults = {
"ignore_whitespace": False,
"compare_branch": "origin/main",
"diff_range_notation": "...",
"input_reports": [],
"fail_under": 0,
"ignore_staged": False,
"ignore_unstaged": False,
"ignore_untracked": False,
"quiet": False,
"total_percent_float": False,
}
return get_config(
parser=parser, argv=argv, defaults=defaults, tool=Tool.DIFF_QUALITY
)
def generate_quality_report(
tool,
compare_branch,
diff_tool,
report_formats=None,
css_file=None,
ignore_staged=False,
ignore_unstaged=False,
include_untracked=False,
exclude=None,
include=None,
quiet=False,
total_percent_float=False,
):
"""
Generate the quality report, using kwargs from `parse_args()`.
"""
supported_extensions = (
getattr(tool, "supported_extensions", None) or tool.driver.supported_extensions
)
diff = GitDiffReporter(
compare_branch,
git_diff=diff_tool,
ignore_staged=ignore_staged,
ignore_unstaged=ignore_unstaged,
include_untracked=include_untracked,
supported_extensions=supported_extensions,
exclude=exclude,
include=include,
)
if "html" in report_formats:
html_report = report_formats["html"] or HTML_REPORT_DEFAULT_PATH
css_url = css_file
if css_url is not None:
css_url = os.path.relpath(css_file, os.path.dirname(html_report))
reporter = HtmlQualityReportGenerator(
tool, diff, css_url=css_url, total_percent_float=total_percent_float
)
with open_file(html_report, "wb") as output_file:
reporter.generate_report(output_file)
if css_file is not None:
with open(css_file, "wb") as output_file:
reporter.generate_css(output_file)
if "json" in report_formats:
json_report = report_formats["json"] or JSON_REPORT_DEFAULT_PATH
reporter = JsonReportGenerator(
tool, diff, total_percent_float=total_percent_float
)
with open_file(json_report, "wb") as output_file:
reporter.generate_report(output_file)
if "markdown" in report_formats:
markdown_report = report_formats["markdown"] or MARKDOWN_REPORT_DEFAULT_PATH
reporter = MarkdownQualityReportGenerator(
tool, diff, total_percent_float=total_percent_float
)
with open_file(markdown_report, "wb") as output_file:
reporter.generate_report(output_file)
# Generate the report for stdout
reporter = StringQualityReportGenerator(
tool, diff, total_percent_float=total_percent_float
)
output_file = io.BytesIO() if quiet else sys.stdout.buffer
reporter.generate_report(output_file)
return reporter.total_percent_covered()
def main(argv=None, directory=None):
"""
Main entry point for the tool, script installed via pyproject.toml
Returns a value that can be passed into exit() specifying
the exit code.
1 is an error
0 is successful run
"""
argv = argv or sys.argv
arg_dict = parse_quality_args(
handle_old_format(diff_cover.QUALITY_DESCRIPTION, argv[1:])
)
quiet = arg_dict["quiet"]
level = logging.ERROR if quiet else logging.WARNING
logging.basicConfig(format="%(message)s", level=level)
GitPathTool.set_cwd(directory)
fail_under = arg_dict.get("fail_under")
tool = arg_dict["violations"]
user_options = arg_dict.get("options")
if user_options:
# strip quotes if present
first_char = user_options[0]
last_char = user_options[-1]
if first_char == last_char and first_char in ('"', "'"):
user_options = user_options[1:-1]
reporter = None
reporter_factory_fn = None
driver = QUALITY_DRIVERS.get(tool)
if driver is None:
# The requested tool is not built into diff_cover. See if another Python
# package provides it.
plugin_manager = pluggy.PluginManager("diff_cover")
plugin_manager.add_hookspecs(hookspecs)
plugin_manager.load_setuptools_entrypoints("diff_cover")
hooks = plugin_manager.hook.diff_cover_report_quality
for hookimpl in hooks.get_hookimpls():
if hookimpl.plugin_name == tool:
reporter_factory_fn = hookimpl.function
break
# If none of the reporter, driver, or reporter_factory_fn are set
if not any((reporter, driver, reporter_factory_fn)):
LOGGER.error("Quality tool not recognized: '%s'", tool)
return 1
with contextlib.ExitStack() as stack:
try:
input_reports = []
for path in arg_dict["input_reports"]:
try:
file_handle = stack.enter_context(open(path, "rb"))
input_reports.append(file_handle)
except OSError:
LOGGER.error("Could not load report '%s'", path)
return 1
if driver is not None:
# If we've been given pre-generated reports,
# try to open the files
if arg_dict["report_root_path"]:
driver.add_driver_args(
report_root_path=arg_dict["report_root_path"]
)
reporter = QualityReporter(driver, input_reports, user_options)
elif reporter_factory_fn:
reporter = reporter_factory_fn(
reports=input_reports, options=user_options
)
percent_passing = generate_quality_report(
reporter,
arg_dict["compare_branch"],
GitDiffTool(
arg_dict["diff_range_notation"], arg_dict["ignore_whitespace"]
),
report_formats=arg_dict["format"],
css_file=arg_dict["external_css_file"],
ignore_staged=arg_dict["ignore_staged"],
ignore_unstaged=arg_dict["ignore_unstaged"],
include_untracked=arg_dict["include_untracked"],
exclude=arg_dict["exclude"],
include=arg_dict["include"],
quiet=quiet,
total_percent_float=arg_dict["total_percent_float"],
)
if percent_passing >= fail_under:
return 0
LOGGER.error("Failure. Quality is below %i.", fail_under)
return 1
except ImportError:
LOGGER.error("Quality tool not installed: '%s'", tool)
return 1
except OSError as exc:
LOGGER.error("Failure: '%s'", str(exc))
return 1
if __name__ == "__main__":
sys.exit(main())
|