1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602
|
import contextlib
import datetime
import json
import unittest
import pytest
from django.contrib.auth import get_user_model
from django.contrib.auth.hashers import make_password
from django.utils import timezone
from jwcrypto import jwt
from oauthlib.common import Request
from oauthlib.oauth2.rfc6749 import errors as rfc6749_errors
from oauth2_provider.exceptions import FatalClientError
from oauth2_provider.models import (
get_access_token_model,
get_application_model,
get_grant_model,
get_refresh_token_model,
)
from oauth2_provider.oauth2_backends import get_oauthlib_core
from oauth2_provider.oauth2_validators import OAuth2Validator
from . import presets
from .common_testing import OAuth2ProviderTestCase as TestCase
from .common_testing import OAuth2ProviderTransactionTestCase as TransactionTestCase
from .common_testing import retrieve_current_databases
from .utils import get_basic_auth_header
try:
from unittest import mock
except ImportError:
import mock
UserModel = get_user_model()
Application = get_application_model()
AccessToken = get_access_token_model()
Grant = get_grant_model()
RefreshToken = get_refresh_token_model()
CLEARTEXT_SECRET = "1234567890abcdefghijklmnopqrstuvwxyz"
CLEARTEXT_BLANK_SECRET = ""
@contextlib.contextmanager
def always_invalid_token():
# NOTE: This can happen if someone swaps the AccessToken model and
# updates `is_valid` such that it has some criteria on top of
# `is_expired` and `allow_scopes`.
original_is_valid = AccessToken.is_valid
AccessToken.is_valid = mock.MagicMock(return_value=False)
try:
yield
finally:
AccessToken.is_valid = original_is_valid
class TestOAuth2Validator(TransactionTestCase):
def setUp(self):
self.user = UserModel.objects.create_user("user", "test@example.com", "123456")
self.request = mock.MagicMock(wraps=Request)
self.request.user = self.user
self.request.grant_type = "not client"
self.validator = OAuth2Validator()
self.application = Application.objects.create(
client_id="client_id",
client_secret=CLEARTEXT_SECRET,
user=self.user,
client_type=Application.CLIENT_PUBLIC,
authorization_grant_type=Application.GRANT_PASSWORD,
)
self.request.client = self.application
self.blank_secret_request = mock.MagicMock(wraps=Request)
self.blank_secret_request.user = self.user
self.blank_secret_request.grant_type = "not client"
self.blank_secret_application = Application.objects.create(
client_id="blank_secret_client_id",
client_secret=CLEARTEXT_BLANK_SECRET,
user=self.user,
client_type=Application.CLIENT_PUBLIC,
authorization_grant_type=Application.GRANT_PASSWORD,
)
self.blank_secret_request.client = self.blank_secret_application
def tearDown(self):
self.application.delete()
def test_authenticate_request_body(self):
self.request.client_id = "client_id"
self.assertFalse(self.validator._authenticate_request_body(self.request))
self.request.client_secret = ""
self.assertFalse(self.validator._authenticate_request_body(self.request))
self.request.client_secret = "wrong_client_secret"
self.assertFalse(self.validator._authenticate_request_body(self.request))
self.request.client_secret = CLEARTEXT_SECRET
self.assertTrue(self.validator._authenticate_request_body(self.request))
self.blank_secret_request.client_id = "blank_secret_client_id"
self.assertTrue(self.validator._authenticate_request_body(self.blank_secret_request))
self.blank_secret_request.client_secret = CLEARTEXT_BLANK_SECRET
self.assertTrue(self.validator._authenticate_request_body(self.blank_secret_request))
self.blank_secret_request.client_secret = "wrong_client_secret"
self.assertFalse(self.validator._authenticate_request_body(self.blank_secret_request))
def test_authenticate_request_body_unhashed_secret(self):
self.application.client_secret = CLEARTEXT_SECRET
self.application.hash_client_secret = False
self.application.save()
self.request.client_id = "client_id"
self.request.client_secret = CLEARTEXT_SECRET
self.assertTrue(self.validator._authenticate_request_body(self.request))
self.application.hash_client_secret = True
self.application.save()
def test_extract_basic_auth(self):
self.request.headers = {"HTTP_AUTHORIZATION": "Basic 123456"}
self.assertEqual(self.validator._extract_basic_auth(self.request), "123456")
self.request.headers = {}
self.assertIsNone(self.validator._extract_basic_auth(self.request))
self.request.headers = {"HTTP_AUTHORIZATION": "Dummy 123456"}
self.assertIsNone(self.validator._extract_basic_auth(self.request))
self.request.headers = {"HTTP_AUTHORIZATION": "Basic"}
self.assertIsNone(self.validator._extract_basic_auth(self.request))
self.request.headers = {"HTTP_AUTHORIZATION": "Basic 123456 789"}
self.assertEqual(self.validator._extract_basic_auth(self.request), "123456 789")
def test_authenticate_basic_auth_hashed_secret(self):
self.request.encoding = "utf-8"
self.request.headers = get_basic_auth_header("client_id", CLEARTEXT_SECRET)
self.assertTrue(self.validator._authenticate_basic_auth(self.request))
def test_authenticate_basic_auth_unhashed_secret(self):
self.application.client_secret = CLEARTEXT_SECRET
self.application.hash_client_secret = False
self.application.save()
self.request.encoding = "utf-8"
self.request.headers = get_basic_auth_header("client_id", CLEARTEXT_SECRET)
self.assertTrue(self.validator._authenticate_basic_auth(self.request))
def test_authenticate_basic_auth_default_encoding(self):
self.request.encoding = None
self.request.headers = get_basic_auth_header("client_id", CLEARTEXT_SECRET)
self.assertTrue(self.validator._authenticate_basic_auth(self.request))
def test_authenticate_basic_auth_wrong_client_id(self):
self.request.encoding = "utf-8"
self.request.headers = get_basic_auth_header("wrong_id", CLEARTEXT_SECRET)
self.assertFalse(self.validator._authenticate_basic_auth(self.request))
def test_authenticate_basic_auth_wrong_client_secret(self):
self.request.encoding = "utf-8"
self.request.headers = get_basic_auth_header("client_id", "wrong_secret")
self.assertFalse(self.validator._authenticate_basic_auth(self.request))
def test_authenticate_basic_auth_not_b64_auth_string(self):
self.request.encoding = "utf-8"
# Can"t b64decode
self.request.headers = {"HTTP_AUTHORIZATION": "Basic not_base64"}
self.assertFalse(self.validator._authenticate_basic_auth(self.request))
def test_authenticate_basic_auth_invalid_b64_string(self):
self.request.encoding = "utf-8"
self.request.headers = {"HTTP_AUTHORIZATION": "Basic ZHVtbXk=:ZHVtbXk=\n"}
self.assertFalse(self.validator._authenticate_basic_auth(self.request))
def test_authenticate_basic_auth_not_utf8(self):
self.request.encoding = "utf-8"
# b64decode("test") will become b"\xb5\xeb-", it can"t be decoded as utf-8
self.request.headers = {"HTTP_AUTHORIZATION": "Basic test"}
self.assertFalse(self.validator._authenticate_basic_auth(self.request))
def test_authenticate_check_secret(self):
hashed = make_password(CLEARTEXT_SECRET)
self.assertTrue(self.validator._check_secret(CLEARTEXT_SECRET, CLEARTEXT_SECRET))
self.assertTrue(self.validator._check_secret(CLEARTEXT_SECRET, hashed))
self.assertFalse(self.validator._check_secret(hashed, hashed))
self.assertFalse(self.validator._check_secret(hashed, CLEARTEXT_SECRET))
def test_authenticate_client_id(self):
self.assertTrue(self.validator.authenticate_client_id("client_id", self.request))
def test_authenticate_client_id_fail(self):
self.application.client_type = Application.CLIENT_CONFIDENTIAL
self.application.save()
self.assertFalse(self.validator.authenticate_client_id("client_id", self.request))
self.assertFalse(self.validator.authenticate_client_id("fake_client_id", self.request))
def test_client_authentication_required(self):
self.request.headers = {"HTTP_AUTHORIZATION": "Basic 123456"}
self.assertTrue(self.validator.client_authentication_required(self.request))
self.request.headers = {}
self.request.client_id = "client_id"
self.request.client_secret = CLEARTEXT_SECRET
self.assertTrue(self.validator.client_authentication_required(self.request))
self.request.client_secret = ""
self.assertFalse(self.validator.client_authentication_required(self.request))
self.application.client_type = Application.CLIENT_CONFIDENTIAL
self.application.save()
self.request.client = ""
self.assertTrue(self.validator.client_authentication_required(self.request))
def test_load_application_fails_when_request_has_no_client(self):
self.assertRaises(AssertionError, self.validator.authenticate_client_id, "client_id", {})
def test_rotate_refresh_token__is_true(self):
self.assertTrue(self.validator.rotate_refresh_token(mock.MagicMock()))
def test_save_bearer_token__without_user__raises_fatal_client(self):
token = {}
with self.assertRaises(FatalClientError):
self.validator.save_bearer_token(token, mock.MagicMock())
def test_save_bearer_token__with_existing_tokens__does_not_create_new_tokens(self):
rotate_token_function = mock.MagicMock()
rotate_token_function.return_value = False
self.validator.rotate_refresh_token = rotate_token_function
access_token = AccessToken.objects.create(
token="123",
user=self.user,
expires=timezone.now() + datetime.timedelta(seconds=60),
application=self.application,
)
refresh_token = RefreshToken.objects.create(
access_token=access_token, token="abc", user=self.user, application=self.application
)
self.request.refresh_token_instance = refresh_token
token = {
"scope": "foo bar",
"refresh_token": "abc",
"access_token": "123",
}
self.assertEqual(1, RefreshToken.objects.count())
self.assertEqual(1, AccessToken.objects.count())
self.validator.save_bearer_token(token, self.request)
self.assertEqual(1, RefreshToken.objects.count())
self.assertEqual(1, AccessToken.objects.count())
def test_save_bearer_token__checks_to_rotate_tokens(self):
rotate_token_function = mock.MagicMock()
rotate_token_function.return_value = False
self.validator.rotate_refresh_token = rotate_token_function
access_token = AccessToken.objects.create(
token="123",
user=self.user,
expires=timezone.now() + datetime.timedelta(seconds=60),
application=self.application,
)
refresh_token = RefreshToken.objects.create(
access_token=access_token, token="abc", user=self.user, application=self.application
)
self.request.refresh_token_instance = refresh_token
token = {
"scope": "foo bar",
"refresh_token": "abc",
"access_token": "123",
}
self.validator.save_bearer_token(token, self.request)
rotate_token_function.assert_called_once_with(self.request)
def test_save_bearer_token__with_new_token__creates_new_tokens(self):
token = {
"scope": "foo bar",
"refresh_token": "abc",
"access_token": "123",
}
self.assertEqual(0, RefreshToken.objects.count())
self.assertEqual(0, AccessToken.objects.count())
self.validator.save_bearer_token(token, self.request)
self.assertEqual(1, RefreshToken.objects.count())
self.assertEqual(1, AccessToken.objects.count())
def test_save_bearer_token__with_new_token_equal_to_existing_token__revokes_old_tokens(self):
access_token = AccessToken.objects.create(
token="123",
user=self.user,
expires=timezone.now() + datetime.timedelta(seconds=60),
application=self.application,
)
refresh_token = RefreshToken.objects.create(
access_token=access_token, token="abc", user=self.user, application=self.application
)
self.request.refresh_token_instance = refresh_token
token = {
"scope": "foo bar",
"refresh_token": "abc",
"access_token": "123",
}
self.assertEqual(1, RefreshToken.objects.count())
self.assertEqual(1, AccessToken.objects.count())
self.validator.save_bearer_token(token, self.request)
self.assertEqual(1, RefreshToken.objects.filter(revoked__isnull=True).count())
self.assertEqual(1, AccessToken.objects.count())
def test_save_bearer_token__with_no_refresh_token__creates_new_access_token_only(self):
token = {
"scope": "foo bar",
"access_token": "123",
}
self.validator.save_bearer_token(token, self.request)
self.assertEqual(0, RefreshToken.objects.count())
self.assertEqual(1, AccessToken.objects.count())
def test_save_bearer_token__with_new_token__calls_methods_to_create_access_and_refresh_tokens(self):
token = {
"scope": "foo bar",
"refresh_token": "abc",
"access_token": "123",
}
# Mock private methods to create access and refresh tokens
create_access_token_mock = mock.MagicMock()
create_refresh_token_mock = mock.MagicMock()
self.validator._create_refresh_token = create_refresh_token_mock
self.validator._create_access_token = create_access_token_mock
self.validator.save_bearer_token(token, self.request)
assert create_access_token_mock.call_count == 1
assert create_refresh_token_mock.call_count == 1
def test_get_or_create_user_from_content(self):
content = {"username": "test_user"}
UserModel.objects.filter(username=content["username"]).delete()
user = self.validator.get_or_create_user_from_content(content)
self.assertIsNotNone(user)
self.assertEqual(content["username"], user.username)
class TestOAuth2ValidatorProvidesErrorData(TransactionTestCase):
"""These test cases check that the recommended error codes are returned
when token authentication fails.
RFC-6750: https://rfc-editor.org/rfc/rfc6750.html
> If the protected resource request does not include authentication
> credentials or does not contain an access token that enables access
> to the protected resource, the resource server MUST include the HTTP
> "WWW-Authenticate" response header field[.]
>
> ...
>
> If the request lacks any authentication information..., the
> resource server SHOULD NOT include an error code or other error
> information.
>
> ...
>
> If the protected resource request included an access token and failed
> authentication, the resource server SHOULD include the "error"
> attribute to provide the client with the reason why the access
> request was declined.
See https://rfc-editor.org/rfc/rfc6750.html#section-3.1 for the allowed error
codes.
"""
def setUp(self):
self.user = UserModel.objects.create_user(
"user",
"test@example.com",
"123456",
)
self.request = mock.MagicMock(wraps=Request)
self.request.user = self.user
self.request.grant_type = "not client"
self.validator = OAuth2Validator()
self.application = Application.objects.create(
client_id="client_id",
client_secret=CLEARTEXT_SECRET,
user=self.user,
client_type=Application.CLIENT_PUBLIC,
authorization_grant_type=Application.GRANT_PASSWORD,
)
self.request.client = self.application
def test_validate_bearer_token_does_not_add_error_when_no_token_is_provided(self):
self.assertFalse(self.validator.validate_bearer_token(None, ["dolphin"], self.request))
with self.assertRaises(AttributeError):
self.request.oauth2_error
def test_validate_bearer_token_adds_error_to_the_request_when_an_invalid_token_is_provided(self):
access_token = mock.MagicMock(token="some_invalid_token")
self.assertFalse(
self.validator.validate_bearer_token(
access_token.token,
[],
self.request,
)
)
self.assertDictEqual(
self.request.oauth2_error,
{
"error": "invalid_token",
"error_description": "The access token is invalid.",
},
)
def test_validate_bearer_token_adds_error_to_the_request_when_an_expired_token_is_provided(self):
access_token = AccessToken.objects.create(
token="some_valid_token",
user=self.user,
expires=timezone.now() - datetime.timedelta(seconds=1),
application=self.application,
)
self.assertFalse(
self.validator.validate_bearer_token(
access_token.token,
[],
self.request,
)
)
self.assertDictEqual(
self.request.oauth2_error,
{
"error": "invalid_token",
"error_description": "The access token has expired.",
},
)
def test_validate_bearer_token_adds_error_to_the_request_when_a_valid_token_has_insufficient_scope(self):
access_token = AccessToken.objects.create(
token="some_valid_token",
user=self.user,
expires=timezone.now() + datetime.timedelta(seconds=1),
application=self.application,
)
self.assertFalse(
self.validator.validate_bearer_token(
access_token.token,
["some_extra_scope"],
self.request,
)
)
self.assertDictEqual(
self.request.oauth2_error,
{
"error": "insufficient_scope",
"error_description": "The access token is valid but does not have enough scope.",
},
)
def test_validate_bearer_token_adds_error_to_the_request_when_a_invalid_custom_token_is_provided(self):
access_token = AccessToken.objects.create(
token="some_valid_token",
user=self.user,
expires=timezone.now() + datetime.timedelta(seconds=1),
application=self.application,
)
with always_invalid_token():
self.assertFalse(
self.validator.validate_bearer_token(
access_token.token,
[],
self.request,
)
)
self.assertDictEqual(
self.request.oauth2_error,
{
"error": "invalid_token",
},
)
@unittest.skip("Requires network connection, disabled for Debian build")
class TestOAuth2ValidatorErrorResourceToken(TestCase):
"""The following tests check logger information when response from oauth2
is unsuccessful.
"""
@classmethod
def setUpTestData(cls):
cls.token = "test_token"
cls.introspection_url = "http://example.com/token/introspection/"
cls.introspection_token = "test_introspection_token"
cls.validator = OAuth2Validator()
def test_response_when_auth_server_response_return_404(self):
with self.assertLogs(logger="oauth2_provider") as mock_log:
self.validator._get_token_from_authentication_server(
self.token, self.introspection_url, self.introspection_token, None
)
self.assertIn(
"ERROR:oauth2_provider:Introspection: Failed to "
"get a valid response from authentication server. "
"Status code: 404, Reason: "
"Not Found.\nNoneType: None",
mock_log.output,
)
@pytest.mark.oauth2_settings(presets.OIDC_SETTINGS_RW)
def test_oidc_endpoint_generation(oauth2_settings, rf):
oauth2_settings.OIDC_ISS_ENDPOINT = ""
django_request = rf.get("/")
request = Request("/", headers=django_request.META)
validator = OAuth2Validator()
oidc_issuer_endpoint = validator.get_oidc_issuer_endpoint(request)
assert oidc_issuer_endpoint == "http://testserver/o"
@pytest.mark.oauth2_settings(presets.OIDC_SETTINGS_RW)
def test_oidc_endpoint_generation_ssl(oauth2_settings, rf, settings):
oauth2_settings.OIDC_ISS_ENDPOINT = ""
django_request = rf.get("/", secure=True)
# Calling the settings method with a django https request should generate a https url
oidc_issuer_endpoint = oauth2_settings.oidc_issuer(django_request)
assert oidc_issuer_endpoint == "https://testserver/o"
# Should also work with an oauthlib request (via validator)
core = get_oauthlib_core()
uri, http_method, body, headers = core._extract_params(django_request)
request = Request(uri=uri, http_method=http_method, body=body, headers=headers)
validator = OAuth2Validator()
oidc_issuer_endpoint = validator.get_oidc_issuer_endpoint(request)
assert oidc_issuer_endpoint == "https://testserver/o"
@pytest.mark.oauth2_settings(presets.OIDC_SETTINGS_RW)
def test_get_jwt_bearer_token(oauth2_settings, mocker):
# oauthlib instructs us to make get_jwt_bearer_token call get_id_token
request = mocker.MagicMock(wraps=Request)
validator = OAuth2Validator()
mock_get_id_token = mocker.patch.object(validator, "get_id_token")
validator.get_jwt_bearer_token(None, None, request)
assert mock_get_id_token.call_count == 1
assert mock_get_id_token.call_args[0] == (None, None, request)
assert mock_get_id_token.call_args[1] == {}
@pytest.mark.django_db(databases=retrieve_current_databases())
@pytest.mark.oauth2_settings(presets.OIDC_SETTINGS_RW)
def test_validate_id_token_expired_jwt(oauth2_settings, mocker, oidc_tokens):
mocker.patch("oauth2_provider.oauth2_validators.jwt.JWT", side_effect=jwt.JWTExpired)
validator = OAuth2Validator()
status = validator.validate_id_token(oidc_tokens.id_token, ["openid"], mocker.sentinel.request)
assert status is False
@pytest.mark.oauth2_settings(presets.OIDC_SETTINGS_RW)
def test_validate_id_token_no_token(oauth2_settings, mocker):
validator = OAuth2Validator()
status = validator.validate_id_token("", ["openid"], mocker.sentinel.request)
assert status is False
@pytest.mark.django_db(databases=retrieve_current_databases())
@pytest.mark.oauth2_settings(presets.OIDC_SETTINGS_RW)
def test_validate_id_token_app_removed(oauth2_settings, mocker, oidc_tokens):
oidc_tokens.application.delete()
validator = OAuth2Validator()
status = validator.validate_id_token(oidc_tokens.id_token, ["openid"], mocker.sentinel.request)
assert status is False
@pytest.mark.django_db(databases=retrieve_current_databases())
@pytest.mark.oauth2_settings(presets.OIDC_SETTINGS_RW)
def test_validate_id_token_bad_token_no_aud(oauth2_settings, mocker, oidc_key):
token = jwt.JWT(header=json.dumps({"alg": "RS256"}), claims=json.dumps({"bad": "token"}))
token.make_signed_token(oidc_key)
validator = OAuth2Validator()
status = validator.validate_id_token(token.serialize(), ["openid"], mocker.sentinel.request)
assert status is False
@pytest.mark.django_db
def test_invalidate_authorization_token_returns_invalid_grant_error_when_grant_does_not_exist():
client_id = "123"
code = "12345"
request = Request("/")
assert Grant.objects.all().count() == 0
with pytest.raises(rfc6749_errors.InvalidGrantError):
validator = OAuth2Validator()
validator.invalidate_authorization_code(client_id=client_id, code=code, request=request)
|