1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609
|
// Copyright Contributors to the DNF5 project.
// Copyright Contributors to the libdnf project.
// SPDX-License-Identifier: GPL-2.0-or-later
//
// This file is part of libdnf: https://github.com/rpm-software-management/libdnf/
//
// Libdnf is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 2 of the License, or
// (at your option) any later version.
//
// Libdnf is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with libdnf. If not, see <https://www.gnu.org/licenses/>.
#include "needs_restarting.hpp"
#include <dirent.h>
#include <libdnf5-cli/argument_parser.hpp>
#include <libdnf5-cli/output/changelogs.hpp>
#include <libdnf5/conf/const.hpp>
#include <libdnf5/conf/option_string.hpp>
#include <libdnf5/rpm/package.hpp>
#include <libdnf5/rpm/package_query.hpp>
#include <libdnf5/sdbus_compat.hpp>
#include <libdnf5/utils/bgettext/bgettext-mark-domain.h>
#include <unistd.h>
#include <utils/string.hpp>
#include <ctime>
#include <fstream>
#include <iostream>
#include <sstream>
#include <unordered_set>
#include <vector>
const SDBUS_SERVICE_NAME_TYPE SYSTEMD_DESTINATION_NAME{"org.freedesktop.systemd1"};
const sdbus::ObjectPath SYSTEMD_OBJECT_PATH{"/org/freedesktop/systemd1"};
const SDBUS_INTERFACE_NAME_TYPE SYSTEMD_MANAGER_INTERFACE{"org.freedesktop.systemd1.Manager"};
const SDBUS_INTERFACE_NAME_TYPE SYSTEMD_UNIT_INTERFACE{"org.freedesktop.systemd1.Unit"};
const SDBUS_INTERFACE_NAME_TYPE SYSTEMD_SERVICE_INTERFACE{"org.freedesktop.systemd1.Service"};
namespace dnf5 {
using namespace libdnf5::cli;
void NeedsRestartingCommand::set_parent_command() {
auto * arg_parser_parent_cmd = get_session().get_argument_parser().get_root_command();
auto * arg_parser_this_cmd = get_argument_parser_command();
arg_parser_parent_cmd->register_command(arg_parser_this_cmd);
}
void NeedsRestartingCommand::set_argument_parser() {
auto & ctx = get_context();
auto & parser = ctx.get_argument_parser();
auto & cmd = *get_argument_parser_command();
cmd.set_description("Determine whether system or systemd services need restarting");
services_option =
dynamic_cast<libdnf5::OptionBool *>(parser.add_init_value(std::make_unique<libdnf5::OptionBool>(false)));
auto * services_arg = parser.add_new_named_arg("services");
services_arg->set_long_name("services");
services_arg->set_short_name('s');
services_arg->set_description("List systemd services started before their dependencies were updated");
services_arg->set_const_value("true");
services_arg->link_value(services_option);
cmd.register_named_arg(services_arg);
processes_option =
dynamic_cast<libdnf5::OptionBool *>(parser.add_init_value(std::make_unique<libdnf5::OptionBool>(false)));
auto * processes_arg = parser.add_new_named_arg("processes");
processes_arg->set_long_name("processes");
processes_arg->set_short_name('p');
processes_arg->set_description("List processes started before their dependencies were updated");
processes_arg->set_const_value("true");
processes_arg->link_value(processes_option);
cmd.register_named_arg(processes_arg);
exclude_services_option =
dynamic_cast<libdnf5::OptionBool *>(parser.add_init_value(std::make_unique<libdnf5::OptionBool>(false)));
auto * exclude_services_arg = parser.add_new_named_arg("exclude-services");
exclude_services_arg->set_long_name("exclude-services");
exclude_services_arg->set_short_name('e');
exclude_services_arg->set_description("Exclude processes managed by systemd services (use with --processes)");
exclude_services_arg->set_const_value("true");
exclude_services_arg->link_value(exclude_services_option);
cmd.register_named_arg(exclude_services_arg);
auto * reboothint_arg = parser.add_new_named_arg("reboothint");
reboothint_arg->set_long_name("reboothint");
reboothint_arg->set_short_name('r');
reboothint_arg->set_description(
"Has no effect, kept for compatibility with DNF 4. \"dnf4 needs-restarting -r\" provides the same "
"functionality "
"as \"dnf5 needs-restarting\".");
cmd.register_named_arg(reboothint_arg);
}
void NeedsRestartingCommand::configure() {
auto & context = get_context();
context.set_load_system_repo(true);
context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
const std::set<std::string> metadata_types{libdnf5::METADATA_TYPE_FILELISTS, libdnf5::METADATA_TYPE_UPDATEINFO};
context.get_base().get_config().get_optional_metadata_types_option().add(
libdnf5::Option::Priority::RUNTIME, metadata_types);
}
time_t NeedsRestartingCommand::get_proc_1_boot_time(Context & ctx) {
time_t proc_1_boot_time = 0;
struct stat proc_1_stat = {};
const auto & logger = ctx.get_base().get_logger();
if (stat("/proc/1", &proc_1_stat) == 0) {
proc_1_boot_time = proc_1_stat.st_mtime;
} else {
logger->debug("Unable to stat /proc/1, using {} as the /proc/1 boot time.", proc_1_boot_time);
}
return proc_1_boot_time;
}
time_t NeedsRestartingCommand::get_kernel_boot_time(Context & ctx) {
time_t btime = 0;
const auto & logger = ctx.get_base().get_logger();
std::ifstream proc_stat{"/proc/stat"};
std::string line;
if (!proc_stat.is_open()) {
logger->debug("Unable to read /proc/stat, using {} as the system boot time.", btime);
return btime;
}
while (std::getline(proc_stat, line)) {
if (line.compare(0, 6, "btime ") == 0) {
std::istringstream btime_stream(line);
std::string tmp;
btime_stream >> tmp >> btime;
return btime;
}
}
if (btime == 0) {
logger->debug("Error reading /proc/stat, using {} as the system boot time.", btime);
}
return btime;
}
time_t NeedsRestartingCommand::get_boot_time(Context & ctx) {
// We have three sources from which to derive the boot time. These values
// vary depending on containerization, existing of a Real Time Clock, etc:
// - UnitsLoadStartTimestamp property on /org/freedesktop/systemd1
// The start time of the service manager, according to systemd itself.
// Seems to be more reliable than UserspaceTimestamp when the RTC is
// in local time. Works unless the system was not booted with systemd,
// such as in (most) containers.
// Reflects the time the first process was run after booting. This
// works for all known cases except machines without a RTC---they
// awake at the start of the epoch.
// - st_mtime of /proc/1
// Reflects the time the first process was run after booting. This
// works for all known cases except machines without a RTC---they
// awake at the start of the epoch.
// - btime field of /proc/stat
// Reflects the time when the kernel started. Works for machines
// without RTC iff the current time is reasonably correct. Does not
// work on containers which share their kernel with the host---there,
// the host kernel uptime is returned.
const auto & logger = ctx.get_base().get_logger();
// First, ask systemd for the boot time. If systemd is available, this is
// the best option.
try {
std::unique_ptr<sdbus::IConnection> connection;
connection = sdbus::createSystemBusConnection();
auto proxy = sdbus::createProxy(SYSTEMD_DESTINATION_NAME, SYSTEMD_OBJECT_PATH);
const auto systemd_boot_time_us =
uint64_t{proxy->getProperty("UnitsLoadStartTimestamp").onInterface(SYSTEMD_MANAGER_INTERFACE)};
const time_t systemd_boot_time = static_cast<long>(systemd_boot_time_us) / (1000L * 1000L);
if (systemd_boot_time != 0) {
logger->debug("Got boot time from systemd: {}", systemd_boot_time);
return systemd_boot_time;
}
} catch (const sdbus::Error & ex) {
// Some D-Bus error, maybe we're inside a container.
logger->debug("D-Bus error getting boot time from systemd: {}", ex.what());
}
// Otherwise, take the maximum of the st_mtime of /proc/1 and the btime field of /proc/stat.
logger->debug(
"Couldn't get boot time from systemd, checking st_mtime of /proc/1 and the btime field of /proc/stat.");
time_t proc_1_boot_time = get_proc_1_boot_time(ctx);
time_t kernel_boot_time = get_kernel_boot_time(ctx);
const time_t boot_time = std::max(proc_1_boot_time, kernel_boot_time);
logger->debug("st_mtime of /proc/1: {}", proc_1_boot_time);
logger->debug("btime field of /proc/stat: {}", kernel_boot_time);
logger->debug("Using {} as the system boot time.", boot_time);
return boot_time;
}
libdnf5::rpm::PackageSet recursive_dependencies(
const libdnf5::rpm::Package & package, libdnf5::rpm::PackageQuery & installed) {
libdnf5::rpm::PackageSet dependencies{package.get_base()};
dependencies.add(package);
std::vector<libdnf5::rpm::Package> stack;
stack.emplace_back(package);
while (!stack.empty()) {
libdnf5::rpm::PackageQuery query{installed};
query.filter_provides(stack.back().get_requires());
stack.pop_back();
for (const auto & dependency : query) {
if (!dependencies.contains(dependency)) {
stack.emplace_back(dependency);
}
}
dependencies |= query;
}
return dependencies;
}
void NeedsRestartingCommand::system_needs_restarting(Context & ctx) {
const auto boot_time = get_boot_time(ctx);
libdnf5::rpm::PackageQuery reboot_suggested{ctx.get_base()};
reboot_suggested.filter_installed();
reboot_suggested.filter_reboot_suggested();
std::vector<libdnf5::rpm::Package> need_reboot = {};
for (const auto & pkg : reboot_suggested) {
if (pkg.get_install_time() > static_cast<unsigned long long>(boot_time)) {
need_reboot.push_back(pkg);
}
}
if (need_reboot.empty()) {
std::cout << "No core libraries or services have been updated since boot-up." << std::endl
<< "Reboot should not be necessary." << std::endl;
} else {
std::cout << "Core libraries or services have been updated since boot-up:" << std::endl;
std::vector<std::string> need_reboot_names;
for (const auto & pkg : need_reboot) {
need_reboot_names.emplace_back(pkg.get_name());
}
std::sort(need_reboot_names.begin(), need_reboot_names.end());
need_reboot_names.erase(
std::unique(need_reboot_names.begin(), need_reboot_names.end()), need_reboot_names.end());
for (const auto & pkg_name : need_reboot_names) {
std::cout << " * " << pkg_name << std::endl;
}
std::cout << std::endl
<< "Reboot is required to fully utilize these updates." << std::endl
<< "More information: https://access.redhat.com/solutions/27943" << std::endl;
throw libdnf5::cli::SilentCommandExitError(1);
}
}
std::vector<NeedsRestartingCommand::SystemdService> NeedsRestartingCommand::get_systemd_services(
[[maybe_unused]] Context & ctx) {
std::unique_ptr<sdbus::IConnection> connection;
try {
connection = sdbus::createSystemBusConnection();
} catch (const sdbus::Error & ex) {
const std::string error_message{ex.what()};
throw libdnf5::cli::CommandExitError(1, M_("Couldn't connect to D-Bus: {}"), error_message);
}
auto systemd_proxy = sdbus::createProxy(SYSTEMD_DESTINATION_NAME, SYSTEMD_OBJECT_PATH);
std::vector<sdbus::Struct<
std::string,
std::string,
std::string,
std::string,
std::string,
std::string,
sdbus::ObjectPath,
uint32_t,
std::string,
sdbus::ObjectPath>>
units;
systemd_proxy->callMethod("ListUnits").onInterface(SYSTEMD_MANAGER_INTERFACE).storeResultsTo(units);
std::vector<SystemdService> services;
for (const auto & unit : units) {
// See ListUnits here:
// https://www.freedesktop.org/wiki/Software/systemd/dbus/
const auto unit_name = std::get<0>(unit);
// Only consider service units. Skip timers, targets, etc.
if (!libdnf5::utils::string::ends_with(unit_name, ".service")) {
continue;
}
const auto unit_object_path = std::get<6>(unit);
auto unit_proxy = sdbus::createProxy(SYSTEMD_DESTINATION_NAME, unit_object_path);
// Only consider active (running) services
std::string active_state =
unit_proxy->getProperty("ActiveState").onInterface(SYSTEMD_UNIT_INTERFACE).get<std::string>();
if (active_state != "active") {
continue;
}
// FragmentPath is the path to the unit file that defines the service
std::string fragment_path =
unit_proxy->getProperty("FragmentPath").onInterface(SYSTEMD_UNIT_INTERFACE).get<std::string>();
const auto start_timestamp_us =
uint64_t{unit_proxy->getProperty("ActiveEnterTimestamp").onInterface(SYSTEMD_UNIT_INTERFACE)};
services.push_back(SystemdService{unit_name, start_timestamp_us, unit_object_path, fragment_path});
}
return services;
}
void NeedsRestartingCommand::services_need_restarting(Context & ctx) {
const auto services = get_systemd_services(ctx);
std::unordered_map<std::string, SystemdService> unit_file_to_service;
for (const auto & service : services) {
unit_file_to_service.insert(std::make_pair(service.fragment_path, service));
}
// Iterate over each file from each installed package and check whether it
// is a unit file for a running service. This is much faster than running
// filter_file on each unit file.
libdnf5::rpm::PackageQuery installed{ctx.get_base()};
installed.filter_installed();
std::vector<std::string> service_names;
for (const auto & package : installed) {
for (const auto & file : package.get_files()) {
const auto & service_pair = unit_file_to_service.find(file);
if (service_pair != unit_file_to_service.end()) {
// If the file is a unit file for a running service
const auto & service = service_pair->second;
// Recursively get all dependencies of the package that
// provides the service (and include the package itself)
const auto & deps = recursive_dependencies(package, installed);
for (const auto & dep : deps) {
// If any dependency (or the package itself) has been
// updated since the service started, recommend restarting
// of that service
const uint64_t install_timestamp_us = 1000L * 1000L * dep.get_install_time();
if (install_timestamp_us > service.start_timestamp_us) {
service_names.emplace_back(service.name);
break;
}
}
break;
}
}
}
if (!service_names.empty()) {
for (const auto & service_name : service_names) {
std::cout << service_name << std::endl;
}
throw libdnf5::cli::SilentCommandExitError(1);
}
}
void NeedsRestartingCommand::processes_need_restarting(Context & ctx, bool exclude_services) {
const auto boot_time = get_boot_time(ctx);
const auto & logger = ctx.get_base().get_logger();
// Build a map of executable paths to their packages
libdnf5::rpm::PackageQuery installed{ctx.get_base()};
installed.filter_installed();
std::unordered_map<std::string, libdnf5::rpm::Package> file_to_package;
for (const auto & package : installed) {
for (const auto & file : package.get_files()) {
file_to_package.insert({file, package});
}
}
// If exclude_services is set, build a set of PIDs managed by systemd services
std::unordered_set<std::string> service_pids;
if (exclude_services) {
try {
std::unique_ptr<sdbus::IConnection> connection = sdbus::createSystemBusConnection();
const auto services = get_systemd_services(ctx);
for (const auto & service : services) {
auto unit_proxy = sdbus::createProxy(SYSTEMD_DESTINATION_NAME, service.object_path);
// Get the main PID of the service
try {
const auto main_pid =
uint32_t{unit_proxy->getProperty("MainPID").onInterface(SYSTEMD_SERVICE_INTERFACE)};
if (main_pid > 0) {
service_pids.insert(std::to_string(main_pid));
}
} catch (const sdbus::Error & ex) {
// Some services might not have a MainPID
logger->debug("Failed to get MainPID for {}: {}", service.name, ex.what());
}
// Also get control group PIDs
try {
std::string control_group = unit_proxy->getProperty("ControlGroup")
.onInterface(SYSTEMD_SERVICE_INTERFACE)
.get<std::string>();
if (!control_group.empty()) {
// Read PIDs from the cgroup
std::string cgroup_procs_path = "/sys/fs/cgroup" + control_group + "/cgroup.procs";
if (std::ifstream cgroup_file(cgroup_procs_path); cgroup_file.is_open()) {
std::string pid;
while (std::getline(cgroup_file, pid)) {
if (!pid.empty()) {
service_pids.insert(pid);
}
}
}
}
} catch (const sdbus::Error & ex) {
logger->debug("Failed to get ControlGroup for {}: {}", service.name, ex.what());
}
}
} catch (const sdbus::Error & ex) {
logger->warning("Failed to connect to D-Bus for service exclusion: {}", ex.what());
} catch (const libdnf5::cli::CommandExitError & ex) {
logger->warning("Failed to get systemd services for exclusion: {}", ex.what());
}
}
// Iterate through /proc to find running processes
DIR * proc_dir = opendir("/proc");
if (!proc_dir) {
logger->warning("Failed to open /proc directory");
return;
}
// Map of executable paths to their process start times and packages
struct ProcessInfo {
std::string pid;
std::string cmdline;
time_t start_time;
libdnf5::rpm::Package package;
};
std::unordered_map<std::string, ProcessInfo> running_processes;
struct dirent * entry;
while ((entry = readdir(proc_dir)) != nullptr) {
// Check if the directory name is a number (PID)
if (entry->d_type != DT_DIR) {
continue;
}
bool is_pid = true;
for (const char * c = entry->d_name; *c != '\0'; ++c) {
if (!std::isdigit(*c)) {
is_pid = false;
break;
}
}
if (!is_pid) {
continue;
}
std::string pid{entry->d_name};
// Skip processes managed by systemd services if exclude_services is set
if (exclude_services && service_pids.find(pid) != service_pids.end()) {
continue;
}
// Get the process start time from /proc/[pid]/stat
std::string stat_path = std::string("/proc/") + pid + "/stat";
std::ifstream stat_file(stat_path);
time_t process_start_time = 0;
if (stat_file.is_open()) {
std::string stat_line;
if (std::getline(stat_file, stat_line)) {
// Parse /proc/[pid]/stat to get the starttime field (field 22)
// Format: pid (comm) state ppid pgrp session tty_nr tpgid flags ... starttime
size_t pos = stat_line.rfind(')');
if (pos != std::string::npos) {
std::istringstream iss(stat_line.substr(pos + 1));
std::string field;
// Skip fields 3-21 (we're after field 2 which is comm)
for (int i = 0; i < 20; ++i) {
iss >> field;
}
// Field 22 is starttime in clock ticks since boot
unsigned long long starttime_ticks;
if (iss >> starttime_ticks) {
// Convert ticks to seconds and add to boot_time
long ticks_per_second = sysconf(_SC_CLK_TCK);
process_start_time =
boot_time +
static_cast<time_t>(starttime_ticks / static_cast<unsigned long long>(ticks_per_second));
}
}
}
}
// Read the full cmdline
std::string cmdline_path = std::string("/proc/") + pid + "/cmdline";
std::ifstream cmdline_file(cmdline_path);
std::string cmdline;
if (cmdline_file.is_open()) {
std::getline(cmdline_file, cmdline, '\0');
// null bytes used as field separators; replace with spaces
for (char & c : cmdline) {
if (c == '\0') {
c = ' ';
}
}
}
// Read the exe symlink to get the executable path
std::string exe_link = std::string("/proc/") + pid + "/exe";
char exe_path[PATH_MAX];
ssize_t len = readlink(exe_link.c_str(), exe_path, sizeof(exe_path) - 1);
if (len != -1) {
exe_path[len] = '\0';
// Remove " (deleted)" suffix if present
std::string exe_path_str(exe_path);
const std::string deleted_suffix = " (deleted)";
if (libdnf5::utils::string::ends_with(exe_path_str, deleted_suffix)) {
exe_path_str = exe_path_str.substr(0, exe_path_str.length() - deleted_suffix.length());
}
// Check if this executable is from an installed package
auto it = file_to_package.find(exe_path_str);
if (it != file_to_package.end()) {
const auto & package = it->second;
running_processes.insert({exe_path_str, ProcessInfo{pid, cmdline, process_start_time, package}});
}
}
}
closedir(proc_dir);
// Now check which processes need restarting
std::unordered_set<std::string> processes_needing_restart;
libdnf5::rpm::PackageSet updated_packages{ctx.get_base()};
for (const auto & [exe_path, process_info] : running_processes) {
// Recursively get all dependencies of the package that
// provides the executable (and include the package itself)
const auto & deps = recursive_dependencies(process_info.package, installed);
for (const auto & dep : deps) {
// If any dependency (or the package itself) has been
// updated since the process started, the process needs restart
const auto install_time = static_cast<time_t>(dep.get_install_time());
if (install_time > process_info.start_time) {
processes_needing_restart.insert(std::string(process_info.pid) + '\t' + process_info.cmdline);
// Track this package as updated so we can check reverse dependencies
updated_packages.add(dep);
break;
}
}
}
if (!processes_needing_restart.empty()) {
std::vector<std::string> sorted_processes(processes_needing_restart.begin(), processes_needing_restart.end());
std::sort(sorted_processes.begin(), sorted_processes.end());
for (const auto & process : sorted_processes) {
std::cout << process << std::endl;
}
throw libdnf5::cli::SilentCommandExitError(1);
}
}
void NeedsRestartingCommand::run() {
auto & ctx = get_context();
if (services_option->get_value()) {
services_need_restarting(ctx);
} else if (processes_option->get_value()) {
processes_need_restarting(ctx, exclude_services_option->get_value());
} else {
system_needs_restarting(ctx);
}
}
} // namespace dnf5
|