1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313
|
package daemon
import (
"fmt"
"os"
"path/filepath"
"strings"
"testing"
"gotest.tools/v3/fs"
containertypes "github.com/docker/docker/api/types/container"
"github.com/docker/docker/container"
swarmagent "github.com/docker/swarmkit/agent"
swarmapi "github.com/docker/swarmkit/api"
specs "github.com/opencontainers/runtime-spec/specs-go"
"golang.org/x/sys/windows/registry"
"gotest.tools/v3/assert"
)
func TestSetWindowsCredentialSpecInSpec(t *testing.T) {
// we need a temp directory to act as the daemon's root
tmpDaemonRoot := fs.NewDir(t, t.Name()).Path()
defer func() {
assert.NilError(t, os.RemoveAll(tmpDaemonRoot))
}()
daemon := &Daemon{
root: tmpDaemonRoot,
}
t.Run("it does nothing if there are no security options", func(t *testing.T) {
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(&container.Container{}, spec)
assert.NilError(t, err)
assert.Check(t, spec.Windows == nil)
err = daemon.setWindowsCredentialSpec(&container.Container{HostConfig: &containertypes.HostConfig{}}, spec)
assert.NilError(t, err)
assert.Check(t, spec.Windows == nil)
err = daemon.setWindowsCredentialSpec(&container.Container{HostConfig: &containertypes.HostConfig{SecurityOpt: []string{}}}, spec)
assert.NilError(t, err)
assert.Check(t, spec.Windows == nil)
})
dummyContainerID := "dummy-container-ID"
containerFactory := func(secOpt string) *container.Container {
if !strings.Contains(secOpt, "=") {
secOpt = "credentialspec=" + secOpt
}
return &container.Container{
ID: dummyContainerID,
HostConfig: &containertypes.HostConfig{
SecurityOpt: []string{secOpt},
},
}
}
credSpecsDir := filepath.Join(tmpDaemonRoot, credentialSpecFileLocation)
dummyCredFileContents := `{"We don't need no": "education"}`
t.Run("happy path with a 'file://' option", func(t *testing.T) {
spec := &specs.Spec{}
// let's render a dummy cred file
err := os.Mkdir(credSpecsDir, os.ModePerm)
assert.NilError(t, err)
dummyCredFileName := "dummy-cred-spec.json"
dummyCredFilePath := filepath.Join(credSpecsDir, dummyCredFileName)
err = os.WriteFile(dummyCredFilePath, []byte(dummyCredFileContents), 0644)
defer func() {
assert.NilError(t, os.Remove(dummyCredFilePath))
}()
assert.NilError(t, err)
err = daemon.setWindowsCredentialSpec(containerFactory("file://"+dummyCredFileName), spec)
assert.NilError(t, err)
if assert.Check(t, spec.Windows != nil) {
assert.Equal(t, dummyCredFileContents, spec.Windows.CredentialSpec)
}
})
t.Run("it's not allowed to use a 'file://' option with an absolute path", func(t *testing.T) {
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory(`file://C:\path\to\my\credspec.json`), spec)
assert.ErrorContains(t, err, "invalid credential spec - file:// path cannot be absolute")
assert.Check(t, spec.Windows == nil)
})
t.Run("it's not allowed to use a 'file://' option breaking out of the cred specs' directory", func(t *testing.T) {
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory(`file://..\credspec.json`), spec)
assert.ErrorContains(t, err, fmt.Sprintf("invalid credential spec - file:// path must be under %s", credSpecsDir))
assert.Check(t, spec.Windows == nil)
})
t.Run("when using a 'file://' option pointing to a file that doesn't exist, it fails gracefully", func(t *testing.T) {
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory("file://i-dont-exist.json"), spec)
assert.ErrorContains(t, err, fmt.Sprintf("credential spec for container %s could not be read from file", dummyContainerID))
assert.ErrorContains(t, err, "The system cannot find")
assert.Check(t, spec.Windows == nil)
})
t.Run("happy path with a 'registry://' option", func(t *testing.T) {
valueName := "my-cred-spec"
key := &dummyRegistryKey{
getStringValueFunc: func(name string) (val string, valtype uint32, err error) {
assert.Equal(t, valueName, name)
return dummyCredFileContents, 0, nil
},
}
defer setRegistryOpenKeyFunc(t, key)()
spec := &specs.Spec{}
assert.NilError(t, daemon.setWindowsCredentialSpec(containerFactory("registry://"+valueName), spec))
if assert.Check(t, spec.Windows != nil) {
assert.Equal(t, dummyCredFileContents, spec.Windows.CredentialSpec)
}
assert.Check(t, key.closed)
})
t.Run("when using a 'registry://' option and opening the registry key fails, it fails gracefully", func(t *testing.T) {
dummyError := fmt.Errorf("dummy error")
defer setRegistryOpenKeyFunc(t, &dummyRegistryKey{}, dummyError)()
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory("registry://my-cred-spec"), spec)
assert.ErrorContains(t, err, fmt.Sprintf("registry key %s could not be opened: %v", credentialSpecRegistryLocation, dummyError))
assert.Check(t, spec.Windows == nil)
})
t.Run("when using a 'registry://' option pointing to a value that doesn't exist, it fails gracefully", func(t *testing.T) {
valueName := "my-cred-spec"
key := &dummyRegistryKey{
getStringValueFunc: func(name string) (val string, valtype uint32, err error) {
assert.Equal(t, valueName, name)
return "", 0, registry.ErrNotExist
},
}
defer setRegistryOpenKeyFunc(t, key)()
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory("registry://"+valueName), spec)
assert.ErrorContains(t, err, fmt.Sprintf("registry credential spec %q for container %s was not found", valueName, dummyContainerID))
assert.Check(t, key.closed)
})
t.Run("when using a 'registry://' option and reading the registry value fails, it fails gracefully", func(t *testing.T) {
dummyError := fmt.Errorf("dummy error")
valueName := "my-cred-spec"
key := &dummyRegistryKey{
getStringValueFunc: func(name string) (val string, valtype uint32, err error) {
assert.Equal(t, valueName, name)
return "", 0, dummyError
},
}
defer setRegistryOpenKeyFunc(t, key)()
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory("registry://"+valueName), spec)
assert.ErrorContains(t, err, fmt.Sprintf("error reading credential spec %q from registry for container %s: %v", valueName, dummyContainerID, dummyError))
assert.Check(t, key.closed)
})
t.Run("happy path with a 'config://' option", func(t *testing.T) {
configID := "my-cred-spec"
dependencyManager := swarmagent.NewDependencyManager()
dependencyManager.Configs().Add(swarmapi.Config{
ID: configID,
Spec: swarmapi.ConfigSpec{
Data: []byte(dummyCredFileContents),
},
})
task := &swarmapi.Task{
Spec: swarmapi.TaskSpec{
Runtime: &swarmapi.TaskSpec_Container{
Container: &swarmapi.ContainerSpec{
Configs: []*swarmapi.ConfigReference{
{
ConfigID: configID,
},
},
},
},
},
}
cntr := containerFactory("config://" + configID)
cntr.DependencyStore = swarmagent.Restrict(dependencyManager, task)
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(cntr, spec)
assert.NilError(t, err)
if assert.Check(t, spec.Windows != nil) {
assert.Equal(t, dummyCredFileContents, spec.Windows.CredentialSpec)
}
})
t.Run("using a 'config://' option on a container not managed by swarmkit is not allowed, and results in a generic error message to hide that purely internal API", func(t *testing.T) {
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory("config://whatever"), spec)
assert.Equal(t, errInvalidCredentialSpecSecOpt, err)
assert.Check(t, spec.Windows == nil)
})
t.Run("happy path with a 'raw://' option", func(t *testing.T) {
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory("raw://"+dummyCredFileContents), spec)
assert.NilError(t, err)
if assert.Check(t, spec.Windows != nil) {
assert.Equal(t, dummyCredFileContents, spec.Windows.CredentialSpec)
}
})
t.Run("it's not case sensitive in the option names", func(t *testing.T) {
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory("CreDENtiaLSPeC=rAw://"+dummyCredFileContents), spec)
assert.NilError(t, err)
if assert.Check(t, spec.Windows != nil) {
assert.Equal(t, dummyCredFileContents, spec.Windows.CredentialSpec)
}
})
t.Run("it rejects unknown options", func(t *testing.T) {
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory("credentialspe=config://whatever"), spec)
assert.ErrorContains(t, err, "security option not supported: credentialspe")
assert.Check(t, spec.Windows == nil)
})
t.Run("it rejects unsupported credentialspec options", func(t *testing.T) {
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory("idontexist://whatever"), spec)
assert.Equal(t, errInvalidCredentialSpecSecOpt, err)
assert.Check(t, spec.Windows == nil)
})
for _, option := range []string{"file", "registry", "config", "raw"} {
t.Run(fmt.Sprintf("it rejects empty values for %s", option), func(t *testing.T) {
spec := &specs.Spec{}
err := daemon.setWindowsCredentialSpec(containerFactory(option+"://"), spec)
assert.Equal(t, errInvalidCredentialSpecSecOpt, err)
assert.Check(t, spec.Windows == nil)
})
}
}
/* Helpers below */
type dummyRegistryKey struct {
getStringValueFunc func(name string) (val string, valtype uint32, err error)
closed bool
}
func (k *dummyRegistryKey) GetStringValue(name string) (val string, valtype uint32, err error) {
return k.getStringValueFunc(name)
}
func (k *dummyRegistryKey) Close() error {
k.closed = true
return nil
}
// setRegistryOpenKeyFunc replaces the registryOpenKeyFunc package variable, and returns a function
// to be called to revert the change when done with testing.
func setRegistryOpenKeyFunc(t *testing.T, key *dummyRegistryKey, err ...error) func() {
previousRegistryOpenKeyFunc := registryOpenKeyFunc
registryOpenKeyFunc = func(baseKey registry.Key, path string, access uint32) (registryKey, error) {
// this should always be called with exactly the same arguments
assert.Equal(t, registry.LOCAL_MACHINE, baseKey)
assert.Equal(t, credentialSpecRegistryLocation, path)
assert.Equal(t, uint32(registry.QUERY_VALUE), access)
if len(err) > 0 {
return nil, err[0]
}
return key, nil
}
return func() {
registryOpenKeyFunc = previousRegistryOpenKeyFunc
}
}
|