1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
|
/* SPDX-License-Identifier: BSD-3-Clause
* Copyright(c) 2010-2014 Intel Corporation
*/
#include <stdio.h>
#include <string.h>
#include <inttypes.h>
#include <rte_ether.h>
#include <rte_string_fns.h>
#include <cmdline_parse.h>
#include <cmdline_parse_etheraddr.h>
#include "test_cmdline.h"
struct ether_addr_str {
const char * str;
uint64_t address;
};
/* valid strings */
static const struct ether_addr_str ether_addr_valid_strs[] = {
{"01:23:45:67:89:AB", 0xAB8967452301ULL},
{"4567:89AB:CDEF", 0xEFCDAB896745ULL},
};
/* valid strings with various garbage at the end.
* these strings are still valid because parser checks for
* end of token, which is either space chars, null char or
* a hash sign.
*/
static const char * const ether_addr_garbage_strs[] = {
"00:11:22:33:44:55\0garbage",
"00:11:22:33:44:55#garbage",
"00:11:22:33:44:55 garbage",
"00:11:22:33:44:55\tgarbage",
"00:11:22:33:44:55\ngarbage",
"00:11:22:33:44:55\rgarbage",
"00:11:22:33:44:55#",
"00:11:22:33:44:55 ",
"00:11:22:33:44:55\t",
"00:11:22:33:44:55\n",
"00:11:22:33:44:55\r",
};
#define GARBAGE_ETHERADDR 0x554433221100ULL /* corresponding address */
static const char * const ether_addr_invalid_strs[] = {
/* valid chars, invalid syntax */
"0123:45:67:89:AB",
"01:23:4567:89:AB",
"01:23:45:67:89AB",
"012:345:678:9AB",
"01:23:45:67:89:ABC",
"01:23:45:67:89",
"01:23:45:67:89:AB:CD",
/* invalid chars, valid syntax */
"IN:VA:LI:DC:HA:RS",
"INVA:LIDC:HARS",
/* misc */
"01 23 45 67 89 AB",
"01,23,45,67,89,AB",
"01:23:45\0:67:89:AB",
"01:23:45#:67:89:AB",
"random invalid text",
"random text",
"",
"\0",
" ",
};
static int
is_addr_different(const struct rte_ether_addr addr, uint64_t num)
{
int i;
for (i = 0; i < RTE_ETHER_ADDR_LEN; i++, num >>= 8)
if (addr.addr_bytes[i] != (num & 0xFF)) {
return 1;
}
return 0;
}
/* test invalid parameters */
int
test_parse_etheraddr_invalid_param(void)
{
char buf[CMDLINE_TEST_BUFSIZE];
struct rte_ether_addr result;
int ret = 0;
/* try all null */
ret = cmdline_parse_etheraddr(NULL, NULL, NULL, 0);
if (ret != -1) {
printf("Error: parser accepted null parameters!\n");
return -1;
}
/* try null buf */
ret = cmdline_parse_etheraddr(NULL, NULL, (void*)&result,
sizeof(result));
if (ret != -1) {
printf("Error: parser accepted null string!\n");
return -1;
}
/* try null result */
/* copy string to buffer */
strlcpy(buf, ether_addr_valid_strs[0].str, sizeof(buf));
ret = cmdline_parse_etheraddr(NULL, buf, NULL, 0);
if (ret == -1) {
printf("Error: parser rejected null result!\n");
return -1;
}
/* token is not used in ether_parse anyway so there's no point in
* testing it */
/* test help function */
memset(&buf, 0, sizeof(buf));
/* coverage! */
ret = cmdline_get_help_etheraddr(NULL, buf, sizeof(buf));
if (ret < 0) {
printf("Error: help function failed with valid parameters!\n");
return -1;
}
return 0;
}
/* test valid parameters but invalid data */
int
test_parse_etheraddr_invalid_data(void)
{
int ret = 0;
unsigned i;
struct rte_ether_addr result;
/* test full strings */
for (i = 0; i < RTE_DIM(ether_addr_invalid_strs); i++) {
memset(&result, 0, sizeof(struct rte_ether_addr));
ret = cmdline_parse_etheraddr(NULL, ether_addr_invalid_strs[i],
(void*)&result, sizeof(result));
if (ret != -1) {
printf("Error: parsing %s succeeded!\n",
ether_addr_invalid_strs[i]);
return -1;
}
}
return 0;
}
/* test valid parameters and data */
int
test_parse_etheraddr_valid(void)
{
int ret = 0;
unsigned i;
struct rte_ether_addr result;
/* test full strings */
for (i = 0; i < RTE_DIM(ether_addr_valid_strs); i++) {
memset(&result, 0, sizeof(struct rte_ether_addr));
ret = cmdline_parse_etheraddr(NULL, ether_addr_valid_strs[i].str,
(void*)&result, sizeof(result));
if (ret < 0) {
printf("Error: parsing %s failed!\n",
ether_addr_valid_strs[i].str);
return -1;
}
if (is_addr_different(result, ether_addr_valid_strs[i].address)) {
printf("Error: parsing %s failed: address mismatch!\n",
ether_addr_valid_strs[i].str);
return -1;
}
}
/* test garbage strings */
for (i = 0; i < RTE_DIM(ether_addr_garbage_strs); i++) {
memset(&result, 0, sizeof(struct rte_ether_addr));
ret = cmdline_parse_etheraddr(NULL, ether_addr_garbage_strs[i],
(void*)&result, sizeof(result));
if (ret < 0) {
printf("Error: parsing %s failed!\n",
ether_addr_garbage_strs[i]);
return -1;
}
if (is_addr_different(result, GARBAGE_ETHERADDR)) {
printf("Error: parsing %s failed: address mismatch!\n",
ether_addr_garbage_strs[i]);
return -1;
}
}
return 0;
}
|
