1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690
|
# test_line_ending.py -- Tests for the line ending functions
# Copyright (C) 2018-2019 Boris Feld <boris.feld@comet.ml>
#
# SPDX-License-Identifier: Apache-2.0 OR GPL-2.0-or-later
# Dulwich is dual-licensed under the Apache License, Version 2.0 and the GNU
# General Public License as published by the Free Software Foundation; version 2.0
# or (at your option) any later version. You can redistribute it and/or
# modify it under the terms of either of these two licenses.
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# You should have received a copy of the licenses; if not, see
# <http://www.gnu.org/licenses/> for a copy of the GNU General Public License
# and <http://www.apache.org/licenses/LICENSE-2.0> for a copy of the Apache
# License, Version 2.0.
#
"""Tests for the line ending conversion."""
from dulwich.line_ending import (
BlobNormalizer,
LineEndingFilter,
TreeBlobNormalizer,
check_safecrlf,
convert_crlf_to_lf,
convert_lf_to_crlf,
get_clean_filter_autocrlf,
get_smudge_filter_autocrlf,
normalize_blob,
)
from dulwich.objects import Blob
from . import TestCase
class LineEndingConversion(TestCase):
"""Test the line ending conversion functions in various cases."""
def test_convert_crlf_to_lf_no_op(self) -> None:
self.assertEqual(convert_crlf_to_lf(b"foobar"), b"foobar")
def test_convert_crlf_to_lf(self) -> None:
self.assertEqual(convert_crlf_to_lf(b"line1\r\nline2"), b"line1\nline2")
def test_convert_crlf_to_lf_mixed(self) -> None:
self.assertEqual(convert_crlf_to_lf(b"line1\r\n\nline2"), b"line1\n\nline2")
def test_convert_lf_to_crlf_no_op(self) -> None:
self.assertEqual(convert_lf_to_crlf(b"foobar"), b"foobar")
def test_convert_lf_to_crlf(self) -> None:
self.assertEqual(convert_lf_to_crlf(b"line1\nline2"), b"line1\r\nline2")
def test_convert_lf_to_crlf_mixed(self) -> None:
self.assertEqual(convert_lf_to_crlf(b"line1\r\n\nline2"), b"line1\r\n\r\nline2")
class GetLineEndingAutocrlfFilters(TestCase):
def test_get_clean_filter_autocrlf_default(self) -> None:
clean_filter = get_clean_filter_autocrlf(b"false")
self.assertEqual(clean_filter, None)
def test_get_clean_filter_autocrlf_true(self) -> None:
clean_filter = get_clean_filter_autocrlf(b"true")
self.assertEqual(clean_filter, convert_crlf_to_lf)
def test_get_clean_filter_autocrlf_input(self) -> None:
clean_filter = get_clean_filter_autocrlf(b"input")
self.assertEqual(clean_filter, convert_crlf_to_lf)
def test_get_smudge_filter_autocrlf_default(self) -> None:
smudge_filter = get_smudge_filter_autocrlf(b"false")
self.assertEqual(smudge_filter, None)
def test_get_smudge_filter_autocrlf_true(self) -> None:
smudge_filter = get_smudge_filter_autocrlf(b"true")
self.assertEqual(smudge_filter, convert_lf_to_crlf)
def test_get_smudge_filter_autocrlf_input(self) -> None:
smudge_filter = get_smudge_filter_autocrlf(b"input")
self.assertEqual(smudge_filter, None)
class NormalizeBlobTestCase(TestCase):
def test_normalize_to_lf_no_op(self) -> None:
base_content = b"line1\nline2"
base_sha = "f8be7bb828880727816015d21abcbc37d033f233"
base_blob = Blob()
base_blob.set_raw_string(base_content)
self.assertEqual(base_blob.as_raw_chunks(), [base_content])
self.assertEqual(base_blob.sha().hexdigest(), base_sha)
filtered_blob = normalize_blob(
base_blob, convert_crlf_to_lf, binary_detection=False
)
self.assertEqual(filtered_blob.as_raw_chunks(), [base_content])
self.assertEqual(filtered_blob.sha().hexdigest(), base_sha)
def test_normalize_to_lf(self) -> None:
base_content = b"line1\r\nline2"
base_sha = "3a1bd7a52799fe5cf6411f1d35f4c10bacb1db96"
base_blob = Blob()
base_blob.set_raw_string(base_content)
self.assertEqual(base_blob.as_raw_chunks(), [base_content])
self.assertEqual(base_blob.sha().hexdigest(), base_sha)
filtered_blob = normalize_blob(
base_blob, convert_crlf_to_lf, binary_detection=False
)
normalized_content = b"line1\nline2"
normalized_sha = "f8be7bb828880727816015d21abcbc37d033f233"
self.assertEqual(filtered_blob.as_raw_chunks(), [normalized_content])
self.assertEqual(filtered_blob.sha().hexdigest(), normalized_sha)
def test_normalize_to_lf_binary(self) -> None:
base_content = b"line1\r\nline2\0"
base_sha = "b44504193b765f7cd79673812de8afb55b372ab2"
base_blob = Blob()
base_blob.set_raw_string(base_content)
self.assertEqual(base_blob.as_raw_chunks(), [base_content])
self.assertEqual(base_blob.sha().hexdigest(), base_sha)
filtered_blob = normalize_blob(
base_blob, convert_crlf_to_lf, binary_detection=True
)
self.assertEqual(filtered_blob.as_raw_chunks(), [base_content])
self.assertEqual(filtered_blob.sha().hexdigest(), base_sha)
def test_normalize_to_crlf_no_op(self) -> None:
base_content = b"line1\r\nline2"
base_sha = "3a1bd7a52799fe5cf6411f1d35f4c10bacb1db96"
base_blob = Blob()
base_blob.set_raw_string(base_content)
self.assertEqual(base_blob.as_raw_chunks(), [base_content])
self.assertEqual(base_blob.sha().hexdigest(), base_sha)
filtered_blob = normalize_blob(
base_blob, convert_lf_to_crlf, binary_detection=False
)
self.assertEqual(filtered_blob.as_raw_chunks(), [base_content])
self.assertEqual(filtered_blob.sha().hexdigest(), base_sha)
def test_normalize_to_crlf(self) -> None:
base_content = b"line1\nline2"
base_sha = "f8be7bb828880727816015d21abcbc37d033f233"
base_blob = Blob()
base_blob.set_raw_string(base_content)
self.assertEqual(base_blob.as_raw_chunks(), [base_content])
self.assertEqual(base_blob.sha().hexdigest(), base_sha)
filtered_blob = normalize_blob(
base_blob, convert_lf_to_crlf, binary_detection=False
)
normalized_content = b"line1\r\nline2"
normalized_sha = "3a1bd7a52799fe5cf6411f1d35f4c10bacb1db96"
self.assertEqual(filtered_blob.as_raw_chunks(), [normalized_content])
self.assertEqual(filtered_blob.sha().hexdigest(), normalized_sha)
def test_normalize_to_crlf_binary(self) -> None:
base_content = b"line1\r\nline2\0"
base_sha = "b44504193b765f7cd79673812de8afb55b372ab2"
base_blob = Blob()
base_blob.set_raw_string(base_content)
self.assertEqual(base_blob.as_raw_chunks(), [base_content])
self.assertEqual(base_blob.sha().hexdigest(), base_sha)
filtered_blob = normalize_blob(
base_blob, convert_lf_to_crlf, binary_detection=True
)
self.assertEqual(filtered_blob.as_raw_chunks(), [base_content])
self.assertEqual(filtered_blob.sha().hexdigest(), base_sha)
class LineEndingFilterTests(TestCase):
"""Test the LineEndingFilter class."""
def test_clean_no_conversion(self) -> None:
"""Test clean with no conversion function."""
filter = LineEndingFilter()
data = b"test\r\ndata"
self.assertEqual(filter.clean(data), data)
def test_clean_with_conversion(self) -> None:
"""Test clean with CRLF to LF conversion."""
filter = LineEndingFilter(clean_conversion=convert_crlf_to_lf)
data = b"test\r\ndata"
self.assertEqual(filter.clean(data), b"test\ndata")
def test_clean_binary_detection(self) -> None:
"""Test clean skips binary files."""
filter = LineEndingFilter(
clean_conversion=convert_crlf_to_lf, binary_detection=True
)
# Binary data with null byte
data = b"test\r\n\x00data"
self.assertEqual(filter.clean(data), data) # Should not convert
def test_smudge_no_conversion(self) -> None:
"""Test smudge with no conversion function."""
filter = LineEndingFilter()
data = b"test\ndata"
self.assertEqual(filter.smudge(data), data)
def test_smudge_with_conversion(self) -> None:
"""Test smudge with LF to CRLF conversion."""
filter = LineEndingFilter(smudge_conversion=convert_lf_to_crlf)
data = b"test\ndata"
self.assertEqual(filter.smudge(data), b"test\r\ndata")
def test_smudge_binary_detection(self) -> None:
"""Test smudge skips binary files."""
filter = LineEndingFilter(
smudge_conversion=convert_lf_to_crlf, binary_detection=True
)
# Binary data with null byte
data = b"test\n\x00data"
self.assertEqual(filter.smudge(data), data) # Should not convert
class BlobNormalizerTests(TestCase):
"""Test the BlobNormalizer class integration with filters."""
def setUp(self) -> None:
super().setUp()
from dulwich.config import ConfigDict
self.config = ConfigDict()
self.gitattributes = {}
def test_autocrlf_true_checkin(self) -> None:
"""Test checkin with autocrlf=true."""
normalizer = BlobNormalizer(self.config, self.gitattributes, autocrlf=b"true")
# Create blob with CRLF
blob = Blob()
blob.data = b"line1\r\nline2\r\n"
# Should convert to LF on checkin
result = normalizer.checkin_normalize(blob, b"test.txt")
self.assertEqual(result.data, b"line1\nline2\n")
def test_autocrlf_true_checkout(self) -> None:
"""Test checkout with autocrlf=true."""
normalizer = BlobNormalizer(self.config, self.gitattributes, autocrlf=b"true")
# Create blob with LF
blob = Blob()
blob.data = b"line1\nline2\n"
# Should convert to CRLF on checkout
result = normalizer.checkout_normalize(blob, b"test.txt")
self.assertEqual(result.data, b"line1\r\nline2\r\n")
def test_autocrlf_input_checkin(self) -> None:
"""Test checkin with autocrlf=input."""
normalizer = BlobNormalizer(self.config, self.gitattributes, autocrlf=b"input")
# Create blob with CRLF
blob = Blob()
blob.data = b"line1\r\nline2\r\n"
# Should convert to LF on checkin
result = normalizer.checkin_normalize(blob, b"test.txt")
self.assertEqual(result.data, b"line1\nline2\n")
def test_autocrlf_input_checkout(self) -> None:
"""Test checkout with autocrlf=input."""
normalizer = BlobNormalizer(self.config, self.gitattributes, autocrlf=b"input")
# Create blob with LF
blob = Blob()
blob.data = b"line1\nline2\n"
# Should NOT convert on checkout with input mode
result = normalizer.checkout_normalize(blob, b"test.txt")
self.assertIs(result, blob) # Same object, no conversion
def test_autocrlf_false(self) -> None:
"""Test with autocrlf=false (no conversion)."""
normalizer = BlobNormalizer(self.config, self.gitattributes, autocrlf=b"false")
# Create blob with mixed line endings
blob = Blob()
blob.data = b"line1\r\nline2\nline3"
# Should not convert on either operation
result = normalizer.checkin_normalize(blob, b"test.txt")
self.assertIs(result, blob)
result = normalizer.checkout_normalize(blob, b"test.txt")
self.assertIs(result, blob)
def test_gitattributes_text_attr(self) -> None:
"""Test gitattributes text attribute overrides autocrlf."""
# Set gitattributes to force text conversion
self.gitattributes[b"*.txt"] = {b"text": True}
# Even with autocrlf=false, should convert based on gitattributes
normalizer = BlobNormalizer(self.config, self.gitattributes, autocrlf=b"false")
blob = Blob()
blob.data = b"line1\r\nline2\r\n"
# Should still convert because of gitattributes
result = normalizer.checkin_normalize(blob, b"test.txt")
# Note: with just text=true and no eol setting, it follows platform defaults
# For checkin, it should always normalize to LF
self.assertIsNot(result, blob)
def test_gitattributes_binary_attr(self) -> None:
"""Test gitattributes -text attribute prevents conversion."""
# Set gitattributes to force binary (no conversion)
self.gitattributes[b"*.bin"] = {b"text": False}
normalizer = BlobNormalizer(self.config, self.gitattributes, autocrlf=b"true")
blob = Blob()
blob.data = b"line1\r\nline2\r\n"
# Should not convert despite autocrlf=true
result = normalizer.checkin_normalize(blob, b"test.bin")
self.assertIs(result, blob)
def test_binary_file_detection(self) -> None:
"""Test that binary files are not converted."""
normalizer = BlobNormalizer(self.config, self.gitattributes, autocrlf=b"true")
# Create blob with binary content
blob = Blob()
blob.data = b"line1\r\n\x00\xffbinary\r\ndata"
# Should not convert binary files
result = normalizer.checkin_normalize(blob, b"binary.dat")
self.assertIs(result, blob)
result = normalizer.checkout_normalize(blob, b"binary.dat")
self.assertIs(result, blob)
class TreeBlobNormalizerTests(TestCase):
"""Test the TreeBlobNormalizer class for existing file handling."""
def setUp(self) -> None:
super().setUp()
from dulwich.config import ConfigDict
from dulwich.object_store import MemoryObjectStore
self.config = ConfigDict()
self.gitattributes = {}
self.object_store = MemoryObjectStore()
def test_autocrlf_input_existing_files(self) -> None:
"""Test that autocrlf=input normalizes existing files with CRLF."""
# Create a tree with an existing file
from dulwich.objects import Tree
tree = Tree()
tree[b"existing.txt"] = (0o100644, b"a" * 40) # dummy sha
self.object_store.add_object(tree)
# Create normalizer with autocrlf=input
normalizer = TreeBlobNormalizer(
self.config,
self.gitattributes,
self.object_store,
tree.id,
autocrlf=b"input",
)
# Create blob with CRLF line endings
blob = Blob()
blob.data = b"line1\r\nline2\r\n"
# Should convert CRLF to LF on checkin even for existing files
result = normalizer.checkin_normalize(blob, b"existing.txt")
self.assertEqual(result.data, b"line1\nline2\n")
def test_autocrlf_false_existing_files(self) -> None:
"""Test that autocrlf=false does not normalize existing files."""
# Create a tree with an existing file
from dulwich.objects import Tree
tree = Tree()
tree[b"existing.txt"] = (0o100644, b"a" * 40) # dummy sha
self.object_store.add_object(tree)
# Create normalizer with autocrlf=false
normalizer = TreeBlobNormalizer(
self.config,
self.gitattributes,
self.object_store,
tree.id,
autocrlf=b"false",
)
# Create blob with CRLF line endings
blob = Blob()
blob.data = b"line1\r\nline2\r\n"
# Should NOT convert for existing files when autocrlf=false
result = normalizer.checkin_normalize(blob, b"existing.txt")
self.assertIs(result, blob)
def test_autocrlf_input_new_files(self) -> None:
"""Test that autocrlf=input normalizes new files."""
# Create empty tree (no existing files)
from dulwich.objects import Tree
tree = Tree()
self.object_store.add_object(tree)
# Create normalizer with autocrlf=input
normalizer = TreeBlobNormalizer(
self.config,
self.gitattributes,
self.object_store,
tree.id,
autocrlf=b"input",
)
# Create blob with CRLF line endings
blob = Blob()
blob.data = b"line1\r\nline2\r\n"
# Should convert CRLF to LF for new files
result = normalizer.checkin_normalize(blob, b"new.txt")
self.assertEqual(result.data, b"line1\nline2\n")
class LineEndingIntegrationTests(TestCase):
"""Integration tests for line ending conversion with the filter system."""
def setUp(self) -> None:
super().setUp()
from dulwich.config import ConfigDict
from dulwich.filters import FilterRegistry
self.config = ConfigDict()
self.registry = FilterRegistry(self.config)
def test_filter_registry_with_line_endings(self) -> None:
"""Test that line ending filters work through the registry."""
# Register a custom text filter that does line ending conversion
filter = LineEndingFilter(
clean_conversion=convert_crlf_to_lf,
smudge_conversion=convert_lf_to_crlf,
binary_detection=True,
)
self.registry.register_driver("text", filter)
# Set up gitattributes
# Create GitAttributes
from dulwich.attrs import GitAttributes, Pattern
patterns = [(Pattern(b"*.txt"), {b"filter": b"text"})]
gitattributes = GitAttributes(patterns)
# Create normalizer
from dulwich.filters import FilterBlobNormalizer, FilterContext
filter_context = FilterContext(self.registry)
normalizer = FilterBlobNormalizer(
self.config, gitattributes, filter_context=filter_context
)
# Test round trip
blob = Blob()
blob.data = b"Hello\r\nWorld\r\n"
# Checkin should convert CRLF to LF
checked_in = normalizer.checkin_normalize(blob, b"test.txt")
self.assertEqual(checked_in.data, b"Hello\nWorld\n")
# Checkout should convert LF to CRLF
checked_out = normalizer.checkout_normalize(checked_in, b"test.txt")
self.assertEqual(checked_out.data, b"Hello\r\nWorld\r\n")
def test_mixed_filters(self) -> None:
"""Test multiple filters can coexist (line endings and LFS)."""
# This would be a more complex test requiring LFS setup
# For now, just verify the structure works
text_filter = LineEndingFilter(
clean_conversion=convert_crlf_to_lf,
smudge_conversion=convert_lf_to_crlf,
)
self.registry.register_driver("text", text_filter)
# Mock LFS filter
class MockLFSFilter:
def clean(self, data):
return b"LFS pointer"
def smudge(self, data):
return b"LFS content"
def cleanup(self):
pass
def reuse(self, config, filter_name):
return False
self.registry.register_driver("lfs", MockLFSFilter())
# Different files use different filters
from dulwich.attrs import GitAttributes, Pattern
patterns = [
(Pattern(b"*.txt"), {b"filter": b"text"}),
(Pattern(b"*.bin"), {b"filter": b"lfs"}),
]
gitattributes = GitAttributes(patterns)
from dulwich.filters import FilterBlobNormalizer, FilterContext
filter_context = FilterContext(self.registry)
normalizer = FilterBlobNormalizer(
self.config, gitattributes, filter_context=filter_context
)
# Text file gets line ending conversion
text_blob = Blob()
text_blob.data = b"text\r\nfile"
result = normalizer.checkin_normalize(text_blob, b"test.txt")
self.assertEqual(result.data, b"text\nfile")
# Binary file gets LFS conversion
bin_blob = Blob()
bin_blob.data = b"binary content"
result = normalizer.checkin_normalize(bin_blob, b"test.bin")
self.assertEqual(result.data, b"LFS pointer")
class LineEndingFilterFromConfigTests(TestCase):
"""Test LineEndingFilter.from_config classmethod."""
def test_from_config_none(self) -> None:
"""Test from_config with no config."""
# No config, not for text attr - no conversion
filter = LineEndingFilter.from_config(None, for_text_attr=False)
self.assertIsNone(filter.clean_conversion)
self.assertIsNone(filter.smudge_conversion)
self.assertEqual(filter.safecrlf, b"false")
# No config, for text attr - normalize on checkin
filter = LineEndingFilter.from_config(None, for_text_attr=True)
self.assertIsNotNone(filter.clean_conversion)
self.assertIsNone(filter.smudge_conversion)
self.assertEqual(filter.safecrlf, b"false")
def test_from_config_autocrlf_true(self) -> None:
"""Test from_config with autocrlf=true."""
from dulwich.config import ConfigDict
config = ConfigDict()
config.set(b"core", b"autocrlf", b"true")
filter = LineEndingFilter.from_config(config, for_text_attr=False)
self.assertIsNotNone(filter.clean_conversion)
self.assertIsNotNone(filter.smudge_conversion)
self.assertEqual(filter.safecrlf, b"false")
def test_from_config_with_safecrlf(self) -> None:
"""Test from_config with safecrlf setting."""
from dulwich.config import ConfigDict
config = ConfigDict()
config.set(b"core", b"autocrlf", b"input")
config.set(b"core", b"safecrlf", b"warn")
filter = LineEndingFilter.from_config(config, for_text_attr=False)
self.assertIsNotNone(filter.clean_conversion)
self.assertIsNone(filter.smudge_conversion)
self.assertEqual(filter.safecrlf, b"warn")
def test_from_config_text_attr_overrides(self) -> None:
"""Test that for_text_attr=True always normalizes on checkin."""
from dulwich.config import ConfigDict
config = ConfigDict()
config.set(b"core", b"autocrlf", b"false")
# Even with autocrlf=false, text attr should normalize
filter = LineEndingFilter.from_config(config, for_text_attr=True)
self.assertIsNotNone(filter.clean_conversion)
# Smudge should still be None since autocrlf=false
self.assertIsNone(filter.smudge_conversion)
class SafeCRLFTests(TestCase):
"""Test core.safecrlf functionality."""
def test_safecrlf_false(self) -> None:
"""Test that safecrlf=false allows any conversion."""
original = b"line1\r\nline2\r\n"
converted = b"line1\nline2\n"
# Should not raise
check_safecrlf(original, converted, b"false", b"test.txt")
def test_safecrlf_true_safe_conversion(self) -> None:
"""Test that safecrlf=true allows safe conversions."""
# CRLF -> LF -> CRLF is reversible
original = b"line1\r\nline2\r\n"
converted = b"line1\nline2\n"
# Should not raise because conversion is reversible
check_safecrlf(original, converted, b"true", b"test.txt")
def test_safecrlf_true_unsafe_conversion(self) -> None:
"""Test that safecrlf=true fails on unsafe conversions."""
# Mixed line endings would be lost
original = b"line1\r\nline2\nline3\r\n"
converted = b"line1\nline2\nline3\n"
# Should raise because converting back gives all CRLF
with self.assertRaises(ValueError) as cm:
check_safecrlf(original, converted, b"true", b"test.txt")
self.assertIn("CRLF would be replaced by LF", str(cm.exception))
def test_safecrlf_warn(self) -> None:
"""Test that safecrlf=warn issues warnings."""
# Mixed line endings would be lost
original = b"line1\r\nline2\nline3\r\n"
converted = b"line1\nline2\nline3\n"
# Should warn but not raise
with self.assertLogs("dulwich.line_ending", level="WARNING") as cm:
check_safecrlf(original, converted, b"warn", b"test.txt")
self.assertEqual(len(cm.output), 1)
self.assertIn("CRLF would be replaced by LF", cm.output[0])
def test_lineending_filter_with_safecrlf(self) -> None:
"""Test LineEndingFilter with safecrlf enabled."""
# Test with safecrlf=true
filter_strict = LineEndingFilter(
clean_conversion=convert_crlf_to_lf,
smudge_conversion=None,
binary_detection=False,
safecrlf=b"true",
)
# Safe conversion should work
safe_data = b"line1\r\nline2\r\n"
result = filter_strict.clean(safe_data, b"test.txt")
self.assertEqual(result, b"line1\nline2\n")
# Unsafe conversion should fail
unsafe_data = b"line1\r\nline2\nline3\r\n"
with self.assertRaises(ValueError):
filter_strict.clean(unsafe_data, b"test.txt")
# Test with safecrlf=warn
filter_warn = LineEndingFilter(
clean_conversion=convert_crlf_to_lf,
smudge_conversion=None,
binary_detection=False,
safecrlf=b"warn",
)
# Should warn but still convert
with self.assertLogs("dulwich.line_ending", level="WARNING") as cm:
result = filter_warn.clean(unsafe_data, b"test.txt")
self.assertEqual(result, b"line1\nline2\nline3\n")
self.assertEqual(len(cm.output), 1)
|